high_freq_hwp_cap_cppc.c: new test
PATCH v2 1/1 high_freq_hwp_cap_cppc.c: new test
Verify for all online logical CPUs that their highest performance value are the same for HWP Capability MSR 0x771 and CPPC sysfs file.
--- testcases/kernel/power_management/.gitignore | 1 + .../power_management/high_freq_hwp_cap_cppc.c | 66 +++++++++++++++++++ 2 files changed, 67 insertions(+) create mode 100644 testcases/kernel/power_management/high_freq_hwp_cap_cppc.c
testcases/kernel/power_management/.gitignore +1 -0
@@ -1 +1,2 @@ +high_freq_hwp_cap_cppc pm_get_sched_values
testcases/kernel/power_management/high_freq_hwp_cap_cppc.c new file +66 -0
66 lines not on this page · raw message
Signature · 13 lines
2.47.3 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited. -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 7 lines
Verify for all online logical CPUs that their highest performance value are the same for HWP Capability MSR
0x771and CPPC sysfs file.Signed-off-by Piotr Kubaj <[email protected]>--- testcases/kernel/power_management/.gitignore | 1 + .../power_management/high_freq_hwp_cap_cppc.c | 66 +++++++++++++++++++
As I wrote in v1, any tests needs to be added into runtest file, runtest/power_management_tests in this case.
Quoted 2 lines
2 files changed, 67 insertions(+) create mode 100644 testcases/kernel/power_management/high_freq_hwp_cap_cppc.c
...
Quoted 7 lines
testcases/kernel/power_management/high_freq_hwp_cap_cppc.c new file +7
-0+static void run (void ) +{ +bool status = true; + +for (int i =0 ; i < nproc; i++) { +char path[PATH_MAX ]; +unsigned long long msr_highest_perf =0 , sysfs_highest_perf =0 ;
testcases/kernel/power_management/high_freq_hwp_cap_cppc.c line 38
Quoted 10 lines
testcases/kernel/power_management/high_freq_hwp_cap_cppc.c new file +10
-0+ +snprintf (path,sizeof (path),"/sys/devices/system/cpu/cpu%d/acpi_cppc/highest_perf" , i); +SAFE_FILE_SCANF (path,"%llu" , &sysfs_highest_perf); +tst_res (TDEBUG ,"%s: %llu" , path, sysfs_highest_perf); + +snprintf (path,sizeof (path),"/dev/cpu/%d/msr" , i); +int fd =SAFE_OPEN (path,O_RDONLY ); + +if (SAFE_PREAD (1 , fd, &msr_highest_perf,sizeof (msr_highest_perf),0x771 ) ==-1 ) +tst_brk (TBROK |TERRNO ,"MSR read error" );
SAFE_*() functions contain error check, tst_brk() is redundant.
testcases/kernel/power_management/high_freq_hwp_cap_cppc.c line 49
Quoted 11 lines
testcases/kernel/power_management/high_freq_hwp_cap_cppc.c new file +11
-0+ msr_highest_perf &= (1ULL <<8 ) -1 ; +tst_res (TDEBUG ,"%s: %llu" , path, msr_highest_perf); + +if (msr_highest_perf != sysfs_highest_perf) + status = false; + } + +if (status) +tst_res (TPASS ,"Sysfs and MSR values are equal" ); +else +tst_res (TFAIL ,"Highest performance values differ between sysfs and MSR" );
I would print TFAIL in the for loop with CPU ID and both values. And here print only final TPASS.
testcases/kernel/power_management/high_freq_hwp_cap_cppc.c line 55
Quoted 6 lines
testcases/kernel/power_management/high_freq_hwp_cap_cppc.c new file +6
-0+} + +static struct tst_test test = { + .needs_kconfigs = (const char *const []) { +"CONFIG_ACPI_CPPC_LIB" , +"CONFIG_X86_MSR" ,
Also even on this version I have:
high_freq_hwp_cap_cppc.c:31: TBROK: Failed to open FILE '/sys/devices/system/cpu/cpu0/acpi_cppc/highest_perf' for reading: ENOENT (2)
on 6.18 kernel even I run modprobe msr
$ grep -e CONFIG_X86_MSR -e CONFIG_ACPI_CPPC_LIB /boot/config-6.18.* CONFIG_X86_MSR=m CONFIG_ACPI_CPPC_LIB=y
OTOH on 7.0.0-rc2 with the same config values autoloading worked.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp