Skip to contentSkip to conversation

Funxi: Fix and extend SPL power LED support

PATCH In review Andre Przywara 3 participants 8 messages Apr 29

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover Funxi: Fix and extend SPL power LED support

Hi,

just an update after some discussion on the list (thanks to Paul and Quentin for having a look!), changing the naming of the Kconfig symbols, since their meaning wasn't clear. Changelog below.

================
With the demise of the legacy SPL LED framework a new, much simpler version emerged for Allwinner SoCs: Just define the GPIO number in Kconfig, and some simple code turns the LED on very early.

I was looking at using this feature for boards with a GPIO controlled power LED, as having a sign of life very early can be very handy. So I grep'ed all DTs for those LEDs, and added the respective symbols to the board's defconfig file.
Doing so revealed a small bug in the code when using active low LEDs, so patch 1/3 fixes this.
Patch 2/3 adds the power LEDs to 32-bit boards, patch 3/3 to 64-bit boards - just some arbitrary splitup to simplify review.

Please have a look and test if you have any of the boards.

Cheers,
Andre

Changelog v1 ... v2:
- rename Kconfig symbols to better match their meaning
- default to ACTIVE_HIGH=y

Andre Przywara (3):
sunxi: spl: fix SPL_SUNXI_LED active low configuration
sunxi: configs: enable power LEDs on 32-bit boards
sunxi: configs: enable power LEDs on 64-bit boards

 arch/arm/mach-sunxi/Kconfig              | 10 ++++++----
 board/sunxi/board.c                      |  4 ++--
 configs/A13-OLinuXinoM_defconfig         |  2 ++
 configs/Bananapi_M2_Ultra_defconfig      |  2 ++
 configs/Bananapi_m2m_defconfig           |  3 +++
 configs/Mele_A1000G_quad_defconfig       |  2 ++
 configs/Mele_A1000_defconfig             |  2 ++
 configs/Mele_M9_defconfig                |  2 ++
 configs/anbernic_rg35xx_h700_defconfig   |  2 ++
 configs/bananapi_m1_plus_defconfig       |  2 ++
 configs/bananapi_m2_berry_defconfig      |  2 ++
 configs/bananapi_m2_zero_defconfig       |  3 +++
 configs/bananapi_m64_defconfig           |  2 ++
 configs/beelink_gs1_defconfig            |  2 ++
 configs/beelink_x2_defconfig             |  2 ++
 configs/icnova-a20-adb4006_defconfig     |  2 ++
 configs/liontron-h-a133l_defconfig       |  3 +++
 configs/nanopi_duo2_defconfig            |  2 ++
 configs/nanopi_neo2_defconfig            |  2 ++
 configs/nanopi_neo_air_defconfig         |  2 ++
 configs/nanopi_neo_plus2_defconfig       |  2 ++
 configs/orangepi_2_defconfig             |  2 ++
 configs/orangepi_3_defconfig             |  2 ++
 configs/orangepi_lite2_defconfig         |  2 ++
 configs/orangepi_lite_defconfig          |  2 ++
 configs/orangepi_one_defconfig           |  2 ++
 configs/orangepi_pc2_defconfig           |  2 ++
 configs/orangepi_pc_defconfig            |  2 ++
 configs/orangepi_prime_defconfig         |  2 ++
 configs/orangepi_zero2_defconfig         |  2 ++
 configs/orangepi_zero_defconfig          |  2 ++
 configs/orangepi_zero_plus2_defconfig    |  2 ++
 configs/orangepi_zero_plus2_h3_defconfig |  2 ++
 configs/orangepi_zero_plus_defconfig     |  2 ++
 configs/pinephone_defconfig              |  3 +--
 configs/radxa-cubie-a5e_defconfig        |  3 +++
 configs/tanix_tx1_defconfig              |  2 ++
 37 files changed, 81 insertions(+), 8 deletions(-)
Signature · 1 line
2.43.0
#1 lore raw

PATCH v2 1/3 sunxi: spl: fix SPL_SUNXI_LED active low configuration

The newly introduced Allwinner SPL LED "framework" defined a SPL_SUNXI_LED_STATUS_STATE Kconfig symbol, that was supposed to denote the active-low vs. active-high polarity of the LED. However this is a bool symbol, so it will simply vanish if not defined, and we cannot use it directly inside a C statement.

Filter the symbol through the IS_ENABLED() macro, which will return 0 if the symbol is not defined, which is the intended value here.

Since the STATUS_STATE name is a bit confusing, rename it to ACTIVE_HIGH on the way, because that is its real meaning. Also the LED_STATUS_BIT name for the GPIO number is similarly a remnant of the old status LED code, so rename it to LED_STATUS_GPIO as well.

This fixes configuring LEDs with active-low polarity.

Fixes 256557dd9aae ("sunxi: remove usage of legacy LED API")
---
 arch/arm/mach-sunxi/Kconfig | 10 ++++++----
 board/sunxi/board.c         |  4 ++--
 configs/pinephone_defconfig |  3 +--
 3 files changed, 9 insertions(+), 8 deletions(-)
arch/arm/mach-sunxi/Kconfig +6 -4
index 89f0e77bcdb..07d7ea2b7ad 100644
@@ -1245,15 +1245,17 @@ config SPL_SUNXI_LED_STATUS
 
 if SPL_SUNXI_LED_STATUS
 
-config SPL_SUNXI_LED_STATUS_BIT
+config SPL_SUNXI_LED_STATUS_GPIO
 	int "GPIO number for GPIO status LED"
 	help
 	  GPIO number for the GPIO controlling the GPIO status LED in SPL.
 
-config SPL_SUNXI_LED_STATUS_STATE
-	bool "GPIO status LED initial state is on"
+config SPL_SUNXI_LED_STATUS_ACTIVE_HIGH
+	bool "GPIO status LED is active high"
+	default y
 	help
-	  Whether the initial state of the status LED in SPL must be on or off.
+	  Whether the GPIO of the status LED must be set high or low to turn
+	  the LED on.
 
 endif # SPL_SUNXI_LED_STATUS
 
board/sunxi/board.c +2 -2
index d7722d1858a..3d1afec7c66 100644
@@ -563,8 +563,8 @@ static void sunxi_spl_store_dram_size(phys_addr_t dram_size)
 static void status_led_init(void)
 {
 #if CONFIG_IS_ENABLED(SUNXI_LED_STATUS)
-	unsigned int state = CONFIG_SPL_SUNXI_LED_STATUS_STATE;
-	unsigned int gpio = CONFIG_SPL_SUNXI_LED_STATUS_BIT;
+	unsigned int state = IS_ENABLED(CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH);
+	unsigned int gpio = CONFIG_SPL_SUNXI_LED_STATUS_GPIO;
 
 	gpio_request(gpio, "gpio_led");
 	gpio_direction_output(gpio, state);
configs/pinephone_defconfig +1 -2
index ed7dbc1852b..3a4f4ec51cf 100644
@@ -9,8 +9,7 @@ CONFIG_DRAM_ZQ=3881949
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 CONFIG_PINEPHONE_DT_SELECTION=y
 CONFIG_SPL_SUNXI_LED_STATUS=y
-CONFIG_SPL_SUNXI_LED_STATUS_BIT=114
-CONFIG_SPL_SUNXI_LED_STATUS_STATE=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=114
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_CMD_PSTORE=y
 CONFIG_CMD_PSTORE_MEM_ADDR=0x61000000
Signature · 1 line
2.43.0
Acked-by on v2 1/3
#2 lore raw

Re: [PATCH v2 1/3] sunxi: spl: fix SPL_SUNXI_LED active low configuration

Hi Andre,

Quoted 9 lines · Andre Przywara

The newly introduced Allwinner SPL LED "framework" defined a SPL_SUNXI_LED_STATUS_STATE Kconfig symbol, that was supposed to denote the active-low vs. active-high polarity of the LED. However this is a bool symbol, so it will simply vanish if not defined, and we cannot use it directly inside a C statement.

Filter the symbol through the IS_ENABLED() macro, which will return 0 if the symbol is not defined, which is the intended value here.

Quoted 7 lines

Since the STATUS_STATE name is a bit confusing, rename it to ACTIVE_HIGH on the way, because that is its real meaning. Also the LED_STATUS_BIT name for the GPIO number is similarly a remnant of the old status LED code, so rename it to LED_STATUS_GPIO as well.

This fixes configuring LEDs with active-low polarity.

Individual patches would have been better.

Quoted 1 line
Fixes 256557dd9aae ("sunxi: remove usage of legacy LED API")

Thanks!
Quentin

Reviewed-by on v2 1/3
#3 lore raw

Re: [PATCH v2 1/3] sunxi: spl: fix SPL_SUNXI_LED active low configuration

In reply to Andre Przywara

Hi Andre,

Quoted 14 lines · Andre Przywara

The newly introduced Allwinner SPL LED "framework" defined a SPL_SUNXI_LED_STATUS_STATE Kconfig symbol, that was supposed to denote the active-low vs. active-high polarity of the LED. However this is a bool symbol, so it will simply vanish if not defined, and we cannot use it directly inside a C statement.

Filter the symbol through the IS_ENABLED() macro, which will return 0 if the symbol is not defined, which is the intended value here.

Since the STATUS_STATE name is a bit confusing, rename it to ACTIVE_HIGH on the way, because that is its real meaning. Also the LED_STATUS_BIT name for the GPIO number is similarly a remnant of the old status LED code, so rename it to LED_STATUS_GPIO as well.

Quoted 4 lines

This fixes configuring LEDs with active-low polarity.

Fixes 256557dd9aae ("sunxi: remove usage of legacy LED API")

Thanks for your work!

All the best,

Paul

Quoted 64 lines
---
 arch/arm/mach-sunxi/Kconfig | 10 ++++++----
 board/sunxi/board.c         |  4 ++--
 configs/pinephone_defconfig |  3 +--
 3 files changed, 9 insertions(+), 8 deletions(-)
arch/arm/mach-sunxi/Kconfig +6 -4
index 89f0e77bcdb..07d7ea2b7ad 100644
@@ -1245,15 +1245,17 @@ config SPL_SUNXI_LED_STATUS
 
 if SPL_SUNXI_LED_STATUS
 
-config SPL_SUNXI_LED_STATUS_BIT
+config SPL_SUNXI_LED_STATUS_GPIO
 	int "GPIO number for GPIO status LED"
 	help
 	  GPIO number for the GPIO controlling the GPIO status LED in SPL.
 
-config SPL_SUNXI_LED_STATUS_STATE
-	bool "GPIO status LED initial state is on"
+config SPL_SUNXI_LED_STATUS_ACTIVE_HIGH
+	bool "GPIO status LED is active high"
+	default y
 	help
-	  Whether the initial state of the status LED in SPL must be on or off.
+	  Whether the GPIO of the status LED must be set high or low to turn
+	  the LED on.
 
 endif # SPL_SUNXI_LED_STATUS
 
board/sunxi/board.c +2 -2
index d7722d1858a..3d1afec7c66 100644
@@ -563,8 +563,8 @@ static void sunxi_spl_store_dram_size(phys_addr_t dram_size)
 static void status_led_init(void)
 {
 #if CONFIG_IS_ENABLED(SUNXI_LED_STATUS)
-	unsigned int state = CONFIG_SPL_SUNXI_LED_STATUS_STATE;
-	unsigned int gpio = CONFIG_SPL_SUNXI_LED_STATUS_BIT;
+	unsigned int state = IS_ENABLED(CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH);
+	unsigned int gpio = CONFIG_SPL_SUNXI_LED_STATUS_GPIO;
 
 	gpio_request(gpio, "gpio_led");
 	gpio_direction_output(gpio, state);
configs/pinephone_defconfig +1 -2
index ed7dbc1852b..3a4f4ec51cf 100644
@@ -9,8 +9,7 @@ CONFIG_DRAM_ZQ=3881949
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 CONFIG_PINEPHONE_DT_SELECTION=y
 CONFIG_SPL_SUNXI_LED_STATUS=y
-CONFIG_SPL_SUNXI_LED_STATUS_BIT=114
-CONFIG_SPL_SUNXI_LED_STATUS_STATE=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=114
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_CMD_PSTORE=y
 CONFIG_CMD_PSTORE_MEM_ADDR=0x61000000
Signature · 1 line
2.43.0
Signature · 6 lines
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expert in multimedia, graphics and embedded hardware support with Linux.
#4 lore raw

PATCH v2 2/3 sunxi: configs: enable power LEDs on 32-bit boards

In reply to Andre Przywara

We recently gained a simple way to enable a power LED very early in the SPL boot, through simple Kconfig variables.

Add those symbols to those boards' defconfigs where the DT indicates a default-on power LED. The number used is <port bank> * 32 + <pin no>, an active low setup means CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH must be undefined. Since its default is "high", we can skip the symbol in the defconfig in this case.

This will light up the power LED very early in the (SPL) boot phase on those 32-bit boards.

---
 configs/A13-OLinuXinoM_defconfig         | 2 ++
 configs/Bananapi_M2_Ultra_defconfig      | 2 ++
 configs/Bananapi_m2m_defconfig           | 3 +++
 configs/Mele_A1000G_quad_defconfig       | 2 ++
 configs/Mele_A1000_defconfig             | 2 ++
 configs/Mele_M9_defconfig                | 2 ++
 configs/bananapi_m1_plus_defconfig       | 2 ++
 configs/bananapi_m2_berry_defconfig      | 2 ++
 configs/bananapi_m2_zero_defconfig       | 3 +++
 configs/beelink_x2_defconfig             | 2 ++
 configs/icnova-a20-adb4006_defconfig     | 2 ++
 configs/nanopi_duo2_defconfig            | 2 ++
 configs/nanopi_neo_air_defconfig         | 2 ++
 configs/orangepi_2_defconfig             | 2 ++
 configs/orangepi_lite_defconfig          | 2 ++
 configs/orangepi_one_defconfig           | 2 ++
 configs/orangepi_pc_defconfig            | 2 ++
 configs/orangepi_zero_defconfig          | 2 ++
 configs/orangepi_zero_plus2_h3_defconfig | 2 ++
 19 files changed, 40 insertions(+)
configs/A13-OLinuXinoM_defconfig +2 -0
index f547635302f..6c5a1b33194 100644
@@ -10,6 +10,8 @@ CONFIG_VIDEO_VGA_VIA_LCD=y
 CONFIG_VIDEO_VGA_VIA_LCD_FORCE_SYNC_ACTIVE_HIGH=y
 CONFIG_VIDEO_LCD_POWER="PB10"
 CONFIG_VIDEO_LCD_BL_PWM="PB2"
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=201
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SYS_I2C_MVTWSI=y
 CONFIG_SYS_I2C_SLAVE=0x7f
configs/Bananapi_M2_Ultra_defconfig +2 -0
index 375b0063c1a..750868033be 100644
@@ -5,6 +5,8 @@ CONFIG_DRAM_CLK=576
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_R40=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=244
 # CONFIG_HAS_ARMV7_SECURE_BASE is not set
 CONFIG_AHCI=y
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
configs/Bananapi_m2m_defconfig +3 -0
index 0c20cce49ea..f75e3e09d03 100644
@@ -7,6 +7,9 @@ CONFIG_MACH_SUN8I_A33=y
 CONFIG_DRAM_ZQ=15291
 CONFIG_DRAM_ODT_EN=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=355
+# CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH is not set
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
 CONFIG_USB_EHCI_HCD=y
configs/Mele_A1000G_quad_defconfig +2 -0
index 1f4739e0005..ee6c902970a 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun6i-a31-mele-a1000g-quad"
 CONFIG_SPL=y
 CONFIG_MACH_SUN6I=y
 CONFIG_DRAM_ZQ=120
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=237
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_PHY_REALTEK=y
 CONFIG_ETH_DESIGNWARE=y
configs/Mele_A1000_defconfig +2 -0
index 93e73ebe3f1..48679265650 100644
@@ -5,6 +5,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN4I=y
 CONFIG_VIDEO_VGA=y
 CONFIG_VIDEO_COMPOSITE=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=244
 CONFIG_AHCI=y
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
configs/Mele_M9_defconfig +2 -0
index 9b1bb97eedd..293e00db1b0 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun6i-a31-m9"
 CONFIG_SPL=y
 CONFIG_MACH_SUN6I=y
 CONFIG_DRAM_ZQ=120
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=237
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_PHY_REALTEK=y
 CONFIG_ETH_DESIGNWARE=y
configs/bananapi_m1_plus_defconfig +2 -0
index 22b69aa88cb..14ecaf759b5 100644
@@ -6,6 +6,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN7I=y
 CONFIG_VIDEO_COMPOSITE=y
 CONFIG_GMAC_TX_DELAY=3
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=249
 CONFIG_AHCI=y
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
configs/bananapi_m2_berry_defconfig +2 -0
index b406d519684..b9975211362 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-v40-bananapi-m2-berry"
 CONFIG_DRAM_CLK=576
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_R40=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=244
 # CONFIG_HAS_ARMV7_SECURE_BASE is not set
 CONFIG_AHCI=y
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
configs/bananapi_m2_zero_defconfig +3 -0
index 337bafecd47..5041802ea8c 100644
@@ -4,4 +4,7 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-h2-plus-bananapi-m2-zero"
 CONFIG_DRAM_CLK=408
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
+# CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH is not set
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
configs/beelink_x2_defconfig +2 -0
index 3b0be26f063..16a37da521d 100644
@@ -5,6 +5,8 @@ CONFIG_DRAM_CLK=567
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
configs/icnova-a20-adb4006_defconfig +2 -0
index 507e330612e..dcb6457fe71 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-icnova-a20-adb4006"
 CONFIG_DRAM_CLK=384
 CONFIG_SPL=y
 CONFIG_MACH_SUN7I=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=245
 CONFIG_AHCI=y
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
configs/nanopi_duo2_defconfig +2 -0
index 41b5502d24e..9b0fbecff60 100644
@@ -5,6 +5,8 @@ CONFIG_DRAM_CLK=408
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
 # CONFIG_VIDEO_DE2 is not set
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_CONSOLE_MUX=y
 CONFIG_USB_EHCI_HCD=y
configs/nanopi_neo_air_defconfig +2 -0
index 3b8cbbfcdba..110bb1e864c 100644
@@ -5,6 +5,8 @@ CONFIG_DRAM_CLK=408
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
 # CONFIG_VIDEO_DE2 is not set
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_CONSOLE_MUX=y
 CONFIG_USB_EHCI_HCD=y
configs/orangepi_2_defconfig +2 -0
index 88433808538..43f3ab512f1 100644
@@ -5,6 +5,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-orangepi-2"
 CONFIG_DRAM_CLK=672
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
 CONFIG_SPL_SYS_I2C_LEGACY=y
configs/orangepi_lite_defconfig +2 -0
index ea1548f0fcd..499ffd8ace5 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-orangepi-lite"
 CONFIG_DRAM_CLK=672
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_OHCI_HCD=y
configs/orangepi_one_defconfig +2 -0
index e4de13de26b..637eb41207e 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-orangepi-one"
 CONFIG_DRAM_CLK=672
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
configs/orangepi_pc_defconfig +2 -0
index f857d7fa203..01195b68621 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-orangepi-pc"
 CONFIG_DRAM_CLK=624
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
 CONFIG_SPL_SYS_I2C_LEGACY=y
configs/orangepi_zero_defconfig +2 -0
index e128f5fcdb3..49a1f4d03da 100644
@@ -6,6 +6,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
 # CONFIG_VIDEO_DE2 is not set
 CONFIG_SPL_SPI_SUNXI=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_CONSOLE_MUX=y
 CONFIG_MTD=y
configs/orangepi_zero_plus2_h3_defconfig +2 -0
index caf515c7026..63335b404da 100644
@@ -6,6 +6,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
 # CONFIG_DRAM_ODT_EN is not set
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
Signature · 1 line
2.43.0
Reviewed-by on v2 2/3
#5 lore raw

Re: [PATCH v2 2/3] sunxi: configs: enable power LEDs on 32-bit boards

Hi Andre,

Quoted 9 lines · Andre Przywara

We recently gained a simple way to enable a power LED very early in the SPL boot, through simple Kconfig variables.

Add those symbols to those boards' defconfigs where the DT indicates a default-on power LED. The number used is <port bank> * 32 + <pin no>, an active low setup means CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH must be undefined. Since its default is "high", we can skip the symbol in the defconfig in this case.

Quoted 4 lines

This will light up the power LED very early in the (SPL) boot phase on those 32-bit boards.

All the best,

Paul

Quoted 272 lines
---
 configs/A13-OLinuXinoM_defconfig         | 2 ++
 configs/Bananapi_M2_Ultra_defconfig      | 2 ++
 configs/Bananapi_m2m_defconfig           | 3 +++
 configs/Mele_A1000G_quad_defconfig       | 2 ++
 configs/Mele_A1000_defconfig             | 2 ++
 configs/Mele_M9_defconfig                | 2 ++
 configs/bananapi_m1_plus_defconfig       | 2 ++
 configs/bananapi_m2_berry_defconfig      | 2 ++
 configs/bananapi_m2_zero_defconfig       | 3 +++
 configs/beelink_x2_defconfig             | 2 ++
 configs/icnova-a20-adb4006_defconfig     | 2 ++
 configs/nanopi_duo2_defconfig            | 2 ++
 configs/nanopi_neo_air_defconfig         | 2 ++
 configs/orangepi_2_defconfig             | 2 ++
 configs/orangepi_lite_defconfig          | 2 ++
 configs/orangepi_one_defconfig           | 2 ++
 configs/orangepi_pc_defconfig            | 2 ++
 configs/orangepi_zero_defconfig          | 2 ++
 configs/orangepi_zero_plus2_h3_defconfig | 2 ++
 19 files changed, 40 insertions(+)
configs/A13-OLinuXinoM_defconfig +2 -0
index f547635302f..6c5a1b33194 100644
@@ -10,6 +10,8 @@ CONFIG_VIDEO_VGA_VIA_LCD=y
 CONFIG_VIDEO_VGA_VIA_LCD_FORCE_SYNC_ACTIVE_HIGH=y
 CONFIG_VIDEO_LCD_POWER="PB10"
 CONFIG_VIDEO_LCD_BL_PWM="PB2"
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=201
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SYS_I2C_MVTWSI=y
 CONFIG_SYS_I2C_SLAVE=0x7f
configs/Bananapi_M2_Ultra_defconfig +2 -0
index 375b0063c1a..750868033be 100644
@@ -5,6 +5,8 @@ CONFIG_DRAM_CLK=576
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_R40=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=244
 # CONFIG_HAS_ARMV7_SECURE_BASE is not set
 CONFIG_AHCI=y
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
configs/Bananapi_m2m_defconfig +3 -0
index 0c20cce49ea..f75e3e09d03 100644
@@ -7,6 +7,9 @@ CONFIG_MACH_SUN8I_A33=y
 CONFIG_DRAM_ZQ=15291
 CONFIG_DRAM_ODT_EN=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=355
+# CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH is not set
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
 CONFIG_USB_EHCI_HCD=y
configs/Mele_A1000G_quad_defconfig +2 -0
index 1f4739e0005..ee6c902970a 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun6i-a31-mele-a1000g-quad"
 CONFIG_SPL=y
 CONFIG_MACH_SUN6I=y
 CONFIG_DRAM_ZQ=120
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=237
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_PHY_REALTEK=y
 CONFIG_ETH_DESIGNWARE=y
configs/Mele_A1000_defconfig +2 -0
index 93e73ebe3f1..48679265650 100644
@@ -5,6 +5,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN4I=y
 CONFIG_VIDEO_VGA=y
 CONFIG_VIDEO_COMPOSITE=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=244
 CONFIG_AHCI=y
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
configs/Mele_M9_defconfig +2 -0
index 9b1bb97eedd..293e00db1b0 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun6i-a31-m9"
 CONFIG_SPL=y
 CONFIG_MACH_SUN6I=y
 CONFIG_DRAM_ZQ=120
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=237
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_PHY_REALTEK=y
 CONFIG_ETH_DESIGNWARE=y
configs/bananapi_m1_plus_defconfig +2 -0
index 22b69aa88cb..14ecaf759b5 100644
@@ -6,6 +6,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN7I=y
 CONFIG_VIDEO_COMPOSITE=y
 CONFIG_GMAC_TX_DELAY=3
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=249
 CONFIG_AHCI=y
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
configs/bananapi_m2_berry_defconfig +2 -0
index b406d519684..b9975211362 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-v40-bananapi-m2-berry"
 CONFIG_DRAM_CLK=576
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_R40=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=244
 # CONFIG_HAS_ARMV7_SECURE_BASE is not set
 CONFIG_AHCI=y
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
configs/bananapi_m2_zero_defconfig +3 -0
index 337bafecd47..5041802ea8c 100644
@@ -4,4 +4,7 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-h2-plus-bananapi-m2-zero"
 CONFIG_DRAM_CLK=408
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
+# CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH is not set
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
configs/beelink_x2_defconfig +2 -0
index 3b0be26f063..16a37da521d 100644
@@ -5,6 +5,8 @@ CONFIG_DRAM_CLK=567
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
configs/icnova-a20-adb4006_defconfig +2 -0
index 507e330612e..dcb6457fe71 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-icnova-a20-adb4006"
 CONFIG_DRAM_CLK=384
 CONFIG_SPL=y
 CONFIG_MACH_SUN7I=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=245
 CONFIG_AHCI=y
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
configs/nanopi_duo2_defconfig +2 -0
index 41b5502d24e..9b0fbecff60 100644
@@ -5,6 +5,8 @@ CONFIG_DRAM_CLK=408
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
 # CONFIG_VIDEO_DE2 is not set
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_CONSOLE_MUX=y
 CONFIG_USB_EHCI_HCD=y
configs/nanopi_neo_air_defconfig +2 -0
index 3b8cbbfcdba..110bb1e864c 100644
@@ -5,6 +5,8 @@ CONFIG_DRAM_CLK=408
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
 # CONFIG_VIDEO_DE2 is not set
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_CONSOLE_MUX=y
 CONFIG_USB_EHCI_HCD=y
configs/orangepi_2_defconfig +2 -0
index 88433808538..43f3ab512f1 100644
@@ -5,6 +5,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-orangepi-2"
 CONFIG_DRAM_CLK=672
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
 CONFIG_SPL_SYS_I2C_LEGACY=y
configs/orangepi_lite_defconfig +2 -0
index ea1548f0fcd..499ffd8ace5 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-orangepi-lite"
 CONFIG_DRAM_CLK=672
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_OHCI_HCD=y
configs/orangepi_one_defconfig +2 -0
index e4de13de26b..637eb41207e 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-orangepi-one"
 CONFIG_DRAM_CLK=672
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
configs/orangepi_pc_defconfig +2 -0
index f857d7fa203..01195b68621 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-orangepi-pc"
 CONFIG_DRAM_CLK=624
 CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
 CONFIG_SPL_SYS_I2C_LEGACY=y
configs/orangepi_zero_defconfig +2 -0
index e128f5fcdb3..49a1f4d03da 100644
@@ -6,6 +6,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
 # CONFIG_VIDEO_DE2 is not set
 CONFIG_SPL_SPI_SUNXI=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_CONSOLE_MUX=y
 CONFIG_MTD=y
configs/orangepi_zero_plus2_h3_defconfig +2 -0
index caf515c7026..63335b404da 100644
@@ -6,6 +6,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN8I_H3=y
 # CONFIG_DRAM_ODT_EN is not set
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
Signature · 1 line
2.43.0
Signature · 6 lines
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expert in multimedia, graphics and embedded hardware support with Linux.
#6 lore raw

PATCH v2 3/3 sunxi: configs: enable power LEDs on 64-bit boards

In reply to Andre Przywara

We recently gained a simple way to enable a power LED very early in the SPL boot, through simple Kconfig variables.

Add those symbols to those boards' defconfigs where the DT indicates a default-on power LED. The number used is <port bank> * 32 + <pin no>, an active low setup means CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH must be undefined.

This will light up the power LED very early in the (SPL) boot phase on those 64-bit boards.

---
 configs/anbernic_rg35xx_h700_defconfig | 2 ++
 configs/bananapi_m64_defconfig         | 2 ++
 configs/beelink_gs1_defconfig          | 2 ++
 configs/liontron-h-a133l_defconfig     | 3 +++
 configs/nanopi_neo2_defconfig          | 2 ++
 configs/nanopi_neo_plus2_defconfig     | 2 ++
 configs/orangepi_3_defconfig           | 2 ++
 configs/orangepi_lite2_defconfig       | 2 ++
 configs/orangepi_pc2_defconfig         | 2 ++
 configs/orangepi_prime_defconfig       | 2 ++
 configs/orangepi_zero2_defconfig       | 2 ++
 configs/orangepi_zero_plus2_defconfig  | 2 ++
 configs/orangepi_zero_plus_defconfig   | 2 ++
 configs/radxa-cubie-a5e_defconfig      | 3 +++
 configs/tanix_tx1_defconfig            | 2 ++
 15 files changed, 32 insertions(+)
configs/anbernic_rg35xx_h700_defconfig +2 -0
index 2fa57cbecce..2abea94e979 100644
@@ -16,6 +16,8 @@ CONFIG_DRAM_SUNXI_PHY_ADDR_MAP_1=y
 CONFIG_MACH_SUN50I_H616=y
 CONFIG_SUNXI_DRAM_H616_LPDDR4=y
 CONFIG_R_I2C_ENABLE=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=268
 CONFIG_SPL_I2C=y
 CONFIG_SPL_SYS_I2C_LEGACY=y
 CONFIG_SYS_I2C_MVTWSI=y
configs/bananapi_m64_defconfig +2 -0
index d957071cb13..3d1f5d27e5d 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64"
 CONFIG_SPL=y
 CONFIG_MACH_SUN50I=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=120
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUPPORT_EMMC_BOOT=y
 CONFIG_SUN8I_EMAC=y
configs/beelink_gs1_defconfig +2 -0
index de46d205453..ebac032915f 100644
@@ -5,6 +5,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H6=y
 CONFIG_SUNXI_DRAM_H6_LPDDR3=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=356
 # CONFIG_PSCI_RESET is not set
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_LED=y
configs/liontron-h-a133l_defconfig +3 -0
index 831d5b56e3a..836e8d12ff0 100644
@@ -23,6 +23,9 @@ CONFIG_MACH_SUN50I_A133=y
 CONFIG_SUNXI_DRAM_A133_LPDDR4=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 CONFIG_R_I2C_ENABLE=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=240
+# CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH is not set
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
 CONFIG_SPL_SYS_I2C_LEGACY=y
configs/nanopi_neo2_defconfig +2 -0
index 6704a24a880..63fa6bac9ba 100644
@@ -6,6 +6,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H5=y
 CONFIG_DRAM_ZQ=3881977
 # CONFIG_DRAM_ODT_EN is not set
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
configs/nanopi_neo_plus2_defconfig +2 -0
index e80e32a63d4..9d1b783476d 100644
@@ -7,6 +7,8 @@ CONFIG_MACH_SUN50I_H5=y
 CONFIG_DRAM_ZQ=3881977
 # CONFIG_DRAM_ODT_EN is not set
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
configs/orangepi_3_defconfig +2 -0
index 125137bc321..409fa705a06 100644
@@ -6,6 +6,8 @@ CONFIG_MACH_SUN50I_H6=y
 CONFIG_SUNXI_DRAM_H6_LPDDR3=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 CONFIG_BLUETOOTH_DT_DEVICE_FIXUP="brcm,bcm4345c5"
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=356
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_PHY_SUN50I_USB3=y
 CONFIG_USB_XHCI_HCD=y
configs/orangepi_lite2_defconfig +2 -0
index 577f7436c15..5d72d34eb9d 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h6-orangepi-lite2"
 CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H6=y
 CONFIG_SUNXI_DRAM_H6_LPDDR3=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=356
 # CONFIG_PSCI_RESET is not set
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_USB_EHCI_HCD=y
configs/orangepi_pc2_defconfig +2 -0
index d856a25814b..464b34f4ec0 100644
@@ -6,6 +6,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H5=y
 CONFIG_DRAM_ZQ=3881977
 CONFIG_SPL_SPI_SUNXI=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
 CONFIG_SPL_SYS_I2C_LEGACY=y
configs/orangepi_prime_defconfig +2 -0
index e93154cc0e9..e5e9009378c 100644
@@ -6,6 +6,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H5=y
 CONFIG_DRAM_ZQ=3881977
 # CONFIG_DRAM_ODT_EN is not set
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
configs/orangepi_zero2_defconfig +2 -0
index 831bfe66e25..b387b4795ad 100644
@@ -10,6 +10,8 @@ CONFIG_MACH_SUN50I_H616=y
 CONFIG_SUNXI_DRAM_H616_DDR3_1333=y
 CONFIG_R_I2C_ENABLE=y
 CONFIG_SPL_SPI_SUNXI=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=76
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
 CONFIG_SPL_SYS_I2C_LEGACY=y
configs/orangepi_zero_plus2_defconfig +2 -0
index c4d9800975c..9758ffd385e 100644
@@ -7,6 +7,8 @@ CONFIG_MACH_SUN50I_H5=y
 CONFIG_DRAM_ZQ=3881977
 # CONFIG_DRAM_ODT_EN is not set
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
configs/orangepi_zero_plus_defconfig +2 -0
index 4b6491dc846..bb159428a14 100644
@@ -6,6 +6,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H5=y
 CONFIG_DRAM_ZQ=3881977
 # CONFIG_DRAM_ODT_EN is not set
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
configs/radxa-cubie-a5e_defconfig +3 -0
index 9d204ef5548..84bc4e3d4a9 100644
@@ -15,6 +15,9 @@ CONFIG_DRAM_SUNXI_TPR12=0x3533302f
 CONFIG_MACH_SUN55I_A523=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 CONFIG_R_I2C_ENABLE=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=356
+# CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH is not set
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
 CONFIG_SPL_SYS_I2C_LEGACY=y
configs/tanix_tx1_defconfig +2 -0
index 1bd167ce0f6..03b18701859 100644
@@ -14,6 +14,8 @@ CONFIG_MACH_SUN50I_H616=y
 CONFIG_SUNXI_DRAM_H616_LPDDR3=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 CONFIG_R_I2C_ENABLE=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=231
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
 CONFIG_SPL_SYS_I2C_LEGACY=y
Signature · 1 line
2.43.0
Reviewed-by on v2 3/3
#7 lore raw

Re: [PATCH v2 3/3] sunxi: configs: enable power LEDs on 64-bit boards

Hi Andre,

Quoted 8 lines · Andre Przywara

We recently gained a simple way to enable a power LED very early in the SPL boot, through simple Kconfig variables.

Add those symbols to those boards' defconfigs where the DT indicates a default-on power LED. The number used is <port bank> * 32 + <pin no>, an active low setup means CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH must be undefined.

Quoted 4 lines

This will light up the power LED very early in the (SPL) boot phase on those 64-bit boards.

All the best,

Paul

Quoted 218 lines
---
 configs/anbernic_rg35xx_h700_defconfig | 2 ++
 configs/bananapi_m64_defconfig         | 2 ++
 configs/beelink_gs1_defconfig          | 2 ++
 configs/liontron-h-a133l_defconfig     | 3 +++
 configs/nanopi_neo2_defconfig          | 2 ++
 configs/nanopi_neo_plus2_defconfig     | 2 ++
 configs/orangepi_3_defconfig           | 2 ++
 configs/orangepi_lite2_defconfig       | 2 ++
 configs/orangepi_pc2_defconfig         | 2 ++
 configs/orangepi_prime_defconfig       | 2 ++
 configs/orangepi_zero2_defconfig       | 2 ++
 configs/orangepi_zero_plus2_defconfig  | 2 ++
 configs/orangepi_zero_plus_defconfig   | 2 ++
 configs/radxa-cubie-a5e_defconfig      | 3 +++
 configs/tanix_tx1_defconfig            | 2 ++
 15 files changed, 32 insertions(+)
configs/anbernic_rg35xx_h700_defconfig +2 -0
index 2fa57cbecce..2abea94e979 100644
@@ -16,6 +16,8 @@ CONFIG_DRAM_SUNXI_PHY_ADDR_MAP_1=y
 CONFIG_MACH_SUN50I_H616=y
 CONFIG_SUNXI_DRAM_H616_LPDDR4=y
 CONFIG_R_I2C_ENABLE=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=268
 CONFIG_SPL_I2C=y
 CONFIG_SPL_SYS_I2C_LEGACY=y
 CONFIG_SYS_I2C_MVTWSI=y
configs/bananapi_m64_defconfig +2 -0
index d957071cb13..3d1f5d27e5d 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64"
 CONFIG_SPL=y
 CONFIG_MACH_SUN50I=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=120
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUPPORT_EMMC_BOOT=y
 CONFIG_SUN8I_EMAC=y
configs/beelink_gs1_defconfig +2 -0
index de46d205453..ebac032915f 100644
@@ -5,6 +5,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H6=y
 CONFIG_SUNXI_DRAM_H6_LPDDR3=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=356
 # CONFIG_PSCI_RESET is not set
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_LED=y
configs/liontron-h-a133l_defconfig +3 -0
index 831d5b56e3a..836e8d12ff0 100644
@@ -23,6 +23,9 @@ CONFIG_MACH_SUN50I_A133=y
 CONFIG_SUNXI_DRAM_A133_LPDDR4=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 CONFIG_R_I2C_ENABLE=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=240
+# CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH is not set
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
 CONFIG_SPL_SYS_I2C_LEGACY=y
configs/nanopi_neo2_defconfig +2 -0
index 6704a24a880..63fa6bac9ba 100644
@@ -6,6 +6,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H5=y
 CONFIG_DRAM_ZQ=3881977
 # CONFIG_DRAM_ODT_EN is not set
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
configs/nanopi_neo_plus2_defconfig +2 -0
index e80e32a63d4..9d1b783476d 100644
@@ -7,6 +7,8 @@ CONFIG_MACH_SUN50I_H5=y
 CONFIG_DRAM_ZQ=3881977
 # CONFIG_DRAM_ODT_EN is not set
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
configs/orangepi_3_defconfig +2 -0
index 125137bc321..409fa705a06 100644
@@ -6,6 +6,8 @@ CONFIG_MACH_SUN50I_H6=y
 CONFIG_SUNXI_DRAM_H6_LPDDR3=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 CONFIG_BLUETOOTH_DT_DEVICE_FIXUP="brcm,bcm4345c5"
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=356
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_PHY_SUN50I_USB3=y
 CONFIG_USB_XHCI_HCD=y
configs/orangepi_lite2_defconfig +2 -0
index 577f7436c15..5d72d34eb9d 100644
@@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h6-orangepi-lite2"
 CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H6=y
 CONFIG_SUNXI_DRAM_H6_LPDDR3=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=356
 # CONFIG_PSCI_RESET is not set
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_USB_EHCI_HCD=y
configs/orangepi_pc2_defconfig +2 -0
index d856a25814b..464b34f4ec0 100644
@@ -6,6 +6,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H5=y
 CONFIG_DRAM_ZQ=3881977
 CONFIG_SPL_SPI_SUNXI=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
 CONFIG_SPL_SYS_I2C_LEGACY=y
configs/orangepi_prime_defconfig +2 -0
index e93154cc0e9..e5e9009378c 100644
@@ -6,6 +6,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H5=y
 CONFIG_DRAM_ZQ=3881977
 # CONFIG_DRAM_ODT_EN is not set
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
configs/orangepi_zero2_defconfig +2 -0
index 831bfe66e25..b387b4795ad 100644
@@ -10,6 +10,8 @@ CONFIG_MACH_SUN50I_H616=y
 CONFIG_SUNXI_DRAM_H616_DDR3_1333=y
 CONFIG_R_I2C_ENABLE=y
 CONFIG_SPL_SPI_SUNXI=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=76
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
 CONFIG_SPL_SYS_I2C_LEGACY=y
configs/orangepi_zero_plus2_defconfig +2 -0
index c4d9800975c..9758ffd385e 100644
@@ -7,6 +7,8 @@ CONFIG_MACH_SUN50I_H5=y
 CONFIG_DRAM_ZQ=3881977
 # CONFIG_DRAM_ODT_EN is not set
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
configs/orangepi_zero_plus_defconfig +2 -0
index 4b6491dc846..bb159428a14 100644
@@ -6,6 +6,8 @@ CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H5=y
 CONFIG_DRAM_ZQ=3881977
 # CONFIG_DRAM_ODT_EN is not set
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
configs/radxa-cubie-a5e_defconfig +3 -0
index 9d204ef5548..84bc4e3d4a9 100644
@@ -15,6 +15,9 @@ CONFIG_DRAM_SUNXI_TPR12=0x3533302f
 CONFIG_MACH_SUN55I_A523=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 CONFIG_R_I2C_ENABLE=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=356
+# CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH is not set
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
 CONFIG_SPL_SYS_I2C_LEGACY=y
configs/tanix_tx1_defconfig +2 -0
index 1bd167ce0f6..03b18701859 100644
@@ -14,6 +14,8 @@ CONFIG_MACH_SUN50I_H616=y
 CONFIG_SUNXI_DRAM_H616_LPDDR3=y
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 CONFIG_R_I2C_ENABLE=y
+CONFIG_SPL_SUNXI_LED_STATUS=y
+CONFIG_SPL_SUNXI_LED_STATUS_GPIO=231
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_I2C=y
 CONFIG_SPL_SYS_I2C_LEGACY=y
Signature · 1 line
2.43.0
Signature · 6 lines
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expert in multimedia, graphics and embedded hardware support with Linux.