Skip to content

Funxi: Fix and extend SPL power LED support

Andre Przywara linux-sunxi u-boot 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 4 repliesIn review
  2. v13 patches 6 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3sunxi: spl: fix SPL_SUNXI_LED active low configurationarch/arm/mach-sunxi/Kconfig board/sunxi/board.c configs/pinephone_defconfig+9 -82 replies
2/3sunxi: configs: enable power LEDs on 32-bit boardsconfigs/A13-OLinuXinoM_defconfig configs/Bananapi_M2_Ultra_defconfig configs/Bananapi_m2m_defconfig +16 more+40 -01 reply
3/3sunxi: configs: enable power LEDs on 64-bit boardsconfigs/anbernic_rg35xx_h700_defconfig configs/bananapi_m64_defconfig configs/beelink_gs1_defconfig +12 more+32 -01 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchQuentin SchulzPaul Kocialkowski
1/3A-b R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Funxi: Fix and extend SPL power LED support

Hi,

just an update after some discussion on the list (thanks to Paul and Quentin for having a look!), changing the naming of the Kconfig symbols, since their meaning wasn't clear. Changelog below.

================
With the demise of the legacy SPL LED framework a new, much simpler version emerged for Allwinner SoCs: Just define the GPIO number in Kconfig, and some simple code turns the LED on very early.

I was looking at using this feature for boards with a GPIO controlled power LED, as having a sign of life very early can be very handy. So I grep'ed all DTs for those LEDs, and added the respective symbols to the board's defconfig file.
Doing so revealed a small bug in the code when using active low LEDs, so patch 1/3 fixes this.
Patch 2/3 adds the power LEDs to 32-bit boards, patch 3/3 to 64-bit boards - just some arbitrary splitup to simplify review.

Please have a look and test if you have any of the boards.

Cheers,
Andre

Changelog v1 ... v2:
- rename Kconfig symbols to better match their meaning
- default to ACTIVE_HIGH=y

Andre Przywara (3):
sunxi: spl: fix SPL_SUNXI_LED active low configuration
sunxi: configs: enable power LEDs on 32-bit boards
sunxi: configs: enable power LEDs on 64-bit boards

 arch/arm/mach-sunxi/Kconfig              | 10 ++++++----
 board/sunxi/board.c                      |  4 ++--
 configs/A13-OLinuXinoM_defconfig         |  2 ++
 configs/Bananapi_M2_Ultra_defconfig      |  2 ++
 configs/Bananapi_m2m_defconfig           |  3 +++
 configs/Mele_A1000G_quad_defconfig       |  2 ++
 configs/Mele_A1000_defconfig             |  2 ++
 configs/Mele_M9_defconfig                |  2 ++
 configs/anbernic_rg35xx_h700_defconfig   |  2 ++
 configs/bananapi_m1_plus_defconfig       |  2 ++
 configs/bananapi_m2_berry_defconfig      |  2 ++
 configs/bananapi_m2_zero_defconfig       |  3 +++
 configs/bananapi_m64_defconfig           |  2 ++
 configs/beelink_gs1_defconfig            |  2 ++
 configs/beelink_x2_defconfig             |  2 ++
 configs/icnova-a20-adb4006_defconfig     |  2 ++
 configs/liontron-h-a133l_defconfig       |  3 +++
 configs/nanopi_duo2_defconfig            |  2 ++
 configs/nanopi_neo2_defconfig            |  2 ++
 configs/nanopi_neo_air_defconfig         |  2 ++
 configs/nanopi_neo_plus2_defconfig       |  2 ++
 configs/orangepi_2_defconfig             |  2 ++
 configs/orangepi_3_defconfig             |  2 ++
 configs/orangepi_lite2_defconfig         |  2 ++
 configs/orangepi_lite_defconfig          |  2 ++
 configs/orangepi_one_defconfig           |  2 ++
 configs/orangepi_pc2_defconfig           |  2 ++
 configs/orangepi_pc_defconfig            |  2 ++
 configs/orangepi_prime_defconfig         |  2 ++
 configs/orangepi_zero2_defconfig         |  2 ++
 configs/orangepi_zero_defconfig          |  2 ++
 configs/orangepi_zero_plus2_defconfig    |  2 ++
 configs/orangepi_zero_plus2_h3_defconfig |  2 ++
 configs/orangepi_zero_plus_defconfig     |  2 ++
 configs/pinephone_defconfig              |  3 +--
 configs/radxa-cubie-a5e_defconfig        |  3 +++
 configs/tanix_tx1_defconfig              |  2 ++
 37 files changed, 81 insertions(+), 8 deletions(-)
Signature · 1 line
2.43.0