sunxi: Fix and extend SPL power LED support
cover sunxi: Fix and extend SPL power LED support
With the demise of the legacy SPL LED framework a new, much simpler version emerged for Allwinner SoCs: Just define the GPIO number in Kconfig, and some simple code turns the LED on very early.
I was looking at using this feature for boards with a GPIO controlled power LED, as having a sign of life very early can be very handy. So I grep'ed all DTs for those LEDs, and added the respective symbols to the board's defconfig file.
Doing so revealed a small bug in the code when using active low LEDs, so patch 1/3 fixes this.
Patch 2/3 adds the power LEDs to 32-bit boards, patch 3/3 to 64-bit boards - just some arbitrary splitup to simplify review.
Please have a look and test if you have any of the boards.
Cheers,
Andre
Andre Przywara (3):
sunxi: spl: fix SPL_SUNXI_LED active low configuration
sunxi: configs: enable power LEDs on 32-bit boards
sunxi: configs: enable power LEDs on 64-bit boards
board/sunxi/board.c | 2 +- configs/A13-OLinuXinoM_defconfig | 3 +++ configs/Bananapi_M2_Ultra_defconfig | 3 +++ configs/Bananapi_m2m_defconfig | 3 +++ configs/Mele_A1000G_quad_defconfig | 3 +++ configs/Mele_A1000_defconfig | 3 +++ configs/Mele_M9_defconfig | 3 +++ configs/anbernic_rg35xx_h700_defconfig | 3 +++ configs/bananapi_m1_plus_defconfig | 3 +++ configs/bananapi_m2_berry_defconfig | 3 +++ configs/bananapi_m2_zero_defconfig | 3 +++ configs/bananapi_m64_defconfig | 3 +++ configs/beelink_gs1_defconfig | 3 +++ configs/beelink_x2_defconfig | 3 +++ configs/icnova-a20-adb4006_defconfig | 3 +++ configs/liontron-h-a133l_defconfig | 3 +++ configs/nanopi_duo2_defconfig | 3 +++ configs/nanopi_neo2_defconfig | 3 +++ configs/nanopi_neo_air_defconfig | 3 +++ configs/nanopi_neo_plus2_defconfig | 3 +++ configs/orangepi_2_defconfig | 3 +++ configs/orangepi_3_defconfig | 3 +++ configs/orangepi_lite2_defconfig | 3 +++ configs/orangepi_lite_defconfig | 3 +++ configs/orangepi_one_defconfig | 3 +++ configs/orangepi_pc2_defconfig | 3 +++ configs/orangepi_pc_defconfig | 3 +++ configs/orangepi_prime_defconfig | 3 +++ configs/orangepi_zero2_defconfig | 3 +++ configs/orangepi_zero_defconfig | 3 +++ configs/orangepi_zero_plus2_defconfig | 3 +++ configs/orangepi_zero_plus2_h3_defconfig | 3 +++ configs/orangepi_zero_plus_defconfig | 3 +++ configs/radxa-cubie-a5e_defconfig | 3 +++ configs/tanix_tx1_defconfig | 3 +++ 35 files changed, 103 insertions(+), 1 deletion(-)
Signature · 1 line
2.46.4
PATCH 1/3 sunxi: spl: fix SPL_SUNXI_LED active low configuration
The newly introduced Allwinner SPL LED "framework" defined a SPL_SUNXI_LED_STATUS_STATE Kconfig symbol, that was supposed to denote the active-low vs. active-high polarity of the LED. However this is a bool symbol, so it will simply vanish if not defined, and we cannot use it directly inside a C statement.
Filter the symbol through the IS_ENABLED() macro, which will return 0 if the symbol is not defined, which is the intended value here.
This fixes configuring LEDs with active-low polarity.
--- board/sunxi/board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
board/sunxi/board.c +1 -1
@@ -563,7 +563,7 @@ static void sunxi_spl_store_dram_size(phys_addr_t dram_size)static void status_led_init (void ) {#if CONFIG_IS_ENABLED (SUNXI_LED_STATUS ) -unsigned int state =CONFIG_SPL_SUNXI_LED_STATUS_STATE ; +unsigned int state =IS_ENABLED (CONFIG_SPL_SUNXI_LED_STATUS_STATE );unsigned int gpio =CONFIG_SPL_SUNXI_LED_STATUS_BIT ;gpio_request (gpio,"gpio_led" );
Signature · 1 line
2.46.4
Re: [PATCH 1/3] sunxi: spl: fix SPL_SUNXI_LED active low configuration
Hi Andre,
Quoted 6 lines · Andre Przywara
The newly introduced Allwinner SPL LED "framework" defined a
SPL_SUNXI_LED_STATUS_STATEKconfigsymbol, that was supposed to denote the active-low vs. active-high polarity of the LED. However this is a bool symbol, so it will simply vanish if not defined, and we cannot use it directly inside a C statement.
Ugh, thanks for catching that!
Quoted 5 lines
Filter the symbol through the
IS_ENABLED()macro, which will return 0 if the symbol is not defined, which is the intended value here.This fixes configuring LEDs with active-low polarity.
Thanks!
Quentin
Re: [PATCH 1/3] sunxi: spl: fix SPL_SUNXI_LED active low configuration
In reply to Andre PrzywaraHi,
Quoted 21 lines · Andre Przywara
The newly introduced Allwinner SPL LED "framework" defined a
SPL_SUNXI_LED_STATUS_STATEKconfigsymbol, that was supposed to denote the active-low vs. active-high polarity of the LED. However this is a bool symbol, so it will simply vanish if not defined, and we cannot use it directly inside a C statement.Filter the symbol through the
IS_ENABLED()macro, which will return 0 if the symbol is not defined, which is the intended value here.This fixes configuring LEDs with active-low polarity.
Signed-off-by Andre Przywara <[email protected]>--- board/sunxi/board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)board/sunxi/board.c +0
-0
board/sunxi/board.c static void sunxi_spl_store_dram_size(phys_addr_t dram_size) · line 566
Quoted 5 lines
board/sunxi/board.c +1
-1@@ -563,7 +563,7 @@ static void sunxi_spl_store_dram_size(phys_addr_t dram_size)static void status_led_init (void ) {#if CONFIG_IS_ENABLED (SUNXI_LED_STATUS ) -unsigned int state =CONFIG_SPL_SUNXI_LED_STATUS_STATE ; +unsigned int state =IS_ENABLED (CONFIG_SPL_SUNXI_LED_STATUS_STATE );
Sorry I didn't react to the initial submission, but it feels like the CONFIG_SPL_SUNXI_LED_STATUS_STATE symbol really means active-high if enabled and active-low if disabled. The name would suggest that it's an int with a value of either 0 or 1 instead.
I think it would be less confusing to call the symbol CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_LOW and reverse its meaning, so that we can spare defining it in most configs (that will be active-high). Also the description currently mentions "initial state" which may be confusing as it could refer to the state inherited after reset (e.g. due to some pull resistor) or the state we do set in the SPL.
board/sunxi/board.c static void sunxi_spl_store_dram_size(phys_addr_t dram_size) · line 567
Quoted 1 line
board/sunxi/board.c +0
-0unsigned int gpio =CONFIG_SPL_SUNXI_LED_STATUS_BIT ;
And while at it I would rename this to something like:CONFIG_SPL_SUNXI_LED_STATUS_GPIO since it indicates the GPIO number, not a specific bit in a sunxi-specific kind of register.
What do you think?
All the best,
Paul
Quoted 5 lines
board/sunxi/board.c +0
-0gpio_request (gpio,"gpio_led" );Signature · 1 line
2.46.4
Signature · 6 lines
Paul Kocialkowski, Free software developer - https://www.paulk.fr/ Independent contractor - sys-base - https://www.sys-base.io/ Contributor to fully free software support for selected hardware.
Re: [PATCH 1/3] sunxi: spl: fix SPL_SUNXI_LED active low configuration
Hi Paul,
Quoted 19 lines · Paul Kocialkowski
Hi,
Quoted 16 lines · Andre Przywara
The newly introduced Allwinner SPL LED "framework" defined a
SPL_SUNXI_LED_STATUS_STATEKconfigsymbol, that was supposed to denote the active-low vs. active-high polarity of the LED. However this is a bool symbol, so it will simply vanish if not defined, and we cannot use it directly inside a C statement.Filter the symbol through the
IS_ENABLED()macro, which will return 0 if the symbol is not defined, which is the intended value here.This fixes configuring LEDs with active-low polarity.
Signed-off-by Andre Przywara <[email protected]>--- board/sunxi/board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
board/sunxi/board.c static void sunxi_spl_store_dram_size(phys_addr_t dram_size) · line 566
Quoted 10 lines
board/sunxi/board.c +1
-1@@ -563,7 +563,7 @@ static void sunxi_spl_store_dram_size(phys_addr_t dram_size)static void status_led_init (void ) {#if CONFIG_IS_ENABLED (SUNXI_LED_STATUS ) -unsigned int state =CONFIG_SPL_SUNXI_LED_STATUS_STATE ; +unsigned int state =IS_ENABLED (CONFIG_SPL_SUNXI_LED_STATUS_STATE );Sorry I didn't react to the initial submission, but it feels like the
CONFIG_SPL_SUNXI_LED_STATUS_STATEsymbol really means active-high if enabled and active-low if disabled. The name would suggest that it's an int with a value of either 0 or 1 instead.
Yeah, I lazily renamed the old CONFIG_LED_STATUS_STATE which used to be an int range (0..2) and made it both specific for Allwinner as well as changing it into a bool.
Quoted 3 lines
I think it would be less confusing to call the symbol
CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_LOWand reverse its meaning, so that we can spare defining it in most configs (that will be active-high).
You can also have
default y
in your symbol to not have to reverse the meaning.
Quoted 4 lines
Also the description currently mentions "initial state" which may be confusing as it could refer to the state inherited after reset (e.g. due to some pull resistor) or the state we do set in the SPL.
It was the prompt for the now removed LED_STATUS_STATE. What are you suggesting instead?
Quoted 6 lines
board/sunxi/board.c static void sunxi_spl_store_dram_size(phys_addr_t dram_size) · line 567
Quoted 1 line
board/sunxi/board.c +0
-0unsigned int gpio =CONFIG_SPL_SUNXI_LED_STATUS_BIT ;And while at it I would rename this to something like:
CONFIG_SPL_SUNXI_LED_STATUS_GPIOsince it indicates the GPIO number, not a specific bit in a sunxi-specific kind of register.
Also a remnant of LED_STATUS_BIT* symbols. Either work for me.
Cheers,
Quentin
Re: [PATCH 1/3] sunxi: spl: fix SPL_SUNXI_LED active low configuration
Hi Quentin, Paul,
ah, it seems like LEDs are the "embedded bike shed", let me add my shade of blue ;-)
Quoted 42 lines · Quentin Schulz
Hi Paul,
Quoted 19 lines · Paul Kocialkowski
Hi,
Quoted 16 lines · Andre Przywara
The newly introduced Allwinner SPL LED "framework" defined a
SPL_SUNXI_LED_STATUS_STATEKconfigsymbol, that was supposed to denote the active-low vs. active-high polarity of the LED. However this is a bool symbol, so it will simply vanish if not defined, and we cannot use it directly inside a C statement.Filter the symbol through the
IS_ENABLED()macro, which will return 0 if the symbol is not defined, which is the intended value here.This fixes configuring LEDs with active-low polarity.
Signed-off-by Andre Przywara <[email protected]>---
board/sunxi/board.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)Quoted 17 lines
board/sunxi/board.c static void sunxi_spl_store_dram_size(phys_addr_t · line 567
Quoted 11 lines
board/sunxi/board.c +1
-1@@ -563,7 +563,7 @@ static void sunxi_spl_store_dram_size(phys_addr_t dram_size) static void status_led_init(void) { #if CONFIG_IS_ENABLED(SUNXI_LED_STATUS) - unsigned int state = CONFIG_SPL_SUNXI_LED_STATUS_STATE; + unsigned int state = IS_ENABLED(CONFIG_SPL_SUNXI_LED_STATUS_STATE);Sorry I didn't react to the initial submission, but it feels like the
CONFIG_SPL_SUNXI_LED_STATUS_STATEsymbol really means active-high if enabled and active-low if disabled. The name would suggest that it's an int with a value of either 0 or 1 instead.Yeah, I lazily renamed the old
CONFIG_LED_STATUS_STATEwhich used to be an int range (0..2) and made it both specific for Allwinner as well as changing it into a bool.
Quoted 7 lines
Quoted 3 lines
I think it would be less confusing to call the symbol
CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_LOWand reverse its meaning, so that we can spare defining it in most configs (that will be active-high).You can also have
default y
in your symbol to not have to reverse the meaning.
So what about:
config CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH
default y
then?
Quoted 7 lines
Quoted 5 lines
Also the description currently mentions "initial state" which may be confusing as it could refer to the state inherited after reset (e.g. due to some pull resistor) or the state we do set in the SPL.
It was the prompt for the now removed
LED_STATUS_STATE. What are you suggesting instead?
I came up with:
Whether the GPIO of the status LED must be set high or low to turn the LED on. Thoughts?
Quoted 9 lines
Quoted 7 lines
board/sunxi/board.c static void sunxi_spl_store_dram_size(phys_addr_t dram_size) · line 567
Quoted 2 lines
board/sunxi/board.c +0
-0unsigned int gpio = CONFIG_SPL_SUNXI_LED_STATUS_BIT;And while at it I would rename this to something like:
CONFIG_SPL_SUNXI_LED_STATUS_GPIOsince it indicates the GPIO number, not a specific bit in a sunxi-specific kind of register.Also a remnant of LED_STATUS_BIT* symbols. Either work for me.
Yes, indeed CONFIG_LED_STATUS_GPIO makes much more sense.
Let me know what you think.
Cheers,
Andre
Quoted 3 lines
Cheers,
Quentin
Re: [PATCH 1/3] sunxi: spl: fix SPL_SUNXI_LED active low configuration
Hi Andre,
Quoted 76 lines · Andre Przywara
Hi Quentin, Paul,
ah, it seems like LEDs are the "embedded bike shed", let me add my shade of blue ;-)
Quoted 43 lines · Quentin Schulz
Hi Paul,
Quoted 28 lines · Paul Kocialkowski
Hi,
Quoted 25 lines · Andre Przywara
The newly introduced Allwinner SPL LED "framework" defined a
SPL_SUNXI_LED_STATUS_STATEKconfigsymbol, that was supposed to denote the active-low vs. active-high polarity of the LED. However this is a bool symbol, so it will simply vanish if not defined, and we cannot use it directly inside a C statement.Filter the symbol through the
IS_ENABLED()macro, which will return 0 if the symbol is not defined, which is the intended value here.This fixes configuring LEDs with active-low polarity.
Signed-off-by Andre Przywara <[email protected]>---
board/sunxi/board.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)board/sunxi/board.c +0
-0@@ -563,7 +563,7 @@ static void sunxi_spl_store_dram_size(phys_addr_t dram_size) static void status_led_init(void) { #if CONFIG_IS_ENABLED(SUNXI_LED_STATUS)Quoted 9 lines
board/sunxi/board.c static void · line 568
Quoted 3 lines
board/sunxi/board.c +1
-1- unsigned int state = CONFIG_SPL_SUNXI_LED_STATUS_STATE; + unsigned int state =IS_ENABLED (CONFIG_SPL_SUNXI_LED_STATUS_STATE );Sorry I didn't react to the initial submission, but it feels like the
CONFIG_SPL_SUNXI_LED_STATUS_STATEsymbol really means active-high if enabled and active-low if disabled. The name would suggest that it's an int with a value of either 0 or 1 instead.Yeah, I lazily renamed the old
CONFIG_LED_STATUS_STATEwhich used to be an int range (0..2) and made it both specific for Allwinner as well as changing it into a bool.Quoted 7 lines
Quoted 3 lines
I think it would be less confusing to call the symbol
CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_LOWand reverse its meaning, so that we can spare defining it in most configs (that will be active-high).You can also have
default y
in your symbol to not have to reverse the meaning.So what about:
configCONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH
default y
then?Quoted 7 lines
Quoted 5 lines
Also the description currently mentions "initial state" which may be confusing as it could refer to the state inherited after reset (e.g. due to some pull resistor) or the state we do set in the SPL.
It was the prompt for the now removed
LED_STATUS_STATE. What are you suggesting instead?I came up with:
Whether the GPIO of the status LED must be set high or low to turn the LED on. Thoughts?Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
board/sunxi/board.c +0
-0unsigned int gpio = CONFIG_SPL_SUNXI_LED_STATUS_BIT;
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
And while at it I would rename this to something like:
CONFIG_SPL_SUNXI_LED_STATUS_GPIOsince it indicates the GPIO number, not a specific bit in a sunxi-specific kind of register.Also a remnant of LED_STATUS_BIT* symbols. Either work for me.
Yes, indeed
CONFIG_LED_STATUS_GPIOmakes much more sense.
CONFIG_SPL_SUNXI_LED_STATUS_GPIO I'm assuming?
Quoted 2 lines
Let me know what you think.
Ack to all but I also don't care too much about Allwinner. @Paul?
Cheers,
Quentin
Re: [PATCH 1/3] sunxi: spl: fix SPL_SUNXI_LED active low configuration
Hi,
Quoted 71 lines · Quentin Schulz
Hi Andre,
Quoted 68 lines · Andre Przywara
Hi Quentin, Paul,
ah, it seems like LEDs are the "embedded bike shed", let me add my shade of blue ;-)
Quoted 49 lines · Quentin Schulz
Hi Paul,
Quoted 32 lines · Paul Kocialkowski
Hi,
Quoted 29 lines · Andre Przywara
The newly introduced Allwinner SPL LED "framework" defined a
SPL_SUNXI_LED_STATUS_STATEKconfigsymbol, that was supposed to denote the active-low vs. active-high polarity of the LED. However this is a bool symbol, so it will simply vanish if not defined, and we cannot use
it directly inside a C statement.Filter the symbol through the
IS_ENABLED()macro, which will return 0 if
the symbol is not defined, which is the intended value here.This fixes configuring LEDs with active-low polarity.
Signed-off-by Andre Przywara <[email protected]>---
board/sunxi/board.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)board/sunxi/board.c +1
-1@@ -563,7 +563,7 @@ static void sunxi_spl_store_dram_size(phys_addr_t dram_size) static void status_led_init(void) { #if CONFIG_IS_ENABLED(SUNXI_LED_STATUS) - unsigned int state = CONFIG_SPL_SUNXI_LED_STATUS_STATE; + unsigned int state =Quoted 9 lines
board/sunxi/board.c static void · line 568
Quoted 1 line
board/sunxi/board.c +0
-0IS_ENABLED (CONFIG_SPL_SUNXI_LED_STATUS_STATE );Sorry I didn't react to the initial submission, but it feels like the
CONFIG_SPL_SUNXI_LED_STATUS_STATEsymbol really means active-high if enabled
and active-low if disabled. The name would suggest that it's an int with a value
of either 0 or 1 instead.Yeah, I lazily renamed the old
CONFIG_LED_STATUS_STATEwhich used to be an int range (0..2) and made it both specific for Allwinner as well as changing it into a bool.Quoted 8 lines
Quoted 4 lines
I think it would be less confusing to call the symbol
CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_LOWand reverse its meaning, so that we can
spare defining it in most configs (that will be active-high).You can also have
default y
in your symbol to not have to reverse the meaning.So what about:
configCONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH
default y
then?
Sounds good to me!
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Also the description currently mentions "initial state" which may be confusing
as it could refer to the state inherited after reset (e.g. due to some pull
resistor) or the state we do set in the SPL.
Quoted 7 lines
Quoted 7 lines
Quoted 2 lines
It was the prompt for the now removed
LED_STATUS_STATE. What are you suggesting instead?I came up with:
Whether the GPIO of the status LED must be set high or low to turn the LED on.
Thoughts?
Looks good.
Quoted 14 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
board/sunxi/board.c static void sunxi_spl_store_dram_size(phys_addr_t dram_size) · line 567
Quoted 2 lines
board/sunxi/board.c +0
-0unsigned int gpio = CONFIG_SPL_SUNXI_LED_STATUS_BIT;And while at it I would rename this to something like:
CONFIG_SPL_SUNXI_LED_STATUS_GPIOsince it indicates the GPIO number, not a
specific bit in a sunxi-specific kind of register.Quoted 4 lines
Quoted 1 line
Also a remnant of LED_STATUS_BIT* symbols. Either work for me.
Yes, indeed
CONFIG_LED_STATUS_GPIOmakes much more sense.
Quoted 6 lines
CONFIG_SPL_SUNXI_LED_STATUS_GPIOI'm assuming?Quoted 2 lines
Let me know what you think.
Ack to all but I also don't care too much about Allwinner. @Paul?
Yes Andre's proposal sounds fine, I'm all for it.
Thanks for looking at this.
Paul
Signature · 6 lines
Paul Kocialkowski, Independent contractor - sys-base - https://www.sys-base.io/ Free software developer - https://www.paulk.fr/ Expert in multimedia, graphics and embedded hardware support with Linux.
PATCH 2/3 sunxi: configs: enable power LEDs on 32-bit boards
In reply to Andre PrzywaraWe recently gained a simple way to enable a power LED very early in the SPL boot, through simple Kconfig variables.
Add those symbols to those boards' defconfigs where the DT indicates a default-on power LED. The number used is <port bank> * 32 + <pin no>, an active low setup means CONFIG_SPL_SUNXI_LED_STATUS_STATE must be undefined.
This will light up the power LED very early in the (SPL) boot phase on those 32-bit boards.
--- configs/A13-OLinuXinoM_defconfig | 3 +++ configs/Bananapi_M2_Ultra_defconfig | 3 +++ configs/Bananapi_m2m_defconfig | 3 +++ configs/Mele_A1000G_quad_defconfig | 3 +++ configs/Mele_A1000_defconfig | 3 +++ configs/Mele_M9_defconfig | 3 +++ configs/bananapi_m1_plus_defconfig | 3 +++ configs/bananapi_m2_berry_defconfig | 3 +++ configs/bananapi_m2_zero_defconfig | 3 +++ configs/beelink_x2_defconfig | 3 +++ configs/icnova-a20-adb4006_defconfig | 3 +++ configs/nanopi_duo2_defconfig | 3 +++ configs/nanopi_neo_air_defconfig | 3 +++ configs/orangepi_2_defconfig | 3 +++ configs/orangepi_lite_defconfig | 3 +++ configs/orangepi_one_defconfig | 3 +++ configs/orangepi_pc_defconfig | 3 +++ configs/orangepi_zero_defconfig | 3 +++ configs/orangepi_zero_plus2_h3_defconfig | 3 +++ 19 files changed, 57 insertions(+)
configs/A13-OLinuXinoM_defconfig +3 -0
@@ -10,6 +10,9 @@ CONFIG_VIDEO_VGA_VIA_LCD=y CONFIG_VIDEO_VGA_VIA_LCD_FORCE_SYNC_ACTIVE_HIGH=y CONFIG_VIDEO_LCD_POWER="PB10" CONFIG_VIDEO_LCD_BL_PWM="PB2" +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=201 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SYS_I2C_MVTWSI=y CONFIG_SYS_I2C_SLAVE=0x7f
configs/Bananapi_M2_Ultra_defconfig +3 -0
@@ -5,6 +5,9 @@ CONFIG_DRAM_CLK=576 CONFIG_SPL=y CONFIG_MACH_SUN8I_R40=y CONFIG_MMC_SUNXI_SLOT_EXTRA=2 +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=244 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_HAS_ARMV7_SECURE_BASE is not set CONFIG_AHCI=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
configs/Bananapi_m2m_defconfig +3 -0
@@ -7,6 +7,9 @@ CONFIG_MACH_SUN8I_A33=y CONFIG_DRAM_ZQ=15291 CONFIG_DRAM_ODT_EN=y CONFIG_MMC_SUNXI_SLOT_EXTRA=2 +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=355 +# CONFIG_SPL_SUNXI_LED_STATUS_STATE is not set # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_FASTBOOT_CMD_OEM_FORMAT=y CONFIG_USB_EHCI_HCD=y
configs/Mele_A1000G_quad_defconfig +3 -0
@@ -4,6 +4,9 @@ CONFIG_DEFAULT_DEVICE_TREE="sun6i-a31-mele-a1000g-quad" CONFIG_SPL=y CONFIG_MACH_SUN6I=y CONFIG_DRAM_ZQ=120 +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=237 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_PHY_REALTEK=y CONFIG_ETH_DESIGNWARE=y
configs/Mele_A1000_defconfig +3 -0
@@ -5,6 +5,9 @@ CONFIG_SPL=y CONFIG_MACH_SUN4I=y CONFIG_VIDEO_VGA=y CONFIG_VIDEO_COMPOSITE=y +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=244 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y CONFIG_AHCI=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL_I2C=y
configs/Mele_M9_defconfig +3 -0
@@ -4,6 +4,9 @@ CONFIG_DEFAULT_DEVICE_TREE="sun6i-a31-m9" CONFIG_SPL=y CONFIG_MACH_SUN6I=y CONFIG_DRAM_ZQ=120 +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=237 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_PHY_REALTEK=y CONFIG_ETH_DESIGNWARE=y
configs/bananapi_m1_plus_defconfig +3 -0
@@ -6,6 +6,9 @@ CONFIG_SPL=y CONFIG_MACH_SUN7I=y CONFIG_VIDEO_COMPOSITE=y CONFIG_GMAC_TX_DELAY=3 +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=249 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y CONFIG_AHCI=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL_I2C=y
configs/bananapi_m2_berry_defconfig +3 -0
@@ -4,6 +4,9 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-v40-bananapi-m2-berry" CONFIG_DRAM_CLK=576 CONFIG_SPL=y CONFIG_MACH_SUN8I_R40=y +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=244 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_HAS_ARMV7_SECURE_BASE is not set CONFIG_AHCI=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
configs/bananapi_m2_zero_defconfig +3 -0
@@ -4,4 +4,7 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-h2-plus-bananapi-m2-zero" CONFIG_DRAM_CLK=408 CONFIG_SPL=y CONFIG_MACH_SUN8I_H3=y +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=362 +# CONFIG_SPL_SUNXI_LED_STATUS_STATE is not set # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
configs/beelink_x2_defconfig +3 -0
@@ -5,6 +5,9 @@ CONFIG_DRAM_CLK=567 CONFIG_SPL=y CONFIG_MACH_SUN8I_H3=y CONFIG_MMC_SUNXI_SLOT_EXTRA=2 +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=362 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y
configs/icnova-a20-adb4006_defconfig +3 -0
@@ -4,6 +4,9 @@ CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-icnova-a20-adb4006" CONFIG_DRAM_CLK=384 CONFIG_SPL=y CONFIG_MACH_SUN7I=y +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=245 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y CONFIG_AHCI=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL_I2C=y
configs/nanopi_duo2_defconfig +3 -0
@@ -5,6 +5,9 @@ CONFIG_DRAM_CLK=408 CONFIG_SPL=y CONFIG_MACH_SUN8I_H3=y # CONFIG_VIDEO_DE2 is not set +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=362 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_CONSOLE_MUX=y CONFIG_USB_EHCI_HCD=y
configs/nanopi_neo_air_defconfig +3 -0
@@ -5,6 +5,9 @@ CONFIG_DRAM_CLK=408 CONFIG_SPL=y CONFIG_MACH_SUN8I_H3=y # CONFIG_VIDEO_DE2 is not set +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=362 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_CONSOLE_MUX=y CONFIG_USB_EHCI_HCD=y
configs/orangepi_2_defconfig +3 -0
@@ -5,6 +5,9 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-orangepi-2" CONFIG_DRAM_CLK=672 CONFIG_SPL=y CONFIG_MACH_SUN8I_H3=y +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=362 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL_I2C=y CONFIG_SPL_SYS_I2C_LEGACY=y
configs/orangepi_lite_defconfig +3 -0
@@ -4,6 +4,9 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-orangepi-lite" CONFIG_DRAM_CLK=672 CONFIG_SPL=y CONFIG_MACH_SUN8I_H3=y +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=362 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_USB_EHCI_HCD=y CONFIG_USB_OHCI_HCD=y
configs/orangepi_one_defconfig +3 -0
@@ -4,6 +4,9 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-orangepi-one" CONFIG_DRAM_CLK=672 CONFIG_SPL=y CONFIG_MACH_SUN8I_H3=y +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=362 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y
configs/orangepi_pc_defconfig +3 -0
@@ -4,6 +4,9 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-orangepi-pc" CONFIG_DRAM_CLK=624 CONFIG_SPL=y CONFIG_MACH_SUN8I_H3=y +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=362 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL_I2C=y CONFIG_SPL_SYS_I2C_LEGACY=y
configs/orangepi_zero_defconfig +3 -0
@@ -6,6 +6,9 @@ CONFIG_SPL=y CONFIG_MACH_SUN8I_H3=y # CONFIG_VIDEO_DE2 is not set CONFIG_SPL_SPI_SUNXI=y +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=362 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_CONSOLE_MUX=y CONFIG_MTD=y
configs/orangepi_zero_plus2_h3_defconfig +3 -0
@@ -6,6 +6,9 @@ CONFIG_SPL=y CONFIG_MACH_SUN8I_H3=y # CONFIG_DRAM_ODT_EN is not set CONFIG_MMC_SUNXI_SLOT_EXTRA=2 +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=362 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y
Signature · 1 line
2.46.4
PATCH 3/3 sunxi: configs: enable power LEDs on 64-bit boards
In reply to Andre PrzywaraWe recently gained a simple way to enable a power LED very early in the SPL boot, through simple Kconfig variables.
Add those symbols to those boards' defconfigs where the DT indicates a default-on power LED. The number used is <port bank> * 32 + <pin no>, an active low setup means CONFIG_SPL_SUNXI_LED_STATUS_STATE must be undefined.
This will light up the power LED very early in the (SPL) boot phase on those 64-bit boards.
--- configs/anbernic_rg35xx_h700_defconfig | 3 +++ configs/bananapi_m64_defconfig | 3 +++ configs/beelink_gs1_defconfig | 3 +++ configs/liontron-h-a133l_defconfig | 3 +++ configs/nanopi_neo2_defconfig | 3 +++ configs/nanopi_neo_plus2_defconfig | 3 +++ configs/orangepi_3_defconfig | 3 +++ configs/orangepi_lite2_defconfig | 3 +++ configs/orangepi_pc2_defconfig | 3 +++ configs/orangepi_prime_defconfig | 3 +++ configs/orangepi_zero2_defconfig | 3 +++ configs/orangepi_zero_plus2_defconfig | 3 +++ configs/orangepi_zero_plus_defconfig | 3 +++ configs/radxa-cubie-a5e_defconfig | 3 +++ configs/tanix_tx1_defconfig | 3 +++ 15 files changed, 45 insertions(+)
configs/anbernic_rg35xx_h700_defconfig +3 -0
@@ -16,6 +16,9 @@ CONFIG_DRAM_SUNXI_PHY_ADDR_MAP_1=y CONFIG_MACH_SUN50I_H616=y CONFIG_SUNXI_DRAM_H616_LPDDR4=y CONFIG_R_I2C_ENABLE=y +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=268 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y CONFIG_SPL_I2C=y CONFIG_SPL_SYS_I2C_LEGACY=y CONFIG_SYS_I2C_MVTWSI=y
configs/bananapi_m64_defconfig +3 -0
@@ -4,6 +4,9 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64" CONFIG_SPL=y CONFIG_MACH_SUN50I=y CONFIG_MMC_SUNXI_SLOT_EXTRA=2 +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=120 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SUPPORT_EMMC_BOOT=y CONFIG_SUN8I_EMAC=y
configs/beelink_gs1_defconfig +3 -0
@@ -5,6 +5,9 @@ CONFIG_SPL=y CONFIG_MACH_SUN50I_H6=y CONFIG_SUNXI_DRAM_H6_LPDDR3=y CONFIG_MMC_SUNXI_SLOT_EXTRA=2 +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=356 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_PSCI_RESET is not set # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_LED=y
configs/liontron-h-a133l_defconfig +3 -0
@@ -23,6 +23,9 @@ CONFIG_MACH_SUN50I_A133=y CONFIG_SUNXI_DRAM_A133_LPDDR4=y CONFIG_MMC_SUNXI_SLOT_EXTRA=2 CONFIG_R_I2C_ENABLE=y +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=240 +# CONFIG_SPL_SUNXI_LED_STATUS_STATE is not set # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL_I2C=y CONFIG_SPL_SYS_I2C_LEGACY=y
configs/nanopi_neo2_defconfig +3 -0
@@ -6,6 +6,9 @@ CONFIG_SPL=y CONFIG_MACH_SUN50I_H5=y CONFIG_DRAM_ZQ=3881977 # CONFIG_DRAM_ODT_EN is not set +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=362 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y
configs/nanopi_neo_plus2_defconfig +3 -0
@@ -7,6 +7,9 @@ CONFIG_MACH_SUN50I_H5=y CONFIG_DRAM_ZQ=3881977 # CONFIG_DRAM_ODT_EN is not set CONFIG_MMC_SUNXI_SLOT_EXTRA=2 +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=362 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y
configs/orangepi_3_defconfig +3 -0
@@ -6,6 +6,9 @@ CONFIG_MACH_SUN50I_H6=y CONFIG_SUNXI_DRAM_H6_LPDDR3=y CONFIG_MMC_SUNXI_SLOT_EXTRA=2 CONFIG_BLUETOOTH_DT_DEVICE_FIXUP="brcm,bcm4345c5" +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=356 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_PHY_SUN50I_USB3=y CONFIG_USB_XHCI_HCD=y
configs/orangepi_lite2_defconfig +3 -0
@@ -4,6 +4,9 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h6-orangepi-lite2" CONFIG_SPL=y CONFIG_MACH_SUN50I_H6=y CONFIG_SUNXI_DRAM_H6_LPDDR3=y +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=356 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_PSCI_RESET is not set # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_USB_EHCI_HCD=y
configs/orangepi_pc2_defconfig +3 -0
@@ -6,6 +6,9 @@ CONFIG_SPL=y CONFIG_MACH_SUN50I_H5=y CONFIG_DRAM_ZQ=3881977 CONFIG_SPL_SPI_SUNXI=y +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=362 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL_I2C=y CONFIG_SPL_SYS_I2C_LEGACY=y
configs/orangepi_prime_defconfig +3 -0
@@ -6,6 +6,9 @@ CONFIG_SPL=y CONFIG_MACH_SUN50I_H5=y CONFIG_DRAM_ZQ=3881977 # CONFIG_DRAM_ODT_EN is not set +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=362 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y
configs/orangepi_zero2_defconfig +3 -0
@@ -10,6 +10,9 @@ CONFIG_MACH_SUN50I_H616=y CONFIG_SUNXI_DRAM_H616_DDR3_1333=y CONFIG_R_I2C_ENABLE=y CONFIG_SPL_SPI_SUNXI=y +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=76 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL_I2C=y CONFIG_SPL_SYS_I2C_LEGACY=y
configs/orangepi_zero_plus2_defconfig +3 -0
@@ -7,6 +7,9 @@ CONFIG_MACH_SUN50I_H5=y CONFIG_DRAM_ZQ=3881977 # CONFIG_DRAM_ODT_EN is not set CONFIG_MMC_SUNXI_SLOT_EXTRA=2 +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=362 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y
configs/orangepi_zero_plus_defconfig +3 -0
@@ -6,6 +6,9 @@ CONFIG_SPL=y CONFIG_MACH_SUN50I_H5=y CONFIG_DRAM_ZQ=3881977 # CONFIG_DRAM_ODT_EN is not set +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=362 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y
configs/radxa-cubie-a5e_defconfig +3 -0
@@ -15,6 +15,9 @@ CONFIG_DRAM_SUNXI_TPR12=0x3533302f CONFIG_MACH_SUN55I_A523=y CONFIG_MMC_SUNXI_SLOT_EXTRA=2 CONFIG_R_I2C_ENABLE=y +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=356 +# CONFIG_SPL_SUNXI_LED_STATUS_STATE is not set # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL_I2C=y CONFIG_SPL_SYS_I2C_LEGACY=y
configs/tanix_tx1_defconfig +3 -0
@@ -14,6 +14,9 @@ CONFIG_MACH_SUN50I_H616=y CONFIG_SUNXI_DRAM_H616_LPDDR3=y CONFIG_MMC_SUNXI_SLOT_EXTRA=2 CONFIG_R_I2C_ENABLE=y +CONFIG_SPL_SUNXI_LED_STATUS=y +CONFIG_SPL_SUNXI_LED_STATUS_BIT=231 +CONFIG_SPL_SUNXI_LED_STATUS_STATE=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL_I2C=y CONFIG_SPL_SYS_I2C_LEGACY=y
Signature · 1 line
2.46.4