iio: humidity: ens210: Fix missing I2C functionality checks
PATCH v3 1/1 iio: humidity: ens210: Fix missing I2C functionality checks
The ENS210 driver uses SMBus transactions (such as byte, word, and block data reads/writes) during the probe and measurement phases. However, the initial functionality check only validated a subset of these capabilities, which could lead to loading failures on adapters requiring SMBus emulation or native-only controllers.
To ensure compatibility across a wide range of I2C adapters, modify the functionality check to verify if the adapter supports the required native operations or, failing that, supports the SMBus emulation layer.
---
Changes since v2:
- Fixed the alignment and indentation of the I2C functionality check per Maxime's review.
Changes since v1:
- Updated the I2C functionality test to check for both required native operations and SMBus emulation (I2C_FUNC_SMBUS_EMUL) to prevent loading issues on controllers lacking the emulation flag.
drivers/iio/humidity/ens210.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/iio/humidity/ens210.c +7 -3
@@ -202,9 +202,13 @@ static int ens210_probe(struct i2c_client *client)int ret;if (!i2c_check_functionality (client->adapter, -I2C_FUNC_SMBUS_WRITE_BYTE_DATA | -I2C_FUNC_SMBUS_WRITE_BYTE | -I2C_FUNC_SMBUS_READ_I2C_BLOCK )) { +I2C_FUNC_SMBUS_WRITE_BYTE_DATA | +I2C_FUNC_SMBUS_WRITE_BYTE | +I2C_FUNC_SMBUS_READ_BYTE_DATA | +I2C_FUNC_SMBUS_READ_WORD_DATA | +I2C_FUNC_SMBUS_READ_I2C_BLOCK ) && + !i2c_check_functionality (client->adapter, +I2C_FUNC_SMBUS_EMUL )) {return dev_err_probe (&client->dev, -EOPNOTSUPP ,"adapter does not support some i2c transactions\n" ); }
Signature · 1 line
2.43.0
Quoted 9 lines · Salah Triki
The ENS210 driver uses SMBus transactions (such as byte, word, and block data reads/writes) during the probe and measurement phases. However, the initial functionality check only validated a subset of these capabilities, which could lead to loading failures on adapters requiring SMBus emulation or native-only controllers.
To ensure compatibility across a wide range of I2C adapters, modify the functionality check to verify if the adapter supports the required native operations or, failing that, supports the SMBus emulation layer.
...
Quoted 4 lines
---
Changes since v2:
- Fixed the alignment and indentation of the I2C functionality check per Maxime's review.
???
...
drivers/iio/humidity/ens210.c static int ens210_probe(struct i2c_client *client) · line 209
Quoted 9 lines
drivers/iio/humidity/ens210.c +5
-3if (!i2c_check_functionality(client->adapter, -I2C_FUNC_SMBUS_WRITE_BYTE_DATA | -I2C_FUNC_SMBUS_WRITE_BYTE | -I2C_FUNC_SMBUS_READ_I2C_BLOCK )) { + I2C_FUNC_SMBUS_WRITE_BYTE_DATA | + I2C_FUNC_SMBUS_WRITE_BYTE | + I2C_FUNC_SMBUS_READ_BYTE_DATA | + I2C_FUNC_SMBUS_READ_WORD_DATA | + I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&
The above was the correct one.
drivers/iio/humidity/ens210.c static int ens210_probe(struct i2c_client *client) · line 211
Quoted 2 lines
drivers/iio/humidity/ens210.c +2
-0+ !i2c_check_functionality(client->adapter, + I2C_FUNC_SMBUS_EMUL)) {
This one is now wrong.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 1 line · Andy Shevchenko
On Tue, May 05, 2026 at 06:49:43PM +0100, Salah Triki wrote:
...
Quoted 4 lines
drivers/iio/humidity/ens210.c static int ens210_probe(struct i2c_client *client) · line 211
Quoted 2 lines
drivers/iio/humidity/ens210.c +2
-0+ !i2c_check_functionality(client->adapter, + I2C_FUNC_SMBUS_EMUL)) {This one is now wrong.
I meant this *indentation* is now wrong.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 4 lines · Andy Shevchenko
Quoted 1 line · Andy Shevchenko
On Tue, May 05, 2026 at 06:49:43PM +0100, Salah Triki wrote:
Quoted 9 lines
...
Quoted 4 lines
drivers/iio/humidity/ens210.c static int ens210_probe(struct i2c_client *client) · line 211
Quoted 2 lines
drivers/iio/humidity/ens210.c +2
-0+ !i2c_check_functionality(client->adapter, + I2C_FUNC_SMBUS_EMUL)) {This one is now wrong.
I meant this *indentation* is now wrong.
Did something happen to that when I sent the email? Or maybe I'm just going insane...
slightly confused,
max
Quoted 6 lines
--
With Best Regards,
Andy Shevchenko
Quoted 4 lines · Maxwell Doose
Quoted 2 lines · Andy Shevchenko
Quoted 1 line · Andy Shevchenko
On Tue, May 05, 2026 at 06:49:43PM +0100, Salah Triki wrote:
...
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
drivers/iio/humidity/ens210.c static int ens210_probe(struct i2c_client *client) · line 211
Quoted 2 lines
drivers/iio/humidity/ens210.c +2
-0+ !i2c_check_functionality(client->adapter, + I2C_FUNC_SMBUS_EMUL)) {This one is now wrong.
I meant this *indentation* is now wrong.
Did something happen to that when I sent the email? Or maybe I'm just going insane...
Sounds like latter one? :-)
Quoted 1 line
slightly confused,
In short this is if (foo(A) && foo(B)), and foo should be indented on the same column while their parameters on different but still same. In your example the foo(B) is indented as A parameter on previous call instead of indenting as foo(...).
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 12 lines · Andy Shevchenko
Quoted 4 lines · Maxwell Doose
Quoted 2 lines · Andy Shevchenko
Quoted 1 line · Andy Shevchenko
On Tue, May 05, 2026 at 06:49:43PM +0100, Salah Triki wrote:
...
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
drivers/iio/humidity/ens210.c +2
-0+ !i2c_check_functionality(client->adapter, + I2C_FUNC_SMBUS_EMUL)) {
Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
This one is now wrong.
I meant this *indentation* is now wrong.
Did something happen to that when I sent the email? Or maybe I'm just going insane...
Sounds like latter one? :-)
Probably true :)
In all seriousness though I need to slow down...
Quoted 8 lines
Quoted 2 lines
slightly confused,
In short this is
if (foo(A) && foo(B)), and foo should be indented on the same column while their parameters on different but still same. In your example the foo(B) is indented as A parameter on previous call instead of indenting as foo(...).
Mk, thanks for pointing that out to me.
best regards,
max
Quoted 5 lines
--
With Best Regards,
Andy Shevchenko