Skip to contentSkip to conversation

iio: humidity: ens210: Fix missing I2C functionality checks

PATCH Superseded Salah Triki 3 participants 3 messages May 5 – May 6 IIO

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 iio: humidity: ens210: Fix missing I2C functionality checks

The ENS210 driver uses SMBus transactions (such as byte, word, and block data reads/writes) during the probe and measurement phases. However, the initial functionality check only validated a subset of these capabilities, which could lead to loading failures on adapters requiring SMBus emulation or native-only controllers.

To ensure compatibility across a wide range of I2C adapters, modify the functionality check to verify if the adapter supports the required native operations or, failing that, supports the SMBus emulation layer.

Fixes c524fbca672e ("iio: humidity: Add support for ENS210")
---
 drivers/iio/humidity/ens210.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/iio/humidity/ens210.c +6 -3
index 77418d97f30d..c722087bc188 100644
@@ -202,9 +202,12 @@ static int ens210_probe(struct i2c_client *client)
 	int ret;
 
 	if (!i2c_check_functionality(client->adapter,
-				     I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
-				     I2C_FUNC_SMBUS_WRITE_BYTE |
-				     I2C_FUNC_SMBUS_READ_I2C_BLOCK)) {
+				I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
+				I2C_FUNC_SMBUS_WRITE_BYTE |
+				I2C_FUNC_SMBUS_READ_BYTE_DATA |
+				I2C_FUNC_SMBUS_READ_WORD_DATA |
+				I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&
+			!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_EMUL)) {
 		return dev_err_probe(&client->dev, -EOPNOTSUPP,
 			"adapter does not support some i2c transactions\n");
 	}
Signature · 1 line
2.43.0
#1 lore raw
Quoted 16 lines · Salah Triki

The ENS210 driver uses SMBus transactions (such as byte, word, and block data reads/writes) during the probe and measurement phases. However, the initial functionality check only validated a subset of these capabilities, which could lead to loading failures on adapters requiring SMBus emulation or native-only controllers.

To ensure compatibility across a wide range of I2C adapters, modify the functionality check to verify if the adapter supports the required native operations or, failing that, supports the SMBus emulation layer.

Fixes c524fbca672e ("iio: humidity: Add support for ENS210")
---
 drivers/iio/humidity/ens210.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

[snip]

drivers/iio/humidity/ens210.c static int ens210_probe(struct i2c_client *client) · line 213

Quoted 13 lines
drivers/iio/humidity/ens210.c +6 -3
 	if (!i2c_check_functionality(client->adapter,
-				     I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
-				     I2C_FUNC_SMBUS_WRITE_BYTE |
-				     I2C_FUNC_SMBUS_READ_I2C_BLOCK)) {
+				I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
+				I2C_FUNC_SMBUS_WRITE_BYTE |
+				I2C_FUNC_SMBUS_READ_BYTE_DATA |
+				I2C_FUNC_SMBUS_READ_WORD_DATA |
+				I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&
+			!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_EMUL)) {
 		return dev_err_probe(&client->dev, -EOPNOTSUPP,
 			"adapter does not support some i2c transactions\n");
 	}

This alignment doesn't look right. Probably should be something like:

if (!i2c_check_functionality(client->adapter,

				     I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
				     I2C_FUNC_SMBUS_WRITE_BYTE |
				     I2C_FUNC_SMBUS_READ_BYTE_DATA |
				     I2C_FUNC_SMBUS_READ_WORD_DATA |
				     I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&
 			             !i2c_check_functionality(client->adapter, 
							      I2C_FUNC_SMBUS_EMUL)) {

best regards,
max

#2 lore raw
Quoted 4 lines · Maxwell Doose

On Tue May 5, 2026 at 12:22 PM CDT, Salah Triki wrote:

[snip]

Quoted 15 lines

drivers/iio/humidity/ens210.c static int ens210_probe(struct i2c_client *client) · line 213

Quoted 13 lines
drivers/iio/humidity/ens210.c +6 -3
 	if (!i2c_check_functionality(client->adapter,
-				     I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
-				     I2C_FUNC_SMBUS_WRITE_BYTE |
-				     I2C_FUNC_SMBUS_READ_I2C_BLOCK)) {
+				I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
+				I2C_FUNC_SMBUS_WRITE_BYTE |
+				I2C_FUNC_SMBUS_READ_BYTE_DATA |
+				I2C_FUNC_SMBUS_READ_WORD_DATA |
+				I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&
+			!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_EMUL)) {
 		return dev_err_probe(&client->dev, -EOPNOTSUPP,
 			"adapter does not support some i2c transactions\n");
 	}

This alignment doesn't look right. Probably should be something like:

However the end result is wrong, this one...

Quoted 8 lines

if (!i2c_check_functionality(client->adapter,

				     I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
				     I2C_FUNC_SMBUS_WRITE_BYTE |
				     I2C_FUNC_SMBUS_READ_BYTE_DATA |
				     I2C_FUNC_SMBUS_READ_WORD_DATA |
				     I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&
 			             !i2c_check_functionality(client->adapter, 
							      I2C_FUNC_SMBUS_EMUL)) {

...is also wrong.

if (!i2c_check_functionality(client->adapter,

			     I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
			     I2C_FUNC_SMBUS_WRITE_BYTE |
			     I2C_FUNC_SMBUS_READ_BYTE_DATA |
			     I2C_FUNC_SMBUS_READ_WORD_DATA |
			     I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&
    !i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_EMUL)) {
Signature · 2 lines
With Best Regards,
Andy Shevchenko