Skip to contentSkip to conversation

iio: humidity: ens210: Fix missing I2C functionality checks

PATCH In review Salah Triki 4 participants 5 messages May 6 IIO

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 iio: humidity: ens210: Fix missing I2C functionality checks

The ENS210 driver uses SMBus transactions (such as byte, word, and block data reads/writes) during the probe and measurement phases. However, the initial functionality check only validated a subset of these capabilities, which could lead to loading failures on adapters requiring SMBus emulation or native-only controllers.

To ensure compatibility across a wide range of I2C adapters, modify the functionality check to verify if the adapter supports the required native operations or, failing that, supports the SMBus emulation layer.

Fixes c524fbca672e ("iio: humidity: Add support for ENS210")

---
Changes since v4:
- Fixed the alignment and indentation of the I2C functionality check per Andy's review.

Changes since v3:
- Fixed the alignment and indentation of the I2C functionality check per Andy's review.

Changes since v2:
- Fixed the alignment and indentation of the I2C functionality check per Maxime's review.

Changes since v1:
- Updated the I2C functionality test to check for both required native operations and SMBus emulation (I2C_FUNC_SMBUS_EMUL) to prevent loading issues on controllers lacking the emulation flag.

 drivers/iio/humidity/ens210.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/iio/humidity/ens210.c +4 -1
index 77418d97f30d..159a3c158c9f 100644
@@ -204,7 +204,10 @@ static int ens210_probe(struct i2c_client *client)
 	if (!i2c_check_functionality(client->adapter,
 				     I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
 				     I2C_FUNC_SMBUS_WRITE_BYTE |
-				     I2C_FUNC_SMBUS_READ_I2C_BLOCK)) {
+				     I2C_FUNC_SMBUS_READ_BYTE_DATA |
+				     I2C_FUNC_SMBUS_READ_WORD_DATA |
+				     I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&
+	    !i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_EMUL)) {
 		return dev_err_probe(&client->dev, -EOPNOTSUPP,
 			"adapter does not support some i2c transactions\n");
 	}
Signature · 1 line
2.43.0
#1 lore raw
Quoted 7 lines · Salah Triki

The ENS210 driver uses SMBus transactions (such as byte, word, and block data reads/writes) during the probe and measurement phases. However, the initial functionality check only validated a subset of these capabilities, which could lead to loading failures on adapters requiring SMBus emulation or native-only controllers.

Quoted 7 lines

To ensure compatibility across a wide range of I2C adapters, modify the functionality check to verify if the adapter supports the required native operations or, failing that, supports the SMBus emulation layer.

Fixes c524fbca672e ("iio: humidity: Add support for ENS210")

---

Please slow down, you've sent two versions in the past 30 minutes.

Alignment is fine, but refrain from sending patches that quickly.

Signature · 3 lines
Kind regards

CJD
maintainer
#2 lore raw
Quoted 12 lines · On Wed, 6 May 2026 12:17:42 +0200 Joshua Crofts <[email protected]>…
Quoted 11 lines · Salah Triki

The ENS210 driver uses SMBus transactions (such as byte, word, and block data reads/writes) during the probe and measurement phases. However, the initial functionality check only validated a subset of these capabilities, which could lead to loading failures on adapters requiring SMBus emulation or native-only controllers.

To ensure compatibility across a wide range of I2C adapters, modify the functionality check to verify if the adapter supports the required native operations or, failing that, supports the SMBus emulation layer.

Quoted 8 lines
Quoted 3 lines
Fixes c524fbca672e ("iio: humidity: Add support for ENS210")

---

Please slow down, you've sent two versions in the past 30 minutes.

Alignment is fine, but refrain from sending patches that quickly.

The comments I just sent indeed applied to v2... So good advice that you should slow down!

J

Reviewed-by on v5 1/1
#3 lore raw
In reply to Salah Triki
Quoted 9 lines · Salah Triki

The ENS210 driver uses SMBus transactions (such as byte, word, and block data reads/writes) during the probe and measurement phases. However, the initial functionality check only validated a subset of these capabilities, which could lead to loading failures on adapters requiring SMBus emulation or native-only controllers.

To ensure compatibility across a wide range of I2C adapters, modify the functionality check to verify if the adapter supports the required native operations or, failing that, supports the SMBus emulation layer.

As Joshua said, next time respect the rules, id est no new version for at least 24h+ period of time. Give others chance to review.

This one, although, is small,

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#4 lore raw
In reply to Salah Triki
Quoted 11 lines · On Wed, 6 May 2026 10:58:35 +0100 Salah Triki <[email protected]> wrote:

The ENS210 driver uses SMBus transactions (such as byte, word, and block data reads/writes) during the probe and measurement phases. However, the initial functionality check only validated a subset of these capabilities, which could lead to loading failures on adapters requiring SMBus emulation or native-only controllers.

To ensure compatibility across a wide range of I2C adapters, modify the functionality check to verify if the adapter supports the required native operations or, failing that, supports the SMBus emulation layer.

Fixes c524fbca672e ("iio: humidity: Add support for ENS210")

Are there any known i2c adapters that this actually applies to? Feels to me like hardening against unexpected results rather than a real fix. So probably drop the tag.

Quoted 10 lines

---
Changes since v4:
- Fixed the alignment and indentation of the I2C functionality check per Andy's review.

Changes since v3:
- Fixed the alignment and indentation of the I2C functionality check per Andy's review.

Quoted 8 lines

Changes since v2:
- Fixed the alignment and indentation of the I2C functionality check per Maxime's review.

Changes since v1:
- Updated the I2C functionality test to check for both required native operations and SMBus emulation (I2C_FUNC_SMBUS_EMUL) to prevent loading issues on controllers lacking the emulation flag.

That one is spurious. See below. A device on a bus doesn't care how these bus operations are occurring so should never be messing with that define.

Quoted 9 lines
 drivers/iio/humidity/ens210.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/iio/humidity/ens210.c +0 -0
index 77418d97f30d..159a3c158c9f 100644

drivers/iio/humidity/ens210.c static int ens210_probe(struct i2c_client *client) · line 209

Quoted 7 lines
drivers/iio/humidity/ens210.c +3 -1
@@ -204,7 +204,10 @@ static int ens210_probe(struct i2c_client *client)
 	if (!i2c_check_functionality(client->adapter,
 				     I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
 				     I2C_FUNC_SMBUS_WRITE_BYTE |
-				     I2C_FUNC_SMBUS_READ_I2C_BLOCK)) {
+				     I2C_FUNC_SMBUS_READ_BYTE_DATA |
+				     I2C_FUNC_SMBUS_READ_WORD_DATA |
+				     I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&

Look at definitions of:
I2C_FUNC_SMBUS_BYTE_DATA and I2C_FUNC_SMUS_WORD_DATA

As you might imagine it's common to want the pairs or read and write so there are macros for it.

drivers/iio/humidity/ens210.c static int ens210_probe(struct i2c_client *client) · line 210

Quoted 1 line
drivers/iio/humidity/ens210.c +1 -0
+	    !i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_EMUL)) {

I don't follow the point in this check. See how I2C_FUNC_SMBUS_EMUL is defined

#define I2C_FUNC_SMBUS_EMUL		(I2C_FUNC_SMBUS_QUICK | \
					 I2C_FUNC_SMBUS_BYTE | \
					 I2C_FUNC_SMBUS_BYTE_DATA | \
					 I2C_FUNC_SMBUS_WORD_DATA | \
					 I2C_FUNC_SMBUS_PROC_CALL | \
					 I2C_FUNC_SMBUS_WRITE_BLOCK_DATA | \
					 I2C_FUNC_SMBUS_I2C_BLOCK | \
					 I2C_FUNC_SMBUS_PEC)

So if that passes the earlier one already passed as it's a subset.

Quoted 3 lines
drivers/iio/humidity/ens210.c +0 -0
 		return dev_err_probe(&client->dev, -EOPNOTSUPP,
 			"adapter does not support some i2c transactions\n");
 	}