Convert shell-based ACL test (tacl_xattr.sh) to C
cover Convert shell-based ACL test (tacl_xattr.sh) to C
This patch series converts the existing shell-based ACL test (tacl_xattr.sh) to C implementation, providing better integration with the LTP test framework and more precise control over test execution.
Partially closes(convert tacl_xattr.sh to C)
https://github.com/linux-test-project/ltp/issues/1265
The conversion splits functionality into seven focused test files. Patch 1/8 adds acl_user_obj01.c
Patch 2/8 adds acl_mask01.c
Patch 3/8 adds acl_other01.c
Patch 4/8 adds acl_inherit01.c
Patch 5/8 adds acl_file_ops01.c
Patch 6/8 adds acl_link01.c
Patch 7/8 adds xattr_test01.c
The code has been successfully tested on SLES (kernel 6.12) and fedora (kernel 7.0) releases.
Sachin Sant (8):
fs/acl: Add ACL_USER_OBJ permissions test
fs/acl: Add ACL mask interaction tests
fs/acl: Add ACL_OTHER permissions test
fs/acl: Add default ACL inheritance test
fs/acl: Add chmod/chown ACL interaction tests
fs/acl: Add symlink ACL operations test
fs/acl: Add extended attributes test
fs/acl: Remove old shell-based ACL test
runtest/fs | 8 + testcases/kernel/fs/acl/.gitignore | 7 + testcases/kernel/fs/acl/Makefile | 10 + testcases/kernel/fs/acl/acl_file_ops01.c | 296 +++++++++ testcases/kernel/fs/acl/acl_inherit01.c | 112 ++++ testcases/kernel/fs/acl/acl_lib.h | 342 ++++++++++ testcases/kernel/fs/acl/acl_link01.c | 124 ++++ testcases/kernel/fs/acl/acl_mask01.c | 277 ++++++++ testcases/kernel/fs/acl/acl_other01.c | 101 +++ testcases/kernel/fs/acl/acl_user_obj01.c | 109 +++ testcases/kernel/fs/acl/tacl_xattr.sh | 807 ----------------------- testcases/kernel/fs/acl/xattr_test01.c | 349 ++++++++++ 12 files changed, 1735 insertions(+), 807 deletions(-) create mode 100644 testcases/kernel/fs/acl/.gitignore create mode 100644 testcases/kernel/fs/acl/Makefile create mode 100644 testcases/kernel/fs/acl/acl_file_ops01.c create mode 100644 testcases/kernel/fs/acl/acl_inherit01.c create mode 100644 testcases/kernel/fs/acl/acl_lib.h create mode 100644 testcases/kernel/fs/acl/acl_link01.c create mode 100644 testcases/kernel/fs/acl/acl_mask01.c create mode 100644 testcases/kernel/fs/acl/acl_other01.c create mode 100644 testcases/kernel/fs/acl/acl_user_obj01.c delete mode 100755 testcases/kernel/fs/acl/tacl_xattr.sh create mode 100644 testcases/kernel/fs/acl/xattr_test01.c
Signature · 5 lines
2.39.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
RFC PATCH 1/8 fs/acl: Add ACL_USER_OBJ permissions test
Add acl_user_obj01 test to validate ACL_USER_OBJ (owner) permissions. This test verifies that:
- Traditional permission bits restrict owner access
- ACL_USER_OBJ entries override permission bits
- Owner permissions work correctly with ACL entries
The test creates a directory with restrictive permissions, verifies that file creation is denied, then sets ACL_USER_OBJ with write permissions and confirms that file creation succeeds.
The patch also adds acl_lib.h containing shared helper functions and definitions for ACL and extended attribute tests. This library provides:
- Test user management (ltpuser1, ltpuser2, ltpuser3)
- ACL entry creation and manipulation helpers
- File operation helpers with different uid/gid
- Test path management and cleanup functions
- Extended attribute test definitions
--- runtest/fs | 2 + testcases/kernel/fs/acl/.gitignore | 1 + testcases/kernel/fs/acl/Makefile | 10 + testcases/kernel/fs/acl/acl_lib.h | 342 +++++++++++++++++++++++ testcases/kernel/fs/acl/acl_user_obj01.c | 109 ++++++++ 5 files changed, 464 insertions(+) create mode 100644 testcases/kernel/fs/acl/.gitignore create mode 100644 testcases/kernel/fs/acl/Makefile create mode 100644 testcases/kernel/fs/acl/acl_lib.h create mode 100644 testcases/kernel/fs/acl/acl_user_obj01.c
runtest/fs +2 -0
@@ -87,3 +87,5 @@ binfmt_misc01 binfmt_misc01.sh binfmt_misc02 binfmt_misc02.sh squashfs01 squashfs01 + +acl_user_obj01 acl_user_obj01
testcases/kernel/fs/acl/.gitignore new file +1 -0
@@ -0,0 +1 @@ +/acl_user_obj01
testcases/kernel/fs/acl/Makefile new file +10 -0
@@ -0,0 +1,10 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) 2026 IBM + +top_srcdir ?= ../../../.. + +include $(top_srcdir)/include/mk/testcases.mk + +LDLIBS += -lacl + +include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/fs/acl/acl_lib.h new file +342 -0
342 lines not on this page · raw message
testcases/kernel/fs/acl/acl_user_obj01.c new file +109 -0
109 lines not on this page · raw message
Signature · 5 lines
2.39.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] fs/acl: Add ACL_USER_OBJ permissions test
Hi Sachin,
Thank you for this series. Converting the old monolithic tacl_xattr.sh to modular C tests using the new LTP API is a clear improvement. The code structure, helper library design, ACL logic, and test coverage are all solid. I found two commit-message accuracy issues that need to be fixed before the series can be applied.
---
[PATCH 7/8] fs/acl: Add extended attributes test
The commit subject and body both describe 6 test cases:
Add xattr_test01 test with 6 test cases to validate extended attribute operations:
1. Set/get xattr on directory
2. Set/get xattr on regular file
3. List xattrs on directory
4. Remove xattr from file
5. Backup and restore xattrs
6. Verify xattr operations follow symlinks to target
But the actual implementation has only 2 sub-tests (.tcnt = 2):
case 0: test_xattr() — covers items 1, 2, 4
case 1: test_xattr_backup_restore() — covers item 5
Items 3 ("List xattrs on directory") and 6 ("Verify xattr operations follow symlinks to target") are described in the commit message but are not implemented anywhere in xattr_test01.c. There is no listxattr(2) call and no symlink creation or xattr-through-symlink test in the file.
The test's own description block is accurate:
* This test validates:
* - Extended attributes set/get/remove operations
* - Extended attributes backup and restore operations
Please update the commit message to match the actual implementation. Either drop the unimplemented items from the list (and say "2 test cases"), or implement the missing cases.
---
[PATCH 8/8] fs/acl: Remove old shell-based ACL test
The replacement test summary in this commit is copied from (or refers to) the inaccurate count above:
- xattr_test01: Extended attributes (6 tests)
xattr_test01 has .tcnt = 2, not 6. Update this line to:
- xattr_test01: Extended attributes (2 tests)
---
Verdict: Needs revision
---
Code review notes (no action required):
- acl_lib.h is clean: the static-inline helper design, SAFE_FORK/ SAFE_WAITPID usage, setgroups(0,NULL)+setgid+setuid ordering, and _exit(errno) through WEXITSTATUS are all correct.
- All tst_test structs correctly set needs_root=1, mount_device=1, forks_child=1, and list appropriate ACL-capable filesystems. The needs_cmds guard for useradd/userdel is a nice touch.
- ACL semantics in every sub-test are correct: ACL_USER_OBJ is unaffected by ACL_MASK; ACL_OTHER is likewise mask-exempt; ACL_USER/ACL_GROUP/ ACL_GROUP_OBJ are correctly restricted by the mask. The acl_inherit01 umask=0 + mode=0666 → 0444 path matches POSIX ACL inheritance rules.
- The Makefile wildcard build and runtest/fs entries are all consistent. The old tacl_xattr.sh had no runtest entry, so no runtest removal is needed.
Thanks,
LTP AI Reviewer
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
RFC PATCH 2/8 fs/acl: Add ACL mask interaction tests
In reply to Sachin SantAdd acl_mask01 test with 3 test cases to validate ACL_MASK interaction with named user and group entries:
1. ACL_USER with mask - Named user permissions restricted by mask
2. ACL_GROUP with mask - Named group permissions restricted by mask
3. ACL_GROUP_OBJ with mask - Group owner permissions restricted by mask
Each test verifies that:
- With mask set to rwx, access is granted
- With mask cleared (---), access is denied with EACCES
This validates that ACL_MASK correctly restricts permissions for ACL_USER, ACL_GROUP, and ACL_GROUP_OBJ entries.
--- runtest/fs | 1 + testcases/kernel/fs/acl/.gitignore | 1 + testcases/kernel/fs/acl/acl_mask01.c | 277 +++++++++++++++++++++++++++ 3 files changed, 279 insertions(+) create mode 100644 testcases/kernel/fs/acl/acl_mask01.c
runtest/fs +1 -0
@@ -89,3 +89,4 @@ binfmt_misc02 binfmt_misc02.sh squashfs01 squashfs01 acl_user_obj01 acl_user_obj01 +acl_mask01 acl_mask01
testcases/kernel/fs/acl/.gitignore +1 -0
@@ -1 +1,2 @@ /acl_user_obj01 +/acl_mask01
testcases/kernel/fs/acl/acl_mask01.c new file +277 -0
277 lines not on this page · raw message
Signature · 5 lines
2.39.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
RFC PATCH 3/8 fs/acl: Add ACL_OTHER permissions test
In reply to Sachin SantAdd acl_other01 test to validate that ACL_OTHER permissions are not affected by ACL_MASK.
The test verifies that:
- ACL_OTHER entry with rwx permissions allows access
- ACL_MASK set to --- does not restrict ACL_OTHER
- Users not matching owner, named users, or groups use ACL_OTHER
This confirms that ACL_MASK only affects ACL_USER, ACL_GROUP_OBJ, and ACL_GROUP entries, but not ACL_OTHER.
--- runtest/fs | 1 + testcases/kernel/fs/acl/.gitignore | 1 + testcases/kernel/fs/acl/acl_other01.c | 101 ++++++++++++++++++++++++++ 3 files changed, 103 insertions(+) create mode 100644 testcases/kernel/fs/acl/acl_other01.c
runtest/fs +1 -0
@@ -90,3 +90,4 @@ squashfs01 squashfs01 acl_user_obj01 acl_user_obj01 acl_mask01 acl_mask01 +acl_other01 acl_other01
testcases/kernel/fs/acl/.gitignore +1 -0
@@ -1,2 +1,3 @@ /acl_user_obj01 /acl_mask01 +/acl_other01
testcases/kernel/fs/acl/acl_other01.c new file +101 -0
101 lines not on this page · raw message
Signature · 5 lines
2.39.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
RFC PATCH 4/8 fs/acl: Add default ACL inheritance test
In reply to Sachin SantAdd acl_inherit01 test to validate default ACL inheritance from parent directory to newly created files.
The test verifies that:
- Default ACLs set on a directory are inherited by new files
- New file permissions reflect the default ACL entries
- File created with umask 0 gets permissions from default ACL
This test sets default ACL with read-only permissions (r--r--r--) on the parent directory, creates a new file with umask 0, and verifies the file has 0444 permissions inherited from the default ACL.
--- runtest/fs | 1 + testcases/kernel/fs/acl/.gitignore | 1 + testcases/kernel/fs/acl/acl_inherit01.c | 112 ++++++++++++++++++++++++ 3 files changed, 114 insertions(+) create mode 100644 testcases/kernel/fs/acl/acl_inherit01.c
runtest/fs +1 -0
@@ -91,3 +91,4 @@ squashfs01 squashfs01 acl_user_obj01 acl_user_obj01 acl_mask01 acl_mask01 acl_other01 acl_other01 +acl_inherit01 acl_inherit01
testcases/kernel/fs/acl/.gitignore +1 -0
@@ -1,3 +1,4 @@ /acl_user_obj01 /acl_mask01 /acl_other01 +/acl_inherit01
testcases/kernel/fs/acl/acl_inherit01.c new file +112 -0
112 lines not on this page · raw message
Signature · 5 lines
2.39.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
RFC PATCH 5/8 fs/acl: Add chmod/chown ACL interaction tests
In reply to Sachin SantAdd acl_file_ops01 test with 2 test cases to validate chmod and chown interaction with ACL entries:
1. chmod interaction - Verifies that chmod updates ACL_USER_OBJ, ACL_GROUP_OBJ, and ACL_OTHER entries to match new permission bits. Sets ACL with read-only, then chmod 0777, and confirms all three ACL entries now have rwx permissions.
2. chown interaction - Verifies that chown changes file owner and group without modifying ACL entry permissions. Sets ACL entries, performs chown, and confirms ACL permissions are preserved.
These tests ensure chmod and chown work correctly with ACL-enabled files.
--- runtest/fs | 1 + testcases/kernel/fs/acl/.gitignore | 1 + testcases/kernel/fs/acl/acl_file_ops01.c | 296 +++++++++++++++++++++++ 3 files changed, 298 insertions(+) create mode 100644 testcases/kernel/fs/acl/acl_file_ops01.c
runtest/fs +1 -0
@@ -92,3 +92,4 @@ acl_user_obj01 acl_user_obj01 acl_mask01 acl_mask01 acl_other01 acl_other01 acl_inherit01 acl_inherit01 +acl_file_ops01 acl_file_ops01
testcases/kernel/fs/acl/.gitignore +1 -0
@@ -2,3 +2,4 @@ /acl_mask01 /acl_other01 /acl_inherit01 +/acl_file_ops01
testcases/kernel/fs/acl/acl_file_ops01.c new file +296 -0
296 lines not on this page · raw message
Signature · 5 lines
2.39.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
RFC PATCH 6/8 fs/acl: Add symlink ACL operations test
In reply to Sachin SantAdd acl_link01 test to validate that ACL operations on symlinks follow the symlink to the target file.
The test verifies that:
- acl_set_file() on a symlink sets ACL on the target file
- acl_get_file() on a symlink retrieves ACL from the target file
- ACL operations follow symlinks rather than operating on the link itself
This test creates a file and symlink, sets ACL via the symlink path, and retrieves ACL via the symlink path to confirm both operations work on the target file. Returns TCONF if ACL on symlinks is not supported by the filesystem.
--- runtest/fs | 1 + testcases/kernel/fs/acl/.gitignore | 1 + testcases/kernel/fs/acl/acl_link01.c | 124 +++++++++++++++++++++++++++ 3 files changed, 126 insertions(+) create mode 100644 testcases/kernel/fs/acl/acl_link01.c
runtest/fs +1 -0
@@ -93,3 +93,4 @@ acl_mask01 acl_mask01 acl_other01 acl_other01 acl_inherit01 acl_inherit01 acl_file_ops01 acl_file_ops01 +acl_link01 acl_link01
testcases/kernel/fs/acl/.gitignore +1 -0
@@ -3,3 +3,4 @@ /acl_other01 /acl_inherit01 /acl_file_ops01 +/acl_link01
testcases/kernel/fs/acl/acl_link01.c new file +124 -0
124 lines not on this page · raw message
Signature · 5 lines
2.39.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
RFC PATCH 7/8 fs/acl: Add extended attributes test
In reply to Sachin SantAdd xattr_test01 test with 6 test cases to validate extended attribute operations:
1. Set/get xattr on directory
2. Set/get xattr on regular file
3. List xattrs on directory
4. Remove xattr from file
5. Backup and restore xattrs
6. Verify xattr operations follow symlinks to target
The test validates basic extended attribute functionality including setting, getting, listing, and removing user.* extended attributes on filesystem objects. It also tests backup/restore functionality and confirms that xattr operations on symlinks affect the target file.
--- runtest/fs | 1 + testcases/kernel/fs/acl/.gitignore | 1 + testcases/kernel/fs/acl/xattr_test01.c | 349 +++++++++++++++++++++++++ 3 files changed, 351 insertions(+) create mode 100644 testcases/kernel/fs/acl/xattr_test01.c
runtest/fs +1 -0
@@ -94,3 +94,4 @@ acl_other01 acl_other01 acl_inherit01 acl_inherit01 acl_file_ops01 acl_file_ops01 acl_link01 acl_link01 +xattr_test01 xattr_test01
testcases/kernel/fs/acl/.gitignore +1 -0
@@ -4,3 +4,4 @@ /acl_inherit01 /acl_file_ops01 /acl_link01 +/xattr_test01
testcases/kernel/fs/acl/xattr_test01.c new file +349 -0
349 lines not on this page · raw message
Signature · 5 lines
2.39.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
RFC PATCH 8/8 fs/acl: Remove old shell-based ACL test
In reply to Sachin SantRemove tacl_xattr.sh, the old shell-based ACL and extended attribute test script. This test has been replaced by the new modular C-based test suite:
- acl_user_obj01: ACL_USER_OBJ permissions
- acl_mask01: ACL mask interactions (3 tests)
- acl_other01: ACL_OTHER permissions
- acl_inherit01: Default ACL inheritance
- acl_file_ops01: chmod/chown interactions (2 tests)
- acl_link01: Symlink ACL operations
- xattr_test01: Extended attributes (6 tests)
--- testcases/kernel/fs/acl/tacl_xattr.sh | 807 -------------------------- 1 file changed, 807 deletions(-) delete mode 100755 testcases/kernel/fs/acl/tacl_xattr.sh
testcases/kernel/fs/acl/tacl_xattr.sh deleted +0 -807
@@ -1,807 +0,0 @@ -#!/bin/bash -############################################################## -# -# Copyright (c) International Business Machines Corp., 2003 -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See -# the GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, -# -# FILE : tacl_xattr.sh -# USAGE : ./tacl_xattr.sh -# -# DESCRIPTION : A script that will test ACL and Extend Attribute on Linux system. -# REQUIREMENTS: -# 1) Kernel with loop device support -# 2) A spare (scratch) disk partition of 100MB or larger. -# 3) Kernel with ACL and Extend Attribute function support -# -# HISTORY : -# 10/23/2003 Kai Zhao ([email protected]) -# 07/06/2004 Jacky Malcles enable ext3 & clean users home dir. -# -# CODE COVERAGE: -# 76.3% - fs/posix_acl.c -# 80.9% - xattr_acl.c -# 73.0% - xattr.c -# -############################################################## - -CUR_PATH="" -CONTENT="" -RES="" -USER_PERMISSION="" -GROUP_PERMISSION="" -OTHER_PERMISSION="" -ITEM_OWNER="" -ITEM_GROUP="" - -################################################################ -# -# Make sure that uid=root is running this script. -# Make sure that loop device is built into the kernel -# Make sure that ACL(Access Control List) and Extended Attribute are -# built into the kernel -# -################################################################ - -if [ $UID != 0 ] -then - echo "FAILED: Must have root access to execute this script" - exit 1 -fi - -################################################################# -# -# Prepare Ext2 file system for ACL and Extended Attribute test -# Make some directory , file and symlink for the test -# Add three users for the test -# -################################################################# - -if [ ! -e tacl ] -then - mkdir -m 777 tacl -else - echo "FAILED: Directory tacl are exist" - exit 1 -fi - -dd if=/dev/zero of=tacl/blkext2 bs=1k count=10240 -chmod 777 tacl/blkext2 - -losetup /dev/loop0 tacl/blkext2 >/dev/null 2>&1 -if [ $? != 0 ] -then - printf "\nFAILED: [ losetup ] Must have loop device support by kernel\n" - printf "\t to execute this script\n" - exit 1 -fi - -mount | grep ext2 -if [ $? != 0 ] -then - mkfs -t ext3 /dev/loop0 - mkdir -m 777 tacl/mount-ext2 - mount -t ext3 -o defaults,acl,user_xattr /dev/loop0 tacl/mount-ext2 - if [ $? != 0 ] - then - printf "\nFAILED: [ mount ] Make sure that ACL (Access Control List)\n" - printf "\t and Extended Attribute are built into the kernel\n" - printf "\t Can not mount ext2 file system with acl and user_xattr options\n" - exit 1 - fi - -else - mkfs -t ext2 /dev/loop0 - mkdir -m 777 tacl/mount-ext2 - mount -t ext2 -o defaults,acl,user_xattr /dev/loop0 tacl/mount-ext2 - if [ $? != 0 ] - then - printf "\nFAILED: [ mount ] Make sure that ACL (Access Control List)\n" - printf "\t and Extended Attribute are built into the kernel\n" - printf "\t Can not mount ext2 file system with acl and user_xattr options\n" - exit 1 - fi -fi - -chmod 777 tacl/mount-ext2 - -useradd -d `pwd`/tacl/tacluser1 tacluser1 -useradd -d `pwd`/tacl/tacluser2 tacluser2 -useradd -d `pwd`/tacl/tacluser3 tacluser3 -useradd -d `pwd`/tacl/tacluser4 tacluser4 - -if [ ! -e tacl/mount-ext2/shared ] -then - mkdir -p -m 777 tacl/mount-ext2/shared -fi - -CUR_PATH=`pwd` - -su - tacluser1 << TACL_USER1 - - mkdir $CUR_PATH/tacl/mount-ext2/shared/team1 - touch $CUR_PATH/tacl/mount-ext2/shared/team1/file1 - - cd $CUR_PATH/tacl/mount-ext2/shared/team1 - ln -sf file1 symlinkfile1 - cd $CUR_PATH - - cd $CUR_PATH/tacl/mount-ext2/shared - ln -sf team1 symlinkdir1 - cd $CUR_PATH - -TACL_USER1 - -su - tacluser2 << TACL_USER2 - - mkdir $CUR_PATH/tacl/mount-ext2/shared/team2 - touch $CUR_PATH/tacl/mount-ext2/shared/team2/file1 - - cd $CUR_PATH/tacl/mount-ext2/shared/team2 - ln -sf file1 symlinkfile1 - cd $CUR_PATH - - cd $CUR_PATH/tacl/mount-ext2/shared - ln -sf team2 symlinkdir2 - cd $CUR_PATH - -TACL_USER2 - -############################################################################################# -# -# The permissions bit limit user's act -# lrwxrwxrwx 1 tacluser1 tacluser1 5 Jun 23 13:39 symlinkdir1 -> team1 -# lrwxrwxrwx 1 tacluser2 tacluser2 5 Jun 23 13:39 symlinkdir2 -> team2 -# dr-x------ 2 tacluser1 tacluser1 1024 Jun 23 13:39 team1 -# drwxrwxr-x 2 tacluser2 tacluser2 1024 Jun 23 13:39 team2 -# -############################################################################################# - -chmod 500 tacl/mount-ext2/shared/team1 - -su - tacluser1 << TACL_USER1 - - touch $CUR_PATH/tacl/mount-ext2/shared/team1/newfil1 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile1 ] - then - printf "\nFAILED: [ touch ] Create file must be denied by file permission bits\n" - printf "\t [ Physical Directory ]\n" - else - printf "\nSUCCESS: Create file denied by file permission bits [ Physical directory ]\n" - fi - - touch $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfil2 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile2 ] - then - printf "\nFAILED: [ touch ] Create file must be denied by file permission bits\n" - printf "\t [ Symlink Directory ]\n" - else - printf "\nSUCCESS: Create file denied by file permission bits [ Symlink directory ]\n" - fi - -TACL_USER1 - -################################################################# -# -# ACL_USER_OBJ are a superset of the permissions specified -# by the file permission bits. -# The effective user ID of the process matches the user ID of -# the file object owner. -# Owner's act are based ACL_USER_OBJ -# -################################################################# - -setfacl -m u::rx tacl/mount-ext2/shared/team1 -su - tacluser1 << TACL_USER1 - - cd $CUR_PATH/tacl/mount-ext2/shared/team1/ 2> /dev/null - if [ $? != 0 ] - then - printf "\nFAILED: [ touch ] ACL_USER_OBJ entry already contains the owner execute\n" - printf "\t permissions, but operation failed [ Physical Directory ]\n" - else - printf "\nSUCCESS: ACL_USER_OBJ entry contains the owner execute permissions,\n" - printf "\t operation success [ Physical Directory ]\n" - fi - - cd $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/ 2> /dev/null - if [ $? != 0 ] - then - printf "\nFAILED: [ touch ] ACL_USER_OBJ entry already contains the owner execute\n" - printf "\t permissions, but operation failed [ Symlink Directory ]\n" - else - printf "\nSUCCESS: ACL_USER_OBJ entry contains the owner execute permissions,\n" - printf "\t operation success [ Symlink Directory ]\n" - fi - -TACL_USER1 - -setfacl -m u::rwx tacl/mount-ext2/shared/team1 - -su - tacluser1 << TACL_USER1 - - touch $CUR_PATH/tacl/mount-ext2/shared/team1/newfil1 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile1 ] - then - printf "\nFAILED: [ touch ] ACL_USER_OBJ entry already contains the owner write \n" - printf "\t permissions, but operation failed [ Physical Directory ]\n" - else - printf "\nSUCCESS: ACL_USER_OBJ entry contains the owner write permissions,\n" - printf "\t operation success [ Physical Directory ]\n" - fi - - touch $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfil2 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile2 ] - then - printf "\nFAILED: [ touch ] ACL_USER_OBJ entry already contains the owner write \n" - printf "\t permissions, but operation failed [ Symlink Directory ]\n" - else - printf "\nSUCCESS: ACL_USER_OBJ entry contains the owner write permissions,\n" - printf "\t operation success [ Symlink Directory ]\n" - fi - -TACL_USER1 - -################################################################# -# -# The effective user ID of the process matches the qualifier of -# any entry of type ACL_USER -# IF the matching ACL_USER entry and the ACL_MASK -# entry contain the requested permissions,# access is granted, -# ELSE access is denied. -# -################################################################# - -setfacl -m u:tacluser3:rwx tacl/mount-ext2/shared/team1 - -su - tacluser3 << TACL_USER3 - - touch $CUR_PATH/tacl/mount-ext2/shared/team1/newfile3 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile3 ] - then - printf "\nSUCCESS: ACL_USER entry contains the user permissions,\n" - printf "\t operation success [ Physical Directory ]\n" - else - printf "\nFAILED: ACL_USER entry contains the user permissions,\n" - printf "\t but operation denied [ Physical Directory ]\n" - fi - - touch $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfile4 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfile4 ] - then - printf "\nSUCCESS: ACL_USER entry contains the user permissions,\n" - printf "\t operation success [ Symlink Directory ]\n" - else - printf "\nFAILED: ACL_USER entry contains the user permissions,\n" - printf "\t but operation denied [ Symlink Directory ]\n" - fi - -TACL_USER3 - -setfacl -m mask:--- tacl/mount-ext2/shared/team1 - -su - tacluser3 << TACL_USER3 - - touch $CUR_PATH/tacl/mount-ext2/shared/team1/newfile5 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile5 ] - then - printf "\nFAILED: [ touch ] ACL_USER entry contains the user permissions\n" - printf "\t but ACL_MASK are set --- ,\n" - printf "\t operation must be denied [ Physical Directory ]\n" - else - printf "\nSUCCESS: ACL_USER entry contains the user permissions,\n" - printf "\t but ACL_MASK are set ___ ,\n" - printf "\t operation success [ Physical Directory ]\n" - fi - - touch $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfile6 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfile6 ] - then - printf "\nFAILED: [ touch ] ACL_USER entry contains the user permissions\n" - printf "\t but ACL_MASK are set --- ,\n" - printf "\t operation must be denied [ Symlink Directory ]\n" - else - printf "\nSUCCESS: ACL_USER entry contains the user permissions,\n" - printf "\t but ACL_MASK are set ___ ,\n" - printf "\t operation success [ Symlink Directory ]\n" - fi - -TACL_USER3 - -########################################################################################### -# -# The effective group ID or any of the supplementary group IDs of the process match the -# qualifier of the entry of type ACL_GROUP_OBJ, or the qualifier of any entry of type -# ACL_GROUP -# -# IF the ACL contains an ACL_MASK entry, THEN -# if the ACL_MASK entry and any of the matching ACL_GROUP_OBJ -# or ACL_GROUP entries contain the requested permissions, -# access is granted, -# -# else access is denied. -# -# ELSE (note that there can be no ACL_GROUP entries without an ACL_MASK entry) -# if the ACL_GROUP_OBJ entry contains the requested permis- -# sions, access is granted, -# -# else access is denied. -# -########################################################################################### - -setfacl -m g:tacluser2:rwx tacl/mount-ext2/shared/team1 - -su - tacluser2 << TACL_USER2 - touch $CUR_PATH/tacl/mount-ext2/shared/team1/newfile7 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile7 ] - then - printf "\nSUCCESS: ACL_GROUP entry contains the group permissions,\n" - printf "\t option success [ Physical Directory ]\n" - else - printf "\nFAILED: [ touch ] ACL_GROUP entry already contains the group permissions,\n" - printf "\t but option success [ Physical Directory ]\n" - fi - - touch $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfile8 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfile8 ] - then - printf "\nSUCCESS: ACL_GROUP entry contains the group permissions,\n" - printf "\t option success [ Symlink Directory ]\n" - else - printf "\nFAILED: [ touch ] ACL_GROUP entry already contains the group permissions,\n" - printf "\t but option success [ Symlink Directory ]\n" - fi - -TACL_USER2 - -setfacl -m mask:--- tacl/mount-ext2/shared/team1 - -su - tacluser2 << TACL_USER2 - touch $CUR_PATH/tacl/mount-ext2/shared/team1/newfile9 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile9 ] - then - printf "\nFAILED: [ touch ] ACL_GROUP entry contains the group permissions\n" - printf "\t and ACL_MASK entry are set ---,\n" - printf "\t option must no be success [ Physical Directory ]\n" - else - printf "\nSUCCESS: ACL_GROUP entry already contains the group permissions\n" - printf "\t and ACL_MASK entry are set ---,\n" - printf "\t option success [ Physical Directory ]\n" - fi - - touch $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfile10 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfile10 ] - then - printf "\nFAILED: [ touch ] ACL_GROUP entry contains the group permissions\n" - printf "\t and ACL_MASK entry are set ---,\n" - printf "\t option must no be success [ Symlink Directory ]\n" - else - printf "\nSUCCESS: ACL_GROUP entry already contains the group permissions\n" - printf "\t and ACL_MASK entry are set ---,\n" - printf "\t option success [ Symlink Directory ]\n" - fi - -TACL_USER2 - -setfacl -m g::rwx tacl/mount-ext2/shared/team1 -usermod -g tacluser1 tacluser2 - -su - tacluser2 << TACL_USER2 - - touch $CUR_PATH/tacl/mount-ext2/shared/team1/newfile11 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile11 ] - then - printf "\nSUCCESS: ACL_GROUP_OBJ entry contains the group owner permissions,\n" - printf "\t option success [ Physical Directory ]\n" - else - printf "\nFAILED: [ touch ] ACL_GROUP_OBJ entry already contains the group owner,\n" - printf "\t but option denied [ Physical Directory ]\n" - fi - - touch $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfile12 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfile12 ] - then - printf "\nSUCCESS: ACL_GROUP_OBJ entry contains the group owner permissions,\n" - printf "\t option success [ Symlink Directory ]\n" - else - printf "\nFAILED: [ touch ] ACL_GROUP_OBJ entry already contains the group owner,\n" - printf "\t but option denied [ Symlink Directory ]\n" - fi - -TACL_USER2 - -setfacl -m mask:--- tacl/mount-ext2/shared/team1 - -su - tacluser2 << TACL_USER2 - touch $CUR_PATH/tacl/mount-ext2/shared/team1/newfile13 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile13 ] - then - printf "\nFAILED: [ touch ] ACL_GROUP_OBJ entry contains the group owner permissions\n" - printf "\t and ACL_MASK entry are set ---,\n" - printf "\t option must no be success [ Physical Directory ]\n" - else - printf "\nSUCCESS: ACL_GROUP_OBJ entry already contains the group owner permissions\n" - printf "\t and ACL_MASK entry are set ---,\n" - printf "\t option success [ Physical Directory ]\n" - fi - - touch $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfile14 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfile14 ] - then - printf "\nFAILED: [ touch ] ACL_GROUP_OBJ entry contains the group owner permissions\n" - printf "\t and ACL_MASK entry are set ---,\n" - printf "\t option must no be success [ Symlink Directory ]\n" - else - printf "\nSUCCESS: ACL_GROUP_OBJ entry already contains the group owner permissions\n" - printf "\t and ACL_MASK entry are set ---,\n" - printf "\t option success [ Symlink Directory ]\n" - fi - -TACL_USER2 - -usermod -g tacluser2 tacluser2 - -################################################################################### -# -# IF the ACL_OTHER entry contains the requested permissions, access is granted -# -################################################################################### - -setfacl -m o::rwx tacl/mount-ext2/shared/team1 - -su - tacluser4 << TACL_USER4 - - touch $CUR_PATH/tacl/mount-ext2/shared/team1/newfile15 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile15 ] - then - printf "\nSUCCESS: ACL_OTHER entry contains the user permissions,\n" - printf "\t operation success [ Physical Directory ]\n" - else - printf "\nFAILED: ACL_OTHER entry contains the user permissions,\n" - printf "\t but operation denied [ Physical Directory ]\n" - fi - - touch $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfile16 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfile16 ] - then - printf "\nSUCCESS: ACL_OTHER entry contains the user permissions,\n" - printf "\t operation success [ Symlink Directory ]\n" - else - printf "\nFAILED: ACL_OTHER entry contains the user permissions,\n" - printf "\t but operation denied [ Symlink Directory ]\n" - fi - -TACL_USER4 - -setfacl -m mask:--- tacl/mount-ext2/shared/team1 - -su - tacluser4 << TACL_USER4 - - touch $CUR_PATH/tacl/mount-ext2/shared/team1/newfile17 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile17 ] - then - printf "\nSUCCESS: [ touch ] ACL_OTHER do not strick by ACL_MASK [ Physical Directory ]\n" - else - printf "\nFAILED: ACL_OTHER do not strick by ACL_MASK [ Physical Directory ]\n" - fi - - touch $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfile18 2> /dev/null - if [ -e $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfile18 ] - then - printf "\nSUCCESS: [ touch ] ACL_OTHER do not strick by ACL_MASK [ Symlink Directory ]\n" - else - printf "\nFAILED: ACL_OTHER do not strick by ACL_MASK [ Symlink Directory ]\n" - fi - -TACL_USER4 - -############################################################################ -# -# OBJECT CREATION AND DEFAULT ACLs -# The new object inherits the default ACL of the containing directory as its access ACL. -# -############################################################################ - -rm -f tacl/mount-ext2/shared/team1/newfil* - -# -# Test ACL_USER_OBJ default ACLs -# -setfacl -m d:u::r -m d:g::r -m d:o::r tacl/mount-ext2/shared/team1 - -su - tacluser1 << TACL_USER1 - - MASK=`umask` - umask 0 - touch $CUR_PATH/tacl/mount-ext2/shared/team1/newfile1 - umask $MASK > /dev/null - -TACL_USER1 - -CONTENT="" -CONTENT=`ls -l tacl/mount-ext2/shared/team1/newfile1` -RES=`echo $CONTENT | grep ".r--r--r--" | awk '{print $1}'` - -if [ $RES != "" ] -then - printf "\nSUCCESS: With default ACLs set, new file permission set correct.\n" -else - printf "\nFAILED: With default ACLs set, new file permission set not correct\n" -fi - - - -# -# Test ACL_USER and ACL_GROUP defaults ACLs -# -setfacl -m d:u:tacluser3:rw -m d:g:tacluser3:rw tacl/mount-ext2/shared/team1 -su - tacluser3 << TACL_USER3 - - MASK=`umask` - umask 0 - touch $CUR_PATH/tacl/mount-ext2/shared/team1/newfile2 - umask $MASK > /dev/null - -TACL_USER3 - -CONTENT="" -CONTENT=`ls -l tacl/mount-ext2/shared/team1/newfile2` -RES=`echo $CONTENT | grep ".r--rw-r--" | awk '{print $1}'` - -if [ $RES != "" ] -then - printf "\nSUCCESS: With default ACLs set, new file permission set correct.\n" -else - printf "\nFAILED: With default ACLs set, new file permission set not correct\n" -fi - -# -# Test ACL_GROUP default ACLs -# - -setfacl -m d:u::rwx -m d:g::rwx -m d:o::rwx tacl/mount-ext2/shared/team1 -su - tacluser3 << TACL_USER3 - - MASK=`umask` - umask 0 - touch $CUR_PATH/tacl/mount-ext2/shared/team1/newfile3 - umask $MASK > /dev/null - -TACL_USER3 - -CONTENT="" -CONTENT=`ls -l tacl/mount-ext2/shared/team1/newfile3` -RES=`echo $CONTENT | grep ".rw-rw-rw-" | awk '{print \$1}'` - -if [ $RES != "" ] -then - printf "\nSUCCESS: With default ACLs set, new file permission set correct.\n" -else - printf "\nFAILED: With default ACLs set, new file permission set not correct\n" -fi - - -################################################################################# -# -# Chmod also change ACL_USER_OBJ ACL_GROUP_OBJ and ACL_OTHER permissions -# -################################################################################# -su - tacluser3 << TACL_USER3 - MASK=`umask` - umask 0 - - chmod 777 $CUR_PATH/tacl/mount-ext2/shared/team1/newfile3 - umask $MASK > /dev/null -TACL_USER3 - -CONTENT="" -CONTENT=`getfacl tacl/mount-ext2/shared/team1/newfile3` - -USER_PERMISSION=`echo $CONTENT | awk '{print \$10}'` - -GROUP_PERMISSION=`echo $CONTENT | awk '{print \$12}'` -OTHER_PERMISSION=`echo $CONTENT | awk '{print \$15}'` - -if [ $USER_PERMISSION = "user::rwx" ] -then - if [ $GROUP_PERMISSION = "group::rwx" ] - then - if [ $OTHER_PERMISSION = "other::rwx" ] - then - printf "\nSUCCESS: Chmod with ACL_USER_OBJ ACL_GROUP_OBJ and ACL_OTHER are correct\n" - else - printf "\nFAILED: Chmod with ACL_USER_OBJ ACL_GROUP_OBJ and ACL_OTHER are not correct\n" - fi - else - printf "\nFAILED: Chmod with ACL_USER_OBJ ACL_GROUP_OBJ and ACL_OTHER are not correct\n" - fi -else - printf "\nFAILED: Chmod with ACL_USER_OBJ ACL_GROUP_OBJ and ACL_OTHER are not correct\n" -fi - - -##################################################################################### -# -# Chown only change object owner and group -# -##################################################################################### - -chown tacluser2.tacluser2 tacl/mount-ext2/shared/team1/newfile2 -CONTENT="" -CONTENT=`getfacl tacl/mount-ext2/shared/team1/newfile2` - -ITEM_OWNER=`echo $CONTENT | awk '{print \$6}'` -ITEM_GROUP=`echo $CONTENT | awk '{print \$9}'` - -if [ $ITEM_OWNER = "tacluser2" ] -then - if [ $ITEM_GROUP = "tacluser2" ] - then - printf "\nSUCCESS: Chown correct\n" - else - printf "\nFAILED: Chown are not correct\n" - fi -else - echo "FAILED: Chown are not correct" -fi - -##################################################### -# -# Test ACLs backup and restore -# -##################################################### - -getfacl -RL tacl/mount-ext2/ > tacl/tmp1 -setfacl -m u::--- -m g::--- -m o::--- tacl/mount-ext2/shared/team1 -setfacl --restore tacl/tmp1 -getfacl -RL tacl/mount-ext2/ > tacl/tmp2 - -if [ `diff tacl/tmp1 tacl/tmp2` ] -then - printf "\nFAILED: ACLs backup and restore are not correct\n" -else - printf "\nSUCCESS: ACLs backup and restore are correct\n" -fi - -printf "\n\tEnd ACLs Test\n" - -##################################################### -# -# Now begin Extend Attribute test -# -##################################################### - -printf "\nNow begin Extend Attribute Test\n" - -# dir -printf "\nAttach name:value pair to object dir\n\n" -attr -s attrname1 -V attrvalue1 tacl/mount-ext2/shared/team2 -if [ $? != 0 ] -then - echo "FAILED: Attach name:value pair to object dir" -fi - -#file -echo -echo "Attach name:value pair to object file " -echo "" -attr -s attrname2 -V attrvalue2 tacl/mount-ext2/shared/team2/file1 -if [ $? != 0 ] -then - echo "FAILED: Attach name:value pair to object file" -fi - -#symlink file -echo -echo "Attach name:value pair to object symlink file" -echo "" -attr -s attrname3 -V attrvalue3 tacl/mount-ext2/shared/team2/symlinkfile1 -if [ $? != 0 ] -then - echo "INFO: Can't attach name:value pair to object symlink file" -fi - -echo "" -ls -lRt tacl/mount-ext2/shared/team2 - -echo -echo "get extended attributes of filesystem objects" -echo "" - -echo "Dump the values" -getfattr -d tacl/mount-ext2/shared/team2 -if [ $? != 0 ] -then - echo "FAILED: getfattr: Dump the values" -fi - -echo "Recursively dump the values" -getfattr -dR tacl/mount-ext2/* -if [ $? != 0 ] -then - echo "FAILED: getfattr: Recursively Dump the values" -fi - -echo "Do not follow symlinks." -echo "but extended user attributes are disallowed for symbolic links" -getfattr -h --no-dereference tacl/mount-ext2/shared/team2/symlinkfile1 -if [ $? != 0 ] -then - echo "FAILED: getfattr: Do not follow symlinks." -fi -echo - -echo "Logical walk, follow symbolic links" -getfattr -L tacl/mount-ext2/shared/team2/* -if [ $? != 0 ] -then - echo "FAILED: getfattr: Logical walk" -fi - -echo "Physical walk, skip all symbolic links" -getfattr -P tacl/mount-ext2/shared/team2/* -if [ $? != 0 ] -then - echo "FAILED: getfattr: Physical walk" -fi - -echo "attr -g to search the named object" -attr -g attrname1 tacl/mount-ext2/shared/team2 -if [ $? != 0 ] -then - echo "FAILED: attr: to search the named object" -fi -echo - -echo "attr -r to remove the named object" -attr -r attrname2 tacl/mount-ext2/shared/team2/file1 -if [ $? != 0 ] -then - echo "FAILED: attr: to remove the named object" -fi - - -################################# -# -# Backup and Restore -# -################################# -getfattr -dhR -m- -e hex tacl/mount-ext2 > tacl/backup.ea -setfattr -h --restore=tacl/backup.ea - -getfattr -dhR -m- -e hex tacl/mount-ext2 > tacl/backup.ea1 -if [ `diff tacl/backup.ea1 tacl/backup.ea` ] -then - printf "\nFAILED: EAs backup and restore are not correct\n" -else - printf "\nSUCCESS: EAs backup and restore are correct\n" -fi - -printf "\n\tEnd EAs Test\n" - - - -##################################################### -# -# Clean up -# -##################################################### - -userdel tacluser1 -userdel tacluser2 -userdel tacluser3 -userdel tacluser4 -umount -d tacl/mount-ext2 -rm -rf tacl
Signature · 5 lines
2.39.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Sachin,
the patch set is not compiling in some systems. Please verify that it compiles by running the CI in your github branch before sending a new patch.
https://github.com/linux-test-project/ltp/actions/runs/26713233737
Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 7 lines · Andrea Cervesato
Hi Sachin,
the patch set is not compiling in some systems. Please verify that it compiles by running the CI in your github branch before sending a new patch.
https://github.com/linux-test-project/ltp/actions/runs/26713233737
Thanks Andrea for the pointer.
Test building in various distros in Docker workflow was not enabled in my branch. I have now enabled it so that I can catch such failures in future.
The compile/link failure seems to be due to unconditional inclusion of -lacl and sys/acl.h header. Will add a build-time detection for libacl to allow tests to compile on systems without libacl development packages.
Will send an updated patch series.
Signature · 7 lines
Thanks - Sachin -- Mailing list info: https://lists.linux.it/listinfo/ltp