GuC paging engine support
Subsystems (2)
v6 cover GuC paging engine support
On NVL-S+, the GuC will be moving towards a dedicated GuC engine class for the driver reserved copy engine(s), which we need for USM flows. With this the GuC will now be able to internally differentiate KMD paging operations, like clearing/migrating/binding, from other copy engine submissions.
Note that this is purely a software view within the GuC. There is no new physical engine, or anything like that. With that in mind the design here keeps this contained on the GuC side, with upper layers not needing to know about this distinction.
v2 (Sashiko):
- In VF query patch, we shouldn't call guc_has_paging_engine(), since this is too early in the VF sequence, and GUC_SUBMIT_VER() is still unset.
v3:
- Revamp the paging engine setup in patch 5 (Sashiko)
- Some more improvements from Daniele
v4:
- Some more improvements from Daniele, plus some other tweaks
v5:
- Some improvements from Michal
- Update with the official GuC version: 70.68.0 (1.36.0)
v6:
- Tweak the VF vs PF versioning as per GuC team
- Also for now treat zero paging engines as hint to use fallback
Signature · 1 line
2.54.0
PATCH v6 1/10 drm/xe/guc: refactor ads to use guc_class
Currently in the lrc init flow on the ads side, we loop through each generic engine class and convert that to the respective guc engine class. However, with some upcoming changes, it will be better to go the opposite way and loop through every guc engine class, and convert that to the generic engine class.
This will be needed in an upcoming patch where we have a new guc engine class that just matches up to the existing blitter/copy class, but needs to be treated as a separate entity from the normal copy lrc, when setting up the ADS.
This also reworks engine_enable_mask to operate on the guc_class, that way we can easily filter out the PAGING vs normal BSC, when applicable.
As a bonus, this also gets rid of two xe_engine_class_to_guc_class() users which will be helpful for the next patch.
No functional changes.
v2 (Daniele):
- Simplify fill_engine_enable_masks() to just loop over all guc classes.
--- drivers/gpu/drm/xe/xe_guc_ads.c | 69 ++++++++++++++++++++------------- 1 file changed, 41 insertions(+), 28 deletions(-)
drivers/gpu/drm/xe/xe_guc_ads.c +41 -28
@@ -251,14 +251,35 @@ static size_t calculate_regset_size(struct xe_gt *gt)return count *sizeof (struct guc_mmio_reg ); } -static u32 engine_enable_mask (struct xe_gt *gt,enum xe_engine_class class) +static inline enum xe_engine_class guc_class_to_engine_class (u16 guc_class) +{ +switch (guc_class) { +case GUC_RENDER_CLASS : +return XE_ENGINE_CLASS_RENDER ; +case GUC_VIDEO_CLASS : +return XE_ENGINE_CLASS_VIDEO_DECODE ; +case GUC_VIDEOENHANCE_CLASS : +return XE_ENGINE_CLASS_VIDEO_ENHANCE ; +case GUC_BLITTER_CLASS : +return XE_ENGINE_CLASS_COPY ; +case GUC_COMPUTE_CLASS : +return XE_ENGINE_CLASS_COMPUTE ; +case GUC_GSC_OTHER_CLASS : +return XE_ENGINE_CLASS_OTHER ; +default : +XE_WARN_ON (guc_class); +return -1 ; + } +} + +static u32 engine_enable_mask (struct xe_gt *gt,u16 guc_class) {struct xe_hw_engine *hwe;enum xe_hw_engine_id id;u32 mask =0 ;for_each_hw_engine (hwe, gt, id) -if (hwe->class == class) +if (xe_engine_class_to_guc_class (hwe->class) == guc_class) mask |=BIT (hwe->instance);return mask;
@@ -268,10 +289,13 @@ static size_t calculate_golden_lrc_size(struct xe_guc_ads *ads) {struct xe_gt *gt =ads_to_gt (ads);size_t total_size =0 , alloc_size, real_size; -int class; +u16 guc_class; -for (class =0 ; class <XE_ENGINE_CLASS_MAX ; ++class) { -if (!engine_enable_mask (gt, class)) +for (guc_class =0 ; guc_class <=GUC_LAST_ENGINE_CLASS ; ++guc_class) { +enum xe_engine_class class = +guc_class_to_engine_class (guc_class); + +if (!engine_enable_mask (gt, guc_class))continue ; real_size =xe_gt_lrc_size (gt, class);
@@ -463,20 +487,11 @@ static void fill_engine_enable_masks(struct xe_gt *gt, struct iosys_map *info_map) {struct xe_device *xe =gt_to_xe (gt); +u16 guc_class; -info_map_write (xe, info_map, engine_enabled_masks[GUC_RENDER_CLASS ], -engine_enable_mask (gt,XE_ENGINE_CLASS_RENDER )); -info_map_write (xe, info_map, engine_enabled_masks[GUC_BLITTER_CLASS ], -engine_enable_mask (gt,XE_ENGINE_CLASS_COPY )); -info_map_write (xe, info_map, engine_enabled_masks[GUC_VIDEO_CLASS ], -engine_enable_mask (gt,XE_ENGINE_CLASS_VIDEO_DECODE )); -info_map_write (xe, info_map, - engine_enabled_masks[GUC_VIDEOENHANCE_CLASS ], -engine_enable_mask (gt,XE_ENGINE_CLASS_VIDEO_ENHANCE )); -info_map_write (xe, info_map, engine_enabled_masks[GUC_COMPUTE_CLASS ], -engine_enable_mask (gt,XE_ENGINE_CLASS_COMPUTE )); -info_map_write (xe, info_map, engine_enabled_masks[GUC_GSC_OTHER_CLASS ], -engine_enable_mask (gt,XE_ENGINE_CLASS_OTHER )); +for (guc_class =0 ; guc_class <=GUC_LAST_ENGINE_CLASS ; ++guc_class) +info_map_write (xe, info_map, engine_enabled_masks[guc_class], +engine_enable_mask (gt, guc_class)); }/*
@@ -491,15 +506,14 @@ static void guc_golden_lrc_init(struct xe_guc_ads *ads) offsetof(struct __guc_ads_blob, system_info));size_t alloc_size, real_size;u32 addr_ggtt, offset; -int class; +u16 guc_class; offset =guc_ads_golden_lrc_offset (ads); addr_ggtt =xe_bo_ggtt_addr (ads->bo) + offset; -for (class =0 ; class <XE_ENGINE_CLASS_MAX ; ++class) { -u8 guc_class; - - guc_class =xe_engine_class_to_guc_class (class); +for (guc_class =0 ; guc_class <=GUC_LAST_ENGINE_CLASS ; ++guc_class) { +enum xe_engine_class class = +guc_class_to_engine_class (guc_class);if (!info_map_read (xe, &info_map, engine_enabled_masks[guc_class]))
@@ -948,14 +962,13 @@ static void guc_golden_lrc_populate(struct xe_guc_ads *ads) offsetof(struct __guc_ads_blob, system_info));size_t total_size =0 , alloc_size, real_size;u32 offset; -int class; +u16 guc_class; offset =guc_ads_golden_lrc_offset (ads); -for (class =0 ; class <XE_ENGINE_CLASS_MAX ; ++class) { -u8 guc_class; - - guc_class =xe_engine_class_to_guc_class (class); +for (guc_class =0 ; guc_class <=GUC_LAST_ENGINE_CLASS ; ++guc_class) { +enum xe_engine_class class = +guc_class_to_engine_class (guc_class);if (!info_map_read (xe, &info_map, engine_enabled_masks[guc_class]))
Signature · 1 line
2.54.0
PATCH v6 2/10 drm/xe/guc: refactor to_guc_class() to accept hwe
In reply to Matthew AuldRather than inferring the GuC engine class from the generic hw engine class, pass in the hwe itself, which gives the complete view, like instance etc. On future GuC versions, there is dedicated PAGING class to identify the KMD reserved BCS engine, so we need more info here in order to return the correct GuC specific engine class.
With this everything should now be using the new hwe based interface. No functional changes.
--- drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c | 2 +- drivers/gpu/drm/xe/xe_gt_sriov_pf_policy.c | 2 +- drivers/gpu/drm/xe/xe_guc.h | 21 +--------------- drivers/gpu/drm/xe/xe_guc_ads.c | 27 ++++++++++++++++++--- drivers/gpu/drm/xe/xe_guc_capture.c | 12 ++++----- drivers/gpu/drm/xe/xe_guc_capture.h | 4 +-- drivers/gpu/drm/xe/xe_guc_engine_activity.c | 4 +-- drivers/gpu/drm/xe/xe_guc_submit.c | 2 +- 8 files changed, 38 insertions(+), 36 deletions(-)
drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c +1 -1
@@ -381,7 +381,7 @@ static ssize_t sched_group_engines_read(struct file *file, char __user *buf,if (group < num_groups) {for_each_hw_engine (hwe, gt, id) { -u8 guc_class =xe_engine_class_to_guc_class (hwe->class); +u8 guc_class =xe_hwe_to_guc_class (hwe);u32 mask = groups[group].engines[guc_class];if (mask &BIT (hwe->logical_instance)) {
drivers/gpu/drm/xe/xe_gt_sriov_pf_policy.c +1 -1
@@ -471,7 +471,7 @@ static void pf_sched_group_media_slices(struct xe_gt *gt, struct guc_sched_groupreturn ;for_each_hw_engine (hwe, gt, id) { -u8 guc_class =xe_engine_class_to_guc_class (hwe->class); +u8 guc_class =xe_hwe_to_guc_class (hwe);switch (hwe->class) {case XE_ENGINE_CLASS_VIDEO_DECODE :
drivers/gpu/drm/xe/xe_guc.h +1 -20
@@ -67,26 +67,7 @@ bool xe_guc_using_main_gamctrl_queues(struct xe_guc *guc);int xe_guc_g2g_test_notification (struct xe_guc *guc,u32 *payload,u32 len);#endif -static inline u16 xe_engine_class_to_guc_class (enum xe_engine_class class) -{ -switch (class) { -case XE_ENGINE_CLASS_RENDER : -return GUC_RENDER_CLASS ; -case XE_ENGINE_CLASS_VIDEO_DECODE : -return GUC_VIDEO_CLASS ; -case XE_ENGINE_CLASS_VIDEO_ENHANCE : -return GUC_VIDEOENHANCE_CLASS ; -case XE_ENGINE_CLASS_COPY : -return GUC_BLITTER_CLASS ; -case XE_ENGINE_CLASS_COMPUTE : -return GUC_COMPUTE_CLASS ; -case XE_ENGINE_CLASS_OTHER : -return GUC_GSC_OTHER_CLASS ; -default : -XE_WARN_ON (class); -return -1 ; - } -} +u16 xe_hwe_to_guc_class (struct xe_hw_engine *hwe);static inline struct xe_gt *guc_to_gt (struct xe_guc *guc) {
drivers/gpu/drm/xe/xe_guc_ads.c +24 -3
@@ -279,7 +279,7 @@ static u32 engine_enable_mask(struct xe_gt *gt, u16 guc_class)u32 mask =0 ;for_each_hw_engine (hwe, gt, id) -if (xe_engine_class_to_guc_class (hwe->class) == guc_class) +if (xe_hwe_to_guc_class (hwe) == guc_class) mask |=BIT (hwe->instance);return mask;
@@ -494,6 +494,27 @@ static void fill_engine_enable_masks(struct xe_gt *gt, engine_enable_mask(gt, guc_class)); } +u16 xe_hwe_to_guc_class (struct xe_hw_engine *hwe) +{ +switch (hwe->class) { +case XE_ENGINE_CLASS_RENDER : +return GUC_RENDER_CLASS ; +case XE_ENGINE_CLASS_VIDEO_DECODE : +return GUC_VIDEO_CLASS ; +case XE_ENGINE_CLASS_VIDEO_ENHANCE : +return GUC_VIDEOENHANCE_CLASS ; +case XE_ENGINE_CLASS_COPY : +return GUC_BLITTER_CLASS ; +case XE_ENGINE_CLASS_COMPUTE : +return GUC_COMPUTE_CLASS ; +case XE_ENGINE_CLASS_OTHER : +return GUC_GSC_OTHER_CLASS ; +default : +XE_WARN_ON (hwe->class); +return -1 ; + } +} +/* * Write the offsets corresponding to the golden LRCs. The actual data is * populated later by guc_golden_lrc_populate()
@@ -564,7 +585,7 @@ static void guc_mapping_table_init(struct xe_gt *gt,for_each_hw_engine (hwe, gt, id) {u8 guc_class; - guc_class =xe_engine_class_to_guc_class (hwe->class); + guc_class =xe_hwe_to_guc_class (hwe);info_map_write (xe, info_map, mapping_table[guc_class][hwe->logical_instance], hwe->instance);
@@ -819,7 +840,7 @@ static void guc_mmio_reg_state_init(struct xe_guc_ads *ads)* 2. Record in the header (ads.reg_state_list) the address * location and number of entries */ - gc =xe_engine_class_to_guc_class (hwe->class); + gc =xe_hwe_to_guc_class (hwe);ads_blob_write (ads, ads.reg_state_list[gc][hwe->instance].address, addr);ads_blob_write (ads, ads.reg_state_list[gc][hwe->instance].count, count);
drivers/gpu/drm/xe/xe_guc_capture.c +6 -6
@@ -440,7 +440,7 @@ static void guc_capture_alloc_steered_lists(struct xe_guc *guc)* to be extended */ for_each_hw_engine (hwe, gt, id) { -if (xe_engine_class_to_guc_capture_class (hwe->class) == +if (xe_hwe_to_guc_capture_class (hwe) ==GUC_CAPTURE_LIST_CLASS_RENDER_COMPUTE ) { has_rcs_ccs = true;break ;
@@ -812,7 +812,7 @@ static int guc_capture_output_size_est(struct xe_guc *guc)for_each_hw_engine (hwe, gt, id) {enum guc_capture_list_class_type capture_class; - capture_class =xe_engine_class_to_guc_capture_class (hwe->class); + capture_class =xe_hwe_to_guc_capture_class (hwe); capture_size +=sizeof (struct guc_state_capture_group_header_t ) + (3 *sizeof (struct guc_state_capture_header_t ));
@@ -1620,7 +1620,7 @@ xe_engine_manual_capture(struct xe_hw_engine *hwe, struct xe_hw_engine_snapshotif (!new)return ; - capture_class =xe_engine_class_to_guc_capture_class (hwe->class); + capture_class =xe_hwe_to_guc_capture_class (hwe);for (type =GUC_STATE_CAPTURE_TYPE_GLOBAL ; type <GUC_STATE_CAPTURE_TYPE_MAX ; type++) {struct gcap_reg_list_info *reginfo = &new->reginfo[type];/*
@@ -1662,7 +1662,7 @@ xe_engine_manual_capture(struct xe_hw_engine *hwe, struct xe_hw_engine_snapshot } } - new->eng_class =xe_engine_class_to_guc_class (hwe->class); + new->eng_class =xe_hwe_to_guc_class (hwe); new->eng_inst = hwe->instance; new->guc_id = guc_id; new->lrca = lrca;
@@ -1826,7 +1826,7 @@ void xe_engine_snapshot_print(struct xe_hw_engine_snapshot *snapshot, struct drmxe_gt_assert (gt, snapshot->hwe); - capture_class =xe_engine_class_to_guc_capture_class (snapshot->hwe->class); + capture_class =xe_hwe_to_guc_capture_class (snapshot->hwe); drm_printf(p, "%s (physical), logical instance=%d\n", snapshot->name ? snapshot->name : "",
@@ -1898,7 +1898,7 @@ xe_guc_capture_get_matching_and_lock(struct xe_exec_queue *q)for_each_hw_engine (hwe, q->gt, id) {if (hwe != q->hwe)continue ; - guc_class =xe_engine_class_to_guc_class (hwe->class); + guc_class =xe_hwe_to_guc_class (hwe);break ; }
drivers/gpu/drm/xe/xe_guc_capture.h +2 -2
@@ -35,9 +35,9 @@ static inline enum guc_capture_list_class_type xe_guc_class_to_capture_class(u16 }static inline enum guc_capture_list_class_type -xe_engine_class_to_guc_capture_class (enum xe_engine_class class) +xe_hwe_to_guc_capture_class (struct xe_hw_engine *hwe) { -return xe_guc_class_to_capture_class (xe_engine_class_to_guc_class (class)); +return xe_guc_class_to_capture_class (xe_hwe_to_guc_class (hwe)); }void xe_guc_capture_process (struct xe_guc *guc);
drivers/gpu/drm/xe/xe_guc_engine_activity.c +2 -2
@@ -27,7 +27,7 @@ static struct iosys_map engine_activity_map(struct xe_guc *guc, struct xe_hw_eng {struct xe_guc_engine_activity *engine_activity = &guc->engine_activity;struct engine_activity_buffer *buffer; -u16 guc_class =xe_engine_class_to_guc_class (hwe->class); +u16 guc_class =xe_hwe_to_guc_class (hwe);size_t offset;if (engine_activity->num_functions) {
@@ -150,7 +150,7 @@ static struct engine_activity *hw_engine_to_engine_activity(struct xe_hw_engine {struct xe_guc *guc = &hwe->gt->uc.guc;struct engine_activity_group *eag = &guc->engine_activity.eag[index]; -u16 guc_class =xe_engine_class_to_guc_class (hwe->class); +u16 guc_class =xe_hwe_to_guc_class (hwe);return &eag->engine[guc_class][hwe->logical_instance]; }
drivers/gpu/drm/xe/xe_guc_submit.c +1 -1
@@ -984,7 +984,7 @@ static void register_exec_queue(struct xe_exec_queue *q, int ctx_type)memset (&info,0 ,sizeof (info)); info.context_idx = q->guc->id; - info.engine_class =xe_engine_class_to_guc_class (q->class); + info.engine_class =xe_hwe_to_guc_class (q->hwe); info.engine_submit_mask = q->logical_mask; info.hwlrca_lo =lower_32_bits (xe_lrc_descriptor (lrc)); info.hwlrca_hi =upper_32_bits (xe_lrc_descriptor (lrc));
Signature · 1 line
2.54.0
PATCH v6 3/10 drm/xe/guc: add the plumbing for GUC_PAGING_CLASS
In reply to Matthew AuldOn newer platforms, the GuC has a new engine class which we need to use to refer to the dedicated/reserved KMD BCS engine. With that, add the plumbing in the GuC backend to support GUC_PAGING_CLASS and GUC_CAPTURE_LIST_CLASS_PAGING.
Currently this is still turned off.
v2 (Daniele)
- Also add adjust the capture list for hpg, so we account for nvl-s.
- Move single paging engine assert to a more natural place.
--- drivers/gpu/drm/xe/abi/guc_capture_abi.h | 3 ++- drivers/gpu/drm/xe/abi/guc_scheduler_abi.h | 3 ++- drivers/gpu/drm/xe/xe_guc.c | 15 +++++++++++++++ drivers/gpu/drm/xe/xe_guc.h | 1 + drivers/gpu/drm/xe/xe_guc_ads.c | 12 ++++++++++++ drivers/gpu/drm/xe/xe_guc_capture.c | 9 +++++++++ drivers/gpu/drm/xe/xe_guc_capture.h | 2 ++ 7 files changed, 43 insertions(+), 2 deletions(-)
drivers/gpu/drm/xe/abi/guc_capture_abi.h +2 -1
@@ -32,9 +32,10 @@ enum guc_capture_list_class_type {GUC_CAPTURE_LIST_CLASS_VIDEOENHANCE =2 ,GUC_CAPTURE_LIST_CLASS_BLITTER =3 ,GUC_CAPTURE_LIST_CLASS_GSC_OTHER =4 , + GUC_CAPTURE_LIST_CLASS_PAGING = 5, }; -#define GUC_CAPTURE_LIST_CLASS_MAX (GUC_CAPTURE_LIST_CLASS_GSC_OTHER + 1) +#define GUC_CAPTURE_LIST_CLASS_MAX (GUC_CAPTURE_LIST_CLASS_PAGING + 1)/** * struct guc_mmio_reg - GuC MMIO reg state struct
drivers/gpu/drm/xe/abi/guc_scheduler_abi.h +2 -1
@@ -21,7 +21,8 @@#define GUC_BLITTER_CLASS 3#define GUC_COMPUTE_CLASS 4#define GUC_GSC_OTHER_CLASS 5 -#define GUC_LAST_ENGINE_CLASS GUC_GSC_OTHER_CLASS +#define GUC_PAGING_CLASS 6 +#define GUC_LAST_ENGINE_CLASS GUC_PAGING_CLASS#define GUC_MAX_ENGINE_CLASSES 16#define GUC_MAX_INSTANCES_PER_CLASS 32
drivers/gpu/drm/xe/xe_guc.c +15 -0
@@ -1846,6 +1846,21 @@ bool xe_guc_using_main_gamctrl_queues(struct xe_guc *guc)return GT_VER (gt) >=35 ; } +bool xe_guc_has_paging_engine (struct xe_guc *guc) +{ +/* +* On newer platforms the GuC now has a dedicated engine class for the +* special PAGING engine, which is the driver reserved BCS engine used +* for KMD paging/binding operations. GuC requires KMD to refer to this +* using the special PAGING engine class. Note that there is no new hw +* engine here, this is purely a sw view in the GuC itself, which we +* need to respect. +*/ + +/* TODO: Have some way to query this from the GuC? */ +return false; +} +#if IS_ENABLED (CONFIG_DRM_XE_KUNIT_TEST )#include "tests/xe_guc_g2g_test.c" #endif
drivers/gpu/drm/xe/xe_guc.h +1 -0
@@ -62,6 +62,7 @@ void xe_guc_stop(struct xe_guc *guc);int xe_guc_start (struct xe_guc *guc);void xe_guc_declare_wedged (struct xe_guc *guc);bool xe_guc_using_main_gamctrl_queues (struct xe_guc *guc); +bool xe_guc_has_paging_engine (struct xe_guc *guc);#if IS_ENABLED (CONFIG_DRM_XE_KUNIT_TEST )int xe_guc_g2g_test_notification (struct xe_guc *guc,u32 *payload,u32 len);
drivers/gpu/drm/xe/xe_guc_ads.c +12 -0
@@ -261,6 +261,7 @@ static inline enum xe_engine_class guc_class_to_engine_class(u16 guc_class)case GUC_VIDEOENHANCE_CLASS :return XE_ENGINE_CLASS_VIDEO_ENHANCE ;case GUC_BLITTER_CLASS : +case GUC_PAGING_CLASS :return XE_ENGINE_CLASS_COPY ;case GUC_COMPUTE_CLASS :return XE_ENGINE_CLASS_COMPUTE ;
@@ -282,6 +283,10 @@ static u32 engine_enable_mask(struct xe_gt *gt, u16 guc_class)if (xe_hwe_to_guc_class (hwe) == guc_class) mask |=BIT (hwe->instance); +/* We expect at most one paging engine per GuC instance, for now */ +if (guc_class ==GUC_PAGING_CLASS ) +xe_gt_assert (gt, !mask ||is_power_of_2 (mask)); +return mask; }
@@ -496,6 +501,10 @@ static void fill_engine_enable_masks(struct xe_gt *gt,u16 xe_hwe_to_guc_class (struct xe_hw_engine *hwe) { +if (xe_guc_has_paging_engine (&hwe->gt->uc.guc) && +xe_gt_is_usm_hwe (hwe->gt, hwe)) +return GUC_PAGING_CLASS ; +switch (hwe->class) {case XE_ENGINE_CLASS_RENDER :return GUC_RENDER_CLASS ;
@@ -615,6 +624,9 @@ static u32 guc_get_capture_engine_mask(struct xe_gt *gt, struct iosys_map *info_case GUC_CAPTURE_LIST_CLASS_GSC_OTHER : mask =info_map_read (xe, info_map, engine_enabled_masks[GUC_GSC_OTHER_CLASS ]);break ; +case GUC_CAPTURE_LIST_CLASS_PAGING : + mask =info_map_read (xe, info_map, engine_enabled_masks[GUC_PAGING_CLASS ]); +break ;default : mask =0 ; }
drivers/gpu/drm/xe/xe_guc_capture.c +9 -0
@@ -249,6 +249,8 @@ static const struct __guc_mmio_reg_descr_group xe_hpg_lists[] = {MAKE_REGLIST (xe_blt_inst_regs,PF ,ENGINE_INSTANCE ,GUC_CAPTURE_LIST_CLASS_BLITTER ),MAKE_REGLIST (empty_regs_list,PF ,ENGINE_CLASS ,GUC_CAPTURE_LIST_CLASS_GSC_OTHER ),MAKE_REGLIST (xe_lp_gsc_inst_regs,PF ,ENGINE_INSTANCE ,GUC_CAPTURE_LIST_CLASS_GSC_OTHER ), +MAKE_REGLIST (empty_regs_list,PF ,ENGINE_CLASS ,GUC_CAPTURE_LIST_CLASS_PAGING ), + MAKE_REGLIST(xe_blt_inst_regs, PF, ENGINE_INSTANCE, GUC_CAPTURE_LIST_CLASS_PAGING), {} };
@@ -265,6 +267,8 @@ static const struct __guc_mmio_reg_descr_group xe3p_lists[] = {MAKE_REGLIST (xe_blt_inst_regs,PF ,ENGINE_INSTANCE ,GUC_CAPTURE_LIST_CLASS_BLITTER ),MAKE_REGLIST (empty_regs_list,PF ,ENGINE_CLASS ,GUC_CAPTURE_LIST_CLASS_GSC_OTHER ),MAKE_REGLIST (xe_lp_gsc_inst_regs,PF ,ENGINE_INSTANCE ,GUC_CAPTURE_LIST_CLASS_GSC_OTHER ), +MAKE_REGLIST (empty_regs_list,PF ,ENGINE_CLASS ,GUC_CAPTURE_LIST_CLASS_PAGING ), + MAKE_REGLIST(xe_blt_inst_regs, PF, ENGINE_INSTANCE, GUC_CAPTURE_LIST_CLASS_PAGING), {} }; static const char * const capture_list_type_names[] = {
@@ -279,6 +283,7 @@ static const char * const capture_engine_class_names[] = {"VideoEnhance" ,"Blitter" ,"GSC-Other" , + "Paging", }; struct __guc_capture_ads_cache {
@@ -766,6 +771,10 @@ size_t xe_guc_capture_ads_input_worst_size(struct xe_guc *guc) total_size =PAGE_SIZE ;/* Pad a page in front for empty lists */ for (i =0 ; i <GUC_CAPTURE_LIST_INDEX_MAX ; i++) {for (j =0 ; j <GUC_CAPTURE_LIST_CLASS_MAX ; j++) { +if (!xe_guc_has_paging_engine (guc) && + j ==GUC_CAPTURE_LIST_CLASS_PAGING ) +continue ; +if (xe_guc_capture_getlistsize (guc, i,GUC_STATE_CAPTURE_TYPE_ENGINE_CLASS , j, &class_size) <0 )
drivers/gpu/drm/xe/xe_guc_capture.h +2 -0
@@ -28,6 +28,8 @@ static inline enum guc_capture_list_class_type xe_guc_class_to_capture_class(u16case GUC_VIDEOENHANCE_CLASS :case GUC_BLITTER_CLASS :return class; +case GUC_PAGING_CLASS : +return GUC_CAPTURE_LIST_CLASS_PAGING ;default :XE_WARN_ON (class);return GUC_CAPTURE_LIST_CLASS_MAX ;
Signature · 1 line
2.54.0
PATCH v6 4/10 drm/xe/hw_engine: don't open code is_usm_hwe()
In reply to Matthew AuldPrefer is_usm_hwe() here.
--- drivers/gpu/drm/xe/xe_hw_engine.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/xe/xe_hw_engine.c +1 -2
@@ -1035,8 +1035,7 @@ bool xe_hw_engine_is_reserved(struct xe_hw_engine *hwe) hwe->logical_instance >= gt->ccs_mode)return true; -return xe->info.has_usm && hwe->class ==XE_ENGINE_CLASS_COPY && - hwe->instance == gt->usm.reserved_bcs_instance; +return xe_gt_is_usm_hwe (gt, hwe); }const char *xe_hw_engine_class_to_str (enum xe_engine_class class)
Signature · 1 line
2.54.0
PATCH v6 5/10 drm/xe: refactor the paging engine setup
In reply to Matthew AuldOn newer platforms, the paging configuration is now configured by the PF via the ADS object, where VF side should ensure that everything configured as GUC_PAGING_CLASS is correctly mirrored on VF side. For example PF could in theory reserve two BCS instances, and we expect VF to mirror that.
With that move towards having a logical mask of all the paging engines, and also generalise selecting those engines, based on the number of paging engines. Also cache the first designated paging engine, which will makes things a little cleaner here, and in later patches.
No functional changes for existing platforms.
v2 (Sashiko):
- Rework the loop slightly so that we don't needlessly check for the paging engine, before we have correctly set the logical instance.
- Add a proper error return, if we encounter a bogus paging config. Thinking ahead to VF where the config is defined by the PF, we should just gracefully exit the probe sequence.
v3:
- Move paging_engines > copy_engines engines check to VF patch.
--- drivers/gpu/drm/xe/xe_exec_queue.c | 5 +--- drivers/gpu/drm/xe/xe_gt.h | 6 ++--- drivers/gpu/drm/xe/xe_gt_types.h | 12 ++++++--- drivers/gpu/drm/xe/xe_hw_engine.c | 40 ++++++++++++++++++++++-------- drivers/gpu/drm/xe/xe_migrate.c | 32 +++--------------------- 5 files changed, 46 insertions(+), 49 deletions(-)
drivers/gpu/drm/xe/xe_exec_queue.c +1 -4
@@ -530,10 +530,7 @@ struct xe_exec_queue *xe_exec_queue_create_bind(struct xe_device *xe, migrate_vm =xe_migrate_get_vm (tile->migrate);if (xe->info.has_usm) { -struct xe_hw_engine *hwe =xe_gt_hw_engine (gt, -XE_ENGINE_CLASS_COPY , - gt->usm.reserved_bcs_instance, - false); +struct xe_hw_engine *hwe = gt->usm.paging_hwe0;if (!hwe) {xe_vm_put (migrate_vm);
drivers/gpu/drm/xe/xe_gt.h +2 -4
@@ -137,10 +137,8 @@ static inline bool xe_gt_is_media_type(struct xe_gt *gt)static inline bool xe_gt_is_usm_hwe (struct xe_gt *gt,struct xe_hw_engine *hwe) { -struct xe_device *xe =gt_to_xe (gt); - -return xe->info.has_usm && hwe->class ==XE_ENGINE_CLASS_COPY && - hwe->instance == gt->usm.reserved_bcs_instance; +return hwe->class ==XE_ENGINE_CLASS_COPY && + (gt->usm.paging_logical_mask &BIT (hwe->logical_instance)); }/**
drivers/gpu/drm/xe/xe_gt_types.h +9 -3
@@ -230,10 +230,16 @@ struct xe_gt {*/ struct xe_sa_manager *bb_pool;/** -* @usm.reserved_bcs_instance: reserved BCS instance used for USM -* operations (e.g. migrations, fixing page tables) +* @usm.paging_hwe0: The first designated paging engine. +* This is some reserved BCS instance used for USM operations +* (e.g. migrations, fixing page tables) */ -u16 reserved_bcs_instance; +struct xe_hw_engine *paging_hwe0; +/** +* @usm.paging_logical_mask: logical mask of paging engines. +* Should be densely populated. +*/ +u32 paging_logical_mask; } usm;/** @ordered_wq: used to serialize GT resets and TDRs */
drivers/gpu/drm/xe/xe_hw_engine.c +30 -10
@@ -637,10 +637,6 @@ static int hw_engine_init(struct xe_gt *gt, struct xe_hw_engine *hwe,xe_hw_engine_enable_ring (hwe); } -/* We reserve the highest BCS instance for USM */ -if (xe->info.has_usm && hwe->class ==XE_ENGINE_CLASS_COPY ) - gt->usm.reserved_bcs_instance = hwe->instance; -/* Ensure IDLEDLY is lower than MAXCNT */ adjust_idledly (hwe);
@@ -654,19 +650,43 @@ static int hw_engine_init(struct xe_gt *gt, struct xe_hw_engine *hwe,return err; } -static void hw_engine_setup_logical_mapping (struct xe_gt *gt) +static void hw_engine_setup_logical_and_paging_mapping (struct xe_gt *gt) { +struct xe_device *xe =gt_to_xe (gt); +unsigned int num_copy_engines =0 , num_paging_engines =0 ; +unsigned int reserved_logical_bcs_start; +struct xe_hw_engine *hwe; +enum xe_hw_engine_id id;int class; +for_each_hw_engine (hwe, gt, id) +if (hwe->class ==XE_ENGINE_CLASS_COPY ) + num_copy_engines++; + +/* We just reserve the highest BCS instance for USM */ +if (num_copy_engines && xe->info.has_usm) + num_paging_engines =1 ; + + reserved_logical_bcs_start = num_copy_engines - num_paging_engines; +/* FIXME: Doing a simple logical mapping that works for most hardware */ for (class =0 ; class <XE_ENGINE_CLASS_MAX ; ++class) { -struct xe_hw_engine *hwe; -enum xe_hw_engine_id id;int logical_instance =0 ; -for_each_hw_engine (hwe, gt, id) -if (hwe->class == class) +for_each_hw_engine (hwe, gt, id) { +if (hwe->class == class) { hwe->logical_instance = logical_instance++; + +if (class ==XE_ENGINE_CLASS_COPY && + hwe->logical_instance >= + reserved_logical_bcs_start) { +if (!gt->usm.paging_hwe0) + gt->usm.paging_hwe0 = hwe; + gt->usm.paging_logical_mask |= +BIT (hwe->logical_instance); + } + } + } } }
@@ -886,7 +906,7 @@ int xe_hw_engines_init(struct xe_gt *gt)return err; } -hw_engine_setup_logical_mapping (gt); +hw_engine_setup_logical_and_paging_mapping (gt); err =xe_hw_engine_setup_groups (gt);if (err)return err;
drivers/gpu/drm/xe/xe_migrate.c +4 -28
@@ -383,27 +383,6 @@ static void xe_migrate_suballoc_manager_init(struct xe_migrate *m, u32 map_ofs) NUM_VMUSA_UNIT_PER_PAGE, 0); } -/* -* Including the reserved copy engine is required to avoid deadlocks due to -* migrate jobs servicing the faults gets stuck behind the job that faulted. -*/ -static u32 xe_migrate_usm_logical_mask (struct xe_gt *gt) -{ -u32 logical_mask =0 ; -struct xe_hw_engine *hwe; -enum xe_hw_engine_id id; - -for_each_hw_engine (hwe, gt, id) { -if (hwe->class !=XE_ENGINE_CLASS_COPY ) -continue ; - -if (xe_gt_is_usm_hwe (gt, hwe)) - logical_mask |=BIT (hwe->logical_instance); - } - -return logical_mask; -} -static bool xe_migrate_needs_ccs_emit (struct xe_device *xe) {return xe_device_has_flat_ccs (xe) && !(GRAPHICS_VER (xe) >=20 &&IS_DGFX (xe));
@@ -479,13 +458,10 @@ int xe_migrate_init(struct xe_migrate *m) goto err_out;if (xe->info.has_usm) { -struct xe_hw_engine *hwe =xe_gt_hw_engine (primary_gt, -XE_ENGINE_CLASS_COPY , - primary_gt->usm.reserved_bcs_instance, - false); -u32 logical_mask =xe_migrate_usm_logical_mask (primary_gt); +struct xe_hw_engine *hwe0 = primary_gt->usm.paging_hwe0; +u32 logical_mask = primary_gt->usm.paging_logical_mask; -if (!hwe || !logical_mask) { +if (!hwe0 || !logical_mask) { err = -EINVAL ; goto err_out; }
@@ -494,7 +470,7 @@ int xe_migrate_init(struct xe_migrate *m)* XXX: Currently only reserving 1 (likely slow) BCS instance on * PVC, may want to revisit if performance is needed. */ - m->q = xe_exec_queue_create(xe, vm, logical_mask, 1, hwe, + m->q = xe_exec_queue_create(xe, vm, logical_mask, 1, hwe0, EXEC_QUEUE_FLAG_KERNEL | EXEC_QUEUE_FLAG_PERMANENT | EXEC_QUEUE_FLAG_HIGH_PRIORITY |
Signature · 1 line
2.54.0
PATCH v6 6/10 drm/xe/guc: handle guc logical instance for paging engine
In reply to Matthew AuldIn the GuC backend, we need a different logical instance when referring to the reserved paging engine. Under the hood, this is still just the same physical BSC engine, however from the GuC POV this is actually re-mapped to a separate GUC_PAGING_CLASS, with the logical index starting from zero.
The idea is to not leak this into the upper layers, since this is GuC version specific, so the changes here are purely on the GuC side.
No functional change.
v2:
- Add some kernel-doc to explain the usage.
- Move the implementation to guc.c
--- drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c | 3 +- drivers/gpu/drm/xe/xe_gt_sriov_pf_policy.c | 3 +- drivers/gpu/drm/xe/xe_guc.c | 31 +++++++++++++++++++++ drivers/gpu/drm/xe/xe_guc.h | 1 + drivers/gpu/drm/xe/xe_guc_ads.c | 5 +++- drivers/gpu/drm/xe/xe_guc_engine_activity.c | 6 ++-- drivers/gpu/drm/xe/xe_hw_engine_types.h | 7 ++++- 7 files changed, 50 insertions(+), 6 deletions(-)
drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c +2 -1
@@ -382,9 +382,10 @@ static ssize_t sched_group_engines_read(struct file *file, char __user *buf,if (group < num_groups) {for_each_hw_engine (hwe, gt, id) {u8 guc_class =xe_hwe_to_guc_class (hwe); +u16 guc_logical_instance =xe_hwe_guc_logical_instance (hwe);u32 mask = groups[group].engines[guc_class]; -if (mask &BIT (hwe->logical_instance)) { +if (mask &BIT (guc_logical_instance)) {strlcat (engines, hwe->name,sizeof (engines));strlcat (engines," " ,sizeof (engines)); }
drivers/gpu/drm/xe/xe_gt_sriov_pf_policy.c +2 -1
@@ -472,6 +472,7 @@ static void pf_sched_group_media_slices(struct xe_gt *gt, struct guc_sched_groupfor_each_hw_engine (hwe, gt, id) {u8 guc_class =xe_hwe_to_guc_class (hwe); +u16 guc_logical_instance =xe_hwe_guc_logical_instance (hwe);switch (hwe->class) {case XE_ENGINE_CLASS_VIDEO_DECODE :
@@ -490,7 +491,7 @@ static void pf_sched_group_media_slices(struct xe_gt *gt, struct guc_sched_group slice =0 ; } - values[slice_to_group[slice]].engines[guc_class] |=BIT (hwe->logical_instance); + values[slice_to_group[slice]].engines[guc_class] |=BIT (guc_logical_instance); } *groups = values;
drivers/gpu/drm/xe/xe_guc.c +31 -0
@@ -1861,6 +1861,37 @@ bool xe_guc_has_paging_engine(struct xe_guc *guc)return false; } +/** +* xe_hwe_guc_logical_instance - Get the GuC-aligned logical instance of a +* hardware engine. +* @hwe: Hardware engine. +* +* For GuC backend usage, we should no longer use the raw logical instance +* directly. This helper must be used to retrieve the logical instance of the +* hardware engine, taking care of any necessary adjustments (such as the GuC +* PAGING engine mapping). This is assumed to be used in conjunction with the +* GuC engine class. +* +* Return: Logical instance, taking into account for stuff like GuC PAGING +* engine mapping. +*/ +u16 xe_hwe_guc_logical_instance (struct xe_hw_engine *hwe) +{ +struct xe_gt *gt = hwe->gt; + +if (xe_guc_has_paging_engine (&hwe->gt->uc.guc) && +xe_gt_is_usm_hwe (gt, hwe)) { +int shift = gt->usm.paging_hwe0->logical_instance; + +xe_gt_assert (gt, shift <= hwe->logical_instance); + +/* GUC_PAGING_CLASS:guc_logical_instance */ +return hwe->logical_instance - shift; + } + +return hwe->logical_instance; +} +#if IS_ENABLED (CONFIG_DRM_XE_KUNIT_TEST )#include "tests/xe_guc_g2g_test.c" #endif
drivers/gpu/drm/xe/xe_guc.h +1 -0
@@ -69,6 +69,7 @@ int xe_guc_g2g_test_notification(struct xe_guc *guc, u32 *payload, u32 len);#endif u16 xe_hwe_to_guc_class (struct xe_hw_engine *hwe); +u16 xe_hwe_guc_logical_instance (struct xe_hw_engine *hwe);static inline struct xe_gt *guc_to_gt (struct xe_guc *guc) {
drivers/gpu/drm/xe/xe_guc_ads.c +4 -1
@@ -592,11 +592,14 @@ static void guc_mapping_table_init(struct xe_gt *gt,guc_mapping_table_init_invalid (gt, info_map);for_each_hw_engine (hwe, gt, id) { +u16 guc_logical_instance;u8 guc_class; guc_class =xe_hwe_to_guc_class (hwe); + guc_logical_instance =xe_hwe_guc_logical_instance (hwe); +info_map_write (xe, info_map, - mapping_table[guc_class][hwe->logical_instance], + mapping_table[guc_class][guc_logical_instance], hwe->instance); } }
drivers/gpu/drm/xe/xe_guc_engine_activity.c +4 -2
@@ -28,6 +28,7 @@ static struct iosys_map engine_activity_map(struct xe_guc *guc, struct xe_hw_engstruct xe_guc_engine_activity *engine_activity = &guc->engine_activity;struct engine_activity_buffer *buffer;u16 guc_class =xe_hwe_to_guc_class (hwe); +u16 guc_logical_instance =xe_hwe_guc_logical_instance (hwe);size_t offset;if (engine_activity->num_functions) {
@@ -39,7 +40,7 @@ static struct iosys_map engine_activity_map(struct xe_guc *guc, struct xe_hw_eng } offset += offsetof(struct guc_engine_activity_data , - engine_activity[guc_class][hwe->logical_instance]); + engine_activity[guc_class][guc_logical_instance]);return IOSYS_MAP_INIT_OFFSET (&buffer->activity_bo->vmap, offset); }
@@ -151,8 +152,9 @@ static struct engine_activity *hw_engine_to_engine_activity(struct xe_hw_enginestruct xe_guc *guc = &hwe->gt->uc.guc;struct engine_activity_group *eag = &guc->engine_activity.eag[index];u16 guc_class =xe_hwe_to_guc_class (hwe); +u16 guc_logical_instance =xe_hwe_guc_logical_instance (hwe); -return &eag->engine[guc_class][hwe->logical_instance]; +return &eag->engine[guc_class][guc_logical_instance]; }static u64 cpu_ns_to_guc_tsc_tick (ktime_t ns,u32 freq)
drivers/gpu/drm/xe/xe_hw_engine_types.h +6 -1
@@ -114,7 +114,12 @@ struct xe_hw_engine {enum xe_engine_class class;/** @instance: physical instance of this hw engine */ u16 instance; -/** @logical_instance: logical instance of this hw engine */ +/** +* @logical_instance: logical instance of this hw engine. +* +* Note: For GuC usage, always use xe_hwe_guc_logical_instance(). +* For GuC usage, we should no longer use the raw logical instance. +*/ u16 logical_instance;/** @irq_offset: IRQ offset of this hw engine */ u16 irq_offset;
Signature · 1 line
2.54.0
PATCH v6 7/10 drm/xe/guc: handle submit mask with paging engine
In reply to Matthew AuldWe need to re-map the submit mask so that we correctly account for the logical mask of paging engines, if the GUC_PAGING_CLASS is in play. We could also have multiple instances (possible on VF), so we need to handle that also.
v2 (Daniele):
- Move the implementation to guc_submit.c
--- drivers/gpu/drm/xe/xe_guc_submit.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_guc_submit.c +23 -1
@@ -972,6 +972,27 @@ static void __register_exec_queue(struct xe_guc *guc,xe_guc_ct_send (&guc->ct, action,ARRAY_SIZE (action),0 ,0 ); } +static u32 xe_hwe_guc_logical_to_submit_mask (struct xe_hw_engine *hwe,u32 logical_mask) +{ +struct xe_gt *gt = hwe->gt; + +if (xe_gt_is_usm_hwe (gt, hwe)) { +int shift = gt->usm.paging_hwe0->logical_instance; +u32 paging_logical_mask = gt->usm.paging_logical_mask; + +xe_gt_assert (gt, (logical_mask & paging_logical_mask) == logical_mask); + +/* +* Remap to GUC_PAGING_CLASS logical instance mask, if +* applicable. +*/ +if (xe_guc_has_paging_engine (&hwe->gt->uc.guc)) +return logical_mask >> shift; + } + +return logical_mask; +} +static void register_exec_queue (struct xe_exec_queue *q,int ctx_type) {struct xe_guc *guc =exec_queue_to_guc (q);
@@ -985,7 +1006,8 @@ static void register_exec_queue(struct xe_exec_queue *q, int ctx_type)memset (&info,0 ,sizeof (info)); info.context_idx = q->guc->id; info.engine_class =xe_hwe_to_guc_class (q->hwe); - info.engine_submit_mask = q->logical_mask; + info.engine_submit_mask = +xe_hwe_guc_logical_to_submit_mask (q->hwe, q->logical_mask); info.hwlrca_lo =lower_32_bits (xe_lrc_descriptor (lrc)); info.hwlrca_hi =upper_32_bits (xe_lrc_descriptor (lrc)); info.flags = CONTEXT_REGISTRATION_FLAG_KMD |
Signature · 1 line
2.54.0
PATCH v6 8/10 drm/xe/vf: wire up NUM_PAGING_ENGINE_INSTANCES
In reply to Matthew AuldWhen host PF writes the logical configuration for the GUC PAGING engine, the VF is meant to query it, and mirror it. Size of N means we have paging logical index range [0, N-1], with N fewer normal copy engines.
Agreement is that PF will only spawn PAGING engines on NVL-S+, so this should be zero on older platforms, where we should simply fall back to the old behaviour.
v2 (Sashiko):
- We can't call use the guc_has_paging_engine() this early in the VF code. With that just unconditionally do the query, if the GuC is new enough and take the value as-is. With that drop the -1 special case and just let the upper layers figure out the rest.
v3:
- Also update xe_guc_klv_key_to_string. (Michal)
- Add kernel-doc for xe_gt_sriov_vf_paging_engines(), plus other tweaks. (Michal)
- Update with final GuC version.
v4:
- Just fallback to manual reserve when vf reported paging engines is zero. Will revisit in the future.
--- drivers/gpu/drm/xe/abi/guc_klvs_abi.h | 9 +++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 47 +++++++++++++++++++++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.h | 1 + drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h | 4 ++ drivers/gpu/drm/xe/xe_guc_klv_helpers.c | 2 + drivers/gpu/drm/xe/xe_hw_engine.c | 30 ++++++++++++++- 6 files changed, 91 insertions(+), 2 deletions(-)
drivers/gpu/drm/xe/abi/guc_klvs_abi.h +9 -0
@@ -52,6 +52,12 @@* _`GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE` : 0x3001 * Tells the driver whether scheduler groups are enabled or not. * Requires GuC ABI 1.26+ +* +* _`GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES` : 0x3003 +* Tells the driver the paging engine configuration. +* Paging engine logical instances are guaranteed to be dense starting at +* index 0. +* Requires GuC ABI 1.36+ */ #define GUC_KLV_GLOBAL_CFG_GMD_ID_KEY 0x3000u
@@ -60,6 +66,9 @@#define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY 0x3001u#define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_LEN 1u +#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY 0x3003u +#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_LEN 1u +/** * DOC: GuC Self Config KLVs *
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +47 -0
65 lines not on this page · raw message
drivers/gpu/drm/xe/xe_gt_sriov_vf.h +1 -0
@@ -31,6 +31,7 @@ u32 xe_gt_sriov_vf_gmdid(struct xe_gt *gt);u16 xe_gt_sriov_vf_guc_ids (struct xe_gt *gt);u64 xe_gt_sriov_vf_lmem (struct xe_gt *gt);bool xe_gt_sriov_vf_sched_groups_enabled (struct xe_gt *gt); +u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt);u32 xe_gt_sriov_vf_read32 (struct xe_gt *gt,struct xe_reg reg);void xe_gt_sriov_vf_write32 (struct xe_gt *gt,struct xe_reg reg,u32 val);
drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +4 -0
@@ -40,6 +40,10 @@ struct xe_gt_sriov_vf_runtime {/** @regs.value: register value. */ u32 value; } *regs; +/** +* @num_paging_engine_instances: number of configured paging engines. +*/ +u32 num_paging_engine_instances; };/**
drivers/gpu/drm/xe/xe_guc_klv_helpers.c +2 -0
@@ -24,6 +24,8 @@ const char *xe_guc_klv_key_to_string(u16 key)/* GuC Global Config KLVs */ case GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY :return "group_scheduling_available" ; +case GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY : +return "num_paging_engine_instances" ;/* VGT POLICY keys */ case GUC_KLV_VGT_POLICY_SCHED_IF_IDLE_KEY :return "sched_if_idle" ;
drivers/gpu/drm/xe/xe_hw_engine.c +28 -2
@@ -650,7 +650,7 @@ static int hw_engine_init(struct xe_gt *gt, struct xe_hw_engine *hwe,return err; } -static void hw_engine_setup_logical_and_paging_mapping (struct xe_gt *gt) +static int hw_engine_setup_logical_and_paging_mapping (struct xe_gt *gt) {struct xe_device *xe =gt_to_xe (gt);unsigned int num_copy_engines =0 , num_paging_engines =0 ;
@@ -667,6 +667,27 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt)if (num_copy_engines && xe->info.has_usm) num_paging_engines =1 ; +if (IS_SRIOV_VF (xe)) { +u32 vf_num_paging_engines; + +/* +* PF could in theory reserve multiple paging engines, which +* internally the submission/scheduling backend can load balance +* from. Not something we currently expect, but we are at the +* mercy of the PF, so we just need try our best to mirror the +* paging configuration. +*/ + vf_num_paging_engines =xe_gt_sriov_vf_paging_engines (gt); +if (vf_num_paging_engines) { +/* This should only be non-zero on NVL-S+ */ +xe_gt_assert (gt, xe->info.platform >=XE_NOVALAKE_S ); + num_paging_engines = vf_num_paging_engines; + } + } + +if (xe_gt_WARN_ON (gt, num_paging_engines > num_copy_engines)) +return -EINVAL ; + reserved_logical_bcs_start = num_copy_engines - num_paging_engines;/* FIXME: Doing a simple logical mapping that works for most hardware */
@@ -688,6 +709,8 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) } } } + +return 0 ; }static void read_media_fuses (struct xe_gt *gt)
@@ -906,7 +929,10 @@ int xe_hw_engines_init(struct xe_gt *gt)return err; } -hw_engine_setup_logical_and_paging_mapping (gt); + err =hw_engine_setup_logical_and_paging_mapping (gt); +if (err) +return err; + err =xe_hw_engine_setup_groups (gt);if (err)return err;
Signature · 1 line
2.54.0
Re: [PATCH v6 08/10] drm/xe/vf: wire up NUM_PAGING_ENGINE_INSTANCES
Quoted 85 lines · Matthew Auld
When host PF writes the logical configuration for the GUC PAGING engine, the VF is meant to query it, and mirror it. Size of N means we have paging logical index range [0, N-1], with N fewer normal copy engines.
Agreement is that PF will only spawn PAGING engines on NVL-S+, so this should be zero on older platforms, where we should simply fall back to the old behaviour.
v2 (Sashiko):
- We can't call use theguc_has_paging_engine()this early in the VF code. With that just unconditionally do the query, if the GuC is new enough and take the value as-is. With that drop the -1 special case and just let the upper layers figure out the rest.
v3:
- Also updatexe_guc_klv_key_to_string. (Michal)
- Add kernel-doc forxe_gt_sriov_vf_paging_engines(), plus other tweaks. (Michal)
- Update with final GuC version.
v4:
- Just fallback to manual reserve when vf reported paging engines is zero. Will revisit in the future.Signed-off-by Matthew Auld <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>Cc Piotr Piórkowski <[email protected]>Cc Michal Wajdeczko <[email protected]>--- drivers/gpu/drm/xe/abi/guc_klvs_abi.h | 9 +++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 47 +++++++++++++++++++++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.h | 1 + drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h | 4 ++ drivers/gpu/drm/xe/xe_guc_klv_helpers.c | 2 + drivers/gpu/drm/xe/xe_hw_engine.c | 30 ++++++++++++++- 6 files changed, 91 insertions(+), 2 deletions(-)drivers/gpu/drm/xe/abi/guc_klvs_abi.h +9
-0@@ -52,6 +52,12 @@* _`GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE` : 0x3001 * Tells the driver whether scheduler groups are enabled or not. * Requires GuC ABI 1.26+ +* +* _`GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES` : 0x3003 +* Tells the driver the paging engine configuration. +* Paging engine logical instances are guaranteed to be dense starting at +* index 0. +* Requires GuC ABI 1.36+ */ #define GUC_KLV_GLOBAL_CFG_GMD_ID_KEY 0x3000u@@ -60,6 +66,9 @@#define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY 0x3001u#define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_LEN 1u +#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY 0x3003u +#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_LEN 1u +/** * DOC: GuC Self Config KLVs * drivers/gpu/drm/xe/xe_gt_sriov_vf.c +15
-0@@ -658,6 +658,33 @@ static int vf_cache_sched_groups_status(struct xe_gt *gt)return 0 ; } +static int vf_cache_num_paging_engines (struct xe_gt *gt) +{ +struct xe_guc *guc = >->uc.guc; +struct xe_uc_fw_version guc_version; +u32 value =0 ; +int err; + +xe_gt_sriov_vf_guc_versions (gt,NULL , &guc_version); + +if (MAKE_GUC_VER_STRUCT (guc_version) <MAKE_GUC_VER (1 ,36 ,0 )) +return 0 ; + + err =guc_action_query_single_klv32 (guc,GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY , + &value); +if (unlikely (err)) {
drivers/gpu/drm/xe/xe_gt_sriov_vf.c static int vf_cache_sched_groups_status(struct xe_gt *gt) · line 685
Quoted 10 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +10
-0+xe_gt_sriov_err (gt, +"Failed to obtain the number of paging instances (%pe)\n" , +ERR_PTR (err)); +return err; + } + + gt->sriov.vf.runtime.num_paging_engine_instances = value; + +xe_gt_sriov_dbg (gt,"num_paging_engines %u\n" , value); +return err;
return 0;
Quoted 17 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +6
-0+} +/** * xe_gt_sriov_vf_query_config - Query SR-IOV config data over MMIO. * @gt: the &xe_gt @@ -694,6 +721,10 @@ int xe_gt_sriov_vf_query_config(struct xe_gt *gt)if (has_gmdid (xe))vf_cache_gmdid (gt); + err =vf_cache_num_paging_engines (gt); +if (unlikely (err)) +return err; +return 0 ; }
drivers/gpu/drm/xe/xe_gt_sriov_vf.c u16 xe_gt_sriov_vf_guc_ids(struct xe_gt *gt) · line 766
Quoted 5 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +2
-0@@ -731,6 +762,22 @@ u16 xe_gt_sriov_vf_guc_ids(struct xe_gt *gt)return gt->sriov.vf.self_config.num_ctxs; } +/** +* xe_gt_sriov_vf_paging_engines - Query the number of paging engine instances
nit: we don't do any query here
Quoted 34 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +14
-0+* @gt: the &xe_gt +* +* This function is for VF use only. +* +* Return: number of GuC paging engine instances configured by the PF. +*/ +u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt) +{ +xe_gt_assert (gt,IS_SRIOV_VF (gt_to_xe (gt))); +xe_gt_assert (gt, gt->sriov.vf.guc_version.major); + +return gt->sriov.vf.runtime.num_paging_engine_instances; +} +static int relay_action_handshake (struct xe_gt *gt,u32 *major,u32 *minor) {u32 request[VF2PF_HANDSHAKE_REQUEST_MSG_LEN ] = {drivers/gpu/drm/xe/xe_gt_sriov_vf.h +1
-0@@ -31,6 +31,7 @@ u32 xe_gt_sriov_vf_gmdid(struct xe_gt *gt);u16 xe_gt_sriov_vf_guc_ids (struct xe_gt *gt);u64 xe_gt_sriov_vf_lmem (struct xe_gt *gt);bool xe_gt_sriov_vf_sched_groups_enabled (struct xe_gt *gt); +u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt);u32 xe_gt_sriov_vf_read32 (struct xe_gt *gt,struct xe_reg reg);void xe_gt_sriov_vf_write32 (struct xe_gt *gt,struct xe_reg reg,u32 val);drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +0
-0
drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h struct xe_gt_sriov_vf_runtime { · line 46
Quoted 7 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +4
-0@@ -40,6 +40,10 @@ struct xe_gt_sriov_vf_runtime {/** @regs.value: register value. */ u32 value; } *regs; +/** +* @num_paging_engine_instances: number of configured paging engines. +*/ +u32 num_paging_engine_instances;
nit: can we move this up near .uses_sched_groups
Quoted 30 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +0
-0};/** drivers/gpu/drm/xe/xe_guc_klv_helpers.c +2
-0@@ -24,6 +24,8 @@ const char *xe_guc_klv_key_to_string(u16 key)/* GuC Global Config KLVs */ case GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY :return "group_scheduling_available" ; +case GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY : +return "num_paging_engine_instances" ;/* VGT POLICY keys */ case GUC_KLV_VGT_POLICY_SCHED_IF_IDLE_KEY :return "sched_if_idle" ;drivers/gpu/drm/xe/xe_hw_engine.c +1
-1@@ -650,7 +650,7 @@ static int hw_engine_init(struct xe_gt *gt, struct xe_hw_engine *hwe,return err; } -static void hw_engine_setup_logical_and_paging_mapping (struct xe_gt *gt) +static int hw_engine_setup_logical_and_paging_mapping (struct xe_gt *gt) {struct xe_device *xe =gt_to_xe (gt);unsigned int num_copy_engines =0 , num_paging_engines =0 ;
drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 670
Quoted 4 lines
drivers/gpu/drm/xe/xe_hw_engine.c +1
-0@@ -667,6 +667,27 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt)if (num_copy_engines && xe->info.has_usm) num_paging_engines =1 ; +if (IS_SRIOV_VF (xe)) {
maybe:
if (IS_SRIOV_VF(xe) && xe->info.platform >= XE_NOVALAKE_S) {
or
if (IS_SRIOV_VF(xe) && xe_uses_paging_class(xe)) {Quoted 5 lines
drivers/gpu/drm/xe/xe_hw_engine.c +5
-0+u32 vf_num_paging_engines; + +/* +* PF could in theory reserve multiple paging engines, which +* internally the submission/scheduling backend can load balance
drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 685
Quoted 10 lines
drivers/gpu/drm/xe/xe_hw_engine.c +10
-0+* from. Not something we currently expect, but we are at the +* mercy of the PF, so we just need try our best to mirror the +* paging configuration. +*/ + vf_num_paging_engines =xe_gt_sriov_vf_paging_engines (gt); +if (vf_num_paging_engines) { +/* This should only be non-zero on NVL-S+ */ +xe_gt_assert (gt, xe->info.platform >=XE_NOVALAKE_S ); + num_paging_engines = vf_num_paging_engines; + }
hmm, so what should we do if vf_num_paging_engines is actually 0 on NVL-S+?
can it be due to GuC FW being older that 1.36 on NVL-S+? can PF skip programming paging class on NVL-S+?
maybe 0 on NVL-S+ is a good reason to abort the probe?
Quoted 29 lines
drivers/gpu/drm/xe/xe_hw_engine.c +11
-1+ } + +if (xe_gt_WARN_ON (gt, num_paging_engines > num_copy_engines)) +return -EINVAL ; + reserved_logical_bcs_start = num_copy_engines - num_paging_engines;/* FIXME: Doing a simple logical mapping that works for most hardware */ @@ -688,6 +709,8 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) } } } + +return 0 ; }static void read_media_fuses (struct xe_gt *gt)@@ -906,7 +929,10 @@ int xe_hw_engines_init(struct xe_gt *gt)return err; } -hw_engine_setup_logical_and_paging_mapping (gt); + err =hw_engine_setup_logical_and_paging_mapping (gt); +if (err) +return err; + err =xe_hw_engine_setup_groups (gt);if (err)return err;
Re: [PATCH v6 08/10] drm/xe/vf: wire up NUM_PAGING_ENGINE_INSTANCES
Quoted 222 lines · Michal Wajdeczko
Quoted 85 lines · Matthew Auld
When host PF writes the logical configuration for the GUC PAGING engine, the VF is meant to query it, and mirror it. Size of N means we have paging logical index range [0, N-1], with N fewer normal copy engines.
Agreement is that PF will only spawn PAGING engines on NVL-S+, so this should be zero on older platforms, where we should simply fall back to the old behaviour.
v2 (Sashiko):
- We can't call use theguc_has_paging_engine()this early in the VF code. With that just unconditionally do the query, if the GuC is new enough and take the value as-is. With that drop the -1 special case and just let the upper layers figure out the rest.
v3:
- Also updatexe_guc_klv_key_to_string. (Michal)
- Add kernel-doc forxe_gt_sriov_vf_paging_engines(), plus other tweaks. (Michal)
- Update with final GuC version.
v4:
- Just fallback to manual reserve when vf reported paging engines is zero. Will revisit in the future.Signed-off-by Matthew Auld <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>Cc Piotr Piórkowski <[email protected]>Cc Michal Wajdeczko <[email protected]>--- drivers/gpu/drm/xe/abi/guc_klvs_abi.h | 9 +++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 47 +++++++++++++++++++++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.h | 1 + drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h | 4 ++ drivers/gpu/drm/xe/xe_guc_klv_helpers.c | 2 + drivers/gpu/drm/xe/xe_hw_engine.c | 30 ++++++++++++++- 6 files changed, 91 insertions(+), 2 deletions(-)drivers/gpu/drm/xe/abi/guc_klvs_abi.h +9
-0@@ -52,6 +52,12 @@* _`GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE` : 0x3001 * Tells the driver whether scheduler groups are enabled or not. * Requires GuC ABI 1.26+ +* +* _`GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES` : 0x3003 +* Tells the driver the paging engine configuration. +* Paging engine logical instances are guaranteed to be dense starting at +* index 0. +* Requires GuC ABI 1.36+ */ #define GUC_KLV_GLOBAL_CFG_GMD_ID_KEY 0x3000u@@ -60,6 +66,9 @@#define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY 0x3001u#define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_LEN 1u +#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY 0x3003u +#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_LEN 1u +/** * DOC: GuC Self Config KLVs * drivers/gpu/drm/xe/xe_gt_sriov_vf.c +15
-0@@ -658,6 +658,33 @@ static int vf_cache_sched_groups_status(struct xe_gt *gt)return 0 ; } +static int vf_cache_num_paging_engines (struct xe_gt *gt) +{ +struct xe_guc *guc = >->uc.guc; +struct xe_uc_fw_version guc_version; +u32 value =0 ; +int err; + +xe_gt_sriov_vf_guc_versions (gt,NULL , &guc_version); + +if (MAKE_GUC_VER_STRUCT (guc_version) <MAKE_GUC_VER (1 ,36 ,0 )) +return 0 ; + + err =guc_action_query_single_klv32 (guc,GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY , + &value); +if (unlikely (err)) {drivers/gpu/drm/xe/xe_gt_sriov_vf.c static int vf_cache_sched_groups_status(struct xe_gt *gt) · line 685
Quoted 10 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +10
-0+xe_gt_sriov_err (gt, +"Failed to obtain the number of paging instances (%pe)\n" , +ERR_PTR (err)); +return err; + } + + gt->sriov.vf.runtime.num_paging_engine_instances = value; + +xe_gt_sriov_dbg (gt,"num_paging_engines %u\n" , value); +return err;return 0;Quoted 17 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +6
-0+} +/** * xe_gt_sriov_vf_query_config - Query SR-IOV config data over MMIO. * @gt: the &xe_gt @@ -694,6 +721,10 @@ int xe_gt_sriov_vf_query_config(struct xe_gt *gt)if (has_gmdid (xe))vf_cache_gmdid (gt); + err =vf_cache_num_paging_engines (gt); +if (unlikely (err)) +return err; +return 0 ; }drivers/gpu/drm/xe/xe_gt_sriov_vf.c u16 xe_gt_sriov_vf_guc_ids(struct xe_gt *gt) · line 766
Quoted 5 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +2
-0@@ -731,6 +762,22 @@ u16 xe_gt_sriov_vf_guc_ids(struct xe_gt *gt)return gt->sriov.vf.self_config.num_ctxs; } +/** +* xe_gt_sriov_vf_paging_engines - Query the number of paging engine instances nit: we don't do any query here
Quoted 34 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +14
-0+* @gt: the &xe_gt +* +* This function is for VF use only. +* +* Return: number of GuC paging engine instances configured by the PF. +*/ +u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt) +{ +xe_gt_assert (gt,IS_SRIOV_VF (gt_to_xe (gt))); +xe_gt_assert (gt, gt->sriov.vf.guc_version.major); + +return gt->sriov.vf.runtime.num_paging_engine_instances; +} +static int relay_action_handshake (struct xe_gt *gt,u32 *major,u32 *minor) {u32 request[VF2PF_HANDSHAKE_REQUEST_MSG_LEN ] = {drivers/gpu/drm/xe/xe_gt_sriov_vf.h +1
-0@@ -31,6 +31,7 @@ u32 xe_gt_sriov_vf_gmdid(struct xe_gt *gt);u16 xe_gt_sriov_vf_guc_ids (struct xe_gt *gt);u64 xe_gt_sriov_vf_lmem (struct xe_gt *gt);bool xe_gt_sriov_vf_sched_groups_enabled (struct xe_gt *gt); +u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt);u32 xe_gt_sriov_vf_read32 (struct xe_gt *gt,struct xe_reg reg);void xe_gt_sriov_vf_write32 (struct xe_gt *gt,struct xe_reg reg,u32 val);drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +0
-0drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h struct xe_gt_sriov_vf_runtime { · line 46
Quoted 7 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +4
-0@@ -40,6 +40,10 @@ struct xe_gt_sriov_vf_runtime {/** @regs.value: register value. */ u32 value; } *regs; +/** +* @num_paging_engine_instances: number of configured paging engines. +*/ +u32 num_paging_engine_instances;nit: can we move this up near .uses_sched_groups
Quoted 30 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +0
-0};/** drivers/gpu/drm/xe/xe_guc_klv_helpers.c +2
-0@@ -24,6 +24,8 @@ const char *xe_guc_klv_key_to_string(u16 key)/* GuC Global Config KLVs */ case GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY :return "group_scheduling_available" ; +case GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY : +return "num_paging_engine_instances" ;/* VGT POLICY keys */ case GUC_KLV_VGT_POLICY_SCHED_IF_IDLE_KEY :return "sched_if_idle" ;drivers/gpu/drm/xe/xe_hw_engine.c +1
-1@@ -650,7 +650,7 @@ static int hw_engine_init(struct xe_gt *gt, struct xe_hw_engine *hwe,return err; } -static void hw_engine_setup_logical_and_paging_mapping (struct xe_gt *gt) +static int hw_engine_setup_logical_and_paging_mapping (struct xe_gt *gt) {struct xe_device *xe =gt_to_xe (gt);unsigned int num_copy_engines =0 , num_paging_engines =0 ;drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 670
Quoted 4 lines
drivers/gpu/drm/xe/xe_hw_engine.c +1
-0@@ -667,6 +667,27 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt)if (num_copy_engines && xe->info.has_usm) num_paging_engines =1 ; +if (IS_SRIOV_VF (xe)) {maybe:
if (IS_SRIOV_VF(xe) && xe->info.platform >= XE_NOVALAKE_S) { or if (IS_SRIOV_VF(xe) && xe_uses_paging_class(xe)) {Quoted 5 lines
drivers/gpu/drm/xe/xe_hw_engine.c +5
-0+u32 vf_num_paging_engines; + +/* +* PF could in theory reserve multiple paging engines, which +* internally the submission/scheduling backend can load balance drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 685
Quoted 10 lines
drivers/gpu/drm/xe/xe_hw_engine.c +10
-0+* from. Not something we currently expect, but we are at the +* mercy of the PF, so we just need try our best to mirror the +* paging configuration. +*/ + vf_num_paging_engines =xe_gt_sriov_vf_paging_engines (gt); +if (vf_num_paging_engines) { +/* This should only be non-zero on NVL-S+ */ +xe_gt_assert (gt, xe->info.platform >=XE_NOVALAKE_S ); + num_paging_engines = vf_num_paging_engines; + }hmm, so what should we do if
vf_num_paging_enginesis actually 0 on NVL-S+?
Quoted 2 lines
can it be due to GuC FW being older that 1.36 on NVL-S+? can PF skip programming paging class on NVL-S+?
PF can indeed skip programming the paging class and that is a valid (although currently unexpected) scenario.
Quoted 2 lines
maybe 0 on NVL-S+ is a good reason to abort the probe?
The expectation from the GuC side is that if PF has reserved a paging engine then VF must match it, but if PF hasn't reserved a paging engine then VF is free to reserve a BCS to do paging.
Quoted 30 lines
Quoted 30 lines
drivers/gpu/drm/xe/xe_hw_engine.c +11
-1+ } + +if (xe_gt_WARN_ON (gt, num_paging_engines > num_copy_engines)) +return -EINVAL ; + reserved_logical_bcs_start = num_copy_engines - num_paging_engines;/* FIXME: Doing a simple logical mapping that works for most hardware */ @@ -688,6 +709,8 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) } } } + +return 0 ; }static void read_media_fuses (struct xe_gt *gt)@@ -906,7 +929,10 @@ int xe_hw_engines_init(struct xe_gt *gt)return err; } -hw_engine_setup_logical_and_paging_mapping (gt); + err =hw_engine_setup_logical_and_paging_mapping (gt); +if (err) +return err; + err =xe_hw_engine_setup_groups (gt);if (err)return err;
Re: [PATCH v6 08/10] drm/xe/vf: wire up NUM_PAGING_ENGINE_INSTANCES
Quoted 198 lines · Daniele Ceraolo Spurio
Quoted 195 lines · Michal Wajdeczko
Quoted 82 lines · Matthew Auld
When host PF writes the logical configuration for the GUC PAGING engine, the VF is meant to query it, and mirror it. Size of N means we have paging logical index range [0, N-1], with N fewer normal copy engines.
Agreement is that PF will only spawn PAGING engines on NVL-S+, so this should be zero on older platforms, where we should simply fall back to the old behaviour.
v2 (Sashiko):
- We can't call use theguc_has_paging_engine()this early in the VF code. With that just unconditionally do the query, if the GuC is new enough and take the value as-is. With that drop the -1 special case and just let the upper layers figure out the rest.
v3:
- Also updatexe_guc_klv_key_to_string. (Michal)
- Add kernel-doc forxe_gt_sriov_vf_paging_engines(), plus other tweaks. (Michal)
- Update with final GuC version.
v4:
- Just fallback to manual reserve when vf reported paging engines is zero. Will revisit in the future.Signed-off-by Matthew Auld <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>Cc Piotr Piórkowski <[email protected]>Cc Michal Wajdeczko <[email protected]>---
drivers/gpu/drm/xe/abi/guc_klvs_abi.h | 9 +++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 47 +++++++++++++++++++++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.h | 1 +drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h| 4 ++ drivers/gpu/drm/xe/xe_guc_klv_helpers.c | 2 + drivers/gpu/drm/xe/xe_hw_engine.c | 30 ++++++++++++++-6 files changed, 91 insertions(+), 2 deletions(-)drivers/gpu/drm/xe/abi/guc_klvs_abi.h +6
-0@@ -52,6 +52,12 @@* _`GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE` : 0x3001 * Tells the driver whether scheduler groups are enabled or not. * Requires GuC ABI 1.26+ +* +* _`GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES` : 0x3003 +* Tells the driver the paging engine configuration. +* Paging engine logical instances are guaranteed to be dense starting at +* index 0. +* Requires GuC ABI 1.36+ */ #define GUC_KLV_GLOBAL_CFG_GMD_ID_KEY 0x3000u@@ -60,6 +66,9 @@ #define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY 0x3001u #define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_LEN 1u+#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY
0x3003udrivers/gpu/drm/xe/abi/guc_klvs_abi.h +2
-0+#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_LEN 1u +/**
* DOC: GuC Self Config KLVs
*drivers/gpu/drm/xe/xe_gt_sriov_vf.c +14
-0@@ -658,6 +658,33 @@ static int vf_cache_sched_groups_status(struct xe_gt *gt) return 0; } +static int vf_cache_num_paging_engines(struct xe_gt *gt) +{ + struct xe_guc *guc = >->uc.guc; + struct xe_uc_fw_version guc_version; + u32 value = 0; + int err; + + xe_gt_sriov_vf_guc_versions(gt, NULL, &guc_version); + + if (MAKE_GUC_VER_STRUCT(guc_version) < MAKE_GUC_VER(1, 36, 0)) + return 0; + + err = guc_action_query_single_klv32(guc, GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY, + &value); + if (unlikely(err)) {drivers/gpu/drm/xe/xe_gt_sriov_vf.c static int vf_cache_sched_groups_status(struct xe_gt *gt) · line 684
Quoted 10 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +10
-0+ xe_gt_sriov_err(gt, + "Failed to obtain the number of paging instances (%pe)\n", + ERR_PTR(err)); + return err; + } + + gt->sriov.vf.runtime.num_paging_engine_instances = value; + + xe_gt_sriov_dbg(gt, "num_paging_engines %u\n", value); + return err;return 0;
Quoted 15 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +5
-0+} + /*** xe_gt_sriov_vf_query_config - Query SR-IOV config data over MMIO. * @gt: the &xe_gt @@ -694,6 +721,10 @@ int xe_gt_sriov_vf_query_config(struct xe_gt *gt) if (has_gmdid(xe)) vf_cache_gmdid(gt); + err = vf_cache_num_paging_engines(gt); + if (unlikely(err)) + return err; + return 0; } @@ -731,6 +762,22 @@ u16 xe_gt_sriov_vf_guc_ids(struct xe_gt *gt)Quoted 4 lines
return
gt->sriov.vf.self_config.num_ctxs;
}
+/**
+ *xe_gt_sriov_vf_paging_engines- Query the number of paging engine instancesnit: we don't do any query here
Quoted 33 lines
+ * @gt: the
&xe_gt
+ *
+ * This function is for VF use only.
+ *
+ * Return: number of GuC paging engine instances configured by the PF.
+ */drivers/gpu/drm/xe/xe_gt_sriov_vf.c +8
-0+u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt) +{ + xe_gt_assert(gt, IS_SRIOV_VF(gt_to_xe(gt))); + xe_gt_assert(gt, gt->sriov.vf.guc_version.major); + + return gt->sriov.vf.runtime.num_paging_engine_instances; +} +static int
relay_action_handshake(struct xe_gt *gt, u32 *major, u32 *minor){
u32 request[VF2PF_HANDSHAKE_REQUEST_MSG_LEN] = {drivers/gpu/drm/xe/xe_gt_sriov_vf.h +1
-0@@ -31,6 +31,7 @@ u32 xe_gt_sriov_vf_gmdid(struct xe_gt *gt); u16 xe_gt_sriov_vf_guc_ids(struct xe_gt *gt); u64 xe_gt_sriov_vf_lmem(struct xe_gt *gt); bool xe_gt_sriov_vf_sched_groups_enabled(struct xe_gt *gt); +u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt); u32 xe_gt_sriov_vf_read32(struct xe_gt *gt, struct xe_reg reg); void xe_gt_sriov_vf_write32(struct xe_gt *gt, struct xe_reg reg, u32 val);drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +0
-0drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h struct xe_gt_sriov_vf_runtime { · line 46
Quoted 7 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +4
-0@@ -40,6 +40,10 @@ struct xe_gt_sriov_vf_runtime { /** @regs.value: register value. */ u32 value; } *regs; + /** + * @num_paging_engine_instances: number of configured paging engines. + */ + u32 num_paging_engine_instances;nit: can we move this up near .uses_sched_groups
Quoted 28 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +0
-0}; /**drivers/gpu/drm/xe/xe_guc_klv_helpers.c +0
-0@@ -24,6 +24,8 @@ const char *xe_guc_klv_key_to_string(u16 key) /* GuC Global Config KLVs */case
GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY:
return "group_scheduling_available";
+ caseGUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY:
+ return "num_paging_engine_instances";
/* VGT POLICY keys */
caseGUC_KLV_VGT_POLICY_SCHED_IF_IDLE_KEY:
return "sched_if_idle";drivers/gpu/drm/xe/xe_hw_engine.c +1
-0@@ -650,7 +650,7 @@ static int hw_engine_init(struct xe_gt *gt, struct xe_hw_engine *hwe, return err; } -static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) +static int hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) { struct xe_device *xe = gt_to_xe(gt); unsigned int num_copy_engines = 0, num_paging_engines = 0;drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 669
Quoted 3 lines
drivers/gpu/drm/xe/xe_hw_engine.c +0
-0@@ -667,6 +667,27 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) if (num_copy_engines && xe->info.has_usm) num_paging_engines = 1; + if (IS_SRIOV_VF(xe)) {maybe:
if (
IS_SRIOV_VF(xe)&&xe->info.platform>=XE_NOVALAKE_S) { or
if (IS_SRIOV_VF(xe)&&xe_uses_paging_class(xe)) {
Quoted 13 lines
Quoted 5 lines
Quoted 5 lines
drivers/gpu/drm/xe/xe_hw_engine.c +5
-0+ u32 vf_num_paging_engines; + + /* +* PF could in theory reserve multiple paging engines, which +* internally the submission/scheduling backend can load balance Quoted 8 lines
drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 683
Quoted 8 lines
drivers/gpu/drm/xe/xe_hw_engine.c +8
-0+* from. Not something we currently expect, but we are at the +* mercy of the PF, so we just need try our best to mirror the +* paging configuration. +*/ + vf_num_paging_engines = xe_gt_sriov_vf_paging_engines(gt); + if (vf_num_paging_engines) { + /* This should only be non-zero on NVL-S+ */ + xe_gt_assert(gt, xe->info.platform >= XE_NOVALAKE_S);
missed this one: I'm not sure we should use assert here:
it's not our fault after all, but it's misbehaving PF, so either we silently live with that or abort
Quoted 7 lines
Quoted 6 lines
drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 684
Quoted 2 lines
drivers/gpu/drm/xe/xe_hw_engine.c +2
-0+ num_paging_engines = vf_num_paging_engines; + }hmm, so what should we do if
vf_num_paging_enginesis actually 0 on NVL-S+?can it be due to GuC FW being older that 1.36 on NVL-S+? can PF skip programming paging class on NVL-S+?
Quoted 6 lines
PF can indeed skip programming the paging class and that is a valid (although currently unexpected) scenario.
Quoted 2 lines
maybe 0 on NVL-S+ is a good reason to abort the probe?
The expectation from the GuC side is that if PF has reserved a paging engine then VF must match it, but if PF hasn't reserved a paging engine then VF is free to reserve a BCS to do paging.
but then this paging engine on VF side will not be a paging CLASS, as the rest of the code may assume or it doesn't matter for the VF?
Quoted 29 lines
Quoted 28 lines
Quoted 28 lines
drivers/gpu/drm/xe/xe_hw_engine.c +11
-0+ } + + if (xe_gt_WARN_ON(gt, num_paging_engines > num_copy_engines)) + return -EINVAL; + reserved_logical_bcs_start = num_copy_engines - num_paging_engines; /* FIXME: Doing a simple logical mapping that works for most hardware */@@ -688,6 +709,8 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) } } } + + return 0; } static void read_media_fuses(struct xe_gt *gt)@@ -906,7 +929,10 @@ int xe_hw_engines_init(struct xe_gt *gt) return err; } - hw_engine_setup_logical_and_paging_mapping(gt); + err = hw_engine_setup_logical_and_paging_mapping(gt); + if (err) + return err; + err = xe_hw_engine_setup_groups(gt); if (err) return err;
Re: [PATCH v6 08/10] drm/xe/vf: wire up NUM_PAGING_ENGINE_INSTANCES
Quoted 219 lines · Michal Wajdeczko
Quoted 196 lines · Daniele Ceraolo Spurio
Quoted 194 lines · Michal Wajdeczko
Quoted 82 lines · Matthew Auld
When host PF writes the logical configuration for the GUC PAGING engine, the VF is meant to query it, and mirror it. Size of N means we have paging logical index range [0, N-1], with N fewer normal copy engines.
Agreement is that PF will only spawn PAGING engines on NVL-S+, so this should be zero on older platforms, where we should simply fall back to the old behaviour.
v2 (Sashiko):
- We can't call use theguc_has_paging_engine()this early in the VF code. With that just unconditionally do the query, if the GuC is new enough and take the value as-is. With that drop the -1 special case and just let the upper layers figure out the rest.
v3:
- Also updatexe_guc_klv_key_to_string. (Michal)
- Add kernel-doc forxe_gt_sriov_vf_paging_engines(), plus other tweaks. (Michal)
- Update with final GuC version.
v4:
- Just fallback to manual reserve when vf reported paging engines is zero. Will revisit in the future.Signed-off-by Matthew Auld <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>Cc Piotr Piórkowski <[email protected]>Cc Michal Wajdeczko <[email protected]>--- drivers/gpu/drm/xe/abi/guc_klvs_abi.h | 9 +++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 47 +++++++++++++++++++++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.h | 1 + drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h | 4 ++ drivers/gpu/drm/xe/xe_guc_klv_helpers.c | 2 + drivers/gpu/drm/xe/xe_hw_engine.c | 30 ++++++++++++++- 6 files changed, 91 insertions(+), 2 deletions(-)drivers/gpu/drm/xe/abi/guc_klvs_abi.h +8
-0@@ -52,6 +52,12 @@* _`GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE` : 0x3001 * Tells the driver whether scheduler groups are enabled or not. * Requires GuC ABI 1.26+ +* +* _`GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES` : 0x3003 +* Tells the driver the paging engine configuration. +* Paging engine logical instances are guaranteed to be dense starting at +* index 0. +* Requires GuC ABI 1.36+ */ #define GUC_KLV_GLOBAL_CFG_GMD_ID_KEY 0x3000u@@ -60,6 +66,9 @@ #define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY 0x3001u #define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_LEN 1u +#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY 0x3003u +#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_LEN 1u + /*** DOC: GuC Self Config KLVs * drivers/gpu/drm/xe/xe_gt_sriov_vf.c +14
-0@@ -658,6 +658,33 @@ static int vf_cache_sched_groups_status(struct xe_gt *gt) return 0; } +static int vf_cache_num_paging_engines(struct xe_gt *gt) +{ + struct xe_guc *guc = >->uc.guc; + struct xe_uc_fw_version guc_version; + u32 value = 0; + int err; + + xe_gt_sriov_vf_guc_versions(gt, NULL, &guc_version); + + if (MAKE_GUC_VER_STRUCT(guc_version) < MAKE_GUC_VER(1, 36, 0)) + return 0; + + err = guc_action_query_single_klv32(guc, GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY, + &value); + if (unlikely(err)) {drivers/gpu/drm/xe/xe_gt_sriov_vf.c static int vf_cache_sched_groups_status(struct xe_gt *gt) · line 684
Quoted 10 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +10
-0+ xe_gt_sriov_err(gt, + "Failed to obtain the number of paging instances (%pe)\n", + ERR_PTR(err)); + return err; + } + + gt->sriov.vf.runtime.num_paging_engine_instances = value; + + xe_gt_sriov_dbg(gt, "num_paging_engines %u\n", value); + return err;return 0;
Quoted 9 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +2
-0+} + /*** xe_gt_sriov_vf_query_config - Query SR-IOV config data over MMIO. * @gt: the &xe_gt @@ -694,6 +721,10 @@ int xe_gt_sriov_vf_query_config(struct xe_gt *gt) if (has_gmdid(xe)) vf_cache_gmdid(gt); + err = vf_cache_num_paging_engines(gt);drivers/gpu/drm/xe/xe_gt_sriov_vf.c int xe_gt_sriov_vf_query_config(struct xe_gt *gt)
Quoted 10 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +4
-0+ if (unlikely(err)) + return err; + return 0; } @@ -731,6 +762,22 @@ u16 xe_gt_sriov_vf_guc_ids(struct xe_gt *gt) return gt->sriov.vf.self_config.num_ctxs; } +/** +* xe_gt_sriov_vf_paging_engines - Query the number of paging engine instances nit: we don't do any query here
Quoted 33 lines
+ * @gt: the
&xe_gt
+ *
+ * This function is for VF use only.
+ *
+ * Return: number of GuC paging engine instances configured by the PF.
+ */drivers/gpu/drm/xe/xe_gt_sriov_vf.c +8
-0+u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt) +{ + xe_gt_assert(gt, IS_SRIOV_VF(gt_to_xe(gt))); + xe_gt_assert(gt, gt->sriov.vf.guc_version.major); + + return gt->sriov.vf.runtime.num_paging_engine_instances; +} + static int relay_action_handshake(struct xe_gt *gt, u32 *major, u32 *minor) { u32 request[VF2PF_HANDSHAKE_REQUEST_MSG_LEN] = {drivers/gpu/drm/xe/xe_gt_sriov_vf.h +1
-0@@ -31,6 +31,7 @@ u32 xe_gt_sriov_vf_gmdid(struct xe_gt *gt); u16 xe_gt_sriov_vf_guc_ids(struct xe_gt *gt); u64 xe_gt_sriov_vf_lmem(struct xe_gt *gt); bool xe_gt_sriov_vf_sched_groups_enabled(struct xe_gt *gt); +u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt); u32 xe_gt_sriov_vf_read32(struct xe_gt *gt, struct xe_reg reg); void xe_gt_sriov_vf_write32(struct xe_gt *gt, struct xe_reg reg, u32 val);drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +0
-0drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h struct xe_gt_sriov_vf_runtime { · line 46
Quoted 7 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +4
-0@@ -40,6 +40,10 @@ struct xe_gt_sriov_vf_runtime { /** @regs.value: register value. */ u32 value; } *regs; + /** + * @num_paging_engine_instances: number of configured paging engines. + */ + u32 num_paging_engine_instances;nit: can we move this up near .uses_sched_groups
Quoted 28 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +0
-0}; /**drivers/gpu/drm/xe/xe_guc_klv_helpers.c +2
-0@@ -24,6 +24,8 @@ const char *xe_guc_klv_key_to_string(u16 key) /* GuC Global Config KLVs */ case GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY: return "group_scheduling_available"; + case GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY: + return "num_paging_engine_instances"; /* VGT POLICY keys */ case GUC_KLV_VGT_POLICY_SCHED_IF_IDLE_KEY: return "sched_if_idle";drivers/gpu/drm/xe/xe_hw_engine.c +1
-0@@ -650,7 +650,7 @@ static int hw_engine_init(struct xe_gt *gt, struct xe_hw_engine *hwe, return err; } -static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) +static int hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) { struct xe_device *xe = gt_to_xe(gt); unsigned int num_copy_engines = 0, num_paging_engines = 0;drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 669
Quoted 3 lines
drivers/gpu/drm/xe/xe_hw_engine.c +0
-0@@ -667,6 +667,27 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) if (num_copy_engines && xe->info.has_usm) num_paging_engines = 1; + if (IS_SRIOV_VF(xe)) {maybe:
if (
IS_SRIOV_VF(xe)&&xe->info.platform>=XE_NOVALAKE_S) {
or
if (IS_SRIOV_VF(xe)&&xe_uses_paging_class(xe)) {Quoted 13 lines
Quoted 5 lines
Quoted 5 lines
drivers/gpu/drm/xe/xe_hw_engine.c +5
-0+ u32 vf_num_paging_engines; + + /* +* PF could in theory reserve multiple paging engines, which +* internally the submission/scheduling backend can load balance Quoted 8 lines
drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 683
Quoted 8 lines
drivers/gpu/drm/xe/xe_hw_engine.c +8
-0+* from. Not something we currently expect, but we are at the +* mercy of the PF, so we just need try our best to mirror the +* paging configuration. +*/ + vf_num_paging_engines = xe_gt_sriov_vf_paging_engines(gt); + if (vf_num_paging_engines) { + /* This should only be non-zero on NVL-S+ */ + xe_gt_assert(gt, xe->info.platform >= XE_NOVALAKE_S);missed this one: I'm not sure we should use assert here:
it's not our fault after all, but it's misbehaving PF, so either we silently live with that or abortQuoted 4 lines
Quoted 4 lines
drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 684
Quoted 2 lines
drivers/gpu/drm/xe/xe_hw_engine.c +2
-0+ num_paging_engines = vf_num_paging_engines; + }hmm, so what should we do if
vf_num_paging_enginesis actually 0 on NVL-S+?
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
can it be due to GuC FW being older that 1.36 on NVL-S+? can PF skip programming paging class on NVL-S+?
PF can indeed skip programming the paging class and that is a valid (although currently unexpected) scenario.
Quoted 1 line
maybe 0 on NVL-S+ is a good reason to abort the probe?
The expectation from the GuC side is that if PF has reserved a paging engine then VF must match it, but if PF hasn't reserved a paging engine then VF is free to reserve a BCS to do paging.
but then this paging engine on VF side will not be a paging CLASS, as the rest of the code may assume or it doesn't matter for the VF?
You're right that if we reserve a BCS (like we do now on current platforms) then it needs to be submitted as a COPY class and not as a PAGING class.
It looks like xe_hwe_to_guc_class and xe_hwe_guc_logical_instance might be unconditionally returning PAGING class on VF if we're on a setup that supports it even if PF has not enabled it (unless I'm missing something), so that might need to be updated.
Quoted 27 lines
Quoted 27 lines
Quoted 27 lines
Quoted 27 lines
drivers/gpu/drm/xe/xe_hw_engine.c +11
-0+ } + + if (xe_gt_WARN_ON(gt, num_paging_engines > num_copy_engines)) + return -EINVAL; + reserved_logical_bcs_start = num_copy_engines - num_paging_engines; /* FIXME: Doing a simple logical mapping that works for most hardware */@@ -688,6 +709,8 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) } } } + + return 0; } static void read_media_fuses(struct xe_gt *gt)@@ -906,7 +929,10 @@ int xe_hw_engines_init(struct xe_gt *gt) return err; } - hw_engine_setup_logical_and_paging_mapping(gt); + err = hw_engine_setup_logical_and_paging_mapping(gt); + if (err) + return err; + err = xe_hw_engine_setup_groups(gt); if (err) return err;
Re: [PATCH v6 08/10] drm/xe/vf: wire up NUM_PAGING_ENGINE_INSTANCES
Quoted 241 lines · Daniele Ceraolo Spurio
Quoted 238 lines · Michal Wajdeczko
Quoted 208 lines · Daniele Ceraolo Spurio
Quoted 206 lines · Michal Wajdeczko
Quoted 87 lines · Matthew Auld
When host PF writes the logical configuration for the GUC PAGING engine, the VF is meant to query it, and mirror it. Size of N means we have paging logical index range [0, N-1], with N fewer normal copy engines.
Agreement is that PF will only spawn PAGING engines on NVL-S+, so this should be zero on older platforms, where we should simply fall back to the old behaviour.
v2 (Sashiko):
- We can't call use theguc_has_paging_engine()this early in the VF code. With that just unconditionally do the query, if the GuC is new enough and take the value as-is. With that drop the -1 special case and just let the upper layers figure out the rest.
v3:
- Also updatexe_guc_klv_key_to_string. (Michal)
- Add kernel-doc forxe_gt_sriov_vf_paging_engines(), plus other tweaks. (Michal)
- Update with final GuC version.
v4:
- Just fallback to manual reserve when vf reported paging engines is zero. Will revisit in the future.Signed-off-by Matthew Auld <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>Cc Piotr Piórkowski <[email protected]>Cc Michal Wajdeczko <[email protected]>---
drivers/gpu/drm/xe/abi/guc_klvs_abi.h | 9 +++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 47
+++++++++++++++++++++++
drivers/gpu/drm/xe/xe_gt_sriov_vf.h | 1 +drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h| 4 ++ drivers/gpu/drm/xe/xe_guc_klv_helpers.c | 2 + drivers/gpu/drm/xe/xe_hw_engine.c | 30 ++++++++++++++-6 files changed, 91 insertions(+), 2 deletions(-)drivers/gpu/drm/xe/abi/guc_klvs_abi.h +4
-0@@ -52,6 +52,12 @@ * _`GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE` : 0x3001 * Tells the driver whether scheduler groups are enabled or not. * Requires GuC ABI 1.26+ + * + * _`GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES` : 0x3003 + * Tells the driver the paging engine configuration. + * Paging engine logical instances are guaranteed to bedense starting at
+ * index 0.
+ * Requires GuC ABI 1.36+
*/
#defineGUC_KLV_GLOBAL_CFG_GMD_ID_KEY0x3000udrivers/gpu/drm/xe/abi/guc_klvs_abi.h +0
-0@@ -60,6 +66,9 @@ #define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY 0x3001u #define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_LEN 1u+#define
GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY0x3003udrivers/gpu/drm/xe/abi/guc_klvs_abi.h +2
-0+#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_LEN 1u +/**
* DOC: GuC Self Config KLVs
*drivers/gpu/drm/xe/xe_gt_sriov_vf.c +15
-0@@ -658,6 +658,33 @@ static int vf_cache_sched_groups_status(struct xe_gt *gt) return 0; } +static int vf_cache_num_paging_engines(struct xe_gt *gt) +{ + struct xe_guc *guc = >->uc.guc; + struct xe_uc_fw_version guc_version; + u32 value = 0; + int err; + + xe_gt_sriov_vf_guc_versions(gt, NULL, &guc_version); + + if (MAKE_GUC_VER_STRUCT(guc_version) < MAKE_GUC_VER(1, 36, 0)) + return 0; + + err = guc_action_query_single_klv32(guc,GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY , + &value); + if (unlikely(err)) { + xe_gt_sriov_err(gt,drivers/gpu/drm/xe/xe_gt_sriov_vf.c static int · line 687
Quoted 10 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +9
-0+ "Failed to obtain the number of paging instances (%pe)\n", + ERR_PTR(err)); + return err; + } + + gt->sriov.vf.runtime.num_paging_engine_instances = value; + + xe_gt_sriov_dbg(gt, "num_paging_engines %u\n", value); + return err;return 0;
Quoted 15 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +2
-0+} +/**
*xe_gt_sriov_vf_query_config- Query SR-IOV config data over MMIO.
* @gt: the&xe_gtdrivers/gpu/drm/xe/xe_gt_sriov_vf.c +3
-0@@ -694,6 +721,10 @@ int xe_gt_sriov_vf_query_config(struct xe_gt *gt) if (has_gmdid(xe)) vf_cache_gmdid(gt); + err = vf_cache_num_paging_engines(gt); + if (unlikely(err)) + return err; + return 0; }Quoted 6 lines
@@ -731,6 +762,22 @@ u16
xe_gt_sriov_vf_guc_ids(struct xe_gt *gt)returngt->sriov.vf.self_config.num_ctxs;
}
+/**
+ *xe_gt_sriov_vf_paging_engines- Query the number of paging engine instancesnit: we don't do any query here
Quoted 39 lines
+ * @gt: the
&xe_gt
+ *
+ * This function is for VF use only.
+ *
+ * Return: number of GuC paging engine instances configured by the PF.
+ */drivers/gpu/drm/xe/xe_gt_sriov_vf.c +8
-0+u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt) +{ + xe_gt_assert(gt, IS_SRIOV_VF(gt_to_xe(gt))); + xe_gt_assert(gt, gt->sriov.vf.guc_version.major); + + return gt->sriov.vf.runtime.num_paging_engine_instances; +} +static int
relay_action_handshake(struct xe_gt *gt, u32 *major, u32 *minor){
u32 request[VF2PF_HANDSHAKE_REQUEST_MSG_LEN] = {drivers/gpu/drm/xe/xe_gt_sriov_vf.h +1
-0@@ -31,6 +31,7 @@ u32 xe_gt_sriov_vf_gmdid(struct xe_gt *gt); u16 xe_gt_sriov_vf_guc_ids(struct xe_gt *gt); u64 xe_gt_sriov_vf_lmem(struct xe_gt *gt); bool xe_gt_sriov_vf_sched_groups_enabled(struct xe_gt *gt); +u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt); u32 xe_gt_sriov_vf_read32(struct xe_gt *gt, struct xe_reg reg); void xe_gt_sriov_vf_write32(struct xe_gt *gt, struct xe_reg reg, u32 val);drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +2
-0@@ -40,6 +40,10 @@ struct xe_gt_sriov_vf_runtime { /** @regs.value: register value. */ u32 value; } *regs; + /** +* @num_paging_engine_instances: number of configured paging Quoted 3 lines
engines.
+ */
+ u32num_paging_engine_instances;nit: can we move this up near .uses_sched_groups
Quoted 30 lines
};
/**drivers/gpu/drm/xe/xe_guc_klv_helpers.c +0
-0@@ -24,6 +24,8 @@ const char *xe_guc_klv_key_to_string(u16 key) /* GuC Global Config KLVs */case
GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY:
return "group_scheduling_available";
+ caseGUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY:
+ return "num_paging_engine_instances";
/* VGT POLICY keys */
caseGUC_KLV_VGT_POLICY_SCHED_IF_IDLE_KEY:
return "sched_if_idle";drivers/gpu/drm/xe/xe_hw_engine.c +1
-0@@ -650,7 +650,7 @@ static int hw_engine_init(struct xe_gt *gt,struct xe_hw_engine *hwe, return err; } -static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) +static inthw_engine_setup_logical_and_paging_mapping (struct xe_gt *gt) {struct
xe_device*xe =gt_to_xe(gt);
unsigned intnum_copy_engines= 0,num_paging_engines= 0;drivers/gpu/drm/xe/xe_hw_engine.c static void · line 670
Quoted 4 lines
drivers/gpu/drm/xe/xe_hw_engine.c +0
-0@@ -667,6 +667,27 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) if (num_copy_engines && xe->info.has_usm) num_paging_engines = 1; + if (IS_SRIOV_VF(xe)) {maybe:
if (
IS_SRIOV_VF(xe)&&xe->info.platform>=XE_NOVALAKE_S) { or
if (IS_SRIOV_VF(xe)&&xe_uses_paging_class(xe)) {Quoted 16 lines
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/xe/xe_hw_engine.c +5
-0+ u32 vf_num_paging_engines; + + /* +* PF could in theory reserve multiple paging engines, which +* internally the submission/scheduling backend can load balance
+ * from. Not something we currently expect, but we are at theQuoted 8 lines
Quoted 8 lines
+ * mercy of the PF, so we just need try our best to mirror the
+ * paging configuration.
+ */
+vf_num_paging_engines=xe_gt_sriov_vf_paging_engines(gt); + if (vf_num_paging_engines) {
+ /* This should only be non-zero on NVL-S+ */ +xe_gt_assert(gt, xe->info.platform >= XE_NOVALAKE_S);missed this one: I'm not sure we should use assert here:
it's not our fault after all, but it's misbehaving PF, so either we silently live with that or abortQuoted 8 lines
Quoted 6 lines
Quoted 2 lines
+
num_paging_engines=vf_num_paging_engines; + }hmm, so what should we do if
vf_num_paging_enginesis actually 0 on NVL-S+?can it be due to GuC FW being older that 1.36 on NVL-S+? can PF skip programming paging class on NVL-S+?
PF can indeed skip programming the paging class and that is a valid (although currently unexpected) scenario.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Quoted 1 line
maybe 0 on NVL-S+ is a good reason to abort the probe?
The expectation from the GuC side is that if PF has reserved a paging engine then VF must match it, but if PF hasn't reserved a paging engine then VF is free to reserve a BCS to do paging.
but then this paging engine on VF side will not be a paging CLASS, as the rest of the code may assume or it doesn't matter for the VF?
You're right that if we reserve a BCS (like we do now on current platforms) then it needs to be submitted as a COPY class and not as a PAGING class.
It looks likexe_hwe_to_guc_classandxe_hwe_guc_logical_instancemight be unconditionally returning PAGING class on VF if we're on a setup that supports it even if PF has not enabled it (unless I'm missing something), so that might need to be updated.
I was indeed missing something :)xe_guc_has_paging_engine(), which is used in both xe_hwe_to_guc_class and xe_hwe_guc_logical_instance to decide if COPY or PAGING class should be used, on VF returns true only if PF has reserved a paging engine (see patch 10); if no paging engines are reserved the code should automatically fall back to COPY class.
Quoted 30 lines
Quoted 29 lines
Quoted 29 lines
Quoted 29 lines
Quoted 29 lines
+ }
drivers/gpu/drm/xe/xe_hw_engine.c +4
-0+ + if (xe_gt_WARN_ON(gt, num_paging_engines > num_copy_engines)) + return -EINVAL; +
reserved_logical_bcs_start=num_copy_engines-num_paging_engines; /* FIXME: Doing a simple logical mapping that works for most hardware */drivers/gpu/drm/xe/xe_hw_engine.c +6
-0@@ -688,6 +709,8 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) } } } + + return 0; } static void read_media_fuses(struct xe_gt *gt)@@ -906,7 +929,10 @@ int xe_hw_engines_init(struct xe_gt *gt) return err; } - hw_engine_setup_logical_and_paging_mapping(gt); + err = hw_engine_setup_logical_and_paging_mapping(gt); + if (err) + return err; + err = xe_hw_engine_setup_groups(gt); if (err) return err;
Re: [PATCH v6 08/10] drm/xe/vf: wire up NUM_PAGING_ENGINE_INSTANCES
Quoted 246 lines · Daniele Ceraolo Spurio
Quoted 243 lines · Daniele Ceraolo Spurio
Quoted 240 lines · Michal Wajdeczko
Quoted 208 lines · Daniele Ceraolo Spurio
Quoted 206 lines · Michal Wajdeczko
Quoted 87 lines · Matthew Auld
When host PF writes the logical configuration for the GUC PAGING engine, the VF is meant to query it, and mirror it. Size of N means we have paging logical index range [0, N-1], with N fewer normal copy engines.
Agreement is that PF will only spawn PAGING engines on NVL-S+, so this should be zero on older platforms, where we should simply fall back to the old behaviour.
v2 (Sashiko):
- We can't call use theguc_has_paging_engine()this early in the VF code. With that just unconditionally do the query, if the GuC is new enough and take the value as-is. With that drop the -1 special case and just let the upper layers figure out the rest.
v3:
- Also updatexe_guc_klv_key_to_string. (Michal)
- Add kernel-doc forxe_gt_sriov_vf_paging_engines(), plus other tweaks. (Michal)
- Update with final GuC version.
v4:
- Just fallback to manual reserve when vf reported paging engines is zero. Will revisit in the future.Signed-off-by Matthew Auld <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>Cc Piotr Piórkowski <[email protected]>Cc Michal Wajdeczko <[email protected]>---
drivers/gpu/drm/xe/abi/guc_klvs_abi.h | 9 +++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 47 ++++++++++++++++
+++++++
drivers/gpu/drm/xe/xe_gt_sriov_vf.h | 1 +drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h| 4 ++ drivers/gpu/drm/xe/xe_guc_klv_helpers.c | 2 + drivers/gpu/drm/xe/xe_hw_engine.c | 30 ++++++++++++++-6 files changed, 91 insertions(+), 2 deletions(-)drivers/gpu/drm/xe/abi/guc_klvs_abi.h +4
-0@@ -52,6 +52,12 @@ * _`GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE` : 0x3001 * Tells the driver whether scheduler groups are enabled or not. * Requires GuC ABI 1.26+ + * + * _`GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES` : 0x3003 + * Tells the driver the paging engine configuration. + * Paging engine logical instances are guaranteed to bedense starting at
+ * index 0.
+ * Requires GuC ABI 1.36+
*/
#defineGUC_KLV_GLOBAL_CFG_GMD_ID_KEY0x3000udrivers/gpu/drm/xe/abi/guc_klvs_abi.h +0
-0@@ -60,6 +66,9 @@ #define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY 0x3001u #define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_LEN 1u+#define
GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY0x3003udrivers/gpu/drm/xe/abi/guc_klvs_abi.h +2
-0+#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_LEN 1u +/**
* DOC: GuC Self Config KLVs
*drivers/gpu/drm/xe/xe_gt_sriov_vf.c +15
-0@@ -658,6 +658,33 @@ static int vf_cache_sched_groups_status(struct xe_gt *gt) return 0; } +static int vf_cache_num_paging_engines(struct xe_gt *gt) +{ + struct xe_guc *guc = >->uc.guc; + struct xe_uc_fw_version guc_version; + u32 value = 0; + int err; + + xe_gt_sriov_vf_guc_versions(gt, NULL, &guc_version); + + if (MAKE_GUC_VER_STRUCT(guc_version) < MAKE_GUC_VER(1, 36, 0)) + return 0; + + err = guc_action_query_single_klv32(guc,GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY , + &value); + if (unlikely(err)) { + xe_gt_sriov_err(gt,drivers/gpu/drm/xe/xe_gt_sriov_vf.c static int · line 687
Quoted 10 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +9
-0+ "Failed to obtain the number of paging instances (%pe)\n", + ERR_PTR(err)); + return err; + } + + gt->sriov.vf.runtime.num_paging_engine_instances = value; + + xe_gt_sriov_dbg(gt, "num_paging_engines %u\n", value); + return err;return 0;
Quoted 15 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +2
-0+} +/**
*xe_gt_sriov_vf_query_config- Query SR-IOV config data over MMIO.
* @gt: the&xe_gtdrivers/gpu/drm/xe/xe_gt_sriov_vf.c +3
-0@@ -694,6 +721,10 @@ int xe_gt_sriov_vf_query_config(struct xe_gt *gt) if (has_gmdid(xe)) vf_cache_gmdid(gt); + err = vf_cache_num_paging_engines(gt); + if (unlikely(err)) + return err; + return 0; }Quoted 6 lines
@@ -731,6 +762,22 @@ u16
xe_gt_sriov_vf_guc_ids(struct xe_gt *gt)returngt->sriov.vf.self_config.num_ctxs;
}
+/**
+ *xe_gt_sriov_vf_paging_engines- Query the number of paging engine instancesnit: we don't do any query here
Quoted 39 lines
+ * @gt: the
&xe_gt
+ *
+ * This function is for VF use only.
+ *
+ * Return: number of GuC paging engine instances configured by the PF.
+ */drivers/gpu/drm/xe/xe_gt_sriov_vf.c +8
-0+u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt) +{ + xe_gt_assert(gt, IS_SRIOV_VF(gt_to_xe(gt))); + xe_gt_assert(gt, gt->sriov.vf.guc_version.major); + + return gt->sriov.vf.runtime.num_paging_engine_instances; +} +static int
relay_action_handshake(struct xe_gt *gt, u32 *major, u32 *minor){
u32 request[VF2PF_HANDSHAKE_REQUEST_MSG_LEN] = {drivers/gpu/drm/xe/xe_gt_sriov_vf.h +1
-0@@ -31,6 +31,7 @@ u32 xe_gt_sriov_vf_gmdid(struct xe_gt *gt); u16 xe_gt_sriov_vf_guc_ids(struct xe_gt *gt); u64 xe_gt_sriov_vf_lmem(struct xe_gt *gt); bool xe_gt_sriov_vf_sched_groups_enabled(struct xe_gt *gt); +u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt); u32 xe_gt_sriov_vf_read32(struct xe_gt *gt, struct xe_reg reg); void xe_gt_sriov_vf_write32(struct xe_gt *gt, struct xe_reg reg, u32 val);drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +2
-0@@ -40,6 +40,10 @@ struct xe_gt_sriov_vf_runtime { /** @regs.value: register value. */ u32 value; } *regs; + /** +* @num_paging_engine_instances: number of configured paging Quoted 3 lines
engines.
+ */
+ u32num_paging_engine_instances;nit: can we move this up near .uses_sched_groups
Quoted 30 lines
};
/**drivers/gpu/drm/xe/xe_guc_klv_helpers.c +0
-0@@ -24,6 +24,8 @@ const char *xe_guc_klv_key_to_string(u16 key) /* GuC Global Config KLVs */case
GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY:
return "group_scheduling_available";
+ caseGUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY:
+ return "num_paging_engine_instances";
/* VGT POLICY keys */
caseGUC_KLV_VGT_POLICY_SCHED_IF_IDLE_KEY:
return "sched_if_idle";drivers/gpu/drm/xe/xe_hw_engine.c +1
-0@@ -650,7 +650,7 @@ static int hw_engine_init(struct xe_gt *gt,struct xe_hw_engine *hwe, return err; } -static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) +static inthw_engine_setup_logical_and_paging_mapping (struct xe_gt *gt) {struct
xe_device*xe =gt_to_xe(gt);
unsigned intnum_copy_engines= 0,num_paging_engines= 0;drivers/gpu/drm/xe/xe_hw_engine.c static void · line 670
Quoted 4 lines
drivers/gpu/drm/xe/xe_hw_engine.c +0
-0@@ -667,6 +667,27 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) if (num_copy_engines && xe->info.has_usm) num_paging_engines = 1; + if (IS_SRIOV_VF(xe)) {maybe:
if (
IS_SRIOV_VF(xe)&&xe->info.platform>=XE_NOVALAKE_S) { or
if (IS_SRIOV_VF(xe)&&xe_uses_paging_class(xe)) {Quoted 16 lines
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/xe/xe_hw_engine.c +5
-0+ u32 vf_num_paging_engines; + + /* +* PF could in theory reserve multiple paging engines, which +* internally the submission/scheduling backend can load balance
+ * from. Not something we currently expect, but we are at theQuoted 8 lines
Quoted 8 lines
+ * mercy of the PF, so we just need try our best to mirror the
+ * paging configuration.
+ */
+vf_num_paging_engines=xe_gt_sriov_vf_paging_engines(gt); + if (vf_num_paging_engines) {
+ /* This should only be non-zero on NVL-S+ */ +xe_gt_assert(gt, xe->info.platform >= XE_NOVALAKE_S);missed this one: I'm not sure we should use assert here:
it's not our fault after all, but it's misbehaving PF, so either we silently live with that or abortQuoted 10 lines
Quoted 6 lines
Quoted 2 lines
+
num_paging_engines=vf_num_paging_engines; + }hmm, so what should we do if
vf_num_paging_enginesis actually 0 on NVL-S+?can it be due to GuC FW being older that 1.36 on NVL-S+? can PF skip programming paging class on NVL-S+?
PF can indeed skip programming the paging class and that is a valid (although currently unexpected) scenario.
Quoted 1 line
maybe 0 on NVL-S+ is a good reason to abort the probe?
The expectation from the GuC side is that if PF has reserved a paging engine then VF must match it, but if PF hasn't reserved a paging engine then VF is free to reserve a BCS to do paging.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
but then this paging engine on VF side will not be a paging CLASS, as the rest of the code may assume or it doesn't matter for the VF?
You're right that if we reserve a BCS (like we do now on current platforms) then it needs to be submitted as a COPY class and not as a PAGING class.
It looks likexe_hwe_to_guc_classandxe_hwe_guc_logical_instancemight be unconditionally returning PAGING class on VF if we're on a setup that supports it even if PF has not enabled it (unless I'm missing something), so that might need to be updated.I was indeed missing something :)
xe_guc_has_paging_engine(), which is used in bothxe_hwe_to_guc_classandxe_hwe_guc_logical_instanceto decide if COPY or PAGING class should be used, on VF returns true only if PF has reserved a paging engine (see patch 10); if no paging engines are reserved the code should automatically fall back to COPY class.
Yeah, should "just work" either way.
Quoted 32 lines
Quoted 31 lines
Quoted 30 lines
Quoted 30 lines
Quoted 30 lines
Quoted 30 lines
+ }
drivers/gpu/drm/xe/xe_hw_engine.c +4
-0+ + if (xe_gt_WARN_ON(gt, num_paging_engines > num_copy_engines)) + return -EINVAL; +
reserved_logical_bcs_start=num_copy_engines-num_paging_engines; /* FIXME: Doing a simple logical mapping that works for most hardware */drivers/gpu/drm/xe/xe_hw_engine.c +6
-0@@ -688,6 +709,8 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) } } } + + return 0; } static void read_media_fuses(struct xe_gt *gt)@@ -906,7 +929,10 @@ int xe_hw_engines_init(struct xe_gt *gt) return err; } - hw_engine_setup_logical_and_paging_mapping(gt); + err = hw_engine_setup_logical_and_paging_mapping(gt); + if (err) + return err; + err = xe_hw_engine_setup_groups(gt); if (err) return err;
Michal Wajdeczko
Reviewed-byRe: [PATCH v6 08/10] drm/xe/vf: wire up NUM_PAGING_ENGINE_INSTANCES
Quoted 232 lines · Matthew Auld
Quoted 231 lines · Daniele Ceraolo Spurio
Quoted 228 lines · Daniele Ceraolo Spurio
Quoted 225 lines · Michal Wajdeczko
Quoted 196 lines · Daniele Ceraolo Spurio
Quoted 194 lines · Michal Wajdeczko
Quoted 82 lines · Matthew Auld
When host PF writes the logical configuration for the GUC PAGING engine, the VF is meant to query it, and mirror it. Size of N means we have paging logical index range [0, N-1], with N fewer normal copy engines.
Agreement is that PF will only spawn PAGING engines on NVL-S+, so this should be zero on older platforms, where we should simply fall back to the old behaviour.
v2 (Sashiko):
- We can't call use theguc_has_paging_engine()this early in the VF code. With that just unconditionally do the query, if the GuC is new enough and take the value as-is. With that drop the -1 special case and just let the upper layers figure out the rest.
v3:
- Also updatexe_guc_klv_key_to_string. (Michal)
- Add kernel-doc forxe_gt_sriov_vf_paging_engines(), plus other tweaks. (Michal)
- Update with final GuC version.
v4:
- Just fallback to manual reserve when vf reported paging engines is zero. Will revisit in the future.Signed-off-by Matthew Auld <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>Cc Piotr Piórkowski <[email protected]>Cc Michal Wajdeczko <[email protected]>---
drivers/gpu/drm/xe/abi/guc_klvs_abi.h | 9 +++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 47 ++++++++++++++++ +++++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.h | 1 +drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h| 4 ++ drivers/gpu/drm/xe/xe_guc_klv_helpers.c | 2 + drivers/gpu/drm/xe/xe_hw_engine.c | 30 ++++++++++++++-6 files changed, 91 insertions(+), 2 deletions(-)drivers/gpu/drm/xe/abi/guc_klvs_abi.h +6
-0@@ -52,6 +52,12 @@* _`GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE` : 0x3001 * Tells the driver whether scheduler groups are enabled or not. * Requires GuC ABI 1.26+ +* +* _`GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES` : 0x3003 +* Tells the driver the paging engine configuration. +* Paging engine logical instances are guaranteed to be dense starting at +* index 0. +* Requires GuC ABI 1.36+ */ #define GUC_KLV_GLOBAL_CFG_GMD_ID_KEY 0x3000u@@ -60,6 +66,9 @@ #define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY 0x3001u #define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_LEN 1u+#define
GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY0x3003udrivers/gpu/drm/xe/abi/guc_klvs_abi.h +2
-0+#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_LEN 1u +/**
* DOC: GuC Self Config KLVs
*drivers/gpu/drm/xe/xe_gt_sriov_vf.c +14
-0@@ -658,6 +658,33 @@ static int vf_cache_sched_groups_status(struct xe_gt *gt) return 0; } +static int vf_cache_num_paging_engines(struct xe_gt *gt) +{ + struct xe_guc *guc = >->uc.guc; + struct xe_uc_fw_version guc_version; + u32 value = 0; + int err; + + xe_gt_sriov_vf_guc_versions(gt, NULL, &guc_version); + + if (MAKE_GUC_VER_STRUCT(guc_version) < MAKE_GUC_VER(1, 36, 0)) + return 0; + + err = guc_action_query_single_klv32(guc, GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY, + &value); + if (unlikely(err)) {drivers/gpu/drm/xe/xe_gt_sriov_vf.c static int vf_cache_sched_groups_status(struct xe_gt *gt) · line 684
Quoted 10 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +10
-0+ xe_gt_sriov_err(gt, + "Failed to obtain the number of paging instances (%pe)\n", + ERR_PTR(err)); + return err; + } + + gt->sriov.vf.runtime.num_paging_engine_instances = value; + + xe_gt_sriov_dbg(gt, "num_paging_engines %u\n", value); + return err;return 0;
Quoted 15 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +5
-0+} + /*** xe_gt_sriov_vf_query_config - Query SR-IOV config data over MMIO. * @gt: the &xe_gt @@ -694,6 +721,10 @@ int xe_gt_sriov_vf_query_config(struct xe_gt *gt) if (has_gmdid(xe)) vf_cache_gmdid(gt); + err = vf_cache_num_paging_engines(gt); + if (unlikely(err)) + return err; + return 0; } @@ -731,6 +762,22 @@ u16 xe_gt_sriov_vf_guc_ids(struct xe_gt *gt)Quoted 4 lines
return
gt->sriov.vf.self_config.num_ctxs;
}
+/**
+ *xe_gt_sriov_vf_paging_engines- Query the number of paging engine instancesnit: we don't do any query here
Quoted 33 lines
+ * @gt: the
&xe_gt
+ *
+ * This function is for VF use only.
+ *
+ * Return: number of GuC paging engine instances configured by the PF.
+ */drivers/gpu/drm/xe/xe_gt_sriov_vf.c +8
-0+u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt) +{ + xe_gt_assert(gt, IS_SRIOV_VF(gt_to_xe(gt))); + xe_gt_assert(gt, gt->sriov.vf.guc_version.major); + + return gt->sriov.vf.runtime.num_paging_engine_instances; +} +static int
relay_action_handshake(struct xe_gt *gt, u32 *major, u32 *minor){
u32 request[VF2PF_HANDSHAKE_REQUEST_MSG_LEN] = {drivers/gpu/drm/xe/xe_gt_sriov_vf.h +1
-0@@ -31,6 +31,7 @@ u32 xe_gt_sriov_vf_gmdid(struct xe_gt *gt); u16 xe_gt_sriov_vf_guc_ids(struct xe_gt *gt); u64 xe_gt_sriov_vf_lmem(struct xe_gt *gt); bool xe_gt_sriov_vf_sched_groups_enabled(struct xe_gt *gt); +u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt); u32 xe_gt_sriov_vf_read32(struct xe_gt *gt, struct xe_reg reg); void xe_gt_sriov_vf_write32(struct xe_gt *gt, struct xe_reg reg, u32 val);drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +0
-0drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h struct xe_gt_sriov_vf_runtime { · line 46
Quoted 7 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +4
-0@@ -40,6 +40,10 @@ struct xe_gt_sriov_vf_runtime { /** @regs.value: register value. */ u32 value; } *regs; + /** + * @num_paging_engine_instances: number of configured paging engines. + */ + u32 num_paging_engine_instances;nit: can we move this up near .uses_sched_groups
Quoted 28 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +0
-0}; /**drivers/gpu/drm/xe/xe_guc_klv_helpers.c +0
-0@@ -24,6 +24,8 @@ const char *xe_guc_klv_key_to_string(u16 key) /* GuC Global Config KLVs */case
GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY:
return "group_scheduling_available";
+ caseGUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY:
+ return "num_paging_engine_instances";
/* VGT POLICY keys */
caseGUC_KLV_VGT_POLICY_SCHED_IF_IDLE_KEY:
return "sched_if_idle";drivers/gpu/drm/xe/xe_hw_engine.c +1
-0@@ -650,7 +650,7 @@ static int hw_engine_init(struct xe_gt *gt, struct xe_hw_engine *hwe, return err; } -static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) +static int hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) { struct xe_device *xe = gt_to_xe(gt); unsigned int num_copy_engines = 0, num_paging_engines = 0;drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 669
Quoted 3 lines
drivers/gpu/drm/xe/xe_hw_engine.c +0
-0@@ -667,6 +667,27 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) if (num_copy_engines && xe->info.has_usm) num_paging_engines = 1; + if (IS_SRIOV_VF(xe)) {maybe:
if (
IS_SRIOV_VF(xe)&&xe->info.platform>=XE_NOVALAKE_S) { or
if (IS_SRIOV_VF(xe)&&xe_uses_paging_class(xe)) {Quoted 13 lines
Quoted 5 lines
Quoted 5 lines
drivers/gpu/drm/xe/xe_hw_engine.c +5
-0+ u32 vf_num_paging_engines; + + /* +* PF could in theory reserve multiple paging engines, which +* internally the submission/scheduling backend can load balance Quoted 8 lines
drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 682
Quoted 8 lines
drivers/gpu/drm/xe/xe_hw_engine.c +8
-0+* from. Not something we currently expect, but we are at the +* mercy of the PF, so we just need try our best to mirror the +* paging configuration. +*/ + vf_num_paging_engines = xe_gt_sriov_vf_paging_engines(gt); + if (vf_num_paging_engines) { + /* This should only be non-zero on NVL-S+ */ + xe_gt_assert(gt, xe->info.platform >= XE_NOVALAKE_S);missed this one: I'm not sure we should use assert here:
it's not our fault after all, but it's misbehaving PF, so either we silently live with that or abortQuoted 10 lines
Quoted 6 lines
drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 684
Quoted 2 lines
drivers/gpu/drm/xe/xe_hw_engine.c +2
-0+ num_paging_engines = vf_num_paging_engines; + }hmm, so what should we do if
vf_num_paging_enginesis actually 0 on NVL-S+?can it be due to GuC FW being older that 1.36 on NVL-S+? can PF skip programming paging class on NVL-S+?
PF can indeed skip programming the paging class and that is a valid (although currently unexpected) scenario.
Quoted 1 line
maybe 0 on NVL-S+ is a good reason to abort the probe?
The expectation from the GuC side is that if PF has reserved a paging engine then VF must match it, but if PF hasn't reserved a paging engine then VF is free to reserve a BCS to do paging.
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
but then this paging engine on VF side will not be a paging CLASS, as the rest of the code may assume or it doesn't matter for the VF?
You're right that if we reserve a BCS (like we do now on current platforms) then it needs to be submitted as a COPY class and not as a PAGING class.
It looks likexe_hwe_to_guc_classandxe_hwe_guc_logical_instancemight be unconditionally returning PAGING class on VF if we're on a setup that supports it even if PF has not enabled it (unless I'm missing something), so that might need to be updated.I was indeed missing something :)
xe_guc_has_paging_engine(), which is used in bothxe_hwe_to_guc_classandxe_hwe_guc_logical_instanceto decide if COPY or PAGING class should be used, on VF returns true only if PF has reserved a paging engine (see patch 10); if no paging engines are reserved the code should automatically fall back to COPY class.
hmm, so maybe we should move that VF chunk from patch 10 to this patch here?
Quoted 2 lines
Yeah, should "just work" either way.
ok, so either way, with at least assert fixed,
Quoted 33 lines
Quoted 32 lines
Quoted 31 lines
Quoted 30 lines
Quoted 30 lines
Quoted 30 lines
Quoted 30 lines
drivers/gpu/drm/xe/xe_hw_engine.c +11
-0+ } + + if (xe_gt_WARN_ON(gt, num_paging_engines > num_copy_engines)) + return -EINVAL; + reserved_logical_bcs_start = num_copy_engines - num_paging_engines; /* FIXME: Doing a simple logical mapping that works for most hardware */@@ -688,6 +709,8 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) } } } + + return 0; } static void read_media_fuses(struct xe_gt *gt)@@ -906,7 +929,10 @@ int xe_hw_engines_init(struct xe_gt *gt) return err; } - hw_engine_setup_logical_and_paging_mapping(gt); + err = hw_engine_setup_logical_and_paging_mapping(gt); + if (err) + return err; + err = xe_hw_engine_setup_groups(gt); if (err) return err;
Re: [PATCH v6 08/10] drm/xe/vf: wire up NUM_PAGING_ENGINE_INSTANCES
Quoted 244 lines · Michal Wajdeczko
Quoted 232 lines · Matthew Auld
Quoted 231 lines · Daniele Ceraolo Spurio
Quoted 228 lines · Daniele Ceraolo Spurio
Quoted 225 lines · Michal Wajdeczko
Quoted 196 lines · Daniele Ceraolo Spurio
Quoted 194 lines · Michal Wajdeczko
Quoted 82 lines · Matthew Auld
When host PF writes the logical configuration for the GUC PAGING engine, the VF is meant to query it, and mirror it. Size of N means we have paging logical index range [0, N-1], with N fewer normal copy engines.
Agreement is that PF will only spawn PAGING engines on NVL-S+, so this should be zero on older platforms, where we should simply fall back to the old behaviour.
v2 (Sashiko):
- We can't call use theguc_has_paging_engine()this early in the VF code. With that just unconditionally do the query, if the GuC is new enough and take the value as-is. With that drop the -1 special case and just let the upper layers figure out the rest.
v3:
- Also updatexe_guc_klv_key_to_string. (Michal)
- Add kernel-doc forxe_gt_sriov_vf_paging_engines(), plus other tweaks. (Michal)
- Update with final GuC version.
v4:
- Just fallback to manual reserve when vf reported paging engines is zero. Will revisit in the future.Signed-off-by Matthew Auld <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>Cc Piotr Piórkowski <[email protected]>Cc Michal Wajdeczko <[email protected]>--- drivers/gpu/drm/xe/abi/guc_klvs_abi.h | 9 +++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 47 ++++++++++++++++ +++++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.h | 1 + drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h | 4 ++ drivers/gpu/drm/xe/xe_guc_klv_helpers.c | 2 + drivers/gpu/drm/xe/xe_hw_engine.c | 30 ++++++++++++++- 6 files changed, 91 insertions(+), 2 deletions(-)drivers/gpu/drm/xe/abi/guc_klvs_abi.h +8
-0@@ -52,6 +52,12 @@* _`GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE` : 0x3001 * Tells the driver whether scheduler groups are enabled or not. * Requires GuC ABI 1.26+ +* +* _`GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES` : 0x3003 +* Tells the driver the paging engine configuration. +* Paging engine logical instances are guaranteed to be dense starting at +* index 0. +* Requires GuC ABI 1.36+ */ #define GUC_KLV_GLOBAL_CFG_GMD_ID_KEY 0x3000u@@ -60,6 +66,9 @@ #define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY 0x3001u #define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_LEN 1u +#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY 0x3003u +#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_LEN 1u + /*** DOC: GuC Self Config KLVs * drivers/gpu/drm/xe/xe_gt_sriov_vf.c +14
-0@@ -658,6 +658,33 @@ static int vf_cache_sched_groups_status(struct xe_gt *gt) return 0; } +static int vf_cache_num_paging_engines(struct xe_gt *gt) +{ + struct xe_guc *guc = >->uc.guc; + struct xe_uc_fw_version guc_version; + u32 value = 0; + int err; + + xe_gt_sriov_vf_guc_versions(gt, NULL, &guc_version); + + if (MAKE_GUC_VER_STRUCT(guc_version) < MAKE_GUC_VER(1, 36, 0)) + return 0; + + err = guc_action_query_single_klv32(guc, GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY, + &value); + if (unlikely(err)) {drivers/gpu/drm/xe/xe_gt_sriov_vf.c static int vf_cache_sched_groups_status(struct xe_gt *gt) · line 684
Quoted 10 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +10
-0+ xe_gt_sriov_err(gt, + "Failed to obtain the number of paging instances (%pe)\n", + ERR_PTR(err)); + return err; + } + + gt->sriov.vf.runtime.num_paging_engine_instances = value; + + xe_gt_sriov_dbg(gt, "num_paging_engines %u\n", value); + return err;return 0;
Quoted 9 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +2
-0+} + /*** xe_gt_sriov_vf_query_config - Query SR-IOV config data over MMIO. * @gt: the &xe_gt @@ -694,6 +721,10 @@ int xe_gt_sriov_vf_query_config(struct xe_gt *gt) if (has_gmdid(xe)) vf_cache_gmdid(gt); + err = vf_cache_num_paging_engines(gt);drivers/gpu/drm/xe/xe_gt_sriov_vf.c int xe_gt_sriov_vf_query_config(struct xe_gt *gt)
Quoted 10 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +4
-0+ if (unlikely(err)) + return err; + return 0; } @@ -731,6 +762,22 @@ u16 xe_gt_sriov_vf_guc_ids(struct xe_gt *gt) return gt->sriov.vf.self_config.num_ctxs; } +/** +* xe_gt_sriov_vf_paging_engines - Query the number of paging engine instances nit: we don't do any query here
Quoted 33 lines
+ * @gt: the
&xe_gt
+ *
+ * This function is for VF use only.
+ *
+ * Return: number of GuC paging engine instances configured by the PF.
+ */drivers/gpu/drm/xe/xe_gt_sriov_vf.c +8
-0+u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt) +{ + xe_gt_assert(gt, IS_SRIOV_VF(gt_to_xe(gt))); + xe_gt_assert(gt, gt->sriov.vf.guc_version.major); + + return gt->sriov.vf.runtime.num_paging_engine_instances; +} + static int relay_action_handshake(struct xe_gt *gt, u32 *major, u32 *minor) { u32 request[VF2PF_HANDSHAKE_REQUEST_MSG_LEN] = {drivers/gpu/drm/xe/xe_gt_sriov_vf.h +1
-0@@ -31,6 +31,7 @@ u32 xe_gt_sriov_vf_gmdid(struct xe_gt *gt); u16 xe_gt_sriov_vf_guc_ids(struct xe_gt *gt); u64 xe_gt_sriov_vf_lmem(struct xe_gt *gt); bool xe_gt_sriov_vf_sched_groups_enabled(struct xe_gt *gt); +u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt); u32 xe_gt_sriov_vf_read32(struct xe_gt *gt, struct xe_reg reg); void xe_gt_sriov_vf_write32(struct xe_gt *gt, struct xe_reg reg, u32 val);drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +0
-0drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h struct xe_gt_sriov_vf_runtime { · line 46
Quoted 7 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +4
-0@@ -40,6 +40,10 @@ struct xe_gt_sriov_vf_runtime { /** @regs.value: register value. */ u32 value; } *regs; + /** + * @num_paging_engine_instances: number of configured paging engines. + */ + u32 num_paging_engine_instances;nit: can we move this up near .uses_sched_groups
Quoted 28 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +0
-0}; /**drivers/gpu/drm/xe/xe_guc_klv_helpers.c +2
-0@@ -24,6 +24,8 @@ const char *xe_guc_klv_key_to_string(u16 key) /* GuC Global Config KLVs */ case GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY: return "group_scheduling_available"; + case GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY: + return "num_paging_engine_instances"; /* VGT POLICY keys */ case GUC_KLV_VGT_POLICY_SCHED_IF_IDLE_KEY: return "sched_if_idle";drivers/gpu/drm/xe/xe_hw_engine.c +1
-0@@ -650,7 +650,7 @@ static int hw_engine_init(struct xe_gt *gt, struct xe_hw_engine *hwe, return err; } -static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) +static int hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) { struct xe_device *xe = gt_to_xe(gt); unsigned int num_copy_engines = 0, num_paging_engines = 0;drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 669
Quoted 3 lines
drivers/gpu/drm/xe/xe_hw_engine.c +0
-0@@ -667,6 +667,27 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) if (num_copy_engines && xe->info.has_usm) num_paging_engines = 1; + if (IS_SRIOV_VF(xe)) {maybe:
if (
IS_SRIOV_VF(xe)&&xe->info.platform>=XE_NOVALAKE_S) {
or
if (IS_SRIOV_VF(xe)&&xe_uses_paging_class(xe)) {Quoted 13 lines
Quoted 5 lines
Quoted 5 lines
drivers/gpu/drm/xe/xe_hw_engine.c +5
-0+ u32 vf_num_paging_engines; + + /* +* PF could in theory reserve multiple paging engines, which +* internally the submission/scheduling backend can load balance Quoted 8 lines
drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 682
Quoted 8 lines
drivers/gpu/drm/xe/xe_hw_engine.c +8
-0+* from. Not something we currently expect, but we are at the +* mercy of the PF, so we just need try our best to mirror the +* paging configuration. +*/ + vf_num_paging_engines = xe_gt_sriov_vf_paging_engines(gt); + if (vf_num_paging_engines) { + /* This should only be non-zero on NVL-S+ */ + xe_gt_assert(gt, xe->info.platform >= XE_NOVALAKE_S);missed this one: I'm not sure we should use assert here:
it's not our fault after all, but it's misbehaving PF, so either we silently live with that or abortQuoted 10 lines
Quoted 6 lines
drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 684
Quoted 2 lines
drivers/gpu/drm/xe/xe_hw_engine.c +2
-0+ num_paging_engines = vf_num_paging_engines; + }hmm, so what should we do if
vf_num_paging_enginesis actually 0 on NVL-S+?can it be due to GuC FW being older that 1.36 on NVL-S+? can PF skip programming paging class on NVL-S+?
PF can indeed skip programming the paging class and that is a valid (although currently unexpected) scenario.
Quoted 1 line
maybe 0 on NVL-S+ is a good reason to abort the probe?
The expectation from the GuC side is that if PF has reserved a paging engine then VF must match it, but if PF hasn't reserved a paging engine then VF is free to reserve a BCS to do paging.
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
but then this paging engine on VF side will not be a paging CLASS, as the rest of the code may assume or it doesn't matter for the VF?
You're right that if we reserve a BCS (like we do now on current platforms) then it needs to be submitted as a COPY class and not as a PAGING class.
It looks likexe_hwe_to_guc_classandxe_hwe_guc_logical_instancemight be unconditionally returning PAGING class on VF if we're on a setup that supports it even if PF has not enabled it (unless I'm missing something), so that might need to be updated.I was indeed missing something :)
xe_guc_has_paging_engine(), which is used in bothxe_hwe_to_guc_classandxe_hwe_guc_logical_instanceto decide if COPY or PAGING class should be used, on VF returns true only if PF has reserved a paging engine (see patch 10); if no paging engines are reserved the code should automatically fall back to COPY class.
Quoted 6 lines
hmm, so maybe we should move that VF chunk from patch 10 to this patch here?
Quoted 2 lines
Yeah, should "just work" either way.
ok, so either way, with at least assert fixed,
For the assert can we go with:
if (xe_gt_WARN_ON(gt, xe->info.platform < XE_NOVALAKE_S))
return -EINVAL;
?
I do think we should treat it as some kind of error. I think from xe pov, we will be missing coverage for this combo of GUC_PAGING + pre-NVL + vf, so can't say for sure if it will work or continue to work, or mabye just blow up in a more obscure way later. If this does actaully trigger in production we can revisit?
Quoted 2 lines
Reviewed-by Michal Wajdeczko <[email protected]>
Thanks.
Quoted 35 lines
Quoted 34 lines
Quoted 33 lines
Quoted 32 lines
Quoted 31 lines
Quoted 31 lines
Quoted 31 lines
Quoted 31 lines
drivers/gpu/drm/xe/xe_hw_engine.c +11
-0+ } + + if (xe_gt_WARN_ON(gt, num_paging_engines > num_copy_engines)) + return -EINVAL; + reserved_logical_bcs_start = num_copy_engines - num_paging_engines; /* FIXME: Doing a simple logical mapping that works for most hardware */@@ -688,6 +709,8 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) } } } + + return 0; } static void read_media_fuses(struct xe_gt *gt)@@ -906,7 +929,10 @@ int xe_hw_engines_init(struct xe_gt *gt) return err; } - hw_engine_setup_logical_and_paging_mapping(gt); + err = hw_engine_setup_logical_and_paging_mapping(gt); + if (err) + return err; + err = xe_hw_engine_setup_groups(gt); if (err) return err;
Re: [PATCH v6 08/10] drm/xe/vf: wire up NUM_PAGING_ENGINE_INSTANCES
Quoted 248 lines · Matthew Auld
Quoted 247 lines · Michal Wajdeczko
Quoted 232 lines · Matthew Auld
Quoted 231 lines · Daniele Ceraolo Spurio
Quoted 228 lines · Daniele Ceraolo Spurio
Quoted 225 lines · Michal Wajdeczko
Quoted 196 lines · Daniele Ceraolo Spurio
Quoted 194 lines · Michal Wajdeczko
Quoted 82 lines · Matthew Auld
When host PF writes the logical configuration for the GUC PAGING engine, the VF is meant to query it, and mirror it. Size of N means we have paging logical index range [0, N-1], with N fewer normal copy engines.
Agreement is that PF will only spawn PAGING engines on NVL-S+, so this should be zero on older platforms, where we should simply fall back to the old behaviour.
v2 (Sashiko):
- We can't call use theguc_has_paging_engine()this early in the VF code. With that just unconditionally do the query, if the GuC is new enough and take the value as-is. With that drop the -1 special case and just let the upper layers figure out the rest.
v3:
- Also updatexe_guc_klv_key_to_string. (Michal)
- Add kernel-doc forxe_gt_sriov_vf_paging_engines(), plus other tweaks. (Michal)
- Update with final GuC version.
v4:
- Just fallback to manual reserve when vf reported paging engines is zero. Will revisit in the future.Signed-off-by Matthew Auld <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>Cc Piotr Piórkowski <[email protected]>Cc Michal Wajdeczko <[email protected]>---
drivers/gpu/drm/xe/abi/guc_klvs_abi.h | 9 +++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 47 ++++++++++++++++ +++++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.h | 1 +drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h| 4 ++ drivers/gpu/drm/xe/xe_guc_klv_helpers.c | 2 + drivers/gpu/drm/xe/xe_hw_engine.c | 30 ++++++++++++++-6 files changed, 91 insertions(+), 2 deletions(-)drivers/gpu/drm/xe/abi/guc_klvs_abi.h +6
-0@@ -52,6 +52,12 @@* _`GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE` : 0x3001 * Tells the driver whether scheduler groups are enabled or not. * Requires GuC ABI 1.26+ +* +* _`GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES` : 0x3003 +* Tells the driver the paging engine configuration. +* Paging engine logical instances are guaranteed to be dense starting at +* index 0. +* Requires GuC ABI 1.36+ */ #define GUC_KLV_GLOBAL_CFG_GMD_ID_KEY 0x3000u@@ -60,6 +66,9 @@ #define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY 0x3001u #define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_LEN 1u+#define
GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY0x3003udrivers/gpu/drm/xe/abi/guc_klvs_abi.h +2
-0+#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_LEN 1u +/**
* DOC: GuC Self Config KLVs
*drivers/gpu/drm/xe/xe_gt_sriov_vf.c +14
-0@@ -658,6 +658,33 @@ static int vf_cache_sched_groups_status(struct xe_gt *gt) return 0; } +static int vf_cache_num_paging_engines(struct xe_gt *gt) +{ + struct xe_guc *guc = >->uc.guc; + struct xe_uc_fw_version guc_version; + u32 value = 0; + int err; + + xe_gt_sriov_vf_guc_versions(gt, NULL, &guc_version); + + if (MAKE_GUC_VER_STRUCT(guc_version) < MAKE_GUC_VER(1, 36, 0)) + return 0; + + err = guc_action_query_single_klv32(guc, GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY, + &value); + if (unlikely(err)) {drivers/gpu/drm/xe/xe_gt_sriov_vf.c static int vf_cache_sched_groups_status(struct xe_gt *gt) · line 684
Quoted 10 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +10
-0+ xe_gt_sriov_err(gt, + "Failed to obtain the number of paging instances (%pe)\n", + ERR_PTR(err)); + return err; + } + + gt->sriov.vf.runtime.num_paging_engine_instances = value; + + xe_gt_sriov_dbg(gt, "num_paging_engines %u\n", value); + return err;return 0;
Quoted 15 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +5
-0+} + /*** xe_gt_sriov_vf_query_config - Query SR-IOV config data over MMIO. * @gt: the &xe_gt @@ -694,6 +721,10 @@ int xe_gt_sriov_vf_query_config(struct xe_gt *gt) if (has_gmdid(xe)) vf_cache_gmdid(gt); + err = vf_cache_num_paging_engines(gt); + if (unlikely(err)) + return err; + return 0; } @@ -731,6 +762,22 @@ u16 xe_gt_sriov_vf_guc_ids(struct xe_gt *gt)Quoted 4 lines
return
gt->sriov.vf.self_config.num_ctxs;
}
+/**
+ *xe_gt_sriov_vf_paging_engines- Query the number of paging engine instancesnit: we don't do any query here
Quoted 33 lines
+ * @gt: the
&xe_gt
+ *
+ * This function is for VF use only.
+ *
+ * Return: number of GuC paging engine instances configured by the PF.
+ */drivers/gpu/drm/xe/xe_gt_sriov_vf.c +8
-0+u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt) +{ + xe_gt_assert(gt, IS_SRIOV_VF(gt_to_xe(gt))); + xe_gt_assert(gt, gt->sriov.vf.guc_version.major); + + return gt->sriov.vf.runtime.num_paging_engine_instances; +} +static int
relay_action_handshake(struct xe_gt *gt, u32 *major, u32 *minor){
u32 request[VF2PF_HANDSHAKE_REQUEST_MSG_LEN] = {drivers/gpu/drm/xe/xe_gt_sriov_vf.h +1
-0@@ -31,6 +31,7 @@ u32 xe_gt_sriov_vf_gmdid(struct xe_gt *gt); u16 xe_gt_sriov_vf_guc_ids(struct xe_gt *gt); u64 xe_gt_sriov_vf_lmem(struct xe_gt *gt); bool xe_gt_sriov_vf_sched_groups_enabled(struct xe_gt *gt); +u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt); u32 xe_gt_sriov_vf_read32(struct xe_gt *gt, struct xe_reg reg); void xe_gt_sriov_vf_write32(struct xe_gt *gt, struct xe_reg reg, u32 val);drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +0
-0drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h struct xe_gt_sriov_vf_runtime { · line 46
Quoted 7 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +4
-0@@ -40,6 +40,10 @@ struct xe_gt_sriov_vf_runtime { /** @regs.value: register value. */ u32 value; } *regs; + /** + * @num_paging_engine_instances: number of configured paging engines. + */ + u32 num_paging_engine_instances;nit: can we move this up near .uses_sched_groups
Quoted 28 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +0
-0}; /**drivers/gpu/drm/xe/xe_guc_klv_helpers.c +0
-0@@ -24,6 +24,8 @@ const char *xe_guc_klv_key_to_string(u16 key) /* GuC Global Config KLVs */case
GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY:
return "group_scheduling_available";
+ caseGUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY:
+ return "num_paging_engine_instances";
/* VGT POLICY keys */
caseGUC_KLV_VGT_POLICY_SCHED_IF_IDLE_KEY:
return "sched_if_idle";drivers/gpu/drm/xe/xe_hw_engine.c +1
-0@@ -650,7 +650,7 @@ static int hw_engine_init(struct xe_gt *gt, struct xe_hw_engine *hwe, return err; } -static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) +static int hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) { struct xe_device *xe = gt_to_xe(gt); unsigned int num_copy_engines = 0, num_paging_engines = 0;drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 669
Quoted 3 lines
drivers/gpu/drm/xe/xe_hw_engine.c +0
-0@@ -667,6 +667,27 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) if (num_copy_engines && xe->info.has_usm) num_paging_engines = 1; + if (IS_SRIOV_VF(xe)) {maybe:
if (
IS_SRIOV_VF(xe)&&xe->info.platform>=XE_NOVALAKE_S) { or
if (IS_SRIOV_VF(xe)&&xe_uses_paging_class(xe)) {Quoted 13 lines
Quoted 5 lines
Quoted 5 lines
drivers/gpu/drm/xe/xe_hw_engine.c +5
-0+ u32 vf_num_paging_engines; + + /* +* PF could in theory reserve multiple paging engines, which +* internally the submission/scheduling backend can load balance Quoted 8 lines
drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 682
Quoted 8 lines
drivers/gpu/drm/xe/xe_hw_engine.c +8
-0+* from. Not something we currently expect, but we are at the +* mercy of the PF, so we just need try our best to mirror the +* paging configuration. +*/ + vf_num_paging_engines = xe_gt_sriov_vf_paging_engines(gt); + if (vf_num_paging_engines) { + /* This should only be non-zero on NVL-S+ */ + xe_gt_assert(gt, xe->info.platform >= XE_NOVALAKE_S);missed this one: I'm not sure we should use assert here:
it's not our fault after all, but it's misbehaving PF, so either we silently live with that or abortQuoted 10 lines
Quoted 6 lines
drivers/gpu/drm/xe/xe_hw_engine.c static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) · line 684
Quoted 2 lines
drivers/gpu/drm/xe/xe_hw_engine.c +2
-0+ num_paging_engines = vf_num_paging_engines; + }hmm, so what should we do if
vf_num_paging_enginesis actually 0 on NVL-S+?can it be due to GuC FW being older that 1.36 on NVL-S+? can PF skip programming paging class on NVL-S+?
PF can indeed skip programming the paging class and that is a valid (although currently unexpected) scenario.
Quoted 1 line
maybe 0 on NVL-S+ is a good reason to abort the probe?
The expectation from the GuC side is that if PF has reserved a paging engine then VF must match it, but if PF hasn't reserved a paging engine then VF is free to reserve a BCS to do paging.
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
but then this paging engine on VF side will not be a paging CLASS, as the rest of the code may assume or it doesn't matter for the VF?
You're right that if we reserve a BCS (like we do now on current platforms) then it needs to be submitted as a COPY class and not as a PAGING class.
It looks likexe_hwe_to_guc_classandxe_hwe_guc_logical_instancemight be unconditionally returning PAGING class on VF if we're on a setup that supports it even if PF has not enabled it (unless I'm missing something), so that might need to be updated.I was indeed missing something :)
xe_guc_has_paging_engine(), which is used in bothxe_hwe_to_guc_classandxe_hwe_guc_logical_instanceto decide if COPY or PAGING class should be used, on VF returns true only if PF has reserved a paging engine (see patch 10); if no paging engines are reserved the code should automatically fall back to COPY class.hmm, so maybe we should move that VF chunk from patch 10 to this patch here?
Quoted 1 line
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Yeah, should "just work" either way.
ok, so either way, with at least assert fixed,
For the assert can we go with:
if (
xe_gt_WARN_ON(gt, xe->info.platform < XE_NOVALAKE_S)) return-EINVAL;
that should work but will look like we're complaining about the platform ;)
maybe if we start with the VF case this could be:
int hw_engine_setup_logical_and_paging_mapping(gt)
{
num_copy_engines = ...
if (IS_SRIOV_VF(xe)) {
num_paging_engines = xe_gt_sriov_vf_paging_engines(gt);
if (xe_gt_WARN_ON(gt, num_paging_engines && xe->info.platform < XE_NOVALAKE_S))
return -EPROTO;
if (xe_gt_WARN_ON(gt, num_paging_engines > num_copy_engines))
return -EINVAL;
if (num_paging_engines)
goto done;
}
...
done:
xe_gt_assert(gt, num_paging_engines < num_copy_engines);
reserved_logical_bcs_start = num_copy_engines - num_paging_engines;
return 0;
}Quoted 46 lines
?
I do think we should treat it as some kind of error. I think from xe pov, we will be missing coverage for this combo of
GUC_PAGING+ pre-NVL + vf, so can't say for sure if it will work or continue to work, or mabye just blow up in a more obscure way later. If this does actaully trigger in production we can revisit?Quoted 2 lines
Reviewed-by Michal Wajdeczko <[email protected]>Thanks.
Quoted 35 lines
Quoted 34 lines
Quoted 33 lines
Quoted 32 lines
Quoted 31 lines
Quoted 31 lines
Quoted 31 lines
Quoted 31 lines
drivers/gpu/drm/xe/xe_hw_engine.c +11
-0+ } + + if (xe_gt_WARN_ON(gt, num_paging_engines > num_copy_engines)) + return -EINVAL; + reserved_logical_bcs_start = num_copy_engines - num_paging_engines; /* FIXME: Doing a simple logical mapping that works for most hardware */@@ -688,6 +709,8 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) } } } + + return 0; } static void read_media_fuses(struct xe_gt *gt)@@ -906,7 +929,10 @@ int xe_hw_engines_init(struct xe_gt *gt) return err; } - hw_engine_setup_logical_and_paging_mapping(gt); + err = hw_engine_setup_logical_and_paging_mapping(gt); + if (err) + return err; + err = xe_hw_engine_setup_groups(gt); if (err) return err;
Re: [PATCH v6 08/10] drm/xe/vf: wire up NUM_PAGING_ENGINE_INSTANCES
In reply to Matthew AuldQuoted 22 lines · Matthew Auld
When host PF writes the logical configuration for the GUC PAGING engine, the VF is meant to query it, and mirror it. Size of N means we have paging logical index range [0, N-1], with N fewer normal copy engines.
Agreement is that PF will only spawn PAGING engines on NVL-S+, so this should be zero on older platforms, where we should simply fall back to the old behaviour.
v2 (Sashiko):
- We can't call use theguc_has_paging_engine()this early in the VF code. With that just unconditionally do the query, if the GuC is new enough and take the value as-is. With that drop the -1 special case and just let the upper layers figure out the rest.
v3:
- Also updatexe_guc_klv_key_to_string. (Michal)
- Add kernel-doc forxe_gt_sriov_vf_paging_engines(), plus other tweaks. (Michal)
- Update with final GuC version.
v4:
- Just fallback to manual reserve when vf reported paging engines is zero. Will revisit in the future.
Quoted 4 lines
Signed-off-by Matthew Auld <[email protected]>Cc Daniele Ceraolo Spurio <[email protected]>Cc Piotr Piórkowski <[email protected]>Cc Michal Wajdeczko <[email protected]>
Michal/Piotr, does this look sane from SRIOV side? Any further comments? Otherwise any chance of an ack/r-b for this one?
Quoted 210 lines
--- drivers/gpu/drm/xe/abi/guc_klvs_abi.h | 9 +++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 47 +++++++++++++++++++++++ drivers/gpu/drm/xe/xe_gt_sriov_vf.h | 1 + drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h | 4 ++ drivers/gpu/drm/xe/xe_guc_klv_helpers.c | 2 + drivers/gpu/drm/xe/xe_hw_engine.c | 30 ++++++++++++++- 6 files changed, 91 insertions(+), 2 deletions(-)drivers/gpu/drm/xe/abi/guc_klvs_abi.h +9
-0@@ -52,6 +52,12 @@* _`GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE` : 0x3001 * Tells the driver whether scheduler groups are enabled or not. * Requires GuC ABI 1.26+ +* +* _`GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES` : 0x3003 +* Tells the driver the paging engine configuration. +* Paging engine logical instances are guaranteed to be dense starting at +* index 0. +* Requires GuC ABI 1.36+ */ #define GUC_KLV_GLOBAL_CFG_GMD_ID_KEY 0x3000u@@ -60,6 +66,9 @@#define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY 0x3001u#define GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_LEN 1u +#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY 0x3003u +#define GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_LEN 1u +/** * DOC: GuC Self Config KLVs * drivers/gpu/drm/xe/xe_gt_sriov_vf.c +47
-0@@ -658,6 +658,33 @@ static int vf_cache_sched_groups_status(struct xe_gt *gt)return 0 ; } +static int vf_cache_num_paging_engines (struct xe_gt *gt) +{ +struct xe_guc *guc = >->uc.guc; +struct xe_uc_fw_version guc_version; +u32 value =0 ; +int err; + +xe_gt_sriov_vf_guc_versions (gt,NULL , &guc_version); + +if (MAKE_GUC_VER_STRUCT (guc_version) <MAKE_GUC_VER (1 ,36 ,0 )) +return 0 ; + + err =guc_action_query_single_klv32 (guc,GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY , + &value); +if (unlikely (err)) { +xe_gt_sriov_err (gt, +"Failed to obtain the number of paging instances (%pe)\n" , +ERR_PTR (err)); +return err; + } + + gt->sriov.vf.runtime.num_paging_engine_instances = value; + +xe_gt_sriov_dbg (gt,"num_paging_engines %u\n" , value); +return err; +} +/** * xe_gt_sriov_vf_query_config - Query SR-IOV config data over MMIO. * @gt: the &xe_gt @@ -694,6 +721,10 @@ int xe_gt_sriov_vf_query_config(struct xe_gt *gt)if (has_gmdid (xe))vf_cache_gmdid (gt); + err =vf_cache_num_paging_engines (gt); +if (unlikely (err)) +return err; +return 0 ; }@@ -731,6 +762,22 @@ u16 xe_gt_sriov_vf_guc_ids(struct xe_gt *gt)return gt->sriov.vf.self_config.num_ctxs; } +/** +* xe_gt_sriov_vf_paging_engines - Query the number of paging engine instances +* @gt: the &xe_gt +* +* This function is for VF use only. +* +* Return: number of GuC paging engine instances configured by the PF. +*/ +u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt) +{ +xe_gt_assert (gt,IS_SRIOV_VF (gt_to_xe (gt))); +xe_gt_assert (gt, gt->sriov.vf.guc_version.major); + +return gt->sriov.vf.runtime.num_paging_engine_instances; +} +static int relay_action_handshake (struct xe_gt *gt,u32 *major,u32 *minor) {u32 request[VF2PF_HANDSHAKE_REQUEST_MSG_LEN ] = {drivers/gpu/drm/xe/xe_gt_sriov_vf.h +1
-0@@ -31,6 +31,7 @@ u32 xe_gt_sriov_vf_gmdid(struct xe_gt *gt);u16 xe_gt_sriov_vf_guc_ids (struct xe_gt *gt);u64 xe_gt_sriov_vf_lmem (struct xe_gt *gt);bool xe_gt_sriov_vf_sched_groups_enabled (struct xe_gt *gt); +u32 xe_gt_sriov_vf_paging_engines (struct xe_gt *gt);u32 xe_gt_sriov_vf_read32 (struct xe_gt *gt,struct xe_reg reg);void xe_gt_sriov_vf_write32 (struct xe_gt *gt,struct xe_reg reg,u32 val);drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +4
-0@@ -40,6 +40,10 @@ struct xe_gt_sriov_vf_runtime {/** @regs.value: register value. */ u32 value; } *regs; +/** +* @num_paging_engine_instances: number of configured paging engines. +*/ +u32 num_paging_engine_instances; };/** drivers/gpu/drm/xe/xe_guc_klv_helpers.c +2
-0@@ -24,6 +24,8 @@ const char *xe_guc_klv_key_to_string(u16 key)/* GuC Global Config KLVs */ case GUC_KLV_GLOBAL_CFG_GROUP_SCHEDULING_AVAILABLE_KEY :return "group_scheduling_available" ; +case GUC_KLV_GLOBAL_CFG_NUM_PAGING_ENGINE_INSTANCES_KEY : +return "num_paging_engine_instances" ;/* VGT POLICY keys */ case GUC_KLV_VGT_POLICY_SCHED_IF_IDLE_KEY :return "sched_if_idle" ;drivers/gpu/drm/xe/xe_hw_engine.c +28
-2@@ -650,7 +650,7 @@ static int hw_engine_init(struct xe_gt *gt, struct xe_hw_engine *hwe,return err; } -static void hw_engine_setup_logical_and_paging_mapping (struct xe_gt *gt) +static int hw_engine_setup_logical_and_paging_mapping (struct xe_gt *gt) {struct xe_device *xe =gt_to_xe (gt);unsigned int num_copy_engines =0 , num_paging_engines =0 ;@@ -667,6 +667,27 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt)if (num_copy_engines && xe->info.has_usm) num_paging_engines =1 ; +if (IS_SRIOV_VF (xe)) { +u32 vf_num_paging_engines; + +/* +* PF could in theory reserve multiple paging engines, which +* internally the submission/scheduling backend can load balance +* from. Not something we currently expect, but we are at the +* mercy of the PF, so we just need try our best to mirror the +* paging configuration. +*/ + vf_num_paging_engines =xe_gt_sriov_vf_paging_engines (gt); +if (vf_num_paging_engines) { +/* This should only be non-zero on NVL-S+ */ +xe_gt_assert (gt, xe->info.platform >=XE_NOVALAKE_S ); + num_paging_engines = vf_num_paging_engines; + } + } + +if (xe_gt_WARN_ON (gt, num_paging_engines > num_copy_engines)) +return -EINVAL ; + reserved_logical_bcs_start = num_copy_engines - num_paging_engines;/* FIXME: Doing a simple logical mapping that works for most hardware */ @@ -688,6 +709,8 @@ static void hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt) } } } + +return 0 ; }static void read_media_fuses (struct xe_gt *gt)@@ -906,7 +929,10 @@ int xe_hw_engines_init(struct xe_gt *gt)return err; } -hw_engine_setup_logical_and_paging_mapping (gt); + err =hw_engine_setup_logical_and_paging_mapping (gt); +if (err) +return err; + err =xe_hw_engine_setup_groups (gt);if (err)return err;
PATCH v6 9/10 drm/xe/hw_engine: document top-down paging requirement
In reply to Matthew AuldWe were doing this anyway, but going forward for paging engines, agreement is to always reserve BCS instances in top down fashion. This hopefully future proofs things for VFs, where in some low-level places it might only have the physical BCS instance from the hw pov. If we stick to a consistent mapping scheme, it should make it possible to determine if this is a special paging engine, or not.
v2 (Daniele)
- Give a concrete example, like with page fault descriptor
--- drivers/gpu/drm/xe/xe_hw_engine.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_hw_engine.c +12 -1
@@ -663,7 +663,6 @@ static int hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt)if (hwe->class ==XE_ENGINE_CLASS_COPY ) num_copy_engines++; -/* We just reserve the highest BCS instance for USM */ if (num_copy_engines && xe->info.has_usm) num_paging_engines =1 ;
@@ -688,6 +687,18 @@ static int hw_engine_setup_logical_and_paging_mapping(struct xe_gt *gt)if (xe_gt_WARN_ON (gt, num_paging_engines > num_copy_engines))return -EINVAL ; +/* +* On PF, we just reserve the highest BCS instance for USM. +* +* Note: This is now a requirement going forward. The PF must ALWAYS +* reserve BCS instances in top-down order, that way the VF has a chance +* of discovering the physical BCS instance mappings for paging engines, +* in conjunction with vf_num_paging_engines. In some places we might +* only have the physical instance, and from hw pov there is no such +* thing as a paging engine. For example, the page fault descriptor, +* which comes directly from the hw, will use the physical engine +* instance. +*/ reserved_logical_bcs_start = num_copy_engines - num_paging_engines;/* FIXME: Doing a simple logical mapping that works for most hardware */
Signature · 1 line
2.54.0
PATCH v6 10/10 drm/xe/guc: toggle paging engine support for NVL-S+
In reply to Matthew AuldNVL-S with latest GuC should be the first platform combo to support the special GUC_PAGING_CLASS feature.
v2:
- Update with the final GuC version
v3:
- Split VF vs PF versioning. Which is recommendation from GuC side.
--- drivers/gpu/drm/xe/xe_guc.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/gpu/drm/xe/xe_guc.c +8 -2
@@ -1848,6 +1848,9 @@ bool xe_guc_using_main_gamctrl_queues(struct xe_guc *guc)bool xe_guc_has_paging_engine (struct xe_guc *guc) { +struct xe_gt *gt =guc_to_gt (guc); +struct xe_device *xe =gt_to_xe (gt); +/* * On newer platforms the GuC now has a dedicated engine class for the * special PAGING engine, which is the driver reserved BCS engine used
@@ -1857,8 +1860,11 @@ bool xe_guc_has_paging_engine(struct xe_guc *guc)* need to respect. */ -/* TODO: Have some way to query this from the GuC? */ -return false; +if (IS_SRIOV_VF (xe)) +return xe_gt_sriov_vf_paging_engines (gt); + +return xe->info.platform >=XE_NOVALAKE_S && +GUC_FIRMWARE_VER_AT_LEAST (guc,70 ,69 ,0 ); }/**
Signature · 1 line
2.54.0
Patchwork
CI✓ CI.KUnit: success for GuC paging engine support (rev6)
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: GuC paging engine support (rev6)
URL : https://patchwork.freedesktop.org/series/166960/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [18:10:29] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [18:10:35] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=25 [18:11:23] Starting KUnit Kernel (1/1)... [18:11:23] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [18:11:24] ================== guc_buf (11 subtests) =================== [18:11:24] [PASSED] test_smallest [18:11:24] [PASSED] test_largest [18:11:24] [PASSED] test_granular [18:11:24] [PASSED] test_unique [18:11:24] [PASSED] test_overlap [18:11:24] [PASSED] test_reusable [18:11:24] [PASSED] test_too_big [18:11:24] [PASSED] test_flush [18:11:24] [PASSED] test_lookup [18:11:24] [PASSED] test_data [18:11:24] [PASSED] test_class [18:11:24] ===================== [PASSED] guc_buf ===================== [18:11:24] =================== guc_dbm (7 subtests) =================== [18:11:24] [PASSED] test_empty [18:11:24] [PASSED] test_default [18:11:24] ======================== test_size ======================== [18:11:24] [PASSED] 4 [18:11:24] [PASSED] 8 [18:11:24] [PASSED] 32 [18:11:24] [PASSED] 256 [18:11:24] ==================== [PASSED] test_size ==================== [18:11:24] ======================= test_reuse ======================== [18:11:24] [PASSED] 4 [18:11:24] [PASSED] 8 [18:11:24] [PASSED] 32 [18:11:24] [PASSED] 256 [18:11:24] =================== [PASSED] test_reuse ==================== [18:11:24] =================== test_range_overlap ==================== [18:11:24] [PASSED] 4 [18:11:24] [PASSED] 8 [18:11:24] [PASSED] 32 [18:11:24] [PASSED] 256 [18:11:24] =============== [PASSED] test_range_overlap ================ [18:11:24] =================== test_range_compact ==================== [18:11:24] [PASSED] 4 [18:11:24] [PASSED] 8 [18:11:24] [PASSED] 32 [18:11:24] [PASSED] 256 [18:11:24] =============== [PASSED] test_range_compact ================ [18:11:24] ==================== test_range_spare ===================== [18:11:24] [PASSED] 4 [18:11:24] [PASSED] 8 [18:11:24] [PASSED] 32 [18:11:24] [PASSED] 256 [18:11:24] ================ [PASSED] test_range_spare ================= [18:11:24] ===================== [PASSED] guc_dbm ===================== [18:11:24] =================== guc_idm (6 subtests) =================== [18:11:24] [PASSED] bad_init [18:11:24] [PASSED] no_init [18:11:24] [PASSED] init_fini [18:11:24] [PASSED] check_used [18:11:24] [PASSED] check_quota [18:11:24] [PASSED] check_all [18:11:24] ===================== [PASSED] guc_idm ===================== [18:11:24] ================== no_relay (3 subtests) =================== [18:11:24] [PASSED] xe_drops_guc2pf_if_not_ready [18:11:24] [PASSED] xe_drops_guc2vf_if_not_ready [18:11:24] [PASSED] xe_rejects_send_if_not_ready [18:11:24] ==================== [PASSED] no_relay ===================== [18:11:24] ================== pf_relay (14 subtests) ================== [18:11:24] [PASSED] pf_rejects_guc2pf_too_short [18:11:24] [PASSED] pf_rejects_guc2pf_too_long [18:11:24] [PASSED] pf_rejects_guc2pf_no_payload [18:11:24] [PASSED] pf_fails_no_payload [18:11:24] [PASSED] pf_fails_bad_origin [18:11:24] [PASSED] pf_fails_bad_type [18:11:24] [PASSED] pf_txn_reports_error [18:11:24] [PASSED] pf_txn_sends_pf2guc [18:11:24] [PASSED] pf_sends_pf2guc [18:11:24] [SKIPPED] pf_loopback_nop [18:11:24] [SKIPPED] pf_loopback_echo [18:11:24] [SKIPPED] pf_loopback_fail [18:11:24] [SKIPPED] pf_loopback_busy [18:11:24] [SKIPPED] pf_loopback_retry [18:11:24] ==================== [PASSED] pf_relay ===================== [18:11:24] ================== vf_relay (3 subtests) =================== [18:11:24] [PASSED] vf_rejects_guc2vf_too_short [18:11:24] [PASSED] vf_rejects_guc2vf_too_long [18:11:24] [PASSED] vf_rejects_guc2vf_no_payload [18:11:24] ==================== [PASSED] vf_relay ===================== [18:11:24] ================ pf_gt_config (9 subtests) ================= [18:11:24] [PASSED] fair_contexts_1vf [18:11:24] [PASSED] fair_doorbells_1vf [18:11:24] [PASSED] fair_ggtt_1vf [18:11:24] ====================== fair_vram_1vf ====================== [18:11:24] [PASSED] 3.50 GiB [18:11:24] [PASSED] 11.5 GiB [18:11:24] [PASSED] 15.5 GiB [18:11:24] [PASSED] 31.5 GiB [18:11:24] [PASSED] 63.5 GiB [18:11:24] [PASSED] 1.91 GiB [18:11:24] ================== [PASSED] fair_vram_1vf ================== [18:11:24] ================ fair_vram_1vf_admin_only ================= [18:11:24] [PASSED] 3.50 GiB [18:11:24] [PASSED] 11.5 GiB [18:11:24] [PASSED] 15.5 GiB [18:11:24] [PASSED] 31.5 GiB [18:11:24] [PASSED] 63.5 GiB [18:11:24] [PASSED] 1.91 GiB [18:11:24] ============ [PASSED] fair_vram_1vf_admin_only ============= [18:11:24] ====================== fair_contexts ====================== [18:11:24] [PASSED] 1 VF [18:11:24] [PASSED] 2 VFs [18:11:24] [PASSED] 3 VFs [18:11:24] [PASSED] 4 VFs [18:11:24] [PASSED] 5 VFs [18:11:24] [PASSED] 6 VFs [18:11:24] [PASSED] 7 VFs [18:11:24] [PASSED] 8 VFs [18:11:24] [PASSED] 9 VFs [18:11:24] [PASSED] 10 VFs [18:11:24] [PASSED] 11 VFs [18:11:24] [PASSED] 12 VFs [18:11:24] [PASSED] 13 VFs [18:11:24] [PASSED] 14 VFs [18:11:24] [PASSED] 15 VFs [18:11:24] [PASSED] 16 VFs [18:11:24] [PASSED] 17 VFs [18:11:24] [PASSED] 18 VFs [18:11:24] [PASSED] 19 VFs [18:11:24] [PASSED] 20 VFs [18:11:24] [PASSED] 21 VFs [18:11:24] [PASSED] 22 VFs [18:11:24] [PASSED] 23 VFs [18:11:24] [PASSED] 24 VFs [18:11:24] [PASSED] 25 VFs [18:11:24] [PASSED] 26 VFs [18:11:24] [PASSED] 27 VFs [18:11:24] [PASSED] 28 VFs [18:11:24] [PASSED] 29 VFs [18:11:24] [PASSED] 30 VFs [18:11:24] [PASSED] 31 VFs [18:11:24] [PASSED] 32 VFs [18:11:24] [PASSED] 33 VFs [18:11:24] [PASSED] 34 VFs [18:11:24] [PASSED] 35 VFs [18:11:24] [PASSED] 36 VFs [18:11:24] [PASSED] 37 VFs [18:11:24] [PASSED] 38 VFs [18:11:24] [PASSED] 39 VFs [18:11:24] [PASSED] 40 VFs [18:11:24] [PASSED] 41 VFs [18:11:24] [PASSED] 42 VFs [18:11:24] [PASSED] 43 VFs [18:11:24] [PASSED] 44 VFs [18:11:24] [PASSED] 45 VFs [18:11:24] [PASSED] 46 VFs [18:11:24] [PASSED] 47 VFs [18:11:24] [PASSED] 48 VFs [18:11:24] [PASSED] 49 VFs [18:11:24] [PASSED] 50 VFs [18:11:24] [PASSED] 51 VFs [18:11:24] [PASSED] 52 VFs [18:11:24] [PASSED] 53 VFs [18:11:24] [PASSED] 54 VFs [18:11:24] [PASSED] 55 VFs [18:11:24] [PASSED] 56 VFs [18:11:24] [PASSED] 57 VFs [18:11:24] [PASSED] 58 VFs [18:11:24] [PASSED] 59 VFs [18:11:24] [PASSED] 60 VFs [18:11:24] [PASSED] 61 VFs [18:11:24] [PASSED] 62 VFs [18:11:24] [PASSED] 63 VFs [18:11:24] ================== [PASSED] fair_contexts ================== [18:11:24] ===================== fair_doorbells ====================== [18:11:24] [PASSED] 1 VF [18:11:24] [PASSED] 2 VFs [18:11:24] [PASSED] 3 VFs [18:11:24] [PASSED] 4 VFs [18:11:24] [PASSED] 5 VFs [18:11:24] [PASSED] 6 VFs [18:11:24] [PASSED] 7 VFs [18:11:24] [PASSED] 8 VFs [18:11:24] [PASSED] 9 VFs [18:11:24] [PASSED] 10 VFs [18:11:24] [PASSED] 11 VFs [18:11:24] [PASSED] 12 VFs [18:11:24] [PASSED] 13 VFs [18:11:24] [PASSED] 14 VFs [18:11:24] [PASSED] 15 VFs [18:11:24] [PASSED] 16 VFs [18:11:24] [PASSED] 17 VFs [18:11:24] [PASSED] 18 VFs [18:11:24] [PASSED] 19 VFs [18:11:24] [PASSED] 20 VFs [18:11:24] [PASSED] 21 VFs [18:11:24] [PASSED] 22 VFs [18:11:24] [PASSED] 23 VFs [18:11:24] [PASSED] 24 VFs [18:11:24] [PASSED] 25 VFs [18:11:24] [PASSED] 26 VFs [18:11:24] [PASSED] 27 VFs [18:11:24] [PASSED] 28 VFs [18:11:24] [PASSED] 29 VFs [18:11:24] [PASSED] 30 VFs [18:11:24] [PASSED] 31 VFs [18:11:24] [PASSED] 32 VFs [18:11:24] [PASSED] 33 VFs [18:11:24] [PASSED] 34 VFs [18:11:24] [PASSED] 35 VFs [18:11:24] [PASSED] 36 VFs [18:11:24] [PASSED] 37 VFs [18:11:24] [PASSED] 38 VFs [18:11:24] [PASSED] 39 VFs [18:11:24] [PASSED] 40 VFs [18:11:24] [PASSED] 41 VFs [18:11:24] [PASSED] 42 VFs [18:11:24] [PASSED] 43 VFs [18:11:24] [PASSED] 44 VFs [18:11:24] [PASSED] 45 VFs [18:11:24] [PASSED] 46 VFs [18:11:24] [PASSED] 47 VFs [18:11:24] [PASSED] 48 VFs [18:11:24] [PASSED] 49 VFs [18:11:24] [PASSED] 50 VFs [18:11:24] [PASSED] 51 VFs [18:11:24] [PASSED] 52 VFs [18:11:24] [PASSED] 53 VFs [18:11:24] [PASSED] 54 VFs [18:11:24] [PASSED] 55 VFs [18:11:24] [PASSED] 56 VFs [18:11:24] [PASSED] 57 VFs [18:11:24] [PASSED] 58 VFs [18:11:24] [PASSED] 59 VFs [18:11:24] [PASSED] 60 VFs [18:11:24] [PASSED] 61 VFs [18:11:24] [PASSED] 62 VFs [18:11:24] [PASSED] 63 VFs [18:11:24] ================= [PASSED] fair_doorbells ================== [18:11:24] ======================== fair_ggtt ======================== [18:11:24] [PASSED] 1 VF [18:11:24] [PASSED] 2 VFs [18:11:24] [PASSED] 3 VFs [18:11:24] [PASSED] 4 VFs [18:11:24] [PASSED] 5 VFs [18:11:24] [PASSED] 6 VFs [18:11:24] [PASSED] 7 VFs [18:11:24] [PASSED] 8 VFs [18:11:24] [PASSED] 9 VFs [18:11:24] [PASSED] 10 VFs [18:11:24] [PASSED] 11 VFs [18:11:24] [PASSED] 12 VFs [18:11:24] [PASSED] 13 VFs [18:11:24] [PASSED] 14 VFs [18:11:24] [PASSED] 15 VFs [18:11:24] [PASSED] 16 VFs [18:11:24] [PASSED] 17 VFs [18:11:24] [PASSED] 18 VFs [18:11:24] [PASSED] 19 VFs [18:11:24] [PASSED] 20 VFs [18:11:24] [PASSED] 21 VFs [18:11:24] [PASSED] 22 VFs [18:11:24] [PASSED] 23 VFs [18:11:24] [PASSED] 24 VFs [18:11:24] [PASSED] 25 VFs [18:11:24] [PASSED] 26 VFs [18:11:24] [PASSED] 27 VFs [18:11:24] [PASSED] 28 VFs [18:11:24] [PASSED] 29 VFs [18:11:24] [PASSED] 30 VFs [18:11:24] [PASSED] 31 VFs [18:11:24] [PASSED] 32 VFs [18:11:24] [PASSED] 33 VFs [18:11:24] [PASSED] 34 VFs [18:11:24] [PASSED] 35 VFs [18:11:24] [PASSED] 36 VFs [18:11:24] [PASSED] 37 VFs [18:11:24] [PASSED] 38 VFs [18:11:24] [PASSED] 39 VFs [18:11:24] [PASSED] 40 VFs [18:11:24] [PASSED] 41 VFs [18:11:24] [PASSED] 42 VFs [18:11:24] [PASSED] 43 VFs [18:11:24] [PASSED] 44 VFs [18:11:24] [PASSED] 45 VFs [18:11:24] [PASSED] 46 VFs [18:11:24] [PASSED] 47 VFs [18:11:24] [PASSED] 48 VFs [18:11:24] [PASSED] 49 VFs [18:11:24] [PASSED] 50 VFs [18:11:24] [PASSED] 51 VFs [18:11:24] [PASSED] 52 VFs [18:11:24] [PASSED] 53 VFs [18:11:24] [PASSED] 54 VFs [18:11:24] [PASSED] 55 VFs [18:11:24] [PASSED] 56 VFs [18:11:24] [PASSED] 57 VFs [18:11:24] [PASSED] 58 VFs [18:11:24] [PASSED] 59 VFs [18:11:24] [PASSED] 60 VFs [18:11:24] [PASSED] 61 VFs [18:11:24] [PASSED] 62 VFs [18:11:24] [PASSED] 63 VFs [18:11:24] ==================== [PASSED] fair_ggtt ==================== [18:11:24] ======================== fair_vram ======================== [18:11:24] [PASSED] 1 VF [18:11:24] [PASSED] 2 VFs [18:11:24] [PASSED] 3 VFs [18:11:24] [PASSED] 4 VFs [18:11:24] [PASSED] 5 VFs [18:11:24] [PASSED] 6 VFs [18:11:24] [PASSED] 7 VFs [18:11:24] [PASSED] 8 VFs [18:11:24] [PASSED] 9 VFs [18:11:24] [PASSED] 10 VFs [18:11:24] [PASSED] 11 VFs [18:11:24] [PASSED] 12 VFs [18:11:24] [PASSED] 13 VFs [18:11:24] [PASSED] 14 VFs [18:11:24] [PASSED] 15 VFs [18:11:24] [PASSED] 16 VFs [18:11:24] [PASSED] 17 VFs [18:11:24] [PASSED] 18 VFs [18:11:24] [PASSED] 19 VFs [18:11:24] [PASSED] 20 VFs [18:11:24] [PASSED] 21 VFs [18:11:24] [PASSED] 22 VFs [18:11:24] [PASSED] 23 VFs [18:11:24] [PASSED] 24 VFs [18:11:24] [PASSED] 25 VFs [18:11:24] [PASSED] 26 VFs [18:11:24] [PASSED] 27 VFs [18:11:24] [PASSED] 28 VFs [18:11:24] [PASSED] 29 VFs [18:11:24] [PASSED] 30 VFs [18:11:24] [PASSED] 31 VFs [18:11:24] [PASSED] 32 VFs [18:11:24] [PASSED] 33 VFs [18:11:24] [PASSED] 34 VFs [18:11:24] [PASSED] 35 VFs [18:11:24] [PASSED] 36 VFs [18:11:24] [PASSED] 37 VFs [18:11:24] [PASSED] 38 VFs [18:11:24] [PASSED] 39 VFs [18:11:24] [PASSED] 40 VFs [18:11:24] [PASSED] 41 VFs [18:11:24] [PASSED] 42 VFs [18:11:24] [PASSED] 43 VFs [18:11:24] [PASSED] 44 VFs [18:11:24] [PASSED] 45 VFs [18:11:24] [PASSED] 46 VFs [18:11:24] [PASSED] 47 VFs [18:11:24] [PASSED] 48 VFs [18:11:24] [PASSED] 49 VFs [18:11:24] [PASSED] 50 VFs [18:11:24] [PASSED] 51 VFs [18:11:24] [PASSED] 52 VFs [18:11:24] [PASSED] 53 VFs [18:11:24] [PASSED] 54 VFs [18:11:24] [PASSED] 55 VFs [18:11:24] [PASSED] 56 VFs [18:11:24] [PASSED] 57 VFs [18:11:24] [PASSED] 58 VFs [18:11:24] [PASSED] 59 VFs [18:11:24] [PASSED] 60 VFs [18:11:24] [PASSED] 61 VFs [18:11:24] [PASSED] 62 VFs [18:11:24] [PASSED] 63 VFs [18:11:24] ==================== [PASSED] fair_vram ==================== [18:11:24] ================== [PASSED] pf_gt_config =================== [18:11:24] ===================== lmtt (1 subtest) ===================== [18:11:24] ======================== test_ops ========================= [18:11:24] [PASSED] 2-level [18:11:24] [PASSED] multi-level [18:11:24] ==================== [PASSED] test_ops ===================== [18:11:24] ====================== [PASSED] lmtt ======================= [18:11:24] ================= pf_service (11 subtests) ================= [18:11:24] [PASSED] pf_negotiate_any [18:11:24] [PASSED] pf_negotiate_base_match [18:11:24] [PASSED] pf_negotiate_base_newer [18:11:24] [PASSED] pf_negotiate_base_next [18:11:24] [SKIPPED] pf_negotiate_base_older [18:11:24] [PASSED] pf_negotiate_base_prev [18:11:24] [PASSED] pf_negotiate_latest_match [18:11:24] [PASSED] pf_negotiate_latest_newer [18:11:24] [PASSED] pf_negotiate_latest_next [18:11:24] [SKIPPED] pf_negotiate_latest_older [18:11:24] [SKIPPED] pf_negotiate_latest_prev [18:11:24] =================== [PASSED] pf_service ==================== [18:11:24] ================= xe_guc_g2g (2 subtests) ================== [18:11:24] ============== xe_live_guc_g2g_kunit_default ============== [18:11:24] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ========== [18:11:24] ============== xe_live_guc_g2g_kunit_allmem =============== [18:11:24] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ========== [18:11:24] =================== [SKIPPED] xe_guc_g2g =================== [18:11:24] =================== xe_mocs (2 subtests) =================== [18:11:24] ================ xe_live_mocs_kernel_kunit ================ [18:11:24] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============ [18:11:24] ================ xe_live_mocs_reset_kunit ================= [18:11:24] ============ [SKIPPED] xe_live_mocs_reset_kunit ============ [18:11:24] ==================== [SKIPPED] xe_mocs ===================== [18:11:24] ================= xe_migrate (2 subtests) ================== [18:11:24] ================= xe_migrate_sanity_kunit ================= [18:11:24] ============ [SKIPPED] xe_migrate_sanity_kunit ============= [18:11:24] ================== xe_validate_ccs_kunit ================== [18:11:24] ============= [SKIPPED] xe_validate_ccs_kunit ============== [18:11:24] =================== [SKIPPED] xe_migrate =================== [18:11:24] ================== xe_dma_buf (1 subtest) ================== [18:11:24] ==================== xe_dma_buf_kunit ===================== [18:11:24] ================ [SKIPPED] xe_dma_buf_kunit ================ [18:11:24] =================== [SKIPPED] xe_dma_buf =================== [18:11:24] ================= xe_bo_shrink (1 subtest) ================= [18:11:24] =================== xe_bo_shrink_kunit ==================== [18:11:24] =============== [SKIPPED] xe_bo_shrink_kunit =============== [18:11:24] ================== [SKIPPED] xe_bo_shrink ================== [18:11:24] ==================== xe_bo (2 subtests) ==================== [18:11:24] ================== xe_ccs_migrate_kunit =================== [18:11:24] ============== [SKIPPED] xe_ccs_migrate_kunit ============== [18:11:24] ==================== xe_bo_evict_kunit ==================== [18:11:24] =============== [SKIPPED] xe_bo_evict_kunit ================ [18:11:24] ===================== [SKIPPED] xe_bo ====================== [18:11:24] ==================== args (13 subtests) ==================== [18:11:24] [PASSED] count_args_test [18:11:24] [PASSED] call_args_example [18:11:24] [PASSED] call_args_test [18:11:24] [PASSED] drop_first_arg_example [18:11:24] [PASSED] drop_first_arg_test [18:11:24] [PASSED] first_arg_example [18:11:24] [PASSED] first_arg_test [18:11:24] [PASSED] last_arg_example [18:11:24] [PASSED] last_arg_test [18:11:24] [PASSED] pick_arg_example [18:11:24] [PASSED] if_args_example [18:11:24] [PASSED] if_args_test [18:11:24] [PASSED] sep_comma_example [18:11:24] ====================== [PASSED] args ======================= [18:11:24] =================== xe_pci (3 subtests) ==================== [18:11:24] ==================== check_graphics_ip ==================== [18:11:24] [PASSED] 12.00 Xe_LP [18:11:24] [PASSED] 12.10 Xe_LP+ [18:11:24] [PASSED] 12.55 Xe_HPG [18:11:24] [PASSED] 12.60 Xe_HPC [18:11:24] [PASSED] 12.70 Xe_LPG [18:11:24] [PASSED] 12.71 Xe_LPG [18:11:24] [PASSED] 12.74 Xe_LPG+ [18:11:24] [PASSED] 20.01 Xe2_HPG [18:11:24] [PASSED] 20.02 Xe2_HPG [18:11:24] [PASSED] 20.04 Xe2_LPG [18:11:24] [PASSED] 30.00 Xe3_LPG [18:11:24] [PASSED] 30.01 Xe3_LPG [18:11:24] [PASSED] 30.03 Xe3_LPG [18:11:24] [PASSED] 30.04 Xe3_LPG [18:11:24] [PASSED] 30.05 Xe3_LPG [18:11:24] [PASSED] 35.10 Xe3p_LPG [18:11:24] [PASSED] 35.11 Xe3p_XPC [18:11:24] ================ [PASSED] check_graphics_ip ================ [18:11:24] ===================== check_media_ip ====================== [18:11:24] [PASSED] 12.00 Xe_M [18:11:24] [PASSED] 12.55 Xe_HPM [18:11:24] [PASSED] 13.00 Xe_LPM+ [18:11:24] [PASSED] 13.01 Xe2_HPM [18:11:24] [PASSED] 20.00 Xe2_LPM [18:11:24] [PASSED] 30.00 Xe3_LPM [18:11:24] [PASSED] 30.02 Xe3_LPM [18:11:24] [PASSED] 35.00 Xe3p_LPM [18:11:24] [PASSED] 35.03 Xe3p_HPM [18:11:24] ================= [PASSED] check_media_ip ================== [18:11:24] =================== check_platform_desc =================== [18:11:24] [PASSED] 0x9A60 (TIGERLAKE) [18:11:24] [PASSED] 0x9A68 (TIGERLAKE) [18:11:24] [PASSED] 0x9A70 (TIGERLAKE) [18:11:24] [PASSED] 0x9A40 (TIGERLAKE) [18:11:24] [PASSED] 0x9A49 (TIGERLAKE) [18:11:24] [PASSED] 0x9A59 (TIGERLAKE) [18:11:24] [PASSED] 0x9A78 (TIGERLAKE) [18:11:24] [PASSED] 0x9AC0 (TIGERLAKE) [18:11:24] [PASSED] 0x9AC9 (TIGERLAKE) [18:11:24] [PASSED] 0x9AD9 (TIGERLAKE) [18:11:24] [PASSED] 0x9AF8 (TIGERLAKE) [18:11:24] [PASSED] 0x4C80 (ROCKETLAKE) [18:11:24] [PASSED] 0x4C8A (ROCKETLAKE) [18:11:24] [PASSED] 0x4C8B (ROCKETLAKE) [18:11:24] [PASSED] 0x4C8C (ROCKETLAKE) [18:11:24] [PASSED] 0x4C90 (ROCKETLAKE) [18:11:24] [PASSED] 0x4C9A (ROCKETLAKE) [18:11:24] [PASSED] 0x4680 (ALDERLAKE_S) [18:11:24] [PASSED] 0x4682 (ALDERLAKE_S) [18:11:24] [PASSED] 0x4688 (ALDERLAKE_S) [18:11:24] [PASSED] 0x468A (ALDERLAKE_S) [18:11:24] [PASSED] 0x468B (ALDERLAKE_S) [18:11:24] [PASSED] 0x4690 (ALDERLAKE_S) [18:11:24] [PASSED] 0x4692 (ALDERLAKE_S) [18:11:24] [PASSED] 0x4693 (ALDERLAKE_S) [18:11:24] [PASSED] 0x46A0 (ALDERLAKE_P) [18:11:24] [PASSED] 0x46A1 (ALDERLAKE_P) [18:11:24] [PASSED] 0x46A2 (ALDERLAKE_P) [18:11:24] [PASSED] 0x46A3 (ALDERLAKE_P) [18:11:24] [PASSED] 0x46A6 (ALDERLAKE_P) [18:11:24] [PASSED] 0x46A8 (ALDERLAKE_P) [18:11:24] [PASSED] 0x46AA (ALDERLAKE_P) [18:11:24] [PASSED] 0x462A (ALDERLAKE_P) [18:11:24] [PASSED] 0x4626 (ALDERLAKE_P) [18:11:24] [PASSED] 0x4628 (ALDERLAKE_P) [18:11:24] [PASSED] 0x46B0 (ALDERLAKE_P) [18:11:24] [PASSED] 0x46B1 (ALDERLAKE_P) [18:11:24] [PASSED] 0x46B2 (ALDERLAKE_P) [18:11:24] [PASSED] 0x46B3 (ALDERLAKE_P) [18:11:24] [PASSED] 0x46C0 (ALDERLAKE_P) [18:11:24] [PASSED] 0x46C1 (ALDERLAKE_P) [18:11:24] [PASSED] 0x46C2 (ALDERLAKE_P) [18:11:24] [PASSED] 0x46C3 (ALDERLAKE_P) [18:11:24] [PASSED] 0x46D0 (ALDERLAKE_N) [18:11:24] [PASSED] 0x46D1 (ALDERLAKE_N) [18:11:24] [PASSED] 0x46D2 (ALDERLAKE_N) [18:11:24] [PASSED] 0x46D3 (ALDERLAKE_N) [18:11:24] [PASSED] 0x46D4 (ALDERLAKE_N) [18:11:24] [PASSED] 0xA721 (ALDERLAKE_P) [18:11:24] [PASSED] 0xA7A1 (ALDERLAKE_P) [18:11:24] [PASSED] 0xA7A9 (ALDERLAKE_P) [18:11:24] [PASSED] 0xA7AC (ALDERLAKE_P) [18:11:24] [PASSED] 0xA7AD (ALDERLAKE_P) [18:11:24] [PASSED] 0xA720 (ALDERLAKE_P) [18:11:24] [PASSED] 0xA7A0 (ALDERLAKE_P) [18:11:24] [PASSED] 0xA7A8 (ALDERLAKE_P) [18:11:24] [PASSED] 0xA7AA (ALDERLAKE_P) [18:11:24] [PASSED] 0xA7AB (ALDERLAKE_P) [18:11:24] [PASSED] 0xA780 (ALDERLAKE_S) [18:11:24] [PASSED] 0xA781 (ALDERLAKE_S) [18:11:24] [PASSED] 0xA782 (ALDERLAKE_S) [18:11:24] [PASSED] 0xA783 (ALDERLAKE_S) [18:11:24] [PASSED] 0xA788 (ALDERLAKE_S) [18:11:24] [PASSED] 0xA789 (ALDERLAKE_S) [18:11:24] [PASSED] 0xA78A (ALDERLAKE_S) [18:11:24] [PASSED] 0xA78B (ALDERLAKE_S) [18:11:24] [PASSED] 0x4905 (DG1) [18:11:24] [PASSED] 0x4906 (DG1) [18:11:24] [PASSED] 0x4907 (DG1) [18:11:24] [PASSED] 0x4908 (DG1) [18:11:24] [PASSED] 0x4909 (DG1) [18:11:24] [PASSED] 0x56C0 (DG2) [18:11:24] [PASSED] 0x56C2 (DG2) [18:11:24] [PASSED] 0x56C1 (DG2) [18:11:24] [PASSED] 0x7D51 (METEORLAKE) [18:11:24] [PASSED] 0x7DD1 (METEORLAKE) [18:11:24] [PASSED] 0x7D41 (METEORLAKE) [18:11:24] [PASSED] 0x7D67 (METEORLAKE) [18:11:24] [PASSED] 0xB640 (METEORLAKE) [18:11:24] [PASSED] 0x56A0 (DG2) [18:11:24] [PASSED] 0x56A1 (DG2) [18:11:24] [PASSED] 0x56A2 (DG2) [18:11:24] [PASSED] 0x56BE (DG2) [18:11:24] [PASSED] 0x56BF (DG2) [18:11:24] [PASSED] 0x5690 (DG2) [18:11:24] [PASSED] 0x5691 (DG2) [18:11:24] [PASSED] 0x5692 (DG2) [18:11:24] [PASSED] 0x56A5 (DG2) [18:11:24] [PASSED] 0x56A6 (DG2) [18:11:24] [PASSED] 0x56B0 (DG2) [18:11:24] [PASSED] 0x56B1 (DG2) [18:11:24] [PASSED] 0x56BA (DG2) [18:11:24] [PASSED] 0x56BB (DG2) [18:11:24] [PASSED] 0x56BC (DG2) [18:11:24] [PASSED] 0x56BD (DG2) [18:11:24] [PASSED] 0x5693 (DG2) [18:11:24] [PASSED] 0x5694 (DG2) [18:11:24] [PASSED] 0x5695 (DG2) [18:11:24] [PASSED] 0x56A3 (DG2) [18:11:24] [PASSED] 0x56A4 (DG2) [18:11:24] [PASSED] 0x56B2 (DG2) [18:11:24] [PASSED] 0x56B3 (DG2) [18:11:24] [PASSED] 0x5696 (DG2) [18:11:24] [PASSED] 0x5697 (DG2) [18:11:24] [PASSED] 0xB69 (PVC) [18:11:24] [PASSED] 0xB6E (PVC) [18:11:24] [PASSED] 0xBD4 (PVC) [18:11:24] [PASSED] 0xBD5 (PVC) [18:11:24] [PASSED] 0xBD6 (PVC) [18:11:24] [PASSED] 0xBD7 (PVC) [18:11:24] [PASSED] 0xBD8 (PVC) [18:11:24] [PASSED] 0xBD9 (PVC) [18:11:24] [PASSED] 0xBDA (PVC) [18:11:24] [PASSED] 0xBDB (PVC) [18:11:24] [PASSED] 0xBE0 (PVC) [18:11:24] [PASSED] 0xBE1 (PVC) [18:11:24] [PASSED] 0xBE5 (PVC) [18:11:24] [PASSED] 0x7D40 (METEORLAKE) [18:11:24] [PASSED] 0x7D45 (METEORLAKE) [18:11:24] [PASSED] 0x7D55 (METEORLAKE) [18:11:24] [PASSED] 0x7D60 (METEORLAKE) [18:11:24] [PASSED] 0x7DD5 (METEORLAKE) [18:11:24] [PASSED] 0x6420 (LUNARLAKE) [18:11:24] [PASSED] 0x64A0 (LUNARLAKE) [18:11:24] [PASSED] 0x64B0 (LUNARLAKE) [18:11:24] [PASSED] 0xE202 (BATTLEMAGE) [18:11:24] [PASSED] 0xE209 (BATTLEMAGE) [18:11:24] [PASSED] 0xE20B (BATTLEMAGE) [18:11:24] [PASSED] 0xE20C (BATTLEMAGE) [18:11:24] [PASSED] 0xE20D (BATTLEMAGE) [18:11:24] [PASSED] 0xE210 (BATTLEMAGE) [18:11:24] [PASSED] 0xE211 (BATTLEMAGE) [18:11:24] [PASSED] 0xE212 (BATTLEMAGE) [18:11:24] [PASSED] 0xE216 (BATTLEMAGE) [18:11:24] [PASSED] 0xE220 (BATTLEMAGE) [18:11:24] [PASSED] 0xE221 (BATTLEMAGE) [18:11:24] [PASSED] 0xE222 (BATTLEMAGE) [18:11:24] [PASSED] 0xE223 (BATTLEMAGE) [18:11:24] [PASSED] 0xB080 (PANTHERLAKE) [18:11:24] [PASSED] 0xB081 (PANTHERLAKE) [18:11:24] [PASSED] 0xB082 (PANTHERLAKE) [18:11:24] [PASSED] 0xB083 (PANTHERLAKE) [18:11:24] [PASSED] 0xB084 (PANTHERLAKE) [18:11:24] [PASSED] 0xB085 (PANTHERLAKE) [18:11:24] [PASSED] 0xB086 (PANTHERLAKE) [18:11:24] [PASSED] 0xB087 (PANTHERLAKE) [18:11:24] [PASSED] 0xB08F (PANTHERLAKE) [18:11:24] [PASSED] 0xB090 (PANTHERLAKE) [18:11:24] [PASSED] 0xB0A0 (PANTHERLAKE) [18:11:24] [PASSED] 0xB0B0 (PANTHERLAKE) [18:11:24] [PASSED] 0xFD80 (PANTHERLAKE) [18:11:24] [PASSED] 0xFD81 (PANTHERLAKE) [18:11:24] [PASSED] 0xD740 (NOVALAKE_S) [18:11:24] [PASSED] 0xD741 (NOVALAKE_S) [18:11:24] [PASSED] 0xD742 (NOVALAKE_S) [18:11:24] [PASSED] 0xD743 (NOVALAKE_S) [18:11:24] [PASSED] 0xD745 (NOVALAKE_S) [18:11:24] [PASSED] 0xD74A (NOVALAKE_S) [18:11:24] [PASSED] 0xD74B (NOVALAKE_S) [18:11:24] [PASSED] 0x674C (CRESCENTISLAND) [18:11:24] [PASSED] 0x674D (CRESCENTISLAND) [18:11:24] [PASSED] 0x674E (CRESCENTISLAND) [18:11:24] [PASSED] 0x674F (CRESCENTISLAND) [18:11:24] [PASSED] 0x6750 (CRESCENTISLAND) [18:11:24] [PASSED] 0xD750 (NOVALAKE_P) [18:11:24] [PASSED] 0xD751 (NOVALAKE_P) [18:11:24] [PASSED] 0xD752 (NOVALAKE_P) [18:11:24] [PASSED] 0xD753 (NOVALAKE_P) [18:11:24] [PASSED] 0xD754 (NOVALAKE_P) [18:11:24] [PASSED] 0xD755 (NOVALAKE_P) [18:11:24] [PASSED] 0xD756 (NOVALAKE_P) [18:11:24] [PASSED] 0xD757 (NOVALAKE_P) [18:11:24] [PASSED] 0xD75F (NOVALAKE_P) [18:11:24] =============== [PASSED] check_platform_desc =============== [18:11:24] ===================== [PASSED] xe_pci ====================== [18:11:24] ============= xe_rtp_tables_test (4 subtests) ============== [18:11:24] ================== xe_rtp_table_gt_test =================== [18:11:24] [PASSED] gt_was/14011060649 [18:11:24] [PASSED] gt_was/14011059788 [18:11:24] [PASSED] gt_was/14015795083 [18:11:24] [PASSED] gt_was/16021867713 [18:11:24] [PASSED] gt_was/14019449301 [18:11:24] [PASSED] gt_was/16028005424 [18:11:24] [PASSED] gt_was/14026578760 [18:11:24] [PASSED] gt_was/1409420604 [18:11:24] [PASSED] gt_was/1408615072 [18:11:24] [PASSED] gt_was/22010523718 [18:11:24] [PASSED] gt_was/14011006942 [18:11:24] [PASSED] gt_was/14014830051 [18:11:24] [PASSED] gt_was/18018781329 [18:11:24] [PASSED] gt_was/1509235366 [18:11:24] [PASSED] gt_was/18018781329 [18:11:24] [PASSED] gt_was/16016694945 [18:11:24] [PASSED] gt_was/14018575942 [18:11:24] [PASSED] gt_was/22016670082 [18:11:24] [PASSED] gt_was/22016670082 [18:11:24] [PASSED] gt_was/14017421178 [18:11:24] [PASSED] gt_was/16025250150 [18:11:24] [PASSED] gt_was/14021871409 [18:11:24] [PASSED] gt_was/16021865536 [18:11:24] [PASSED] gt_was/14021486841 [18:11:24] [PASSED] gt_was/14025160223 [18:11:24] [PASSED] gt_was/14026144927, 16029437861 [18:11:24] [PASSED] gt_was/14025635424 [18:11:24] [PASSED] gt_was/16028005424 [18:11:24] ============== [PASSED] xe_rtp_table_gt_test =============== [18:11:24] ================== xe_rtp_table_gt_test =================== [18:11:24] [PASSED] gt_tunings/Tuning: Blend Fill Caching Optimization Disable [18:11:24] [PASSED] gt_tunings/Tuning: 32B Access Enable [18:11:24] [PASSED] gt_tunings/Tuning: L3 cache [18:11:24] [PASSED] gt_tunings/Tuning: L3 cache - media [18:11:24] [PASSED] gt_tunings/Tuning: Compression Overfetch [18:11:24] [PASSED] gt_tunings/Tuning: Compression Overfetch - media [18:11:24] [PASSED] gt_tunings/Tuning: Enable compressible partial write overfetch in L3 [18:11:24] [PASSED] gt_tunings/Tuning: Enable compressible partial write overfetch in L3 - media [18:11:24] [PASSED] gt_tunings/Tuning: L2 Overfetch Compressible Only [18:11:24] [PASSED] gt_tunings/Tuning: L2 Overfetch Compressible Only - media [18:11:24] [PASSED] gt_tunings/Tuning: Stateless compression control [18:11:24] [PASSED] gt_tunings/Tuning: Stateless compression control - media [18:11:24] [PASSED] gt_tunings/Tuning: L3 RW flush all Cache [18:11:24] [PASSED] gt_tunings/Tuning: L3 RW flush all cache - media [18:11:24] [PASSED] gt_tunings/Tuning: Set STLB Bank Hash Mode to 4KB [18:11:24] ============== [PASSED] xe_rtp_table_gt_test =============== [18:11:24] ================== xe_rtp_table_oob_test ================== [18:11:24] [PASSED] oob_was/1607983814 [18:11:24] [PASSED] oob_was/16010904313 [18:11:24] [PASSED] oob_was/18022495364 [18:11:24] [PASSED] oob_was/22012773006 [18:11:24] [PASSED] oob_was/14014475959 [18:11:24] [PASSED] oob_was/22011391025 [18:11:24] [PASSED] oob_was/22012727170 [18:11:24] [PASSED] oob_was/22012727685 [18:11:24] [PASSED] oob_was/22016596838 [18:11:24] [PASSED] oob_was/18020744125 [18:11:24] [PASSED] oob_was/1409600907 [18:11:24] [PASSED] oob_was/22014953428 [18:11:24] [PASSED] oob_was/16017236439 [18:11:24] [PASSED] oob_was/14019821291 [18:11:24] [PASSED] oob_was/14015076503 [18:11:24] [PASSED] oob_was/14018913170 [18:11:24] [PASSED] oob_was/14018094691 [18:11:24] [PASSED] oob_was/18024947630 [18:11:24] [PASSED] oob_was/16022287689 [18:11:24] [PASSED] oob_was/13011645652 [18:11:24] [PASSED] oob_was/14022293748 [18:11:24] [PASSED] oob_was/22019794406 [18:11:24] [PASSED] oob_was/22019338487 [18:11:24] [PASSED] oob_was/16023588340 [18:11:24] [PASSED] oob_was/14019789679 [18:11:24] [PASSED] oob_was/14022866841 [18:11:24] [PASSED] oob_was/16021333562 [18:11:24] [PASSED] oob_was/14016712196 [18:11:24] [PASSED] oob_was/14015568240 [18:11:24] [PASSED] oob_was/18013179988 [18:11:24] [PASSED] oob_was/1508761755 [18:11:24] [PASSED] oob_was/16023105232 [18:11:24] [PASSED] oob_was/16026508708 [18:11:24] [PASSED] oob_was/14020001231 [18:11:24] [PASSED] oob_was/16023683509 [18:11:24] [PASSED] oob_was/14025515070 [18:11:24] [PASSED] oob_was/15015404425_disable [18:11:24] [PASSED] oob_was/16026007364 [18:11:24] [PASSED] oob_was/14020316580 [18:11:24] [PASSED] oob_was/14025883347 [18:11:24] ============== [PASSED] xe_rtp_table_oob_test ============== [18:11:24] ================ xe_rtp_table_dev_oob_test ================ [18:11:24] [PASSED] device_oob_was/22010954014 [18:11:24] [PASSED] device_oob_was/15015404425 [18:11:24] [PASSED] device_oob_was/22019338487_display [18:11:24] [PASSED] device_oob_was/14022085890 [18:11:24] [PASSED] device_oob_was/14026539277 [18:11:24] [PASSED] device_oob_was/14026633728 [18:11:24] [PASSED] device_oob_was/14026746987 [18:11:24] [PASSED] device_oob_was/14026779378 [18:11:24] ============ [PASSED] xe_rtp_table_dev_oob_test ============ [18:11:24] =============== [PASSED] xe_rtp_tables_test ================ [18:11:24] =================== xe_rtp (3 subtests) ==================== [18:11:24] =================== xe_rtp_rules_tests ==================== [18:11:24] [PASSED] no [18:11:24] [PASSED] yes [18:11:24] [PASSED] no-and-no [18:11:24] [PASSED] no-and-yes [18:11:24] [PASSED] yes-and-no [18:11:24] [PASSED] yes-and-yes [18:11:24] [PASSED] no-or-no [18:11:24] [PASSED] no-or-yes [18:11:24] [PASSED] yes-or-no [18:11:24] [PASSED] yes-or-yes [18:11:24] [PASSED] no-yes-or-yes-no [18:11:24] [PASSED] no-yes-or-yes-yes [18:11:24] [PASSED] yes-yes-or-no-yes [18:11:24] [PASSED] yes-yes-or-yes-yes [18:11:24] [PASSED] no-no-or-yes-or-no [18:11:24] [PASSED] or [18:11:24] [PASSED] or-yes [18:11:24] [PASSED] or-no [18:11:24] [PASSED] yes-or [18:11:24] [PASSED] no-or [18:11:24] [PASSED] no-or-or-yes [18:11:24] [PASSED] yes-or-or-no [18:11:24] [PASSED] no-or-or-no [18:11:24] [PASSED] missing-context-engine-class [18:11:24] [PASSED] missing-context-engine-class-or-yes [18:11:24] [PASSED] missing-context-engine-class-or-or-yes [18:11:24] =============== [PASSED] xe_rtp_rules_tests ================ [18:11:24] =============== xe_rtp_process_to_sr_tests ================ [18:11:24] [PASSED] coalesce-same-reg [18:11:24] [PASSED] no-match-no-add [18:11:24] [PASSED] two-regs-two-entries [18:11:24] [PASSED] clr-one-set-other [18:11:24] [PASSED] set-field [18:11:24] [PASSED] conflict-duplicate [18:11:24] [PASSED] conflict-not-disjoint [18:11:24] [PASSED] conflict-reg-type [18:11:24] [PASSED] bad-mcr-reg-forced-to-regular [18:11:24] [PASSED] bad-regular-reg-forced-to-mcr [18:11:24] =========== [PASSED] xe_rtp_process_to_sr_tests ============ [18:11:24] ================== xe_rtp_process_tests =================== [18:11:24] [PASSED] active1 [18:11:24] [PASSED] active2 [18:11:24] [PASSED] active-inactive [18:11:24] [PASSED] inactive-active [18:11:24] [PASSED] inactive-active-inactive [18:11:24] [PASSED] inactive-inactive-inactive [18:11:24] ============== [PASSED] xe_rtp_process_tests =============== [18:11:24] ===================== [PASSED] xe_rtp ====================== [18:11:24] ==================== xe_wa (1 subtest) ===================== [18:11:24] ======================== xe_wa_gt ========================= [18:11:24] [PASSED] TIGERLAKE B0 [18:11:24] [PASSED] DG1 A0 [18:11:24] [PASSED] DG1 B0 [18:11:24] [PASSED] ALDERLAKE_S A0 [18:11:24] [PASSED] ALDERLAKE_S B0 [18:11:24] [PASSED] ALDERLAKE_S C0 [18:11:24] [PASSED] ALDERLAKE_S D0 [18:11:24] [PASSED] ALDERLAKE_P A0 [18:11:24] [PASSED] ALDERLAKE_P B0 [18:11:24] [PASSED] ALDERLAKE_P C0 [18:11:24] [PASSED] ALDERLAKE_S RPLS D0 [18:11:24] [PASSED] ALDERLAKE_P RPLU E0 [18:11:24] [PASSED] DG2 G10 C0 [18:11:24] [PASSED] DG2 G11 B1 [18:11:24] [PASSED] DG2 G12 A1 [18:11:24] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0 [18:11:24] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0 [18:11:24] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0 [18:11:24] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0 [18:11:24] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0 [18:11:24] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1 [18:11:24] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0 [18:11:24] ==================== [PASSED] xe_wa_gt ===================== [18:11:24] ====================== [PASSED] xe_wa ====================== [18:11:24] ============================================================ [18:11:24] Testing complete. Ran 716 tests: passed: 698, skipped: 18 [18:11:24] Elapsed time: 55.023s total, 5.856s configuring, 48.500s building, 0.660s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig [18:11:24] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[18:11:26] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=25
In file included from ../drivers/gpu/drm/tests/drm_bridge_test.c:21:
../drivers/gpu/drm/tests/drm_kunit_edid.h:958:28: warning: ‘test_edid_hdmi_4k_rgb_yuv420_dc_max_340mhz’ defined but not used [-Wunused-const-variable=]
958 | static const unsigned char test_edid_hdmi_4k_rgb_yuv420_dc_max_340mhz[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/gpu/drm/tests/drm_kunit_edid.h:726:28: warning: ‘test_edid_hdmi_1080p_rgb_yuv_dc_max_340mhz’ defined but not used [-Wunused-const-variable=]
726 | static const unsigned char test_edid_hdmi_1080p_rgb_yuv_dc_max_340mhz[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/gpu/drm/tests/drm_kunit_edid.h:612:28: warning: ‘test_edid_hdmi_1080p_rgb_yuv_dc_max_200mhz’ defined but not used [-Wunused-const-variable=]
612 | static const unsigned char test_edid_hdmi_1080p_rgb_yuv_dc_max_200mhz[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/gpu/drm/tests/drm_kunit_edid.h:498:28: warning: ‘test_edid_hdmi_1080p_rgb_max_340mhz’ defined but not used [-Wunused-const-variable=]
498 | static const unsigned char test_edid_hdmi_1080p_rgb_max_340mhz[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/gpu/drm/tests/drm_kunit_edid.h:390:28: warning: ‘test_edid_hdmi_1080p_rgb_max_200mhz_hdr’ defined but not used [-Wunused-const-variable=]
390 | static const unsigned char test_edid_hdmi_1080p_rgb_max_200mhz_hdr[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/gpu/drm/tests/drm_kunit_edid.h:271:28: warning: ‘test_edid_hdmi_1080p_rgb_max_200mhz’ defined but not used [-Wunused-const-variable=]
271 | static const unsigned char test_edid_hdmi_1080p_rgb_max_200mhz[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/gpu/drm/tests/drm_kunit_edid.h:163:28: warning: ‘test_edid_hdmi_1080p_rgb_max_100mhz’ defined but not used [-Wunused-const-variable=]
163 | static const unsigned char test_edid_hdmi_1080p_rgb_max_100mhz[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/gpu/drm/tests/drm_kunit_edid.h:57:28: warning: ‘test_edid_dvi_1080p’ defined but not used [-Wunused-const-variable=]
57 | static const unsigned char test_edid_dvi_1080p[] = {
| ^~~~~~~~~~~~~~~~~~~[18:12:15] Starting KUnit Kernel (1/1)...
[18:12:15] ============================================================ Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [18:12:15] ============ drm_test_pick_cmdline (2 subtests) ============ [18:12:15] [PASSED] drm_test_pick_cmdline_res_1920_1080_60 [18:12:15] =============== drm_test_pick_cmdline_named =============== [18:12:15] [PASSED] NTSC [18:12:15] [PASSED] NTSC-J [18:12:15] [PASSED] PAL [18:12:15] [PASSED] PAL-M [18:12:15] =========== [PASSED] drm_test_pick_cmdline_named =========== [18:12:15] ============== [PASSED] drm_test_pick_cmdline ============== [18:12:15] == drm_test_atomic_get_connector_for_encoder (1 subtest) === [18:12:15] [PASSED] drm_test_drm_atomic_get_connector_for_encoder [18:12:15] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ==== [18:12:15] =========== drm_validate_clone_mode (2 subtests) =========== [18:12:15] ============== drm_test_check_in_clone_mode =============== [18:12:15] [PASSED] in_clone_mode [18:12:15] [PASSED] not_in_clone_mode [18:12:15] ========== [PASSED] drm_test_check_in_clone_mode =========== [18:12:15] =============== drm_test_check_valid_clones =============== [18:12:15] [PASSED] not_in_clone_mode [18:12:15] [PASSED] valid_clone [18:12:15] [PASSED] invalid_clone [18:12:15] =========== [PASSED] drm_test_check_valid_clones =========== [18:12:15] ============= [PASSED] drm_validate_clone_mode ============= [18:12:15] ============= drm_validate_modeset (1 subtest) ============= [18:12:15] [PASSED] drm_test_check_connector_changed_modeset [18:12:15] ============== [PASSED] drm_validate_modeset =============== [18:12:15] ====== drm_test_bridge_get_current_state (2 subtests) ====== [18:12:15] [PASSED] drm_test_drm_bridge_get_current_state_atomic [18:12:15] [PASSED] drm_test_drm_bridge_get_current_state_legacy [18:12:15] ======== [PASSED] drm_test_bridge_get_current_state ======== [18:12:15] ====== drm_test_bridge_helper_reset_crtc (4 subtests) ====== [18:12:15] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic [18:12:15] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled [18:12:15] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy [18:12:15] [PASSED] drm_test_drm_bridge_helper_hdmi_output_bus_fmts [18:12:15] ======== [PASSED] drm_test_bridge_helper_reset_crtc ======== [18:12:15] ============== drm_bridge_alloc (2 subtests) =============== [18:12:15] [PASSED] drm_test_drm_bridge_alloc_basic [18:12:15] [PASSED] drm_test_drm_bridge_alloc_get_put [18:12:15] ================ [PASSED] drm_bridge_alloc ================= [18:12:15] ============= drm_bridge_bus_fmt (5 subtests) ============== [18:12:15] [PASSED] drm_test_bridge_rgb_yuv_rgb [18:12:15] [PASSED] drm_test_bridge_must_convert_to_yuv444 [18:12:15] [PASSED] drm_test_bridge_hdmi_auto_rgb [18:12:15] [PASSED] drm_test_bridge_auto_first [18:12:15] [PASSED] drm_test_bridge_rgb_yuv_no_path [18:12:15] =============== [PASSED] drm_bridge_bus_fmt ================ [18:12:15] ============= drm_cmdline_parser (40 subtests) ============= [18:12:15] [PASSED] drm_test_cmdline_force_d_only [18:12:15] [PASSED] drm_test_cmdline_force_D_only_dvi [18:12:15] [PASSED] drm_test_cmdline_force_D_only_hdmi [18:12:15] [PASSED] drm_test_cmdline_force_D_only_not_digital [18:12:15] [PASSED] drm_test_cmdline_force_e_only [18:12:15] [PASSED] drm_test_cmdline_res [18:12:15] [PASSED] drm_test_cmdline_res_vesa [18:12:15] [PASSED] drm_test_cmdline_res_vesa_rblank [18:12:15] [PASSED] drm_test_cmdline_res_rblank [18:12:15] [PASSED] drm_test_cmdline_res_bpp [18:12:15] [PASSED] drm_test_cmdline_res_refresh [18:12:15] [PASSED] drm_test_cmdline_res_bpp_refresh [18:12:15] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced [18:12:15] [PASSED] drm_test_cmdline_res_bpp_refresh_margins [18:12:15] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off [18:12:15] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on [18:12:15] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog [18:12:15] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital [18:12:15] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on [18:12:15] [PASSED] drm_test_cmdline_res_margins_force_on [18:12:15] [PASSED] drm_test_cmdline_res_vesa_margins [18:12:15] [PASSED] drm_test_cmdline_name [18:12:15] [PASSED] drm_test_cmdline_name_bpp [18:12:15] [PASSED] drm_test_cmdline_name_option [18:12:15] [PASSED] drm_test_cmdline_name_bpp_option [18:12:15] [PASSED] drm_test_cmdline_rotate_0 [18:12:15] [PASSED] drm_test_cmdline_rotate_90 [18:12:15] [PASSED] drm_test_cmdline_rotate_180 [18:12:15] [PASSED] drm_test_cmdline_rotate_270 [18:12:15] [PASSED] drm_test_cmdline_hmirror [18:12:15] [PASSED] drm_test_cmdline_vmirror [18:12:15] [PASSED] drm_test_cmdline_margin_options [18:12:15] [PASSED] drm_test_cmdline_multiple_options [18:12:15] [PASSED] drm_test_cmdline_bpp_extra_and_option [18:12:15] [PASSED] drm_test_cmdline_extra_and_option [18:12:15] [PASSED] drm_test_cmdline_freestanding_options [18:12:15] [PASSED] drm_test_cmdline_freestanding_force_e_and_options [18:12:15] [PASSED] drm_test_cmdline_panel_orientation [18:12:15] ================ drm_test_cmdline_invalid ================= [18:12:15] [PASSED] margin_only [18:12:15] [PASSED] interlace_only [18:12:15] [PASSED] res_missing_x [18:12:15] [PASSED] res_missing_y [18:12:15] [PASSED] res_bad_y [18:12:15] [PASSED] res_missing_y_bpp [18:12:15] [PASSED] res_bad_bpp [18:12:15] [PASSED] res_bad_refresh [18:12:15] [PASSED] res_bpp_refresh_force_on_off [18:12:15] [PASSED] res_invalid_mode [18:12:15] [PASSED] res_bpp_wrong_place_mode [18:12:15] [PASSED] name_bpp_refresh [18:12:15] [PASSED] name_refresh [18:12:15] [PASSED] name_refresh_wrong_mode [18:12:15] [PASSED] name_refresh_invalid_mode [18:12:15] [PASSED] rotate_multiple [18:12:15] [PASSED] rotate_invalid_val [18:12:15] [PASSED] rotate_truncated [18:12:15] [PASSED] invalid_option [18:12:15] [PASSED] invalid_tv_option [18:12:15] [PASSED] truncated_tv_option [18:12:15] ============ [PASSED] drm_test_cmdline_invalid ============= [18:12:15] =============== drm_test_cmdline_tv_options =============== [18:12:15] [PASSED] NTSC [18:12:15] [PASSED] NTSC_443 [18:12:15] [PASSED] NTSC_J [18:12:15] [PASSED] PAL [18:12:15] [PASSED] PAL_M [18:12:15] [PASSED] PAL_N [18:12:15] [PASSED] SECAM [18:12:15] [PASSED] MONO_525 [18:12:15] [PASSED] MONO_625 [18:12:15] =========== [PASSED] drm_test_cmdline_tv_options =========== [18:12:15] =============== [PASSED] drm_cmdline_parser ================ [18:12:15] ========== drmm_connector_hdmi_init (20 subtests) ========== [18:12:15] [PASSED] drm_test_connector_hdmi_init_valid [18:12:15] [PASSED] drm_test_connector_hdmi_init_bpc_8 [18:12:15] [PASSED] drm_test_connector_hdmi_init_bpc_10 [18:12:15] [PASSED] drm_test_connector_hdmi_init_bpc_12 [18:12:15] [PASSED] drm_test_connector_hdmi_init_bpc_invalid [18:12:15] [PASSED] drm_test_connector_hdmi_init_bpc_null [18:12:15] [PASSED] drm_test_connector_hdmi_init_formats_empty [18:12:15] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb [18:12:15] === drm_test_connector_hdmi_init_formats_yuv420_allowed === [18:12:15] [PASSED] supported_formats=0x9 yuv420_allowed=1 [18:12:15] [PASSED] supported_formats=0x9 yuv420_allowed=0 [18:12:15] [PASSED] supported_formats=0x5 yuv420_allowed=1 [18:12:15] [PASSED] supported_formats=0x5 yuv420_allowed=0 [18:12:15] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed === [18:12:15] [PASSED] drm_test_connector_hdmi_init_null_ddc [18:12:15] [PASSED] drm_test_connector_hdmi_init_null_product [18:12:15] [PASSED] drm_test_connector_hdmi_init_null_vendor [18:12:15] [PASSED] drm_test_connector_hdmi_init_product_length_exact [18:12:15] [PASSED] drm_test_connector_hdmi_init_product_length_too_long [18:12:15] [PASSED] drm_test_connector_hdmi_init_product_valid [18:12:15] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact [18:12:15] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long [18:12:15] [PASSED] drm_test_connector_hdmi_init_vendor_valid [18:12:15] ========= drm_test_connector_hdmi_init_type_valid ========= [18:12:15] [PASSED] HDMI-A [18:12:15] [PASSED] HDMI-B [18:12:15] ===== [PASSED] drm_test_connector_hdmi_init_type_valid ===== [18:12:15] ======== drm_test_connector_hdmi_init_type_invalid ======== [18:12:15] [PASSED] Unknown [18:12:15] [PASSED] VGA [18:12:15] [PASSED] DVI-I [18:12:15] [PASSED] DVI-D [18:12:15] [PASSED] DVI-A [18:12:15] [PASSED] Composite [18:12:15] [PASSED] SVIDEO [18:12:15] [PASSED] LVDS [18:12:15] [PASSED] Component [18:12:15] [PASSED] DIN [18:12:15] [PASSED] DP [18:12:15] [PASSED] TV [18:12:15] [PASSED] eDP [18:12:15] [PASSED] Virtual [18:12:15] [PASSED] DSI [18:12:15] [PASSED] DPI [18:12:15] [PASSED] Writeback [18:12:15] [PASSED] SPI [18:12:15] [PASSED] USB [18:12:15] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ==== [18:12:15] ============ [PASSED] drmm_connector_hdmi_init ============= [18:12:15] ============= drmm_connector_init (3 subtests) ============= [18:12:15] [PASSED] drm_test_drmm_connector_init [18:12:15] [PASSED] drm_test_drmm_connector_init_null_ddc [18:12:15] ========= drm_test_drmm_connector_init_type_valid ========= [18:12:15] [PASSED] Unknown [18:12:15] [PASSED] VGA [18:12:15] [PASSED] DVI-I [18:12:15] [PASSED] DVI-D [18:12:15] [PASSED] DVI-A [18:12:15] [PASSED] Composite [18:12:15] [PASSED] SVIDEO [18:12:15] [PASSED] LVDS [18:12:15] [PASSED] Component [18:12:15] [PASSED] DIN [18:12:15] [PASSED] DP [18:12:15] [PASSED] HDMI-A [18:12:15] [PASSED] HDMI-B [18:12:15] [PASSED] TV [18:12:15] [PASSED] eDP [18:12:15] [PASSED] Virtual [18:12:15] [PASSED] DSI [18:12:15] [PASSED] DPI [18:12:15] [PASSED] Writeback [18:12:15] [PASSED] SPI [18:12:15] [PASSED] USB [18:12:15] ===== [PASSED] drm_test_drmm_connector_init_type_valid ===== [18:12:15] =============== [PASSED] drmm_connector_init =============== [18:12:15] ========= drm_connector_dynamic_init (6 subtests) ========== [18:12:15] [PASSED] drm_test_drm_connector_dynamic_init [18:12:15] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc [18:12:15] [PASSED] drm_test_drm_connector_dynamic_init_not_added [18:12:15] [PASSED] drm_test_drm_connector_dynamic_init_properties [18:12:15] ===== drm_test_drm_connector_dynamic_init_type_valid ====== [18:12:15] [PASSED] Unknown [18:12:15] [PASSED] VGA [18:12:15] [PASSED] DVI-I [18:12:15] [PASSED] DVI-D [18:12:15] [PASSED] DVI-A [18:12:15] [PASSED] Composite [18:12:15] [PASSED] SVIDEO [18:12:15] [PASSED] LVDS [18:12:15] [PASSED] Component [18:12:15] [PASSED] DIN [18:12:15] [PASSED] DP [18:12:15] [PASSED] HDMI-A [18:12:15] [PASSED] HDMI-B [18:12:15] [PASSED] TV [18:12:15] [PASSED] eDP [18:12:15] [PASSED] Virtual [18:12:15] [PASSED] DSI [18:12:15] [PASSED] DPI [18:12:15] [PASSED] Writeback [18:12:15] [PASSED] SPI [18:12:15] [PASSED] USB [18:12:15] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid == [18:12:15] ======== drm_test_drm_connector_dynamic_init_name ========= [18:12:15] [PASSED] Unknown [18:12:15] [PASSED] VGA [18:12:15] [PASSED] DVI-I [18:12:15] [PASSED] DVI-D [18:12:15] [PASSED] DVI-A [18:12:15] [PASSED] Composite [18:12:15] [PASSED] SVIDEO [18:12:15] [PASSED] LVDS [18:12:15] [PASSED] Component [18:12:15] [PASSED] DIN [18:12:15] [PASSED] DP [18:12:15] [PASSED] HDMI-A [18:12:15] [PASSED] HDMI-B [18:12:15] [PASSED] TV [18:12:15] [PASSED] eDP [18:12:15] [PASSED] Virtual [18:12:15] [PASSED] DSI [18:12:15] [PASSED] DPI [18:12:15] [PASSED] Writeback [18:12:15] [PASSED] SPI [18:12:15] [PASSED] USB [18:12:15] ==== [PASSED] drm_test_drm_connector_dynamic_init_name ===== [18:12:15] =========== [PASSED] drm_connector_dynamic_init ============ [18:12:15] ==== drm_connector_dynamic_register_early (4 subtests) ===== [18:12:15] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list [18:12:15] [PASSED] drm_test_drm_connector_dynamic_register_early_defer [18:12:15] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init [18:12:15] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object [18:12:15] ====== [PASSED] drm_connector_dynamic_register_early ======= [18:12:15] ======= drm_connector_dynamic_register (7 subtests) ======== [18:12:15] [PASSED] drm_test_drm_connector_dynamic_register_on_list [18:12:15] [PASSED] drm_test_drm_connector_dynamic_register_no_defer [18:12:15] [PASSED] drm_test_drm_connector_dynamic_register_no_init [18:12:15] [PASSED] drm_test_drm_connector_dynamic_register_mode_object [18:12:15] [PASSED] drm_test_drm_connector_dynamic_register_sysfs [18:12:15] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name [18:12:15] [PASSED] drm_test_drm_connector_dynamic_register_debugfs [18:12:15] ========= [PASSED] drm_connector_dynamic_register ========== [18:12:15] = drm_connector_attach_broadcast_rgb_property (2 subtests) = [18:12:15] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property [18:12:15] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector [18:12:15] === [PASSED] drm_connector_attach_broadcast_rgb_property === [18:12:15] ========== drm_get_tv_mode_from_name (2 subtests) ========== [18:12:15] ========== drm_test_get_tv_mode_from_name_valid =========== [18:12:15] [PASSED] NTSC [18:12:15] [PASSED] NTSC-443 [18:12:15] [PASSED] NTSC-J [18:12:15] [PASSED] PAL [18:12:15] [PASSED] PAL-M [18:12:15] [PASSED] PAL-N [18:12:15] [PASSED] SECAM [18:12:15] [PASSED] Mono [18:12:15] ====== [PASSED] drm_test_get_tv_mode_from_name_valid ======= [18:12:15] [PASSED] drm_test_get_tv_mode_from_name_truncated [18:12:15] ============ [PASSED] drm_get_tv_mode_from_name ============ [18:12:15] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) = [18:12:15] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb [18:12:15] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc [18:12:15] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1 [18:12:15] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc [18:12:15] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1 [18:12:15] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double [18:12:15] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid = [18:12:15] [PASSED] VIC 96 [18:12:15] [PASSED] VIC 97 [18:12:15] [PASSED] VIC 101 [18:12:15] [PASSED] VIC 102 [18:12:15] [PASSED] VIC 106 [18:12:15] [PASSED] VIC 107 [18:12:15] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid === [18:12:15] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc [18:12:15] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc [18:12:15] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc [18:12:15] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc [18:12:15] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc [18:12:15] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ==== [18:12:15] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) == [18:12:15] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ==== [18:12:15] [PASSED] Automatic [18:12:15] [PASSED] Full [18:12:15] [PASSED] Limited 16:235 [18:12:15] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name === [18:12:15] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid [18:12:15] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ==== [18:12:15] == drm_hdmi_connector_get_output_format_name (2 subtests) == [18:12:15] === drm_test_drm_hdmi_connector_get_output_format_name ==== [18:12:15] [PASSED] RGB [18:12:15] [PASSED] YUV 4:2:0 [18:12:15] [PASSED] YUV 4:2:2 [18:12:15] [PASSED] YUV 4:4:4 [18:12:15] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name === [18:12:15] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid [18:12:15] ==== [PASSED] drm_hdmi_connector_get_output_format_name ==== [18:12:15] ============= drm_damage_helper (21 subtests) ============== [18:12:15] [PASSED] drm_test_damage_iter_no_damage [18:12:15] [PASSED] drm_test_damage_iter_no_damage_fractional_src [18:12:15] [PASSED] drm_test_damage_iter_no_damage_src_moved [18:12:15] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved [18:12:15] [PASSED] drm_test_damage_iter_no_damage_not_visible [18:12:15] [PASSED] drm_test_damage_iter_no_damage_no_crtc [18:12:15] [PASSED] drm_test_damage_iter_no_damage_no_fb [18:12:15] [PASSED] drm_test_damage_iter_simple_damage [18:12:15] [PASSED] drm_test_damage_iter_single_damage [18:12:15] [PASSED] drm_test_damage_iter_single_damage_intersect_src [18:12:15] [PASSED] drm_test_damage_iter_single_damage_outside_src [18:12:15] [PASSED] drm_test_damage_iter_single_damage_fractional_src [18:12:15] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src [18:12:15] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src [18:12:15] [PASSED] drm_test_damage_iter_single_damage_src_moved [18:12:15] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved [18:12:15] [PASSED] drm_test_damage_iter_damage [18:12:15] [PASSED] drm_test_damage_iter_damage_one_intersect [18:12:15] [PASSED] drm_test_damage_iter_damage_one_outside [18:12:15] [PASSED] drm_test_damage_iter_damage_src_moved [18:12:15] [PASSED] drm_test_damage_iter_damage_not_visible [18:12:15] ================ [PASSED] drm_damage_helper ================ [18:12:15] ============== drm_dp_mst_helper (3 subtests) ============== [18:12:15] ============== drm_test_dp_mst_calc_pbn_mode ============== [18:12:15] [PASSED] Clock 154000 BPP 30 DSC disabled [18:12:15] [PASSED] Clock 234000 BPP 30 DSC disabled [18:12:15] [PASSED] Clock 297000 BPP 24 DSC disabled [18:12:15] [PASSED] Clock 332880 BPP 24 DSC enabled [18:12:15] [PASSED] Clock 324540 BPP 24 DSC enabled [18:12:15] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ========== [18:12:15] ============== drm_test_dp_mst_calc_pbn_div =============== [18:12:15] [PASSED] Link rate 2000000 lane count 4 [18:12:15] [PASSED] Link rate 2000000 lane count 2 [18:12:15] [PASSED] Link rate 2000000 lane count 1 [18:12:15] [PASSED] Link rate 1350000 lane count 4 [18:12:15] [PASSED] Link rate 1350000 lane count 2 [18:12:15] [PASSED] Link rate 1350000 lane count 1 [18:12:15] [PASSED] Link rate 1000000 lane count 4 [18:12:15] [PASSED] Link rate 1000000 lane count 2 [18:12:15] [PASSED] Link rate 1000000 lane count 1 [18:12:15] [PASSED] Link rate 810000 lane count 4 [18:12:15] [PASSED] Link rate 810000 lane count 2 [18:12:15] [PASSED] Link rate 810000 lane count 1 [18:12:15] [PASSED] Link rate 540000 lane count 4 [18:12:15] [PASSED] Link rate 540000 lane count 2 [18:12:15] [PASSED] Link rate 540000 lane count 1 [18:12:15] [PASSED] Link rate 270000 lane count 4 [18:12:15] [PASSED] Link rate 270000 lane count 2 [18:12:15] [PASSED] Link rate 270000 lane count 1 [18:12:15] [PASSED] Link rate 162000 lane count 4 [18:12:15] [PASSED] Link rate 162000 lane count 2 [18:12:15] [PASSED] Link rate 162000 lane count 1 [18:12:15] ========== [PASSED] drm_test_dp_mst_calc_pbn_div =========== [18:12:15] ========= drm_test_dp_mst_sideband_msg_req_decode ========= [18:12:15] [PASSED] DP_ENUM_PATH_RESOURCES with port number [18:12:15] [PASSED] DP_POWER_UP_PHY with port number [18:12:15] [PASSED] DP_POWER_DOWN_PHY with port number [18:12:15] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks [18:12:15] [PASSED] DP_ALLOCATE_PAYLOAD with port number [18:12:15] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI [18:12:15] [PASSED] DP_ALLOCATE_PAYLOAD with PBN [18:12:15] [PASSED] DP_QUERY_PAYLOAD with port number [18:12:15] [PASSED] DP_QUERY_PAYLOAD with VCPI [18:12:15] [PASSED] DP_REMOTE_DPCD_READ with port number [18:12:15] [PASSED] DP_REMOTE_DPCD_READ with DPCD address [18:12:15] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes [18:12:15] [PASSED] DP_REMOTE_DPCD_WRITE with port number [18:12:15] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address [18:12:15] [PASSED] DP_REMOTE_DPCD_WRITE with data array [18:12:15] [PASSED] DP_REMOTE_I2C_READ with port number [18:12:15] [PASSED] DP_REMOTE_I2C_READ with I2C device ID [18:12:15] [PASSED] DP_REMOTE_I2C_READ with transactions array [18:12:15] [PASSED] DP_REMOTE_I2C_WRITE with port number [18:12:15] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID [18:12:15] [PASSED] DP_REMOTE_I2C_WRITE with data array [18:12:15] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID [18:12:15] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID [18:12:15] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event [18:12:15] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event [18:12:15] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior [18:12:15] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior [18:12:15] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode ===== [18:12:15] ================ [PASSED] drm_dp_mst_helper ================ [18:12:15] ================== drm_exec (7 subtests) =================== [18:12:15] [PASSED] sanitycheck [18:12:15] [PASSED] test_lock [18:12:15] [PASSED] test_lock_unlock [18:12:15] [PASSED] test_duplicates [18:12:15] [PASSED] test_prepare [18:12:15] [PASSED] test_prepare_array [18:12:15] [PASSED] test_multiple_loops [18:12:15] ==================== [PASSED] drm_exec ===================== [18:12:15] =========== drm_format_helper_test (17 subtests) =========== [18:12:15] ============== drm_test_fb_xrgb8888_to_gray8 ============== [18:12:15] [PASSED] single_pixel_source_buffer [18:12:15] [PASSED] single_pixel_clip_rectangle [18:12:15] [PASSED] well_known_colors [18:12:15] [PASSED] destination_pitch [18:12:15] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ========== [18:12:15] ============= drm_test_fb_xrgb8888_to_rgb332 ============== [18:12:15] [PASSED] single_pixel_source_buffer [18:12:15] [PASSED] single_pixel_clip_rectangle [18:12:15] [PASSED] well_known_colors [18:12:15] [PASSED] destination_pitch [18:12:15] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ========== [18:12:15] ============= drm_test_fb_xrgb8888_to_rgb565 ============== [18:12:15] [PASSED] single_pixel_source_buffer [18:12:15] [PASSED] single_pixel_clip_rectangle [18:12:15] [PASSED] well_known_colors [18:12:15] [PASSED] destination_pitch [18:12:15] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ========== [18:12:15] ============ drm_test_fb_xrgb8888_to_xrgb1555 ============= [18:12:15] [PASSED] single_pixel_source_buffer [18:12:15] [PASSED] single_pixel_clip_rectangle [18:12:15] [PASSED] well_known_colors [18:12:15] [PASSED] destination_pitch [18:12:15] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 ========= [18:12:15] ============ drm_test_fb_xrgb8888_to_argb1555 ============= [18:12:15] [PASSED] single_pixel_source_buffer [18:12:15] [PASSED] single_pixel_clip_rectangle [18:12:15] [PASSED] well_known_colors [18:12:15] [PASSED] destination_pitch [18:12:15] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 ========= [18:12:15] ============ drm_test_fb_xrgb8888_to_rgba5551 ============= [18:12:15] [PASSED] single_pixel_source_buffer [18:12:15] [PASSED] single_pixel_clip_rectangle [18:12:15] [PASSED] well_known_colors [18:12:15] [PASSED] destination_pitch [18:12:15] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 ========= [18:12:15] ============= drm_test_fb_xrgb8888_to_rgb888 ============== [18:12:15] [PASSED] single_pixel_source_buffer [18:12:15] [PASSED] single_pixel_clip_rectangle [18:12:15] [PASSED] well_known_colors [18:12:15] [PASSED] destination_pitch [18:12:15] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ========== [18:12:15] ============= drm_test_fb_xrgb8888_to_bgr888 ============== [18:12:15] [PASSED] single_pixel_source_buffer [18:12:15] [PASSED] single_pixel_clip_rectangle [18:12:15] [PASSED] well_known_colors [18:12:15] [PASSED] destination_pitch [18:12:15] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ========== [18:12:15] ============ drm_test_fb_xrgb8888_to_argb8888 ============= [18:12:15] [PASSED] single_pixel_source_buffer [18:12:15] [PASSED] single_pixel_clip_rectangle [18:12:15] [PASSED] well_known_colors [18:12:15] [PASSED] destination_pitch [18:12:15] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 ========= [18:12:15] =========== drm_test_fb_xrgb8888_to_xrgb2101010 =========== [18:12:15] [PASSED] single_pixel_source_buffer [18:12:15] [PASSED] single_pixel_clip_rectangle [18:12:15] [PASSED] well_known_colors [18:12:15] [PASSED] destination_pitch [18:12:15] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 ======= [18:12:15] =========== drm_test_fb_xrgb8888_to_argb2101010 =========== [18:12:15] [PASSED] single_pixel_source_buffer [18:12:15] [PASSED] single_pixel_clip_rectangle [18:12:15] [PASSED] well_known_colors [18:12:15] [PASSED] destination_pitch [18:12:15] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 ======= [18:12:15] ============== drm_test_fb_xrgb8888_to_mono =============== [18:12:15] [PASSED] single_pixel_source_buffer [18:12:15] [PASSED] single_pixel_clip_rectangle [18:12:15] [PASSED] well_known_colors [18:12:15] [PASSED] destination_pitch [18:12:15] ========== [PASSED] drm_test_fb_xrgb8888_to_mono =========== [18:12:15] ==================== drm_test_fb_swab ===================== [18:12:15] [PASSED] single_pixel_source_buffer [18:12:15] [PASSED] single_pixel_clip_rectangle [18:12:15] [PASSED] well_known_colors [18:12:15] [PASSED] destination_pitch [18:12:15] ================ [PASSED] drm_test_fb_swab ================= [18:12:15] ============ drm_test_fb_xrgb8888_to_xbgr8888 ============= [18:12:15] [PASSED] single_pixel_source_buffer [18:12:15] [PASSED] single_pixel_clip_rectangle [18:12:15] [PASSED] well_known_colors [18:12:15] [PASSED] destination_pitch [18:12:15] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 ========= [18:12:15] ============ drm_test_fb_xrgb8888_to_abgr8888 ============= [18:12:15] [PASSED] single_pixel_source_buffer [18:12:15] [PASSED] single_pixel_clip_rectangle [18:12:15] [PASSED] well_known_colors [18:12:15] [PASSED] destination_pitch [18:12:15] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 ========= [18:12:15] ================= drm_test_fb_clip_offset ================= [18:12:15] [PASSED] pass through [18:12:15] [PASSED] horizontal offset [18:12:15] [PASSED] vertical offset [18:12:15] [PASSED] horizontal and vertical offset [18:12:15] [PASSED] horizontal offset (custom pitch) [18:12:15] [PASSED] vertical offset (custom pitch) [18:12:15] [PASSED] horizontal and vertical offset (custom pitch) [18:12:15] ============= [PASSED] drm_test_fb_clip_offset ============= [18:12:15] =================== drm_test_fb_memcpy ==================== [18:12:15] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258) [18:12:15] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258) [18:12:15] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559) [18:12:15] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258) [18:12:15] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258) [18:12:15] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559) [18:12:15] [PASSED] well_known_colors: XB24 little-endian (0x34324258) [18:12:15] [PASSED] well_known_colors: XRA8 little-endian (0x38415258) [18:12:15] [PASSED] well_known_colors: YU24 little-endian (0x34325559) [18:12:15] [PASSED] destination_pitch: XB24 little-endian (0x34324258) [18:12:15] [PASSED] destination_pitch: XRA8 little-endian (0x38415258) [18:12:15] [PASSED] destination_pitch: YU24 little-endian (0x34325559) [18:12:15] =============== [PASSED] drm_test_fb_memcpy ================ [18:12:15] ============= [PASSED] drm_format_helper_test ============== [18:12:15] ================= drm_format (18 subtests) ================= [18:12:15] [PASSED] drm_test_format_block_width_invalid [18:12:15] [PASSED] drm_test_format_block_width_one_plane [18:12:15] [PASSED] drm_test_format_block_width_two_plane [18:12:15] [PASSED] drm_test_format_block_width_three_plane [18:12:15] [PASSED] drm_test_format_block_width_tiled [18:12:15] [PASSED] drm_test_format_block_height_invalid [18:12:15] [PASSED] drm_test_format_block_height_one_plane [18:12:15] [PASSED] drm_test_format_block_height_two_plane [18:12:15] [PASSED] drm_test_format_block_height_three_plane [18:12:15] [PASSED] drm_test_format_block_height_tiled [18:12:15] [PASSED] drm_test_format_min_pitch_invalid [18:12:15] [PASSED] drm_test_format_min_pitch_one_plane_8bpp [18:12:15] [PASSED] drm_test_format_min_pitch_one_plane_16bpp [18:12:15] [PASSED] drm_test_format_min_pitch_one_plane_24bpp [18:12:15] [PASSED] drm_test_format_min_pitch_one_plane_32bpp [18:12:15] [PASSED] drm_test_format_min_pitch_two_plane [18:12:15] [PASSED] drm_test_format_min_pitch_three_plane_8bpp [18:12:15] [PASSED] drm_test_format_min_pitch_tiled [18:12:15] =================== [PASSED] drm_format ==================== [18:12:15] ============== drm_framebuffer (10 subtests) =============== [18:12:15] ========== drm_test_framebuffer_check_src_coords ========== [18:12:15] [PASSED] Success: source fits into fb [18:12:15] [PASSED] Fail: overflowing fb with x-axis coordinate [18:12:15] [PASSED] Fail: overflowing fb with y-axis coordinate [18:12:15] [PASSED] Fail: overflowing fb with source width [18:12:15] [PASSED] Fail: overflowing fb with source height [18:12:15] ====== [PASSED] drm_test_framebuffer_check_src_coords ====== [18:12:15] [PASSED] drm_test_framebuffer_cleanup [18:12:15] =============== drm_test_framebuffer_create =============== [18:12:15] [PASSED] ABGR8888 normal sizes [18:12:15] [PASSED] ABGR8888 max sizes [18:12:15] [PASSED] ABGR8888 pitch greater than min required [18:12:15] [PASSED] ABGR8888 pitch less than min required [18:12:15] [PASSED] ABGR8888 Invalid width [18:12:15] [PASSED] ABGR8888 Invalid buffer handle [18:12:15] [PASSED] No pixel format [18:12:15] [PASSED] ABGR8888 Width 0 [18:12:15] [PASSED] ABGR8888 Height 0 [18:12:15] [PASSED] ABGR8888 Out of bound height * pitch combination [18:12:15] [PASSED] ABGR8888 Large buffer offset [18:12:15] [PASSED] ABGR8888 Buffer offset for inexistent plane [18:12:15] [PASSED] ABGR8888 Invalid flag [18:12:15] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers [18:12:15] [PASSED] ABGR8888 Valid buffer modifier [18:12:15] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE) [18:12:15] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS [18:12:15] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS [18:12:15] [PASSED] NV12 Normal sizes [18:12:15] [PASSED] NV12 Max sizes [18:12:15] [PASSED] NV12 Invalid pitch [18:12:15] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag [18:12:15] [PASSED] NV12 different modifier per-plane [18:12:15] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE [18:12:15] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS [18:12:15] [PASSED] NV12 Modifier for inexistent plane [18:12:15] [PASSED] NV12 Handle for inexistent plane [18:12:15] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS [18:12:15] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier [18:12:15] [PASSED] YVU420 Normal sizes [18:12:15] [PASSED] YVU420 Max sizes [18:12:15] [PASSED] YVU420 Invalid pitch [18:12:15] [PASSED] YVU420 Different pitches [18:12:15] [PASSED] YVU420 Different buffer offsets/pitches [18:12:15] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS [18:12:15] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS [18:12:15] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS [18:12:15] [PASSED] YVU420 Valid modifier [18:12:15] [PASSED] YVU420 Different modifiers per plane [18:12:15] [PASSED] YVU420 Modifier for inexistent plane [18:12:15] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR) [18:12:15] [PASSED] X0L2 Normal sizes [18:12:15] [PASSED] X0L2 Max sizes [18:12:15] [PASSED] X0L2 Invalid pitch [18:12:15] [PASSED] X0L2 Pitch greater than minimum required [18:12:15] [PASSED] X0L2 Handle for inexistent plane [18:12:15] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set [18:12:15] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set [18:12:15] [PASSED] X0L2 Valid modifier [18:12:15] [PASSED] X0L2 Modifier for inexistent plane [18:12:15] =========== [PASSED] drm_test_framebuffer_create =========== [18:12:15] [PASSED] drm_test_framebuffer_free [18:12:15] [PASSED] drm_test_framebuffer_init [18:12:15] [PASSED] drm_test_framebuffer_init_bad_format [18:12:15] [PASSED] drm_test_framebuffer_init_dev_mismatch [18:12:15] [PASSED] drm_test_framebuffer_lookup [18:12:15] [PASSED] drm_test_framebuffer_lookup_inexistent [18:12:15] [PASSED] drm_test_framebuffer_modifiers_not_supported [18:12:15] ================= [PASSED] drm_framebuffer ================= [18:12:15] ================ drm_gem_shmem (8 subtests) ================ [18:12:15] [PASSED] drm_gem_shmem_test_obj_create [18:12:15] [PASSED] drm_gem_shmem_test_obj_create_private [18:12:15] [PASSED] drm_gem_shmem_test_pin_pages [18:12:15] [PASSED] drm_gem_shmem_test_vmap [18:12:15] [PASSED] drm_gem_shmem_test_get_sg_table [18:12:15] [PASSED] drm_gem_shmem_test_get_pages_sgt [18:12:15] [PASSED] drm_gem_shmem_test_madvise [18:12:15] [PASSED] drm_gem_shmem_test_purge [18:12:15] ================== [PASSED] drm_gem_shmem ================== [18:12:15] === drm_atomic_helper_connector_hdmi_check (29 subtests) === [18:12:15] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode [18:12:15] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1 [18:12:15] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode [18:12:15] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1 [18:12:15] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode [18:12:15] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1 [18:12:15] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420 ======= [18:12:15] [PASSED] Automatic [18:12:15] [PASSED] Full [18:12:15] [PASSED] Limited 16:235 [18:12:15] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 === [18:12:15] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed [18:12:15] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed [18:12:15] [PASSED] drm_test_check_disable_connector [18:12:15] [PASSED] drm_test_check_hdmi_funcs_reject_rate [18:12:15] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb [18:12:15] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420 [18:12:15] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422 [18:12:15] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420 [18:12:15] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420 [18:12:15] [PASSED] drm_test_check_output_bpc_crtc_mode_changed [18:12:15] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed [18:12:15] [PASSED] drm_test_check_output_bpc_dvi [18:12:15] [PASSED] drm_test_check_output_bpc_format_vic_1 [18:12:15] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only [18:12:15] [PASSED] drm_test_check_output_bpc_format_display_rgb_only [18:12:15] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only [18:12:15] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only [18:12:15] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc [18:12:15] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc [18:12:15] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc [18:12:15] ============ drm_test_check_hdmi_color_format ============= [18:12:15] [PASSED] AUTO -> RGB [18:12:15] [PASSED] YCBCR422 -> YUV422 [18:12:15] [PASSED] YCBCR420 -> YUV420 [18:12:15] [PASSED] YCBCR444 -> YUV444 [18:12:15] [PASSED] RGB -> RGB [18:12:15] ======== [PASSED] drm_test_check_hdmi_color_format ========= [18:12:15] ======== drm_test_check_hdmi_color_format_420_only ======== [18:12:15] [PASSED] RGB should fail [18:12:15] [PASSED] YUV444 should fail [18:12:15] [PASSED] YUV422 should fail [18:12:15] [PASSED] YUV420 should work [18:12:15] ==== [PASSED] drm_test_check_hdmi_color_format_420_only ==== [18:12:15] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ====== [18:12:15] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ==== [18:12:15] [PASSED] drm_test_check_broadcast_rgb_value [18:12:15] [PASSED] drm_test_check_bpc_8_value [18:12:15] [PASSED] drm_test_check_bpc_10_value [18:12:15] [PASSED] drm_test_check_bpc_12_value [18:12:15] [PASSED] drm_test_check_format_value [18:12:15] [PASSED] drm_test_check_tmds_char_value [18:12:15] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ====== [18:12:15] = drm_atomic_helper_connector_hdmi_mode_valid (7 subtests) = [18:12:15] [PASSED] drm_test_check_mode_valid [18:12:15] [PASSED] drm_test_check_mode_valid_reject [18:12:15] [PASSED] drm_test_check_mode_valid_reject_rate [18:12:15] [PASSED] drm_test_check_mode_valid_reject_max_clock [18:12:15] [PASSED] drm_test_check_mode_valid_yuv420_only_max_clock [18:12:15] [PASSED] drm_test_check_mode_valid_reject_yuv420_only_connector [18:12:15] [PASSED] drm_test_check_mode_valid_accept_yuv420_also_connector_rgb [18:12:15] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid === [18:12:15] = drm_atomic_helper_connector_hdmi_infoframes (5 subtests) = [18:12:15] [PASSED] drm_test_check_infoframes [18:12:15] [PASSED] drm_test_check_reject_avi_infoframe [18:12:15] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_8 [18:12:15] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_10 [18:12:15] [PASSED] drm_test_check_reject_audio_infoframe [18:12:15] === [PASSED] drm_atomic_helper_connector_hdmi_infoframes === [18:12:15] ================= drm_managed (2 subtests) ================= [18:12:15] [PASSED] drm_test_managed_release_action [18:12:15] [PASSED] drm_test_managed_run_action [18:12:15] =================== [PASSED] drm_managed =================== [18:12:15] =================== drm_mm (6 subtests) ==================== [18:12:15] [PASSED] drm_test_mm_init [18:12:15] [PASSED] drm_test_mm_debug [18:12:15] [PASSED] drm_test_mm_align32 [18:12:15] [PASSED] drm_test_mm_align64 [18:12:15] [PASSED] drm_test_mm_lowest [18:12:15] [PASSED] drm_test_mm_highest [18:12:15] ===================== [PASSED] drm_mm ====================== [18:12:15] ============= drm_modes_analog_tv (5 subtests) ============= [18:12:15] [PASSED] drm_test_modes_analog_tv_mono_576i [18:12:15] [PASSED] drm_test_modes_analog_tv_ntsc_480i [18:12:15] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined [18:12:15] [PASSED] drm_test_modes_analog_tv_pal_576i [18:12:15] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined [18:12:15] =============== [PASSED] drm_modes_analog_tv =============== [18:12:15] ============== drm_plane_helper (2 subtests) =============== [18:12:15] =============== drm_test_check_plane_state ================ [18:12:15] [PASSED] clipping_simple [18:12:15] [PASSED] clipping_rotate_reflect [18:12:15] [PASSED] positioning_simple [18:12:15] [PASSED] upscaling [18:12:15] [PASSED] downscaling [18:12:15] [PASSED] rounding1 [18:12:15] [PASSED] rounding2 [18:12:15] [PASSED] rounding3 [18:12:15] [PASSED] rounding4 [18:12:15] =========== [PASSED] drm_test_check_plane_state ============ [18:12:15] =========== drm_test_check_invalid_plane_state ============ [18:12:15] [PASSED] positioning_invalid [18:12:15] [PASSED] upscaling_invalid [18:12:15] [PASSED] downscaling_invalid [18:12:15] ======= [PASSED] drm_test_check_invalid_plane_state ======== [18:12:15] ================ [PASSED] drm_plane_helper ================= [18:12:15] ====== drm_connector_helper_tv_get_modes (1 subtest) ======= [18:12:15] ====== drm_test_connector_helper_tv_get_modes_check ======= [18:12:15] [PASSED] None [18:12:15] [PASSED] PAL [18:12:15] [PASSED] NTSC [18:12:15] [PASSED] Both, NTSC Default [18:12:15] [PASSED] Both, PAL Default [18:12:15] [PASSED] Both, NTSC Default, with PAL on command-line [18:12:15] [PASSED] Both, PAL Default, with NTSC on command-line [18:12:15] == [PASSED] drm_test_connector_helper_tv_get_modes_check === [18:12:15] ======== [PASSED] drm_connector_helper_tv_get_modes ======== [18:12:15] ================== drm_rect (9 subtests) =================== [18:12:15] [PASSED] drm_test_rect_clip_scaled_div_by_zero [18:12:15] [PASSED] drm_test_rect_clip_scaled_not_clipped [18:12:15] [PASSED] drm_test_rect_clip_scaled_clipped [18:12:15] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned [18:12:15] ================= drm_test_rect_intersect ================= [18:12:15] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0 [18:12:15] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1 [18:12:15] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0 [18:12:15] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1 [18:12:15] [PASSED] right x left: 2x1+0+0 x 3x1+1+0 [18:12:15] [PASSED] left x right: 3x1+1+0 x 2x1+0+0 [18:12:15] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1 [18:12:15] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0 [18:12:15] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1 [18:12:15] [PASSED] touching side: 1x1+0+0 x 1x1+1+0 [18:12:15] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0 [18:12:15] [PASSED] inside another: 2x2+0+0 x 1x1+1+1 [18:12:15] [PASSED] far away: 1x1+0+0 x 1x1+3+6 [18:12:15] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10 [18:12:15] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10 [18:12:15] ============= [PASSED] drm_test_rect_intersect ============= [18:12:15] ================ drm_test_rect_calc_hscale ================ [18:12:15] [PASSED] normal use [18:12:15] [PASSED] out of max range [18:12:15] [PASSED] out of min range [18:12:15] [PASSED] zero dst [18:12:15] [PASSED] negative src [18:12:15] [PASSED] negative dst [18:12:15] ============ [PASSED] drm_test_rect_calc_hscale ============ [18:12:15] ================ drm_test_rect_calc_vscale ================ [18:12:15] [PASSED] normal use [18:12:15] [PASSED] out of max range [18:12:15] [PASSED] out of min range [18:12:15] [PASSED] zero dst [18:12:15] [PASSED] negative src [18:12:15] [PASSED] negative dst [18:12:15] ============ [PASSED] drm_test_rect_calc_vscale ============ [18:12:15] ================== drm_test_rect_rotate =================== [18:12:15] [PASSED] reflect-x [18:12:15] [PASSED] reflect-y [18:12:15] [PASSED] rotate-0 [18:12:15] [PASSED] rotate-90 [18:12:15] [PASSED] rotate-180 [18:12:15] [PASSED] rotate-270 [18:12:15] ============== [PASSED] drm_test_rect_rotate =============== [18:12:15] ================ drm_test_rect_rotate_inv ================= [18:12:15] [PASSED] reflect-x [18:12:15] [PASSED] reflect-y [18:12:15] [PASSED] rotate-0 [18:12:15] [PASSED] rotate-90 [18:12:15] [PASSED] rotate-180 [18:12:15] [PASSED] rotate-270 [18:12:15] ============ [PASSED] drm_test_rect_rotate_inv ============= [18:12:15] ==================== [PASSED] drm_rect ===================== [18:12:15] ============ drm_sysfb_modeset_test (1 subtest) ============ [18:12:15] ============ drm_test_sysfb_build_fourcc_list ============= [18:12:15] [PASSED] no native formats [18:12:15] [PASSED] XRGB8888 as native format [18:12:15] [PASSED] remove duplicates [18:12:15] [PASSED] convert alpha formats [18:12:15] [PASSED] random formats [18:12:15] ======== [PASSED] drm_test_sysfb_build_fourcc_list ========= [18:12:15] ============= [PASSED] drm_sysfb_modeset_test ============== [18:12:15] ================== drm_fixp (2 subtests) =================== [18:12:15] [PASSED] drm_test_int2fixp [18:12:15] [PASSED] drm_test_sm2fixp [18:12:15] ==================== [PASSED] drm_fixp ===================== [18:12:15] ============================================================ [18:12:15] Testing complete. Ran 639 tests: passed: 639 [18:12:15] Elapsed time: 51.256s total, 1.725s configuring, 49.364s building, 0.159s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig [18:12:16] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [18:12:17] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=25 [18:12:27] Starting KUnit Kernel (1/1)... [18:12:27] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [18:12:27] ================= ttm_device (5 subtests) ================== [18:12:27] [PASSED] ttm_device_init_basic [18:12:27] [PASSED] ttm_device_init_multiple [18:12:27] [PASSED] ttm_device_fini_basic [18:12:27] [PASSED] ttm_device_init_no_vma_man [18:12:27] ================== ttm_device_init_pools ================== [18:12:27] [PASSED] No DMA allocations, no DMA32 required [18:12:27] [PASSED] DMA allocations, DMA32 required [18:12:27] [PASSED] No DMA allocations, DMA32 required [18:12:27] [PASSED] DMA allocations, no DMA32 required [18:12:27] ============== [PASSED] ttm_device_init_pools ============== [18:12:27] =================== [PASSED] ttm_device ==================== [18:12:27] ================== ttm_pool (8 subtests) =================== [18:12:27] ================== ttm_pool_alloc_basic =================== [18:12:27] [PASSED] One page [18:12:27] [PASSED] More than one page [18:12:27] [PASSED] Above the allocation limit [18:12:27] [PASSED] One page, with coherent DMA mappings enabled [18:12:27] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [18:12:27] ============== [PASSED] ttm_pool_alloc_basic =============== [18:12:27] ============== ttm_pool_alloc_basic_dma_addr ============== [18:12:27] [PASSED] One page [18:12:27] [PASSED] More than one page [18:12:27] [PASSED] Above the allocation limit [18:12:27] [PASSED] One page, with coherent DMA mappings enabled [18:12:27] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [18:12:27] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ========== [18:12:27] [PASSED] ttm_pool_alloc_order_caching_match [18:12:27] [PASSED] ttm_pool_alloc_caching_mismatch [18:12:27] [PASSED] ttm_pool_alloc_order_mismatch [18:12:27] [PASSED] ttm_pool_free_dma_alloc [18:12:27] [PASSED] ttm_pool_free_no_dma_alloc [18:12:27] [PASSED] ttm_pool_fini_basic [18:12:27] ==================== [PASSED] ttm_pool ===================== [18:12:27] ================ ttm_resource (8 subtests) ================= [18:12:27] ================= ttm_resource_init_basic ================= [18:12:27] [PASSED] Init resource in TTM_PL_SYSTEM [18:12:27] [PASSED] Init resource in TTM_PL_VRAM [18:12:27] [PASSED] Init resource in a private placement [18:12:27] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags [18:12:27] ============= [PASSED] ttm_resource_init_basic ============= [18:12:27] [PASSED] ttm_resource_init_pinned [18:12:27] [PASSED] ttm_resource_fini_basic [18:12:27] [PASSED] ttm_resource_manager_init_basic [18:12:27] [PASSED] ttm_resource_manager_usage_basic [18:12:27] [PASSED] ttm_resource_manager_set_used_basic [18:12:27] [PASSED] ttm_sys_man_alloc_basic [18:12:27] [PASSED] ttm_sys_man_free_basic [18:12:27] ================== [PASSED] ttm_resource =================== [18:12:27] =================== ttm_tt (15 subtests) =================== [18:12:27] ==================== ttm_tt_init_basic ==================== [18:12:27] [PASSED] Page-aligned size [18:12:27] [PASSED] Extra pages requested [18:12:27] ================ [PASSED] ttm_tt_init_basic ================ [18:12:27] [PASSED] ttm_tt_init_misaligned [18:12:27] [PASSED] ttm_tt_fini_basic [18:12:27] [PASSED] ttm_tt_fini_sg [18:12:27] [PASSED] ttm_tt_fini_shmem [18:12:27] [PASSED] ttm_tt_create_basic [18:12:27] [PASSED] ttm_tt_create_invalid_bo_type [18:12:27] [PASSED] ttm_tt_create_ttm_exists [18:12:27] [PASSED] ttm_tt_create_failed [18:12:27] [PASSED] ttm_tt_destroy_basic [18:12:27] [PASSED] ttm_tt_populate_null_ttm [18:12:27] [PASSED] ttm_tt_populate_populated_ttm [18:12:27] [PASSED] ttm_tt_unpopulate_basic [18:12:27] [PASSED] ttm_tt_unpopulate_empty_ttm [18:12:27] [PASSED] ttm_tt_swapin_basic [18:12:27] ===================== [PASSED] ttm_tt ====================== [18:12:27] =================== ttm_bo (14 subtests) =================== [18:12:27] =========== ttm_bo_reserve_optimistic_no_ticket =========== [18:12:27] [PASSED] Cannot be interrupted and sleeps [18:12:27] [PASSED] Cannot be interrupted, locks straight away [18:12:27] [PASSED] Can be interrupted, sleeps [18:12:27] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket ======= [18:12:27] [PASSED] ttm_bo_reserve_locked_no_sleep [18:12:27] [PASSED] ttm_bo_reserve_no_wait_ticket [18:12:27] [PASSED] ttm_bo_reserve_double_resv [18:12:27] [PASSED] ttm_bo_reserve_interrupted [18:12:27] [PASSED] ttm_bo_reserve_deadlock [18:12:27] [PASSED] ttm_bo_unreserve_basic [18:12:27] [PASSED] ttm_bo_unreserve_pinned [18:12:27] [PASSED] ttm_bo_unreserve_bulk [18:12:27] [PASSED] ttm_bo_fini_basic [18:12:27] [PASSED] ttm_bo_fini_shared_resv [18:12:27] [PASSED] ttm_bo_pin_basic [18:12:27] [PASSED] ttm_bo_pin_unpin_resource [18:12:27] [PASSED] ttm_bo_multiple_pin_one_unpin [18:12:27] ===================== [PASSED] ttm_bo ====================== [18:12:27] ============== ttm_bo_validate (22 subtests) =============== [18:12:27] ============== ttm_bo_init_reserved_sys_man =============== [18:12:27] [PASSED] Buffer object for userspace [18:12:27] [PASSED] Kernel buffer object [18:12:27] [PASSED] Shared buffer object [18:12:27] ========== [PASSED] ttm_bo_init_reserved_sys_man =========== [18:12:27] ============== ttm_bo_init_reserved_mock_man ============== [18:12:27] [PASSED] Buffer object for userspace [18:12:27] [PASSED] Kernel buffer object [18:12:27] [PASSED] Shared buffer object [18:12:27] ========== [PASSED] ttm_bo_init_reserved_mock_man ========== [18:12:27] [PASSED] ttm_bo_init_reserved_resv [18:12:27] ================== ttm_bo_validate_basic ================== [18:12:27] [PASSED] Buffer object for userspace [18:12:27] [PASSED] Kernel buffer object [18:12:27] [PASSED] Shared buffer object [18:12:27] ============== [PASSED] ttm_bo_validate_basic ============== [18:12:27] [PASSED] ttm_bo_validate_invalid_placement [18:12:27] ============= ttm_bo_validate_same_placement ============== [18:12:27] [PASSED] System manager [18:12:27] [PASSED] VRAM manager [18:12:27] ========= [PASSED] ttm_bo_validate_same_placement ========== [18:12:27] [PASSED] ttm_bo_validate_failed_alloc [18:12:27] [PASSED] ttm_bo_validate_pinned [18:12:27] [PASSED] ttm_bo_validate_busy_placement [18:12:27] ================ ttm_bo_validate_multihop ================= [18:12:27] [PASSED] Buffer object for userspace [18:12:27] [PASSED] Kernel buffer object [18:12:27] [PASSED] Shared buffer object [18:12:27] ============ [PASSED] ttm_bo_validate_multihop ============= [18:12:27] ========== ttm_bo_validate_no_placement_signaled ========== [18:12:27] [PASSED] Buffer object in system domain, no page vector [18:12:27] [PASSED] Buffer object in system domain with an existing page vector [18:12:27] ====== [PASSED] ttm_bo_validate_no_placement_signaled ====== [18:12:27] ======== ttm_bo_validate_no_placement_not_signaled ======== [18:12:27] [PASSED] Buffer object for userspace [18:12:27] [PASSED] Kernel buffer object [18:12:27] [PASSED] Shared buffer object [18:12:27] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ==== [18:12:27] [PASSED] ttm_bo_validate_move_fence_signaled [18:12:27] ========= ttm_bo_validate_move_fence_not_signaled ========= [18:12:27] [PASSED] Waits for GPU [18:12:27] [PASSED] Tries to lock straight away [18:12:27] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled ===== [18:12:27] [PASSED] ttm_bo_validate_swapout [18:12:27] [PASSED] ttm_bo_validate_happy_evict [18:12:27] [PASSED] ttm_bo_validate_all_pinned_evict [18:12:27] [PASSED] ttm_bo_validate_allowed_only_evict [18:12:27] [PASSED] ttm_bo_validate_deleted_evict [18:12:27] [PASSED] ttm_bo_validate_busy_domain_evict [18:12:27] [PASSED] ttm_bo_validate_evict_gutting [18:12:27] [PASSED] ttm_bo_validate_recrusive_evict [18:12:27] ================= [PASSED] ttm_bo_validate ================= [18:12:27] ============================================================ [18:12:27] Testing complete. Ran 102 tests: passed: 102 [18:12:27] Elapsed time: 11.558s total, 1.734s configuring, 9.558s building, 0.233s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
Patchwork
CI✓ Xe.CI.BAT: success for GuC paging engine support (rev6)
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: GuC paging engine support (rev6)
URL : https://patchwork.freedesktop.org/series/166960/
State : success
== Summary ==
CI Bug Log - changes from xe-5242-c0a463345cc689fec0dbdea86cd5729123676e18_BAT -> xe-pw-166960v6_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Changes
-------
No changes found
Build changes
-------------
* Linux: xe-5242-c0a463345cc689fec0dbdea86cd5729123676e18 -> xe-pw-166960v6
IGT_8959: 77337ca2d2dd470f3b32f1cf4760b0e79a52e2b7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-5242-c0a463345cc689fec0dbdea86cd5729123676e18: c0a463345cc689fec0dbdea86cd5729123676e18
xe-pw-166960v6: 166960v6
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/index.html
Patchwork
CI✓ Xe.CI.FULL: success for GuC paging engine support (rev6)
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: GuC paging engine support (rev6)
URL : https://patchwork.freedesktop.org/series/166960/
State : success
== Summary ==
CI Bug Log - changes from xe-5242-c0a463345cc689fec0dbdea86cd5729123676e18_FULL -> xe-pw-166960v6_FULL
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (2 -> 2)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in xe-pw-166960v6_FULL that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-bmg: [PASS][1] -> [FAIL][2] ([Intel XE#3718] / [Intel XE#6078])
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5242-c0a463345cc689fec0dbdea86cd5729123676e18/shard-bmg-8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-7/igt@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip@pipe-c-dp-2:
- shard-bmg: [PASS][3] -> [FAIL][4] ([Intel XE#6078])
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5242-c0a463345cc689fec0dbdea86cd5729123676e18/shard-bmg-8/igt@kms_async_flips@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-7/igt@kms_async_flips@[email protected]
* igt@kms_big_fb@x-tiled-64bpp-rotate-270:
- shard-bmg: NOTRUN -> [SKIP][5] ([Intel XE#2327]) +2 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_big_fb@y-tiled-64bpp-rotate-90:
- shard-bmg: NOTRUN -> [SKIP][6] ([Intel XE#1124]) +3 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_bw@connected-linear-tiling-3-displays-target-3840x2160p:
- shard-bmg: NOTRUN -> [SKIP][7] ([Intel XE#7679])
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_bw@linear-tiling-1-displays-target-3840x2160p:
- shard-bmg: NOTRUN -> [SKIP][8] ([Intel XE#367])
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_ccs@crc-sprite-planes-basic-y-tiled-gen12-rc-ccs:
- shard-bmg: NOTRUN -> [SKIP][9] ([Intel XE#2887]) +6 other tests skip
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_chamelium_color@gamma:
- shard-bmg: NOTRUN -> [SKIP][10] ([Intel XE#2325] / [Intel XE#7358])
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_chamelium_hpd@hdmi-hpd-fast:
- shard-bmg: NOTRUN -> [SKIP][11] ([Intel XE#2252]) +1 other test skip
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_content_protection@dp-mst-lic-type-0-hdcp14:
- shard-bmg: NOTRUN -> [SKIP][12] ([Intel XE#6974])
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_cursor_crc@cursor-onscreen-256x85:
- shard-bmg: NOTRUN -> [SKIP][13] ([Intel XE#2320]) +4 other tests skip
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_dp_linktrain_fallback@dsc-fallback:
- shard-bmg: NOTRUN -> [SKIP][14] ([Intel XE#4331] / [Intel XE#7227])
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_dsc@dsc-fractional-bpp-with-bpc-bigjoiner:
- shard-bmg: NOTRUN -> [SKIP][15] ([Intel XE#8265])
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_feature_discovery@chamelium:
- shard-bmg: NOTRUN -> [SKIP][16] ([Intel XE#2372] / [Intel XE#7359])
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-lnl: [PASS][17] -> [FAIL][18] ([Intel XE#301]) +1 other test fail
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5242-c0a463345cc689fec0dbdea86cd5729123676e18/shard-lnl-3/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-lnl-4/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling:
- shard-bmg: NOTRUN -> [SKIP][19] ([Intel XE#7178] / [Intel XE#7351])
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling:
- shard-bmg: NOTRUN -> [SKIP][20] ([Intel XE#7178] / [Intel XE#7349])
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling.html
* igt@kms_frontbuffer_tracking@drrs-rgb101010-draw-blt:
- shard-bmg: NOTRUN -> [SKIP][21] ([Intel XE#2311]) +16 other tests skip
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-bmg: NOTRUN -> [SKIP][22] ([Intel XE#4141]) +3 other tests skip
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbchdr-argb161616f-draw-render:
- shard-bmg: NOTRUN -> [SKIP][23] ([Intel XE#7061]) +3 other tests skip
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_frontbuffer_tracking@psrhdr-2p-primscrn-cur-indfb-draw-blt:
- shard-bmg: NOTRUN -> [SKIP][24] ([Intel XE#2313]) +19 other tests skip
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@kms_frontbuffer_tracking@psrhdr-2p-primscrn-cur-indfb-draw-blt.html
* igt@kms_hdr@static-toggle-dpms@pipe-a-hdmi-a-3-xrgb2101010:
- shard-bmg: [PASS][25] -> [SKIP][26] ([Intel XE#7915]) +1 other test skip
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5242-c0a463345cc689fec0dbdea86cd5729123676e18/shard-bmg-10/igt@kms_hdr@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-8/igt@kms_hdr@[email protected]
* igt@kms_joiner@basic-max-non-joiner:
- shard-bmg: NOTRUN -> [SKIP][27] ([Intel XE#4298] / [Intel XE#5873])
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_joiner@invalid-modeset-big-joiner:
- shard-bmg: NOTRUN -> [SKIP][28] ([Intel XE#6901])
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_plane@pixel-format-4-tiled-dg2-rc-ccs-modifier:
- shard-bmg: NOTRUN -> [SKIP][29] ([Intel XE#7283])
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_plane_scaling@planes-downscale-factor-0-75@pipe-a:
- shard-bmg: NOTRUN -> [SKIP][30] ([Intel XE#2763] / [Intel XE#6886]) +4 other tests skip
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@kms_plane_scaling@[email protected]
* igt@kms_psr2_sf@pr-cursor-plane-move-continuous-sf:
- shard-bmg: NOTRUN -> [SKIP][31] ([Intel XE#1489])
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_psr@fbc-pr-suspend:
- shard-bmg: NOTRUN -> [SKIP][32] ([Intel XE#2234] / [Intel XE#2850]) +5 other tests skip
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_rotation_crc@bad-pixel-format:
- shard-bmg: NOTRUN -> [SKIP][33] ([Intel XE#3904] / [Intel XE#7342]) +1 other test skip
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_sharpness_filter@filter-scaler-downscale:
- shard-bmg: NOTRUN -> [SKIP][34] ([Intel XE#6503])
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_vrr@flip-basic:
- shard-bmg: NOTRUN -> [SKIP][35] ([Intel XE#1499])
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@xe_eudebug@basic-vm-bind-metadata-discovery:
- shard-bmg: NOTRUN -> [SKIP][36] ([Intel XE#7636]) +3 other tests skip
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@xe_exec_basic@multigpu-many-execqueues-many-vm-null-defer-bind:
- shard-bmg: NOTRUN -> [SKIP][37] ([Intel XE#2322] / [Intel XE#7372]) +2 other tests skip
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@xe_exec_basic@multigpu-many-execqueues-many-vm-null-defer-bind.html
* igt@xe_exec_fault_mode@twice-multi-queue:
- shard-bmg: NOTRUN -> [SKIP][38] ([Intel XE#7136]) +1 other test skip
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@xe_exec_multi_queue@two-queues-priority-smem:
- shard-bmg: NOTRUN -> [SKIP][39] ([Intel XE#6874]) +8 other tests skip
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@xe_exec_reset@multi-queue-cat-error-on-secondary:
- shard-bmg: NOTRUN -> [SKIP][40] ([Intel XE#7866])
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@xe_exec_threads@threads-multi-queue-mixed-userptr-invalidate:
- shard-bmg: NOTRUN -> [SKIP][41] ([Intel XE#7138]) +1 other test skip
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@xe_exec_threads@threads-multi-queue-mixed-userptr-invalidate.html
* igt@xe_multigpu_svm@mgpu-atomic-op-prefetch:
- shard-bmg: NOTRUN -> [SKIP][42] ([Intel XE#6964])
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@xe_page_reclaim@binds-1g-partial:
- shard-bmg: NOTRUN -> [SKIP][43] ([Intel XE#7793]) +1 other test skip
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@xe_pat@pat-sw-hw-compare:
- shard-bmg: NOTRUN -> [FAIL][44] ([Intel XE#7695])
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@xe_pxp@pxp-termination-key-update-post-termination-irq:
- shard-bmg: NOTRUN -> [SKIP][45] ([Intel XE#4733] / [Intel XE#7417]) +1 other test skip
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@xe_query@multigpu-query-topology-l3-bank-mask:
- shard-bmg: NOTRUN -> [SKIP][46] ([Intel XE#944])
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
#### Possible fixes ####
* igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic:
- shard-bmg: [INCOMPLETE][47] ([Intel XE#8151]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5242-c0a463345cc689fec0dbdea86cd5729123676e18/shard-bmg-8/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_plane_alpha_blend@coverage-7efc:
- shard-bmg: [ABORT][49] ([Intel XE#7814] / [Intel XE#7893]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5242-c0a463345cc689fec0dbdea86cd5729123676e18/shard-bmg-5/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@[email protected]
* igt@kms_plane_scaling@planes-upscale-20x20@pipe-a:
- shard-bmg: [DMESG-WARN][51] -> [PASS][52] +7 other tests pass
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5242-c0a463345cc689fec0dbdea86cd5729123676e18/shard-bmg-5/igt@kms_plane_scaling@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-5/igt@kms_plane_scaling@[email protected]
* igt@kms_vrr@seamless-rr-switch-virtual@pipe-a-edp-1:
- shard-lnl: [FAIL][53] ([Intel XE#2142]) -> [PASS][54] +1 other test pass
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5242-c0a463345cc689fec0dbdea86cd5729123676e18/shard-lnl-1/igt@kms_vrr@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-lnl-1/igt@kms_vrr@[email protected]
#### Warnings ####
* igt@kms_tiled_display@basic-test-pattern:
- shard-bmg: [SKIP][55] ([Intel XE#2426] / [Intel XE#5848]) -> [FAIL][56] ([Intel XE#1729] / [Intel XE#7424])
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5242-c0a463345cc689fec0dbdea86cd5729123676e18/shard-bmg-6/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/shard-bmg-3/igt@[email protected]
[Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
[Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
[Intel XE#1499]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1499
[Intel XE#1729]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1729
[Intel XE#2142]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2142
[Intel XE#2234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2234
[Intel XE#2252]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2252
[Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2320]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2320
[Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
[Intel XE#2325]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2325
[Intel XE#2327]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2327
[Intel XE#2372]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2372
[Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426
[Intel XE#2763]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2763
[Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
[Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
[Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
[Intel XE#367]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/367
[Intel XE#3718]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3718
[Intel XE#3904]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3904
[Intel XE#4141]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4141
[Intel XE#4298]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4298
[Intel XE#4331]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4331
[Intel XE#4733]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4733
[Intel XE#5848]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5848
[Intel XE#5873]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5873
[Intel XE#6078]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6078
[Intel XE#6503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6503
[Intel XE#6874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6874
[Intel XE#6886]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6886
[Intel XE#6901]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6901
[Intel XE#6964]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6964
[Intel XE#6974]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6974
[Intel XE#7061]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7061
[Intel XE#7136]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7136
[Intel XE#7138]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7138
[Intel XE#7178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7178
[Intel XE#7227]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7227
[Intel XE#7283]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7283
[Intel XE#7342]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7342
[Intel XE#7349]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7349
[Intel XE#7351]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7351
[Intel XE#7358]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7358
[Intel XE#7359]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7359
[Intel XE#7372]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7372
[Intel XE#7417]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7417
[Intel XE#7424]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7424
[Intel XE#7636]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7636
[Intel XE#7679]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7679
[Intel XE#7695]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7695
[Intel XE#7793]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7793
[Intel XE#7814]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7814
[Intel XE#7866]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7866
[Intel XE#7893]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7893
[Intel XE#7915]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7915
[Intel XE#8151]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/8151
[Intel XE#8265]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/8265
[Intel XE#944]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/944
Build changes
-------------
* Linux: xe-5242-c0a463345cc689fec0dbdea86cd5729123676e18 -> xe-pw-166960v6
IGT_8959: 77337ca2d2dd470f3b32f1cf4760b0e79a52e2b7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-5242-c0a463345cc689fec0dbdea86cd5729123676e18: c0a463345cc689fec0dbdea86cd5729123676e18
xe-pw-166960v6: 166960v6
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-166960v6/index.html