Skip to contentSkip to conversation

staging: rtl8723bs: remove unused function declarations

PATCH Superseded Aditya Chari 2 participants 2 messages Jun 22 – Jun 23 Staging

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: remove unused function declarations

rtl8192c_translate_rx_signal_stuff() and rtl8192c_query_rx_desc_status() are declared in rtl8192c_recv.h but have no implementation and no caller anywhere in the kernel tree. They are leftover from when this driver was derived from Realtek's shared vendor codebase covering multiple chip families.

Verified via grep across the full tree that neither symbol is referenced outside this declaration, and confirmed via a full build of the module before and after removal that no warnings or errors are introduced.

This addresses the "find and remove any code for other chips that is left over" item in the driver's TODO file.

---
 drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 4 ----
 1 file changed, 4 deletions(-)
drivers/staging/rtl8723bs/include/rtl8192c_recv.h +0 -4
index e2e9aa03f..b63625ab4 100644
@@ -30,8 +30,4 @@ struct phy_stat {
 /*  Rx smooth factor */
 #define	Rx_Smooth_Factor (20)
 
-
-void rtl8192c_translate_rx_signal_stuff(union recv_frame *precvframe, struct phy_stat *pphy_status);
-void rtl8192c_query_rx_desc_status(union recv_frame *precvframe, struct recv_stat *pdesc);
-
 #endif
Signature · 1 line
2.53.0
#1 lore raw
Quoted 11 lines · Aditya Chari

rtl8192c_translate_rx_signal_stuff() and rtl8192c_query_rx_desc_status() are declared in rtl8192c_recv.h but have no implementation and no caller anywhere in the kernel tree. They are leftover from when this driver was derived from Realtek's shared vendor codebase covering multiple chip families.

Verified via grep across the full tree that neither symbol is referenced outside this declaration, and confirmed via a full build of the module before and after removal that no warnings or errors are introduced.

Quoted 5 lines

This addresses the "find and remove any code for other chips that is left over" item in the driver's TODO file.

---

You're working against an old tree. Work against linux-next or devel-next.

regards,
dan carpenter