Skip to contentSkip to conversation

Add device tree for NVIDIA VR-NVL BMC

PATCH In review Jacky Huang 3 participants 10 messages Jul 28 – Oct 16

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v4 cover Add device tree for NVIDIA VR-NVL BMC

This series adds the DT binding compatible and the device tree for the NVIDIA VR-NVL BMC, an Aspeed AST2600-based BMC for the Vera Rubin NVL compute platform.

Changes in v4:
- dts: address dt-check-style findings for property and child node ordering, required blank lines, and line length.
- dts: retain conventional multi-line block comments, which account for the remaining 8 mixed-indent findings.
- dts: retain 22 meaningful unused labels for source readability and future references. They can be removed if preferred.

Changes in v3:
- dts: reword the &mac0 comment per Andrew Lunn's feedback.

Changes in v2:
- dts: correct the compatible of the PDB I/O expander at 0x75 from nxp,pca9555 to nxp,pca9539 to match the actual part.
- Pick up Acked-by from Krzysztof Kozlowski on the binding.
- Pick up Reviewed-by from Andrew Lunn on the &mac0 and &mdio0 nodes.

v3: https://lore.kernel.org/all/[email protected]/
v2: https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/

Jacky Huang (2):
dt-bindings: arm: aspeed: Add NVIDIA VR-NVL BMC
ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

 .../bindings/arm/aspeed/aspeed.yaml           |   1 +
 arch/arm/boot/dts/aspeed/Makefile             |   1 +
 .../aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts   | 923 ++++++++++++++++++
 3 files changed, 925 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts
Signature · 1 line
2.43.0
#1 lore raw

PATCH v4 1/2 dt-bindings: arm: aspeed: Add NVIDIA VR-NVL BMC

Add NVIDIA's VR-NVL BMC board compatible.

---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
index dd7996960de3..ce893553cfc3 100644
@@ -114,6 +114,7 @@ properties:
               - jabil,rbp-bmc
               - nvidia,gb200nvl-bmc
               - nvidia,msx4-bmc
+              - nvidia,vr-nvl-bmc
               - qcom,dc-scm-v1-bmc
               - quanta,s6q-bmc
               - ufispace,ncplite-bmc
Signature · 1 line
2.43.0
#2 lore raw

PATCH v4 2/2 ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

In reply to Jacky Huang

Add the device tree for the Aspeed AST2600 BMC for NVIDIA's Vera Rubin NVL compute platform.

MAC0 uses phy-mode = "rgmii-id" because the on-board PHY supplies both RGMII internal delays. The matching U-Boot device tree does not enable SoC-side MAC clock delays, leaving the MAC internal delay at zero so the PHY-provided delay is not doubled by the MAC controller.

The corresponding U-Boot change has been submitted to openbmc/u-boot:

---
v4: address dt-check-style findings for property and child node ordering,
required blank lines, and line length. Retain 8 conventional multi-line block comments with mixed-indent and 22 meaningful unused labels for source readability and future references. They can be removed if preferred.

 arch/arm/boot/dts/aspeed/Makefile             |   1 +
 .../aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts   | 923 ++++++++++++++++++
 2 files changed, 924 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts
arch/arm/boot/dts/aspeed/Makefile +1 -0
index 6b68671f9379..07e10083a8bd 100644
@@ -65,6 +65,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-microsoft-olympus.dtb \
 	aspeed-bmc-nvidia-gb200nvl-bmc.dtb \
 	aspeed-bmc-nvidia-msx4-bmc.dtb \
+	aspeed-bmc-nvidia-vr-nvl-bmc.dtb \
 	aspeed-bmc-opp-lanyang.dtb \
 	aspeed-bmc-opp-mowgli.dtb \
 	aspeed-bmc-opp-nicole.dtb \
arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts new file +923 -0

923 lines not on this page · raw message

Signature · 1 line
2.43.0
maintainer
#3 lore raw

Re: [PATCH v4 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

Quoted 70 lines · Jacky Huang

Add the device tree for the Aspeed AST2600 BMC for NVIDIA's Vera Rubin NVL compute platform.

MAC0 uses phy-mode = "rgmii-id" because the on-board PHY supplies both RGMII internal delays. The matching U-Boot device tree does not enable SoC-side MAC clock delays, leaving the MAC internal delay at zero so the PHY-provided delay is not doubled by the MAC controller.

The corresponding U-Boot change has been submitted to openbmc/u-boot:

---
v4: address dt-check-style findings for property and child node ordering,
required blank lines, and line length. Retain 8 conventional multi-line block comments with mixed-indent and 22 meaningful unused labels for source readability and future references. They can be removed if preferred.

 arch/arm/boot/dts/aspeed/Makefile             |   1 +
 .../aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts   | 923 ++++++++++++++++++
 2 files changed, 924 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts
arch/arm/boot/dts/aspeed/Makefile +1 -0
index 6b68671f9379..07e10083a8bd 100644
@@ -65,6 +65,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-microsoft-olympus.dtb \
 	aspeed-bmc-nvidia-gb200nvl-bmc.dtb \
 	aspeed-bmc-nvidia-msx4-bmc.dtb \
+	aspeed-bmc-nvidia-vr-nvl-bmc.dtb \
 	aspeed-bmc-opp-lanyang.dtb \
 	aspeed-bmc-opp-mowgli.dtb \
 	aspeed-bmc-opp-nicole.dtb \
arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts new file +25 -0
new file mode 100644
index 000000000000..1c04fd3e627c
@@ -0,0 +1,923 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2026 NVIDIA Corporation
 
 
+&ehci1 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	status = "okay";
+
+	hub@1 {
+		reg = <1>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		hub@1 {
+			reg = <1>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			hub@4 {
+				reg = <4>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				/* port 1: BlueField-4 SMA mgmt */
+				device@1 {

arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts line 128

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts new file +10 -0
+					reg = <1>;
+					#address-cells = <2>;
+					#size-cells = <0>;
+
+					interface@1 {
+						reg = <1 1>;
+					};
+				};
+
+				cp2112g: device@2 {

This and other devices should have a compatible string and associated schema. The hub probably should too.

Quoted 13 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts new file +13 -0
+					reg = <2>;
+					#gpio-cells = <2>;
+					gpio-controller;
+					gpio-line-names =
+						"BF4_USB_MCU_RECOVERY_L",
+						"BF4_USB_MCU_RST_L",
+						"BF4_USB_FORCE_FNP_L",
+						"BF4_GLOBAL_WP",
+						"BF4_FORCE_POR_L",
+						"BF4_BMC_EROT_RST_L",
+						"BF4_BMC_EROT_RECOVERY_L",
+						"BF4_THERM_SHUTDOWN";
+					#interrupt-cells = <2>;

arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts new file +9 -0
+					interrupt-controller;
+				};
+			};
+		};
+
 
+&fmc {
+	status = "okay";
+
+	flash@0 {

Needs a compatible.

arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts line 349

Quoted 3 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts new file +3 -0
+		label = "bmc";
+
+		status = "okay";

okay is the default, so not needed.

Quoted 27 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts new file +27 -0
+
+		partitions {
+			compatible = "fixed-partitions";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			partition@0 {
+				reg = <0x0 0xe0000>;		/* 896 KiB */
+				label = "u-boot";
+			};
+
+			partition@100000 {
+				reg = <0x100000 0x900000>;	/* 9 MiB */
+				label = "kernel";
+			};
+
+			partition@a00000 {
+				/*
+				 * extends to end of 64 MiB - 4 KiB; last
+				 * 4 KiB reserved for EROT image
+				 */
+				reg = <0xa00000 0x35ff000>;
+				label = "rofs";
+			};
+		};
+	};
+};

arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts new file +8 -0
 
 
+&spi2 {
+	pinctrl-0 = <&pinctrl_spi2_default>;
+	pinctrl-names = "default";
+
+	status = "okay";
+
+	flash@0 {
+		label = "config";

Needs a compatible.

arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts

Quoted 2 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts new file +2 -0
+
+		status = "okay";

Drop

Quoted 23 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts new file +23 -0
+
+		partitions {
+			compatible = "fixed-partitions";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			partition@0 {
+				reg = <0x0 0x40000>;	/* 256 KiB */
+				label = "u-boot-env";
+			};
+
+			partition@40000 {
+				reg = <0x40000 0x1000000>;	/* 16 MiB */
+				label = "rwfs";
+			};
+
+			partition@1040000 {
+				reg = <0x1040000 0x2800000>;	/* 40 MiB */
+				label = "log";
+			};
+		};
+	};
+};
#4 lore raw

Re: [PATCH v4 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

Hi Rob,

Thank you very much for the review.

Quoted 4 lines · Rob Herring

arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts line 128

Quoted 1 line
arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts new file +1 -0
+				cp2112g: device@2 {

This and other devices should have a compatible string and associated schema. The hub probably should too.

Will fix in v5.

Quoted 3 lines

Review

Quoted 1 line
(quoted diff) +1 -0
+	flash@0 {

Needs a compatible.

The flash@0 node augments the corresponding node defined in aspeed-g6.dtsi, which already carries compatible = "jedec,spi-nor", so the compatible is inherited. The same applies to the flash@0 under &spi2.

Quoted 3 lines

Review

Quoted 1 line
(quoted diff) +1 -0
+		status = "okay";

okay is the default, so not needed.

The flash@0 node in aspeed-g6.dtsi is status = "disabled", so the board file needs status = "okay" to enable it.

Jacky

#5 lore raw

Re: [PATCH v4 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

Quoted 21 lines · Jacky Huang

Hi Rob,

Thank you very much for the review.

Quoted 4 lines · Rob Herring

arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts line 128

Quoted 1 line
arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts new file +1 -0
+				cp2112g: device@2 {

This and other devices should have a compatible string and associated schema. The hub probably should too.

Will fix in v5.

Quoted 3 lines

Review

Quoted 1 line
(quoted diff) +1 -0
+	flash@0 {

Needs a compatible.

The flash@0 node augments the corresponding node defined in aspeed-g6.dtsi, which already carries compatible = "jedec,spi-nor", so the compatible is inherited. The same applies to the flash@0 under &spi2.

Quoted 7 lines
Quoted 3 lines

Review

Quoted 1 line
(quoted diff) +1 -0
+		status = "okay";

okay is the default, so not needed.

The flash@0 node in aspeed-g6.dtsi is status = "disabled", so the board file needs status = "okay" to enable it.

Why are you extending existing nodes that way instead of phandle/label? You write confusing code, so that's why you have such comments.

Best regards,
Krzysztof

#6 lore raw

Re: [PATCH v4 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

Hi Krzysztof,

Quoted 2 lines · Krzysztof Kozlowski

Why are you extending existing nodes that way instead of phandle/label? You write confusing code, so that's why you have such comments.

Thank you for pointing this out. I agree that the current form is unclear.

For v5, I plan to add source labels to the existing flash nodes in aspeed-g6.dtsi:

    fmc: spi@1e620000 {
            fmc_flash0: flash@0 {
                    ...
            };
    };

    spi2: spi@1e631000 {
            spi2_flash0: flash@0 {
                    ...
            };
    };

The board DTS will then reference them directly:

    &fmc_flash0 {
            ...
    };

    &spi2_flash0 {
            ...
    };

This should make the references to the existing nodes explicit.

Best,
Jacky

maintainer
#7 lore raw

Re: [PATCH v4 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

In reply to Jacky Huang
Quoted 13 lines · Jacky Huang

Hi Rob,

Thank you very much for the review.

Quoted 4 lines · Rob Herring
Quoted 1 line

+ cp2112g: device@2 {

This and other devices should have a compatible string and associated schema. The hub probably should too.

Will fix in v5.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

+ flash@0 {

Needs a compatible.

The flash@0 node augments the corresponding node defined in aspeed-g6.dtsi, which already carries compatible = "jedec,spi-nor", so the compatible is inherited. The same applies to the flash@0 under &spi2.

Is the flash part of the SoC package? A board level component shouldn't be in the SoC .dtsi file. If there's some components that all/most boards happen to use, then those should be a common board .dtsi file.

Rob

#8 lore raw

Re: [PATCH v4 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

Hi Rob,

Quoted 4 lines · Rob Herring

Is the flash part of the SoC package? A board level component shouldn't be in the SoC .dtsi file. If there's some components that all/most boards happen to use, then those should be a common board .dtsi file.

No, it is not part of the AST2600 SoC package. It is a discrete SPI NOR on the BMC module.

I agree a common board .dtsi would be the better structure. The nodes are already in aspeed-g6.dtsi today and more than 28 AST2600 board files extend them. I can help prepare that cleanup if it is wanted.

Thanks,
Jacky

#9 lore raw

Re: [PATCH v4 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

In reply to Rob Herring

Hi Rob,

Quoted 1 line

A board level component shouldn't be in the SoC .dtsi file.

I submitted a separate cleanup series to address this. The series updates the AST2600 board files and vendor common DTSI files to declare the flash devices they use, then removes the shared flash nodes from aspeed-g6.dtsi:

https://lore.kernel.org/all/[email protected]/

I plan to base v5 of the VR-NVL DTS series on this cleanup.

Thanks,
Jacky