Skip to contentSkip to conversation

arm64: dts: qcom: Refine device support for Xiaomi Redmi 5A

PATCH Superseded Reza Kurniawan 2 participants 5 messages Aug 18

Subsystems (3)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover arm64: dts: qcom: Refine device support for Xiaomi Redmi 5A

Changes in v3:
- Add vcc-supply for vibrator

Changes in v2:
- Split the patch into multiple patches.
- Change name in Signed-off-by field.

v2: https://lore.kernel.org/r/[email protected]
v1: https://lore.kernel.org/r/[email protected]

Reza Kurniawan (3):
arm64: dts: qcom: Add UART support for Xiaomi Redmi 5A (riva)
arm64: dts: qcom: Add haptic vibrator support for Xiaomi Redmi 5A

    (riva)
  arm64: dts: qcom: Add notification LED support for Xiaomi Redmi 5A
    (riva)
 .../boot/dts/qcom/msm8917-xiaomi-riva.dts     | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)

base-commit: 6b8c8af514d739d0335f5579b585e02babe8a727

Signature · 1 line
2.55.0
#1 lore raw

PATCH v3 1/3 arm64: dts: qcom: Add UART support for Xiaomi Redmi 5A (riva)

---
 arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts +8 -0
index 4ea4fbdb5..abfaae502 100644
@@ -13,6 +13,10 @@ / {
 
 	qcom,board-id = <0x1000b 1>, <0x1000b 2>;
 
+	chosen {
+		stdout-path = &blsp1_uart2;
+	};
+
 	battery: battery {
 		compatible = "simple-battery";
 		charge-full-design-microamp-hours = <3000000>;
@@ -25,6 +29,10 @@ battery: battery {
 	};
 };
 
+&blsp1_uart2 {
+	status = "okay";
+};
+
 &blsp2_i2c1 {
 	status = "okay";
 
Signature · 1 line
2.55.0
#2 lore raw

Re: [PATCH v3 1/3] arm64: dts: qcom: Add UART support for Xiaomi Redmi 5A (riva)

Quoted 1 line · Reza Kurniawan

Please run scripts/checkpatch.pl on the patches and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' on the patches and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear.

Commit msg is where you explain why you are doing, what you want to achieve, what is the point of this work etc.

Best regards,
Krzysztof

#3 lore raw

PATCH v3 2/3 arm64: dts: qcom: Add haptic vibrator support for Xiaomi Redmi 5A (riva)

In reply to Reza Kurniawan

---
v3:
- Add vcc-supply for vibrator

 arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts +6 -0
index abfaae502..a066d9d7a 100644
@@ -27,6 +27,12 @@ battery: battery {
 		charge-term-current-microamp = <60000>;
 		voltage-min-design-microvolt = <3400000>;
 	};
+
+	vibrator {
+		compatible = "gpio-vibrator";
+		enable-gpios = <&tlmm 97 GPIO_ACTIVE_HIGH>;
+		vcc-supply = <&vph_pwr>;
+	};
 };
 
 &blsp1_uart2 {
Signature · 1 line
2.55.0
#4 lore raw

PATCH v3 3/3 arm64: dts: qcom: Add notification LED support for Xiaomi Redmi 5A (riva)

In reply to Reza Kurniawan
---
 .../boot/dts/qcom/msm8917-xiaomi-riva.dts     | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts +23 -0
index a066d9d7a..3f63c2d03 100644
@@ -5,6 +5,7 @@
 
 /dts-v1/;
 
+#include <dt-bindings/leds/common.h>
 #include "msm8917-xiaomi-wingtech.dtsi"
 
 / {
@@ -35,6 +36,28 @@ vibrator {
 	};
 };
 
+&blsp1_i2c2 {
+	status = "okay";
+
+	led-controller@45 {
+		compatible = "awinic,aw2013";
+		reg = <0x45>;
+		vcc-supply = <&pm8937_l10>;
+		vio-supply = <&pm8937_l5>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		status = "okay";
+
+		led@0 {
+			reg = <0>;
+			led-max-microamp = <5000>;
+			function = LED_FUNCTION_INDICATOR;
+			color = <LED_COLOR_ID_WHITE>;
+		};
+	};
+};
+
 &blsp1_uart2 {
 	status = "okay";
 };
Signature · 1 line
2.55.0