Skip to contentSkip to conversation

coredump01: New core_pattern specifiers test

PATCH Superseded Andrea Cervesato 3 participants 3 messages Sep 2 – Sep 3

v4 of 11 Superseded Latest is v11 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 coredump01: New core_pattern specifiers test

From: Andrea Cervesato <[email protected]>

LTP has no coverage for the core_pattern specifiers expansion, neither for the pipe flavor of core_pattern, where the kernel spawns a user space helper and writes the core dump into its standard input.

The new test verifies that %e, %p and %s are expanded both in the core file name and in the arguments of a piped helper, checking also that the helper really receives an ELF core dump.

Root is required to rewrite the system wide core_pattern, which is restored by the test library on all exit paths.

---
Add a simple coredump01 test that simulate a coredump and verify that it actually works. This is a small coverage that is missing inside LTP testing suite.
---
Changes in v4:
- read back core_pattern after writing and abort with TBROK on mismatch
- read CONFIG_STATIC_USERMODEHELPER once in setup() and cache the result
- remove namespace visibility scaffolding and skip logic from verify_pipe_pattern()
- resolve helper path with tst_get_path() instead of /proc/self/exe readlink
- Link to v3: https://lore.kernel.org/[email protected]

Changes in v3:
- check for CONFIG_COREDUMP=y
- Link to v2: https://lore.kernel.org/[email protected]

Changes in v2:
- fix CI agent spotted errors
- Link to v1: https://lore.kernel.org/[email protected]

---
 runtest/kernel_misc                           |   1 +
 testcases/kernel/Makefile                     |   1 +
 testcases/kernel/coredump/.gitignore          |   2 +
 testcases/kernel/coredump/Makefile            |   7 +
 testcases/kernel/coredump/coredump01.c        | 181 ++++++++++++++++++++++++++
 testcases/kernel/coredump/coredump01_helper.c |  66 ++++++++++
 6 files changed, 258 insertions(+)
runtest/kernel_misc +1 -0
index cc3562cb7..ecf9ee2a2 100644
@@ -17,3 +17,4 @@ zram02 zram02.sh
 zram03 zram03
 umip_basic_test umip_basic_test
 aslr01 aslr01
+coredump01 coredump01
testcases/kernel/Makefile +1 -0
index ac816e4e8..6b303c14b 100644
@@ -19,6 +19,7 @@ SUBDIRS			+= lib
 SUBDIRS			+= connectors \
 			   containers \
 			   controllers \
+			   coredump \
 			   crypto \
 			   device-drivers \
 			   firmware \
testcases/kernel/coredump/.gitignore new file +2 -0
new file mode 100644
index 000000000..cd0b51700
@@ -0,0 +1,2 @@
+/coredump01
+/coredump01_helper
testcases/kernel/coredump/Makefile new file +7 -0
new file mode 100644
index 000000000..951a3e976
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# Copyright (c) 2026 Linux Test Project
+
+top_srcdir		?= ../../..
+
+include $(top_srcdir)/include/mk/testcases.mk
+include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/coredump/coredump01.c new file +181 -0

181 lines not on this page · raw message

testcases/kernel/coredump/coredump01_helper.c new file +66 -0

66 lines not on this page · raw message

---
base-commit: 12724413534a6d4160ff9694ba6f09daa4ccb6bd
change-id: 20260820-coredump-22fc731bde08

Best regards,

Signature · 5 lines
Andrea Cervesato <[email protected]>


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi Andrea,

Quoted 4 lines · Andrea Cervesato

coredump01: New core_pattern specifiers test

	if (tst_get_path(HELPER, helper_path, sizeof(helper_path)))
		tst_brk(TCONF, "'%s' not found in $PATH", HELPER);

tst_get_path() can return a relative path such as ./coredump01_helper, but a piped core_pattern helper is resolved from the root directory. Canonicalize helper_path to an absolute path before writing it to core_pattern, otherwise the helper may not start and the test reports a false failure.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw
Quoted 19 lines

Hi Andrea,

Quoted 4 lines · Andrea Cervesato

coredump01: New core_pattern specifiers test

	if (tst_get_path(HELPER, helper_path, sizeof(helper_path)))
		tst_brk(TCONF, "'%s' not found in $PATH", HELPER);

tst_get_path() can return a relative path such as ./coredump01_helper, but a piped core_pattern helper is resolved from the root directory. Canonicalize helper_path to an absolute path before writing it to core_pattern, otherwise the helper may not start and the test reports a false failure.

Verdict - Needs revision

---
Note:

Quoted 9 lines

The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp

This is valid. I sent a new version

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp