Skip to contentSkip to conversation

coredump testing suite

PATCH Superseded Andrea Cervesato 4 participants 8 messages Sep 4 – Sep 8

v7 of 11 Superseded Latest is v11 →

lore
Share & tools
lore
#0 lore raw

v7 cover coredump testing suite

Add a simple coredump01 test that simulate a coredump and verify that it actually works. This is a small coverage that is missing inside LTP testing suite.

Add a coredump02 test that verifies ELF data after a coredump.

---
Changes in v7:
- define a common header for the testing suite
- update commit message for coredump02
- Link to v6: https://lore.kernel.org/[email protected]

Changes in v6:
- coredump01 check Elf
- add coredump02 test for Elf validation
- Link to v5: https://lore.kernel.org/[email protected]

Changes in v5:
- resolve path from root for helper
- Link to v4: https://lore.kernel.org/[email protected]

Changes in v4:
- read back core_pattern after writing and abort with TBROK on mismatch
- read CONFIG_STATIC_USERMODEHELPER once in setup() and cache the result
- remove namespace visibility scaffolding and skip logic from verify_pipe_pattern()
- resolve helper path with tst_get_path() instead of /proc/self/exe readlink
- Link to v3: https://lore.kernel.org/[email protected]

Changes in v3:
- check for CONFIG_COREDUMP=y
- Link to v2: https://lore.kernel.org/[email protected]

Changes in v2:
- fix CI agent spotted errors
- Link to v1: https://lore.kernel.org/[email protected]

To: Linux Test Project <[email protected]>

---
Andrea Cervesato (2):
coredump01: New core_pattern specifiers test
coredump02: Verify ELF structure and notes

 runtest/kernel_misc                           |   2 +
 testcases/kernel/Makefile                     |   1 +
 testcases/kernel/coredump/.gitignore          |   3 +
 testcases/kernel/coredump/Makefile            |   7 +
 testcases/kernel/coredump/coredump01.c        | 158 ++++++++++++++++++++
 testcases/kernel/coredump/coredump01_helper.c |  73 ++++++++++
 testcases/kernel/coredump/coredump02.c        | 198 ++++++++++++++++++++++++++
 testcases/kernel/coredump/coredump_common.h   |  69 +++++++++
 8 files changed, 511 insertions(+)

---
base-commit: 043bdc49af410f55ece6f61abcdaba7d9580f86a
change-id: 20260820-coredump-22fc731bde08

Best regards,

Signature · 5 lines
Andrea Cervesato <[email protected]>


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

PATCH v7 1/2 coredump01: New core_pattern specifiers test

From: Andrea Cervesato <[email protected]>

LTP has no coverage for the core_pattern specifiers expansion, neither for the pipe flavor of core_pattern, where the kernel spawns a user space helper and writes the core dump into its standard input.

The new test verifies that %e, %p and %s are expanded both in the core file name and in the arguments of a piped helper, checking also that the helper really receives an ELF core dump.

Root is required to rewrite the system wide core_pattern, which is restored by the test library on all exit paths.

---
 runtest/kernel_misc                           |   1 +
 testcases/kernel/Makefile                     |   1 +
 testcases/kernel/coredump/.gitignore          |   2 +
 testcases/kernel/coredump/Makefile            |   7 ++
 testcases/kernel/coredump/coredump01.c        | 158 ++++++++++++++++++++++++++
 testcases/kernel/coredump/coredump01_helper.c |  73 ++++++++++++
 testcases/kernel/coredump/coredump_common.h   |  69 +++++++++++
 7 files changed, 311 insertions(+)
runtest/kernel_misc +1 -0
index cc3562cb7..ecf9ee2a2 100644
@@ -17,3 +17,4 @@ zram02 zram02.sh
 zram03 zram03
 umip_basic_test umip_basic_test
 aslr01 aslr01
+coredump01 coredump01
testcases/kernel/Makefile +1 -0
index ac816e4e8..6b303c14b 100644
@@ -19,6 +19,7 @@ SUBDIRS			+= lib
 SUBDIRS			+= connectors \
 			   containers \
 			   controllers \
+			   coredump \
 			   crypto \
 			   device-drivers \
 			   firmware \
testcases/kernel/coredump/.gitignore new file +2 -0
new file mode 100644
index 000000000..cd0b51700
@@ -0,0 +1,2 @@
+/coredump01
+/coredump01_helper
testcases/kernel/coredump/Makefile new file +7 -0
new file mode 100644
index 000000000..951a3e976
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# Copyright (c) 2026 Linux Test Project
+
+top_srcdir		?= ../../..
+
+include $(top_srcdir)/include/mk/testcases.mk
+include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/coredump/coredump01.c new file +158 -0

158 lines not on this page · raw message

testcases/kernel/coredump/coredump01_helper.c new file +73 -0

73 lines not on this page · raw message

testcases/kernel/coredump/coredump_common.h new file +69 -0

69 lines not on this page · raw message

Signature · 5 lines
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw

Re: [LTP] coredump01: New core_pattern specifiers test

Hi Andrea,

Quoted 1 line · Andrea Cervesato

coredump01: New core_pattern specifiers test

--- [PATCH 1/2] ---

Quoted 11 lines

static void run(unsigned int n)

{
	if (n)
		verify_pipe_pattern();
	else
		verify_file_pattern();
}
static struct tst_test test = {
	.test = run,
	.tcnt = 2,

This manually dispatches separate functions for the two test cases. Use a single struct tcase array and a generic .test callback, with .tcnt = ARRAY_SIZE(tcases), as required for multi-case tests.

--- [PATCH 2/2] ---

Quoted 3 lines
		} else if (ph[i].p_type == PT_LOAD) {
			have_load = 1;
		}

This only proves that a PT_LOAD header exists, not that its data is present. A short dump_emit() after the headers and notes leaves WCOREDUMP set, so a truncated core can pass every check here. Validate p_offset + p_filesz against core_len with overflow-safe arithmetic for every file-backed segment.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw

Re: [LTP] coredump01: New core_pattern specifiers test

Quoted 4 lines

This manually dispatches separate functions for the two test cases. Use a single struct tcase array and a generic .test callback, with .tcnt = ARRAY_SIZE(tcases), as required for multi-case tests.

no need for this.

Quoted 12 lines

--- [PATCH 2/2] ---

Quoted 3 lines
		} else if (ph[i].p_type == PT_LOAD) {
			have_load = 1;
		}

This only proves that a PT_LOAD header exists, not that its data is present. A short dump_emit() after the headers and notes leaves WCOREDUMP set, so a truncated core can pass every check here. Validate p_offset + p_filesz against core_len with overflow-safe arithmetic for every file-backed segment.

this is valid

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#4 lore raw

Re: [LTP] coredump01: New core_pattern specifiers test

In reply to [email protected]
Quoted 10 lines

--- [PATCH 2/2] ---

Quoted 3 lines
		} else if (ph[i].p_type == PT_LOAD) {
			have_load = 1;
		}

This only proves that a PT_LOAD header exists, not that its data is present. A short dump_emit() after the headers and notes leaves WCOREDUMP set, so a truncated core can pass every check here. Validate p_offset + p_filesz against core_len with overflow-safe arithmetic for every file-backed segment.

Sent a v8 fixing this

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#6 lore raw

PATCH v7 2/2 coredump02: Verify ELF structure and notes

In reply to Andrea Cervesato

From: Andrea Cervesato <[email protected]>

LTP currently only tests core_pattern specifier expansion and basic ELF magic in coredump01, leaving the internal ELF structure and notes generated by the kernel unverified.

Add a test to verify that the kernel produces a valid ET_CORE ELF file with the expected PT_NOTE and PT_LOAD segments, and that the NT_PRPSINFO and NT_PRSTATUS notes contain the expected process name, PID, and terminating signal.

Root is required to set the system-wide core_pattern into the test's temporary directory.

---
 runtest/kernel_misc                    |   1 +
 testcases/kernel/coredump/.gitignore   |   1 +
 testcases/kernel/coredump/coredump02.c | 198 +++++++++++++++++++++++++++++++++
 3 files changed, 200 insertions(+)
runtest/kernel_misc +1 -0
index ecf9ee2a2..3311e1929 100644
@@ -18,3 +18,4 @@ zram03 zram03
 umip_basic_test umip_basic_test
 aslr01 aslr01
 coredump01 coredump01
+coredump02 coredump02
testcases/kernel/coredump/.gitignore +1 -0
index cd0b51700..e241a112e 100644
@@ -1,2 +1,3 @@
 /coredump01
 /coredump01_helper
+/coredump02
testcases/kernel/coredump/coredump02.c new file +198 -0

198 lines not on this page · raw message

Signature · 5 lines
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by on v7 2/2
#7 lore raw

Re: [LTP] [PATCH v7 2/2] coredump02: Verify ELF structure and notes

Signature · 5 lines
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp