Skip to contentSkip to conversation

coredump testing suite

PATCH Superseded Andrea Cervesato 3 participants 6 messages Sep 9 Library code

v9 of 11 Superseded Latest is v11 →

lore
Share & tools
lore
#0 lore raw

v9 cover coredump testing suite

Add a simple coredump01 test that simulate a coredump and verify that it actually works. This is a small coverage that is missing inside LTP testing suite.

Add a coredump02 test that verifies ELF data after a coredump.

---
Changes in v9:
- add SAFE_FILE_VPRINTF() helper in the test library
- factor out shared test logic into coredump_common.h
- use SAFE_FILE_VPRINTF() in set_pattern() to avoid intermediate buffers
- use struct tcase array for test case dispatch in coredump01
- return early in coredump01 if core file is missing before parsing ELF
- document root requirement in coredump02 description
- assert exactly one PT_NOTE segment in coredump02
- validate file bounds for PT_LOAD segments in coredump02
- use TST_EXP_EQ_STRN() to compare executable name in coredump02
- copy unaligned note descriptors to local stack structs to ensure 8-byte alignment
- Link to v8: https://lore.kernel.org/[email protected]

Changes in v8:
- check PT_LOAD data
- Link to v7: https://lore.kernel.org/[email protected]

Changes in v7:
- define a common header for the testing suite
- update commit message for coredump02
- Link to v6: https://lore.kernel.org/[email protected]

Changes in v6:
- coredump01 check Elf
- add coredump02 test for Elf validation
- Link to v5: https://lore.kernel.org/[email protected]

Changes in v5:
- resolve path from root for helper
- Link to v4: https://lore.kernel.org/[email protected]

Changes in v4:
- read back core_pattern after writing and abort with TBROK on mismatch
- read CONFIG_STATIC_USERMODEHELPER once in setup() and cache the result
- remove namespace visibility scaffolding and skip logic from verify_pipe_pattern()
- resolve helper path with tst_get_path() instead of /proc/self/exe readlink
- Link to v3: https://lore.kernel.org/[email protected]

Changes in v3:
- check for CONFIG_COREDUMP=y
- Link to v2: https://lore.kernel.org/[email protected]

Changes in v2:
- fix CI agent spotted errors
- Link to v1: https://lore.kernel.org/[email protected]

To: Linux Test Project <[email protected]>

---
Andrea Cervesato (3):
lib: Add SAFE_FILE_VPRINTF()
coredump01: New core_pattern specifiers test
coredump02: Verify ELF structure and notes

 include/safe_file_ops_fn.h                    |   6 +
 include/tst_safe_file_ops.h                   |   4 +
 lib/safe_file_ops.c                           |   2 +-
 runtest/kernel_misc                           |   2 +
 testcases/kernel/Makefile                     |   1 +
 testcases/kernel/coredump/.gitignore          |   3 +
 testcases/kernel/coredump/Makefile            |   7 +
 testcases/kernel/coredump/coredump01.c        | 162 +++++++++++++++++++++
 testcases/kernel/coredump/coredump01_helper.c |  73 ++++++++++
 testcases/kernel/coredump/coredump02.c        | 196 ++++++++++++++++++++++++++
 testcases/kernel/coredump/coredump_common.h   |  52 +++++++
 11 files changed, 507 insertions(+), 1 deletion(-)

---
base-commit: 043bdc49af410f55ece6f61abcdaba7d9580f86a
change-id: 20260820-coredump-22fc731bde08

Best regards,

Signature · 5 lines
Andrea Cervesato <[email protected]>


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

PATCH v9 1/3 lib: Add SAFE_FILE_VPRINTF()

From: Andrea Cervesato <[email protected]>

Expose safe_file_vprintf() as SAFE_FILE_VPRINTF() macro to allow formatting directly into files with a va_list without requiring an intermediate buffer.

---
 include/safe_file_ops_fn.h  | 6 ++++++
 include/tst_safe_file_ops.h | 4 ++++
 lib/safe_file_ops.c         | 2 +-
 3 files changed, 11 insertions(+), 1 deletion(-)
include/safe_file_ops_fn.h +6 -0
index 223fb0d68..1edaac794 100644
@@ -20,6 +20,7 @@
 
 #include <sys/stat.h>
 #include <time.h>
+#include <stdarg.h>
 
 #include "lapi/utime.h"
 
@@ -62,6 +63,11 @@ void safe_file_printf(const char *file, const int lineno,
                       const char *path, const char *fmt, ...)
                       __attribute__ ((format (printf, 5, 6)));
 
+void safe_file_vprintf(const char *file, const int lineno,
+		       void (*cleanup_fn)(void),
+		       const char *path, const char *fmt, va_list va)
+	__attribute__ ((format (printf, 5, 0)));
+
 void safe_try_file_printf(const char *file, const int lineno,
 	void (*cleanup_fn)(void), const char *path, const char *fmt, ...)
 	__attribute__ ((format (printf, 5, 6)));
include/tst_safe_file_ops.h +4 -0
index 73ebd2ab8..b2b760b33 100644
@@ -65,6 +65,10 @@ void safe_file_read_str(const char *file, const int lineno,
 	safe_file_printf(__FILE__, __LINE__, NULL, \
 	                 (path), (fmt), ## __VA_ARGS__)
 
+#define SAFE_FILE_VPRINTF(path, fmt, va) \
+	safe_file_vprintf(__FILE__, __LINE__, NULL, \
+			  (path), (fmt), (va))
+
 /* Same as SAFE_FILE_PRINTF() but returns quietly if the path doesn't exist */
 #define SAFE_TRY_FILE_PRINTF(path, fmt, ...) \
 	safe_try_file_printf(__FILE__, __LINE__, NULL, \
lib/safe_file_ops.c +1 -1
index 19da1fd97..1069a017f 100644
@@ -280,7 +280,7 @@ err:
 	return 1;
 }
 
-static void safe_file_vprintf(const char *file, const int lineno,
+void safe_file_vprintf(const char *file, const int lineno,
 	void (*cleanup_fn)(void), const char *path, const char *fmt,
 	va_list va)
 {
Signature · 5 lines
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw

Re: [LTP] lib: Add SAFE_FILE_VPRINTF()

Hi Andrea,

Quoted 1 line · Andrea Cervesato

[PATCH 1/3] lib: Add SAFE_FILE_VPRINTF()

--- [PATCH 1/3] ---

include/tst_safe_file_ops.h void safe_file_read_str(const char *file, const int lineno, · line 70

Quoted 3 lines
include/tst_safe_file_ops.h +3 -0
+#define SAFE_FILE_VPRINTF(path, fmt, va) \
+	safe_file_vprintf(__FILE__, __LINE__, NULL, \
+			  (path), (fmt), (va))

Missing kernel-doc comment for SAFE_FILE_VPRINTF(). Public macros added to include/tst_safe_file_ops.h must be documented with kernel-doc syntax recognized by linuxdoc.

--- [PATCH 3/3] ---

Review

Quoted 7 lines
(quoted diff) +7 -0
+	if (type == NT_PRPSINFO && descsz >= sizeof(struct elf_prpsinfo)) {
+		struct elf_prpsinfo info;
+
+		memcpy(&info, desc, sizeof(info));
+		TST_EXP_EQ_STRN(info.pr_fname, "coredump02", sizeof("coredump02"));
+
+		prpsinfo_seen = 1;

Using sizeof("coredump02") as the length argument triggers a -Wsizeof-pointer-memaccess compiler warning from TST_EXP_EQ_STRN(). Use TST_EXP_EQ_STR(info.pr_fname, "coredump02") since pr_fname is null-terminated, or pass sizeof(info.pr_fname).

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw

Re: [LTP] lib: Add SAFE_FILE_VPRINTF()

Quoted 17 lines

Hi Andrea,

Quoted 1 line · Andrea Cervesato

[PATCH 1/3] lib: Add SAFE_FILE_VPRINTF()

--- [PATCH 1/3] ---

include/tst_safe_file_ops.h void safe_file_read_str(const char *file, const int lineno, · line 70

Quoted 3 lines
include/tst_safe_file_ops.h +3 -0
+#define SAFE_FILE_VPRINTF(path, fmt, va) \
+	safe_file_vprintf(__FILE__, __LINE__, NULL, \
+			  (path), (fmt), (va))

Missing kernel-doc comment for SAFE_FILE_VPRINTF(). Public macros added to include/tst_safe_file_ops.h must be documented with kernel-doc syntax recognized by linuxdoc.

--- [PATCH 3/3] ---

Quoted 12 lines

Review

Quoted 7 lines
(quoted diff) +7 -0
+	if (type == NT_PRPSINFO && descsz >= sizeof(struct elf_prpsinfo)) {
+		struct elf_prpsinfo info;
+
+		memcpy(&info, desc, sizeof(info));
+		TST_EXP_EQ_STRN(info.pr_fname, "coredump02", sizeof("coredump02"));
+
+		prpsinfo_seen = 1;

Using sizeof("coredump02") as the length argument triggers a -Wsizeof-pointer-memaccess compiler warning from TST_EXP_EQ_STRN(). Use TST_EXP_EQ_STR(info.pr_fname, "coredump02") since pr_fname is null-terminated, or pass sizeof(info.pr_fname).

both correct, im gonna send a patch

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#4 lore raw

PATCH v9 2/3 coredump01: New core_pattern specifiers test

In reply to Andrea Cervesato

From: Andrea Cervesato <[email protected]>

LTP has no coverage for the core_pattern specifiers expansion, neither for the pipe flavor of core_pattern, where the kernel spawns a user space helper and writes the core dump into its standard input.

The new test verifies that %e, %p and %s are expanded both in the core file name and in the arguments of a piped helper, checking also that the helper really receives an ELF core dump.

Root is required to rewrite the system wide core_pattern, which is restored by the test library on all exit paths.

---
 runtest/kernel_misc                           |   1 +
 testcases/kernel/Makefile                     |   1 +
 testcases/kernel/coredump/.gitignore          |   2 +
 testcases/kernel/coredump/Makefile            |   7 ++
 testcases/kernel/coredump/coredump01.c        | 162 ++++++++++++++++++++++++++
 testcases/kernel/coredump/coredump01_helper.c |  73 ++++++++++++
 testcases/kernel/coredump/coredump_common.h   |  52 +++++++++
 7 files changed, 298 insertions(+)
runtest/kernel_misc +1 -0
index cc3562cb7..ecf9ee2a2 100644
@@ -17,3 +17,4 @@ zram02 zram02.sh
 zram03 zram03
 umip_basic_test umip_basic_test
 aslr01 aslr01
+coredump01 coredump01
testcases/kernel/Makefile +1 -0
index ac816e4e8..6b303c14b 100644
@@ -19,6 +19,7 @@ SUBDIRS			+= lib
 SUBDIRS			+= connectors \
 			   containers \
 			   controllers \
+			   coredump \
 			   crypto \
 			   device-drivers \
 			   firmware \
testcases/kernel/coredump/.gitignore new file +2 -0
new file mode 100644
index 000000000..cd0b51700
@@ -0,0 +1,2 @@
+/coredump01
+/coredump01_helper
testcases/kernel/coredump/Makefile new file +7 -0
new file mode 100644
index 000000000..951a3e976
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# Copyright (c) 2026 Linux Test Project
+
+top_srcdir		?= ../../..
+
+include $(top_srcdir)/include/mk/testcases.mk
+include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/coredump/coredump01.c new file +162 -0

162 lines not on this page · raw message

testcases/kernel/coredump/coredump01_helper.c new file +73 -0

73 lines not on this page · raw message

testcases/kernel/coredump/coredump_common.h new file +52 -0

52 lines not on this page · raw message

Signature · 5 lines
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#5 lore raw

PATCH v9 3/3 coredump02: Verify ELF structure and notes

In reply to Andrea Cervesato

From: Andrea Cervesato <[email protected]>

LTP currently only tests core_pattern specifier expansion and basic ELF magic in coredump01, leaving the internal ELF structure and notes generated by the kernel unverified.

Add a test to verify that the kernel produces a valid ET_CORE ELF file with the expected PT_NOTE and PT_LOAD segments, and that the NT_PRPSINFO and NT_PRSTATUS notes contain the expected process name, PID, and terminating signal.

Root is required to set the system-wide core_pattern into the test's temporary directory.

---
 runtest/kernel_misc                    |   1 +
 testcases/kernel/coredump/.gitignore   |   1 +
 testcases/kernel/coredump/coredump02.c | 196 +++++++++++++++++++++++++++++++++
 3 files changed, 198 insertions(+)
runtest/kernel_misc +1 -0
index ecf9ee2a2..3311e1929 100644
@@ -18,3 +18,4 @@ zram03 zram03
 umip_basic_test umip_basic_test
 aslr01 aslr01
 coredump01 coredump01
+coredump02 coredump02
testcases/kernel/coredump/.gitignore +1 -0
index cd0b51700..e241a112e 100644
@@ -1,2 +1,3 @@
 /coredump01
 /coredump01_helper
+/coredump02
testcases/kernel/coredump/coredump02.c new file +196 -0

196 lines not on this page · raw message

Signature · 5 lines
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp