Skip to contentSkip to conversation

Add reset deassertion for Aspeed MDIO

PATCH Superseded Dylan Hung 5 participants 16 messages Mar 21, 2022 – Mar 22, 2022

Subsystems (6)

v2 of 6 Superseded Latest is v6 →

lore
Share & tools
lore

Dylan Hung

author
#0 lore raw

v2 cover Add reset deassertion for Aspeed MDIO

Add missing reset deassertion for Aspeed MDIO. There are 4 MDIOs embedded in Aspeed AST2600 and share one reset control bit SCU50[3].

Dylan Hung (3):
dt-bindings: net: add reset property for aspeed, ast2600-mdio binding
net: mdio: add reset control for Aspeed MDIO
ARM: dts: aspeed: add reset properties into MDIO nodes

 .../bindings/net/aspeed,ast2600-mdio.yaml         |  4 ++++
 arch/arm/boot/dts/aspeed-g6.dtsi                  |  4 ++++
 drivers/net/mdio/mdio-aspeed.c                    | 15 ++++++++++++++-
 3 files changed, 22 insertions(+), 1 deletion(-)
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH v2 1/3 dt-bindings: net: add reset property for aspeed, ast2600-mdio binding

The AST2600 MDIO bus controller has a reset control bit and must be deasserted before the manipulating the MDIO controller.

Cc stable at vger.kernel.org
---
 .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml          | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml +4 -0
index 1c88820cbcdf..8ba108e25d94 100644
@@ -23,12 +23,15 @@ properties:
   reg:
     maxItems: 1
     description: The register range of the MDIO controller instance
+  resets:
+    maxItems: 1
 
 required:
   - compatible
   - reg
   - "#address-cells"
   - "#size-cells"
+  - resets
 
 unevaluatedProperties: false
 
@@ -39,6 +42,7 @@ examples:
             reg = <0x1e650000 0x8>;
             #address-cells = <1>;
             #size-cells = <0>;
+            resets = <&syscon 35>;
 
             ethphy0: ethernet-phy at 0 {
                     compatible = "ethernet-phy-ieee802.3-c22";
Signature · 1 line
2.25.1
maintainer
#2 lore raw

Re: [PATCH v2 1/3] dt-bindings: net: add reset property for aspeed, ast2600-mdio binding

Quoted 5 lines · Dylan Hung

The AST2600 MDIO bus controller has a reset control bit and must be deasserted before the manipulating the MDIO controller.

Cc stable at vger.kernel.org

Please read the netdev FAQ. You need to indicates which networking tree this is for in the Subject line, and you need to make use of the correct git tree. You should also have a Fixes: tag, indicating where the issue was introduced.

Andrew

maintainer
#3 lore raw

Re: [PATCH v2 1/3] dt-bindings: net: add reset property for aspeed, ast2600-mdio binding

In reply to Dylan Hung
Quoted 9 lines · Dylan Hung

The AST2600 MDIO bus controller has a reset control bit and must be deasserted before the manipulating the MDIO controller.

Cc stable at vger.kernel.org
---
 .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml          | 4 ++++
 1 file changed, 4 insertions(+)

Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1607671

mdio at 1e650000: 'resets' is a required property

	arch/arm/boot/dts/aspeed-ast2600-evb-a1.dt.yaml
	arch/arm/boot/dts/aspeed-ast2600-evb.dt.yaml
	arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dt.yaml

mdio at 1e650008: 'resets' is a required property

	arch/arm/boot/dts/aspeed-ast2600-evb-a1.dt.yaml
	arch/arm/boot/dts/aspeed-ast2600-evb.dt.yaml
	arch/arm/boot/dts/aspeed-bmc-facebook-cloudripper.dt.yaml
	arch/arm/boot/dts/aspeed-bmc-facebook-fuji.dt.yaml

mdio at 1e650010: 'resets' is a required property

	arch/arm/boot/dts/aspeed-ast2600-evb-a1.dt.yaml
	arch/arm/boot/dts/aspeed-ast2600-evb.dt.yaml

mdio at 1e650018: 'resets' is a required property

	arch/arm/boot/dts/aspeed-ast2600-evb-a1.dt.yaml
	arch/arm/boot/dts/aspeed-ast2600-evb.dt.yaml
	arch/arm/boot/dts/aspeed-bmc-facebook-cloudripper.dt.yaml
#4 lore raw

Re: [PATCH v2 1/3] dt-bindings: net: add reset property for aspeed, ast2600-mdio binding

In reply to Dylan Hung
Quoted 5 lines · Dylan Hung

The AST2600 MDIO bus controller has a reset control bit and must be deasserted before the manipulating the MDIO controller.

Cc stable at vger.kernel.org

No bugs fixes, no cc-stable. Especially that you break existing devices...

Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml properties: · line 25

Quoted 12 lines
---
 .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml          | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml +0 -0
index 1c88820cbcdf..8ba108e25d94 100644
@@ -23,12 +23,15 @@ properties:
   reg:
     maxItems: 1
     description: The register range of the MDIO controller instance

Missing empty line.

Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml properties: · line 34

Quoted 9 lines
Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml +3 -0
+  resets:
+    maxItems: 1
 
 required:
   - compatible
   - reg
   - "#address-cells"
   - "#size-cells"
+  - resets

You break the ABI. This isusually not accepted in a regular kernel and even totally not accepted accepted for stable kernel.

Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml examples: · line 48

Quoted 11 lines
Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml +1 -0
 unevaluatedProperties: false
 
@@ -39,6 +42,7 @@ examples:
             reg = <0x1e650000 0x8>;
             #address-cells = <1>;
             #size-cells = <0>;
+            resets = <&syscon 35>;
 
             ethphy0: ethernet-phy at 0 {
                     compatible = "ethernet-phy-ieee802.3-c22";

Best regards,
Krzysztof

author
#5 lore raw

PATCH v2 2/3 net: mdio: add reset control for Aspeed MDIO

In reply to Dylan Hung

Add reset assertion/deassertion for Aspeed MDIO. There are 4 MDIO controllers embedded in Aspeed AST2600 SOC and share one reset control register SCU50[3]. So devm_reset_control_get_shared is used in this change.

Cc stable at vger.kernel.org
---
 drivers/net/mdio/mdio-aspeed.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)
drivers/net/mdio/mdio-aspeed.c +14 -1
index e2273588c75b..5bda48d7071d 100644
@@ -3,6 +3,7 @@
 
 #include <linux/bitfield.h>
 #include <linux/delay.h>
+#include <linux/reset.h>
 #include <linux/iopoll.h>
 #include <linux/mdio.h>
 #include <linux/module.h>
@@ -37,6 +38,7 @@
 
 struct aspeed_mdio {
 	void __iomem *base;
+	struct reset_control *reset;
 };
 
 static int aspeed_mdio_read(struct mii_bus *bus, int addr, int regnum)
@@ -120,6 +122,12 @@ static int aspeed_mdio_probe(struct platform_device *pdev)
 	if (IS_ERR(ctx->base))
 		return PTR_ERR(ctx->base);
 
+	ctx->reset = devm_reset_control_get_shared(&pdev->dev, NULL);
+	if (IS_ERR(ctx->reset))
+		return PTR_ERR(ctx->reset);
+
+	reset_control_deassert(ctx->reset);
+
 	bus->name = DRV_NAME;
 	snprintf(bus->id, MII_BUS_ID_SIZE, "%s%d", pdev->name, pdev->id);
 	bus->parent = &pdev->dev;
@@ -129,6 +137,7 @@ static int aspeed_mdio_probe(struct platform_device *pdev)
 	rc = of_mdiobus_register(bus, pdev->dev.of_node);
 	if (rc) {
 		dev_err(&pdev->dev, "Cannot register MDIO bus!\n");
+		reset_control_assert(ctx->reset);
 		return rc;
 	}
 
@@ -139,7 +148,11 @@ static int aspeed_mdio_probe(struct platform_device *pdev)
 
 static int aspeed_mdio_remove(struct platform_device *pdev)
 {
-	mdiobus_unregister(platform_get_drvdata(pdev));
+	struct mii_bus *bus = (struct mii_bus *)platform_get_drvdata(pdev);
+	struct aspeed_mdio *ctx = bus->priv;
+
+	reset_control_assert(ctx->reset);
+	mdiobus_unregister(bus);
 
 	return 0;
 }
Signature · 1 line
2.25.1
Reviewed-by on v2 2/3
#6 lore raw

Re: [PATCH v2 2/3] net: mdio: add reset control for Aspeed MDIO

Quoted 7 lines · Dylan Hung

Add reset assertion/deassertion for Aspeed MDIO.? There are 4 MDIO controllers embedded in Aspeed AST2600 SOC and share one reset control
register SCU50[3]. So devm_reset_control_get_shared is used in this change.

regards
Philipp

author
#7 lore raw

PATCH v2 3/3 ARM: dts: aspeed: add reset properties into MDIO nodes

In reply to Dylan Hung

Add reset control properties into MDIO nodes. The 4 MDIO controllers in AST2600 SOC share one reset control bit SCU50[3].

Cc stable at vger.kernel.org
---
 arch/arm/boot/dts/aspeed-g6.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/aspeed-g6.dtsi +4 -0
index c32e87fad4dc..ab20ea8d829d 100644
@@ -181,6 +181,7 @@ mdio0: mdio at 1e650000 {
 			status = "disabled";
 			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_mdio1_default>;
+			resets = <&syscon ASPEED_RESET_MII>;
 		};
 
 		mdio1: mdio at 1e650008 {
@@ -191,6 +192,7 @@ mdio1: mdio at 1e650008 {
 			status = "disabled";
 			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_mdio2_default>;
+			resets = <&syscon ASPEED_RESET_MII>;
 		};
 
 		mdio2: mdio at 1e650010 {
@@ -201,6 +203,7 @@ mdio2: mdio at 1e650010 {
 			status = "disabled";
 			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_mdio3_default>;
+			resets = <&syscon ASPEED_RESET_MII>;
 		};
 
 		mdio3: mdio at 1e650018 {
@@ -211,6 +214,7 @@ mdio3: mdio at 1e650018 {
 			status = "disabled";
 			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_mdio4_default>;
+			resets = <&syscon ASPEED_RESET_MII>;
 		};
 
 		mac0: ftgmac at 1e660000 {
Signature · 1 line
2.25.1
#8 lore raw

Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes

Quoted 5 lines · Dylan Hung

Add reset control properties into MDIO nodes. The 4 MDIO controllers in AST2600 SOC share one reset control bit SCU50[3].

Cc stable at vger.kernel.org

Please describe the bug being fixed. See stable-kernel-rules.

Best regards,
Krzysztof

author
#9 lore raw

RE: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes

Quoted 13 lines

-----Original Message-----
From: Krzysztof Kozlowski [mailto:krzk at kernel.org]
Sent: 2022?3?21? 11:53 PM
To: Dylan Hung <[email protected]>; robh+dt at kernel.org; joel at jms.id.au; andrew at aj.id.au; andrew at lunn.ch; hkallweit1 at gmail.com; linux at armlinux.org.uk; davem at davemloft.net; kuba at kernel.org; pabeni at redhat.com; p.zabel at pengutronix.de; devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; netdev at vger.kernel.org
Cc: BMC-SW <[email protected]>; stable at vger.kernel.org
Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes

Quoted 8 lines
Quoted 5 lines · Dylan Hung

Add reset control properties into MDIO nodes. The 4 MDIO controllers in AST2600 SOC share one reset control bit SCU50[3].

Cc stable at vger.kernel.org

Please describe the bug being fixed. See stable-kernel-rules.

Thank you for your comment.
The reset deassertion of the MDIO device was usually done by the bootloader (u-boot). However, one of our clients uses proprietary bootloader and doesn't deassert the MDIO reset so failed to access the HW in kernel driver. The reset deassertion is missing in the kernel driver since it was created, should I add a BugFix for the first commit of this driver? Or would it be better if I remove " Cc: stable at vger.kernel.org"?

Quoted 3 lines

Best regards,
Krzysztof

maintainer
#10 lore raw

Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes

Quoted 20 lines · Dylan Hung
Quoted 20 lines

-----Original Message-----
From: Krzysztof Kozlowski [mailto:krzk at kernel.org]
Sent: 2022?3?21? 11:53 PM
To: Dylan Hung <[email protected]>; robh+dt at kernel.org; joel at jms.id.au; andrew at aj.id.au; andrew at lunn.ch; hkallweit1 at gmail.com; linux at armlinux.org.uk; davem at davemloft.net; kuba at kernel.org; pabeni at redhat.com; p.zabel at pengutronix.de; devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; netdev at vger.kernel.org
Cc: BMC-SW <[email protected]>; stable at vger.kernel.org
Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes

Quoted 5 lines · Dylan Hung

Add reset control properties into MDIO nodes. The 4 MDIO controllers in AST2600 SOC share one reset control bit SCU50[3].

Cc stable at vger.kernel.org
Quoted 6 lines
Quoted 1 line

Please describe the bug being fixed. See stable-kernel-rules.

Thank you for your comment.
The reset deassertion of the MDIO device was usually done by the bootloader (u-boot). However, one of our clients uses proprietary bootloader and doesn't deassert the MDIO reset so failed to access the HW in kernel driver.

So are you saying mainline u-boot releases the reset?

Quoted 2 lines

The reset deassertion is missing in the
kernel driver since it was created, should I add a BugFix for the first commit of this driver?

Yes, that is normal. Ideally the kernel should not depend on u-boot, because often people want to use other bootloaders, e.g. barebox. You should also consider kexec, where one kernel hands over to another kernel, without the bootloader being involved. In such a situation, you ideally want to assert and deassert the reset just to clean away any state the old kernel left around.

But please do note, that the reset is optional, since you need to be able to work with old DT blobs which don't have the reset property in them.

Andrew

author
#11 lore raw

RE: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes

Quoted 39 lines

-----Original Message-----
From: Andrew Lunn [mailto:andrew at lunn.ch]
Sent: 2022?3?22? 11:01 AM
To: Dylan Hung <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>; robh+dt at kernel.org; joel at jms.id.au; andrew at aj.id.au; hkallweit1 at gmail.com; linux at armlinux.org.uk; davem at davemloft.net; kuba at kernel.org; pabeni at redhat.com; p.zabel at pengutronix.de; devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; netdev at vger.kernel.org; BMC-SW <[email protected]>; stable at vger.kernel.org
Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes

Quoted 24 lines · Dylan Hung
Quoted 23 lines

-----Original Message-----
From: Krzysztof Kozlowski [mailto:krzk at kernel.org]
Sent: 2022?3?21? 11:53 PM
To: Dylan Hung <[email protected]>; robh+dt at kernel.org; joel at jms.id.au; andrew at aj.id.au; andrew at lunn.ch; hkallweit1 at gmail.com; linux at armlinux.org.uk; davem at davemloft.net; kuba at kernel.org; pabeni at redhat.com; p.zabel at pengutronix.de; devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; netdev at vger.kernel.org
Cc: BMC-SW <[email protected]>; stable at vger.kernel.org
Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes

Quoted 6 lines · Dylan Hung

Add reset control properties into MDIO nodes. The 4 MDIO controllers in
AST2600 SOC share one reset control bit SCU50[3].

Cc stable at vger.kernel.org

Please describe the bug being fixed. See stable-kernel-rules.

Quoted 8 lines
Quoted 2 lines

Thank you for your comment.
The reset deassertion of the MDIO device was usually done by the

bootloader (u-boot).

Quoted 2 lines

However, one of our clients uses proprietary bootloader and doesn't deassert the MDIO reset so failed to access the HW in kernel driver.

So are you saying mainline u-boot releases the reset?

Yes, if the mdio devices are used in u-boot.

Quoted 12 lines
Quoted 2 lines

The reset deassertion is missing in the kernel driver since it was created, should I add a BugFix for the first commit of this driver?

Yes, that is normal. Ideally the kernel should not depend on u-boot, because often people want to use other bootloaders, e.g. barebox. You should also consider kexec, where one kernel hands over to another kernel, without the bootloader being involved. In such a situation, you ideally want to assert and deassert the reset just to clean away any state the old kernel left around.

But please do note, that the reset is optional, since you need to be able to work with old DT blobs which don't have the reset property in them.

Thank you. I will let the reset property be optional and modify the error-checking in the driver accordingly in V3.

Quoted 3 lines

Andrew

#12 lore raw

Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes

Quoted 73 lines · Dylan Hung
Quoted 47 lines

-----Original Message-----
From: Andrew Lunn [mailto:andrew at lunn.ch]
Sent: 2022?3?22? 11:01 AM
To: Dylan Hung <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>; robh+dt at kernel.org; joel at jms.id.au; andrew at aj.id.au; hkallweit1 at gmail.com; linux at armlinux.org.uk; davem at davemloft.net; kuba at kernel.org; pabeni at redhat.com; p.zabel at pengutronix.de; devicetree at vger.kernel.org;
linux-arm-kernel at lists.infradead.org;
linux-aspeed at lists.ozlabs.org;
linux-kernel at vger.kernel.org; netdev at vger.kernel.org; BMC-SW <[email protected]>; stable at vger.kernel.org
Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO
nodes

Quoted 22 lines · Dylan Hung
Quoted 22 lines

-----Original Message-----
From: Krzysztof Kozlowski [mailto:krzk at kernel.org]
Sent: 2022?3?21? 11:53 PM
To: Dylan Hung <[email protected]>; robh+dt at kernel.org; joel at jms.id.au; andrew at aj.id.au; andrew at lunn.ch; hkallweit1 at gmail.com; linux at armlinux.org.uk;
davem at davemloft.net;
kuba at kernel.org; pabeni at redhat.com; p.zabel at pengutronix.de; devicetree at vger.kernel.org;
linux-arm-kernel at lists.infradead.org;
linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; netdev at vger.kernel.org
Cc: BMC-SW <[email protected]>; stable at vger.kernel.org
Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties
into MDIO nodes

Quoted 4 lines · Dylan Hung

Add reset control properties into MDIO nodes.? The 4 MDIO controllers in
AST2600 SOC share one reset control bit SCU50[3].

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Cc stable at vger.kernel.org

Please describe the bug being fixed. See stable-kernel-rules.

Thank you for your comment.
The reset deassertion of the MDIO device was usually done by the

Quoted 8 lines

bootloader (u-boot).

Quoted 4 lines

However, one of our clients uses proprietary bootloader and doesn't
deassert the MDIO reset so failed to access the HW in kernel driver.

So are you saying mainline u-boot releases the reset?

Yes, if the mdio devices are used in u-boot.

Quoted 16 lines
Quoted 4 lines

The reset deassertion is missing in the kernel driver since it was
created, should I add a BugFix for the first commit of this driver?

Yes, that is normal. Ideally the kernel should not depend on u- boot, because
often people want to use other bootloaders, e.g. barebox. You should also
consider kexec, where one kernel hands over to another kernel, without the
bootloader being involved. In such a situation, you ideally want to assert and
deassert the reset just to clean away any state the old kernel left around.

Quoted 7 lines
Quoted 4 lines

But please do note, that the reset is optional, since you need to be able to
work with old DT blobs which don't have the reset property in them.

Thank you. I will let the reset property be optional and modify the error-checking in the driver accordingly in V3.

No need to change the error checking, just use
devm_reset_control_get_optional_shared().

regards
Philipp

#13 lore raw

Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes

In reply to Dylan Hung
Quoted 20 lines · Dylan Hung
Quoted 20 lines

-----Original Message-----
From: Krzysztof Kozlowski [mailto:krzk at kernel.org]
Sent: 2022?3?21? 11:53 PM
To: Dylan Hung <[email protected]>; robh+dt at kernel.org; joel at jms.id.au; andrew at aj.id.au; andrew at lunn.ch; hkallweit1 at gmail.com; linux at armlinux.org.uk; davem at davemloft.net; kuba at kernel.org; pabeni at redhat.com; p.zabel at pengutronix.de; devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; netdev at vger.kernel.org
Cc: BMC-SW <[email protected]>; stable at vger.kernel.org
Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes

Quoted 5 lines · Dylan Hung

Add reset control properties into MDIO nodes. The 4 MDIO controllers in AST2600 SOC share one reset control bit SCU50[3].

Cc stable at vger.kernel.org
Quoted 8 lines
Quoted 1 line

Please describe the bug being fixed. See stable-kernel-rules.

Thank you for your comment.
The reset deassertion of the MDIO device was usually done by the bootloader (u-boot). However, one of our clients uses proprietary bootloader and doesn't deassert the MDIO reset so failed to access the HW in kernel driver. The reset deassertion is missing in the kernel driver since it was created, should I add a BugFix for the first commit of this driver? Or would it be better if I remove " Cc: stable at vger.kernel.org"?

This rather looks like a missing feature, not a bug. Anyway any description must be in commit message.

Best regards,
Krzysztof

author
#14 lore raw

RE: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes

Quoted 41 lines

-----Original Message-----
From: Krzysztof Kozlowski [mailto:krzk at kernel.org]
Sent: 2022?3?22? 4:40 PM
To: Dylan Hung <[email protected]>; robh+dt at kernel.org; joel at jms.id.au; andrew at aj.id.au; andrew at lunn.ch; hkallweit1 at gmail.com; linux at armlinux.org.uk; davem at davemloft.net; kuba at kernel.org; pabeni at redhat.com; p.zabel at pengutronix.de; devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; netdev at vger.kernel.org
Cc: BMC-SW <[email protected]>; stable at vger.kernel.org
Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes

Quoted 19 lines · Dylan Hung
Quoted 19 lines

-----Original Message-----
From: Krzysztof Kozlowski [mailto:krzk at kernel.org]
Sent: 2022?3?21? 11:53 PM
To: Dylan Hung <[email protected]>; robh+dt at kernel.org; joel at jms.id.au; andrew at aj.id.au; andrew at lunn.ch; hkallweit1 at gmail.com; linux at armlinux.org.uk; davem at davemloft.net; kuba at kernel.org; pabeni at redhat.com; p.zabel at pengutronix.de; devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; netdev at vger.kernel.org
Cc: BMC-SW <[email protected]>; stable at vger.kernel.org
Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes

Quoted 4 lines · Dylan Hung

Add reset control properties into MDIO nodes. The 4 MDIO controllers in
AST2600 SOC share one reset control bit SCU50[3].

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Cc stable at vger.kernel.org

Please describe the bug being fixed. See stable-kernel-rules.

Thank you for your comment.
The reset deassertion of the MDIO device was usually done by the

bootloader (u-boot).

Quoted 8 lines
Quoted 3 lines

However, one of our clients uses proprietary bootloader and doesn't deassert the MDIO reset so failed to access the HW in kernel driver. The reset deassertion is missing in the kernel driver since it was created,

should I add a BugFix for the first commit of this driver?

Quoted 1 line

Or would it be better if I remove " Cc: stable at vger.kernel.org"?

This rather looks like a missing feature, not a bug. Anyway any description must be in commit message.

Thank you. I will remove " Cc: stable at vger.kernel.org" and add more description in commit message in V3.

Quoted 4 lines

Best regards,
Krzysztof

maintainer
#15 lore raw
In reply to Dylan Hung
Quoted 2 lines · Dylan Hung

Add missing reset deassertion for Aspeed MDIO. There are 4 MDIOs embedded in Aspeed AST2600 and share one reset control bit SCU50[3].

Hi Dylan

Please wait at least 24 hours between posting versions, to give other people times to comment.

The danger here is that my comments on the previous version are going to get ignored, and this version merged containing the issues i pointed out.

Andrew