Skip to contentSkip to conversation

xen: make (set|get)_xen_guest_handle available

PATCH In review Christoph Egger 3 participants 9 messages Jul 30, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen: make (set|get)_xen_guest_handle available

Hi!

Make (set|get)_xen_guest_handle() always available. This avoids code snippets in the guest like this:

#if __XEN_ITNERFACE_VERSION__ >= 0x00030201
set_xen_guest_handle(hnd, val);
#else
hnd = val;
#endif

Also make get_xen_guest_handle() available for the guest. It is useful for the guest, too.

P.S.: Keir: Please apply this patch also in xen-3.4-testing and xen-3.3-testing tree.

Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
xen/include/public/arch-x86/xen.h +5 -1
diff -r 41b2c4e4f674 xen/include/public/arch-x86/xen.h
@@ -44,9 +44,13 @@
 #define DEFINE_XEN_GUEST_HANDLE(name)   __DEFINE_XEN_GUEST_HANDLE(name, name)
 #define __XEN_GUEST_HANDLE(name)        __guest_handle_ ## name
 #define XEN_GUEST_HANDLE(name)          __XEN_GUEST_HANDLE(name)
+
+#if __XEN_INTERFACE_VERSION__ >= 0x00030201
 #define set_xen_guest_handle(hnd, val)  do { (hnd).p = val; } while (0)
-#ifdef __XEN_TOOLS__
 #define get_xen_guest_handle(val, hnd)  do { val = (hnd).p; } while (0)
+#else
+#define set_xen_guest_handle(hnd, val)  (hnd) = val
+#define get_xen_guest_handle(val, hnd)  val = (hnd)
 #endif
 
 #if defined(__i386__)

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 2 lines · Christoph Egger

P.S.: Keir: Please apply this patch also in xen-3.4-testing and xen-3.3-testing tree.

No more nice-to-have backports. The trees are closed to ship next week.

-- Keir

#2 lore raw
In reply to Christoph Egger
Quoted 8 lines · Christoph Egger

Make (set|get)_xen_guest_handle() always available. This avoids code snippets in the guest like this:

#if __XEN_ITNERFACE_VERSION__ >= 0x00030201
set_xen_guest_handle(hnd, val);
#else
hnd = val;
#endif

Actually I don't see why you'd have code like this. *You*, the guest, gets to specify __XEN_INTERFACE_VERSION__ -- that is the point of it -- so ifdef'ing based on it in the guest is stupid.

Just specify __XEN_INTERFACE_VERSION__ to be recent enough to have the guest handles, and then remove your ifdefs. Simple.

-- Keir

#3 lore raw
Quoted 10 lines · On Thursday 30 July 2009 12:14:04 Keir Fraser wrote:
Quoted 8 lines · Christoph Egger

Make (set|get)_xen_guest_handle() always available. This avoids code snippets in the guest like this:

#if __XEN_ITNERFACE_VERSION__ >= 0x00030201
set_xen_guest_handle(hnd, val);
#else
hnd = val;
#endif

Quoted 6 lines

Actually I don't see why you'd have code like this. *You*, the guest, gets to specify __XEN_INTERFACE_VERSION__ -- that is the point of it -- so ifdef'ing based on it in the guest is stupid.

Just specify __XEN_INTERFACE_VERSION__ to be recent enough to have the guest handles, and then remove your ifdefs. Simple.

The point is to keep backward compatibility. The patch makes Xen more friendly with using the old non-structured guest handler if the user wants.

NetBSD offers both way to build & run it with either using the old or new interface. This allows a smooth migration.

Christoph

Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
#4 lore raw

May the recent version of NetBSD run as PV guest ? Sorry, for stupid question.
Boris.

--- On Thu, 7/30/09, Christoph Egger <[email protected]> wrote:

From: Christoph Egger <[email protected]>
Subject: Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available
To: "Keir Fraser" <[email protected]>
Cc: "[email protected]" <[email protected]>
Date: Thursday, July 30, 2009, 6:34 AM

Quoted 10 lines · On Thursday 30 July 2009 12:14:04 Keir Fraser wrote:
Quoted 8 lines · Christoph Egger

Make (set|get)_xen_guest_handle() always available. This avoids code snippets in the guest like this:

#if __XEN_ITNERFACE_VERSION__ >= 0x00030201
set_xen_guest_handle(hnd, val);
#else
hnd = val;
#endif

Quoted 6 lines

Actually I don't see why you'd have code like this. *You*, the guest, gets to specify __XEN_INTERFACE_VERSION__ -- that is the point of it -- so ifdef'ing based on it in the guest is stupid.

Just specify __XEN_INTERFACE_VERSION__ to be recent enough to have the guest handles, and then remove your ifdefs. Simple.

The point is to keep backward compatibility. The patch makes Xen more friendly with using the old non-structured guest handler if the user wants.

NetBSD offers both way to build & run it with either using the old or new interface. This allows a smooth migration.

Christoph

Signature · 12 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#5 lore raw

Hi Boris,

this is the history:

NetBSD 2.0 got Xen 1.2 support (both Dom0 and DomU)
NetBSD 3.0 got Xen 2 support, dropped Xen 1.2 support (both Dom0 and DomU) NetBSD 4.0 got Xen 3.0/3.1 support 32bit only, kept Xen 2 support (both Dom0 and DomU)
NetBSD 5.0 got Xen 3.x support (both 32bit and 64bit), kept Xen 2 support (both Dom0 and DomU)
NetBSD-current dropped Xen 2 support, about to move to new interface.

Christoph

Quoted 37 lines · On Thursday 30 July 2009 13:16:00 Boris Derzhavets wrote:

May the recent version of NetBSD run as PV guest ? Sorry, for stupid question.
Boris.

--- On Thu, 7/30/09, Christoph Egger <[email protected]> wrote:

From: Christoph Egger <[email protected]>
Subject: Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available To: "Keir Fraser" <[email protected]>
Cc: "[email protected]" <[email protected]>
Date: Thursday, July 30, 2009, 6:34 AM

Quoted 10 lines · On Thursday 30 July 2009 12:14:04 Keir Fraser wrote:
Quoted 8 lines · Christoph Egger

Make (set|get)_xen_guest_handle() always available. This avoids code snippets in the guest like this:

#if __XEN_ITNERFACE_VERSION__ >= 0x00030201
set_xen_guest_handle(hnd, val);
#else
hnd = val;
#endif

Quoted 6 lines

Actually I don't see why you'd have code like this. *You*, the guest, gets to specify __XEN_INTERFACE_VERSION__ -- that is the point of it -- so ifdef'ing based on it in the guest is stupid.

Just specify __XEN_INTERFACE_VERSION__ to be recent enough to have the guest handles, and then remove your ifdefs. Simple.

The point is to keep backward compatibility. The patch makes Xen more friendly with using the old non-structured guest handler if the user wants.

NetBSD offers both way to build & run it with either using the old or new interface. This allows a smooth migration.

Christoph

Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
#6 lore raw

Hi Christoph,

Quoted 1 line

NetBSD 5.0 got Xen 3.x support (both 32bit and 64bit), kept Xen 2 support

Sounds a bit strange for me. Like only 3.X  Xen Hypervisor could be connected via hypercalls from NetBSD 5.0 DomU xenified kernel. ( For instance Solaris Nevada until build 84(5)  ( or so)  required patch to work with Xen 3.2 and higher Linux Dom0 )

Would NetBSD 5.0 understand Xen 3.4.1 Dom0 on top
of Ubuntu 9.04 or F11 (64-bit environment) ?

Thanks.
Boris.

--- On Thu, 7/30/09, Christoph Egger <[email protected]> wrote:

From: Christoph Egger <[email protected]>
Subject: Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available
To: "Boris Derzhavets" <[email protected]>
Cc: "[email protected]" <[email protected]>, "Keir Fraser" <[email protected]>
Date: Thursday, July 30, 2009, 7:55 AM

Hi Boris,

this is the history:

NetBSD 2.0 got Xen 1.2 support (both Dom0 and DomU)
NetBSD 3.0 got Xen 2 support, dropped Xen 1.2 support (both Dom0 and DomU) NetBSD 4.0 got Xen 3.0/3.1 support 32bit only, kept Xen 2 support (both Dom0 and DomU)
NetBSD 5.0 got Xen 3.x support (both 32bit and 64bit), kept Xen 2 support (both Dom0 and DomU)
NetBSD-current dropped Xen 2 support, about to move to new interface.

Christoph

Quoted 37 lines · On Thursday 30 July 2009 13:16:00 Boris Derzhavets wrote:

May the recent version of NetBSD run as PV guest ? Sorry, for stupid question.
Boris.

--- On Thu, 7/30/09, Christoph Egger <[email protected]> wrote:

From: Christoph Egger <[email protected]>
Subject: Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available To: "Keir Fraser" <[email protected]>
Cc: "[email protected]" <[email protected]>
Date: Thursday, July 30, 2009, 6:34 AM

Quoted 10 lines · On Thursday 30 July 2009 12:14:04 Keir Fraser wrote:
Quoted 8 lines · Christoph Egger

Make (set|get)_xen_guest_handle() always available. This avoids code snippets in the guest like this:

#if __XEN_ITNERFACE_VERSION__ >= 0x00030201
set_xen_guest_handle(hnd, val);
#else
hnd = val;
#endif

Quoted 6 lines

Actually I don't see why you'd have code like this. *You*, the guest, gets to specify __XEN_INTERFACE_VERSION__ -- that is the point of it -- so ifdef'ing based on it in the guest is stupid.

Just specify __XEN_INTERFACE_VERSION__ to be recent enough to have the guest handles, and then remove your ifdefs. Simple.

The point is to keep backward compatibility. The patch makes Xen more friendly with using the old non-structured guest handler if the user wants.

NetBSD offers both way to build & run it with either using the old or new interface. This allows a smooth migration.

Christoph

Signature · 12 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#7 lore raw
Quoted 8 lines · On Thursday 30 July 2009 14:41:33 Boris Derzhavets wrote:

Hi Christoph,

Quoted 1 line

NetBSD 5.0 got Xen 3.x support (both 32bit and 64bit), kept Xen 2 support

Sounds a bit strange for me. Like only 3.X  Xen Hypervisor could be connected via hypercalls from NetBSD 5.0 DomU xenified kernel. ( For instance Solaris Nevada until build 84(5)  ( or so)  required patch to work with Xen 3.2 and higher Linux Dom0 )

Patches for NetBSD are maintained in NetBSD's package management (likewise Gentoo or Debian have their own patches in their packages).
Most of them break non-NetBSD totally, that's why I can't just submit them at once. xen-unstable is in a very good shape though. patch queue is very small now.

Quoted 2 lines

Would NetBSD 5.0 understand Xen 3.4.1 Dom0 on top
of Ubuntu 9.04 or F11 (64-bit environment) ?

Yes.

Quoted 66 lines

Thanks.
Boris.

--- On Thu, 7/30/09, Christoph Egger <[email protected]> wrote:

From: Christoph Egger <[email protected]>
Subject: Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available To: "Boris Derzhavets" <[email protected]>
Cc: "[email protected]" <[email protected]>, "Keir Fraser" <[email protected]> Date: Thursday, July 30, 2009, 7:55 AM

Hi Boris,

this is the history:

NetBSD 2.0 got Xen 1.2 support (both Dom0 and DomU)
NetBSD 3.0 got Xen 2 support, dropped Xen 1.2 support (both Dom0 and DomU) NetBSD 4.0 got Xen 3.0/3.1 support 32bit only, kept Xen 2 support (both Dom0 and DomU)
NetBSD 5.0 got Xen 3.x support (both 32bit and 64bit), kept Xen 2 support (both Dom0 and DomU)
NetBSD-current dropped Xen 2 support, about to move to new interface.

Christoph

Quoted 38 lines · On Thursday 30 July 2009 13:16:00 Boris Derzhavets wrote:

May the recent version of NetBSD run as PV guest ? Sorry, for stupid question.
Boris.

--- On Thu, 7/30/09, Christoph Egger <[email protected]> wrote:

From: Christoph Egger <[email protected]>
Subject: Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available To: "Keir Fraser" <[email protected]>
Cc: "[email protected]" <[email protected]>
Date: Thursday, July 30, 2009, 6:34 AM

Quoted 10 lines · On Thursday 30 July 2009 12:14:04 Keir Fraser wrote:
Quoted 8 lines · Christoph Egger

Make (set|get)_xen_guest_handle() always available. This avoids code snippets in the guest like this:

#if __XEN_ITNERFACE_VERSION__ >= 0x00030201
set_xen_guest_handle(hnd, val);
#else
hnd = val;
#endif

Quoted 6 lines

Actually I don't see why you'd have code like this. *You*, the guest, gets to specify __XEN_INTERFACE_VERSION__ -- that is the point of it -- so ifdef'ing based on it in the guest is stupid.

Just specify __XEN_INTERFACE_VERSION__ to be recent enough to have the guest handles, and then remove your ifdefs. Simple.

The point is to keep backward compatibility. The patch makes Xen more friendly with using the old non-structured guest handler if the user wants.

NetBSD offers both way to build & run it with either using the old or new interface. This allows a smooth migration.

Christoph

Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
#8 lore raw
In reply to Christoph Egger
Quoted 4 lines · Christoph Egger
Quoted 4 lines

Actually I don't see why you'd have code like this. *You*, the guest, gets to specify __XEN_INTERFACE_VERSION__ -- that is the point of it -- so ifdef'ing based on it in the guest is stupid.

Quoted 8 lines
Quoted 2 lines

Just specify __XEN_INTERFACE_VERSION__ to be recent enough to have the guest handles, and then remove your ifdefs. Simple.

The point is to keep backward compatibility. The patch makes Xen more friendly with using the old non-structured guest handler if the user wants.

NetBSD offers both way to build & run it with either using the old or new interface. This allows a smooth migration.

Am I going to regret asking: Why? You only need to pick one API version (__XEN_INTERFACE_VERSION__) -- the resulting binaries will work with any Xen 3.x (since we guarantee ABI compatibility).

-- Keir