KSM test case fixes - ksm01
PATCH v2 1/4 KSM test case fixes - ksm01
Thanks Casper. Used macro 'PATH_KSM' and removed braces. And tested the same.
ksm01, ksm01_1:
Before patch:
...
ksm01 0 TINFO : KSM merging... ksm01 1 TBROK : open: errno=ENOENT(2): No such file or directory ksm01 2 TBROK : Remaining cases broken
...
After patch:
...
ksm01 1 TCONF : KSM configuration is not enabled ksm01 2 TCONF : Remaining cases not appropriate for configuration
...
Signature · 2 lines
Regards R.Nageswara Sastry
testcases/kernel/mem/ksm/ksm01.c +2 -0
@@ -109,6 +109,8 @@ void setup(void)tst_sig (FORK ,DEF_HANDLER ,NULL );TEST_PAUSE ; +if (access (PATH_KSM ,F_OK ) ==-1 ) +tst_brkm (TCONF ,NULL ,"KSM configuration is not enabled" ); }void cleanup (void )
------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi!
Quoted 11 lines
testcases/kernel/mem/ksm/ksm01.c void setup(void) · line 113
Quoted 8 lines
testcases/kernel/mem/ksm/ksm01.c +2
-0@@ -109,6 +109,8 @@ void setup(void)tst_sig (FORK ,DEF_HANDLER ,NULL );TEST_PAUSE ; +if (access (PATH_KSM ,F_OK ) ==-1 ) +tst_brkm (TCONF ,NULL ,"KSM configuration is not enabled" );Hi, sorry I still have some comments to the new version of 1/4 and 2/4.
Quoted 8 lines
format corrections:
1. use tab instead of 8 spaces
2. space after "if" and no space inside round backets(you may want to check the style-guide in
LTPROOT/doc/style-guide.txt)And I suggest put this if-condtion before
tst_sig(). Cyril, any comments?
LTP uses LKML coding style and you can use the checkpatch.pl script packed with kernel sources (reasonably new sources are needed) to check that your patch is clean.
Signature · 13 lines
Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Using storage to extend the benefits of virtualization and iSCSI Virtualization increases hardware utilization and delivers a new level of agility. Learn what those decisions are and how to modernize your storage and backup environments for virtualization. http://www.accelacomm.com/jaw/sfnl/114/51434361/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list