KSM test case fixes - mmap10
PATCH v5 3/4 KSM test case fixes - mmap10
Disable mmap10 test if KSM is not configured
P.S. patch checked with 'checkpatch.pl'
# ./mmap10 -s mmap10 1 TCONF : KSM configuration is not enabled mmap10 2 TCONF : Remaining cases not appropriate for configuration
Signature · 2 lines
Regards R.Nageswara Sastry
testcases/kernel/syscalls/mmap/mmap10.c +3 -0
@@ -62,6 +62,7 @@#include "test.h" #include "usctest.h" #include "config.h" +#include "../../mem/include/mem.h" #define SIZE (5*1024*1024)
@@ -94,6 +95,8 @@ int main(int argc, char *argv[])if (opt_ksm) { +if (access (PATH_KSM ,F_OK ) ==-1 ) +tst_brkm (TCONF ,NULL ,"KSM configuration is not enabled" );#ifdef HAVE_MADV_MERGEABLE tst_resm (TINFO ,"add to KSM regions." );#else
------------------------------------------------------------------------------
Why Cloud-Based Security and Archiving Make Sense
Osterman Research conducted this study that outlines how and why cloud computing security and archiving is rapidly being adopted across the IT space for its ease of implementation, lower cost, and increased reliability. Learn more. http://www.accelacomm.com/jaw/sfnl/114/51425301/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Hi!
Quoted 11 lines
testcases/kernel/syscalls/mmap/mmap10.c +1
-0@@ -62,6 +62,7 @@#include "test.h" #include "usctest.h" #include "config.h" +#include "../../mem/include/mem.h" #define SIZE (5*1024*1024)
testcases/kernel/syscalls/mmap/mmap10.c int main(int argc, char *argv[]) · line 102
Quoted 8 lines
testcases/kernel/syscalls/mmap/mmap10.c +2
-0@@ -94,6 +95,8 @@ int main(int argc, char *argv[])if (opt_ksm) { +if (access (PATH_KSM ,F_OK ) ==-1 ) +tst_brkm (TCONF ,NULL ,"KSM configuration is not enabled" );#ifdef HAVE_MADV_MERGEABLE tst_resm (TINFO ,"add to KSM regions." );#else
I don't have a good feeling about including header files across several directories, which could break things miraculously in the future. The best solution would be creating one header file to store constants to in ltp/include/. Or even duplicating the constant in the mmap10.c source seems as better solution to me.
Signature · 13 lines
Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Why Cloud-Based Security and Archiving Make Sense Osterman Research conducted this study that outlines how and why cloud computing security and archiving is rapidly being adopted across the IT space for its ease of implementation, lower cost, and increased reliability. Learn more. http://www.accelacomm.com/jaw/sfnl/114/51425301/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list