KSM test case fixes - ksm01
PATCH v3 1/4 KSM test case fixes - ksm01
Fixed format issues.
Signature · 2 lines
Regards R.Nageswara Sastry
testcases/kernel/mem/ksm/ksm01.c +2 -0
@@ -106,6 +106,8 @@ void setup(void)if (tst_kvercmp (2 ,6 ,32 ) <0 )tst_brkm (TCONF ,NULL ,"2.6.32 or greater kernel required" ); +if (access (PATH_KSM ,F_OK ) ==-1 ) +tst_brkm (TCONF ,NULL ,"KSM configuration is not enabled" );tst_sig (FORK ,DEF_HANDLER ,NULL );TEST_PAUSE ;
------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Hi!
Quoted 1 line
Fixed format issues.
^ please write here short description of the problme that the patch is
fixing. Somethink like "Disable ksm01 test if KSM is not supported" should do.
Quoted 10 lines
Signed-off-by Nageswara R Sastry <[email protected]>Signature · 2 lines
Regards R.Nageswara Sastry
testcases/kernel/mem/ksm/ksm01.c void setup(void) · line 113
Quoted 8 lines
testcases/kernel/mem/ksm/ksm01.c +2
-0@@ -106,6 +106,8 @@ void setup(void)if (tst_kvercmp (2 ,6 ,32 ) <0 )tst_brkm (TCONF ,NULL ,"2.6.32 or greater kernel required" ); +if (access (PATH_KSM ,F_OK ) ==-1 ) +tst_brkm (TCONF ,NULL ,"KSM configuration is not enabled" );tst_sig (FORK ,DEF_HANDLER ,NULL );TEST_PAUSE ;
Still there should be whitespace after the if and there shouldn't be whitespaces on the inner side of the braces.
Could you pretty please use the checkpatch.pl script, that should save both your and mine time ;).
Signature · 13 lines
Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Using storage to extend the benefits of virtualization and iSCSI Virtualization increases hardware utilization and delivers a new level of agility. Learn what those decisions are and how to modernize your storage and backup environments for virtualization. http://www.accelacomm.com/jaw/sfnl/114/51434361/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list