Skip to contentSkip to conversation

clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

PATCH Superseded Mutharaju, Prasanna (P.) 2 participants 2 messages Nov 30, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

Remove unneeded variable used to store return value.

---
v3: Modified subject and changelog comments
---

---
 drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/samsung/clk-s3c2410-dclk.c +1 -2
index e9eb935..ec6fb14 100644
@@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)
 static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
 {
 	struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw);
-	int ret = 0;
 
 	s3c2410_modify_misccr((clkout->mask << clkout->shift),
 			      (index << clkout->shift));
 
-	return ret;
+	return 0;
 }
 
 static const struct clk_ops s3c24xx_clkout_ops = {
Signature · 1 line
1.9.1
#1 lore raw

PATCH v3 1/1 clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

W dniu 30.11.2015 o 18:52, Mutharaju, Prasanna (P.) pisze:

Quoted 3 lines

Remove unneeded variable used to store return value.

Previous issues fixed, thanks! But now you changed the From field and it does not match exactly the Signed-off-by (email matches but name does not). Please fix this - signed-off-by should be the same as "From" (in previous versions it was ok...).

Best regards,
Krzysztof

Quoted 27 lines

---
v3: Modified subject and changelog comments
---

---
 drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/samsung/clk-s3c2410-dclk.c +1 -2
index e9eb935..ec6fb14 100644
@@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)
 static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
 {
 	struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw);
-	int ret = 0;
 
 	s3c2410_modify_misccr((clkout->mask << clkout->shift),
 			      (index << clkout->shift));
 
-	return ret;
+	return 0;
 }
 
 static const struct clk_ops s3c24xx_clkout_ops = {