remoteproc: qcom: Add support for MSM8953 ADSP
v3 cover remoteproc: qcom: Add support for MSM8953 ADSP
This patch series adds support for the ADSP PIL as found on the MSM8953 platform. It is a subset of a previous patch series.
Changes since v2:
* Made ordering of compatible strings lexical in doc patch
Link to v1: https://lkml.org/lkml/2022/10/6/18
Sireesh Kodali (2):
remoteproc: qcom: pas: Add MSM8953 ADSP PIL support
dt-bindings: remoteproc: qcom: adsp: Add ADSP on MSM8953
Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 5 +++++ drivers/remoteproc/qcom_q6v5_pas.c | 1 + 2 files changed, 6 insertions(+)
Signature · 1 line
2.37.3
PATCH v3 1/2 remoteproc: qcom: pas: Add MSM8953 ADSP PIL support
Add support for the Audio DSP PIL found on the Qualcomm MSM8953 platform. The same configuration is used on all SoCs based on the MSM8953 platform (SDM450, SDA450, SDM625, SDM632, APQ8053).
--- drivers/remoteproc/qcom_q6v5_pas.c | 1 + 1 file changed, 1 insertion(+)
drivers/remoteproc/qcom_q6v5_pas.c +1 -0
@@ -950,6 +950,7 @@ static const struct of_device_id adsp_of_match[] = { { .compatible = "qcom,msm8226-adsp-pil", .data = &adsp_resource_init}, { .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init}, { .compatible = "qcom,msm8996-adsp-pil", .data = &msm8996_adsp_resource}, + { .compatible = "qcom,msm8953-adsp-pil", .data = &msm8996_adsp_resource}, { .compatible = "qcom,msm8996-slpi-pil", .data = &slpi_resource_init}, { .compatible = "qcom,msm8998-adsp-pas", .data = &msm8996_adsp_resource}, { .compatible = "qcom,msm8998-slpi-pas", .data = &slpi_resource_init},
Signature · 1 line
2.37.3
Re: [PATCH v3 1/2] remoteproc: qcom: pas: Add MSM8953 ADSP PIL support
Quoted 14 lines · Sireesh Kodali
Add support for the Audio DSP PIL found on the Qualcomm MSM8953 platform. The same configuration is used on all SoCs based on the MSM8953 platform (SDM450, SDA450, SDM625, SDM632, APQ8053).
Signed-off-by Sireesh Kodali <[email protected]>--- drivers/remoteproc/qcom_q6v5_pas.c | 1 + 1 file changed, 1 insertion(+)drivers/remoteproc/qcom_q6v5_pas.c +0
-0
drivers/remoteproc/qcom_q6v5_pas.c static const struct of_device_id adsp_of_match[] = { · line 953
Quoted 4 lines
drivers/remoteproc/qcom_q6v5_pas.c +1
-0@@ -950,6 +950,7 @@ static const struct of_device_id adsp_of_match[] = { { .compatible = "qcom,msm8226-adsp-pil", .data = &adsp_resource_init}, { .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init}, { .compatible = "qcom,msm8996-adsp-pil", .data = &msm8996_adsp_resource}, + { .compatible = "qcom,msm8953-adsp-pil", .data = &msm8996_adsp_resource},
This one also in alphanumeric order, by compatible.
Best regards,
Krzysztof
Re: [PATCH v3 1/2] remoteproc: qcom: pas: Add MSM8953 ADSP PIL support
Quoted 10 lines · Krzysztof Kozlowski
Quoted 9 lines · Sireesh Kodali
Add support for the Audio DSP PIL found on the Qualcomm MSM8953 platform. The same configuration is used on all SoCs based on the MSM8953 platform (SDM450, SDA450, SDM625, SDM632, APQ8053).
Signed-off-by Sireesh Kodali <[email protected]>--- drivers/remoteproc/qcom_q6v5_pas.c | 1 + 1 file changed, 1 insertion(+)
Quoted 11 lines
drivers/remoteproc/qcom_q6v5_pas.c static const struct of_device_id adsp_of_match[] = { · line 953
Quoted 9 lines
drivers/remoteproc/qcom_q6v5_pas.c +1
-0@@ -950,6 +950,7 @@ static const struct of_device_id adsp_of_match[] = { { .compatible = "qcom,msm8226-adsp-pil", .data = &adsp_resource_init}, { .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init}, { .compatible = "qcom,msm8996-adsp-pil", .data = &msm8996_adsp_resource}, + { .compatible = "qcom,msm8953-adsp-pil", .data = &msm8996_adsp_resource},This one also in alphanumeric order, by compatible.
Will be fixed in the next iteration
Regards,
Sireesh Kodali
Quoted 4 lines
Best regards,
Krzysztof
PATCH v3 2/2 dt-bindings: remoteproc: qcom: adsp: Add ADSP on MSM8953
In reply to Sireesh KodaliAdd support for booting the Audio DSP on the MSM8953 platform. This is used by SoCs like SDM450, SDM625, SDM626, APQ8053, etc. Since the configuration is the same on all SoCs, a single compatible string is used.
--- Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml +5 -0
@@ -17,6 +17,7 @@ properties: compatible: enum: - qcom,msm8226-adsp-pil + - qcom,msm8953-adsp-pil - qcom,msm8974-adsp-pil - qcom,msm8996-adsp-pil - qcom,msm8996-slpi-pil
@@ -178,6 +179,7 @@ allOf: contains: enum: - qcom,msm8226-adsp-pil + - qcom,msm8953-adsp-pil - qcom,msm8974-adsp-pil - qcom,msm8996-adsp-pil - qcom,msm8996-slpi-pil
@@ -297,6 +299,7 @@ allOf: contains: enum: - qcom,msm8226-adsp-pil + - qcom,msm8953-adsp-pil - qcom,msm8974-adsp-pil - qcom,msm8996-adsp-pil - qcom,msm8996-slpi-pil
@@ -369,6 +372,7 @@ allOf: contains: enum: - qcom,msm8226-adsp-pil + - qcom,msm8953-adsp-pil - qcom,msm8996-adsp-pil - qcom,msm8998-adsp-pas - qcom,sm8150-adsp-pas
@@ -558,6 +562,7 @@ allOf: contains: enum: - qcom,msm8226-adsp-pil + - qcom,msm8953-adsp-pil - qcom,msm8974-adsp-pil - qcom,msm8996-adsp-pil - qcom,msm8996-slpi-pil
Signature · 1 line
2.37.3
Re: [PATCH v3 2/2] dt-bindings: remoteproc: qcom: adsp: Add ADSP on MSM8953
Quoted 6 lines · Sireesh Kodali
Add support for booting the Audio DSP on the MSM8953 platform. This is used by SoCs like SDM450, SDM625, SDM626, APQ8053, etc. Since the configuration is the same on all SoCs, a single compatible string is used.
Signed-off-by Sireesh Kodali <[email protected]>
Best regards,
Krzysztof