Change in openvpn[master]: options: Fix --hash-size virtual argument
A message that is not in the archive (sent off-list or not yet received): gerrit.1755870317000.Ibec7ffb9085503f72e79514776042bc310384f13@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1149?usp=email
to review the following change.
Change subject: options: Fix --hash-size virtual argument
......................................................................
options: Fix --hash-size virtual argument
Previously we ignored the second argument to --hash-size. This bug is older than the openvpn git repository, but clearly this is not an option often used (or at all).
---
M src/openvpn/options.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/49/1149/1
src/openvpn/options.c +1 -1
@@ -7951,7 +7951,7 @@ goto err; } options->real_hash_size = real; - options->virtual_hash_size = real; + options->virtual_hash_size = virtual; }else if (streq (p[0 ],"connect-freq" ) && p[1 ] && p[2 ] && !p[3 ]) {
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1149?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibec7ffb9085503f72e79514776042bc310384f13
Gerrit-Change-Number: 1149
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-MessageType: newchange
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1149?usp=email )
Change subject: options: Fix --hash-size virtual argument
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1149?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibec7ffb9085503f72e79514776042bc310384f13
Gerrit-Change-Number: 1149
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Fri, 22 Aug 2025 20:52:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
PATCH 1/1 options: Fix --hash-size virtual argument
In reply to a message not in the archiveFrom: Frank Lichtenheld <[email protected]...>
Previously we ignored the second argument to --hash-size. This bug is older than the openvpn git repository, but clearly this is not an option often used (or at all).
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1149
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>
src/openvpn/options.c +1 -1
@@ -7951,7 +7951,7 @@ goto err; } options->real_hash_size = real; - options->virtual_hash_size = real; + options->virtual_hash_size = virtual; }else if (streq (p[0 ],"connect-freq" ) && p[1 ] && p[2 ] && !p[3 ]) {
[Openvpn-devel] [PATCH applied] Re: options: Fix --hash-size virtual argument
Trivially correct. And amazing that this oversight is in the code since before the dawn of git...
I have not tested this, nor am I going to build a test rig that tests --hash-size variants. Anyone feels like a unit test? ;-)
Your patch has been applied to the master branch.
commit 4f7ae8acdecf2ad45319270a0045af92d610264c
Author: Frank Lichtenheld Date: Fri Aug 22 22:52:16 2025 +0200
options: Fix --hash-size virtual argument
Signed-off-by: Frank Lichtenheld <[email protected]...>
Acked-by: Gert Doering <[email protected]...>
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32658.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1149?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: options: Fix --hash-size virtual argument
......................................................................
options: Fix --hash-size virtual argument
Previously we ignored the second argument to --hash-size. This bug is older than the openvpn git repository, but clearly this is not an option often used (or at all).
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32658.html
---
M src/openvpn/options.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/49/1149/2
src/openvpn/options.c +1 -1
@@ -7951,7 +7951,7 @@ goto err; } options->real_hash_size = real; - options->virtual_hash_size = real; + options->virtual_hash_size = virtual; }else if (streq (p[0 ],"connect-freq" ) && p[1 ] && p[2 ] && !p[3 ]) {
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1149?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibec7ffb9085503f72e79514776042bc310384f13
Gerrit-Change-Number: 1149
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1149?usp=email )
Change subject: options: Fix --hash-size virtual argument
......................................................................
options: Fix --hash-size virtual argument
Previously we ignored the second argument to --hash-size. This bug is older than the openvpn git repository, but clearly this is not an option often used (or at all).
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32658.html
---
M src/openvpn/options.c
1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/options.c +1 -1
@@ -7951,7 +7951,7 @@ goto err; } options->real_hash_size = real; - options->virtual_hash_size = real; + options->virtual_hash_size = virtual; }else if (streq (p[0 ],"connect-freq" ) && p[1 ] && p[2 ] && !p[3 ]) {
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1149?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibec7ffb9085503f72e79514776042bc310384f13
Gerrit-Change-Number: 1149
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged