staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
PATCH v3 1/1 staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
---
changes in v4:
-Remove Whitespace in comment section of module_comedi_pci_driver()
to fix checkpatch Error.
changes in v3:
-Comment section of module_pci_driver() exceeds 75 characters.
Adjust the chars to 75 per line
-Modified log message.
-Added change log.
changes in v2:
-comedi_pci_auto_config() function prototype is exceeds
75 characters per line. Adjust to 75 chars to improve readability and also adjust the arguments to match open parantheses.
-Comment section of module_comedi_pci_driver() exceeds 75
characters. Modified contents to adjust 75 chars per line.
drivers/staging/comedi/comedi_pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/comedi_pci.h +1 -1
@@ -42,7 +42,7 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver, struct pci_driver *pci_driver);/** -* module_comedi_pci_driver()-Helper macro for registering a comedi PCI +* module_comedi_pci_driver()-Helper macro for registering a comedi PCI * driver * @__comedi_driver: comedi_driver struct * @__pci_driver: pci_driver struct
Signature · 1 line
2.17.1
Quoted 38 lines · Bhanusree Pola
Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
Signed-off-by Bhanusree Pola <[email protected]>---
changes in v4:
-Remove Whitespace in comment section ofmodule_comedi_pci_driver()
to fix checkpatch Error.changes in v3:
(quoted diff) +0
-3-Comment section of module_pci_driver() exceeds 75 characters. Adjust the chars to 75 per line -Modified log message. -Added change log.changes in v2:
(quoted diff) +0
-2-comedi_pci_auto_config() function prototype is exceeds 75 characters per line. Adjust to 75 chars to improve readability and also adjust the arguments to match open parantheses. -Comment section of module_comedi_pci_driver() exceeds 75 characters. Modified contents to adjust 75 chars per line. drivers/staging/comedi/comedi_pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/comedi/comedi_pci.h +1
-1@@ -42,7 +42,7 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver, struct pci_driver *pci_driver);/** -* module_comedi_pci_driver()-Helper macro for registering a comedi PCI +* module_comedi_pci_driver()-Helper macro for registering a comedi PCI * driver * @__comedi_driver: comedi_driver struct * @__pci_driver: pci_driver struct
Quoted 4 lines · Bhanusree Pola
Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
Signed-off-by Bhanusree Pola <[email protected]>---
Your subject says v3 but changelog says v4 ...
Quoted 26 lines
changes in v4:
-Remove Whitespace in comment section ofmodule_comedi_pci_driver()
to fix checkpatch Error.changes in v3:
(quoted diff) +0
-3-Comment section of module_pci_driver() exceeds 75 characters. Adjust the chars to 75 per line -Modified log message. -Added change log.changes in v2:
(quoted diff) +0
-2-comedi_pci_auto_config() function prototype is exceeds 75 characters per line. Adjust to 75 chars to improve readability and also adjust the arguments to match open parantheses. -Comment section of module_comedi_pci_driver() exceeds 75 characters. Modified contents to adjust 75 chars per line. drivers/staging/comedi/comedi_pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/comedi/comedi_pci.h +0
-0
drivers/staging/comedi/comedi_pci.h void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver, · line 45
Quoted 5 lines
drivers/staging/comedi/comedi_pci.h +1
-1@@ -42,7 +42,7 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver, struct pci_driver *pci_driver);/** -* module_comedi_pci_driver()-Helper macro for registering a comedi PCI +* module_comedi_pci_driver()-Helper macro for registering a comedi PCI
The change is identical ?
Use git rebase to fixup and send again.
Quoted 12 lines
drivers/staging/comedi/comedi_pci.h +0
-0* driver * @__comedi_driver: comedi_driver struct * @__pci_driver: pci_driver struct Signature · 8 lines
2.17.1 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181006135752.GA3037%40veda-VGN-CS3AGH-R. For more options, visit https://groups.google.com/d/optout.
Signature · 4 lines
Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): 20181006180243.GG6283@himanshu-Vostro-3559
Quoted 11 lines
Then please state that reasoning in subject too ...
Subject: [PATCH v4] ....
---
changelog:v4: corrected whitespace error.
v3: ...
v2: ...
I made changes mentioned and sent already with Subject:[PATCH v4]. Am I supposed to send it again?
Quoted 17 lines · Himanshu Jha
Quoted 2 lines · Bhanusree
Change is not identical. In v3 whitespace error is observed. So corrected it and sent as v4 again.
Then please state that reasoning in subject too ...
Subject: [PATCH v4] ....
---
changelog:v4: corrected whitespace error.
v3: ...
v2: ...And use 'reply-all` please!
Quoted 8 lines · Bhanusree
Quoted 7 lines
Then please state that reasoning in subject too ...
Subject: [PATCH v4] ....
---
changelog:
Quoted 6 lines
Quoted 3 lines
v4: corrected whitespace error.
v3: ...
v2: ...I made changes mentioned and sent already with Subject:[PATCH v4]. Am I supposed to send it again?
Ah, I see.
Subject: [Outreachy kernel] Re: [Outreachy Kernel][PATCH v4] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
You send the patch as a "Re:" as you forgot to use get_maintainer in the first place.
Took me some time to figure that out.
And I think this is not the correct way.
Signature · 4 lines
Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology
Please let me know what to do on this ?
Quoted 22 lines · Himanshu Jha
Quoted 10 lines · Bhanusree
Quoted 8 lines
Then please state that reasoning in subject too ...
Subject: [PATCH v4] ....---
changelog:
v4: corrected whitespace error.
v3: ...
v2: ...I made changes mentioned and sent already with Subject:[PATCH v4]. Am I supposed to send it again?
Ah, I see.
Subject: [Outreachy kernel] Re: [Outreachy Kernel][PATCH v4] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
You send the patch as a "Re:" as you forgot to use
get_maintainerin the first place.Took me some time to figure that out.
And I think this is not the correct way.
Quoted 1 line · Bhanusree
Please let me know what to do on this ?
Send a new patch with v5 with changelog.
And don't top-post!
Signature · 4 lines
Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology
Quoted 3 lines · Himanshu Jha
Quoted 2 lines · Bhanusree
Please let me know what to do on this ?
Send a new patch with v5 with changelog.
Can I mention 'No changes in v5' in change log or am I supposed to mention any ?
Quoted 8 lines · Bhanusree
Quoted 3 lines · Himanshu Jha
Quoted 2 lines · Bhanusree
Please let me know what to do on this ?
Send a new patch with v5 with changelog.Can I mention 'No changes in v5' in change log or am I supposed to mention any ?
Your comments about the changes in the version go under the --- so that they don't appear in the change log. If there are no changes in some cases, then you should mention that.
julia
Quoted 11 lines
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected]. To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/4e37d6bc-9b6f-f128-38fc-8fca295573d4%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Quoted 2 lines · Bhanusree Pola
Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
Would you mind explaining this:
from: Bhanusree Pola <[email protected]>
reply-to: [email protected]
to: [email protected]
cc: [email protected],
[email protected]
date: 6 Oct 2018, 16:44
subject: [Outreachy kernel][PATCH v2]staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
mailing list: [email protected] Filter messages from this mailing list
mailed-by: googlegroups.com
Signed by: gmail.com
"reply-to" ?
Please check your email settings!
Signature · 4 lines
Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology
Quoted 16 lines · Himanshu Jha
Quoted 2 lines · Bhanusree Pola
Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
Would you mind explaining this:
from: Bhanusree Pola <[email protected]>
reply-to: [email protected]
to: [email protected]
cc: [email protected],
[email protected]
date: 6 Oct 2018, 16:44
subject: [Outreachy kernel][PATCH v2]staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
mailing list: [email protected] Filter messages from this mailing list
mailed-by: googlegroups.com
Signed by: gmail.com
Quoted 4 lines
"reply-to" ?
Quoted 1 line
Please check your email settings!
I did not understand.What was the mistake i have done ? shouldn't I mention "reply-to" in specific ?
Quoted 19 lines · Bhanusree
Quoted 16 lines · Himanshu Jha
Quoted 2 lines · Bhanusree Pola
Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
Would you mind explaining this:
from: Bhanusree Pola <[email protected]>
reply-to: [email protected]
to: [email protected]
cc: [email protected],
[email protected]
date: 6 Oct 2018, 16:44
subject: [Outreachy kernel][PATCH v2]staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
mailing list: [email protected] Filter messages from this mailing list
mailed-by: googlegroups.com
Signed by: gmail.com
Quoted 6 lines
Quoted 4 lines
"reply-to" ?
Quoted 1 line
Please check your email settings!
I did not understand.What was the mistake i have done ? shouldn't I mention "reply-to" in specific ?
Lookout for the purpose for "reply-to".
If someone replies to this thread, that reply would go to address mentioned in the "reply-to" which is currently my email address.
reply-to: [email protected]
I hope I'm clear now.
You can add *your* secondary address in reply-to if you want to receive the reply at that specified address.
Signature · 4 lines
Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology
Thank you.
Quoted 36 lines · Himanshu Jha
Quoted 18 lines · Bhanusree
Quoted 16 lines · Himanshu Jha
Quoted 2 lines · Bhanusree Pola
Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
Would you mind explaining this:
from: Bhanusree Pola <[email protected]>
reply-to: [email protected]
to: [email protected]
cc: [email protected],
[email protected]
date: 6 Oct 2018, 16:44
subject: [Outreachy kernel][PATCH v2]staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
mailing list: [email protected] Filter messages from this mailing list
mailed-by: googlegroups.com
Signed by: gmail.comQuoted 5 lines
Quoted 3 lines
"reply-to" ?
Quoted 1 line
Please check your email settings!
I did not understand.What was the mistake i have done ? shouldn't I mention "reply-to" in specific ?
Lookout for the purpose for "reply-to".
If someone replies to this thread, that reply would go to address mentioned in the "reply-to" which is currently my email address.
reply-to: [email protected]
I hope I'm clear now.
You can add *your* secondary address in reply-to if you want to receive the reply at that specified address.