Skip to contentSkip to conversation

tps6105x add devicetree and leds support

PATCH Superseded Sven Van Asbroeck 4 participants 12 messages Nov 21, 2019 – Dec 10, 2019

Subsystems (3)

v4 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v4 cover tps6105x add devicetree and leds support

v3 -> v4:
Removed tps6105 mfd patch - it was accepted (Mark Brown).

Use the new LED registration API - suggested by Jacek Anaszewski.

Updated led dt bindings to document function, color usage.

v2 -> v3:
Removed tps6105x regulator patch - it was accepted (Mark Brown).

Removed devicetree/platdata bindings for tps6105x led naming. I can test only with a 4.19 vendor kernel, which does not have the latest led naming infrastructure (function/color). Drop devicetree/ fwnode/pdata led naming in favour of hard-coding to "tps6105x::torch", so the patch can be tested by me, yet remains acceptable to upstream.

v1 -> v2:
Select chip operational mode by looking at subnode name, _not_ its compatible property. Suggested by Mark Brown.

I needed led operation for this mfd chip, so I added a very simple driver for this.

My platform (arm imx6q) is devicetree-based, so I added optional devicetree support for this chip and its sub-drivers.

Sven Van Asbroeck (2):
leds: tps6105x: add driver for mfd chip led mode
dt-bindings: mfd: update TI tps6105x chip bindings

 .../devicetree/bindings/mfd/tps6105x.txt      | 47 ++++++++++-
 drivers/leds/Kconfig                          | 10 +++
 drivers/leds/Makefile                         |  1 +
 drivers/leds/leds-tps6105x.c                  | 83 +++++++++++++++++++
 4 files changed, 140 insertions(+), 1 deletion(-)
 create mode 100644 drivers/leds/leds-tps6105x.c
Signature · 1 line
2.17.1
#1 lore raw

PATCH v4 1/2 leds: tps6105x: add driver for mfd chip led mode

This driver adds support for the led operational mode of the tps6105x mfd device.

Tree: next-20191118

---
 drivers/leds/Kconfig         | 10 +++++
 drivers/leds/Makefile        |  1 +
 drivers/leds/leds-tps6105x.c | 83 ++++++++++++++++++++++++++++++++++++
 3 files changed, 94 insertions(+)
 create mode 100644 drivers/leds/leds-tps6105x.c
drivers/leds/Kconfig +10 -0
index 4b68520ac251..7c7ceaa824a2 100644
@@ -836,6 +836,16 @@ config LEDS_LM36274
 	  Say Y to enable the LM36274 LED driver for TI LMU devices.
 	  This supports the LED device LM36274.
 
+config LEDS_TPS6105X
+	tristate "LED support for TI TPS6105X"
+	depends on LEDS_CLASS
+	depends on TPS6105X
+	default y if TPS6105X
+	help
+	  This driver supports TPS61050/TPS61052 led chips.
+	  It is a single boost converter primarily for white LEDs and
+	  audio amplifiers.
+
 comment "LED Triggers"
 source "drivers/leds/trigger/Kconfig"
 
drivers/leds/Makefile +1 -0
index 2da39e896ce8..d7e1107753fb 100644
@@ -85,6 +85,7 @@ obj-$(CONFIG_LEDS_LM3601X)		+= leds-lm3601x.o
 obj-$(CONFIG_LEDS_TI_LMU_COMMON)	+= leds-ti-lmu-common.o
 obj-$(CONFIG_LEDS_LM3697)		+= leds-lm3697.o
 obj-$(CONFIG_LEDS_LM36274)		+= leds-lm36274.o
+obj-$(CONFIG_LEDS_TPS6105X)		+= leds-tps6105x.o
 
 # LED SPI Drivers
 obj-$(CONFIG_LEDS_CR0014114)		+= leds-cr0014114.o
drivers/leds/leds-tps6105x.c new file +83 -0

83 lines not on this page · raw message

Signature · 1 line
2.17.1
#2 lore raw

PATCH v4 2/2 dt-bindings: mfd: update TI tps6105x chip bindings

In reply to Sven Van Asbroeck

The driver has been extended to optionally get its operational mode, regulator init data and led naming from the devicetree.

Tree: next-20191118

---
 .../devicetree/bindings/mfd/tps6105x.txt      | 47 ++++++++++++++++++-
 1 file changed, 46 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/tps6105x.txt +46 -1
index 93602c7a19c8..1fc9aa3ed882 100644
@@ -7,11 +7,56 @@ Required properties:
 - compatible:		"ti,tps61050" or "ti,tps61052"
 - reg:			Specifies the I2C slave address
 
-Example:
+Optional sub-node:
+
+This subnode selects the chip's operational mode.
+There can be at most one single available subnode.
+
+- regulator: presence of this sub-node puts the chip in regulator mode.
+	see Documentation/devicetree/bindings/regulator/regulator.txt
+
+- led: presence of this sub-node puts the chip in led mode.
+	Optional properties:
+	- function : see Documentation/devicetree/bindings/leds/common.txt
+	- color : see Documentation/devicetree/bindings/leds/common.txt
+	- label : see Documentation/devicetree/bindings/leds/common.txt
+			(deprecated)
+
+Example (GPIO operation only):
+
+i2c0 {
+	tps61052@33 {
+		compatible = "ti,tps61052";
+		reg = <0x33>;
+	};
+};
+
+Example (GPIO + regulator operation):
 
 i2c0 {
 	tps61052@33 {
 		compatible = "ti,tps61052";
 		reg = <0x33>;
+
+		regulator {
+			regulator-min-microvolt = <5000000>;
+			regulator-max-microvolt = <5000000>;
+			regulator-always-on;
+		};
+	};
+};
+
+Example (GPIO + led operation):
+
+#include <dt-bindings/leds/common.h>
+
+i2c0 {
+	tps61052@33 {
+		compatible = "ti,tps61052";
+		reg = <0x33>;
+
+		led {
+			color = <LED_COLOR_ID_WHITE>;
+		};
 	};
 };
Signature · 1 line
2.17.1
maintainer Reviewed-by on v4 2/2
#3 lore raw

Re: [PATCH v4 2/2] dt-bindings: mfd: update TI tps6105x chip bindings

Quoted 9 lines · Sven Van Asbroeck

The driver has been extended to optionally get its operational mode, regulator init data and led naming from the devicetree.

Tree: next-20191118

---
 .../devicetree/bindings/mfd/tps6105x.txt      | 47 ++++++++++++++++++-
 1 file changed, 46 insertions(+), 1 deletion(-)
#4 lore raw

Re: [PATCH v4 2/2] dt-bindings: mfd: update TI tps6105x chip bindings

In reply to Sven Van Asbroeck
Quoted 2 lines · Sven Van Asbroeck

The driver has been extended to optionally get its operational mode, regulator init data and led naming from the devicetree.

s/led/LED/

Quoted 1 line

Tree: next-20191118

Why is this in your commit message?

Quoted 18 lines
---
 .../devicetree/bindings/mfd/tps6105x.txt      | 47 ++++++++++++++++++-
 1 file changed, 46 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/tps6105x.txt +4 -1
index 93602c7a19c8..1fc9aa3ed882 100644
@@ -7,11 +7,56 @@ Required properties:
 - compatible:		"ti,tps61050" or "ti,tps61052"
 - reg:			Specifies the I2C slave address
 
-Example:
+Optional sub-node:
+
+This subnode selects the chip's operational mode.
+There can be at most one single available subnode.

Documentation/devicetree/bindings/mfd/tps6105x.txt Required properties: · line 23

Quoted 10 lines
Documentation/devicetree/bindings/mfd/tps6105x.txt +10 -0
+
+- regulator: presence of this sub-node puts the chip in regulator mode.
+	see Documentation/devicetree/bindings/regulator/regulator.txt
+
+- led: presence of this sub-node puts the chip in led mode.
+	Optional properties:
+	- function : see Documentation/devicetree/bindings/leds/common.txt
+	- color : see Documentation/devicetree/bindings/leds/common.txt
+	- label : see Documentation/devicetree/bindings/leds/common.txt
+			(deprecated)

Nit:

Could you please use relative paths here.

If you line up the ':', it would look slightly cleaner.

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#5 lore raw

Re: [PATCH v4 2/2] dt-bindings: mfd: update TI tps6105x chip bindings

Hi Lee, thank you for the review.

Quoted 4 lines · Lee Jones
Quoted 2 lines

Tree: next-20191118

Why is this in your commit message?

I have been posting patches against various maintainer trees lately, which will not apply to mainline or next. So I have been including base tree information in the patch itself.

Base-tree info on patches is high on developers' wish list, but not yet standardized. This was discussed at the 2019 kernel maintainers summit:
https://lwn.net/Articles/803619/

#6 lore raw

Re: [PATCH v4 2/2] dt-bindings: mfd: update TI tps6105x chip bindings

Quoted 8 lines · Sven Van Asbroeck

Hi Lee, thank you for the review.

Quoted 4 lines · Lee Jones
Quoted 2 lines

Tree: next-20191118

Why is this in your commit message?

Quoted 8 lines

I have been posting patches against various maintainer trees lately, which will not apply to mainline or next. So I have been including base tree information in the patch itself.

Base-tree info on patches is high on developers' wish list, but not yet standardized. This was discussed at the 2019 kernel maintainers summit:
https://lwn.net/Articles/803619/

NB: I haven't seen this discussion (or opened this link just yet).

It's no problem to have it in the submission, but it would be better to have it *below* the '--' with the diff, such that if it is applied, it doesn't end up in the kernel's Git history.

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#7 lore raw

Re: [PATCH v4 2/2] dt-bindings: mfd: update TI tps6105x chip bindings

Quoted 19 lines · Lee Jones
Quoted 8 lines · Sven Van Asbroeck

Hi Lee, thank you for the review.

Quoted 4 lines · Lee Jones
Quoted 2 lines

Tree: next-20191118

Why is this in your commit message?

Quoted 8 lines

I have been posting patches against various maintainer trees lately, which will not apply to mainline or next. So I have been including base tree information in the patch itself.

Base-tree info on patches is high on developers' wish list, but not yet standardized. This was discussed at the 2019 kernel maintainers summit:
https://lwn.net/Articles/803619/

Quoted 5 lines

NB: I haven't seen this discussion (or opened this link just yet).

It's no problem to have it in the submission, but it would be better to have it *below* the '--' with the diff, such that if it is applied, it doesn't end up in the kernel's Git history.

Obviously that was meant to be '---'.

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Acked-by on the v4 series
#8 lore raw
In reply to Sven Van Asbroeck

Hi Sven,

Thank you for the updated set.

For both patches:

Best regards,
Jacek Anaszewski

Quoted 37 lines · Sven Van Asbroeck

v3 -> v4:
Removed tps6105 mfd patch - it was accepted (Mark Brown).

Use the new LED registration API - suggested by Jacek Anaszewski.

Updated led dt bindings to document function, color usage.

v2 -> v3:
Removed tps6105x regulator patch - it was accepted (Mark Brown).

Removed devicetree/platdata bindings for tps6105x led naming. I can test only with a 4.19 vendor kernel, which does not have the latest led naming infrastructure (function/color). Drop devicetree/ fwnode/pdata led naming in favour of hard-coding to "tps6105x::torch", so the patch can be tested by me, yet remains acceptable to upstream.

v1 -> v2:
Select chip operational mode by looking at subnode name, _not_ its compatible property. Suggested by Mark Brown.

I needed led operation for this mfd chip, so I added a very simple driver for this.

My platform (arm imx6q) is devicetree-based, so I added optional devicetree support for this chip and its sub-drivers.

Sven Van Asbroeck (2):
leds: tps6105x: add driver for mfd chip led mode
dt-bindings: mfd: update TI tps6105x chip bindings

 .../devicetree/bindings/mfd/tps6105x.txt      | 47 ++++++++++-
 drivers/leds/Kconfig                          | 10 +++
 drivers/leds/Makefile                         |  1 +
 drivers/leds/leds-tps6105x.c                  | 83 +++++++++++++++++++
 4 files changed, 140 insertions(+), 1 deletion(-)
 create mode 100644 drivers/leds/leds-tps6105x.c
#9 lore raw
Quoted 4 lines · Jacek Anaszewski

For both patches:

Thank you Jacek. To get accepted in a maintainer tree, does this patch need more acks/reviews?
Should I continue to include it in new patch set versions if it doesn't change?

#10 lore raw
Quoted 9 lines · Sven Van Asbroeck
Quoted 4 lines · Jacek Anaszewski

For both patches:

Thank you Jacek. To get accepted in a maintainer tree, does this patch need more acks/reviews?

It should get ack from Pavel Machek since he now maintains LED tree.

I'd say that it should be merged in one batch with the related change to the MFD driver, but this is to be agreed upon by Pavel and Lee, via which tree it will go.

Quoted 2 lines

Should I continue to include it in new patch set versions if it doesn't change?

You can include it, and add my ack.

However, you could remove also below lines, since you switched to using color DT property and a new LED registration API:

- init_data.devicename = "tps6105x";
- init_data.default_label = ":torch";

Signature · 2 lines
Best regards,
Jacek Anaszewski