Skip to contentSkip to conversation

Tegra: add ASUS/Google Nexus 7 (2012) support

PATCH Superseded Svyatoslav Ryhel 2 participants 18 messages Jun 6, 2023 – Jun 8, 2023

Subsystems (3)

v5 of 9 Superseded Latest is v9 →

lore
Share & tools
lore
#0 lore raw

v5 cover Tegra: add ASUS/Google Nexus 7 (2012) support

This patchset adds support for native use of U-Boot on:
- ASUS T30 Transformers (7 devices, all models);
- ASUS/Google Nexus 7 (2012), both grouper and tilapia
- LG Optimus 4X HD (P880) and Optimus Vu (P895)
- HTC One X (endeavoru)
as a replacement for the vendor bootloader.

Current commits are designed to work on re-crypted devices but can be used on clean unmodified devices with slight restrictions (like no booting/mounting emmc and no self updating feature).

All device setup commits fall under the same pattern. Alongside device bringup tegra requires few small patches:
 - add gpio keyboard as stdin device
 - make networking boot options optional
 - add a small tool to generate SoC UID

Commits passed ./tools/buildman/buildman tegra
Building current source for 30 boards (12 threads, 1 job per thread)
30 0 0 /30 0:00:06 : apalis_t30
Completed: 30 total built, 30 newly), duration 0:05:23, rate 0.09

---
Changes from v4:
- fixed documentation
- fixed CONFIG_* definitions

Changes from v3:
- extended amount of devices supported

Changes from v2:
- fuse build is excluded for T186 (it is not supported in it anyway)

Changes from v1:
- fix fuse headers for newer Tegra generations
- allow grouper_common_defconfig to pass without fragments
---

Jonas Schwöbel (1):
configs: tegra-common-post: make PXE and DHCP boot targets optional

Svyatoslav Ryhel (6):
configs: tegra-common-post: add GPIO keyboard as STDIN device
ARM: tegra: add SoC UID calculation function
board: asus: transformer: add ASUS Transformer T30 family support
board: asus: grouper: add Google Nexus 7 (2012) support
board: lg: x3: add Optimus 4X HD and Optimus Vu support
board: htc: endeavoru: add One X support

 arch/arm/dts/Makefile                         |  12 +
 arch/arm/dts/tegra30-asus-grouper-common.dtsi | 157 ++++++
 .../dts/tegra30-asus-nexus7-grouper-E1565.dts |  43 ++
 .../dts/tegra30-asus-nexus7-grouper-PM269.dts |  36 ++
 .../dts/tegra30-asus-nexus7-tilapia-E1565.dts |  62 +++
 arch/arm/dts/tegra30-asus-p1801-t.dts         |  17 +
 arch/arm/dts/tegra30-asus-tf201.dts           |   9 +
 arch/arm/dts/tegra30-asus-tf300t.dts          |  18 +
 arch/arm/dts/tegra30-asus-tf300tg.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf300tl.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf600t.dts          |  89 ++++
 arch/arm/dts/tegra30-asus-tf700t.dts          |  13 +
 arch/arm/dts/tegra30-asus-transformer.dtsi    | 211 ++++++++
 arch/arm/dts/tegra30-htc-endeavoru.dts        | 166 +++++++
 arch/arm/dts/tegra30-lg-p880.dts              |  40 ++
 arch/arm/dts/tegra30-lg-p895.dts              |  50 ++
 arch/arm/dts/tegra30-lg-x3.dtsi               | 180 +++++++
 arch/arm/include/asm/arch-tegra/fuse.h        |   7 +
 arch/arm/mach-tegra/Makefile                  |   4 +
 arch/arm/mach-tegra/fuse.c                    | 151 ++++++
 arch/arm/mach-tegra/tegra30/Kconfig           |  20 +
 board/asus/grouper/Kconfig                    |  22 +
 board/asus/grouper/MAINTAINERS                |   6 +
 board/asus/grouper/Makefile                   |  14 +
 board/asus/grouper/grouper-spl-max.c          |  45 ++
 board/asus/grouper/grouper-spl-ti.c           |  41 ++
 board/asus/grouper/grouper.c                  | 202 ++++++++
 board/asus/grouper/pinmux-config-grouper.h    | 362 ++++++++++++++
 board/asus/transformer-t30/Kconfig            |  23 +
 board/asus/transformer-t30/MAINTAINERS        |   6 +
 board/asus/transformer-t30/Makefile           |  11 +
 .../pinmux-config-transformer.h               | 365 ++++++++++++++
 .../transformer-t30/transformer-t30-spl.c     |  41 ++
 board/asus/transformer-t30/transformer-t30.c  | 201 ++++++++
 board/htc/endeavoru/Kconfig                   |  12 +
 board/htc/endeavoru/MAINTAINERS               |   6 +
 board/htc/endeavoru/Makefile                  |  11 +
 board/htc/endeavoru/endeavoru-spl.c           |  47 ++
 board/htc/endeavoru/endeavoru.c               | 116 +++++
 board/htc/endeavoru/pinmux-config-endeavoru.h | 362 ++++++++++++++
 board/lg/x3-t30/Kconfig                       |  26 +
 board/lg/x3-t30/MAINTAINERS                   |   6 +
 board/lg/x3-t30/Makefile                      |  11 +
 board/lg/x3-t30/pinmux-config-x3.h            | 449 ++++++++++++++++++
 board/lg/x3-t30/x3-t30-spl.c                  |  48 ++
 board/lg/x3-t30/x3-t30.c                      | 176 +++++++
 configs/endeavoru_defconfig                   |  84 ++++
 configs/grouper_E1565.config                  |   2 +
 configs/grouper_PM269.config                  |   2 +
 configs/grouper_common_defconfig              |  84 ++++
 configs/p1801-t.config                        |   2 +
 configs/p880.config                           |   4 +
 configs/p895.config                           |   4 +
 configs/tf201.config                          |   2 +
 configs/tf300t.config                         |   2 +
 configs/tf300tg.config                        |   2 +
 configs/tf300tl.config                        |   2 +
 configs/tf600t.config                         |   4 +
 configs/tf700t.config                         |   2 +
 configs/tilapia.config                        |   3 +
 configs/transformer_t30_defconfig             |  85 ++++
 configs/x3_t30_defconfig                      |  88 ++++
 doc/board/asus/grouper_common.rst             |  95 ++++
 doc/board/asus/index.rst                      |  10 +
 doc/board/asus/transformer_t30.rst            |  96 ++++
 doc/board/htc/endeavoru.rst                   |  90 ++++
 doc/board/htc/index.rst                       |   9 +
 doc/board/lg/index.rst                        |   9 +
 doc/board/lg/x3_t30.rst                       |  93 ++++
 include/configs/endeavoru.h                   |  65 +++
 include/configs/grouper.h                     |  61 +++
 include/configs/tegra-common-post.h           |  28 +-
 include/configs/transformer-common.h          |  94 ++++
 include/configs/transformer-t30.h             |  23 +
 include/configs/x3-t30.h                      |  77 +++
 75 files changed, 5029 insertions(+), 5 deletions(-)
 create mode 100644 arch/arm/dts/tegra30-asus-grouper-common.dtsi
 create mode 100644 arch/arm/dts/tegra30-asus-nexus7-grouper-E1565.dts
 create mode 100644 arch/arm/dts/tegra30-asus-nexus7-grouper-PM269.dts
 create mode 100644 arch/arm/dts/tegra30-asus-nexus7-tilapia-E1565.dts
 create mode 100644 arch/arm/dts/tegra30-asus-p1801-t.dts
 create mode 100644 arch/arm/dts/tegra30-asus-tf201.dts
 create mode 100644 arch/arm/dts/tegra30-asus-tf300t.dts
 create mode 100644 arch/arm/dts/tegra30-asus-tf300tg.dts
 create mode 100644 arch/arm/dts/tegra30-asus-tf300tl.dts
 create mode 100644 arch/arm/dts/tegra30-asus-tf600t.dts
 create mode 100644 arch/arm/dts/tegra30-asus-tf700t.dts
 create mode 100644 arch/arm/dts/tegra30-asus-transformer.dtsi
 create mode 100644 arch/arm/dts/tegra30-htc-endeavoru.dts
 create mode 100644 arch/arm/dts/tegra30-lg-p880.dts
 create mode 100644 arch/arm/dts/tegra30-lg-p895.dts
 create mode 100644 arch/arm/dts/tegra30-lg-x3.dtsi
 create mode 100644 arch/arm/mach-tegra/fuse.c
 create mode 100644 board/asus/grouper/Kconfig
 create mode 100644 board/asus/grouper/MAINTAINERS
 create mode 100644 board/asus/grouper/Makefile
 create mode 100644 board/asus/grouper/grouper-spl-max.c
 create mode 100644 board/asus/grouper/grouper-spl-ti.c
 create mode 100644 board/asus/grouper/grouper.c
 create mode 100644 board/asus/grouper/pinmux-config-grouper.h
 create mode 100644 board/asus/transformer-t30/Kconfig
 create mode 100644 board/asus/transformer-t30/MAINTAINERS
 create mode 100644 board/asus/transformer-t30/Makefile
 create mode 100644 board/asus/transformer-t30/pinmux-config-transformer.h
 create mode 100644 board/asus/transformer-t30/transformer-t30-spl.c
 create mode 100644 board/asus/transformer-t30/transformer-t30.c
 create mode 100644 board/htc/endeavoru/Kconfig
 create mode 100644 board/htc/endeavoru/MAINTAINERS
 create mode 100644 board/htc/endeavoru/Makefile
 create mode 100644 board/htc/endeavoru/endeavoru-spl.c
 create mode 100644 board/htc/endeavoru/endeavoru.c
 create mode 100644 board/htc/endeavoru/pinmux-config-endeavoru.h
 create mode 100644 board/lg/x3-t30/Kconfig
 create mode 100644 board/lg/x3-t30/MAINTAINERS
 create mode 100644 board/lg/x3-t30/Makefile
 create mode 100644 board/lg/x3-t30/pinmux-config-x3.h
 create mode 100644 board/lg/x3-t30/x3-t30-spl.c
 create mode 100644 board/lg/x3-t30/x3-t30.c
 create mode 100644 configs/endeavoru_defconfig
 create mode 100644 configs/grouper_E1565.config
 create mode 100644 configs/grouper_PM269.config
 create mode 100644 configs/grouper_common_defconfig
 create mode 100644 configs/p1801-t.config
 create mode 100644 configs/p880.config
 create mode 100644 configs/p895.config
 create mode 100644 configs/tf201.config
 create mode 100644 configs/tf300t.config
 create mode 100644 configs/tf300tg.config
 create mode 100644 configs/tf300tl.config
 create mode 100644 configs/tf600t.config
 create mode 100644 configs/tf700t.config
 create mode 100644 configs/tilapia.config
 create mode 100644 configs/transformer_t30_defconfig
 create mode 100644 configs/x3_t30_defconfig
 create mode 100644 doc/board/asus/grouper_common.rst
 create mode 100644 doc/board/asus/index.rst
 create mode 100644 doc/board/asus/transformer_t30.rst
 create mode 100644 doc/board/htc/endeavoru.rst
 create mode 100644 doc/board/htc/index.rst
 create mode 100644 doc/board/lg/index.rst
 create mode 100644 doc/board/lg/x3_t30.rst
 create mode 100644 include/configs/endeavoru.h
 create mode 100644 include/configs/grouper.h
 create mode 100644 include/configs/transformer-common.h
 create mode 100644 include/configs/transformer-t30.h
 create mode 100644 include/configs/x3-t30.h
Signature · 1 line
2.39.2
#1 lore raw

PATCH v5 1/7 configs: tegra-common-post: add GPIO keyboard as STDIN device

GPIO keyboard is used on many newly upstreamed devices.

---
 include/configs/tegra-common-post.h | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
include/configs/tegra-common-post.h +7 -1
index 991ffbb7df..2d5095639a 100644
@@ -35,6 +35,12 @@
 #define STDIN_KBD_USB ""
 #endif
 
+#ifdef CONFIG_BUTTON_KEYBOARD
+#define STDIN_BTN_KBD ",button-kbd"
+#else
+#define STDIN_BTN_KBD ""
+#endif
+
 #ifdef CONFIG_VIDEO
 #define STDOUT_VIDEO ",vidconsole"
 #else
@@ -48,7 +54,7 @@
 #endif
 
 #define TEGRA_DEVICE_SETTINGS \
-	"stdin=serial" STDIN_KBD_KBC STDIN_KBD_USB STDOUT_CROS_EC "\0" \
+	"stdin=serial" STDIN_KBD_KBC STDIN_KBD_USB STDOUT_CROS_EC STDIN_BTN_KBD "\0" \
 	"stdout=serial" STDOUT_VIDEO "\0" \
 	"stderr=serial" STDOUT_VIDEO "\0" \
 	""
Signature · 1 line
2.39.2
#2 lore raw

PATCH v5 2/7 configs: tegra-common-post: make PXE and DHCP boot targets optional

In reply to Svyatoslav Ryhel

From: Jonas Schwöbel <[email protected]>

Disabling the network related features in defconfig causes build to fail so make them optional.

---
 include/configs/tegra-common-post.h | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)
include/configs/tegra-common-post.h +16 -4
index 2d5095639a..0d0965ecce 100644
@@ -8,9 +8,21 @@
 #define __TEGRA_COMMON_POST_H
 
 #if IS_ENABLED(CONFIG_CMD_USB)
-# define BOOT_TARGET_USB(func) func(USB, usb, 0)
+#define BOOT_TARGET_USB(func) func(USB, usb, 0)
 #else
-# define BOOT_TARGET_USB(func)
+#define BOOT_TARGET_USB(func)
+#endif
+
+#if CONFIG_IS_ENABLED(CMD_DHCP) && CONFIG_IS_ENABLED(CMD_PXE)
+#define BOOT_TARGET_PXE(func) func(PXE, pxe, na)
+#else
+#define BOOT_TARGET_PXE(func)
+#endif
+
+#if CONFIG_IS_ENABLED(CMD_DHCP)
+#define BOOT_TARGET_DHCP(func) func(DHCP, dhcp, na)
+#else
+#define BOOT_TARGET_DHCP(func)
 #endif
 
 #ifndef BOOT_TARGET_DEVICES
@@ -18,8 +30,8 @@
 	func(MMC, mmc, 1) \
 	func(MMC, mmc, 0) \
 	BOOT_TARGET_USB(func) \
-	func(PXE, pxe, na) \
-	func(DHCP, dhcp, na)
+	BOOT_TARGET_PXE(func) \
+	BOOT_TARGET_DHCP(func)
 #endif
 #include <config_distro_bootcmd.h>
 
Signature · 1 line
2.39.2
#3 lore raw

PATCH v5 3/7 ARM: tegra: add SoC UID calculation function

In reply to Svyatoslav Ryhel

This is a small tool for calculation of SoC UID based on the same Linux function. It can be further used for generation of device unique data like mac address or exposing it as serial number.

---
 arch/arm/include/asm/arch-tegra/fuse.h |   7 ++
 arch/arm/mach-tegra/Makefile           |   4 +
 arch/arm/mach-tegra/fuse.c             | 151 +++++++++++++++++++++++++
 3 files changed, 162 insertions(+)
 create mode 100644 arch/arm/mach-tegra/fuse.c
arch/arm/include/asm/arch-tegra/fuse.h +7 -0
index 5b8e0bd8d1..f3f2ad8e3f 100644
@@ -19,4 +19,11 @@ struct fuse_regs {
 	u32 security_mode;		/* 0x1A0: FUSE_SECURITY_MODE */
 };
 
+/**
+ * Calculate SoC UID
+ *
+ * Return: uid if ok, 0 on error
+ */
+unsigned long long tegra_chip_uid(void);
+
 #endif	/* ifndef _FUSE_H_ */
arch/arm/mach-tegra/Makefile +4 -0
index 9147050b32..a5733b0bf6 100644
@@ -32,6 +32,10 @@ endif
 obj-$(CONFIG_DISPLAY_CPUINFO) += sys_info.o
 obj-y += pmc.o
 
+ifndef CONFIG_TEGRA186
+obj-y += fuse.o
+endif
+
 obj-$(CONFIG_TEGRA20) += tegra20/
 obj-$(CONFIG_TEGRA30) += tegra30/
 obj-$(CONFIG_TEGRA114) += tegra114/
arch/arm/mach-tegra/fuse.c new file +151 -0

151 lines not on this page · raw message

Signature · 1 line
2.39.2
#4 lore raw

PATCH v5 4/7 board: asus: transformer: add ASUS Transformer T30 family support

In reply to Svyatoslav Ryhel

The ASUS Transformer T30 family are 2-in-1 detachable tablets and AiO developed by ASUS that run the Android operating system (TF600T runs Windows RT and P1801-T runs Android and Windows). The T30 Transformers feature a 10.1-inch display (apart P1801-T), an Nvidia Tegra 3 quad-core chip, 1/2 GB of RAM, and 16/32 GB of storage. Transformers board derives from Nvidia Cardhu development board.

This patch brings support for 7 known Transformer devices:
- ASUS Transformer Prime TF201
- ASUS Transformer Pad TF300T/TF300TG/TF300TL
- ASUS VivoTab RT TF600T (Windows RT based)
- ASUS Transformer Infinity TF700T
- ASUS Transformer AiO P1801-T

---
 arch/arm/dts/Makefile                         |   7 +
 arch/arm/dts/tegra30-asus-p1801-t.dts         |  17 +
 arch/arm/dts/tegra30-asus-tf201.dts           |   9 +
 arch/arm/dts/tegra30-asus-tf300t.dts          |  18 +
 arch/arm/dts/tegra30-asus-tf300tg.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf300tl.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf600t.dts          |  89 +++++
 arch/arm/dts/tegra30-asus-tf700t.dts          |  13 +
 arch/arm/dts/tegra30-asus-transformer.dtsi    | 211 ++++++++++
 arch/arm/mach-tegra/tegra30/Kconfig           |   5 +
 board/asus/transformer-t30/Kconfig            |  23 ++
 board/asus/transformer-t30/MAINTAINERS        |   6 +
 board/asus/transformer-t30/Makefile           |  11 +
 .../pinmux-config-transformer.h               | 365 ++++++++++++++++++
 .../transformer-t30/transformer-t30-spl.c     |  41 ++
 board/asus/transformer-t30/transformer-t30.c  | 201 ++++++++++
 configs/p1801-t.config                        |   2 +
 configs/tf201.config                          |   2 +
 configs/tf300t.config                         |   2 +
 configs/tf300tg.config                        |   2 +
 configs/tf300tl.config                        |   2 +
 configs/tf600t.config                         |   4 +
 configs/tf700t.config                         |   2 +
 configs/transformer_t30_defconfig             |  85 ++++
 doc/board/asus/index.rst                      |   9 +
 doc/board/asus/transformer_t30.rst            |  96 +++++
 include/configs/transformer-common.h          |  94 +++++
 include/configs/transformer-t30.h             |  23 ++
 28 files changed, 1357 insertions(+)
 create mode 100644 arch/arm/dts/tegra30-asus-p1801-t.dts
 create mode 100644 arch/arm/dts/tegra30-asus-tf201.dts
 create mode 100644 arch/arm/dts/tegra30-asus-tf300t.dts
 create mode 100644 arch/arm/dts/tegra30-asus-tf300tg.dts
 create mode 100644 arch/arm/dts/tegra30-asus-tf300tl.dts
 create mode 100644 arch/arm/dts/tegra30-asus-tf600t.dts
 create mode 100644 arch/arm/dts/tegra30-asus-tf700t.dts
 create mode 100644 arch/arm/dts/tegra30-asus-transformer.dtsi
 create mode 100644 board/asus/transformer-t30/Kconfig
 create mode 100644 board/asus/transformer-t30/MAINTAINERS
 create mode 100644 board/asus/transformer-t30/Makefile
 create mode 100644 board/asus/transformer-t30/pinmux-config-transformer.h
 create mode 100644 board/asus/transformer-t30/transformer-t30-spl.c
 create mode 100644 board/asus/transformer-t30/transformer-t30.c
 create mode 100644 configs/p1801-t.config
 create mode 100644 configs/tf201.config
 create mode 100644 configs/tf300t.config
 create mode 100644 configs/tf300tg.config
 create mode 100644 configs/tf300tl.config
 create mode 100644 configs/tf600t.config
 create mode 100644 configs/tf700t.config
 create mode 100644 configs/transformer_t30_defconfig
 create mode 100644 doc/board/asus/index.rst
 create mode 100644 doc/board/asus/transformer_t30.rst
 create mode 100644 include/configs/transformer-common.h
 create mode 100644 include/configs/transformer-t30.h
arch/arm/dts/Makefile +7 -0
index 480269fa60..c87729d45e 100644
@@ -237,6 +237,13 @@ dtb-$(CONFIG_ARCH_TEGRA) += tegra20-harmony.dtb \
 	tegra20-ventana.dtb \
 	tegra20-colibri.dtb \
 	tegra30-apalis.dtb \
+	tegra30-asus-p1801-t.dtb \
+	tegra30-asus-tf201.dtb \
+	tegra30-asus-tf300t.dtb \
+	tegra30-asus-tf300tg.dtb \
+	tegra30-asus-tf300tl.dtb \
+	tegra30-asus-tf600t.dtb \
+	tegra30-asus-tf700t.dtb \
 	tegra30-beaver.dtb \
 	tegra30-cardhu.dtb \
 	tegra30-colibri.dtb \
arch/arm/dts/tegra30-asus-p1801-t.dts new file +17 -0
new file mode 100644
index 0000000000..879373a5e8
@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+
+#include "tegra30-asus-transformer.dtsi"
+
+/ {
+	model = "ASUS Transformer AiO P1801-T";
+	compatible = "asus,p1801-t", "nvidia,tegra30";
+
+	/delete-node/ host1x@50000000;
+
+	/delete-node/ backlight;
+	/delete-node/ panel;
+
+	/delete-node/ regulator-pnl;
+	/delete-node/ regulator-bl;
+};
arch/arm/dts/tegra30-asus-tf201.dts new file +9 -0
new file mode 100644
index 0000000000..54f359ef96
@@ -0,0 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+
+#include "tegra30-asus-transformer.dtsi"
+
+/ {
+	model = "ASUS Transformer Prime TF201";
+	compatible = "asus,tf201", "nvidia,tegra30";
+};
arch/arm/dts/tegra30-asus-tf300t.dts new file +18 -0
new file mode 100644
index 0000000000..db08488420
@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+
+#include "tegra30-asus-transformer.dtsi"
+
+/ {
+	model = "ASUS Transformer Pad TF300T";
+	compatible = "asus,tf300t", "nvidia,tegra30";
+
+	gpio@6000d000 {
+		volume-buttons-hog {
+			gpio-hog;
+			gpios = <TEGRA_GPIO(R, 0) GPIO_ACTIVE_HIGH>,
+				<TEGRA_GPIO(K, 7) GPIO_ACTIVE_HIGH>;
+			output-low;
+		};
+	};
+};
arch/arm/dts/tegra30-asus-tf300tg.dts new file +9 -0
new file mode 100644
index 0000000000..6f42182c99
@@ -0,0 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+
+#include "tegra30-asus-transformer.dtsi"
+
+/ {
+	model = "ASUS Transformer Pad 3G TF300TG";
+	compatible = "asus,tf300tg", "nvidia,tegra30";
+};
arch/arm/dts/tegra30-asus-tf300tl.dts new file +9 -0
new file mode 100644
index 0000000000..242f79170c
@@ -0,0 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+
+#include "tegra30-asus-transformer.dtsi"
+
+/ {
+	model = "ASUS Transformer Pad LTE TF300TL";
+	compatible = "asus,tf300tl", "nvidia,tegra30";
+};
arch/arm/dts/tegra30-asus-tf600t.dts new file +89 -0

89 lines not on this page · raw message

arch/arm/dts/tegra30-asus-tf700t.dts new file +13 -0
new file mode 100644
index 0000000000..d530527c9f
@@ -0,0 +1,13 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+
+#include "tegra30-asus-transformer.dtsi"
+
+/ {
+	model = "ASUS Transformer Infinity TF700T";
+	compatible = "asus,tf700t", "nvidia,tegra30";
+
+	/delete-node/ host1x@50000000;
+
+	/delete-node/ panel;
+};
arch/arm/dts/tegra30-asus-transformer.dtsi new file +211 -0

211 lines not on this page · raw message

arch/arm/mach-tegra/tegra30/Kconfig +5 -0
index 85b8ce294f..4f78d0ba97 100644
@@ -24,6 +24,10 @@ config TARGET_TEC_NG
 	bool "Avionic Design TEC-NG board"
 	select BOARD_LATE_INIT
 
+config TARGET_TRANSFORMER_T30
+	bool "Asus Tegra30 Transformer board"
+	select BOARD_LATE_INIT
+
 endchoice
 
 config SYS_SOC
@@ -34,5 +38,6 @@ source "board/nvidia/beaver/Kconfig"
 source "board/nvidia/cardhu/Kconfig"
 source "board/toradex/colibri_t30/Kconfig"
 source "board/avionic-design/tec-ng/Kconfig"
+source "board/asus/transformer-t30/Kconfig"
 
 endif
board/asus/transformer-t30/Kconfig new file +23 -0
new file mode 100644
index 0000000000..3c36f4ada2
@@ -0,0 +1,23 @@
+if TARGET_TRANSFORMER_T30
+
+config SYS_BOARD
+	default "transformer-t30"
+
+config SYS_VENDOR
+	default "asus"
+
+config SYS_CONFIG_NAME
+	default "transformer-t30"
+
+config TRANSFORMER_SPI_BOOT
+	bool "Enable support for SPI based flash"
+	select TEGRA20_SLINK
+	select DM_SPI_FLASH
+	select SPI_FLASH_WINBOND
+	default n
+	help
+	  Tegra 3 based Transformers with Windows RT have core
+	  boot sequence (BCT and EBT) on separate SPI FLASH
+	  memory with 4MB size.
+
+endif
board/asus/transformer-t30/MAINTAINERS new file +6 -0
new file mode 100644
index 0000000000..7a75a1c481
@@ -0,0 +1,6 @@
+TRANSFORMER BOARD
+M:	Svyatoslav Ryhel <[email protected]>
+S:	Maintained
+F:	board/asus/transformer-t30/
+F:	include/configs/transformer-t30.h
+F:	configs/transformer_t30_defconfig
board/asus/transformer-t30/Makefile new file +11 -0
new file mode 100644
index 0000000000..c083f2289b
@@ -0,0 +1,11 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+#  (C) Copyright 2010-2012
+#  NVIDIA Corporation <www.nvidia.com>
+#
+#  (C) Copyright 2021
+#  Svyatoslav Ryhel <[email protected]>
+
+obj-$(CONFIG_SPL_BUILD) += transformer-t30-spl.o
+
+obj-y += transformer-t30.o
board/asus/transformer-t30/pinmux-config-transformer.h new file +365 -0

365 lines not on this page · raw message

board/asus/transformer-t30/transformer-t30-spl.c new file +41 -0

41 lines not on this page · raw message

board/asus/transformer-t30/transformer-t30.c new file +201 -0

201 lines not on this page · raw message

configs/p1801-t.config new file +2 -0
new file mode 100644
index 0000000000..fab2912132
@@ -0,0 +1,2 @@
+CONFIG_DEFAULT_DEVICE_TREE="tegra30-asus-p1801-t"
+CONFIG_USB_GADGET_PRODUCT_NUM=0x4cb0
configs/tf201.config new file +2 -0
new file mode 100644
index 0000000000..296743b774
@@ -0,0 +1,2 @@
+CONFIG_DEFAULT_DEVICE_TREE="tegra30-asus-tf201"
+CONFIG_USB_GADGET_PRODUCT_NUM=0x4d00
configs/tf300t.config new file +2 -0
new file mode 100644
index 0000000000..32a92fe76f
@@ -0,0 +1,2 @@
+CONFIG_DEFAULT_DEVICE_TREE="tegra30-asus-tf300t"
+CONFIG_USB_GADGET_PRODUCT_NUM=0x4d00
configs/tf300tg.config new file +2 -0
new file mode 100644
index 0000000000..1396294f6d
@@ -0,0 +1,2 @@
+CONFIG_DEFAULT_DEVICE_TREE="tegra30-asus-tf300tg"
+CONFIG_USB_GADGET_PRODUCT_NUM=0x4c80
configs/tf300tl.config new file +2 -0
new file mode 100644
index 0000000000..3db033c8df
@@ -0,0 +1,2 @@
+CONFIG_DEFAULT_DEVICE_TREE="tegra30-asus-tf300tl"
+CONFIG_USB_GADGET_PRODUCT_NUM=0x4d00
configs/tf600t.config new file +4 -0
new file mode 100644
index 0000000000..89d8db4eb1
@@ -0,0 +1,4 @@
+CONFIG_DEFAULT_DEVICE_TREE="tegra30-asus-tf600t"
+CONFIG_TRANSFORMER_SPI_BOOT=y
+CONFIG_BOOTCOMMAND="setenv gpio_button 222; if run check_button; then poweroff; fi; setenv gpio_button 132; if run check_button; then echo Starting SPI flash update ...; run update_spi; fi; run bootcmd_mmc1; run bootcmd_mmc0; poweroff;"
+CONFIG_USB_GADGET_PRODUCT_NUM=0x4d00
configs/tf700t.config new file +2 -0
new file mode 100644
index 0000000000..066c884d08
@@ -0,0 +1,2 @@
+CONFIG_DEFAULT_DEVICE_TREE="tegra30-asus-tf700t"
+CONFIG_USB_GADGET_PRODUCT_NUM=0x4c90
configs/transformer_t30_defconfig new file +85 -0

85 lines not on this page · raw message

doc/board/asus/index.rst new file +9 -0
new file mode 100644
index 0000000000..c59571c8b3
@@ -0,0 +1,9 @@
+.. SPDX-License-Identifier: GPL-2.0+
+
+ASUS
+====
+
+.. toctree::
+   :maxdepth: 2
+
+   transformer_t30
doc/board/asus/transformer_t30.rst new file +96 -0

96 lines not on this page · raw message

include/configs/transformer-common.h new file +94 -0

94 lines not on this page · raw message

include/configs/transformer-t30.h new file +23 -0
new file mode 100644
index 0000000000..d2a16f12c1
@@ -0,0 +1,23 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ *  (C) Copyright 2010,2012
+ *  NVIDIA Corporation <www.nvidia.com>
+ *
+ *  (C) Copyright 2022
+ *  Svyatoslav Ryhel <[email protected]>
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#include <linux/sizes.h>
+
+#include "tegra30-common.h"
+#include "transformer-common.h"
+
+/* Board-specific serial config */
+#define CFG_SYS_NS16550_COM1		NV_PA_APB_UARTA_BASE
+
+#include "tegra-common-post.h"
+
+#endif /* __CONFIG_H */
Signature · 1 line
2.39.2
#5 lore raw

Re: [PATCH v5 4/7] board: asus: transformer: add ASUS Transformer T30 family support

Quoted 34 lines · Svyatoslav Ryhel

The ASUS Transformer T30 family are 2-in-1 detachable tablets and AiO developed by ASUS that run the Android operating system (TF600T runs Windows RT and P1801-T runs Android and Windows). The T30 Transformers feature a 10.1-inch display (apart P1801-T), an Nvidia Tegra 3 quad-core chip, 1/2 GB of RAM, and 16/32 GB of storage. Transformers board derives from Nvidia Cardhu development board.

This patch brings support for 7 known Transformer devices:
- ASUS Transformer Prime TF201
- ASUS Transformer Pad TF300T/TF300TG/TF300TL
- ASUS VivoTab RT TF600T (Windows RT based)
- ASUS Transformer Infinity TF700T
- ASUS Transformer AiO P1801-T

---
 arch/arm/dts/Makefile                         |   7 +
 arch/arm/dts/tegra30-asus-p1801-t.dts         |  17 +
 arch/arm/dts/tegra30-asus-tf201.dts           |   9 +
 arch/arm/dts/tegra30-asus-tf300t.dts          |  18 +
 arch/arm/dts/tegra30-asus-tf300tg.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf300tl.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf600t.dts          |  89 +++++
 arch/arm/dts/tegra30-asus-tf700t.dts          |  13 +
 arch/arm/dts/tegra30-asus-transformer.dtsi    | 211 ++++++++++
 arch/arm/mach-tegra/tegra30/Kconfig           |   5 +
 board/asus/transformer-t30/Kconfig            |  23 ++
 board/asus/transformer-t30/MAINTAINERS        |   6 +
 board/asus/transformer-t30/Makefile           |  11 +
 .../pinmux-config-transformer.h               | 365 ++++++++++++++++++
 .../transformer-t30/transformer-t30-spl.c     |  41 ++
 board/asus/transformer-t30/transformer-t30.c  | 201 ++++++++++
Quoted 8 lines
 configs/p1801-t.config                        |   2 +
 configs/tf201.config                          |   2 +
 configs/tf300t.config                         |   2 +
 configs/tf300tg.config                        |   2 +
 configs/tf300tl.config                        |   2 +
 configs/tf600t.config                         |   4 +
 configs/tf700t.config                         |   2 +
 configs/transformer_t30_defconfig             |  85 ++++

Sorry for not noticing this part sooner. Looking in the kernel, arch/{riscv,powerpc}/Makefile both provide examples of how to automate generating the resulting defconfigs directly. I think we really want that, and also the config fragments need to be listed in the MAINTAINERS file.

I also worry that none of these other configs will be caught by buildmn and so won't be in CI at all, just the base. Which isn't a big problem, yet, but could be as more people use config fragments. I'm just noting this secondary part and not saying you need to fix that as well.

Signature · 1 line
Tom
#6 lore raw

Re: [PATCH v5 4/7] board: asus: transformer: add ASUS Transformer T30 family support

6 червня 2023 р. 22:19:44 GMT+03:00, Tom Rini <[email protected]> написав(-ла):

Quoted 45 lines · Svyatoslav Ryhel
Quoted 35 lines

The ASUS Transformer T30 family are 2-in-1 detachable tablets and AiO developed by ASUS that run the Android operating system (TF600T runs Windows RT and P1801-T runs Android and Windows). The T30 Transformers feature a 10.1-inch display (apart P1801-T), an Nvidia Tegra 3 quad-core chip, 1/2 GB of RAM, and 16/32 GB of storage. Transformers board derives from Nvidia Cardhu development board.

This patch brings support for 7 known Transformer devices:
- ASUS Transformer Prime TF201
- ASUS Transformer Pad TF300T/TF300TG/TF300TL
- ASUS VivoTab RT TF600T (Windows RT based)
- ASUS Transformer Infinity TF700T
- ASUS Transformer AiO P1801-T

---
 arch/arm/dts/Makefile                         |   7 +
 arch/arm/dts/tegra30-asus-p1801-t.dts         |  17 +
 arch/arm/dts/tegra30-asus-tf201.dts           |   9 +
 arch/arm/dts/tegra30-asus-tf300t.dts          |  18 +
 arch/arm/dts/tegra30-asus-tf300tg.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf300tl.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf600t.dts          |  89 +++++
 arch/arm/dts/tegra30-asus-tf700t.dts          |  13 +
 arch/arm/dts/tegra30-asus-transformer.dtsi    | 211 ++++++++++
 arch/arm/mach-tegra/tegra30/Kconfig           |   5 +
 board/asus/transformer-t30/Kconfig            |  23 ++
 board/asus/transformer-t30/MAINTAINERS        |   6 +
 board/asus/transformer-t30/Makefile           |  11 +
 .../pinmux-config-transformer.h               | 365 ++++++++++++++++++
 .../transformer-t30/transformer-t30-spl.c     |  41 ++
 board/asus/transformer-t30/transformer-t30.c  | 201 ++++++++++
Quoted 8 lines
 configs/p1801-t.config                        |   2 +
 configs/tf201.config                          |   2 +
 configs/tf300t.config                         |   2 +
 configs/tf300tg.config                        |   2 +
 configs/tf300tl.config                        |   2 +
 configs/tf600t.config                         |   4 +
 configs/tf700t.config                         |   2 +
 configs/transformer_t30_defconfig             |  85 ++++
Quoted 5 lines

Sorry for not noticing this part sooner. Looking in the kernel, arch/{riscv,powerpc}/Makefile both provide examples of how to automate generating the resulting defconfigs directly. I think we really want that, and also the config fragments need to be listed in the MAINTAINERS file.

Not sure if adding this is a good idea, plus adding fragments into MAINTAINERS may cause even more issues. Iirc buildman uses it as a config source and defining multiple fragments may fail not only for boards under question, but those, already existing in u-boot, as well.

Issue is not in the arch dir to tweak arch's makefile, fragments are used by some boards and issue lays in omitting their existence by system of autobuild.

Quoted 5 lines

I also worry that none of these other configs will be caught by buildmn and so won't be in CI at all, just the base. Which isn't a big problem, yet, but could be as more people use config fragments. I'm just noting this secondary part and not saying you need to fix that as well.

Buildman indeed is not catching any fragments, which already caused me issues since defconfigs are not as generic as I would like to (since else I get a big chunk of checks failed).

A good solution might be to tweak buildman to accept fragments if any are defined in the dedicated field of MAINTAINERS file. But that would be a major patchset to implement on the entire project scale.

Best regards,
Svyatoslav R.

#7 lore raw

Re: [PATCH v5 4/7] board: asus: transformer: add ASUS Transformer T30 family support

Quoted 54 lines · Svyatoslav Ryhel

6 червня 2023 р. 22:19:44 GMT+03:00, Tom Rini <[email protected]> написав(-ла):

Quoted 45 lines · Svyatoslav Ryhel
Quoted 35 lines

The ASUS Transformer T30 family are 2-in-1 detachable tablets and AiO developed by ASUS that run the Android operating system (TF600T runs Windows RT and P1801-T runs Android and Windows). The T30 Transformers feature a 10.1-inch display (apart P1801-T), an Nvidia Tegra 3 quad-core chip, 1/2 GB of RAM, and 16/32 GB of storage. Transformers board derives from Nvidia Cardhu development board.

This patch brings support for 7 known Transformer devices:
- ASUS Transformer Prime TF201
- ASUS Transformer Pad TF300T/TF300TG/TF300TL
- ASUS VivoTab RT TF600T (Windows RT based)
- ASUS Transformer Infinity TF700T
- ASUS Transformer AiO P1801-T

---
 arch/arm/dts/Makefile                         |   7 +
 arch/arm/dts/tegra30-asus-p1801-t.dts         |  17 +
 arch/arm/dts/tegra30-asus-tf201.dts           |   9 +
 arch/arm/dts/tegra30-asus-tf300t.dts          |  18 +
 arch/arm/dts/tegra30-asus-tf300tg.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf300tl.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf600t.dts          |  89 +++++
 arch/arm/dts/tegra30-asus-tf700t.dts          |  13 +
 arch/arm/dts/tegra30-asus-transformer.dtsi    | 211 ++++++++++
 arch/arm/mach-tegra/tegra30/Kconfig           |   5 +
 board/asus/transformer-t30/Kconfig            |  23 ++
 board/asus/transformer-t30/MAINTAINERS        |   6 +
 board/asus/transformer-t30/Makefile           |  11 +
 .../pinmux-config-transformer.h               | 365 ++++++++++++++++++
 .../transformer-t30/transformer-t30-spl.c     |  41 ++
 board/asus/transformer-t30/transformer-t30.c  | 201 ++++++++++
Quoted 8 lines
 configs/p1801-t.config                        |   2 +
 configs/tf201.config                          |   2 +
 configs/tf300t.config                         |   2 +
 configs/tf300tg.config                        |   2 +
 configs/tf300tl.config                        |   2 +
 configs/tf600t.config                         |   4 +
 configs/tf700t.config                         |   2 +
 configs/transformer_t30_defconfig             |  85 ++++
Quoted 5 lines

Sorry for not noticing this part sooner. Looking in the kernel, arch/{riscv,powerpc}/Makefile both provide examples of how to automate generating the resulting defconfigs directly. I think we really want that, and also the config fragments need to be listed in the MAINTAINERS file.

Quoted 4 lines

Not sure if adding this is a good idea, plus adding fragments into MAINTAINERS may cause even more issues. Iirc buildman uses it as a config source and defining multiple fragments may fail not only for boards under question, but those, already existing in u-boot, as well.

If this causes buildman problems then we'll need to figure out something, but it shouldn't.

Quoted 3 lines

Issue is not in the arch dir to tweak arch's makefile, fragments are used by some boards and issue lays in omitting their existence by system of autobuild.

Yes, and I'd like to set some good examples for the first config fragments we're adding as I suspect you're the first person to notice this works (as a feature not a happenstance) and others will make more use if it for more than a few changes. So I'd like to get things going in the right direction.

Quoted 10 lines
Quoted 6 lines

I also worry that none of these other configs will be caught by buildmn and so won't be in CI at all, just the base. Which isn't a big problem, yet, but could be as more people use config fragments. I'm just noting this secondary part and not saying you need to fix that as well.

Buildman indeed is not catching any fragments, which already caused me issues since defconfigs are not as generic as I would like to (since else I get a big chunk of checks failed).

A good solution might be to tweak buildman to accept fragments if any are defined in the dedicated field of MAINTAINERS file. But that would be a major patchset to implement on the entire project scale.

Yes, I'm not sure how best to deal with fragments to start with, for buildman. But we don't need to solve that today for this series, either.

Signature · 1 line
Tom
#8 lore raw

Re: [PATCH v5 4/7] board: asus: transformer: add ASUS Transformer T30 family support

6 червня 2023 р. 22:47:23 GMT+03:00, Tom Rini <[email protected]> написав(-ла):

Quoted 67 lines · Svyatoslav Ryhel
Quoted 54 lines

6 червня 2023 р. 22:19:44 GMT+03:00, Tom Rini <[email protected]> написав(-ла):

Quoted 45 lines · Svyatoslav Ryhel
Quoted 35 lines

The ASUS Transformer T30 family are 2-in-1 detachable tablets and AiO developed by ASUS that run the Android operating system (TF600T runs Windows RT and P1801-T runs Android and Windows). The T30 Transformers feature a 10.1-inch display (apart P1801-T), an Nvidia Tegra 3 quad-core chip, 1/2 GB of RAM, and 16/32 GB of storage. Transformers board derives from Nvidia Cardhu development board.

This patch brings support for 7 known Transformer devices:
- ASUS Transformer Prime TF201
- ASUS Transformer Pad TF300T/TF300TG/TF300TL
- ASUS VivoTab RT TF600T (Windows RT based)
- ASUS Transformer Infinity TF700T
- ASUS Transformer AiO P1801-T

---
 arch/arm/dts/Makefile                         |   7 +
 arch/arm/dts/tegra30-asus-p1801-t.dts         |  17 +
 arch/arm/dts/tegra30-asus-tf201.dts           |   9 +
 arch/arm/dts/tegra30-asus-tf300t.dts          |  18 +
 arch/arm/dts/tegra30-asus-tf300tg.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf300tl.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf600t.dts          |  89 +++++
 arch/arm/dts/tegra30-asus-tf700t.dts          |  13 +
 arch/arm/dts/tegra30-asus-transformer.dtsi    | 211 ++++++++++
 arch/arm/mach-tegra/tegra30/Kconfig           |   5 +
 board/asus/transformer-t30/Kconfig            |  23 ++
 board/asus/transformer-t30/MAINTAINERS        |   6 +
 board/asus/transformer-t30/Makefile           |  11 +
 .../pinmux-config-transformer.h               | 365 ++++++++++++++++++
 .../transformer-t30/transformer-t30-spl.c     |  41 ++
 board/asus/transformer-t30/transformer-t30.c  | 201 ++++++++++
Quoted 8 lines
 configs/p1801-t.config                        |   2 +
 configs/tf201.config                          |   2 +
 configs/tf300t.config                         |   2 +
 configs/tf300tg.config                        |   2 +
 configs/tf300tl.config                        |   2 +
 configs/tf600t.config                         |   4 +
 configs/tf700t.config                         |   2 +
 configs/transformer_t30_defconfig             |  85 ++++
Quoted 5 lines

Sorry for not noticing this part sooner. Looking in the kernel, arch/{riscv,powerpc}/Makefile both provide examples of how to automate generating the resulting defconfigs directly. I think we really want that, and also the config fragments need to be listed in the MAINTAINERS file.

Quoted 4 lines

Not sure if adding this is a good idea, plus adding fragments into MAINTAINERS may cause even more issues. Iirc buildman uses it as a config source and defining multiple fragments may fail not only for boards under question, but those, already existing in u-boot, as well.

If this causes buildman problems then we'll need to figure out something, but it shouldn't.

Quoted 3 lines

Issue is not in the arch dir to tweak arch's makefile, fragments are used by some boards and issue lays in omitting their existence by system of autobuild.

Quoted 5 lines

Yes, and I'd like to set some good examples for the first config fragments we're adding as I suspect you're the first person to notice this works (as a feature not a happenstance) and others will make more use if it for more than a few changes. So I'd like to get things going in the right direction.

Fragments system is by far the best solution for situations like with Asus Transformers.

Quoted 7 lines
Quoted 7 lines
Quoted 6 lines

I also worry that none of these other configs will be caught by buildmn and so won't be in CI at all, just the base. Which isn't a big problem, yet, but could be as more people use config fragments. I'm just noting this secondary part and not saying you need to fix that as well.

Quoted 8 lines
Quoted 3 lines

Buildman indeed is not catching any fragments, which already caused me issues since defconfigs are not as generic as I would like to (since else I get a big chunk of checks failed).

A good solution might be to tweak buildman to accept fragments if any are defined in the dedicated field of MAINTAINERS file. But that would be a major patchset to implement on the entire project scale.

Yes, I'm not sure how best to deal with fragments to start with, for buildman. But we don't need to solve that today for this series, either.

Since I place myself as a maintainer of all devices in this patchset you can count on me if there will be any changes to the fragment system. Additionally, I will experiment more with transformer defconfigs (this is definitely not all changes I am interested in) to improve current state inline with u-boot development.

#9 lore raw

Re: [PATCH v5 4/7] board: asus: transformer: add ASUS Transformer T30 family support

In reply to Tom Rini

вт, 6 черв. 2023 р. о 22:47 Tom Rini <[email protected]> пише:

Quoted 56 lines · Svyatoslav Ryhel
Quoted 54 lines

6 червня 2023 р. 22:19:44 GMT+03:00, Tom Rini <[email protected]> написав(-ла):

Quoted 50 lines · Svyatoslav Ryhel
Quoted 35 lines

The ASUS Transformer T30 family are 2-in-1 detachable tablets and AiO developed by ASUS that run the Android operating system (TF600T runs Windows RT and P1801-T runs Android and Windows). The T30 Transformers feature a 10.1-inch display (apart P1801-T), an Nvidia Tegra 3 quad-core chip, 1/2 GB of RAM, and 16/32 GB of storage. Transformers board derives from Nvidia Cardhu development board.

This patch brings support for 7 known Transformer devices:
- ASUS Transformer Prime TF201
- ASUS Transformer Pad TF300T/TF300TG/TF300TL
- ASUS VivoTab RT TF600T (Windows RT based)
- ASUS Transformer Infinity TF700T
- ASUS Transformer AiO P1801-T

---
 arch/arm/dts/Makefile                         |   7 +
 arch/arm/dts/tegra30-asus-p1801-t.dts         |  17 +
 arch/arm/dts/tegra30-asus-tf201.dts           |   9 +
 arch/arm/dts/tegra30-asus-tf300t.dts          |  18 +
 arch/arm/dts/tegra30-asus-tf300tg.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf300tl.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf600t.dts          |  89 +++++
 arch/arm/dts/tegra30-asus-tf700t.dts          |  13 +
 arch/arm/dts/tegra30-asus-transformer.dtsi    | 211 ++++++++++
 arch/arm/mach-tegra/tegra30/Kconfig           |   5 +
 board/asus/transformer-t30/Kconfig            |  23 ++
 board/asus/transformer-t30/MAINTAINERS        |   6 +
 board/asus/transformer-t30/Makefile           |  11 +
 .../pinmux-config-transformer.h               | 365 ++++++++++++++++++
 .../transformer-t30/transformer-t30-spl.c     |  41 ++
 board/asus/transformer-t30/transformer-t30.c  | 201 ++++++++++
Quoted 8 lines
 configs/p1801-t.config                        |   2 +
 configs/tf201.config                          |   2 +
 configs/tf300t.config                         |   2 +
 configs/tf300tg.config                        |   2 +
 configs/tf300tl.config                        |   2 +
 configs/tf600t.config                         |   4 +
 configs/tf700t.config                         |   2 +
 configs/transformer_t30_defconfig             |  85 ++++

Sorry for not noticing this part sooner. Looking in the kernel, arch/{riscv,powerpc}/Makefile both provide examples of how to automate generating the resulting defconfigs directly. I think we really want that, and also the config fragments need to be listed in the MAINTAINERS file.

Quoted 7 lines
Quoted 4 lines

Not sure if adding this is a good idea, plus adding fragments into MAINTAINERS may cause even more issues. Iirc buildman uses it as a config source and defining multiple fragments may fail not only for boards under question, but those, already existing in u-boot, as well.

If this causes buildman problems then we'll need to figure out something, but it shouldn't.

Adding fragments into MAINTAINERS does not cause issues but seems to not have any effect either.

Quoted 10 lines
Quoted 4 lines

Issue is not in the arch dir to tweak arch's makefile, fragments are used by some boards and issue lays in omitting their existence by system of autobuild.

Yes, and I'd like to set some good examples for the first config fragments we're adding as I suspect you're the first person to notice this works (as a feature not a happenstance) and others will make more use if it for more than a few changes. So I'd like to get things going in the right direction.

May you specify more, what do you exactly want from me to change.

Quoted 7 lines
Quoted 7 lines
Quoted 6 lines

I also worry that none of these other configs will be caught by buildmn and so won't be in CI at all, just the base. Which isn't a big problem, yet, but could be as more people use config fragments. I'm just noting this secondary part and not saying you need to fix that as well.

Quoted 8 lines
Quoted 3 lines

Buildman indeed is not catching any fragments, which already caused me issues since defconfigs are not as generic as I would like to (since else I get a big chunk of checks failed).

A good solution might be to tweak buildman to accept fragments if any are defined in the dedicated field of MAINTAINERS file. But that would be a major patchset to implement on the entire project scale.

Yes, I'm not sure how best to deal with fragments to start with, for buildman. But we don't need to solve that today for this series, either.

Does this patchset require any additional changes to be accepted? Have in mind that most likely there will be more patchsets for transformers.

Best regards,
Svyatoslav R.

Quoted 2 lines

--
Tom

#10 lore raw

Re: [PATCH v5 4/7] board: asus: transformer: add ASUS Transformer T30 family support

Quoted 62 lines · Svyatoslav Ryhel

вт, 6 черв. 2023 р. о 22:47 Tom Rini <[email protected]> пише:

Quoted 61 lines · Svyatoslav Ryhel
Quoted 58 lines

6 червня 2023 р. 22:19:44 GMT+03:00, Tom Rini <[email protected]> написав(-ла):

Quoted 45 lines · Svyatoslav Ryhel
Quoted 35 lines

The ASUS Transformer T30 family are 2-in-1 detachable tablets and AiO developed by ASUS that run the Android operating system (TF600T runs Windows RT and P1801-T runs Android and Windows). The T30 Transformers feature a 10.1-inch display (apart P1801-T), an Nvidia Tegra 3 quad-core chip, 1/2 GB of RAM, and 16/32 GB of storage. Transformers board derives from Nvidia Cardhu development board.

This patch brings support for 7 known Transformer devices:
- ASUS Transformer Prime TF201
- ASUS Transformer Pad TF300T/TF300TG/TF300TL
- ASUS VivoTab RT TF600T (Windows RT based)
- ASUS Transformer Infinity TF700T
- ASUS Transformer AiO P1801-T

---
 arch/arm/dts/Makefile                         |   7 +
 arch/arm/dts/tegra30-asus-p1801-t.dts         |  17 +
 arch/arm/dts/tegra30-asus-tf201.dts           |   9 +
 arch/arm/dts/tegra30-asus-tf300t.dts          |  18 +
 arch/arm/dts/tegra30-asus-tf300tg.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf300tl.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf600t.dts          |  89 +++++
 arch/arm/dts/tegra30-asus-tf700t.dts          |  13 +
 arch/arm/dts/tegra30-asus-transformer.dtsi    | 211 ++++++++++
 arch/arm/mach-tegra/tegra30/Kconfig           |   5 +
 board/asus/transformer-t30/Kconfig            |  23 ++
 board/asus/transformer-t30/MAINTAINERS        |   6 +
 board/asus/transformer-t30/Makefile           |  11 +
 .../pinmux-config-transformer.h               | 365 ++++++++++++++++++
 .../transformer-t30/transformer-t30-spl.c     |  41 ++
 board/asus/transformer-t30/transformer-t30.c  | 201 ++++++++++
Quoted 8 lines
 configs/p1801-t.config                        |   2 +
 configs/tf201.config                          |   2 +
 configs/tf300t.config                         |   2 +
 configs/tf300tg.config                        |   2 +
 configs/tf300tl.config                        |   2 +
 configs/tf600t.config                         |   4 +
 configs/tf700t.config                         |   2 +
 configs/transformer_t30_defconfig             |  85 ++++
Quoted 5 lines

Sorry for not noticing this part sooner. Looking in the kernel, arch/{riscv,powerpc}/Makefile both provide examples of how to automate generating the resulting defconfigs directly. I think we really want that, and also the config fragments need to be listed in the MAINTAINERS file.

Not sure if adding this is a good idea, plus adding fragments into MAINTAINERS may cause even more issues. Iirc buildman uses it as a config source and defining multiple fragments may fail not only for boards under question, but those, already existing in u-boot, as well.

Quoted 5 lines
Quoted 2 lines

If this causes buildman problems then we'll need to figure out something, but it shouldn't.

Adding fragments into MAINTAINERS does not cause issues but seems to not have any effect either.

Well, get_maintainers.pl will now report who owns them, which it didn't before, yes?

Quoted 11 lines
Quoted 9 lines
Quoted 3 lines

Issue is not in the arch dir to tweak arch's makefile, fragments are used by some boards and issue lays in omitting their existence by system of autobuild.

Yes, and I'd like to set some good examples for the first config fragments we're adding as I suspect you're the first person to notice this works (as a feature not a happenstance) and others will make more use if it for more than a few changes. So I'd like to get things going in the right direction.

May you specify more, what do you exactly want from me to change.

Well, as this just came up on the IRC channel as well as someone else noticed fragments work, it would be nice to figure out what needs to be added so they can live in $(BOARDDIR) if possible. Or something that doesn't cause a further explosion of files in configs/ (which is already unwieldy).

Quoted 10 lines
Quoted 10 lines
Quoted 9 lines
Quoted 5 lines

I also worry that none of these other configs will be caught by buildmn and so won't be in CI at all, just the base. Which isn't a big problem, yet, but could be as more people use config fragments. I'm just noting this secondary part and not saying you need to fix that as well.

Buildman indeed is not catching any fragments, which already caused me issues since defconfigs are not as generic as I would like to (since else I get a big chunk of checks failed).

A good solution might be to tweak buildman to accept fragments if any are defined in the dedicated field of MAINTAINERS file. But that would be a major patchset to implement on the entire project scale.

Quoted 8 lines
Quoted 4 lines

Yes, I'm not sure how best to deal with fragments to start with, for buildman. But we don't need to solve that today for this series, either.

Does this patchset require any additional changes to be accepted? Have in mind that most likely there will be more patchsets for transformers.

To be clear, it needs the CI issues that I pointed out in Tom W's pull request to be fixed.

Signature · 1 line
Tom
#11 lore raw

Re: [PATCH v5 4/7] board: asus: transformer: add ASUS Transformer T30 family support

чт, 8 черв. 2023 р. о 19:40 Tom Rini <[email protected]> пише:

Quoted 64 lines · Svyatoslav Ryhel
Quoted 62 lines

вт, 6 черв. 2023 р. о 22:47 Tom Rini <[email protected]> пише:

Quoted 61 lines · Svyatoslav Ryhel
Quoted 58 lines

6 червня 2023 р. 22:19:44 GMT+03:00, Tom Rini <[email protected]> написав(-ла):

Quoted 45 lines · Svyatoslav Ryhel
Quoted 35 lines

The ASUS Transformer T30 family are 2-in-1 detachable tablets and AiO developed by ASUS that run the Android operating system (TF600T runs Windows RT and P1801-T runs Android and Windows). The T30 Transformers feature a 10.1-inch display (apart P1801-T), an Nvidia Tegra 3 quad-core chip, 1/2 GB of RAM, and 16/32 GB of storage. Transformers board derives from Nvidia Cardhu development board.

This patch brings support for 7 known Transformer devices:
- ASUS Transformer Prime TF201
- ASUS Transformer Pad TF300T/TF300TG/TF300TL
- ASUS VivoTab RT TF600T (Windows RT based)
- ASUS Transformer Infinity TF700T
- ASUS Transformer AiO P1801-T

---
 arch/arm/dts/Makefile                         |   7 +
 arch/arm/dts/tegra30-asus-p1801-t.dts         |  17 +
 arch/arm/dts/tegra30-asus-tf201.dts           |   9 +
 arch/arm/dts/tegra30-asus-tf300t.dts          |  18 +
 arch/arm/dts/tegra30-asus-tf300tg.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf300tl.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf600t.dts          |  89 +++++
 arch/arm/dts/tegra30-asus-tf700t.dts          |  13 +
 arch/arm/dts/tegra30-asus-transformer.dtsi    | 211 ++++++++++
 arch/arm/mach-tegra/tegra30/Kconfig           |   5 +
 board/asus/transformer-t30/Kconfig            |  23 ++
 board/asus/transformer-t30/MAINTAINERS        |   6 +
 board/asus/transformer-t30/Makefile           |  11 +
 .../pinmux-config-transformer.h               | 365 ++++++++++++++++++
 .../transformer-t30/transformer-t30-spl.c     |  41 ++
 board/asus/transformer-t30/transformer-t30.c  | 201 ++++++++++
Quoted 8 lines
 configs/p1801-t.config                        |   2 +
 configs/tf201.config                          |   2 +
 configs/tf300t.config                         |   2 +
 configs/tf300tg.config                        |   2 +
 configs/tf300tl.config                        |   2 +
 configs/tf600t.config                         |   4 +
 configs/tf700t.config                         |   2 +
 configs/transformer_t30_defconfig             |  85 ++++
Quoted 5 lines

Sorry for not noticing this part sooner. Looking in the kernel, arch/{riscv,powerpc}/Makefile both provide examples of how to automate generating the resulting defconfigs directly. I think we really want that, and also the config fragments need to be listed in the MAINTAINERS file.

Not sure if adding this is a good idea, plus adding fragments into MAINTAINERS may cause even more issues. Iirc buildman uses it as a config source and defining multiple fragments may fail not only for boards under question, but those, already existing in u-boot, as well.

Quoted 9 lines
Quoted 5 lines
Quoted 2 lines

If this causes buildman problems then we'll need to figure out something, but it shouldn't.

Adding fragments into MAINTAINERS does not cause issues but seems to not have any effect either.

Well, get_maintainers.pl will now report who owns them, which it didn't before, yes?

It does report me if get_maintainers.pl is used anyway, even if no files are specified in MAINTAINERS

Quoted 10 lines
Quoted 10 lines
Quoted 9 lines
Quoted 3 lines

Issue is not in the arch dir to tweak arch's makefile, fragments are used by some boards and issue lays in omitting their existence by system of autobuild.

Yes, and I'd like to set some good examples for the first config fragments we're adding as I suspect you're the first person to notice this works (as a feature not a happenstance) and others will make more use if it for more than a few changes. So I'd like to get things going in the right direction.

Quoted 8 lines
Quoted 1 line

May you specify more, what do you exactly want from me to change.

Well, as this just came up on the IRC channel as well as someone else noticed fragments work, it would be nice to figure out what needs to be added so they can live in $(BOARDDIR) if possible. Or something that doesn't cause a further explosion of files in configs/ (which is already unwieldy).

I see your point but it is definitely beyond this patchset cover.

Quoted 15 lines
Quoted 15 lines
Quoted 14 lines
Quoted 9 lines
Quoted 5 lines

I also worry that none of these other configs will be caught by buildmn and so won't be in CI at all, just the base. Which isn't a big problem, yet, but could be as more people use config fragments. I'm just noting this secondary part and not saying you need to fix that as well.

Buildman indeed is not catching any fragments, which already caused me issues since defconfigs are not as generic as I would like to (since else I get a big chunk of checks failed).

A good solution might be to tweak buildman to accept fragments if any are defined in the dedicated field of MAINTAINERS file. But that would be a major patchset to implement on the entire project scale.

Yes, I'm not sure how best to deal with fragments to start with, for buildman. But we don't need to solve that today for this series, either.

Quoted 7 lines
Quoted 3 lines

Does this patchset require any additional changes to be accepted? Have in mind that most likely there will be more patchsets for transformers.

To be clear, it needs the CI issues that I pointed out in Tom W's pull request to be fixed.

This was done in v5 iteration. I have fixed CI issues you have pointed to. Hopefully, how checks pass.

Quoted 2 lines

--
Tom

#12 lore raw

Re: [PATCH v5 4/7] board: asus: transformer: add ASUS Transformer T30 family support

Quoted 71 lines · Svyatoslav Ryhel

чт, 8 черв. 2023 р. о 19:40 Tom Rini <[email protected]> пише:

Quoted 70 lines · Svyatoslav Ryhel
Quoted 67 lines

вт, 6 черв. 2023 р. о 22:47 Tom Rini <[email protected]> пише:

Quoted 56 lines · Svyatoslav Ryhel
Quoted 54 lines

6 червня 2023 р. 22:19:44 GMT+03:00, Tom Rini <[email protected]> написав(-ла):

Quoted 50 lines · Svyatoslav Ryhel
Quoted 35 lines

The ASUS Transformer T30 family are 2-in-1 detachable tablets and AiO developed by ASUS that run the Android operating system (TF600T runs Windows RT and P1801-T runs Android and Windows). The T30 Transformers feature a 10.1-inch display (apart P1801-T), an Nvidia Tegra 3 quad-core chip, 1/2 GB of RAM, and 16/32 GB of storage. Transformers board derives from Nvidia Cardhu development board.

This patch brings support for 7 known Transformer devices:
- ASUS Transformer Prime TF201
- ASUS Transformer Pad TF300T/TF300TG/TF300TL
- ASUS VivoTab RT TF600T (Windows RT based)
- ASUS Transformer Infinity TF700T
- ASUS Transformer AiO P1801-T

---
 arch/arm/dts/Makefile                         |   7 +
 arch/arm/dts/tegra30-asus-p1801-t.dts         |  17 +
 arch/arm/dts/tegra30-asus-tf201.dts           |   9 +
 arch/arm/dts/tegra30-asus-tf300t.dts          |  18 +
 arch/arm/dts/tegra30-asus-tf300tg.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf300tl.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf600t.dts          |  89 +++++
 arch/arm/dts/tegra30-asus-tf700t.dts          |  13 +
 arch/arm/dts/tegra30-asus-transformer.dtsi    | 211 ++++++++++
 arch/arm/mach-tegra/tegra30/Kconfig           |   5 +
 board/asus/transformer-t30/Kconfig            |  23 ++
 board/asus/transformer-t30/MAINTAINERS        |   6 +
 board/asus/transformer-t30/Makefile           |  11 +
 .../pinmux-config-transformer.h               | 365 ++++++++++++++++++
 .../transformer-t30/transformer-t30-spl.c     |  41 ++
 board/asus/transformer-t30/transformer-t30.c  | 201 ++++++++++
Quoted 8 lines
 configs/p1801-t.config                        |   2 +
 configs/tf201.config                          |   2 +
 configs/tf300t.config                         |   2 +
 configs/tf300tg.config                        |   2 +
 configs/tf300tl.config                        |   2 +
 configs/tf600t.config                         |   4 +
 configs/tf700t.config                         |   2 +
 configs/transformer_t30_defconfig             |  85 ++++

Sorry for not noticing this part sooner. Looking in the kernel, arch/{riscv,powerpc}/Makefile both provide examples of how to automate generating the resulting defconfigs directly. I think we really want that, and also the config fragments need to be listed in the MAINTAINERS file.

Quoted 7 lines
Quoted 4 lines

Not sure if adding this is a good idea, plus adding fragments into MAINTAINERS may cause even more issues. Iirc buildman uses it as a config source and defining multiple fragments may fail not only for boards under question, but those, already existing in u-boot, as well.

If this causes buildman problems then we'll need to figure out something, but it shouldn't.

Adding fragments into MAINTAINERS does not cause issues but seems to not have any effect either.

Quoted 6 lines
Quoted 3 lines

Well, get_maintainers.pl will now report who owns them, which it didn't before, yes?

It does report me if get_maintainers.pl is used anyway, even if no files are specified in MAINTAINERS

As maintainer, or as git heuristics? But all the same, the rule about defconfigs needing to be in MAINTAINERS entires should extend to config fragments.

Quoted 12 lines
Quoted 12 lines
Quoted 11 lines
Quoted 9 lines
Quoted 3 lines

Issue is not in the arch dir to tweak arch's makefile, fragments are used by some boards and issue lays in omitting their existence by system of autobuild.

Yes, and I'd like to set some good examples for the first config fragments we're adding as I suspect you're the first person to notice this works (as a feature not a happenstance) and others will make more use if it for more than a few changes. So I'd like to get things going in the right direction.

May you specify more, what do you exactly want from me to change.

Quoted 7 lines
Quoted 5 lines

Well, as this just came up on the IRC channel as well as someone else noticed fragments work, it would be nice to figure out what needs to be added so they can live in $(BOARDDIR) if possible. Or something that doesn't cause a further explosion of files in configs/ (which is already unwieldy).

I see your point but it is definitely beyond this patchset cover.

Yes, it's not stopping this first patch-set.

Quoted 19 lines
Quoted 19 lines
Quoted 18 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines

I also worry that none of these other configs will be caught by buildmn and so won't be in CI at all, just the base. Which isn't a big problem, yet, but could be as more people use config fragments. I'm just noting this secondary part and not saying you need to fix that as well.

Quoted 8 lines
Quoted 3 lines

Buildman indeed is not catching any fragments, which already caused me issues since defconfigs are not as generic as I would like to (since else I get a big chunk of checks failed).

A good solution might be to tweak buildman to accept fragments if any are defined in the dedicated field of MAINTAINERS file. But that would be a major patchset to implement on the entire project scale.

Yes, I'm not sure how best to deal with fragments to start with, for buildman. But we don't need to solve that today for this series, either.

Does this patchset require any additional changes to be accepted? Have in mind that most likely there will be more patchsets for transformers.

Quoted 5 lines
Quoted 2 lines

To be clear, it needs the CI issues that I pointed out in Tom W's pull request to be fixed.

This was done in v5 iteration. I have fixed CI issues you have pointed to. Hopefully, how checks pass.

Were you able to use GitHub / Azure to get a round of CI run?

Signature · 1 line
Tom
#13 lore raw

Re: [PATCH v5 4/7] board: asus: transformer: add ASUS Transformer T30 family support

8 червня 2023 р. 20:09:41 GMT+03:00, Tom Rini <[email protected]> написав(-ла):

Quoted 76 lines · Svyatoslav Ryhel
Quoted 75 lines

чт, 8 черв. 2023 р. о 19:40 Tom Rini <[email protected]> пише:

Quoted 73 lines · Svyatoslav Ryhel
Quoted 62 lines

вт, 6 черв. 2023 р. о 22:47 Tom Rini <[email protected]> пише:

Quoted 61 lines · Svyatoslav Ryhel
Quoted 58 lines

6 червня 2023 р. 22:19:44 GMT+03:00, Tom Rini <[email protected]> написав(-ла):

Quoted 45 lines · Svyatoslav Ryhel
Quoted 35 lines

The ASUS Transformer T30 family are 2-in-1 detachable tablets and AiO developed by ASUS that run the Android operating system (TF600T runs Windows RT and P1801-T runs Android and Windows). The T30 Transformers feature a 10.1-inch display (apart P1801-T), an Nvidia Tegra 3 quad-core chip, 1/2 GB of RAM, and 16/32 GB of storage. Transformers board derives from Nvidia Cardhu development board.

This patch brings support for 7 known Transformer devices:
- ASUS Transformer Prime TF201
- ASUS Transformer Pad TF300T/TF300TG/TF300TL
- ASUS VivoTab RT TF600T (Windows RT based)
- ASUS Transformer Infinity TF700T
- ASUS Transformer AiO P1801-T

---
 arch/arm/dts/Makefile                         |   7 +
 arch/arm/dts/tegra30-asus-p1801-t.dts         |  17 +
 arch/arm/dts/tegra30-asus-tf201.dts           |   9 +
 arch/arm/dts/tegra30-asus-tf300t.dts          |  18 +
 arch/arm/dts/tegra30-asus-tf300tg.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf300tl.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf600t.dts          |  89 +++++
 arch/arm/dts/tegra30-asus-tf700t.dts          |  13 +
 arch/arm/dts/tegra30-asus-transformer.dtsi    | 211 ++++++++++
 arch/arm/mach-tegra/tegra30/Kconfig           |   5 +
 board/asus/transformer-t30/Kconfig            |  23 ++
 board/asus/transformer-t30/MAINTAINERS        |   6 +
 board/asus/transformer-t30/Makefile           |  11 +
 .../pinmux-config-transformer.h               | 365 ++++++++++++++++++
 .../transformer-t30/transformer-t30-spl.c     |  41 ++
 board/asus/transformer-t30/transformer-t30.c  | 201 ++++++++++
Quoted 8 lines
 configs/p1801-t.config                        |   2 +
 configs/tf201.config                          |   2 +
 configs/tf300t.config                         |   2 +
 configs/tf300tg.config                        |   2 +
 configs/tf300tl.config                        |   2 +
 configs/tf600t.config                         |   4 +
 configs/tf700t.config                         |   2 +
 configs/transformer_t30_defconfig             |  85 ++++
Quoted 5 lines

Sorry for not noticing this part sooner. Looking in the kernel, arch/{riscv,powerpc}/Makefile both provide examples of how to automate generating the resulting defconfigs directly. I think we really want that, and also the config fragments need to be listed in the MAINTAINERS file.

Not sure if adding this is a good idea, plus adding fragments into MAINTAINERS may cause even more issues. Iirc buildman uses it as a config source and defining multiple fragments may fail not only for boards under question, but those, already existing in u-boot, as well.

Quoted 5 lines
Quoted 2 lines

If this causes buildman problems then we'll need to figure out something, but it shouldn't.

Adding fragments into MAINTAINERS does not cause issues but seems to not have any effect either.

Well, get_maintainers.pl will now report who owns them, which it didn't before, yes?

Quoted 7 lines
Quoted 2 lines

It does report me if get_maintainers.pl is used anyway, even if no files are specified in MAINTAINERS

As maintainer, or as git heuristics? But all the same, the rule about defconfigs needing to be in MAINTAINERS entires should extend to config fragments.

Hm, not as maintainer even for main defconfig which is strange. I will add fragments as separate files and re-check.

Quoted 41 lines
Quoted 12 lines
Quoted 12 lines
Quoted 11 lines
Quoted 9 lines
Quoted 3 lines

Issue is not in the arch dir to tweak arch's makefile, fragments are used by some boards and issue lays in omitting their existence by system of autobuild.

Yes, and I'd like to set some good examples for the first config fragments we're adding as I suspect you're the first person to notice this works (as a feature not a happenstance) and others will make more use if it for more than a few changes. So I'd like to get things going in the right direction.

May you specify more, what do you exactly want from me to change.

Quoted 7 lines
Quoted 5 lines

Well, as this just came up on the IRC channel as well as someone else noticed fragments work, it would be nice to figure out what needs to be added so they can live in $(BOARDDIR) if possible. Or something that doesn't cause a further explosion of files in configs/ (which is already unwieldy).

I see your point but it is definitely beyond this patchset cover.

Yes, it's not stopping this first patch-set.

Quoted 19 lines
Quoted 19 lines
Quoted 18 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines

I also worry that none of these other configs will be caught by buildmn and so won't be in CI at all, just the base. Which isn't a big problem, yet, but could be as more people use config fragments. I'm just noting this secondary part and not saying you need to fix that as well.

Quoted 8 lines
Quoted 3 lines

Buildman indeed is not catching any fragments, which already caused me issues since defconfigs are not as generic as I would like to (since else I get a big chunk of checks failed).

A good solution might be to tweak buildman to accept fragments if any are defined in the dedicated field of MAINTAINERS file. But that would be a major patchset to implement on the entire project scale.

Yes, I'm not sure how best to deal with fragments to start with, for buildman. But we don't need to solve that today for this series, either.

Does this patchset require any additional changes to be accepted? Have in mind that most likely there will be more patchsets for transformers.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

To be clear, it needs the CI issues that I pointed out in Tom W's pull request to be fixed.

This was done in v5 iteration. I have fixed CI issues you have pointed to. Hopefully, how checks pass.

Were you able to use GitHub / Azure to get a round of CI run?

Unfortunately, I had no time yet, but I will try to set it ASAP.

#14 lore raw

Re: [PATCH v5 4/7] board: asus: transformer: add ASUS Transformer T30 family support

In reply to Tom Rini

чт, 8 черв. 2023 р. о 20:09 Tom Rini <[email protected]> пише:

Quoted 125 lines · Svyatoslav Ryhel
Quoted 71 lines

чт, 8 черв. 2023 р. о 19:40 Tom Rini <[email protected]> пише:

Quoted 70 lines · Svyatoslav Ryhel
Quoted 67 lines

вт, 6 черв. 2023 р. о 22:47 Tom Rini <[email protected]> пише:

Quoted 56 lines · Svyatoslav Ryhel
Quoted 54 lines

6 червня 2023 р. 22:19:44 GMT+03:00, Tom Rini <[email protected]> написав(-ла):

Quoted 50 lines · Svyatoslav Ryhel
Quoted 35 lines

The ASUS Transformer T30 family are 2-in-1 detachable tablets and AiO developed by ASUS that run the Android operating system (TF600T runs Windows RT and P1801-T runs Android and Windows). The T30 Transformers feature a 10.1-inch display (apart P1801-T), an Nvidia Tegra 3 quad-core chip, 1/2 GB of RAM, and 16/32 GB of storage. Transformers board derives from Nvidia Cardhu development board.

This patch brings support for 7 known Transformer devices:
- ASUS Transformer Prime TF201
- ASUS Transformer Pad TF300T/TF300TG/TF300TL
- ASUS VivoTab RT TF600T (Windows RT based)
- ASUS Transformer Infinity TF700T
- ASUS Transformer AiO P1801-T

---
 arch/arm/dts/Makefile                         |   7 +
 arch/arm/dts/tegra30-asus-p1801-t.dts         |  17 +
 arch/arm/dts/tegra30-asus-tf201.dts           |   9 +
 arch/arm/dts/tegra30-asus-tf300t.dts          |  18 +
 arch/arm/dts/tegra30-asus-tf300tg.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf300tl.dts         |   9 +
 arch/arm/dts/tegra30-asus-tf600t.dts          |  89 +++++
 arch/arm/dts/tegra30-asus-tf700t.dts          |  13 +
 arch/arm/dts/tegra30-asus-transformer.dtsi    | 211 ++++++++++
 arch/arm/mach-tegra/tegra30/Kconfig           |   5 +
 board/asus/transformer-t30/Kconfig            |  23 ++
 board/asus/transformer-t30/MAINTAINERS        |   6 +
 board/asus/transformer-t30/Makefile           |  11 +
 .../pinmux-config-transformer.h               | 365 ++++++++++++++++++
 .../transformer-t30/transformer-t30-spl.c     |  41 ++
 board/asus/transformer-t30/transformer-t30.c  | 201 ++++++++++
Quoted 8 lines
 configs/p1801-t.config                        |   2 +
 configs/tf201.config                          |   2 +
 configs/tf300t.config                         |   2 +
 configs/tf300tg.config                        |   2 +
 configs/tf300tl.config                        |   2 +
 configs/tf600t.config                         |   4 +
 configs/tf700t.config                         |   2 +
 configs/transformer_t30_defconfig             |  85 ++++

Sorry for not noticing this part sooner. Looking in the kernel, arch/{riscv,powerpc}/Makefile both provide examples of how to automate generating the resulting defconfigs directly. I think we really want that, and also the config fragments need to be listed in the MAINTAINERS file.

Quoted 7 lines
Quoted 4 lines

Not sure if adding this is a good idea, plus adding fragments into MAINTAINERS may cause even more issues. Iirc buildman uses it as a config source and defining multiple fragments may fail not only for boards under question, but those, already existing in u-boot, as well.

If this causes buildman problems then we'll need to figure out something, but it shouldn't.

Adding fragments into MAINTAINERS does not cause issues but seems to not have any effect either.

Quoted 6 lines
Quoted 3 lines

Well, get_maintainers.pl will now report who owns them, which it didn't before, yes?

It does report me if get_maintainers.pl is used anyway, even if no files are specified in MAINTAINERS

As maintainer, or as git heuristics? But all the same, the rule about defconfigs needing to be in MAINTAINERS entires should extend to config fragments.

Quoted 12 lines
Quoted 12 lines
Quoted 11 lines
Quoted 9 lines
Quoted 3 lines

Issue is not in the arch dir to tweak arch's makefile, fragments are used by some boards and issue lays in omitting their existence by system of autobuild.

Yes, and I'd like to set some good examples for the first config fragments we're adding as I suspect you're the first person to notice this works (as a feature not a happenstance) and others will make more use if it for more than a few changes. So I'd like to get things going in the right direction.

May you specify more, what do you exactly want from me to change.

Quoted 7 lines
Quoted 5 lines

Well, as this just came up on the IRC channel as well as someone else noticed fragments work, it would be nice to figure out what needs to be added so they can live in $(BOARDDIR) if possible. Or something that doesn't cause a further explosion of files in configs/ (which is already unwieldy).

I see your point but it is definitely beyond this patchset cover.

Yes, it's not stopping this first patch-set.

Quoted 19 lines
Quoted 19 lines
Quoted 18 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines

I also worry that none of these other configs will be caught by buildmn and so won't be in CI at all, just the base. Which isn't a big problem, yet, but could be as more people use config fragments. I'm just noting this secondary part and not saying you need to fix that as well.

Quoted 8 lines
Quoted 3 lines

Buildman indeed is not catching any fragments, which already caused me issues since defconfigs are not as generic as I would like to (since else I get a big chunk of checks failed).

A good solution might be to tweak buildman to accept fragments if any are defined in the dedicated field of MAINTAINERS file. But that would be a major patchset to implement on the entire project scale.

Yes, I'm not sure how best to deal with fragments to start with, for buildman. But we don't need to solve that today for this series, either.

Does this patchset require any additional changes to be accepted? Have in mind that most likely there will be more patchsets for transformers.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

To be clear, it needs the CI issues that I pointed out in Tom W's pull request to be fixed.

This was done in v5 iteration. I have fixed CI issues you have pointed to. Hopefully, how checks pass.

Were you able to use GitHub / Azure to get a round of CI run?

I have set Gitlab CI pipelines, once they pass I will upload the next patchset iteration with changes to the MAINTAINERS file you have asked for.

Best regards,
Svyatoslav R.

Quoted 2 lines

--
Tom

#15 lore raw

PATCH v5 5/7 board: asus: grouper: add Google Nexus 7 (2012) support

In reply to Svyatoslav Ryhel

Nexus 7 is a mini tablet computer co-developed by Google and Asus that runs the Android operating system. The Nexus 7 features a 7" display, an Nvidia Tegra 3 quad-core chip, 1 GB of RAM and 8/16 GB of internal storage.

This patch brings support for all 3 known ASUS/Google devices:
- Nexus 7 (2012) E1565
- Nexus 7 (2012) PM269
- Nexus 7 (2012) 3G - tilapia

---
 arch/arm/dts/Makefile                         |   3 +
 arch/arm/dts/tegra30-asus-grouper-common.dtsi | 157 ++++++++
 .../dts/tegra30-asus-nexus7-grouper-E1565.dts |  43 +++
 .../dts/tegra30-asus-nexus7-grouper-PM269.dts |  36 ++
 .../dts/tegra30-asus-nexus7-tilapia-E1565.dts |  62 +++
 arch/arm/mach-tegra/tegra30/Kconfig           |   5 +
 board/asus/grouper/Kconfig                    |  22 ++
 board/asus/grouper/MAINTAINERS                |   6 +
 board/asus/grouper/Makefile                   |  14 +
 board/asus/grouper/grouper-spl-max.c          |  45 +++
 board/asus/grouper/grouper-spl-ti.c           |  41 ++
 board/asus/grouper/grouper.c                  | 202 ++++++++++
 board/asus/grouper/pinmux-config-grouper.h    | 362 ++++++++++++++++++
 configs/grouper_E1565.config                  |   2 +
 configs/grouper_PM269.config                  |   2 +
 configs/grouper_common_defconfig              |  84 ++++
 configs/tilapia.config                        |   3 +
 doc/board/asus/grouper_common.rst             |  95 +++++
 doc/board/asus/index.rst                      |   1 +
 include/configs/grouper.h                     |  61 +++
 20 files changed, 1246 insertions(+)
 create mode 100644 arch/arm/dts/tegra30-asus-grouper-common.dtsi
 create mode 100644 arch/arm/dts/tegra30-asus-nexus7-grouper-E1565.dts
 create mode 100644 arch/arm/dts/tegra30-asus-nexus7-grouper-PM269.dts
 create mode 100644 arch/arm/dts/tegra30-asus-nexus7-tilapia-E1565.dts
 create mode 100644 board/asus/grouper/Kconfig
 create mode 100644 board/asus/grouper/MAINTAINERS
 create mode 100644 board/asus/grouper/Makefile
 create mode 100644 board/asus/grouper/grouper-spl-max.c
 create mode 100644 board/asus/grouper/grouper-spl-ti.c
 create mode 100644 board/asus/grouper/grouper.c
 create mode 100644 board/asus/grouper/pinmux-config-grouper.h
 create mode 100644 configs/grouper_E1565.config
 create mode 100644 configs/grouper_PM269.config
 create mode 100644 configs/grouper_common_defconfig
 create mode 100644 configs/tilapia.config
 create mode 100644 doc/board/asus/grouper_common.rst
 create mode 100644 include/configs/grouper.h
arch/arm/dts/Makefile +3 -0
index c87729d45e..f2b4044a01 100644
@@ -237,6 +237,9 @@ dtb-$(CONFIG_ARCH_TEGRA) += tegra20-harmony.dtb \
 	tegra20-ventana.dtb \
 	tegra20-colibri.dtb \
 	tegra30-apalis.dtb \
+	tegra30-asus-nexus7-grouper-PM269.dtb \
+	tegra30-asus-nexus7-grouper-E1565.dtb \
+	tegra30-asus-nexus7-tilapia-E1565.dtb \
 	tegra30-asus-p1801-t.dtb \
 	tegra30-asus-tf201.dtb \
 	tegra30-asus-tf300t.dtb \
arch/arm/dts/tegra30-asus-grouper-common.dtsi new file +157 -0

157 lines not on this page · raw message

arch/arm/dts/tegra30-asus-nexus7-grouper-E1565.dts new file +43 -0

43 lines not on this page · raw message

arch/arm/dts/tegra30-asus-nexus7-grouper-PM269.dts new file +36 -0
new file mode 100644
index 0000000000..44ea218a47
@@ -0,0 +1,36 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+
+#include "tegra30-asus-grouper-common.dtsi"
+
+/ {
+	model = "ASUS Google Nexus 7 (Project Nakasi / ME370T) PM269";
+	compatible = "asus,grouper", "nvidia,tegra30";
+
+	i2c@7000d000 {
+		/* Texas Instruments TPS659110 PMIC */
+		pmic: tps65911@2d {
+			compatible = "ti,tps65911";
+			reg = <0x2d>;
+
+			interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
+			#interrupt-cells = <2>;
+			interrupt-controller;
+
+			ti,system-power-controller;
+
+			#gpio-cells = <2>;
+			gpio-controller;
+
+			regulators {
+				/* eMMC VDD */
+				vcore_emmc: ldo1 {
+					regulator-name = "vdd_emmc_core";
+					regulator-min-microvolt = <1000000>;
+					regulator-max-microvolt = <3300000>;
+					regulator-always-on;
+				};
+			};
+		};
+	};
+};
arch/arm/dts/tegra30-asus-nexus7-tilapia-E1565.dts new file +62 -0

62 lines not on this page · raw message

arch/arm/mach-tegra/tegra30/Kconfig +5 -0
index 4f78d0ba97..6cbb73ebee 100644
@@ -20,6 +20,10 @@ config TARGET_COLIBRI_T30
 	bool "Toradex Colibri T30 board"
 	select BOARD_LATE_INIT
 
+config TARGET_GROUPER
+	bool "Asus and Google Grouper board"
+	select BOARD_LATE_INIT
+
 config TARGET_TEC_NG
 	bool "Avionic Design TEC-NG board"
 	select BOARD_LATE_INIT
@@ -37,6 +41,7 @@ source "board/toradex/apalis_t30/Kconfig"
 source "board/nvidia/beaver/Kconfig"
 source "board/nvidia/cardhu/Kconfig"
 source "board/toradex/colibri_t30/Kconfig"
+source "board/asus/grouper/Kconfig"
 source "board/avionic-design/tec-ng/Kconfig"
 source "board/asus/transformer-t30/Kconfig"
 
board/asus/grouper/Kconfig new file +22 -0
new file mode 100644
index 0000000000..912c6c5fba
@@ -0,0 +1,22 @@
+if TARGET_GROUPER
+
+config SYS_BOARD
+	default "grouper"
+
+config SYS_VENDOR
+	default "asus"
+
+config SYS_CONFIG_NAME
+	default "grouper"
+
+config GROUPER_TPS65911
+	bool "Enable support TI TPS65911 PMIC"
+	select CMD_POWEROFF
+	default n
+
+config GROUPER_MAX77663
+	bool "Enable support MAXIM MAX77663 PMIC"
+	select CMD_POWEROFF
+	default n
+
+endif
board/asus/grouper/MAINTAINERS new file +6 -0
new file mode 100644
index 0000000000..0f7578e368
@@ -0,0 +1,6 @@
+GROUPER BOARD
+M:	Svyatoslav Ryhel <[email protected]>
+S:	Maintained
+F:	board/asus/grouper/
+F:	include/configs/grouper.h
+F:	configs/grouper_common_defconfig
board/asus/grouper/Makefile new file +14 -0
new file mode 100644
index 0000000000..e4a477a366
@@ -0,0 +1,14 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+#  (C) Copyright 2010-2012
+#  NVIDIA Corporation <www.nvidia.com>
+#
+#  (C) Copyright 2021
+#  Svyatoslav Ryhel <[email protected]>
+
+ifdef CONFIG_SPL_BUILD
+obj-$(CONFIG_GROUPER_MAX77663) += grouper-spl-max.o
+obj-$(CONFIG_GROUPER_TPS65911) += grouper-spl-ti.o
+endif
+
+obj-y += grouper.o
board/asus/grouper/grouper-spl-max.c new file +45 -0

45 lines not on this page · raw message

board/asus/grouper/grouper-spl-ti.c new file +41 -0

41 lines not on this page · raw message

board/asus/grouper/grouper.c new file +202 -0

202 lines not on this page · raw message

board/asus/grouper/pinmux-config-grouper.h new file +362 -0

362 lines not on this page · raw message

configs/grouper_E1565.config new file +2 -0
new file mode 100644
index 0000000000..4d8d5263fa
@@ -0,0 +1,2 @@
+CONFIG_DEFAULT_DEVICE_TREE="tegra30-asus-nexus7-grouper-E1565"
+CONFIG_GROUPER_MAX77663=y
configs/grouper_PM269.config new file +2 -0
new file mode 100644
index 0000000000..fc768b2051
@@ -0,0 +1,2 @@
+CONFIG_DEFAULT_DEVICE_TREE="tegra30-asus-nexus7-grouper-PM269"
+CONFIG_GROUPER_TPS65911=y
configs/grouper_common_defconfig new file +84 -0

84 lines not on this page · raw message

configs/tilapia.config new file +3 -0
new file mode 100644
index 0000000000..1fb0633e3a
@@ -0,0 +1,3 @@
+CONFIG_DEFAULT_DEVICE_TREE="tegra30-asus-nexus7-tilapia-E1565"
+CONFIG_GROUPER_MAX77663=y
+CONFIG_SYS_PROMPT="Tegra30 (Tilapia) # "
doc/board/asus/grouper_common.rst new file +95 -0

95 lines not on this page · raw message

doc/board/asus/index.rst +1 -0
index c59571c8b3..87e535fe34 100644
@@ -6,4 +6,5 @@ ASUS
 .. toctree::
    :maxdepth: 2
 
+   grouper_common
    transformer_t30
include/configs/grouper.h new file +61 -0

61 lines not on this page · raw message

Signature · 1 line
2.39.2
#16 lore raw

PATCH v5 6/7 board: lg: x3: add Optimus 4X HD and Optimus Vu support

In reply to Svyatoslav Ryhel

LG X3 is a development board based on Nvidia Tegra 3 SoC on base of which Optimus 4X HD and Optimus Vu were created. Both smartphones feature a 4.7" and 5" panels respectively, an Nvidia Tegra 3 quad-core chip, 1 GB of RAM and 16/32 GB of internal storage. Optimux 4X HD additionally has a micro SD slot.

---
 arch/arm/dts/Makefile               |   2 +
 arch/arm/dts/tegra30-lg-p880.dts    |  40 +++
 arch/arm/dts/tegra30-lg-p895.dts    |  50 ++++
 arch/arm/dts/tegra30-lg-x3.dtsi     | 180 +++++++++++
 arch/arm/mach-tegra/tegra30/Kconfig |   5 +
 board/lg/x3-t30/Kconfig             |  26 ++
 board/lg/x3-t30/MAINTAINERS         |   6 +
 board/lg/x3-t30/Makefile            |  11 +
 board/lg/x3-t30/pinmux-config-x3.h  | 449 ++++++++++++++++++++++++++++
 board/lg/x3-t30/x3-t30-spl.c        |  48 +++
 board/lg/x3-t30/x3-t30.c            | 176 +++++++++++
 configs/p880.config                 |   4 +
 configs/p895.config                 |   4 +
 configs/x3_t30_defconfig            |  88 ++++++
 doc/board/lg/index.rst              |   9 +
 doc/board/lg/x3_t30.rst             |  93 ++++++
 include/configs/x3-t30.h            |  77 +++++
 17 files changed, 1268 insertions(+)
 create mode 100644 arch/arm/dts/tegra30-lg-p880.dts
 create mode 100644 arch/arm/dts/tegra30-lg-p895.dts
 create mode 100644 arch/arm/dts/tegra30-lg-x3.dtsi
 create mode 100644 board/lg/x3-t30/Kconfig
 create mode 100644 board/lg/x3-t30/MAINTAINERS
 create mode 100644 board/lg/x3-t30/Makefile
 create mode 100644 board/lg/x3-t30/pinmux-config-x3.h
 create mode 100644 board/lg/x3-t30/x3-t30-spl.c
 create mode 100644 board/lg/x3-t30/x3-t30.c
 create mode 100644 configs/p880.config
 create mode 100644 configs/p895.config
 create mode 100644 configs/x3_t30_defconfig
 create mode 100644 doc/board/lg/index.rst
 create mode 100644 doc/board/lg/x3_t30.rst
 create mode 100644 include/configs/x3-t30.h
arch/arm/dts/Makefile +2 -0
index f2b4044a01..f31cabc27b 100644
@@ -250,6 +250,8 @@ dtb-$(CONFIG_ARCH_TEGRA) += tegra20-harmony.dtb \
 	tegra30-beaver.dtb \
 	tegra30-cardhu.dtb \
 	tegra30-colibri.dtb \
+	tegra30-lg-p880.dtb \
+	tegra30-lg-p895.dtb \
 	tegra30-tec-ng.dtb \
 	tegra114-dalmore.dtb \
 	tegra124-apalis.dtb \
arch/arm/dts/tegra30-lg-p880.dts new file +40 -0
new file mode 100644
index 0000000000..81d364310d
@@ -0,0 +1,40 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+
+#include "tegra30-lg-x3.dtsi"
+
+/ {
+	model = "LG Optimus 4X HD";
+	compatible = "lge,p880", "nvidia,tegra30";
+
+	aliases {
+		mmc1 = &sdmmc3; /* uSD slot */
+	};
+
+	sdmmc3: sdhci@78000400  {
+		status = "okay";
+		bus-width = <4>;
+
+		cd-gpios = <&gpio TEGRA_GPIO(W, 5) GPIO_ACTIVE_LOW>;
+
+		vmmc-supply = <&vdd_usd>;
+		vqmmc-supply = <&vdd_1v8_vio>;
+	};
+
+	gpio-keys {
+		key-volume-up {
+			label = "Volume Up";
+			gpios = <&gpio TEGRA_GPIO(O, 7) GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_UP>;
+		};
+	};
+
+	panel: panel {
+		compatible = "jdi,dx12d100vm0eaa";
+
+		enable-gpios = <&gpio TEGRA_GPIO(Y, 0) GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpio TEGRA_GPIO(W, 0) GPIO_ACTIVE_HIGH>;
+
+		backlight = <&backlight>;
+	};
+};
arch/arm/dts/tegra30-lg-p895.dts new file +50 -0

50 lines not on this page · raw message

arch/arm/dts/tegra30-lg-x3.dtsi new file +180 -0

180 lines not on this page · raw message

arch/arm/mach-tegra/tegra30/Kconfig +5 -0
index 6cbb73ebee..9b1df21d28 100644
@@ -32,6 +32,10 @@ config TARGET_TRANSFORMER_T30
 	bool "Asus Tegra30 Transformer board"
 	select BOARD_LATE_INIT
 
+config TARGET_X3_T30
+	bool "LG X3 Tegra30 board"
+	select BOARD_LATE_INIT
+
 endchoice
 
 config SYS_SOC
@@ -44,5 +48,6 @@ source "board/toradex/colibri_t30/Kconfig"
 source "board/asus/grouper/Kconfig"
 source "board/avionic-design/tec-ng/Kconfig"
 source "board/asus/transformer-t30/Kconfig"
+source "board/lg/x3-t30/Kconfig"
 
 endif
board/lg/x3-t30/Kconfig new file +26 -0
new file mode 100644
index 0000000000..20ea4f5f32
@@ -0,0 +1,26 @@
+if TARGET_X3_T30
+
+config SYS_BOARD
+	default "x3-t30"
+
+config SYS_VENDOR
+	default "lg"
+
+config SYS_CONFIG_NAME
+	default "x3-t30"
+
+config DEVICE_P880
+	bool "Enable support for LG Optimus 4X HD"
+	default n
+	help
+	  LG Optimus 4X HD derives from x3 board but has slight
+	  differences.
+
+config DEVICE_P895
+	bool "Enable support for LG Optimus Vu"
+	default n
+	help
+	  LG Optimus Vu derives from x3 board but has slight
+	  differences.
+
+endif
board/lg/x3-t30/MAINTAINERS new file +6 -0
new file mode 100644
index 0000000000..707efe39d4
@@ -0,0 +1,6 @@
+X3 BOARD
+M:	Svyatoslav Ryhel <[email protected]>
+S:	Maintained
+F:	board/lg/x3-t30/
+F:	include/configs/x3-t30.h
+F:	configs/x3_t30_defconfig
board/lg/x3-t30/Makefile new file +11 -0
new file mode 100644
index 0000000000..3eeb132f3c
@@ -0,0 +1,11 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+#  (C) Copyright 2010-2012
+#  NVIDIA Corporation <www.nvidia.com>
+#
+#  (C) Copyright 2021
+#  Svyatoslav Ryhel <[email protected]>
+
+obj-$(CONFIG_SPL_BUILD) += x3-t30-spl.o
+
+obj-y += x3-t30.o
board/lg/x3-t30/pinmux-config-x3.h new file +449 -0

449 lines not on this page · raw message

board/lg/x3-t30/x3-t30-spl.c new file +48 -0

48 lines not on this page · raw message

board/lg/x3-t30/x3-t30.c new file +176 -0

176 lines not on this page · raw message

configs/p880.config new file +4 -0
new file mode 100644
index 0000000000..1a47b5f769
@@ -0,0 +1,4 @@
+CONFIG_DEFAULT_DEVICE_TREE="tegra30-lg-p880"
+CONFIG_DEVICE_P880=y
+CONFIG_SYS_PROMPT="Tegra30 (P880) # "
+CONFIG_VIDEO_LCD_RENESAS_R69328=y
configs/p895.config new file +4 -0
new file mode 100644
index 0000000000..019a5662d6
@@ -0,0 +1,4 @@
+CONFIG_DEFAULT_DEVICE_TREE="tegra30-lg-p895"
+CONFIG_DEVICE_P895=y
+CONFIG_SYS_PROMPT="Tegra30 (P895) # "
+CONFIG_VIDEO_LCD_RENESAS_R61307=y
configs/x3_t30_defconfig new file +88 -0

88 lines not on this page · raw message

doc/board/lg/index.rst new file +9 -0
new file mode 100644
index 0000000000..3af3681e0b
@@ -0,0 +1,9 @@
+.. SPDX-License-Identifier: GPL-2.0+
+
+LG
+==
+
+.. toctree::
+   :maxdepth: 2
+
+   x3_t30
doc/board/lg/x3_t30.rst new file +93 -0

93 lines not on this page · raw message

include/configs/x3-t30.h new file +77 -0

77 lines not on this page · raw message

Signature · 1 line
2.39.2
#17 lore raw

PATCH v5 7/7 board: htc: endeavoru: add One X support

In reply to Svyatoslav Ryhel

The HTC One X is a touchscreen-based, slate-sized smartphone designed and manufactured by HTC that runs the Android operating system. The One X features a 4.7" display, an Nvidia Tegra 3 quad-core chip, 1 GB of RAM and non-extendable 32 GB of internal storage. UART-A is default debug port.

---
 arch/arm/dts/tegra30-htc-endeavoru.dts        | 166 ++++++++
 arch/arm/mach-tegra/tegra30/Kconfig           |   5 +
 board/htc/endeavoru/Kconfig                   |  12 +
 board/htc/endeavoru/MAINTAINERS               |   6 +
 board/htc/endeavoru/Makefile                  |  11 +
 board/htc/endeavoru/endeavoru-spl.c           |  47 +++
 board/htc/endeavoru/endeavoru.c               | 116 ++++++
 board/htc/endeavoru/pinmux-config-endeavoru.h | 362 ++++++++++++++++++
 configs/endeavoru_defconfig                   |  84 ++++
 doc/board/htc/endeavoru.rst                   |  90 +++++
 doc/board/htc/index.rst                       |   9 +
 include/configs/endeavoru.h                   |  65 ++++
 12 files changed, 973 insertions(+)
 create mode 100644 arch/arm/dts/tegra30-htc-endeavoru.dts
 create mode 100644 board/htc/endeavoru/Kconfig
 create mode 100644 board/htc/endeavoru/MAINTAINERS
 create mode 100644 board/htc/endeavoru/Makefile
 create mode 100644 board/htc/endeavoru/endeavoru-spl.c
 create mode 100644 board/htc/endeavoru/endeavoru.c
 create mode 100644 board/htc/endeavoru/pinmux-config-endeavoru.h
 create mode 100644 configs/endeavoru_defconfig
 create mode 100644 doc/board/htc/endeavoru.rst
 create mode 100644 doc/board/htc/index.rst
 create mode 100644 include/configs/endeavoru.h
arch/arm/dts/tegra30-htc-endeavoru.dts new file +166 -0
new file mode 100644
index 0000000000..c55e193d1d
@@ -0,0 +1,166 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+
+/* This dts file describes the HTC One X smartphone */
+/* CPU Speedo ID 4, Soc Speedo ID 1, CPU Process: 1, Core Process: 0 */
+
+#include <dt-bindings/input/input.h>
+
+#include "tegra30.dtsi"
+
+/ {
+	model = "HTC One X";
+	compatible = "htc,endeavoru", "nvidia,tegra30";
+
+	chosen {
+		stdout-path = &uarta;
+	};
+
+	aliases {
+		i2c0 = &pwr_i2c;
+
+		mmc0 = &sdmmc4;	/* eMMC */
+
+		rtc0 = &pmic;
+		rtc1 = "/rtc@7000e000";
+
+		usb0 = &micro_usb;
+	};
+
+	memory {
+		device_type = "memory";
+		reg = <0x80000000 0x40000000>;
+	};
+
+	host1x@50000000 {
+		dc@54200000 {
+			clocks = <&tegra_car TEGRA30_CLK_DISP1>,
+				 <&tegra_car TEGRA30_CLK_PLL_D_OUT0>;
+
+			rgb {
+				status = "okay";
+
+				nvidia,panel = <&dsia>;
+			};
+		};
+
+		dsia: dsi@54300000 {
+			status = "okay";
+
+			avdd-dsi-csi-supply = <&avdd_dsi_csi>;
+
+			panel = <&panel>;
+		};
+	};
+
+	uarta: serial@70006000 {
+		status = "okay";
+	};
+
+	pwr_i2c: i2c@7000d000 {
+		status = "okay";
+		clock-frequency = <100000>;
+
+		/* Texas Instruments TPS80032 PMIC */
+		pmic: tps80032@48 {
+			compatible = "ti,tps80032";
+			reg = <0x48>;
+
+			regulators {
+				/* DSI VDD */
+				avdd_dsi_csi: ldo1 {
+					regulator-name = "avdd_dsi_csi";
+					regulator-min-microvolt = <1200000>;
+					regulator-max-microvolt = <1200000>;
+					regulator-always-on;
+				};
+			};
+		};
+	};
+
+	sdmmc4: sdhci@78000600 {
+		status = "okay";
+		bus-width = <8>;
+		non-removable;
+	};
+
+	micro_usb: usb@7d000000 {
+		status = "okay";
+		dr_mode = "otg";
+	};
+
+	backlight: backlight {
+		compatible = "nvidia,tegra-pwm-backlight";
+
+		nvidia,pwm-source = <1>;
+		nvidia,default-brightness = <0x8E>;
+	};
+
+	/* PMIC has a built-in 32KHz oscillator which is used by PMC */
+	clk32k_in: clock-32k {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <32768>;
+		clock-output-names = "pmic-oscillator";
+	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+
+		key-power {
+			label = "Power";
+			gpios = <&gpio TEGRA_GPIO(U, 6) GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_ENTER>;
+		};
+
+		key-volume-up {
+			label = "Volume Up";
+			gpios = <&gpio TEGRA_GPIO(S, 0) GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_UP>;
+		};
+
+		key-volume-down {
+			label = "Volume Down";
+			gpios = <&gpio TEGRA_GPIO(W, 3) GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_DOWN>;
+		};
+	};
+
+	panel: panel {
+		compatible = "htc,edge-panel";
+
+		reset-gpios = <&gpio TEGRA_GPIO(N, 6) GPIO_ACTIVE_LOW>;
+
+		vdd-supply = <&vdd_3v3_panel>;
+		vddio-supply = <&vdd_1v8_panel>;
+
+		backlight = <&backlight>;
+	};
+
+	vcore_emmc: regulator-emmc {
+		compatible = "regulator-fixed";
+		regulator-name = "vdd_2v85_sdmmc";
+		regulator-min-microvolt = <2850000>;
+		regulator-max-microvolt = <2850000>;
+		gpio = <&gpio TEGRA_GPIO(M, 3) GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	vdd_3v3_panel: regulator-lcm {
+		compatible = "regulator-fixed";
+		regulator-name = "v_lcm_3v3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio TEGRA_GPIO(E, 2) GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	vdd_1v8_panel: regulator-lcmio {
+		compatible = "regulator-fixed";
+		regulator-name = "v_lcmio_1v8";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		gpio = <&gpio TEGRA_GPIO(E, 5) GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+};
arch/arm/mach-tegra/tegra30/Kconfig +5 -0
index 9b1df21d28..3e478b3b7b 100644
@@ -20,6 +20,10 @@ config TARGET_COLIBRI_T30
 	bool "Toradex Colibri T30 board"
 	select BOARD_LATE_INIT
 
+config TARGET_ENDEAVORU
+	bool "HTC Endeavoru T30 board"
+	select BOARD_LATE_INIT
+
 config TARGET_GROUPER
 	bool "Asus and Google Grouper board"
 	select BOARD_LATE_INIT
@@ -45,6 +49,7 @@ source "board/toradex/apalis_t30/Kconfig"
 source "board/nvidia/beaver/Kconfig"
 source "board/nvidia/cardhu/Kconfig"
 source "board/toradex/colibri_t30/Kconfig"
+source "board/htc/endeavoru/Kconfig"
 source "board/asus/grouper/Kconfig"
 source "board/avionic-design/tec-ng/Kconfig"
 source "board/asus/transformer-t30/Kconfig"
board/htc/endeavoru/Kconfig new file +12 -0
new file mode 100644
index 0000000000..0b72c4a687
@@ -0,0 +1,12 @@
+if TARGET_ENDEAVORU
+
+config SYS_BOARD
+	default "endeavoru"
+
+config SYS_VENDOR
+	default "htc"
+
+config SYS_CONFIG_NAME
+	default "endeavoru"
+
+endif
board/htc/endeavoru/MAINTAINERS new file +6 -0
new file mode 100644
index 0000000000..d7f83e8487
@@ -0,0 +1,6 @@
+ENDEAVORU BOARD
+M:	Svyatoslav Ryhel <[email protected]>
+S:	Maintained
+F:	board/htc/endeavoru/
+F:	include/configs/endeavoru.h
+F:	configs/endeavoru_defconfig
board/htc/endeavoru/Makefile new file +11 -0
new file mode 100644
index 0000000000..0c6ba4af3b
@@ -0,0 +1,11 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+#  (C) Copyright 2010-2012
+#  NVIDIA Corporation <www.nvidia.com>
+#
+#  (C) Copyright 2021
+#  Svyatoslav Ryhel <[email protected]>
+
+obj-$(CONFIG_SPL_BUILD) += endeavoru-spl.o
+
+obj-y += endeavoru.o
board/htc/endeavoru/endeavoru-spl.c new file +47 -0

47 lines not on this page · raw message

board/htc/endeavoru/endeavoru.c new file +116 -0

116 lines not on this page · raw message

board/htc/endeavoru/pinmux-config-endeavoru.h new file +362 -0

362 lines not on this page · raw message

configs/endeavoru_defconfig new file +84 -0

84 lines not on this page · raw message

doc/board/htc/endeavoru.rst new file +90 -0

90 lines not on this page · raw message

doc/board/htc/index.rst new file +9 -0
new file mode 100644
index 0000000000..955c9b9e03
@@ -0,0 +1,9 @@
+.. SPDX-License-Identifier: GPL-2.0+
+
+HTC
+===
+
+.. toctree::
+   :maxdepth: 2
+
+   endeavoru
include/configs/endeavoru.h new file +65 -0

65 lines not on this page · raw message

Signature · 1 line
2.39.2