Resolve some redundant property accessors
Subsystems (2)
cover Resolve some redundant property accessors
The QOM API already provides appropriate accessors, so reuse them.
Testing done:
:$ make check
Ok: 569 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 178 Timeout: 0
Bernhard Beschow (2):
hw/vfio/pci-quirks: Resolve redundant property getters hw/riscv/sifive_u: Resolve redundant property accessors
hw/riscv/sifive_u.c | 24 ++++-------------------- hw/vfio/pci-quirks.c | 34 +++++++++------------------------- 2 files changed, 13 insertions(+), 45 deletions(-)
Signature · 1 line
2.35.1
PATCH 1/2 hw/vfio/pci-quirks: Resolve redundant property getters
The QOM API already provides getters for uint64 and uint32 values, so reuse them.
--- hw/vfio/pci-quirks.c | 34 +++++++++------------------------- 1 file changed, 9 insertions(+), 25 deletions(-)
hw/vfio/pci-quirks.c +9 -25
@@ -1565,22 +1565,6 @@ static int vfio_add_nv_gpudirect_cap(VFIOPCIDevice *vdev, Error **errp)return 0 ; } -static void vfio_pci_nvlink2_get_tgt (Object *obj,Visitor *v, -const char *name, -void *opaque,Error **errp) -{ -uint64_t tgt = (uintptr_t ) opaque; -visit_type_uint64 (v, name, &tgt, errp); -} - -static void vfio_pci_nvlink2_get_link_speed (Object *obj,Visitor *v, -const char *name, -void *opaque,Error **errp) -{ -uint32_t link_speed = (uint32_t )(uintptr_t ) opaque; -visit_type_uint32 (v, name, &link_speed, errp); -} -int vfio_pci_nvidia_v100_ram_init (VFIOPCIDevice *vdev,Error **errp) {int ret;
@@ -1618,9 +1602,9 @@ int vfio_pci_nvidia_v100_ram_init(VFIOPCIDevice *vdev, Error **errp) nv2reg->size, p);QLIST_INSERT_HEAD (&vdev->bars[0 ].quirks, quirk, next); -object_property_add (OBJECT (vdev),"nvlink2-tgt" ,"uint64" , - vfio_pci_nvlink2_get_tgt,NULL ,NULL , - (void *) (uintptr_t ) cap->tgt); +object_property_add_uint64_ptr (OBJECT (vdev),"nvlink2-tgt" , + (uint64_t *) &cap->tgt, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvidia_gpu_setup_quirk (vdev->vbasedev.name, cap->tgt, nv2reg->size); free_exit:
@@ -1679,15 +1663,15 @@ int vfio_pci_nvlink2_init(VFIOPCIDevice *vdev, Error **errp)QLIST_INSERT_HEAD (&vdev->bars[0 ].quirks, quirk, next); } -object_property_add (OBJECT (vdev),"nvlink2-tgt" ,"uint64" , - vfio_pci_nvlink2_get_tgt,NULL ,NULL , - (void *) (uintptr_t ) captgt->tgt); +object_property_add_uint64_ptr (OBJECT (vdev),"nvlink2-tgt" , + (uint64_t *) &captgt->tgt, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvlink2_setup_quirk_ssatgt (vdev->vbasedev.name, captgt->tgt, atsdreg->size); -object_property_add (OBJECT (vdev),"nvlink2-link-speed" ,"uint32" , - vfio_pci_nvlink2_get_link_speed,NULL ,NULL , - (void *) (uintptr_t ) capspeed->link_speed); +object_property_add_uint32_ptr (OBJECT (vdev),"nvlink2-link-speed" , + &capspeed->link_speed, +OBJ_PROP_FLAG_READ );trace_vfio_pci_nvlink2_setup_quirk_lnkspd (vdev->vbasedev.name, capspeed->link_speed); free_exit:
Signature · 1 line
2.35.1
Re: [PATCH 1/2] hw/vfio/pci-quirks: Resolve redundant property getters
Quoted 7 lines · Bernhard Beschow
The QOM API already provides getters for uint64 and uint32 values, so reuse them.
Signed-off-by Bernhard Beschow <[email protected]>--- hw/vfio/pci-quirks.c | 34 +++++++++------------------------- 1 file changed, 9 insertions(+), 25 deletions(-)
PATCH 2/2 hw/riscv/sifive_u: Resolve redundant property accessors
In reply to Bernhard BeschowThe QOM API already provides accessors for uint32 values, so reuse them.
--- hw/riscv/sifive_u.c | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-)
hw/riscv/sifive_u.c +4 -20
@@ -713,36 +713,20 @@ static void sifive_u_machine_set_start_in_flash(Object *obj, bool value, Error * s->start_in_flash = value; } -static void sifive_u_machine_get_uint32_prop (Object *obj,Visitor *v, -const char *name,void *opaque, -Error **errp) -{ -visit_type_uint32 (v, name, (uint32_t *)opaque, errp); -} - -static void sifive_u_machine_set_uint32_prop (Object *obj,Visitor *v, -const char *name,void *opaque, -Error **errp) -{ -visit_type_uint32 (v, name, (uint32_t *)opaque, errp); -} -static void sifive_u_machine_instance_init (Object *obj) {SiFiveUState *s =RISCV_U_MACHINE (obj); s->start_in_flash = false; s->msel =0 ; -object_property_add (obj,"msel" ,"uint32" , - sifive_u_machine_get_uint32_prop, - sifive_u_machine_set_uint32_prop,NULL , &s->msel); +object_property_add_uint32_ptr (obj,"msel" , &s->msel, +OBJ_PROP_FLAG_READWRITE );object_property_set_description (obj,"msel" ,"Mode Select (MSEL[3:0]) pin state" ); s->serial =OTP_SERIAL ; -object_property_add (obj,"serial" ,"uint32" , - sifive_u_machine_get_uint32_prop, - sifive_u_machine_set_uint32_prop,NULL , &s->serial); +object_property_add_uint32_ptr (obj,"serial" , &s->serial, +OBJ_PROP_FLAG_READWRITE );object_property_set_description (obj,"serial" ,"Board serial number" ); }
Signature · 1 line
2.35.1
Re: [PATCH 2/2] hw/riscv/sifive_u: Resolve redundant property accessors
Quoted 4 lines · Bernhard Beschow
The QOM API already provides accessors for uint32 values, so reuse them.
Signed-off-by Bernhard Beschow <[email protected]>
Alistair
Quoted 53 lines
--- hw/riscv/sifive_u.c | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-)hw/riscv/sifive_u.c +4
-21@@ -713,36 +713,20 @@ static void sifive_u_machine_set_start_in_flash(Object *obj, bool value, Error * s->start_in_flash = value; } -static void sifive_u_machine_get_uint32_prop (Object *obj,Visitor *v, -const char *name,void *opaque, -Error **errp) -{ -visit_type_uint32 (v, name, (uint32_t *)opaque, errp); -} - -static void sifive_u_machine_set_uint32_prop (Object *obj,Visitor *v, -const char *name,void *opaque, -Error **errp) -{ -visit_type_uint32 (v, name, (uint32_t *)opaque, errp); -} -static void sifive_u_machine_instance_init (Object *obj) {SiFiveUState *s =RISCV_U_MACHINE (obj); s->start_in_flash = false; s->msel =0 ; -object_property_add (obj,"msel" ,"uint32" , - sifive_u_machine_get_uint32_prop, - sifive_u_machine_set_uint32_prop,NULL , &s->msel); +object_property_add_uint32_ptr (obj,"msel" , &s->msel, +OBJ_PROP_FLAG_READWRITE );object_property_set_description (obj,"msel" ,"Mode Select (MSEL[3:0]) pin state" ); s->serial =OTP_SERIAL ; -object_property_add (obj,"serial" ,"uint32" , - sifive_u_machine_get_uint32_prop, - sifive_u_machine_set_uint32_prop,NULL , &s->serial); +object_property_add_uint32_ptr (obj,"serial" , &s->serial, +OBJ_PROP_FLAG_READWRITE );object_property_set_description (obj,"serial" ,"Board serial number" ); } --2.35.1
Re: [PATCH 2/2] hw/riscv/sifive_u: Resolve redundant property accessors
In reply to Bernhard BeschowQuoted 6 lines · Bernhard Beschow
The QOM API already provides accessors for uint32 values, so reuse them.
Signed-off-by Bernhard Beschow <[email protected]>--- hw/riscv/sifive_u.c | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-)
PATCH 1/1 virtio/virtio-balloon: Prefer Object* over void* parameter
In reply to Bernhard Beschow*opaque is an alias to *obj. Using the ladder makes the code consistent with with other devices, e.g. accel/kvm/kvm-all and accel/tcg/tcg-all. It also makes the cast more typesafe.
--- hw/virtio/virtio-balloon.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
hw/virtio/virtio-balloon.c +5 -5
@@ -241,7 +241,7 @@ static void balloon_stats_get_all(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { Error *err = NULL; -VirtIOBalloon *s = opaque; +VirtIOBalloon *s =VIRTIO_BALLOON (obj);int i;if (!visit_start_struct (v, name,NULL ,0 , &err)) {
@@ -276,7 +276,7 @@ static void balloon_stats_get_poll_interval(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - VirtIOBalloon *s = opaque; + VirtIOBalloon *s = VIRTIO_BALLOON(obj);visit_type_int (v, name, &s->stats_poll_interval, errp); }
@@ -284,7 +284,7 @@ static void balloon_stats_set_poll_interval(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - VirtIOBalloon *s = opaque; + VirtIOBalloon *s = VIRTIO_BALLOON(obj);int64_t value;if (!visit_type_int (v, name, &value, errp)) {
@@ -1014,12 +1014,12 @@ static void virtio_balloon_instance_init(Object *obj) s->free_page_hint_notify.notify = virtio_balloon_free_page_hint_notify;object_property_add (obj,"guest-stats" ,"guest statistics" , - balloon_stats_get_all,NULL ,NULL , s); + balloon_stats_get_all,NULL ,NULL ,NULL );object_property_add (obj,"guest-stats-polling-interval" ,"int" , balloon_stats_get_poll_interval, balloon_stats_set_poll_interval, -NULL , s); +NULL ,NULL ); }static const VMStateDescription vmstate_virtio_balloon = {
Signature · 1 line
2.35.1
Re: [PATCH] virtio/virtio-balloon: Prefer Object* over void* parameter
Am 17. Februar 2022 22:53:50 UTC schrieb Bernhard Beschow <[email protected]>:
Quoted 45 lines
*opaque is an alias to *obj. Using the ladder makes the code consistent with with other devices, e.g. accel/kvm/kvm-all and accel/tcg/tcg-all. It also makes the cast more typesafe.
Signed-off-by Bernhard Beschow <[email protected]>---
hw/virtio/virtio-balloon.c| 10 +++++-----1 file changed, 5 insertions(+), 5 deletions(-)hw/virtio/virtio-balloon.c +3
-4@@ -241,7 +241,7 @@ static void balloon_stats_get_all(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { Error *err = NULL; -VirtIOBalloon *s = opaque; +VirtIOBalloon *s =VIRTIO_BALLOON (obj);int i;if (!visit_start_struct (v, name,NULL ,0 , &err)) {@@ -276,7 +276,7 @@ static void balloon_stats_get_poll_interval(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - VirtIOBalloon *s = opaque; + VirtIOBalloon *s = VIRTIO_BALLOON(obj);visit_type_int (v, name, &s->stats_poll_interval, errp); }@@ -284,7 +284,7 @@ static void balloon_stats_set_poll_interval(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - VirtIOBalloon *s = opaque; + VirtIOBalloon *s = VIRTIO_BALLOON(obj);int64_t value;if (!visit_type_int (v, name, &value, errp)) {@@ -1014,12 +1014,12 @@ static void virtio_balloon_instance_init(Object *obj) s->free_page_hint_notify.notify = virtio_balloon_free_page_hint_notify; object_property_add(obj, "guest-stats", "guest statistics", - balloon_stats_get_all,NULL ,NULL , s);
hw/virtio/virtio-balloon.c static void virtio_balloon_instance_init(Object *obj) · line 1025
Quoted 10 lines
hw/virtio/virtio-balloon.c +2
-1+ balloon_stats_get_all, NULL, NULL, NULL);object_property_add (obj,"guest-stats-polling-interval" ,"int" , balloon_stats_get_poll_interval, balloon_stats_set_poll_interval, -NULL , s); +NULL ,NULL ); }static const VMStateDescription vmstate_virtio_balloon = {
Ping
Re: [PATCH] virtio/virtio-balloon: Prefer Object* over void* parameter
Quoted 6 lines · Bernhard Beschow
Am 17. Februar 2022 22:53:50 UTC schrieb Bernhard Beschow <[email protected]>:
Quoted 5 lines
*opaque is an alias to *obj. Using the ladder makes the code consistent with with other devices, e.g. accel/kvm/kvm-all and accel/tcg/tcg-all. It also makes the cast more typesafe.
Signed-off-by Bernhard Beschow <[email protected]>
Send this kind of thing to qemu-trivial pls.
Quoted 52 lines
Quoted 40 lines
---
hw/virtio/virtio-balloon.c| 10 +++++-----1 file changed, 5 insertions(+), 5 deletions(-)hw/virtio/virtio-balloon.c +3
-4@@ -241,7 +241,7 @@ static void balloon_stats_get_all(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { Error *err = NULL; -VirtIOBalloon *s = opaque; +VirtIOBalloon *s =VIRTIO_BALLOON (obj);int i;if (!visit_start_struct (v, name,NULL ,0 , &err)) {@@ -276,7 +276,7 @@ static void balloon_stats_get_poll_interval(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - VirtIOBalloon *s = opaque; + VirtIOBalloon *s = VIRTIO_BALLOON(obj);visit_type_int (v, name, &s->stats_poll_interval, errp); }@@ -284,7 +284,7 @@ static void balloon_stats_set_poll_interval(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - VirtIOBalloon *s = opaque; + VirtIOBalloon *s = VIRTIO_BALLOON(obj);int64_t value;if (!visit_type_int (v, name, &value, errp)) {@@ -1014,12 +1014,12 @@ static void virtio_balloon_instance_init(Object *obj) s->free_page_hint_notify.notify = virtio_balloon_free_page_hint_notify; object_property_add(obj, "guest-stats", "guest statistics", - balloon_stats_get_all,NULL ,NULL , s);hw/virtio/virtio-balloon.c static void virtio_balloon_instance_init(Object *obj) · line 1025
Quoted 10 lines
hw/virtio/virtio-balloon.c +2
-1+ balloon_stats_get_all, NULL, NULL, NULL);object_property_add (obj,"guest-stats-polling-interval" ,"int" , balloon_stats_get_poll_interval, balloon_stats_set_poll_interval, -NULL , s); +NULL ,NULL ); }static const VMStateDescription vmstate_virtio_balloon = {Ping
Re: [PATCH] virtio/virtio-balloon: Prefer Object* over void* parameter
In reply to Bernhard BeschowQuoted 45 lines · Bernhard Beschow
*opaque is an alias to *obj. Using the ladder makes the code consistent with with other devices, e.g. accel/kvm/kvm-all and accel/tcg/tcg-all. It also makes the cast more typesafe.
Signed-off-by Bernhard Beschow <[email protected]>--- hw/virtio/virtio-balloon.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)hw/virtio/virtio-balloon.c +3
-4@@ -241,7 +241,7 @@ static void balloon_stats_get_all(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { Error *err = NULL; -VirtIOBalloon *s = opaque; +VirtIOBalloon *s =VIRTIO_BALLOON (obj);int i;if (!visit_start_struct (v, name,NULL ,0 , &err)) {@@ -276,7 +276,7 @@ static void balloon_stats_get_poll_interval(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - VirtIOBalloon *s = opaque; + VirtIOBalloon *s = VIRTIO_BALLOON(obj);visit_type_int (v, name, &s->stats_poll_interval, errp); }@@ -284,7 +284,7 @@ static void balloon_stats_set_poll_interval(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - VirtIOBalloon *s = opaque; + VirtIOBalloon *s = VIRTIO_BALLOON(obj);int64_t value;if (!visit_type_int (v, name, &value, errp)) {@@ -1014,12 +1014,12 @@ static void virtio_balloon_instance_init(Object *obj) s->free_page_hint_notify.notify = virtio_balloon_free_page_hint_notify; object_property_add(obj, "guest-stats", "guest statistics", - balloon_stats_get_all,NULL ,NULL , s);
hw/virtio/virtio-balloon.c static void virtio_balloon_instance_init(Object *obj) · line 1025
Quoted 10 lines
hw/virtio/virtio-balloon.c +2
-1+ balloon_stats_get_all, NULL, NULL, NULL);object_property_add (obj,"guest-stats-polling-interval" ,"int" , balloon_stats_get_poll_interval, balloon_stats_set_poll_interval, -NULL , s); +NULL ,NULL ); }static const VMStateDescription vmstate_virtio_balloon = {
LGTM
Signature · 3 lines
Thanks, David / dhildenb
Quoted 12 lines · Bernhard Beschow
The QOM API already provides appropriate accessors, so reuse them.
Testing done:
:$ make check
Ok: 569 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 178 Timeout: 0
Quoted 3 lines
Bernhard Beschow (2):
hw/vfio/pci-quirks: Resolve redundant property getters hw/riscv/sifive_u: Resolve redundant property accessors
Good cleanup.
You might want to play with Coccinelle spatch [*] to clean all uses:
$ git grep object_property_add\(.*uint hw/acpi/ich9.c:446: object_property_add(obj, ACPI_PM_PROP_GPE0_BLK, "uint32", hw/i386/sgx-epc.c:47: object_property_add(obj, SGX_EPC_SIZE_PROP, "uint64", sgx_epc_get_size, hw/intc/apic_common.c:462: object_property_add(obj, "id", "uint32", hw/mem/pc-dimm.c:175: object_property_add(obj, PC_DIMM_SIZE_PROP, "uint64", pc_dimm_get_size, hw/misc/aspeed_lpc.c:420: object_property_add(obj, "idr1", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:422: object_property_add(obj, "odr1", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:424: object_property_add(obj, "str1", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:426: object_property_add(obj, "idr2", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:428: object_property_add(obj, "odr2", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:430: object_property_add(obj, "str2", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:432: object_property_add(obj, "idr3", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:434: object_property_add(obj, "odr3", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:436: object_property_add(obj, "str3", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:438: object_property_add(obj, "idr4", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:440: object_property_add(obj, "odr4", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:442: object_property_add(obj, "str4", "uint32", aspeed_kcs_get_register_property, hw/misc/npcm7xx_mft.c:493: object_property_add(obj, "max_rpm[*]", "uint32", hw/nvme/ctrl.c:6856: object_property_add(obj, "smart_critical_warning", "uint8", hw/pci-host/q35.c:224: object_property_add(obj, PCI_HOST_PROP_PCI_HOLE_START, "uint32", hw/pci-host/q35.c:228: object_property_add(obj, PCI_HOST_PROP_PCI_HOLE_END, "uint32", hw/pci-host/q35.c:232: object_property_add(obj, PCI_HOST_PROP_PCI_HOLE64_START, "uint64", hw/pci-host/q35.c:236: object_property_add(obj, PCI_HOST_PROP_PCI_HOLE64_END, "uint64", hw/ppc/spapr_drc.c:584: object_property_add(obj, "index", "uint32", prop_get_index, hw/riscv/sifive_u.c:736: object_property_add(obj, "msel", "uint32", hw/riscv/sifive_u.c:743: object_property_add(obj, "serial", "uint32", hw/sensor/adm1272.c:497: object_property_add(obj, "vin", "uint16", hw/sensor/adm1272.c:501: object_property_add(obj, "vout", "uint16", hw/sensor/adm1272.c:505: object_property_add(obj, "iout", "uint16", hw/sensor/adm1272.c:509: object_property_add(obj, "pin", "uint16", hw/sensor/max34451.c:730: object_property_add(obj, "vout[*]", "uint16", hw/sensor/max34451.c:740: object_property_add(obj, "temperature[*]", "uint16", hw/vfio/pci-quirks.c:1621: object_property_add(OBJECT(vdev), "nvlink2-tgt", "uint64", hw/vfio/pci-quirks.c:1682: object_property_add(OBJECT(vdev), "nvlink2-tgt", "uint64", hw/vfio/pci-quirks.c:1688: object_property_add(OBJECT(vdev), "nvlink2-link-speed", "uint32", net/colo-compare.c:1390: object_property_add(obj, "compare_timeout", "uint64", net/colo-compare.c:1394: object_property_add(obj, "expired_scan_cycle", "uint32", net/colo-compare.c:1398: object_property_add(obj, "max_queue_size", "uint32", softmmu/memory.c:1262: object_property_add(OBJECT(mr), "priority", "uint32", softmmu/memory.c:1266: object_property_add(OBJECT(mr), "size", "uint64", target/arm/cpu64.c:863: object_property_add(obj, "sve-max-vq", "uint32", cpu_max_get_sve_max_vq, tests/unit/test-qdev-global-props.c:155: object_property_add(obj, "prop1", "uint32", prop1_accessor, prop1_accessor, tests/unit/test-qdev-global-props.c:157: object_property_add(obj, "prop2", "uint32", prop2_accessor, prop2_accessor,
Am 21. Februar 2022 22:28:00 UTC schrieb "Philippe Mathieu-Daudé" <[email protected]>:
Quoted 13 lines · Bernhard Beschow
Quoted 12 lines
The QOM API already provides appropriate accessors, so reuse them.
Testing done:
:$ make check
Ok: 569 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 178 Timeout: 0
Quoted 7 lines
Quoted 3 lines
Bernhard Beschow (2):
hw/vfio/pci-quirks: Resolve redundant property getters hw/riscv/sifive_u: Resolve redundant property accessorsGood cleanup.
You might want to play with Coccinelle spatch [*] to clean all uses:
Hi Philippe,
thanks for your review!
I've manually inspected most (all?) of them and found that the remaining setters were non-trivial, i.e. they do some extra stuff such as checking boundaries or invoking some extra actions. Do you have an idea how to deal with that?
Regards,
Bernhard
Quoted 79 lines
$ git grep object_property_add\(.*uint hw/acpi/ich9.c:446: object_property_add(obj, ACPI_PM_PROP_GPE0_BLK, "uint32", hw/i386/sgx-epc.c:47: object_property_add(obj, SGX_EPC_SIZE_PROP, "uint64", sgx_epc_get_size, hw/intc/apic_common.c:462: object_property_add(obj, "id", "uint32", hw/mem/pc-dimm.c:175: object_property_add(obj, PC_DIMM_SIZE_PROP, "uint64", pc_dimm_get_size, hw/misc/aspeed_lpc.c:420: object_property_add(obj, "idr1", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:422: object_property_add(obj, "odr1", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:424: object_property_add(obj, "str1", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:426: object_property_add(obj, "idr2", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:428: object_property_add(obj, "odr2", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:430: object_property_add(obj, "str2", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:432: object_property_add(obj, "idr3", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:434: object_property_add(obj, "odr3", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:436: object_property_add(obj, "str3", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:438: object_property_add(obj, "idr4", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:440: object_property_add(obj, "odr4", "uint32", aspeed_kcs_get_register_property, hw/misc/aspeed_lpc.c:442: object_property_add(obj, "str4", "uint32", aspeed_kcs_get_register_property, hw/misc/npcm7xx_mft.c:493: object_property_add(obj, "max_rpm[*]", "uint32", hw/nvme/ctrl.c:6856: object_property_add(obj, "smart_critical_warning", "uint8", hw/pci-host/q35.c:224: object_property_add(obj, PCI_HOST_PROP_PCI_HOLE_START, "uint32", hw/pci-host/q35.c:228: object_property_add(obj, PCI_HOST_PROP_PCI_HOLE_END, "uint32", hw/pci-host/q35.c:232: object_property_add(obj, PCI_HOST_PROP_PCI_HOLE64_START, "uint64", hw/pci-host/q35.c:236: object_property_add(obj, PCI_HOST_PROP_PCI_HOLE64_END, "uint64", hw/ppc/spapr_drc.c:584: object_property_add(obj, "index", "uint32", prop_get_index, hw/riscv/sifive_u.c:736: object_property_add(obj, "msel", "uint32", hw/riscv/sifive_u.c:743: object_property_add(obj, "serial", "uint32", hw/sensor/adm1272.c:497: object_property_add(obj, "vin", "uint16", hw/sensor/adm1272.c:501: object_property_add(obj, "vout", "uint16", hw/sensor/adm1272.c:505: object_property_add(obj, "iout", "uint16", hw/sensor/adm1272.c:509: object_property_add(obj, "pin", "uint16", hw/sensor/max34451.c:730: object_property_add(obj, "vout[*]", "uint16", hw/sensor/max34451.c:740: object_property_add(obj, "temperature[*]", "uint16", hw/vfio/pci-quirks.c:1621: object_property_add(OBJECT(vdev), "nvlink2-tgt", "uint64", hw/vfio/pci-quirks.c:1682: object_property_add(OBJECT(vdev), "nvlink2-tgt", "uint64", hw/vfio/pci-quirks.c:1688: object_property_add(OBJECT(vdev), "nvlink2-link-speed", "uint32", net/colo-compare.c:1390: object_property_add(obj, "compare_timeout", "uint64", net/colo-compare.c:1394: object_property_add(obj, "expired_scan_cycle", "uint32", net/colo-compare.c:1398: object_property_add(obj, "max_queue_size", "uint32", softmmu/memory.c:1262: object_property_add(OBJECT(mr), "priority", "uint32", softmmu/memory.c:1266: object_property_add(OBJECT(mr), "size", "uint64", target/arm/cpu64.c:863: object_property_add(obj, "sve-max-vq", "uint32", cpu_max_get_sve_max_vq, tests/unit/test-qdev-global-props.c:155: object_property_add(obj, "prop1", "uint32", prop1_accessor, prop1_accessor, tests/unit/test-qdev-global-props.c:157: object_property_add(obj, "prop2", "uint32", prop2_accessor, prop2_accessor,
Am 17. Februar 2022 22:53:48 UTC schrieb Bernhard Beschow <[email protected]>:
Quoted 12 lines
The QOM API already provides appropriate accessors, so reuse them.
Testing done:
:$ make check
Ok: 569 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 178 Timeout: 0
Quoted 8 lines
Bernhard Beschow (2):
hw/vfio/pci-quirks: Resolve redundant property getters hw/riscv/sifive_u: Resolve redundant property accessors
hw/riscv/sifive_u.c| 24 ++++--------------------hw/vfio/pci-quirks.c| 34 +++++++++-------------------------2 files changed, 13 insertions(+), 45 deletions(-)
Hi,
all 2 patches in this series are reviewed. What's missing?
Note: The lonely [PATCH] slipped underneath this series. Is this a problem?It was supposed to be submitted toplevel but git send-email doesn't seem to support sending multiple independent series at once.
Best regards,
Bernhard