DSB enablement.
Subsystems (5)
cover DSB enablement.
Display State Buffer (DSB) is hardware capability which allows driver to batch submit HW programming.
As part of initial enablement common api created which currently used to program gamma lut proramming.
Going forwad DSB support can be added for HDR and flip related operation.
Few changes of this patch series is not tested, sending version 1 for design review, will be testing in parallel.
HSDES: 1209978241
BSpec: 32020
Animesh Manna (15):
drm/i915/dsb: feature flag added for display state buffer. drm/i915/dsb: DSB context creation.
drm/i915/dsb: single register write function for DSB. drm/i915/dsb: Added enum for reg write capability. drm/i915/dsb: Indexed register write function for DSB. drm/i915/dsb: Update i915_write to call dsb-write. drm/i915/dsb: Register definition of DSB registers. drm/i915/dsb: Check DSB engine status. drm/i915/dsb: functions to enable/disable DSB engine. drm/i915/dsb: function to trigger workload execution of DSB. drm/i915/dsb: function to destroy DSB context. drm/i915/dsb: Early prepare of dsb context. drm/i915/dsb: Cleanup of DSB context. drm/i915/dsb: Documentation for DSB.
drm/i915/dsb: Enable gamma lut programming using DSB.
Documentation/gpu/i915.rst | 9 + drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_color.c | 4 + drivers/gpu/drm/i915/display/intel_display.c | 34 +++ drivers/gpu/drm/i915/i915_drv.h | 9 +- drivers/gpu/drm/i915/i915_reg.h | 53 +++- drivers/gpu/drm/i915/intel_device_info.h | 1 + drivers/gpu/drm/i915/intel_drv.h | 6 + drivers/gpu/drm/i915/intel_dsb.c | 305 +++++++++++++++++++ drivers/gpu/drm/i915/intel_dsb.h | 48 +++ 10 files changed, 460 insertions(+), 10 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_dsb.c create mode 100644 drivers/gpu/drm/i915/intel_dsb.h
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/15 drm/i915/dsb: feature flag added for display state buffer.
From gen12 onwards Display State Buffer(DSB) is hardware capability added which allows driver to batch submit display HW programming. Feature flag has_dsb added to identify the driver/platform support at runtime.
--- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/intel_device_info.h | 1 + 2 files changed, 3 insertions(+)
drivers/gpu/drm/i915/i915_drv.h +2 -0
@@ -2287,6 +2287,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define HAS_IPC (dev_priv) (INTEL_INFO(dev_priv)->display.has_ipc) +#define HAS_DSB (dev_priv) (INTEL_INFO(dev_priv)->display.has_dsb) +/* * For now, anything with a GuC requires uCode loading, and then supports * command submission once loaded. But these are logically independent
drivers/gpu/drm/i915/intel_device_info.h +1 -0
@@ -132,6 +132,7 @@ enum intel_ppgtt_type {func (has_csr); \func (has_ddi); \func (has_dp_mst); \ +func (has_dsb); \func (has_fbc); \func (has_gmch); \func (has_hotplug); \
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/15 drm/i915/dsb: DSB context creation.
In reply to Animesh MannaThe function will internally get the gem buffer from global GTT which is mapped in cpu domain to feed the data + opcode for DSB engine.
--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_drv.h | 4 ++ drivers/gpu/drm/i915/intel_dsb.c | 65 ++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_dsb.h | 31 +++++++++++++++ 5 files changed, 102 insertions(+) create mode 100644 drivers/gpu/drm/i915/intel_dsb.c create mode 100644 drivers/gpu/drm/i915/intel_dsb.h
drivers/gpu/drm/i915/Makefile +1 -0
@@ -49,6 +49,7 @@ i915-y += i915_drv.o \ i915_sysfs.o \ intel_csr.o \ intel_device_info.o \ + intel_dsb.o \ intel_pm.o \ intel_runtime_pm.o \ intel_sideband.o \
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -76,6 +76,7 @@#include "gt/intel_workarounds.h" #include "intel_device_info.h" +#include "intel_dsb.h" #include "intel_runtime_pm.h" #include "intel_uc.h" #include "intel_uncore.h"
drivers/gpu/drm/i915/intel_drv.h +4 -0
@@ -988,6 +988,10 @@ struct intel_crtc {/* scalers available on this crtc */ int num_scalers; + +/* per pipe DSB related info */ +struct intel_dsb dsb[MAX_DSB_PER_PIPE ]; +int dsb_in_use; };struct intel_plane {
drivers/gpu/drm/i915/intel_dsb.c new file +65 -0
65 lines not on this page · raw message
drivers/gpu/drm/i915/intel_dsb.h new file +31 -0
@@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: MIT +* +* Copyright © 2019 Intel Corporation +*/ + +#ifndef _INTEL_DSB_H +#define _INTEL_DSB_H + +struct intel_crtc ; +struct i915_vma ; + +enum dsb_id { +INVALID_DSB =-1 , +DSB1 , +DSB2 , +DSB3 , +MAX_DSB_PER_PIPE +}; + +struct intel_dsb { +struct intel_crtc *crtc; +enum dsb_id id; +u32 *cmd_buf; +u32 cmd_buf_head; +struct i915_vma *vma; +}; + +struct intel_dsb * +intel_dsb_get (struct intel_crtc *crtc); + +#endif
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/15 drm/i915/dsb: single register write function for DSB.
In reply to Animesh MannaDSB support single register write through opcode 0x1. Generic api created which accumulate all single register write in a batch buffer and once DSB is triggered, it will program all the registers at the same time.
--- drivers/gpu/drm/i915/intel_dsb.c | 36 ++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_dsb.h | 9 ++++++++ 2 files changed, 45 insertions(+)
drivers/gpu/drm/i915/intel_dsb.c +36 -0
@@ -8,6 +8,20 @@#define DSB_BUF_SIZE (2 * PAGE_SIZE) +/* DSB opcodes. */ +#define DSB_OPCODE_SHIFT 24 +#define DSB_OPCODE_NOOP 0x0 +#define DSB_OPCODE_MMIO_WRITE 0x1 +#define DSB_OPCODE_WAIT_FOR_US 0x2 +#define DSB_OPCODE_WAIT_FOR_LINES 0x3 +#define DSB_OPCODE_WAIT_FOR_VBLANK 0x4 +#define DSB_OPCODE_WAIT_FOR_SL_IN 0x5 +#define DSB_OPCODE_WAIT_FOR_SL_OUT 0x6 +#define DSB_OPCODE_GENERATE_INT 0x7 +#define DSB_OPCODE_INDEXED_WRITE 0x9 +#define DSB_OPCODE_POLL 0xA +#define DSB_BYTE_EN (0xf << 20) +struct intel_dsb *intel_dsb_get (struct intel_crtc *crtc) {
@@ -63,3 +77,25 @@ intel_dsb_get(struct intel_crtc *crtc)intel_runtime_pm_put (&i915->runtime_pm, wakeref);return dsb; } + +void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val) +{ +struct intel_crtc *crtc = dsb->crtc; +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +u32 *buf = dsb->cmd_buf; + +if (!buf) { +I915_WRITE (reg, val); +return ; + } + +if (WARN_ON (dsb->free_pos >=DSB_BUF_SIZE )) { +DRM_DEBUG_KMS ("DSB buffer overflow.\n" ); +return ; + } + + buf[dsb->free_pos++] = val; + buf[dsb->free_pos++] = (DSB_OPCODE_MMIO_WRITE << +DSB_OPCODE_SHIFT ) |DSB_BYTE_EN | +i915_mmio_reg_offset (reg); +}
drivers/gpu/drm/i915/intel_dsb.h +9 -0
@@ -6,6 +6,8 @@#ifndef _INTEL_DSB_H#define _INTEL_DSB_H +#include "i915_reg.h" +struct intel_crtc ;struct i915_vma ;
@@ -23,9 +25,16 @@ struct intel_dsb {u32 *cmd_buf;u32 cmd_buf_head;struct i915_vma *vma; + +/* +* free_pos will point the first free entry position +* and help in calculating cmd_buf_tail. +*/ + int free_pos; };struct intel_dsb *intel_dsb_get (struct intel_crtc *crtc); +void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val);#endif
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/15 drm/i915/dsb: Added enum for reg write capability.
In reply to Animesh MannaDSB can access specific register, To identify those register which can be written through DSB, enum reg_write_cap is added to hold the capability.
--- drivers/gpu/drm/i915/i915_reg.h | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_reg.h +12 -1
@@ -178,11 +178,22 @@*/ #define REG_FIELD_GET (__mask, __val) ((u32)FIELD_GET(__mask, __val)) +/* +* Added enum to hold the capability for those registers which can be written +* through DSB. +*/ +enum reg_write_cap { +MMIO_WRITE , +DSB_WRITE , +DSB_INDEX_WRITE +}; +typedef struct {u32 reg; +enum reg_write_cap cap; }i915_reg_t ; -#define _MMIO (r) ((const i915_reg_t){ .reg = (r) }) +#define _MMIO (r, ...) ((const i915_reg_t){ .reg = (r), ##__VA_ARGS__})#define INVALID_MMIO_REG _MMIO(0)
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/15 drm/i915/dsb: Indexed register write function for DSB.
In reply to Animesh MannaDSB can program large set of data through indexed register write (opcode 0x9) in one shot. Will be using for bulk register programming e.g. gamma lut programming, HDR meta data programming.
--- drivers/gpu/drm/i915/intel_dsb.c | 42 ++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_dsb.h | 6 +++++ 2 files changed, 48 insertions(+)
drivers/gpu/drm/i915/intel_dsb.c +42 -0
@@ -21,6 +21,7 @@#define DSB_OPCODE_INDEXED_WRITE 0x9#define DSB_OPCODE_POLL 0xA#define DSB_BYTE_EN (0xf << 20) +#define DSB_REG_VALUE_MASK 0xfffffstruct intel_dsb *intel_dsb_get (struct intel_crtc *crtc)
@@ -78,6 +79,42 @@ intel_dsb_get(struct intel_crtc *crtc)return dsb; } +static void intel_dsb_indexed_reg_write (struct intel_dsb *dsb,i915_reg_t reg, +u32 val) +{ +u32 *buf = dsb->cmd_buf; +u32 reg_val; + + reg_val = buf[dsb->ins_start_offset +1 ] &DSB_REG_VALUE_MASK ; +if (reg_val !=i915_mmio_reg_offset (reg)) { +/* Every instruction should be 8 byte aligned. */ +if (dsb->free_pos &0x1 ) + dsb->free_pos++; + +/* Update the size. */ + dsb->ins_start_offset = dsb->free_pos; + buf[dsb->free_pos++] =1 ; + +/* Update the opcode and reg. */ + buf[dsb->free_pos++] = (DSB_OPCODE_INDEXED_WRITE << +DSB_OPCODE_SHIFT ) | +i915_mmio_reg_offset (reg); + +/* Update the value. */ + buf[dsb->free_pos++] = val; + }else { +/* Update the new value. */ + buf[dsb->free_pos++] = val; + +/* Update the size. */ + buf[dsb->ins_start_offset]++; + } + +/* if number of data words is odd, then the last dword should be 0.*/ +if (dsb->free_pos &0x1 ) + buf[dsb->free_pos] =0 ; +} +void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val) {struct intel_crtc *crtc = dsb->crtc;
@@ -94,6 +131,11 @@ void intel_dsb_reg_write(struct intel_dsb *dsb, i915_reg_t reg, u32 val)return ; } +if (reg.cap ==DSB_INDEX_WRITE ) { +intel_dsb_indexed_reg_write (dsb, reg, val); +return ; + } + buf[dsb->free_pos++] = val; buf[dsb->free_pos++] = (DSB_OPCODE_MMIO_WRITE << DSB_OPCODE_SHIFT) | DSB_BYTE_EN |
drivers/gpu/drm/i915/intel_dsb.h +6 -0
@@ -31,6 +31,12 @@ struct intel_dsb {* and help in calculating cmd_buf_tail. */ int free_pos; + +/* +* ins_start_offset will help to store start address +* of the dsb instuction of auto-increment register. +*/ +u32 ins_start_offset; }; struct intel_dsb *
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 6/15 drm/i915/dsb: Update i915_write to call dsb-write.
In reply to Animesh MannaExisting mmio-reg-write need intel_uncore handle which is part of dev_priv structure and the same design is followed by adding dsb handle in dev_priv for programming registers through DSB.
I915_WRITE is modified to check for register capability and call dsb-reg-write based on its capability.
No changes in I915_READ definition as DSB do not have support to read any register.
--- drivers/gpu/drm/i915/i915_drv.h | 6 +++++- drivers/gpu/drm/i915/intel_dsb.c | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +5 -1
@@ -1880,6 +1880,8 @@ struct drm_i915_private {/* Mutex to protect the above hdcp component related values. */ struct mutex hdcp_comp_mutex; +struct intel_dsb *dsb; +/* * NOTE: This is the dri1/ums dungeon, don't add stuff here. Your patch * will be rejected. Instead look for a better place.
@@ -2716,7 +2718,9 @@ extern void intel_display_print_error_state(struct drm_i915_error_state_buf *e, intel_uncore_##op__(&(dev_priv__)->uncore, __VA_ARGS__)#define I915_READ (reg__) __I915_REG_OP(read, dev_priv, (reg__)) -#define I915_WRITE (reg__, val__) __I915_REG_OP(write, dev_priv, (reg__), (val__)) +#define I915_WRITE (reg__, val__) \ + (reg__.cap) ? intel_dsb_reg_write(dev_priv->dsb, (reg__), (val__)) : \ + __I915_REG_OP(write, dev_priv, (reg__), (val__))#define POSTING_READ (reg__) __I915_REG_OP(posting_read, dev_priv, (reg__))
drivers/gpu/drm/i915/intel_dsb.c +1 -1
@@ -122,7 +122,7 @@ void intel_dsb_reg_write(struct intel_dsb *dsb, i915_reg_t reg, u32 val)u32 *buf = dsb->cmd_buf;if (!buf) { -I915_WRITE (reg, val); +intel_uncore_write (&(dev_priv)->uncore, reg, val);return ; }
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 7/15 drm/i915/dsb: Register definition of DSB registers.
In reply to Animesh MannaAdded key register definitions of DSB.
dsb-ctrl register is required to enable dsb-engine.
head-ptr register hold the head of buffer address from where the execution will start.
Programming tail-ptr register is a trigger point to start execution.
--- drivers/gpu/drm/i915/i915_reg.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +15 -0
@@ -11485,4 +11485,19 @@ enum skl_power_gate {#define PORT_TX_DFLEXDPCSSS _MMIO(FIA1_BASE + 0x00894)#define DP_PHY_MODE_STATUS_NOT_SAFE (tc_port) (1 << (tc_port)) +/* This register controls the Display State Buffer (DSB) engines. */ +#define _DSBSL_INSTANCE_BASE 0x70B00 +#define DSBSL_INSTANCE (pipe, id) (_DSBSL_INSTANCE_BASE + \ + (pipe) * 0x1000 + (id) * 100) +#define DSB_HEAD_PTR (pipe, id) _MMIO(DSBSL_INSTANCE(pipe, id) + 0x0) +#define DSB_TAIL_PTR (pipe, id) _MMIO(DSBSL_INSTANCE(pipe, id) + 0x4) +#define DSB_CTRL (pipe, id) _MMIO(DSBSL_INSTANCE(pipe, id) + 0x8) +#define DSB_ENABLE (1 << 31) +#define DSB_BUFFER_REITERATE (1 << 29) +#define DSB_WAIT_FOR_VBLANK (1 << 28) +#define DSB_WAIT_FOR_LINE_IN_RANGE (1 << 27) +#define DSB_HALT (1 << 16) +#define DSB_NON_POSTED_ENABLE (1 << 8) +#define DSB_STATUS (1 << 0) +#endif /* _I915_REG_H_ */
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 8/15 drm/i915/dsb: Check DSB engine status.
In reply to Animesh MannaAs per bspec check for DSB status before programming any of its register. Inline function added to check the dsb status.
--- drivers/gpu/drm/i915/intel_dsb.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/gpu/drm/i915/intel_dsb.c +9 -0
@@ -23,6 +23,15 @@#define DSB_BYTE_EN (0xf << 20)#define DSB_REG_VALUE_MASK 0xfffff +static inline bool is_dsb_busy (struct intel_dsb *dsb) +{ +struct intel_crtc *crtc = dsb->crtc; +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +enum pipe pipe = crtc->pipe; + +return DSB_STATUS &I915_READ (DSB_CTRL (pipe, dsb->id)); +} +struct intel_dsb *intel_dsb_get (struct intel_crtc *crtc) {
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 9/15 drm/i915/dsb: functions to enable/disable DSB engine.
In reply to Animesh MannaDSB will be used for performance improvement for some special scenario. DSB engine will be enabled based on need and after completion of its work will be disabled. Api added for enable/disable operation by using DSB_CTRL register.
--- drivers/gpu/drm/i915/intel_dsb.c | 40 ++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+)
drivers/gpu/drm/i915/intel_dsb.c +40 -0
@@ -32,6 +32,46 @@ static inline bool is_dsb_busy(struct intel_dsb *dsb)return DSB_STATUS &I915_READ (DSB_CTRL (pipe, dsb->id)); } +static bool intel_dsb_enable_engine (struct intel_dsb *dsb) +{ +struct intel_crtc *crtc = dsb->crtc; +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +enum pipe pipe = crtc->pipe; +u32 dsb_ctrl; + + dsb_ctrl =I915_READ (DSB_CTRL (pipe, dsb->id)); + +if (DSB_STATUS & dsb_ctrl) { +DRM_DEBUG_KMS ("DSB engine is busy.\n" ); +return false; + } + + dsb_ctrl |=DSB_ENABLE ; +I915_WRITE (DSB_CTRL (pipe, dsb->id), dsb_ctrl); + +return true; +} + +static bool intel_dsb_disable_engine (struct intel_dsb *dsb) +{ +struct intel_crtc *crtc = dsb->crtc; +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +enum pipe pipe = crtc->pipe; +u32 dsb_ctrl; + + dsb_ctrl =I915_READ (DSB_CTRL (pipe, dsb->id)); + +if (DSB_STATUS & dsb_ctrl) { +DRM_DEBUG_KMS ("DSB engine is busy.\n" ); +return false; + } + + dsb_ctrl &= ~DSB_ENABLE ; +I915_WRITE (DSB_CTRL (pipe, dsb->id), dsb_ctrl); + +return true; +} +struct intel_dsb *intel_dsb_get (struct intel_crtc *crtc) {
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 10/15 drm/i915/dsb: function to trigger workload execution of DSB.
In reply to Animesh MannaBatch buffer will be created through dsb-reg-write function which can have single/multiple request based on usecase and once the buffer is ready commit function will trigger the execution of the batch buffer. All the registers will be updated simultaneously.
--- drivers/gpu/drm/i915/intel_dsb.c | 43 ++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_dsb.h | 1 + 2 files changed, 44 insertions(+)
drivers/gpu/drm/i915/intel_dsb.c +43 -0
@@ -190,3 +190,46 @@ void intel_dsb_reg_write(struct intel_dsb *dsb, i915_reg_t reg, u32 val) DSB_OPCODE_SHIFT) | DSB_BYTE_EN |i915_mmio_reg_offset (reg); } + +void intel_dsb_commit (struct intel_dsb *dsb) +{ +struct intel_crtc *crtc = dsb->crtc; +struct drm_device *dev = crtc->base.dev; +struct drm_i915_private *dev_priv =to_i915 (dev); +enum pipe pipe = crtc->pipe; +u32 cmd_buf_tail, cmd_buf_size; + +if (!dsb->free_pos) +return ; + +if (!intel_dsb_enable_engine (dsb)) + goto reset; + +if (is_dsb_busy (dsb)) { +DRM_DEBUG_KMS ("HEAD_PTR write failed - dsb engine is busy.\n" ); + goto reset; + } +I915_WRITE (DSB_HEAD_PTR (pipe, dsb->id), dsb->cmd_buf_head); + + cmd_buf_size = dsb->free_pos *4 ; + cmd_buf_tail =round_up ((dsb->cmd_buf_head + cmd_buf_size), +CACHELINE_BYTES ); + +if (is_dsb_busy (dsb)) { +DRM_DEBUG_KMS ("TAIL_PTR write failed - dsb engine is busy.\n" ); + goto reset; + } +DRM_DEBUG_KMS ("DSB execution started - buf-size %u, head 0x%x," +"tail 0x%x\n" , cmd_buf_size, dsb->cmd_buf_head, + cmd_buf_tail); +I915_WRITE (DSB_TAIL_PTR (pipe, dsb->id), cmd_buf_tail); +if (wait_for (!is_dsb_busy (dsb),1 )) { +DRM_ERROR ("Timed out waiting for DSB workload completion.\n" ); + goto reset; + } + +reset: +memset (dsb->cmd_buf,0 ,DSB_BUF_SIZE ); + dsb->free_pos =0 ; +intel_dsb_disable_engine (dsb); +}
drivers/gpu/drm/i915/intel_dsb.h +1 -0
@@ -42,5 +42,6 @@ struct intel_dsb {struct intel_dsb *intel_dsb_get (struct intel_crtc *crtc);void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val); +void intel_dsb_commit (struct intel_dsb *dsb);#endif
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 11/15 drm/i915/dsb: function to destroy DSB context.
In reply to Animesh MannaFreed the gem object after completion of dsb workload.
--- drivers/gpu/drm/i915/intel_dsb.c | 16 ++++++++++++++++ drivers/gpu/drm/i915/intel_dsb.h | 1 + 2 files changed, 17 insertions(+)
drivers/gpu/drm/i915/intel_dsb.c +16 -0
@@ -233,3 +233,19 @@ void intel_dsb_commit(struct intel_dsb *dsb) dsb->free_pos =0 ;intel_dsb_disable_engine (dsb); } + +void intel_dsb_put (struct intel_dsb *dsb) +{ +struct intel_crtc *crtc = dsb->crtc; +struct drm_i915_private *i915 =to_i915 (crtc->base.dev); +struct i915_vma *vma = dsb->vma; + +if (dsb->cmd_buf) { +mutex_lock (&i915->drm.struct_mutex); + crtc->dsb_in_use--; +i915_gem_object_unpin_map (vma->obj); +i915_vma_unpin_and_release (&vma,0 ); + dsb->cmd_buf =NULL ; +mutex_unlock (&i915->drm.struct_mutex); + } +}
drivers/gpu/drm/i915/intel_dsb.h +1 -0
@@ -43,5 +43,6 @@ struct intel_dsb * intel_dsb_get(struct intel_crtc *crtc);void intel_dsb_reg_write (struct intel_dsb *dsb,i915_reg_t reg,u32 val);void intel_dsb_commit (struct intel_dsb *dsb); +void intel_dsb_put (struct intel_dsb *dsb);#endif
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 12/15 drm/i915/dsb: Early prepare of dsb context.
In reply to Animesh MannaThe dsb get call added part of the prepare so that we don't have things that can fail in the commit proper.
The allocated dsb-context will be tracked under intel_crtc_state instead of intel_crtc per atomic-commit.
--- drivers/gpu/drm/i915/display/intel_display.c | 17 +++++++++++++++++ drivers/gpu/drm/i915/intel_drv.h | 2 ++ 2 files changed, 19 insertions(+)
drivers/gpu/drm/i915/display/intel_display.c +17 -0
@@ -13708,6 +13708,22 @@ static void skl_update_crtcs(struct drm_atomic_state *state)icl_dbuf_slices_update (dev_priv, required_slices); } +static void intel_prepare_dsb (struct drm_atomic_state *state) +{ +struct drm_crtc_state *crtc_state; +struct drm_crtc *crtc; +struct intel_crtc_state *config; +int i; + +if (!state) +return ; + +for_each_new_crtc_in_state (state, crtc, crtc_state, i) { + config =to_intel_crtc_state (crtc_state); + config->dsb =intel_dsb_get (to_intel_crtc (crtc)); + } +} +static void intel_atomic_helper_free_state (struct drm_i915_private *dev_priv) {struct intel_atomic_state *state, *next;
@@ -14074,6 +14090,7 @@ static int intel_atomic_commit(struct drm_device *dev, dev_priv->wm.distrust_bios_wm = false;intel_shared_dpll_swap_state (state);intel_atomic_track_fbs (state); +intel_prepare_dsb (state);if (intel_state->modeset) { memcpy(dev_priv->min_cdclk, intel_state->min_cdclk,
drivers/gpu/drm/i915/intel_drv.h +2 -0
@@ -946,6 +946,8 @@ struct intel_crtc_state {/* Forward Error correction State */ bool fec_enable; + +struct intel_dsb *dsb; };struct intel_crtc {
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 13/15 drm/i915/dsb: Cleanup of DSB context.
In reply to Animesh MannaDSB context destroyed using intel_dsb_put() in cleanup function.
--- drivers/gpu/drm/i915/display/intel_display.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
drivers/gpu/drm/i915/display/intel_display.c +17 -0
@@ -13724,6 +13724,22 @@ static void intel_prepare_dsb(struct drm_atomic_state *state) } } +static void intel_cleanup_dsb (struct drm_atomic_state *state) +{ +struct drm_crtc_state *crtc_state; +struct drm_crtc *crtc; +struct intel_crtc_state *config; +int i; + +if (!state) +return ; + +for_each_new_crtc_in_state (state, crtc, crtc_state, i) { + config =to_intel_crtc_state (crtc_state); +intel_dsb_put (config->dsb); + } +} +static void intel_atomic_helper_free_state (struct drm_i915_private *dev_priv) {struct intel_atomic_state *state, *next;
@@ -13772,6 +13788,7 @@ static void intel_atomic_cleanup_work(struct work_struct *work) container_of(work, struct drm_atomic_state, commit_work);struct drm_i915_private *i915 =to_i915 (state->dev); +intel_cleanup_dsb (state);drm_atomic_helper_cleanup_planes (&i915->drm, state);drm_atomic_helper_commit_cleanup_done (state);drm_atomic_state_put (state);
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 14/15 drm/i915/dsb: Documentation for DSB.
In reply to Animesh MannaAdded docbook info regarding Display State Buffer(DSB) which is added from gen12 onwards to batch submit display HW programming.
--- Documentation/gpu/i915.rst | 9 ++++++ drivers/gpu/drm/i915/intel_dsb.c | 54 ++++++++++++++++++++++++++++++++ 2 files changed, 63 insertions(+)
Documentation/gpu/i915.rst +9 -0
@@ -249,6 +249,15 @@ Display PLLs .. kernel-doc:: drivers/gpu/drm/i915/display/intel_dpll_mgr.h :internal: +Display State Buffer +-------------------- + +.. kernel-doc:: drivers/gpu/drm/i915/intel_dsb.c + :doc: DSB + +.. kernel-doc:: drivers/gpu/drm/i915/intel_dsb.c + :internal: + Memory Management and Command Submission ========================================
drivers/gpu/drm/i915/intel_dsb.c +54 -0
84 lines not on this page · raw message
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 15/15 drm/i915/dsb: Enable gamma lut programming using DSB.
In reply to Animesh MannaGamma lut programming can be programmed using DSB where bulk register programming can be done using indexed register write which takes number of data and the mmio offset to be written.
--- drivers/gpu/drm/i915/display/intel_color.c | 4 ++++ drivers/gpu/drm/i915/i915_reg.h | 25 +++++++++++++++------- 2 files changed, 21 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/display/intel_color.c +4 -0
@@ -882,7 +882,9 @@ static void icl_load_luts(const struct intel_crtc_state *crtc_state) {const struct drm_property_blob *gamma_lut = crtc_state->base.gamma_lut;struct intel_crtc *crtc =to_intel_crtc (crtc_state->base.crtc); +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); + dev_priv->dsb = crtc_state->dsb;if (crtc_state->base.degamma_lut)glk_load_degamma_lut (crtc_state);
@@ -900,6 +902,8 @@ static void icl_load_luts(const struct intel_crtc_state *crtc_state)bdw_load_lut_10 (crtc, gamma_lut,PAL_PREC_INDEX_VALUE (0 ));ivb_load_lut_ext_max (crtc); } + +intel_dsb_commit (dev_priv->dsb); }static u32 chv_cgm_degamma_ldw (const struct drm_color_lut *color)
drivers/gpu/drm/i915/i915_reg.h +17 -8
@@ -242,7 +242,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define _PORT (port, a, b) _PICK_EVEN(port, a, b)#define _PLL (pll, a, b) _PICK_EVEN(pll, a, b) -#define _MMIO_PIPE (pipe, a, b) _MMIO(_PIPE(pipe, a, b)) +#define _MMIO_PIPE (pipe, a, b, ...) _MMIO(_PIPE(pipe, a, b), ##__VA_ARGS__)#define _MMIO_PLANE (plane, a, b) _MMIO(_PLANE(plane, a, b))#define _MMIO_TRANS (tran, a, b) _MMIO(_TRANS(tran, a, b))#define _MMIO_PORT (port, a, b) _MMIO(_PORT(port, a, b))
@@ -10185,11 +10185,18 @@ enum skl_power_gate {#define _PAL_PREC_EXT2_GC_MAX_B 0x4AC30#define _PAL_PREC_EXT2_GC_MAX_C 0x4B430 -#define PREC_PAL_INDEX (pipe) _MMIO_PIPE(pipe, _PAL_PREC_INDEX_A, _PAL_PREC_INDEX_B) -#define PREC_PAL_DATA (pipe) _MMIO_PIPE(pipe, _PAL_PREC_DATA_A, _PAL_PREC_DATA_B) -#define PREC_PAL_GC_MAX (pipe, i) _MMIO(_PIPE(pipe, _PAL_PREC_GC_MAX_A, _PAL_PREC_GC_MAX_B) + (i) * 4) -#define PREC_PAL_EXT_GC_MAX (pipe, i) _MMIO(_PIPE(pipe, _PAL_PREC_EXT_GC_MAX_A, _PAL_PREC_EXT_GC_MAX_B) + (i) * 4) -#define PREC_PAL_EXT2_GC_MAX (pipe, i) _MMIO(_PIPE(pipe, _PAL_PREC_EXT2_GC_MAX_A, _PAL_PREC_EXT2_GC_MAX_B) + (i) * 4) +#define PREC_PAL_INDEX (pipe) _MMIO_PIPE(pipe, _PAL_PREC_INDEX_A, \ + _PAL_PREC_INDEX_B, \ + DSB_WRITE) +#define PREC_PAL_DATA (pipe) _MMIO_PIPE(pipe, _PAL_PREC_DATA_A, \ + _PAL_PREC_DATA_B, \ + DSB_INDEX_WRITE) +#define PREC_PAL_GC_MAX (pipe, i) _MMIO(_PIPE(pipe, _PAL_PREC_GC_MAX_A, _PAL_PREC_GC_MAX_B) + (i) * 4, \ + DSB_WRITE) +#define PREC_PAL_EXT_GC_MAX (pipe, i) _MMIO(_PIPE(pipe, _PAL_PREC_EXT_GC_MAX_A, _PAL_PREC_EXT_GC_MAX_B) + (i) * 4, \ + DSB_WRITE) +#define PREC_PAL_EXT2_GC_MAX (pipe, i) _MMIO(_PIPE(pipe, _PAL_PREC_EXT2_GC_MAX_A, _PAL_PREC_EXT2_GC_MAX_B) + (i) * 4, \ + DSB_WRITE)#define _PRE_CSC_GAMC_INDEX_A 0x4A484#define _PRE_CSC_GAMC_INDEX_B 0x4AC84
@@ -10213,10 +10220,12 @@ enum skl_power_gate {#define PREC_PAL_MULTI_SEG_INDEX (pipe) _MMIO_PIPE(pipe, \ _PAL_PREC_MULTI_SEG_INDEX_A, \ - _PAL_PREC_MULTI_SEG_INDEX_B) + _PAL_PREC_MULTI_SEG_INDEX_B, \ + DSB_WRITE)#define PREC_PAL_MULTI_SEG_DATA (pipe) _MMIO_PIPE(pipe, \ _PAL_PREC_MULTI_SEG_DATA_A, \ - _PAL_PREC_MULTI_SEG_DATA_B) + _PAL_PREC_MULTI_SEG_DATA_B, \ + DSB_INDEX_WRITE)/* pipe CSC & degamma/gamma LUTs on CHV */ #define _CGM_PIPE_A_CSC_COEFF01 (VLV_DISPLAY_BASE + 0x67900)
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for DSB enablement.
In reply to Animesh Manna== Series Details ==
== Series Details ==
Series: DSB enablement.
URL : https://patchwork.freedesktop.org/series/63013/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip d1b2b4d2b22b drm/i915/dsb: feature flag added for display state buffer. f910e626c852 drm/i915/dsb: DSB context creation. -:55: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #55: new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 120 lines checked208d2a783e08 drm/i915/dsb: single register write function for DSB. efc2e0d931ee drm/i915/dsb: Added enum for reg write capability. 080a458a7c02 drm/i915/dsb: Indexed register write function for DSB. d3e8201962eb drm/i915/dsb: Update i915_write to call dsb-write.
-:42: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #42: FILE: drivers/gpu/drm/i915/i915_drv.h:2721:
+#define I915_WRITE(reg__, val__) \
+ (reg__.cap) ? intel_dsb_reg_write(dev_priv->dsb, (reg__), (val__)) : \
+ __I915_REG_OP(write, dev_priv, (reg__), (val__))
-:42: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg__' - possible side-effects? #42: FILE: drivers/gpu/drm/i915/i915_drv.h:2721:
+#define I915_WRITE(reg__, val__) \
+ (reg__.cap) ? intel_dsb_reg_write(dev_priv->dsb, (reg__), (val__)) : \
+ __I915_REG_OP(write, dev_priv, (reg__), (val__))
-:42: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val__' - possible side-effects? #42: FILE: drivers/gpu/drm/i915/i915_drv.h:2721:
+#define I915_WRITE(reg__, val__) \
+ (reg__.cap) ? intel_dsb_reg_write(dev_priv->dsb, (reg__), (val__)) : \
+ __I915_REG_OP(write, dev_priv, (reg__), (val__))
total: 1 errors, 0 warnings, 2 checks, 26 lines checked aa9a108cf7a9 drm/i915/dsb: Register definition of DSB registers. 5f19d6c09a08 drm/i915/dsb: Check DSB engine status. 905948da193a drm/i915/dsb: functions to enable/disable DSB engine. 531a3721623a drm/i915/dsb: function to trigger workload execution of DSB. 6c5b6c287545 drm/i915/dsb: function to destroy DSB context. ce2dd71592dd drm/i915/dsb: Early prepare of dsb context. f102c82be397 drm/i915/dsb: Cleanup of DSB context. e96046cb8f4f drm/i915/dsb: Documentation for DSB. 5fcaa6842b63 drm/i915/dsb: Enable gamma lut programming using DSB. -:66: WARNING:LONG_LINE: line over 100 characters
#66: FILE: drivers/gpu/drm/i915/i915_reg.h:10194:
+#define PREC_PAL_GC_MAX(pipe, i) _MMIO(_PIPE(pipe, _PAL_PREC_GC_MAX_A, _PAL_PREC_GC_MAX_B) + (i) * 4, \
-:68: WARNING:LONG_LINE: line over 100 characters
#68: FILE: drivers/gpu/drm/i915/i915_reg.h:10196:
+#define PREC_PAL_EXT_GC_MAX(pipe, i) _MMIO(_PIPE(pipe, _PAL_PREC_EXT_GC_MAX_A, _PAL_PREC_EXT_GC_MAX_B) + (i) * 4, \
-:70: WARNING:LONG_LINE: line over 100 characters
#70: FILE: drivers/gpu/drm/i915/i915_reg.h:10198:
+#define PREC_PAL_EXT2_GC_MAX(pipe, i) _MMIO(_PIPE(pipe, _PAL_PREC_EXT2_GC_MAX_A, _PAL_PREC_EXT2_GC_MAX_B) + (i) * 4, \
total: 0 errors, 3 warnings, 0 checks, 62 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.SPARSE: warning for DSB enablement.
In reply to Animesh Manna== Series Details ==
== Series Details ==
Series: DSB enablement.
URL : https://patchwork.freedesktop.org/series/63013/
State : warning
== Summary ==
$ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/dsb: feature flag added for display state buffer. Okay!
Commit: drm/i915/dsb: DSB context creation.+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
Commit: drm/i915/dsb: single register write function for DSB. Okay!
Commit: drm/i915/dsb: Added enum for reg write capability. Okay!
Commit: drm/i915/dsb: Indexed register write function for DSB. Okay!
Commit: drm/i915/dsb: Update i915_write to call dsb-write. Okay!
Commit: drm/i915/dsb: Register definition of DSB registers. Okay!
Commit: drm/i915/dsb: Check DSB engine status.
Okay!
Commit: drm/i915/dsb: functions to enable/disable DSB engine.
+ ^~~~~~~~~~~~~~~~~~~~~~~
+ ^~~~~~~~~~~~~~~~~~~~~~~~
+cc1: all warnings being treated as errors+drivers/gpu/drm/i915/intel_dsb.c:35:13: error: ‘intel_dsb_enable_engine’ defined but not used [-Werror=unused-function] +drivers/gpu/drm/i915/intel_dsb.c:55:13: error: ‘intel_dsb_disable_engine’ defined but not used [-Werror=unused-function] +make[1]: *** [drivers/gpu/drm/i915] Error 2
+make[1]: *** Waiting for unfinished jobs....
+make[2]: *** [drivers/gpu/drm/i915/intel_dsb.o] Error 1
+make: *** [drivers/gpu/drm/] Error 2
+ static bool intel_dsb_disable_engine(struct intel_dsb *dsb)
+ static bool intel_dsb_enable_engine(struct intel_dsb *dsb)
Commit: drm/i915/dsb: function to trigger workload execution of DSB.
- ^~~~~~~~~~~~~~~~~~~~~~~
- ^~~~~~~~~~~~~~~~~~~~~~~~
-cc1: all warnings being treated as errors+drivers/gpu/drm/i915/display/icl_dsi.c:135:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/icl_dsi.c:1425:25: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/icl_dsi.c:1425:25: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/icl_dsi.c:1426:26: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/icl_dsi.c:1426:26: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_audio.c:306:15: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_audio.c:306:15: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_audio.c:482:15: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_audio.c:601:15: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_audio.c:971:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_audio.c:971:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:129:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:129:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:169:19: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:169:19: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:171:20: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:171:20: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:191:30: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:191:30: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:195:44: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:195:44: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:244:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:244:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:244:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:244:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:244:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:244:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:244:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:244:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:244:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:244:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:244:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:244:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:244:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_bw.c:244:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_cdclk.c:2251:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_cdclk.c:2254:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_cdclk.c:2263:29: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_cdclk.c:2271:29: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_cdclk.c:2280:29: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_cdclk.c:2312:29: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_cdclk.c:2312:29: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_cdclk.c:2348:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_cdclk.c:2348:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_cdclk.c:2541:17: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_cdclk.c:2541:17: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_cdclk.c:2575:17: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_cdclk.c:2575:17: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:121:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:121:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:121:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:121:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:121:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:121:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:121:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:227:29: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:227:29: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:227:29: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:227:29: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:227:29: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:227:29: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:227:29: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:237:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:237:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:237:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:237:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:237:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:237:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:237:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:240:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:240:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:240:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:240:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:240:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:240:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:240:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:243:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:243:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:243:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:243:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:243:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:243:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:243:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:245:38: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:245:38: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:245:38: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:245:38: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:245:38: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:245:38: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:245:38: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:248:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:248:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:248:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:248:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:248:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:248:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:248:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:251:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:251:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:251:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:251:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:251:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:251:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:251:33: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:341:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:341:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:341:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:341:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:341:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:341:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_color.c:341:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_ddi.c:671:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_ddi.c:673:24: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_display.c:1202:22: error: Expected constant expression in case statement +drivers/gpu/drm/i915/display/intel_display.c:1205:22: error: Expected constant expression in case statement +drivers/gpu/drm/i915/display/intel_display.c:1208:22: error: Expected constant expression in case statement +drivers/gpu/drm/i915/display/intel_display.c:1211:22: error: Expected constant expression in case statement +drivers/gpu/drm/i915/display/intel_display.c:14391:21: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_display.c:14391:21: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_display.c:2420:13: error: undefined identifier '__builtin_add_overflow_p' +drivers/gpu/drm/i915/display/intel_display.c:2792:28: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_display.c:2792:28: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_display.c:7372:26: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_display.c:883:21: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_display.c:883:21: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:158:21: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:158:21: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:158:21: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:158:21: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:158:21: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:158:21: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:158:21: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:1442:39: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:1442:39: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:1442:39: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:1442:39: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:1442:39: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:1442:39: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:1442:39: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:1442:39: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:1806:23: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:1806:23: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:1939:23: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:1959:25: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:1959:25: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:1981:58: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:1981:58: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:255:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:255:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:255:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:255:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:255:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:255:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:255:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:255:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:255:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:255:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:255:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:255:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:255:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:255:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:300:30: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:300:30: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:394:28: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:394:28: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:4371:26: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:4371:26: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:4414:27: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:4414:27: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:5941:30: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6645:31: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6674:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6674:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6674:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6674:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6675:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6675:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6675:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6675:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6676:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6676:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6676:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6676:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6677:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6677:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6677:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6677:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6678:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6678:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6678:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_dp.c:6678:9: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_fbc.c:92:25: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_fbc.c:94:25: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_gmbus.c:469:31: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_gmbus.c:471:31: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_gmbus.c:471:31: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_gmbus.c:533:23: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_gmbus.c:533:23: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_hdmi.c:2091:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_hdmi.c:2091:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_hdmi.c:2108:42: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_hdmi.c:2108:42: warning: expression using sizeof(void) +drivers/gpu/drm/i915/display/intel_hdmi.c:2112:42: warning: ex
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for DSB enablement.
In reply to Animesh Manna== Series Details ==
== Series Details ==
Series: DSB enablement.
URL : https://patchwork.freedesktop.org/series/63013/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6388 -> Patchwork_13476
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/
Known issues
------------
Here are the changes found in Patchwork_13476 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap@basic-small-bo:
- fi-glk-dsi: [PASS][1] -> [INCOMPLETE][2] ([fdo#103359] / [fdo#110715] / [k.org#198133])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/fi-glk-dsi/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/fi-glk-dsi/igt@[email protected]
* igt@i915_module_load@reload:
- fi-blb-e6850: [PASS][3] -> [INCOMPLETE][4] ([fdo#107718])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/fi-blb-e6850/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/fi-blb-e6850/igt@[email protected]
* igt@prime_vgem@basic-fence-flip:
- fi-ilk-650: [PASS][5] -> [DMESG-WARN][6] ([fdo#106387]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/fi-ilk-650/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/fi-ilk-650/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live_blt:
- fi-skl-iommu: [INCOMPLETE][7] ([fdo#108602]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/fi-skl-iommu/igt@i915_selftest@live_blt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/fi-skl-iommu/igt@i915_selftest@live_blt.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [FAIL][9] ([fdo#109635 ]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/fi-kbl-7500u/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/fi-kbl-7500u/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7567u: [FAIL][11] ([fdo#109485]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/fi-kbl-7567u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/fi-kbl-7567u/igt@[email protected]
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#110715]: https://bugs.freedesktop.org/show_bug.cgi?id=110715
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (50 -> 42)
------------------------------
Additional (3): fi-hsw-peppy fi-icl-u3 fi-cml-u
Missing (11): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-pnv-d510 fi-icl-y fi-icl-guc fi-icl-dsi fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_6388 -> Patchwork_13476
CI_DRM_6388: 2307d0a7a88d1e98df2214f16d93efd68fb5fcd9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5075: 03779dd3de8a57544f124d9952a6d2b3e34e34ca @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13476: 5fcaa6842b634e04a4a1fced696ec893510c99e3 @ git://anongit.freedesktop.org/gfx-ci/linux
== Kernel 32bit build ==
Warning: Kernel 32bit buildtest failed:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/build_32bit.log
CALL scripts/checksyscalls.sh CALL scripts/atomic/check-atomics.sh CHK include/generated/compile.h
Kernel: arch/x86/boot/bzImage is ready (#1)
Building modules, stage 2.
MODPOST 112 modules
ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: "__divdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1
Makefile:1287: recipe for target 'modules' failed
make: *** [modules] Error 2
== Linux commits ==
5fcaa6842b63 drm/i915/dsb: Enable gamma lut programming using DSB. e96046cb8f4f drm/i915/dsb: Documentation for DSB. f102c82be397 drm/i915/dsb: Cleanup of DSB context. ce2dd71592dd drm/i915/dsb: Early prepare of dsb context. 6c5b6c287545 drm/i915/dsb: function to destroy DSB context. 531a3721623a drm/i915/dsb: function to trigger workload execution of DSB. 905948da193a drm/i915/dsb: functions to enable/disable DSB engine. 5f19d6c09a08 drm/i915/dsb: Check DSB engine status. aa9a108cf7a9 drm/i915/dsb: Register definition of DSB registers. d3e8201962eb drm/i915/dsb: Update i915_write to call dsb-write. 080a458a7c02 drm/i915/dsb: Indexed register write function for DSB. efc2e0d931ee drm/i915/dsb: Added enum for reg write capability. 208d2a783e08 drm/i915/dsb: single register write function for DSB. f910e626c852 drm/i915/dsb: DSB context creation.d1b2b4d2b22b drm/i915/dsb: feature flag added for display state buffer.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for DSB enablement.
In reply to Animesh Manna== Series Details ==
== Series Details ==
Series: DSB enablement.
URL : https://patchwork.freedesktop.org/series/63013/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6388_full -> Patchwork_13476_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_13476_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_13476_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_13476_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_busy@extended-modeset-hang-oldfb-render-a:
- shard-snb: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-snb7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-snb4/igt@[email protected]
* igt@kms_color@pipe-b-ctm-negative:
- shard-skl: [PASS][3] -> [INCOMPLETE][4] +20 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-skl10/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-skl4/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-iclb: [PASS][5] -> [DMESG-FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-iclb3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@runner@aborted:
- shard-iclb: NOTRUN -> ([FAIL][7], [FAIL][8], [FAIL][9]) ([fdo#108866])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-iclb5/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-iclb3/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-iclb7/igt@[email protected]
- shard-snb: NOTRUN -> [FAIL][10]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-snb4/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_13476_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-iclb: [PASS][11] -> [DMESG-WARN][12] ([fdo#110222])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-iclb1/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-iclb3/igt@[email protected]
* igt@kms_color@pipe-a-degamma:
- shard-hsw: [PASS][13] -> [INCOMPLETE][14] ([fdo#103540]) +23 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-hsw4/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-hsw1/igt@[email protected]
* igt@kms_color@pipe-b-degamma:
- shard-kbl: [PASS][15] -> [INCOMPLETE][16] ([fdo#103665]) +22 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-kbl7/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-kbl4/igt@[email protected]
* igt@kms_color@pipe-c-ctm-0-25:
- shard-apl: [PASS][17] -> [INCOMPLETE][18] ([fdo#103927]) +20 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-apl3/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-apl5/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-apl4/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-apl6/igt@[email protected]
* igt@kms_cursor_legacy@all-pipes-forked-bo:
- shard-glk: [PASS][21] -> [INCOMPLETE][22] ([fdo#103359] / [k.org#198133]) +20 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-glk1/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-glk4/igt@[email protected]
* igt@kms_cursor_legacy@pipe-b-forked-move:
- shard-iclb: [PASS][23] -> [DMESG-WARN][24] ([fdo#107122])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-iclb2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-iclb5/igt@[email protected]
* igt@kms_cursor_legacy@pipe-b-torture-move:
- shard-iclb: [PASS][25] -> [INCOMPLETE][26] ([fdo#107713]) +14 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-iclb3/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-iclb1/igt@[email protected]
- shard-snb: [PASS][27] -> [INCOMPLETE][28] ([fdo#105411]) +5 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-snb1/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-snb2/igt@[email protected]
* igt@kms_cursor_legacy@pipe-c-torture-move:
- shard-skl: [PASS][29] -> [INCOMPLETE][30] ([fdo#104108]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-skl5/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-skl1/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][31] -> [FAIL][32] ([fdo#105363]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-skl2/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-skl9/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [PASS][33] -> [FAIL][34] ([fdo#105363])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-glk2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-glk3/igt@[email protected]
* igt@kms_flip@flip-vs-suspend:
- shard-kbl: [PASS][35] -> [DMESG-WARN][36] ([fdo#108566])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-kbl2/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-kbl6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite:
- shard-hsw: [PASS][37] -> [SKIP][38] ([fdo#109271]) +7 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-hsw4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary:
- shard-iclb: [PASS][39] -> [FAIL][40] ([fdo#103167]) +4 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-iclb8/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-iclb1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][41] -> [FAIL][42] ([fdo#108145])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-skl3/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-skl4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][43] -> [FAIL][44] ([fdo#108145] / [fdo#110403]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-skl10/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-skl2/igt@[email protected]
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#109441]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@perf@blocking:
- shard-skl: [PASS][47] -> [FAIL][48] ([fdo#110728])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-skl4/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-skl5/igt@[email protected]
* igt@perf_pmu@rc6:
- shard-kbl: [PASS][49] -> [SKIP][50] ([fdo#109271])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-kbl6/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-kbl2/igt@[email protected]
#### Possible fixes ####
* igt@i915_pm_rpm@i2c:
- shard-hsw: [FAIL][51] ([fdo#104097]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-hsw2/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-hsw7/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][53] ([fdo#108566]) -> [PASS][54] +3 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-kbl1/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-kbl4/igt@[email protected]
* igt@kms_flip@flip-vs-suspend:
- shard-glk: [INCOMPLETE][55] ([fdo#103359] / [k.org#198133]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-glk2/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-glk6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-glk: [FAIL][57] ([fdo#103167]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-glk7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-glk1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move:
- shard-hsw: [SKIP][59] ([fdo#109271]) -> [PASS][60] +11 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-hsw1/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-hsw4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][61] ([fdo#103167]) -> [PASS][62] +4 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-skl: [INCOMPLETE][63] ([fdo#104108]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-skl1/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-skl9/igt@[email protected]
#### Warnings ####
* igt@i915_pm_lpsp@non-edp:
- shard-apl: [SKIP][65] ([fdo#109271]) -> [INCOMPLETE][66] ([fdo#103927])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6388/shard-apl2/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/shard-apl1/igt@[email protected]
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#107122]: https://bugs.freedesktop.org/show_bug.cgi?id=107122
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108866]: https://bugs.freedesktop.org/show_bug.cgi?id=108866
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_6388 -> Patchwork_13476
CI_DRM_6388: 2307d0a7a88d1e98df2214f16d93efd68fb5fcd9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5075: 03779dd3de8a57544f124d9952a6d2b3e34e34ca @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13476: 5fcaa6842b634e04a4a1fced696ec893510c99e3 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13476/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 10 lines · Animesh Manna
Display State Buffer (DSB) is hardware capability which allows driver to batch submit HW programming.
As part of initial enablement common api created which currently used to program gamma lut proramming.
Going forwad DSB support can be added for HDR and flip related operation.
Few changes of this patch series is not tested, sending version 1 for design review, will be testing in parallel.
Our CI reported on the same day that this series oopses on a lot of platforms. Have you investigated and fixed those issues? Please post the fixed series.
BR,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 7 lines · Jani Nikula
Quoted 6 lines · Animesh Manna
Display State Buffer (DSB) is hardware capability which allows driver to batch submit HW programming.
As part of initial enablement common api created which currently used to program gamma lut proramming.
Quoted 7 lines
Quoted 4 lines
Going forwad DSB support can be added for HDR and flip related operation.
Few changes of this patch series is not tested, sending version 1 for design review, will be testing in parallel.
Our CI reported on the same day that this series oopses on a lot of platforms. Have you investigated and fixed those issues? Please post the fixed series.
Found the issue and fixed it (changes added in 15th patch), have sent to trybot, will post the patches soon.
Regards,
Animesh
Quoted 4 lines
BR,
Jani.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx