staging: rtl8723bs: remove redundant 'Adapter' variable in HalPhyRf_8723B
PATCH v2 1/1 staging: rtl8723bs: remove redundant 'Adapter' variable in HalPhyRf_8723B
The variable Adapter was declared and initialized locally in an if-statement, but it shadowed a variable of the same name and value declared in the function scope (line 169).
Removing the inner declaration allows the code to use the existing outer variable, resolving a -Wshadow warning.
---
Changes in v2:
Removed the white space in line 211, which caused a coding style warning (reported by Greg K-H).
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +0 -1
@@ -208,7 +208,6 @@ void ODM_TxPwrTrackSetPwr_8723B( }if (Method ==TXAGC ) { - pDM_Odm->Remnant_OFDMSwingIdx[RFPath] = pDM_Odm->Absolute_OFDMSwingIdx[RFPath]; pDM_Odm->Modify_TxAGC_Flag_PathA = true;
Signature · 1 line
2.53.0
Quoted 20 lines · Haroen Tmimi
The variable Adapter was declared and initialized locally in an if-statement, but it shadowed a variable of the same name and value declared in the function scope (line 169).
Removing the inner declaration allows the code to use the existing outer variable, resolving a -Wshadow warning.
Signed-off-by Haroen Tmimi <[email protected]>---
Changes in v2:
Removed the white space in line 211, which caused a coding style warning (reported by Greg K-H).drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 1 - 1 file changed, 1 deletion(-)drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +0
-0
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c void ODM_TxPwrTrackSetPwr_8723B( · line 213
Quoted 7 lines
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +0
-1@@ -208,7 +208,6 @@ void ODM_TxPwrTrackSetPwr_8723B( }if (Method ==TXAGC ) { - pDM_Odm->Remnant_OFDMSwingIdx[RFPath] = pDM_Odm->Absolute_OFDMSwingIdx[RFPath]; pDM_Odm->Modify_TxAGC_Flag_PathA = true;
I don't see the Adapter variable here?
I believe you meant to use "git commit --amend" but, just made the v2 its own patch without the previous diff.
Thanks,
ET