arm64: dts: rockchip: Add RK3566 LubanCat 1
Subsystems (2)
PATCH v2 1/1 arm64: dts: rockchip: Add RK3566 LubanCat 1
LubanCat 1 is a Rockchip RK3566 SBC based
is developed by EmbedFire Electronics Co., Ltd. Mini Linux Card Type Cheap Computer Development Board It has the following characteristics:
- MicroSD card slot, onboard eMMC flash memory
- 1GbE Realtek RTL8211F Ethernet Transceiver
- 1 USB Type-C port (power and USB2.0 OTG)
- 1 USB 3.0 Host port
- 3 USB 2.0 Host ports
- 1 HDMI
- 1 infrared receiver
- 1 MIPI DSI
- 1 MIPI CSI
- 1 x 4-section headphone jack
- Mini PCIe socket (USB or PCIe)
- 1 SIM Card slot
- 1 SYS LED and 1 PWR LED
- 40-pin GPIO expansion header
--- .../devicetree/bindings/arm/rockchip.yaml | 5 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3566-lubancat-1.dts | 600 ++++++++++++++++++ 3 files changed, 606 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
@@ -781,6 +781,11 @@ properties: - const: rockchip,rk3568-bpi-r2pro - const: rockchip,rk3568 + - description: EmbedFire LubanCat 1 + items: + - const: embedfire,lubancat-1 + - const: rockchip,rk3566 + additionalProperties: true ...
arch/arm64/boot/dts/rockchip/Makefile +1 -0
@@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-blade.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-model-a.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtb
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +600 -0
600 lines not on this page · raw message
Signature · 1 line
2.27.0
Quoted 3 lines · Yuteng Zhong
LubanCat 1 is a Rockchip RK3566 SBC based
is developed by EmbedFire Electronics Co., Ltd. Mini Linux Card Type Cheap Computer Development Board
Please wrap commit message according to Linux coding style / submission process:
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
Quoted 30 lines
It has the following characteristics:
- MicroSD card slot, onboard eMMC flash memory
- 1GbE Realtek RTL8211F Ethernet Transceiver
- 1 USB Type-C port (power and USB2.0 OTG)
- 1 USB 3.0 Host port
- 3 USB 2.0 Host ports
- 1 HDMI
- 1 infrared receiver
- 1 MIPI DSI
- 1 MIPI CSI
- 1 x 4-section headphone jack
- Mini PCIe socket (USB or PCIe)
- 1 SIM Card slot
- 1 SYS LED and 1 PWR LED
- 40-pin GPIO expansion headerSigned-off-by Yuteng Zhong <[email protected]>Signed-off-by DHDAXCW <[email protected]>--- .../devicetree/bindings/arm/rockchip.yaml | 5 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3566-lubancat-1.dts | 600 ++++++++++++++++++ 3 files changed, 606 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dtsDocumentation/devicetree/bindings/arm/rockchip.yaml +0
-0
Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 788
Quoted 8 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +5
-0@@ -781,6 +781,11 @@ properties: - const: rockchip,rk3568-bpi-r2pro - const: rockchip,rk3568 + - description: EmbedFire LubanCat 1 + items: + - const: embedfire,lubancat-1 + - const: rockchip,rk3566 +
This is separate patch. Does not look like properly ordered. Don't add stuff at the end of files/lists.
Quoted 69 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +0
-0additionalProperties: truearch/arm64/boot/dts/rockchip/Makefile +1
-0@@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-blade.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-model-a.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtbarch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +48
-0@@ -0,0 +1,600 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* +* Copyright (c) 2021 Rockchip Electronics Co., Ltd. +*/ + +/dts-v1/; +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/leds/common.h> +#include <dt-bindings/pinctrl/rockchip.h> +#include <dt-bindings/soc/rockchip,vop2.h> +#include "rk3566.dtsi" + +/ { + model = "EmbedFire LubanCat 1"; + compatible = "embedfire,lubancat-1", "rockchip,rk3566"; + + aliases { + ethernet0 = &gmac1; + mmc0 = &sdmmc0; + mmc1 = &sdhci; + }; + + chosen: chosen { + stdout-path = "serial2:1500000n8"; + }; + + gmac1_clkin: external-gmac1-clock { + compatible = "fixed-clock"; + clock-frequency = <125000000>; + clock-output-names = "gmac1_clkin"; + #clock-cells = <0>; + }; + + hdmi-con { + compatible = "hdmi-connector"; + type = "a"; + + port { + hdmi_con_in: endpoint { + remote-endpoint = <&hdmi_out_con>; + }; + }; + }; + + gpio-leds { + compatible = "gpio-leds"; + + sys_led: sys-led {
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts line 58
Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +10
-0+ label = "sys_led"; + linux,default-trigger = "heartbeat"; + default-state = "on"; + gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&sys_led_pin>; + }; + }; + + dc_5v: dc-5v {
Node names should be generic, so at least with regulator prefix or suffix.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Quoted 19 lines
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +19
-0+ compatible = "regulator-fixed"; + regulator-name = "dc_5v"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + }; + + vcc3v3_sys: vcc3v3-sys { + compatible = "regulator-fixed"; + regulator-name = "vcc3v3_sys"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + vin-supply = <&vcc5v0_sys>; + }; + + vcc5v0_sys: vcc5v0-sys {
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts line 87
Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +10
-0+ compatible = "regulator-fixed"; + regulator-name = "vcc5v0_sys"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + vin-supply = <&dc_5v>; + }; + + pcie_3v3: pcie2-3v3-regulator {
And here you have it? Keep your code consistent.
Quoted 123 lines
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +123
-0+ compatible = "regulator-fixed"; + regulator-name = "pcie_3v3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + enable-active-high; + gpio = <&gpio0 RK_PD3 GPIO_ACTIVE_HIGH>; + startup-delay-us = <5000>; + vin-supply = <&vcc5v0_sys>; + }; + + vcc5v0_usb20_host: vcc5v0-usb20-host-regulator { + compatible = "regulator-fixed"; + enable-active-high; + gpio = <&gpio2 RK_PB6 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&vcc5v0_usb20_host_en>; + regulator-name = "vcc5v0_usb20_host"; + regulator-always-on; + }; + + vcc5v0_usb30_host: vcc5v0-usb30-host-regulator { + compatible = "regulator-fixed"; + enable-active-high; + gpio = <&gpio2 RK_PB5 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&vcc5v0_usb30_host_en>; + regulator-name = "vcc5v0_usb30_host"; + regulator-always-on; + }; +}; + +&uart2 { + status = "okay"; +}; + +&combphy1 { + status = "okay"; +}; + +&combphy2 { + status = "okay"; +}; + +&cpu0 { + cpu-supply = <&vdd_cpu>; +}; + +&cpu1 { + cpu-supply = <&vdd_cpu>; +}; + +&cpu2 { + cpu-supply = <&vdd_cpu>; +}; + +&cpu3 { + cpu-supply = <&vdd_cpu>; +}; + +&gpu { + mali-supply = <&vdd_gpu>; + status = "okay"; +}; + +&hdmi { + avdd-0v9-supply = <&vdda0v9_image>; + avdd-1v8-supply = <&vcca1v8_image>; + status = "okay"; +}; + +&hdmi_in { + hdmi_in_vp0: endpoint { + remote-endpoint = <&vp0_out_hdmi>; + }; +}; + +&hdmi_out { + hdmi_out_con: endpoint { + remote-endpoint = <&hdmi_con_in>; + }; +}; + +&hdmi_sound { + status = "okay"; +}; + +&i2c0 { + status = "okay"; + + vdd_cpu: regulator@1c { + compatible = "tcs,tcs4525"; + reg = <0x1c>; + fcs,suspend-voltage-selector = <1>; + regulator-name = "vdd_cpu"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <1150000>; + regulator-ramp-delay = <2300>; + vin-supply = <&vcc5v0_sys>; + + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + rk809: pmic@20 { + compatible = "rockchip,rk809"; + reg = <0x20>; + interrupt-parent = <&gpio0>; + interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>; + assigned-clocks = <&cru I2S1_MCLKOUT_TX>; + assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>; + #clock-cells = <1>; + clock-names = "mclk"; + clocks = <&cru I2S1_MCLKOUT_TX>; + pinctrl-names = "default"; + pinctrl-0 = <&pmic_int>; + rockchip,system-power-controller; + #sound-dai-cells = <0>; + vcc1-supply = <&vcc3v3_sys>; + vcc2-supply = <&vcc3v3_sys>; + vcc3-supply = <&vcc3v3_sys>;
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts line 220
Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +10
-0+ vcc4-supply = <&vcc3v3_sys>; + vcc5-supply = <&vcc3v3_sys>; + vcc6-supply = <&vcc3v3_sys>; + vcc7-supply = <&vcc3v3_sys>; + vcc8-supply = <&vcc3v3_sys>; + vcc9-supply = <&vcc3v3_sys>; + wakeup-source; + + regulators { + vdd_logic: DCDC_REG1 {
No underscores in node names. Anything requires it?
Best regards,
Krzysztof
Heiko Stübner
maintainerAm Dienstag, 20. Dezember 2022, 17:14:51 CET schrieb Krzysztof Kozlowski:
Quoted 30 lines · Yuteng Zhong
Quoted 3 lines
LubanCat 1 is a Rockchip RK3566 SBC based
is developed by EmbedFire Electronics Co., Ltd. Mini Linux Card Type Cheap Computer Development BoardPlease wrap commit message according to Linux coding style / submission process:
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586Quoted 21 lines
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +21
-0+ rk809: pmic@20 { + compatible = "rockchip,rk809"; + reg = <0x20>; + interrupt-parent = <&gpio0>; + interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>; + assigned-clocks = <&cru I2S1_MCLKOUT_TX>; + assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>; + #clock-cells = <1>; + clock-names = "mclk"; + clocks = <&cru I2S1_MCLKOUT_TX>; + pinctrl-names = "default"; + pinctrl-0 = <&pmic_int>; + rockchip,system-power-controller; + #sound-dai-cells = <0>; + vcc1-supply = <&vcc3v3_sys>; + vcc2-supply = <&vcc3v3_sys>; + vcc3-supply = <&vcc3v3_sys>; + vcc4-supply = <&vcc3v3_sys>; + vcc5-supply = <&vcc3v3_sys>; + vcc6-supply = <&vcc3v3_sys>; + vcc7-supply = <&vcc3v3_sys>;
Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts line 220
Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +6
-0+ vcc8-supply = <&vcc3v3_sys>; + vcc9-supply = <&vcc3v3_sys>; + wakeup-source; + + regulators { + vdd_logic: DCDC_REG1 {No underscores in node names. Anything requires it?
looks like the answer is "it depends" :-)
When the regulator-framework searches for the node to get the init-data from it uses the actual node-name or the regulator-compatible property [0] to match against.
And going via regulator-compatible was the "old" way, already deprecated before the yaml-conversion [1] and not even included
So matching against the node-name is the correct way to go and it's actually part of the rk8xx-binding as well [2]
Hope that helps,
Heiko
[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/regulator/of_regulator.c#n477
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/devicetree/bindings/regulator/regulator.txt?id=1914a996436b09186489da73b807e1df71259f67
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml#n84
ok. Modifications are made in PATCH v4.
NOTE: PATCH v3 was sent with an old patch file as attachment, so please ignore.
NOTE: Last Reply E-mail were sent in HTML mode.
Quoted 63 lines · Heiko Stübner <[email protected]> 于2022年12月21日周三 01:32写道:
Am Dienstag, 20. Dezember 2022, 17:14:51 CET schrieb Krzysztof Kozlowski:
Quoted 37 lines · Yuteng Zhong
Quoted 3 lines
LubanCat 1 is a Rockchip RK3566 SBC based
is developed by EmbedFire Electronics Co., Ltd. Mini Linux Card Type Cheap Computer Development BoardPlease wrap commit message according to Linux coding style / submission process:
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586Quoted 17 lines
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +17
-0+ rk809: pmic@20 { + compatible = "rockchip,rk809"; + reg = <0x20>; + interrupt-parent = <&gpio0>; + interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>; + assigned-clocks = <&cru I2S1_MCLKOUT_TX>; + assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>; + #clock-cells = <1>; + clock-names = "mclk"; + clocks = <&cru I2S1_MCLKOUT_TX>; + pinctrl-names = "default"; + pinctrl-0 = <&pmic_int>; + rockchip,system-power-controller; + #sound-dai-cells = <0>; + vcc1-supply = <&vcc3v3_sys>; + vcc2-supply = <&vcc3v3_sys>; + vcc3-supply = <&vcc3v3_sys>;arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts line 220
Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +10
-0+ vcc4-supply = <&vcc3v3_sys>; + vcc5-supply = <&vcc3v3_sys>; + vcc6-supply = <&vcc3v3_sys>; + vcc7-supply = <&vcc3v3_sys>; + vcc8-supply = <&vcc3v3_sys>; + vcc9-supply = <&vcc3v3_sys>; + wakeup-source; + + regulators { + vdd_logic: DCDC_REG1 {Quoted 1 line
No underscores in node names. Anything requires it?
looks like the answer is "it depends" :-)
When the regulator-framework searches for the node to get the init-data from it uses the actual node-name or the regulator-compatible property [0] to match against.
And going via regulator-compatible was the "old" way, already deprecated before the yaml-conversion [1] and not even included
So matching against the node-name is the correct way to go and it's actually part of the rk8xx-binding as well [2]
Hope that helps,
Heiko[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/regulator/of_regulator.c#n477
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/devicetree/bindings/regulator/regulator.txt?id=1914a996436b09186489da73b807e1df71259f67
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml#n84
Signature · 3 lines
Y. T. Zhong Student of The University of Hong Kong, major in Computer Science. E-mail: [email protected]
A message that is not in the archive (sent off-list or not yet received): CAMmci2XuiwZje53L6Nv9+EG+W6pvXSbwyR2Ko5h8n9LEppS5pg@mail.gmail.com
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 10 lines · Krzysztof Kozlowski <[email protected]> 于2022年12月21日周三 17:05写道:
Quoted 5 lines · ty
thanks. I am really sorry.
I fixed this based on your feedback in the PATCH V2 content. Regarding the dts issue, I used the kernel-5.15 kernel adaptation before, which may not be perfect at that time.
Do not send patches based on v5.15. This is some very old kernel. We do not work on such stuff.
Thank you for your kindly reminder. We have modified the whole .dts file based on v6.2 kernel and follow the generic-name-regulation[0] in [PATCH v4]. Because it was basically a whole rewrite, so I decided to send a new PATCH v4.
Quoted 3 lines
The comment was:
"Node names should be generic, so at least with regulator prefix or suffix."
Yes. Node names are all changed in [PATCH v4].
Signature · 3 lines
Y. T. Zhong Student of The University of Hong Kong, major in Computer Science. E-mail: [email protected]
Dear Kozlowski,
We just got where we did wrong by reading twice about the generic-name-recommendation document and comparing our PATCHes with others. We will make a new PATCH v5 addressing all the comments.
Thanks for your patient. We felt sincerely sorry.
Recards.
Yuteng Zhong, DHDAXCW.
Quoted 25 lines · ty <[email protected]> 于2022年12月21日周三 17:18写道:
Quoted 10 lines · Krzysztof Kozlowski <[email protected]> 于2022年12月21日周三 17:05写道:
Quoted 5 lines · ty
thanks. I am really sorry.
I fixed this based on your feedback in the PATCH V2 content. Regarding the dts issue, I used the kernel-5.15 kernel adaptation before, which may not be perfect at that time.
Do not send patches based on v5.15. This is some very old kernel. We do not work on such stuff.
Thank you for your kindly reminder. We have modified the whole .dts file based on v6.2 kernel and follow the generic-name-regulation[0] in [PATCH v4]. Because it was basically a whole rewrite, so I decided to send a new PATCH v4.
Quoted 3 lines
The comment was:
"Node names should be generic, so at least with regulator prefix or suffix."Yes. Node names are all changed in [PATCH v4].