Skip to contentSkip to conversation

arm64: dts: rockchip: Add EmbedFire LubanCat 1

PATCH Superseded Yuteng Zhong 3 participants 10 messages Dec 21, 2022

Subsystems (2)

v4 of 9 Superseded Latest is v9 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/2 arm64: dts: rockchip: Add EmbedFire LubanCat 1

from: DHDAXCW <[email protected]>

LubanCat 1 is a Rockchip RK3566 SBC based
is developed by EmbedFire Electronics Co., Ltd. Mini Linux Card Type Cheap Computer Development Board

It has the following characteristics:
- MicroSD card slot, onboard eMMC flash memory
- 1GbE Realtek RTL8211F Ethernet Transceiver
- 1 USB Type-C port (power and USB2.0 OTG)
- 1 USB 3.0 Host port
- 3 USB 2.0 Host ports
- 1 HDMI
- 1 infrared receiver
- 1 MIPI DSI
- 1 MIPI CSI
- 1 x 4-section headphone jack
- Mini PCIe socket (USB or PCIe)
- 1 SIM Card slot
- 1 SYS LED and 1 PWR LED
- 40-pin GPIO expansion header

---

Changed in V2:
- Remove RNG node
Changed in V3:
- Sent E-mail with a wrong attachment
Changed in V4:
- Modify all node names

---
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3566-lubancat-1.dts   | 598 ++++++++++++++++++
 2 files changed, 599 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index 0a76a2ebb5f6..e52bda04d45a 100644
@@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-blade.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-model-a.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtb
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +598 -0

598 lines not on this page · raw message

Signature · 1 line
2.27.0
#1 lore raw

PATCH v4 2/2 dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

from: DHDAXCW <[email protected]>

LubanCat 1 is a Rockchip RK3566 SBC based
is developed by EmbedFire Electronics Co., Ltd. Mini Linux Card Type Cheap Computer Development Board

---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
index 88ff4422a8c1..84d39a3a8843 100644
@@ -781,6 +781,11 @@ properties:
           - const: rockchip,rk3568-bpi-r2pro
           - const: rockchip,rk3568
 
+      - description: EmbedFire LubanCat 1
+        items:
+          - const: embedfire,lubancat-1
+          - const: rockchip,rk3566
+
 additionalProperties: true
 
 ...
Signature · 1 line
2.27.0
#2 lore raw

Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

Quoted 5 lines · Yuteng Zhong

from: DHDAXCW <[email protected]>

LubanCat 1 is a Rockchip RK3566 SBC based
is developed by EmbedFire Electronics Co., Ltd. Mini Linux Card Type Cheap Computer Development Board

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them.

Thank you.

Quoted 12 lines
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +0 -0
index 88ff4422a8c1..84d39a3a8843 100644

Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 787

Quoted 7 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +4 -0
@@ -781,6 +781,11 @@ properties:
           - const: rockchip,rk3568-bpi-r2pro
           - const: rockchip,rk3568
 
+      - description: EmbedFire LubanCat 1
+        items:
+          - const: embedfire,lubancat-1
+          - const: rockchip,rk3566

Here as well.

Best regards,
Krzysztof

author
#3 lore raw

Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

Dear Kozlowski,

Sorry that we didn't fully get the idea in your previous comments.

Quoted 8 lines · Yuteng Zhong
Quoted 5 lines

from: DHDAXCW <[email protected]>

LubanCat 1 is a Rockchip RK3566 SBC based
is developed by EmbedFire Electronics Co., Ltd. Mini Linux Card Type Cheap Computer Development Board

Quoted 8 lines

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them.

Thank you.

Your pervious comment were:

Quoted 3 lines

Please wrap commit message according to Linux coding style / submission process:
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586

So I think there must be something wrong in the message but I didn't notice. This message has a from line, and the body was wrapped at 75 columns. Please help me make it better.

Quoted 15 lines
Quoted 15 lines
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +0 -0
index 88ff4422a8c1..84d39a3a8843 100644
@@ -781,6 +781,11 @@ properties:
           - const: rockchip,rk3568-bpi-r2pro
           - const: rockchip,rk3568
 
Quoted 6 lines

Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 787

Quoted 4 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +4 -0
+      - description: EmbedFire LubanCat 1
+        items:
+          - const: embedfire,lubancat-1
+          - const: rockchip,rk3566

Here as well.

This change was addressing the previous comment in V2:

Quoted 2 lines

This is separate patch. Does not look like properly ordered. Don't add stuff at the end of files/lists.

The previous PATCH v2 merged changes in 3 diffent files:

1. arch/arm64/boot/dts/rockchip/Makefile
2. arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
3. Documentation/devicetree/bindings/arm/rockchip.yaml

What we do in this PATCH v4 was separated the 3 into a separated patch.

#4 lore raw

Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

Quoted 23 lines · ty

Dear Kozlowski,

Sorry that we didn't fully get the idea in your previous comments.

Quoted 8 lines · Yuteng Zhong
Quoted 5 lines

from: DHDAXCW <[email protected]>

LubanCat 1 is a Rockchip RK3566 SBC based
is developed by EmbedFire Electronics Co., Ltd. Mini Linux Card Type Cheap Computer Development Board

Quoted 8 lines

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them.

Thank you.

Your pervious comment were:

Quoted 7 lines
Quoted 3 lines

Please wrap commit message according to Linux coding style / submission process:
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586

So I think there must be something wrong in the message but I didn't notice. This message has a from line, and the body was wrapped at 75 columns. Please help me make it better.

You do not wrap at 75, but at some other place. Just put it to editor and check where is wrapping (count characters).

Quoted 30 lines
Quoted 18 lines
Quoted 18 lines
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +0 -0
index 88ff4422a8c1..84d39a3a8843 100644
@@ -781,6 +781,11 @@ properties:
           - const: rockchip,rk3568-bpi-r2pro
           - const: rockchip,rk3568
 
Quoted 6 lines

Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 787

Quoted 4 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +4 -0
+      - description: EmbedFire LubanCat 1
+        items:
+          - const: embedfire,lubancat-1
+          - const: rockchip,rk3566

Here as well.

This change was addressing the previous comment in V2:

Quoted 2 lines

This is separate patch. Does not look like properly ordered. Don't add stuff at the end of files/lists.

Quoted 7 lines

The previous PATCH v2 merged changes in 3 diffent files:

1. arch/arm64/boot/dts/rockchip/Makefile
2. arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
3. Documentation/devicetree/bindings/arm/rockchip.yaml

What we do in this PATCH v4 was separated the 3 into a separated patch.

So how did you solve the comment "Does not look like properly ordered. Don't add stuff at the end of files/lists."? What did you change to solve it?

Best regards,
Krzysztof

maintainer
#5 lore raw

Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

In reply to ty

Am Mittwoch, 21. Dezember 2022, 11:46:36 CET schrieb ty:

Quoted 48 lines

Dear Kozlowski,

Sorry that we didn't fully get the idea in your previous comments.

Quoted 8 lines · Yuteng Zhong
Quoted 5 lines

from: DHDAXCW <[email protected]>

LubanCat 1 is a Rockchip RK3566 SBC based
is developed by EmbedFire Electronics Co., Ltd. Mini Linux Card Type Cheap Computer Development Board

Quoted 8 lines

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them.

Thank you.

Your pervious comment were:

Quoted 3 lines

Please wrap commit message according to Linux coding style / submission process:
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586

So I think there must be something wrong in the message but I didn't notice. This message has a from line, and the body was wrapped at 75 columns. Please help me make it better.

Quoted 15 lines
Quoted 15 lines
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +0 -0
index 88ff4422a8c1..84d39a3a8843 100644
@@ -781,6 +781,11 @@ properties:
           - const: rockchip,rk3568-bpi-r2pro
           - const: rockchip,rk3568
 
Quoted 11 lines
Quoted 6 lines

Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 787

Quoted 4 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +4 -0
+      - description: EmbedFire LubanCat 1
+        items:
+          - const: embedfire,lubancat-1
+          - const: rockchip,rk3566

Here as well.

This change was addressing the previous comment in V2:

Quoted 2 lines

This is separate patch. Does not look like properly ordered. Don't add stuff at the end of files/lists.

for context sorting order in that file is alphabetical by description

Heiko

author
#6 lore raw

Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

Hi, Kozlowski and Stübner,

Thank you very much for pointing me in the right direction.

Quoted 5 lines

So how did you solve the comment "Does not look like properly ordered. Don't add stuff at the end of files/lists."? What did you change to solve it?

for context sorting order in that file is alphabetical by description

I finally got it. It should be put right after the "Elgin RV1108 R1".

Quoted 2 lines

You do not wrap at 75, but at some other place. Just put it to editor and check where is wrapping (count characters).

The original message was:

Quoted 8 lines

from: DHDAXCW <[email protected]>

LubanCat 1 is a Rockchip RK3566 SBC based
is developed by EmbedFire Electronics Co., Ltd. Mini Linux Card Type Cheap Computer Development Board

The longest line is "Mini Linux Card Type Cheap Computer Development Board", which has 53 characters. Or ... I should use the whole line as much as possible? Then I see why I was doing wrong. It will be fixed in the PATCH v5.

#7 lore raw

Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

Quoted 23 lines · ty

Hi, Kozlowski and Stübner,

Thank you very much for pointing me in the right direction.

Quoted 5 lines

So how did you solve the comment "Does not look like properly ordered. Don't add stuff at the end of files/lists."? What did you change to solve it?

for context sorting order in that file is alphabetical by description

I finally got it. It should be put right after the "Elgin RV1108 R1".

Quoted 2 lines

You do not wrap at 75, but at some other place. Just put it to editor and check where is wrapping (count characters).

The original message was:

Quoted 6 lines

from: DHDAXCW <[email protected]>

LubanCat 1 is a Rockchip RK3566 SBC based
is developed by EmbedFire Electronics Co., Ltd. Mini Linux Card Type Cheap Computer Development Board

Quoted 7 lines
Quoted 2 lines

The longest line is "Mini Linux Card Type Cheap Computer Development Board", which has 53 characters. Or ... I should use the whole line as much as possible? Then I see why I was doing wrong. It will be fixed in the PATCH v5.

Yes,
because
such
commit
msg
is
also
within
75
characters
but
it
is
not
correct,
right?

Best regards,
Krzysztof

#8 lore raw
In reply to Yuteng Zhong
Quoted 124 lines · Yuteng Zhong

from: DHDAXCW <[email protected]>

LubanCat 1 is a Rockchip RK3566 SBC based
is developed by EmbedFire Electronics Co., Ltd. Mini Linux Card Type Cheap Computer Development Board

It has the following characteristics:
- MicroSD card slot, onboard eMMC flash memory
- 1GbE Realtek RTL8211F Ethernet Transceiver
- 1 USB Type-C port (power and USB2.0 OTG)
- 1 USB 3.0 Host port
- 3 USB 2.0 Host ports
- 1 HDMI
- 1 infrared receiver
- 1 MIPI DSI
- 1 MIPI CSI
- 1 x 4-section headphone jack
- Mini PCIe socket (USB or PCIe)
- 1 SIM Card slot
- 1 SYS LED and 1 PWR LED
- 40-pin GPIO expansion header

---

Changed in V2:
- Remove RNG node
Changed in V3:
- Sent E-mail with a wrong attachment
Changed in V4:
- Modify all node names

---
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3566-lubancat-1.dts   | 598 ++++++++++++++++++
 2 files changed, 599 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index 0a76a2ebb5f6..e52bda04d45a 100644
@@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-blade.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-model-a.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtb
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +67 -0
new file mode 100644
index 000000000000..443fcfabbd16
@@ -0,0 +1,598 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+* Copyright (c) 2021 Rockchip Electronics Co., Ltd.
+*/
+
+/dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/pinctrl/rockchip.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
+#include "rk3566.dtsi"
+
+/ {
+	model = "EmbedFire LubanCat 1";
+	compatible = "embedfire,lubancat-1", "rockchip,rk3566";
+
+	aliases {
+		ethernet0 = &gmac1;
+		mmc0 = &sdmmc0;
+		mmc1 = &sdhci;
+	};
+
+	chosen: chosen {
+		stdout-path = "serial2:1500000n8";
+	};
+
+	gmac1_clkin: external-gmac1-clock {
+		compatible = "fixed-clock";
+		clock-frequency = <125000000>;
+		clock-output-names = "gmac1_clkin";
+		#clock-cells = <0>;
+	};
+	
+	hdmi-con {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi_con_in: endpoint {
+				remote-endpoint = <&hdmi_out_con>;
+			};
+		};
+	};
+
+	gpio-leds {
+		compatible = "gpio-leds";
+
+		sys_led: sys-led {
+			label = "sys_led";
+			linux,default-trigger = "heartbeat";
+			default-state = "on";
+			gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_LOW>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&sys_led_pin>;
+		};
+	};
+
+	usb_5v: usb-5v-regulator {
+		compatible = "regulator-fixed";
+		regulator-name = "usb_5v";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+	};
+
+	vcc5v0_sys: vcc5v0-sys-regulator {

arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts line 77

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +10 -0
+		compatible = "regulator-fixed";
+		regulator-name = "vcc5v0_sys";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		vin-supply = <&usb_5v>;
+	};
+
+	vcc3v3_sys: vcc3v3-sys {

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them.

Thank you.

arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts line 87

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +10 -0
+		compatible = "regulator-fixed";
+		regulator-name = "vcc3v3_sys";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		vin-supply = <&vcc5v0_sys>;
+	};
+
+	vcc3v3_pcie: vcc3v3-pcie-regulator {

Best regards,
Krzysztof

author
#9 lore raw

Dear Kozlowski,

Before making a new PATCH v5 with the whole .dts file, here is a small patch base on the current v4.

This node name was missed in this PATCH.

---

@@ -74,7 +74,7 @@

     vin-supply = <&usb_5v>;
   };

- vcc3v3_sys: vcc3v3-sys {

+ vcc3v3_sys: vcc3v3-sys-regulator {

     compatible = "regulator-fixed";

     regulator-name = "vcc3v3_sys";

     regulator-always-on;
Quoted 161 lines · Krzysztof Kozlowski <[email protected]> 于2022年12月21日周三 16:15写道:
Quoted 124 lines · Yuteng Zhong

from: DHDAXCW <[email protected]>

LubanCat 1 is a Rockchip RK3566 SBC based
is developed by EmbedFire Electronics Co., Ltd. Mini Linux Card Type Cheap Computer Development Board

It has the following characteristics:
- MicroSD card slot, onboard eMMC flash memory
- 1GbE Realtek RTL8211F Ethernet Transceiver
- 1 USB Type-C port (power and USB2.0 OTG)
- 1 USB 3.0 Host port
- 3 USB 2.0 Host ports
- 1 HDMI
- 1 infrared receiver
- 1 MIPI DSI
- 1 MIPI CSI
- 1 x 4-section headphone jack
- Mini PCIe socket (USB or PCIe)
- 1 SIM Card slot
- 1 SYS LED and 1 PWR LED
- 40-pin GPIO expansion header

---

Changed in V2:
- Remove RNG node
Changed in V3:
- Sent E-mail with a wrong attachment
Changed in V4:
- Modify all node names

---
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3566-lubancat-1.dts   | 598 ++++++++++++++++++
 2 files changed, 599 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index 0a76a2ebb5f6..e52bda04d45a 100644
@@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-blade.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-model-a.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtb
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +67 -0
new file mode 100644
index 000000000000..443fcfabbd16
@@ -0,0 +1,598 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+* Copyright (c) 2021 Rockchip Electronics Co., Ltd.
+*/
+
+/dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/pinctrl/rockchip.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
+#include "rk3566.dtsi"
+
+/ {
+     model = "EmbedFire LubanCat 1";
+     compatible = "embedfire,lubancat-1", "rockchip,rk3566";
+
+     aliases {
+             ethernet0 = &gmac1;
+             mmc0 = &sdmmc0;
+             mmc1 = &sdhci;
+     };
+
+     chosen: chosen {
+             stdout-path = "serial2:1500000n8";
+     };
+
+     gmac1_clkin: external-gmac1-clock {
+             compatible = "fixed-clock";
+             clock-frequency = <125000000>;
+             clock-output-names = "gmac1_clkin";
+             #clock-cells = <0>;
+     };
+
+     hdmi-con {
+             compatible = "hdmi-connector";
+             type = "a";
+
+             port {
+                     hdmi_con_in: endpoint {
+                             remote-endpoint = <&hdmi_out_con>;
+                     };
+             };
+     };
+
+     gpio-leds {
+             compatible = "gpio-leds";
+
+             sys_led: sys-led {
+                     label = "sys_led";
+                     linux,default-trigger = "heartbeat";
+                     default-state = "on";
+                     gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_LOW>;
+                     pinctrl-names = "default";
+                     pinctrl-0 = <&sys_led_pin>;
+             };
+     };
+
+     usb_5v: usb-5v-regulator {
+             compatible = "regulator-fixed";
+             regulator-name = "usb_5v";
+             regulator-always-on;
+             regulator-boot-on;
+             regulator-min-microvolt = <5000000>;
+             regulator-max-microvolt = <5000000>;
+     };
+
+     vcc5v0_sys: vcc5v0-sys-regulator {

arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts line 77

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +10 -0
+             compatible = "regulator-fixed";
+             regulator-name = "vcc5v0_sys";
+             regulator-always-on;
+             regulator-boot-on;
+             regulator-min-microvolt = <5000000>;
+             regulator-max-microvolt = <5000000>;
+             vin-supply = <&usb_5v>;
+     };
+
+     vcc3v3_sys: vcc3v3-sys {

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them.

Thank you.

arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts line 87

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts new file +10 -0
+             compatible = "regulator-fixed";
+             regulator-name = "vcc3v3_sys";
+             regulator-always-on;
+             regulator-boot-on;
+             regulator-min-microvolt = <3300000>;
+             regulator-max-microvolt = <3300000>;
+             vin-supply = <&vcc5v0_sys>;
+     };
+
+     vcc3v3_pcie: vcc3v3-pcie-regulator {

Best regards,
Krzysztof

Signature · 3 lines
Y. T. Zhong
Student of The University of Hong Kong, major in Computer Science.
E-mail: [email protected]