staging: most: fix line ending with '('
Subsystems (2)
PATCH v2 1/1 staging: most: fix line ending with '('
Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl
Move the function parameters right after the '(' in the function call line. Align the rest of the parameters to the opening parenthesis.
---
Changes in v2:
- Changed the description
drivers/staging/most/dim2/hal.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/most/dim2/hal.c +2 -3
@@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)dim2_clear_ctr (ctr_addr); } -static void dim2_configure_channel ( -u8 ch_addr,u8 type,u8 is_tx,u16 dbr_address,u16 hw_buffer_size, -u16 packet_length) +static void dim2_configure_channel (u8 ch_addr,u8 type,u8 is_tx,u16 dbr_address, +u16 hw_buffer_size,u16 packet_length) {dim2_configure_cdt (ch_addr, dbr_address, hw_buffer_size, packet_length);dim2_configure_cat (MLB_CAT , ch_addr, type, is_tx ?1 :0 );
--
2.34.1
Quoted 4 lines · Khadija Kamran
Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl
Quoted 9 lines
Move the function parameters right after the '(' in the function call line. Align the rest of the parameters to the opening parenthesis.
Signed-off-by Khadija Kamran <[email protected]>---
Changes in v2:
- Changed the description
No one replied to the v1 of this patch so it's not clear which of the patches should be ignored.
Also you have a couple patches with the same subject and that's against the rules.
regards,
dan carpenter
Quoted 11 lines · Dan Carpenter
Quoted 10 lines · Khadija Kamran
Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl
Move the function parameters right after the '(' in the function call line. Align the rest of the parameters to the opening parenthesis.
Signed-off-by Khadija Kamran <[email protected]>---
Quoted 7 lines
Quoted 3 lines
Changes in v2:
- Changed the descriptionNo one replied to the v1 of this patch so it's not clear which of the patches should be ignored.
Hey Dan!
I created a patch revision without any feedback. My bad. I thought the description in the previous patch was misleading, so I wanted to change it.
Quoted 3 lines
Also you have a couple patches with the same subject and that's against the rules.
I am sorry about that. Kindly guide me here.
Both patches are for same driver i.e. staging/most, but for different files. Would it be fine to add file names in the subject to differentiate them?
Regards,
Khadija
Quoted 3 lines
regards,
dan carpenter
Quoted 20 lines · Khadija Kamran
Quoted 11 lines · Dan Carpenter
Quoted 10 lines · Khadija Kamran
Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl
Move the function parameters right after the '(' in the function call line. Align the rest of the parameters to the opening parenthesis.
Signed-off-by Khadija Kamran <[email protected]>---
Quoted 7 lines
Quoted 3 lines
Changes in v2:
- Changed the descriptionNo one replied to the v1 of this patch so it's not clear which of the patches should be ignored.
Quoted 5 lines
Hey Dan!
I created a patch revision without any feedback. My bad. I thought the description in the previous patch was misleading, so I wanted to change it.
Yeah. But you have to reply to the other email. Otherwise how will we know there was a response to it?
Quoted 10 lines
Quoted 4 lines
Also you have a couple patches with the same subject and that's against the rules.
I am sorry about that. Kindly guide me here.
Both patches are for same driver i.e. staging/most, but for different files. Would it be fine to add file names in the subject to differentiate them?
I trust you. Figure out a way. ;)
regards,
dan carpenter
Quoted 21 lines · Dan Carpenter
Quoted 20 lines · Khadija Kamran
Quoted 18 lines · Dan Carpenter
Quoted 4 lines · Khadija Kamran
Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl
Quoted 9 lines
Move the function parameters right after the '(' in the function call line. Align the rest of the parameters to the opening parenthesis.
Signed-off-by Khadija Kamran <[email protected]>---
Changes in v2:
- Changed the descriptionNo one replied to the v1 of this patch so it's not clear which of the patches should be ignored.
Quoted 9 lines
Quoted 5 lines
Hey Dan!
I created a patch revision without any feedback. My bad. I thought the description in the previous patch was misleading, so I wanted to change it.
Yeah. But you have to reply to the other email. Otherwise how will we know there was a response to it?
Hey Dan,
I will keep that in mind next time.
Sorry about this.
Regards,
Khadija
Quoted 16 lines
Quoted 10 lines
Quoted 4 lines
Also you have a couple patches with the same subject and that's against the rules.
I am sorry about that. Kindly guide me here.
Both patches are for same driver i.e. staging/most, but for different files. Would it be fine to add file names in the subject to differentiate them?I trust you. Figure out a way. ;)
regards,
dan carpenter
Hi--
Quoted 3 lines · Khadija Kamran
Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl
Note that checkpatch is not always correct. It's a simple advisor.
Quoted 2 lines
Move the function parameters right after the '(' in the function call line. Align the rest of the parameters to the opening parenthesis.
coding-style.rst does indeed say:
A very commonly used style
is to align descendants to a function open parenthesis.
That may be poorly worded. What it is trying to say is to align the rest of the parameters to the first parameter immediately after the open parenthesis, like this example from kernel/fork.c:
stack = __vmalloc_node_range(THREAD_SIZE, THREAD_ALIGN,
VMALLOC_START, VMALLOC_END, THREADINFO_GFP & ~__GFP_ACCOUNT, PAGE_KERNEL,
0, node, __builtin_return_address(0));
And FTR, I still haven't found anything in coding-style.rst that says that lines should not end with an open parenthesis. Did I overlook it?
Thanks.
Quoted 28 lines
Signed-off-by Khadija Kamran <[email protected]>---
Changes in v2:
- Changed the descriptiondrivers/staging/most/dim2/hal.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/staging/most/dim2/hal.c +2
-4@@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)dim2_clear_ctr (ctr_addr); } -static void dim2_configure_channel ( -u8 ch_addr,u8 type,u8 is_tx,u16 dbr_address,u16 hw_buffer_size, -u16 packet_length) +static void dim2_configure_channel (u8 ch_addr,u8 type,u8 is_tx,u16 dbr_address, +u16 hw_buffer_size,u16 packet_length) {dim2_configure_cdt (ch_addr, dbr_address, hw_buffer_size, packet_length);dim2_configure_cat (MLB_CAT , ch_addr, type, is_tx ?1 :0 ); --2.34.1
Signature · 1 line
~Randy
Quoted 4 lines · Randy Dunlap
Hi--
And FTR, I still haven't found anything in
coding-style.rstthat says that lines should not end with an open parenthesis. Did I overlook it?
Hi Randy,
You are correct. I did not find anything clear or obvious that calls out not ending the lines with a '(' symbol.
I think the other guideline from the coding style is to align the overrunning argument list in the next lines such that they match the arg1 after '('. So, I think that may be the reason why checkpatch is coded to catch such lines.
Regards,
Deepak.
Quoted 2 lines
Thanks.