x86/vmware: use unsigned integer for shifting
Subsystems (3)
PATCH v2 1/1 x86/vmware: use unsigned integer for shifting
From: Shreenidhi Shedi <[email protected]>
From: Shreenidhi Shedi <[email protected]>
Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. Using unsigned is better option for this.
--- arch/x86/kernel/cpu/vmware.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/vmware.c +3 -2
@@ -28,6 +28,7 @@#include <linux/cpu.h> #include <linux/reboot.h> #include <linux/static_call.h> +#include <linux/bits.h> #include <asm/div64.h> #include <asm/x86_init.h> #include <asm/hypervisor.h>
@@ -476,8 +477,8 @@ static bool __init vmware_legacy_x2apic_available(void) {uint32_t eax, ebx, ecx, edx;VMWARE_CMD (GETVCPU_INFO , eax, ebx, ecx, edx); -return (eax & (1 <<VMWARE_CMD_VCPU_RESERVED )) ==0 && - (eax & (1 <<VMWARE_CMD_LEGACY_X2APIC )) !=0 ; +return !(eax &BIT (VMWARE_CMD_VCPU_RESERVED )) && + (eax & BIT(VMWARE_CMD_LEGACY_X2APIC)) }#ifdef CONFIG_AMD_MEM_ENCRYPT
Signature · 1 line
2.36.1
Quoted 27 lines · Shreenidhi Shedi
From: Shreenidhi Shedi <[email protected]>
From: Shreenidhi Shedi <[email protected]>
Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. Using unsigned is better option for this.
Fixes 4cca6ea04d31 ("x86/apic: Allow x2apic without IR on VMware platform")Signed-off-by Shreenidhi Shedi <[email protected]>--- arch/x86/kernel/cpu/vmware.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)arch/x86/kernel/cpu/vmware.c +1
-0@@ -28,6 +28,7 @@#include <linux/cpu.h> #include <linux/reboot.h> #include <linux/static_call.h> +#include <linux/bits.h> #include <asm/div64.h> #include <asm/x86_init.h> #include <asm/hypervisor.h>
arch/x86/kernel/cpu/vmware.c static bool __init vmware_legacy_x2apic_available(void) · line 481
Quoted 7 lines
arch/x86/kernel/cpu/vmware.c +2
-2@@ -476,8 +477,8 @@ static bool __init vmware_legacy_x2apic_available(void) {uint32_t eax, ebx, ecx, edx;VMWARE_CMD (GETVCPU_INFO , eax, ebx, ecx, edx); -return (eax & (1 <<VMWARE_CMD_VCPU_RESERVED )) ==0 && - (eax & (1 <<VMWARE_CMD_LEGACY_X2APIC )) !=0 ; +return !(eax &BIT (VMWARE_CMD_VCPU_RESERVED )) && + (eax &BIT (VMWARE_CMD_LEGACY_X2APIC ))
This patch has clearly not been tested, and not even compiled! (It is missing a semicolon at the end of the return statement).
Please take your time to revise and test your patch based on the review feedback; there is no hurry! :)
(Also, while at it, the double From: at the beginning of the patch needs to be fixed too).
Regards,
Srivatsa
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 3 lines · Shreenidhi Shedi
From: Shreenidhi Shedi <[email protected]>
From: Shreenidhi Shedi <[email protected]>
Can you please decide which of your personalities wrote that patch?
Quoted 2 lines
Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. Using unsigned is better option for this.
Better option? There are no options. It's either correct or not. Please be precise and technical in your wording.
Quoted 3 lines
Fixes 4cca6ea04d31 ("x86/apic: Allow x2apic without IR on VMware platform")Signed-off-by Shreenidhi Shedi <[email protected]>
Please keep the tags together. This extra new line is pointless and makes the maintainer do extra work to remove it.
Documentation/process/* has all the relevant directives for you. Following them is not an option. It's mandatory.
arch/x86/kernel/cpu/vmware.c static bool __init vmware_legacy_x2apic_available(void) · line 481
Quoted 8 lines
arch/x86/kernel/cpu/vmware.c +2
-2@@ -476,8 +477,8 @@ static bool __init vmware_legacy_x2apic_available(void) {uint32_t eax, ebx, ecx, edx;VMWARE_CMD (GETVCPU_INFO , eax, ebx, ecx, edx); -return (eax & (1 <<VMWARE_CMD_VCPU_RESERVED )) ==0 && - (eax & (1 <<VMWARE_CMD_LEGACY_X2APIC )) !=0 ; +return !(eax &BIT (VMWARE_CMD_VCPU_RESERVED )) && + (eax &BIT (VMWARE_CMD_LEGACY_X2APIC ))
Testing your changes before submission is not optional either. How is this supposed to compile?
Thanks,
tglx
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization