Skip to contentSkip to conversation

GCOV: Add config to check the preqequisites situation

PATCH Superseded [email protected] 2 participants 3 messages Jun 18, 2020 – Jul 23, 2020 1 message not in the archive

Subsystems (2)

v6 of 8 Superseded Latest is v8 →

lore
Share & tools
lore
#0 lore raw

PATCH v6 1/1 GCOV: Add config to check the preqequisites situation

From: Cixi Geng <[email protected]>

Introduce new configuration option GCOV_PROFILE_PREREQS that can be used to check whether the prerequisites for enabling gcov profiling for specific files and directories are met.

Only add SERIAL_GCOV for an example.

---
 drivers/tty/serial/Kconfig  |  7 +++++++
 drivers/tty/serial/Makefile |  1 +
 kernel/gcov/Kconfig         | 10 ++++++++++
 3 files changed, 18 insertions(+)
drivers/tty/serial/Kconfig +7 -0
index adf9e80e7dc9..6df002370f18 100644
@@ -1566,3 +1566,10 @@ endmenu
 
 config SERIAL_MCTRL_GPIO
 	tristate
+
+config SERIAL_GCOV
+	bool "Enable profile gcov for serial directory"
+	depends on GCOV_PROFILE_PREREQS
+	help
+	  The SERIAL_GCOV will add Gcov profiling flags when kernel compiles.
+	  Say 'Y' here if you want the gcov data for the serial directory,
drivers/tty/serial/Makefile +1 -0
index d056ee6cca33..17272733db95 100644
@@ -3,6 +3,7 @@
 # Makefile for the kernel serial device drivers.
 #
 
+GCOV_PROFILE := $(CONFIG_SERIAL_GCOV)
 obj-$(CONFIG_SERIAL_CORE) += serial_core.o
 
 obj-$(CONFIG_SERIAL_EARLYCON) += earlycon.o
kernel/gcov/Kconfig +10 -0
index 3941a9c48f83..f415c4aaf0ab 100644
@@ -51,6 +51,16 @@ config GCOV_PROFILE_ALL
 	larger and run slower. Also be sure to exclude files from profiling
 	which are not linked to the kernel image to prevent linker errors.
 
+config GCOV_PROFILE_PREREQS
+	bool "Profile Kernel for prereqs"
+	default y if GCOV_KERNEL && !COMPILE_TEST
+	help
+	  This options activates profiling for the specified kernel modules.
+
+	  When some modules need Gcov data, enable this config, then configure
+	  with gcov on the corresponding modules,The directories or files of
+	  these modules will be added profiling flags after kernel compile.
+
 choice
 	prompt "Specify GCOV format"
 	depends on GCOV_KERNEL
Signature · 1 line
2.17.1

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#2 lore raw

Hi All:
Does this patch need more modification?

Quoted 71 lines

发件人: [email protected] <[email protected]>
发送时间: 2020年6月18日 18:08
收件人: [email protected]; [email protected]; [email protected]; [email protected]; [email protected] 抄送: [email protected]; [email protected]; 耿慈熙 (Cixi Geng/10039)
主题: [PATCH V6] GCOV: Add config to check the preqequisites situation

From: Cixi Geng <[email protected]>

Introduce new configuration option GCOV_PROFILE_PREREQS that can be used to check whether the prerequisites for enabling gcov profiling for specific files and directories are met.

Only add SERIAL_GCOV for an example.

---
 drivers/tty/serial/Kconfig  |  7 +++++++
 drivers/tty/serial/Makefile |  1 +
 kernel/gcov/Kconfig         | 10 ++++++++++
 3 files changed, 18 insertions(+)
drivers/tty/serial/Kconfig +7 -0
index adf9e80e7dc9..6df002370f18 100644
@@ -1566,3 +1566,10 @@ endmenu
 
 config SERIAL_MCTRL_GPIO
        tristate
+
+config SERIAL_GCOV
+       bool "Enable profile gcov for serial directory"
+       depends on GCOV_PROFILE_PREREQS
+       help
+         The SERIAL_GCOV will add Gcov profiling flags when kernel compiles.
+         Say 'Y' here if you want the gcov data for the serial directory,
drivers/tty/serial/Makefile +1 -0
index d056ee6cca33..17272733db95 100644
@@ -3,6 +3,7 @@
 # Makefile for the kernel serial device drivers.
 #
 
+GCOV_PROFILE := $(CONFIG_SERIAL_GCOV)
 obj-$(CONFIG_SERIAL_CORE) += serial_core.o
 
 obj-$(CONFIG_SERIAL_EARLYCON) += earlycon.o
kernel/gcov/Kconfig +10 -1
index 3941a9c48f83..f415c4aaf0ab 100644
@@ -51,6 +51,16 @@ config GCOV_PROFILE_ALL
        larger and run slower. Also be sure to exclude files from profiling
        which are not linked to the kernel image to prevent linker errors.
 
+config GCOV_PROFILE_PREREQS
+       bool "Profile Kernel for prereqs"
+       default y if GCOV_KERNEL && !COMPILE_TEST
+       help
+         This options activates profiling for the specified kernel modules.
+
+         When some modules need Gcov data, enable this config, then configure
+         with gcov on the corresponding modules,The directories or files of
+         these modules will be added profiling flags after kernel compile.
+
 choice
        prompt "Specify GCOV format"
        depends on GCOV_KERNEL
--

2.17.1

#3 lore raw
Quoted 2 lines · Cixi Geng

Hi All:
Does this patch need more modification?

Yes. As it is now there's still a prompt for the prereq symbol. There should be no prompt for this symbol in the config dialog.

[...]

Quoted 8 lines
Quoted 8 lines
kernel/gcov/Kconfig +0 -0
index 3941a9c48f83..f415c4aaf0ab 100644
@@ -51,6 +51,16 @@ config GCOV_PROFILE_ALL
        larger and run slower. Also be sure to exclude files from profiling
        which are not linked to the kernel image to prevent linker errors.
 
Quoted 10 lines

kernel/gcov/Kconfig config GCOV_PROFILE_ALL · line 63

Quoted 10 lines
kernel/gcov/Kconfig +10 -0
+config GCOV_PROFILE_PREREQS
+       bool "Profile Kernel for prereqs"
+       default y if GCOV_KERNEL && !COMPILE_TEST
+       help
+         This options activates profiling for the specified kernel modules.
+
+         When some modules need Gcov data, enable this config, then configure
+         with gcov on the corresponding modules,The directories or files of
+         these modules will be added profiling flags after kernel compile.
+

Replace the portion above with these lines:

config GCOV_PROFILE_PREREQS

        def_bool y if GCOV_KERNEL && !COMPILE_TEST
Signature · 2 lines
Peter Oberparleiter
Linux on Z Development - IBM Germany