ramfb: Add property to control if load the romfile
v4 cover ramfb: Add property to control if load the romfile
Now the ramfb will load the vgabios-ramfb.bin unconditionally, but only the x86 need the vgabios-ramfb.bin, this can cause that when use the release package on arm64 it can't find the vgabios-ramfb.bin.
Because only seabios will use the vgabios-ramfb.bin, load the rom logic is x86-specific. For other !x86 platforms, the edk2 ships an EFI driver for ramfb, so they don't need to load the romfile.
So add a new property use_legacy_x86_rom in both ramfb and vfio_pci device, because the vfio display also use the ramfb_setup() to load the vgabios-ramfb.bin file.
After have this property, the machine type can set the compatibility to not load the vgabios-ramfb.bin if the arch doesn't need it.
Then I set the use_legacy_x86_rom property to false by default, and only set it to true on x86 since only x86 will need it.
Changelog:
---------
v3 -> v4:
- Set the new property to false by default, only set it to true on x86.
v2 -> v3:
- Fix the underscore error.
- Add a new patch to set the property in arm compatibility.
v1 -> v2:
- Change the property name.
v3: https://lore.kernel.org/all/[email protected]/
v2: https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/
Shaoqin Huang (2):
ramfb: Add property to control if load the romfile hw/i386: Add the ramfb romfile compatatibility
hw/display/ramfb-standalone.c | 4 +++- hw/display/ramfb-stubs.c | 2 +- hw/display/ramfb.c | 6 ++++-- hw/i386/pc_q35.c | 3 +++ hw/vfio/display.c | 4 ++-- hw/vfio/pci.c | 1 + hw/vfio/pci.h | 1 + include/hw/display/ramfb.h | 2 +- 8 files changed, 16 insertions(+), 7 deletions(-)
Signature · 1 line
2.40.1
PATCH v4 1/2 ramfb: Add property to control if load the romfile
Now the ramfb will load the vgabios-ramfb.bin unconditionally, but only the x86 need the vgabios-ramfb.bin, this can cause that when use the release package on arm64 it can't find the vgabios-ramfb.bin.
Because only seabios will use the vgabios-ramfb.bin, load the rom logic is x86-specific. For other !x86 platforms, the edk2 ships an EFI driver for ramfb, so they don't need to load the romfile.
So add a new property use_legacy_x86_rom in both ramfb and vfio_pci device, because the vfio display also use the ramfb_setup() to load the vgabios-ramfb.bin file.
After have this property, the machine type can set the compatibility to not load the vgabios-ramfb.bin if the arch doesn't need it.
--- hw/display/ramfb-standalone.c | 4 +++- hw/display/ramfb-stubs.c | 2 +- hw/display/ramfb.c | 6 ++++-- hw/vfio/display.c | 4 ++-- hw/vfio/pci.c | 1 + hw/vfio/pci.h | 1 + include/hw/display/ramfb.h | 2 +- 7 files changed, 13 insertions(+), 7 deletions(-)
hw/display/ramfb-standalone.c +3 -1
@@ -17,6 +17,7 @@ struct RAMFBStandaloneState {QemuConsole *con;RAMFBState *state;bool migrate; +bool use_legacy_x86_rom; };static void display_update_wrapper (void *dev)
@@ -39,7 +40,7 @@ static void ramfb_realizefn(DeviceState *dev, Error **errp)RAMFBStandaloneState *ramfb =RAMFB (dev); ramfb->con =graphic_console_init (dev,0 , &wrapper_ops, dev); - ramfb->state =ramfb_setup (errp); + ramfb->state =ramfb_setup (ramfb->use_legacy_x86_rom, errp); }static bool migrate_needed (void *opaque)
@@ -62,6 +63,7 @@ static const VMStateDescription ramfb_dev_vmstate = {static const Property ramfb_properties[] = {DEFINE_PROP_BOOL ("x-migrate" , RAMFBStandaloneState, migrate, true), +DEFINE_PROP_BOOL ("use-legacy-x86-rom" , RAMFBStandaloneState, use_legacy_x86_rom, true), };static void ramfb_class_initfn (ObjectClass *klass,void *data)
hw/display/ramfb-stubs.c +1 -1
@@ -8,7 +8,7 @@ void ramfb_display_update(QemuConsole *con, RAMFBState *s) { } -RAMFBState *ramfb_setup (Error **errp) +RAMFBState *ramfb_setup (bool romfile,Error **errp) {error_setg (errp,"ramfb support not available" );return NULL ;
hw/display/ramfb.c +4 -2
@@ -135,7 +135,7 @@ const VMStateDescription ramfb_vmstate = { } }; -RAMFBState *ramfb_setup (Error **errp) +RAMFBState *ramfb_setup (bool romfile,Error **errp) {FWCfgState *fw_cfg =fw_cfg_find ();RAMFBState *s;
@@ -147,7 +147,9 @@ RAMFBState *ramfb_setup(Error **errp) s =g_new0 (RAMFBState,1 ); -rom_add_vga ("vgabios-ramfb.bin" ); +if (romfile) { +rom_add_vga ("vgabios-ramfb.bin" ); + }fw_cfg_add_file_callback (fw_cfg,"etc/ramfb" ,NULL , ramfb_fw_cfg_write, s, &s->cfg,sizeof (s->cfg), false);
hw/vfio/display.c +2 -2
@@ -365,7 +365,7 @@ static bool vfio_display_dmabuf_init(VFIOPCIDevice *vdev, Error **errp) &vfio_display_dmabuf_ops, vdev);if (vdev->enable_ramfb) { - vdev->dpy->ramfb =ramfb_setup (errp); + vdev->dpy->ramfb =ramfb_setup (vdev->use_legacy_x86_rom, errp);if (!vdev->dpy->ramfb) {return false; }
@@ -494,7 +494,7 @@ static bool vfio_display_region_init(VFIOPCIDevice *vdev, Error **errp) &vfio_display_region_ops, vdev);if (vdev->enable_ramfb) { - vdev->dpy->ramfb =ramfb_setup (errp); + vdev->dpy->ramfb =ramfb_setup (vdev->use_legacy_x86_rom, errp);if (!vdev->dpy->ramfb) {return false; }
hw/vfio/pci.c +1 -0
@@ -3564,6 +3564,7 @@ static const TypeInfo vfio_pci_dev_info = {static const Property vfio_pci_dev_nohotplug_properties[] = {DEFINE_PROP_BOOL ("ramfb" , VFIOPCIDevice, enable_ramfb, false), +DEFINE_PROP_BOOL ("use-legacy-x86-rom" , VFIOPCIDevice, use_legacy_x86_rom, true),DEFINE_PROP_ON_OFF_AUTO ("x-ramfb-migrate" , VFIOPCIDevice, ramfb_migrate,ON_OFF_AUTO_AUTO ), };
hw/vfio/pci.h +1 -0
@@ -177,6 +177,7 @@ struct VFIOPCIDevice {bool no_kvm_ioeventfd;bool no_vfio_ioeventfd;bool enable_ramfb; +bool use_legacy_x86_rom;OnOffAuto ramfb_migrate;bool defer_kvm_irq_routing;bool clear_parent_atomics_on_exit;
include/hw/display/ramfb.h +1 -1
@@ -6,7 +6,7 @@/* ramfb.c */ typedef struct RAMFBState RAMFBState ;void ramfb_display_update (QemuConsole *con,RAMFBState *s); -RAMFBState *ramfb_setup (Error **errp); +RAMFBState *ramfb_setup (bool romfile,Error **errp);extern const VMStateDescription ramfb_vmstate;
Signature · 1 line
2.40.1
Hi Shaoqin,
Quoted 1 line · Shaoqin Huang
Now the ramfb will load the vgabios-ramfb.bin unconditionally, but only
Currently the ramfb device loads ...
Quoted 8 lines
the x86 need the vgabios-ramfb.bin, this can cause that when use the release package on arm64 it can't find the vgabios-ramfb.bin.
Because only seabios will use the vgabios-ramfb.bin, load the rom logic is x86-specific. For other !x86 platforms, the edk2 ships an EFI driver for ramfb, so they don't need to load the romfile.
So add a new property
use_legacy_x86_romin both ramfb andvfio_pci
was renamed with - instead of _
Quoted 5 lines
device, because the vfio display also use the
ramfb_setup()to load the vgabios-ramfb.bin file.After have this property, the machine type can set the compatibility to not load the vgabios-ramfb.bin if the arch doesn't need it.
Please add in the commit message that for now the default value is true but it will be turned off by default in subsequent patch when compats get properly handled.
Quoted 129 lines
Signed-off-by Shaoqin Huang <[email protected]>--- hw/display/ramfb-standalone.c | 4 +++- hw/display/ramfb-stubs.c | 2 +- hw/display/ramfb.c | 6 ++++-- hw/vfio/display.c | 4 ++-- hw/vfio/pci.c | 1 + hw/vfio/pci.h | 1 + include/hw/display/ramfb.h | 2 +- 7 files changed, 13 insertions(+), 7 deletions(-)hw/display/ramfb-standalone.c +3
-1@@ -17,6 +17,7 @@ struct RAMFBStandaloneState {QemuConsole *con;RAMFBState *state;bool migrate; +bool use_legacy_x86_rom; };static void display_update_wrapper (void *dev)@@ -39,7 +40,7 @@ static void ramfb_realizefn(DeviceState *dev, Error **errp)RAMFBStandaloneState *ramfb =RAMFB (dev); ramfb->con =graphic_console_init (dev,0 , &wrapper_ops, dev); - ramfb->state =ramfb_setup (errp); + ramfb->state =ramfb_setup (ramfb->use_legacy_x86_rom, errp); }static bool migrate_needed (void *opaque)@@ -62,6 +63,7 @@ static const VMStateDescription ramfb_dev_vmstate = {static const Property ramfb_properties[] = {DEFINE_PROP_BOOL ("x-migrate" , RAMFBStandaloneState, migrate, true), +DEFINE_PROP_BOOL ("use-legacy-x86-rom" , RAMFBStandaloneState, use_legacy_x86_rom, true), };static void ramfb_class_initfn (ObjectClass *klass,void *data)hw/display/ramfb-stubs.c +1
-1@@ -8,7 +8,7 @@ void ramfb_display_update(QemuConsole *con, RAMFBState *s) { } -RAMFBState *ramfb_setup (Error **errp) +RAMFBState *ramfb_setup (bool romfile,Error **errp) {error_setg (errp,"ramfb support not available" );return NULL ;hw/display/ramfb.c +4
-2@@ -135,7 +135,7 @@ const VMStateDescription ramfb_vmstate = { } }; -RAMFBState *ramfb_setup (Error **errp) +RAMFBState *ramfb_setup (bool romfile,Error **errp) {FWCfgState *fw_cfg =fw_cfg_find ();RAMFBState *s;@@ -147,7 +147,9 @@ RAMFBState *ramfb_setup(Error **errp) s =g_new0 (RAMFBState,1 ); -rom_add_vga ("vgabios-ramfb.bin" ); +if (romfile) { +rom_add_vga ("vgabios-ramfb.bin" ); + }fw_cfg_add_file_callback (fw_cfg,"etc/ramfb" ,NULL , ramfb_fw_cfg_write, s, &s->cfg,sizeof (s->cfg), false);hw/vfio/display.c +2
-2@@ -365,7 +365,7 @@ static bool vfio_display_dmabuf_init(VFIOPCIDevice *vdev, Error **errp) &vfio_display_dmabuf_ops, vdev);if (vdev->enable_ramfb) { - vdev->dpy->ramfb =ramfb_setup (errp); + vdev->dpy->ramfb =ramfb_setup (vdev->use_legacy_x86_rom, errp);if (!vdev->dpy->ramfb) {return false; }@@ -494,7 +494,7 @@ static bool vfio_display_region_init(VFIOPCIDevice *vdev, Error **errp) &vfio_display_region_ops, vdev);if (vdev->enable_ramfb) { - vdev->dpy->ramfb =ramfb_setup (errp); + vdev->dpy->ramfb =ramfb_setup (vdev->use_legacy_x86_rom, errp);if (!vdev->dpy->ramfb) {return false; }hw/vfio/pci.c +1
-0@@ -3564,6 +3564,7 @@ static const TypeInfo vfio_pci_dev_info = {static const Property vfio_pci_dev_nohotplug_properties[] = {DEFINE_PROP_BOOL ("ramfb" , VFIOPCIDevice, enable_ramfb, false), +DEFINE_PROP_BOOL ("use-legacy-x86-rom" , VFIOPCIDevice, use_legacy_x86_rom, true),DEFINE_PROP_ON_OFF_AUTO ("x-ramfb-migrate" , VFIOPCIDevice, ramfb_migrate,ON_OFF_AUTO_AUTO ), };hw/vfio/pci.h +1
-0@@ -177,6 +177,7 @@ struct VFIOPCIDevice {bool no_kvm_ioeventfd;bool no_vfio_ioeventfd;bool enable_ramfb; +bool use_legacy_x86_rom;OnOffAuto ramfb_migrate;bool defer_kvm_irq_routing;bool clear_parent_atomics_on_exit;include/hw/display/ramfb.h +0
-0
include/hw/display/ramfb.h line 12
Quoted 8 lines
include/hw/display/ramfb.h +1
-1@@ -6,7 +6,7 @@/* ramfb.c */ typedef struct RAMFBState RAMFBState ;void ramfb_display_update (QemuConsole *con,RAMFBState *s); -RAMFBState *ramfb_setup (Error **errp); +RAMFBState *ramfb_setup (bool romfile,Error **errp);extern const VMStateDescription ramfb_vmstate;
Thanks
Eric
Hi Eric,
Quoted 4 lines · Eric Auger
Hi Shaoqin,
Quoted 1 line · Shaoqin Huang
Now the ramfb will load the vgabios-ramfb.bin unconditionally, but only
Currently the ramfb device loads ...
Ok, will change it.
Quoted 9 lines
Quoted 8 lines
the x86 need the vgabios-ramfb.bin, this can cause that when use the release package on arm64 it can't find the vgabios-ramfb.bin.
Because only seabios will use the vgabios-ramfb.bin, load the rom logic is x86-specific. For other !x86 platforms, the edk2 ships an EFI driver for ramfb, so they don't need to load the romfile.
So add a new property
use_legacy_x86_romin both ramfb andvfio_pciwas renamed with - instead of _
Ok, will fix it.
Quoted 9 lines
Quoted 5 lines
device, because the vfio display also use the
ramfb_setup()to load the vgabios-ramfb.bin file.After have this property, the machine type can set the compatibility to not load the vgabios-ramfb.bin if the arch doesn't need it.
Please add in the commit message that for now the default value is true but it will be turned off by default in subsequent patch when compats get properly handled.
Got it.
Thanks.
Quoted 141 lines
Quoted 129 lines
Signed-off-by Shaoqin Huang <[email protected]>--- hw/display/ramfb-standalone.c | 4 +++- hw/display/ramfb-stubs.c | 2 +- hw/display/ramfb.c | 6 ++++-- hw/vfio/display.c | 4 ++-- hw/vfio/pci.c | 1 + hw/vfio/pci.h | 1 + include/hw/display/ramfb.h | 2 +- 7 files changed, 13 insertions(+), 7 deletions(-)hw/display/ramfb-standalone.c +3
-1@@ -17,6 +17,7 @@ struct RAMFBStandaloneState {QemuConsole *con;RAMFBState *state;bool migrate; +bool use_legacy_x86_rom; };static void display_update_wrapper (void *dev)@@ -39,7 +40,7 @@ static void ramfb_realizefn(DeviceState *dev, Error **errp)RAMFBStandaloneState *ramfb =RAMFB (dev); ramfb->con =graphic_console_init (dev,0 , &wrapper_ops, dev); - ramfb->state =ramfb_setup (errp); + ramfb->state =ramfb_setup (ramfb->use_legacy_x86_rom, errp); }static bool migrate_needed (void *opaque)@@ -62,6 +63,7 @@ static const VMStateDescription ramfb_dev_vmstate = {static const Property ramfb_properties[] = {DEFINE_PROP_BOOL ("x-migrate" , RAMFBStandaloneState, migrate, true), +DEFINE_PROP_BOOL ("use-legacy-x86-rom" , RAMFBStandaloneState, use_legacy_x86_rom, true), };static void ramfb_class_initfn (ObjectClass *klass,void *data)hw/display/ramfb-stubs.c +1
-1@@ -8,7 +8,7 @@ void ramfb_display_update(QemuConsole *con, RAMFBState *s) { } -RAMFBState *ramfb_setup (Error **errp) +RAMFBState *ramfb_setup (bool romfile,Error **errp) {error_setg (errp,"ramfb support not available" );return NULL ;hw/display/ramfb.c +4
-2@@ -135,7 +135,7 @@ const VMStateDescription ramfb_vmstate = { } }; -RAMFBState *ramfb_setup (Error **errp) +RAMFBState *ramfb_setup (bool romfile,Error **errp) {FWCfgState *fw_cfg =fw_cfg_find ();RAMFBState *s;@@ -147,7 +147,9 @@ RAMFBState *ramfb_setup(Error **errp) s =g_new0 (RAMFBState,1 ); -rom_add_vga ("vgabios-ramfb.bin" ); +if (romfile) { +rom_add_vga ("vgabios-ramfb.bin" ); + }fw_cfg_add_file_callback (fw_cfg,"etc/ramfb" ,NULL , ramfb_fw_cfg_write, s, &s->cfg,sizeof (s->cfg), false);hw/vfio/display.c +2
-2@@ -365,7 +365,7 @@ static bool vfio_display_dmabuf_init(VFIOPCIDevice *vdev, Error **errp) &vfio_display_dmabuf_ops, vdev);if (vdev->enable_ramfb) { - vdev->dpy->ramfb =ramfb_setup (errp); + vdev->dpy->ramfb =ramfb_setup (vdev->use_legacy_x86_rom, errp);if (!vdev->dpy->ramfb) {return false; }@@ -494,7 +494,7 @@ static bool vfio_display_region_init(VFIOPCIDevice *vdev, Error **errp) &vfio_display_region_ops, vdev);if (vdev->enable_ramfb) { - vdev->dpy->ramfb =ramfb_setup (errp); + vdev->dpy->ramfb =ramfb_setup (vdev->use_legacy_x86_rom, errp);if (!vdev->dpy->ramfb) {return false; }hw/vfio/pci.c +1
-0@@ -3564,6 +3564,7 @@ static const TypeInfo vfio_pci_dev_info = {static const Property vfio_pci_dev_nohotplug_properties[] = {DEFINE_PROP_BOOL ("ramfb" , VFIOPCIDevice, enable_ramfb, false), +DEFINE_PROP_BOOL ("use-legacy-x86-rom" , VFIOPCIDevice, use_legacy_x86_rom, true),DEFINE_PROP_ON_OFF_AUTO ("x-ramfb-migrate" , VFIOPCIDevice, ramfb_migrate,ON_OFF_AUTO_AUTO ), };hw/vfio/pci.h +1
-0@@ -177,6 +177,7 @@ struct VFIOPCIDevice {bool no_kvm_ioeventfd;bool no_vfio_ioeventfd;bool enable_ramfb; +bool use_legacy_x86_rom;OnOffAuto ramfb_migrate;bool defer_kvm_irq_routing;bool clear_parent_atomics_on_exit;include/hw/display/ramfb.h +0
-0include/hw/display/ramfb.h line 12
Quoted 8 lines
include/hw/display/ramfb.h +1
-1@@ -6,7 +6,7 @@/* ramfb.c */ typedef struct RAMFBState RAMFBState ;void ramfb_display_update (QemuConsole *con,RAMFBState *s); -RAMFBState *ramfb_setup (Error **errp); +RAMFBState *ramfb_setup (bool romfile,Error **errp);extern const VMStateDescription ramfb_vmstate;Thanks
Eric
Signature · 1 line
Shaoqin
PATCH v4 2/2 hw/i386: Add the ramfb romfile compatatibility
In reply to Shaoqin HuangSet the "use-legacy-x86-rom" property to false by default, and only set it to true on x86 since only x86 will need it.
--- hw/display/ramfb-standalone.c | 2 +- hw/i386/pc_q35.c | 3 +++ hw/vfio/pci.c | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-)
hw/display/ramfb-standalone.c +1 -1
@@ -63,7 +63,7 @@ static const VMStateDescription ramfb_dev_vmstate = {static const Property ramfb_properties[] = {DEFINE_PROP_BOOL ("x-migrate" , RAMFBStandaloneState, migrate, true), -DEFINE_PROP_BOOL ("use-legacy-x86-rom" , RAMFBStandaloneState, use_legacy_x86_rom, true), +DEFINE_PROP_BOOL ("use-legacy-x86-rom" , RAMFBStandaloneState, use_legacy_x86_rom, false), };static void ramfb_class_initfn (ObjectClass *klass,void *data)
hw/i386/pc_q35.c +3 -0
@@ -45,6 +45,7 @@#include "hw/i386/pc.h" #include "hw/i386/amd_iommu.h" #include "hw/i386/intel_iommu.h" +#include "hw/vfio/pci.h" #include "hw/virtio/virtio-iommu.h" #include "hw/display/ramfb.h" #include "hw/ide/pci.h"
@@ -67,6 +68,8 @@static GlobalProperty pc_q35_compat_defaults[] = { {TYPE_VIRTIO_IOMMU_PCI ,"aw-bits" ,"39" }, + {TYPE_RAMFB_DEVICE ,"use-legacy-x86-rom" ,"true" }, + {TYPE_VFIO_PCI ,"use-legacy-x86-rom" ,"true" }, };static const size_t pc_q35_compat_defaults_len =G_N_ELEMENTS (pc_q35_compat_defaults);
hw/vfio/pci.c +1 -1
@@ -3564,7 +3564,7 @@ static const TypeInfo vfio_pci_dev_info = {static const Property vfio_pci_dev_nohotplug_properties[] = {DEFINE_PROP_BOOL ("ramfb" , VFIOPCIDevice, enable_ramfb, false), -DEFINE_PROP_BOOL ("use-legacy-x86-rom" , VFIOPCIDevice, use_legacy_x86_rom, true), +DEFINE_PROP_BOOL ("use-legacy-x86-rom" , VFIOPCIDevice, use_legacy_x86_rom, false),DEFINE_PROP_ON_OFF_AUTO ("x-ramfb-migrate" , VFIOPCIDevice, ramfb_migrate,ON_OFF_AUTO_AUTO ), };
Signature · 1 line
2.40.1
Re: [PATCH v4 2/2] hw/i386: Add the ramfb romfile compatatibility
Quoted 2 lines · Shaoqin Huang
Set the "use-legacy-x86-rom" property to false by default, and only set it to true on x86 since only x86 will need it.
s/compatatibility/compatibility in the title
Quoted 34 lines
Signed-off-by Shaoqin Huang <[email protected]>--- hw/display/ramfb-standalone.c | 2 +- hw/i386/pc_q35.c | 3 +++ hw/vfio/pci.c | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-)hw/display/ramfb-standalone.c +1
-1@@ -63,7 +63,7 @@ static const VMStateDescription ramfb_dev_vmstate = {static const Property ramfb_properties[] = {DEFINE_PROP_BOOL ("x-migrate" , RAMFBStandaloneState, migrate, true), -DEFINE_PROP_BOOL ("use-legacy-x86-rom" , RAMFBStandaloneState, use_legacy_x86_rom, true), +DEFINE_PROP_BOOL ("use-legacy-x86-rom" , RAMFBStandaloneState, use_legacy_x86_rom, false), };static void ramfb_class_initfn (ObjectClass *klass,void *data)hw/i386/pc_q35.c +1
-0@@ -45,6 +45,7 @@#include "hw/i386/pc.h" #include "hw/i386/amd_iommu.h" #include "hw/i386/intel_iommu.h" +#include "hw/vfio/pci.h" #include "hw/virtio/virtio-iommu.h" #include "hw/display/ramfb.h" #include "hw/ide/pci.h"
hw/i386/pc_q35.c line 72
Quoted 5 lines
hw/i386/pc_q35.c +2
-0@@ -67,6 +68,8 @@static GlobalProperty pc_q35_compat_defaults[] = { {TYPE_VIRTIO_IOMMU_PCI ,"aw-bits" ,"39" }, + {TYPE_RAMFB_DEVICE ,"use-legacy-x86-rom" ,"true" }, + {TYPE_VFIO_PCI ,"use-legacy-x86-rom" ,"true" },
this will only keep the legacy behavior along with q35 machine type but not on other machines being used for x86. what about pc-i440fx? Doesn't it apply to it as well? Are there other machine types also impacted.
Also what about Daniel's comment in v3:
https://lore.kernel.org/all/[email protected]/
"For non-x86, historical versioned machine types will need likely it set to true, in order to avoid the memory layout being changed IIUC."
Is it actually needed?
Thanks
Eric
Quoted 16 lines
hw/i386/pc_q35.c +0
-0};static const size_t pc_q35_compat_defaults_len =G_N_ELEMENTS (pc_q35_compat_defaults);hw/vfio/pci.c +1
-1@@ -3564,7 +3564,7 @@ static const TypeInfo vfio_pci_dev_info = {static const Property vfio_pci_dev_nohotplug_properties[] = {DEFINE_PROP_BOOL ("ramfb" , VFIOPCIDevice, enable_ramfb, false), -DEFINE_PROP_BOOL ("use-legacy-x86-rom" , VFIOPCIDevice, use_legacy_x86_rom, true), +DEFINE_PROP_BOOL ("use-legacy-x86-rom" , VFIOPCIDevice, use_legacy_x86_rom, false),DEFINE_PROP_ON_OFF_AUTO ("x-ramfb-migrate" , VFIOPCIDevice, ramfb_migrate,ON_OFF_AUTO_AUTO ), };
Re: [PATCH v4 2/2] hw/i386: Add the ramfb romfile compatatibility
Hi Eric,
Quoted 6 lines · Eric Auger
Quoted 2 lines · Shaoqin Huang
Set the "use-legacy-x86-rom" property to false by default, and only set it to true on x86 since only x86 will need it.
s/compatatibility/compatibility in the title
Ok. Will fix it.
Quoted 35 lines
Quoted 35 lines
Signed-off-by Shaoqin Huang <[email protected]>--- hw/display/ramfb-standalone.c | 2 +- hw/i386/pc_q35.c | 3 +++ hw/vfio/pci.c | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-)hw/display/ramfb-standalone.c +1
-1@@ -63,7 +63,7 @@ static const VMStateDescription ramfb_dev_vmstate = {static const Property ramfb_properties[] = {DEFINE_PROP_BOOL ("x-migrate" , RAMFBStandaloneState, migrate, true), -DEFINE_PROP_BOOL ("use-legacy-x86-rom" , RAMFBStandaloneState, use_legacy_x86_rom, true), +DEFINE_PROP_BOOL ("use-legacy-x86-rom" , RAMFBStandaloneState, use_legacy_x86_rom, false), };static void ramfb_class_initfn (ObjectClass *klass,void *data)hw/i386/pc_q35.c +1
-0@@ -45,6 +45,7 @@#include "hw/i386/pc.h" #include "hw/i386/amd_iommu.h" #include "hw/i386/intel_iommu.h" +#include "hw/vfio/pci.h" #include "hw/virtio/virtio-iommu.h" #include "hw/display/ramfb.h" #include "hw/ide/pci.h" @@ -67,6 +68,8 @@
Quoted 7 lines
hw/i386/pc_q35.c line 72
Quoted 4 lines
hw/i386/pc_q35.c +2
-0static GlobalProperty pc_q35_compat_defaults[] = { {TYPE_VIRTIO_IOMMU_PCI ,"aw-bits" ,"39" }, + {TYPE_RAMFB_DEVICE ,"use-legacy-x86-rom" ,"true" }, + {TYPE_VFIO_PCI ,"use-legacy-x86-rom" ,"true" },this will only keep the legacy behavior along with q35 machine type but not on other machines being used for x86. what about pc-i440fx? Doesn't it apply to it as well? Are there other machine types also impacted.
Ok I will also add it with pc-i440fx. I think only q35 and i440fx are impacted.
Quoted 8 lines
Also what about Daniel's comment in v3:
https://lore.kernel.org/all/[email protected]/
"For non-x86, historical versioned machine types will need likely it set to true, in order to avoid the memory layout being changed IIUC."Is it actually needed?
If those machine types need to set it to true. I think they can set it after they have this property.
Thanks,
Shaoqin
Quoted 21 lines
Thanks
Eric
Quoted 16 lines
hw/i386/pc_q35.c +0
-0};static const size_t pc_q35_compat_defaults_len =G_N_ELEMENTS (pc_q35_compat_defaults);hw/vfio/pci.c +1
-1@@ -3564,7 +3564,7 @@ static const TypeInfo vfio_pci_dev_info = {static const Property vfio_pci_dev_nohotplug_properties[] = {DEFINE_PROP_BOOL ("ramfb" , VFIOPCIDevice, enable_ramfb, false), -DEFINE_PROP_BOOL ("use-legacy-x86-rom" , VFIOPCIDevice, use_legacy_x86_rom, true), +DEFINE_PROP_BOOL ("use-legacy-x86-rom" , VFIOPCIDevice, use_legacy_x86_rom, false),DEFINE_PROP_ON_OFF_AUTO ("x-ramfb-migrate" , VFIOPCIDevice, ramfb_migrate,ON_OFF_AUTO_AUTO ), };
Signature · 1 line
Shaoqin
Re: [PATCH v4 2/2] hw/i386: Add the ramfb romfile compatatibility
Quoted 66 lines · Shaoqin Huang
Hi Eric,
Quoted 6 lines · Eric Auger
Quoted 2 lines · Shaoqin Huang
Set the "use-legacy-x86-rom" property to false by default, and only set it to true on x86 since only x86 will need it.
s/compatatibility/compatibility in the title
Ok. Will fix it.
Quoted 35 lines
Quoted 35 lines
Signed-off-by Shaoqin Huang <[email protected]>---
hw/display/ramfb-standalone.c| 2 +-
hw/i386/pc_q35.c | 3 +++
hw/vfio/pci.c | 2 +-3 files changed, 5 insertions(+), 2 deletions(-)hw/display/ramfb- renamed from hw/display/ramfb-standalone.c +0
-0
standalone.c
indexaf1175bf96..ddbf42f181100644hw/display/ramfb-standalone.c +1
-1@@ -63,7 +63,7 @@ static const VMStateDescription ramfb_dev_vmstate = { static const Property ramfb_properties[] = { DEFINE_PROP_BOOL("x-migrate", RAMFBStandaloneState, migrate, true), - DEFINE_PROP_BOOL("use-legacy-x86-rom", RAMFBStandaloneState, use_legacy_x86_rom, true), + DEFINE_PROP_BOOL("use-legacy-x86-rom", RAMFBStandaloneState, use_legacy_x86_rom, false), };static void
ramfb_class_initfn(ObjectClass *klass, void *data)hw/i386/pc_q35.c +1
-0@@ -45,6 +45,7 @@ #include "hw/i386/pc.h" #include "hw/i386/amd_iommu.h" #include "hw/i386/intel_iommu.h" +#include "hw/vfio/pci.h" #include "hw/virtio/virtio-iommu.h" #include "hw/display/ramfb.h" #include "hw/ide/pci.h"Quoted 8 lines
hw/i386/pc_q35.c line 71
Quoted 5 lines
hw/i386/pc_q35.c +2
-0@@ -67,6 +68,8 @@ static GlobalProperty pc_q35_compat_defaults[] = { { TYPE_VIRTIO_IOMMU_PCI, "aw-bits", "39" }, + { TYPE_RAMFB_DEVICE, "use-legacy-x86-rom", "true" }, + { TYPE_VFIO_PCI, "use-legacy-x86-rom", "true" },this will only keep the legacy behavior along with q35 machine type but not on other machines being used for x86. what about pc-i440fx? Doesn't it apply to it as well? Are there other machine types also impacted.
Ok I will also add it with pc-i440fx. I think only q35 and i440fx are impacted.
Quoted 7 lines
Also what about Daniel's comment in v3:
https://lore.kernel.org/all/[email protected]/
"For non-x86, historical versioned machine types will need likely it set to true, in order to avoid the memory layout being changed IIUC."
Quoted 4 lines
Quoted 1 line
Is it actually needed?
If those machine types need to set it to true. I think they can set it after they have this property.
nope it does not work like that. In case we really need to take care of this, this must be handled by compats.
Thanks
Eric
Quoted 28 lines
Thanks,
ShaoqinQuoted 23 lines
Thanks
Eric
Quoted 18 lines
hw/i386/pc_q35.c +0
-0};static const
size_tpc_q35_compat_defaults_len=G_N_ELEMENTS(pc_q35_compat_defaults);hw/vfio/pci.c +1
-1@@ -3564,7 +3564,7 @@ static const TypeInfo vfio_pci_dev_info = { static const Property vfio_pci_dev_nohotplug_properties[] = { DEFINE_PROP_BOOL("ramfb", VFIOPCIDevice, enable_ramfb, false), - DEFINE_PROP_BOOL("use-legacy-x86-rom", VFIOPCIDevice, use_legacy_x86_rom, true), + DEFINE_PROP_BOOL("use-legacy-x86-rom", VFIOPCIDevice, use_legacy_x86_rom, false), DEFINE_PROP_ON_OFF_AUTO("x-ramfb-migrate", VFIOPCIDevice, ramfb_migrate,
ON_OFF_AUTO_AUTO),
};
Re: [PATCH v4 2/2] hw/i386: Add the ramfb romfile compatatibility
Hi Eric,
Quoted 69 lines · Eric Auger
Quoted 66 lines · Shaoqin Huang
Hi Eric,
Quoted 6 lines · Eric Auger
Quoted 2 lines · Shaoqin Huang
Set the "use-legacy-x86-rom" property to false by default, and only set it to true on x86 since only x86 will need it.
s/compatatibility/compatibility in the title
Ok. Will fix it.
Quoted 35 lines
Quoted 35 lines
Signed-off-by Shaoqin Huang <[email protected]>--- hw/display/ramfb-standalone.c | 2 +- hw/i386/pc_q35.c | 3 +++ hw/vfio/pci.c | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-)hw/display/ramfb- renamed from hw/display/ramfb-standalone.c +0
-0
standalone.c
indexaf1175bf96..ddbf42f181100644hw/display/ramfb-standalone.c +1
-1@@ -63,7 +63,7 @@ static const VMStateDescription ramfb_dev_vmstate = { static const Property ramfb_properties[] = { DEFINE_PROP_BOOL("x-migrate", RAMFBStandaloneState, migrate, true), - DEFINE_PROP_BOOL("use-legacy-x86-rom", RAMFBStandaloneState, use_legacy_x86_rom, true), + DEFINE_PROP_BOOL("use-legacy-x86-rom", RAMFBStandaloneState, use_legacy_x86_rom, false), };static void
ramfb_class_initfn(ObjectClass *klass, void *data)hw/i386/pc_q35.c +1
-0@@ -45,6 +45,7 @@ #include "hw/i386/pc.h" #include "hw/i386/amd_iommu.h" #include "hw/i386/intel_iommu.h" +#include "hw/vfio/pci.h" #include "hw/virtio/virtio-iommu.h" #include "hw/display/ramfb.h" #include "hw/ide/pci.h"Quoted 8 lines
hw/i386/pc_q35.c line 71
Quoted 5 lines
hw/i386/pc_q35.c +2
-0@@ -67,6 +68,8 @@ static GlobalProperty pc_q35_compat_defaults[] = { { TYPE_VIRTIO_IOMMU_PCI, "aw-bits", "39" }, + { TYPE_RAMFB_DEVICE, "use-legacy-x86-rom", "true" }, + { TYPE_VFIO_PCI, "use-legacy-x86-rom", "true" },this will only keep the legacy behavior along with q35 machine type but not on other machines being used for x86. what about pc-i440fx? Doesn't it apply to it as well? Are there other machine types also impacted.
Ok I will also add it with pc-i440fx. I think only q35 and i440fx are impacted.
Quoted 7 lines
Also what about Daniel's comment in v3:
https://lore.kernel.org/all/[email protected]/
"For non-x86, historical versioned machine types will need likely it set to true, in order to avoid the memory layout being changed IIUC."
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Is it actually needed?
If those machine types need to set it to true. I think they can set it after they have this property.
nope it does not work like that. In case we really need to take care of this, this must be handled by compats.
If so. Why don't we still keep the "use-legacy-x86-rom" default to true, and only set it to false to those arch which doesn't need it just like my original implementation.
Because I don't really know how other arch's memoery layout was impacted by this property set to false. I think keep their original behavior and only change it on arm64 is a good idea.
How do you think about it?
Thanks,
Shaoqin
Quoted 33 lines
Thanks
Eric
Quoted 28 lines
Thanks,
ShaoqinQuoted 23 lines
Thanks
Eric
Quoted 18 lines
hw/i386/pc_q35.c +0
-0}; static const size_t pc_q35_compat_defaults_len = G_N_ELEMENTS(pc_q35_compat_defaults);hw/vfio/pci.c +1
-1@@ -3564,7 +3564,7 @@ static const TypeInfo vfio_pci_dev_info = { static const Property vfio_pci_dev_nohotplug_properties[] = { DEFINE_PROP_BOOL("ramfb", VFIOPCIDevice, enable_ramfb, false), - DEFINE_PROP_BOOL("use-legacy-x86-rom", VFIOPCIDevice, use_legacy_x86_rom, true), + DEFINE_PROP_BOOL("use-legacy-x86-rom", VFIOPCIDevice, use_legacy_x86_rom, false), DEFINE_PROP_ON_OFF_AUTO("x-ramfb-migrate", VFIOPCIDevice, ramfb_migrate,
ON_OFF_AUTO_AUTO),
};
Signature · 1 line
Shaoqin
Re: [PATCH v4 2/2] hw/i386: Add the ramfb romfile compatatibility
Quoted 83 lines · Shaoqin Huang
Hi Eric,
Quoted 69 lines · Eric Auger
Quoted 66 lines · Shaoqin Huang
Hi Eric,
Quoted 6 lines · Eric Auger
Quoted 2 lines · Shaoqin Huang
Set the "use-legacy-x86-rom" property to false by default, and only set it to true on x86 since only x86 will need it.
s/compatatibility/compatibility in the title
Ok. Will fix it.
Quoted 35 lines
Quoted 35 lines
Signed-off-by Shaoqin Huang <[email protected]>--- hw/display/ramfb-standalone.c | 2 +- hw/i386/pc_q35.c | 3 +++ hw/vfio/pci.c | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-)hw/display/ramfb- renamed from hw/display/ramfb-standalone.c +0
-0
standalone.c
indexaf1175bf96..ddbf42f181100644hw/display/ramfb-standalone.c +1
-1@@ -63,7 +63,7 @@ static const VMStateDescription ramfb_dev_vmstate = { static const Property ramfb_properties[] = { DEFINE_PROP_BOOL("x-migrate", RAMFBStandaloneState, migrate, true), - DEFINE_PROP_BOOL("use-legacy-x86-rom", RAMFBStandaloneState, use_legacy_x86_rom, true), + DEFINE_PROP_BOOL("use-legacy-x86-rom", RAMFBStandaloneState, use_legacy_x86_rom, false), };static void
ramfb_class_initfn(ObjectClass *klass, void *data)hw/i386/pc_q35.c +1
-0@@ -45,6 +45,7 @@ #include "hw/i386/pc.h" #include "hw/i386/amd_iommu.h" #include "hw/i386/intel_iommu.h" +#include "hw/vfio/pci.h" #include "hw/virtio/virtio-iommu.h" #include "hw/display/ramfb.h" #include "hw/ide/pci.h"Quoted 8 lines
hw/i386/pc_q35.c line 71
Quoted 5 lines
hw/i386/pc_q35.c +2
-0@@ -67,6 +68,8 @@ static GlobalProperty pc_q35_compat_defaults[] = { { TYPE_VIRTIO_IOMMU_PCI, "aw-bits", "39" }, + { TYPE_RAMFB_DEVICE, "use-legacy-x86-rom", "true" }, + { TYPE_VFIO_PCI, "use-legacy-x86-rom", "true" },this will only keep the legacy behavior along with q35 machine type but not on other machines being used for x86. what about pc-i440fx? Doesn't it apply to it as well? Are there other machine types also impacted.
Ok I will also add it with pc-i440fx. I think only q35 and i440fx are impacted.
Quoted 7 lines
Also what about Daniel's comment in v3:
https://lore.kernel.org/all/[email protected]/
"For non-x86, historical versioned machine types will need likely it set to true, in order to avoid the memory layout being changed IIUC."Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Is it actually needed?
If those machine types need to set it to true. I think they can set it after they have this property.
nope it does not work like that. In case we really need to take care of this, this must be handled by compats.
If so. Why don't we still keep the "use-legacy-x86-rom" default to true, and only set it to false to those arch which doesn't need it just like my original implementation.
Quoted 5 lines
Because I don't really know how other arch's memoery layout was impacted by this property set to false. I think keep their original behavior and only change it on arm64 is a good idea.
How do you think about it?
No, the default value of the property shoudl reflect the long term desired behaviour - in this case 'use-legacy-x86-rom = false'.
We must then reverse this default to 'true' for ALL historical versioned machine types on ALL architectures, where this device is built, or any specific machines where we want to keep the historical behaviour going forward.
With regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Re: [PATCH v4 2/2] hw/i386: Add the ramfb romfile compatatibility
Hi Daniel,
Quoted 84 lines · Daniel P. Berrangé
Quoted 83 lines · Shaoqin Huang
Hi Eric,
Quoted 69 lines · Eric Auger
Quoted 66 lines · Shaoqin Huang
Hi Eric,
Quoted 6 lines · Eric Auger
Quoted 2 lines · Shaoqin Huang
Set the "use-legacy-x86-rom" property to false by default, and only set it to true on x86 since only x86 will need it.
s/compatatibility/compatibility in the title
Ok. Will fix it.
Quoted 35 lines
Quoted 35 lines
Signed-off-by Shaoqin Huang <[email protected]>--- hw/display/ramfb-standalone.c | 2 +- hw/i386/pc_q35.c | 3 +++ hw/vfio/pci.c | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-)hw/display/ramfb- renamed from hw/display/ramfb-standalone.c +0
-0
standalone.c
indexaf1175bf96..ddbf42f181100644hw/display/ramfb-standalone.c +1
-1@@ -63,7 +63,7 @@ static const VMStateDescription ramfb_dev_vmstate = { static const Property ramfb_properties[] = { DEFINE_PROP_BOOL("x-migrate", RAMFBStandaloneState, migrate, true), - DEFINE_PROP_BOOL("use-legacy-x86-rom", RAMFBStandaloneState, use_legacy_x86_rom, true), + DEFINE_PROP_BOOL("use-legacy-x86-rom", RAMFBStandaloneState, use_legacy_x86_rom, false), };static void
ramfb_class_initfn(ObjectClass *klass, void *data)hw/i386/pc_q35.c +1
-0@@ -45,6 +45,7 @@ #include "hw/i386/pc.h" #include "hw/i386/amd_iommu.h" #include "hw/i386/intel_iommu.h" +#include "hw/vfio/pci.h" #include "hw/virtio/virtio-iommu.h" #include "hw/display/ramfb.h" #include "hw/ide/pci.h"Quoted 8 lines
hw/i386/pc_q35.c line 71
Quoted 5 lines
hw/i386/pc_q35.c +2
-0@@ -67,6 +68,8 @@ static GlobalProperty pc_q35_compat_defaults[] = { { TYPE_VIRTIO_IOMMU_PCI, "aw-bits", "39" }, + { TYPE_RAMFB_DEVICE, "use-legacy-x86-rom", "true" }, + { TYPE_VFIO_PCI, "use-legacy-x86-rom", "true" },this will only keep the legacy behavior along with q35 machine type but not on other machines being used for x86. what about pc-i440fx? Doesn't it apply to it as well? Are there other machine types also impacted.
Ok I will also add it with pc-i440fx. I think only q35 and i440fx are impacted.
Quoted 7 lines
Also what about Daniel's comment in v3:
https://lore.kernel.org/all/[email protected]/
"For non-x86, historical versioned machine types will need likely it set to true, in order to avoid the memory layout being changed IIUC."Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Is it actually needed?
If those machine types need to set it to true. I think they can set it after they have this property.
nope it does not work like that. In case we really need to take care of this, this must be handled by compats.
If so. Why don't we still keep the "use-legacy-x86-rom" default to true, and only set it to false to those arch which doesn't need it just like my original implementation.
Quoted 8 lines
Quoted 5 lines
Because I don't really know how other arch's memoery layout was impacted by this property set to false. I think keep their original behavior and only change it on arm64 is a good idea.
How do you think about it?
No, the default value of the property shoudl reflect the long term desired behaviour - in this case 'use-legacy-x86-rom = false'.
Ok I understand your thoughts.
Quoted 5 lines
We must then reverse this default to 'true' for ALL historical versioned machine types on ALL architectures, where this device is built, or any specific machines where we want to keep the historical behaviour going forward.
But how do we implement that?
Maybe set the 'use-legacy-x86-rom = true' in hw_compat_9_2 ?
I'm not sure about that, could you give some hints about how to reverse the default to 'true' for ALL historical versioned machine types?
Thanks a lot.
Quoted 4 lines
With regards,
Daniel
Signature · 1 line
Shaoqin
Re: [PATCH v4 2/2] hw/i386: Add the ramfb romfile compatatibility
In reply to Eric AugerHi,
Quoted 4 lines
Quoted 2 lines
If those machine types need to set it to true. I think they can set it after they have this property.
nope it does not work like that. In case we really need to take care of this, this must be handled by compats.
ramfb is a sysbus device so it can only used for machine types where it is explicitly enabled:
# git grep machine_class_allow_dynamic_sysbus_dev.*TYPE_RAMFB_DEVICE hw/arm/virt.c: machine_class_allow_dynamic_sysbus_dev(mc, TYPE_RAMFB_DEVICE); hw/i386/microvm.c: machine_class_allow_dynamic_sysbus_dev(mc, TYPE_RAMFB_DEVICE); hw/i386/pc_piix.c: machine_class_allow_dynamic_sysbus_dev(m, TYPE_RAMFB_DEVICE); hw/i386/pc_q35.c: machine_class_allow_dynamic_sysbus_dev(m, TYPE_RAMFB_DEVICE); hw/loongarch/virt.c: machine_class_allow_dynamic_sysbus_dev(mc, TYPE_RAMFB_DEVICE); hw/riscv/virt.c: machine_class_allow_dynamic_sysbus_dev(mc, TYPE_RAMFB_DEVICE);
So these six are the only machine types we have to worry about.
The three x86 machine types (pc, q35, microvm) will actually use the rom (when booting with seabios).
For arm/riscv/loongarch virt we want disable the rom.
Everything else doesn't matter much because ramfb can not be used in the first place, you'll get an error like this when trying:
# qemu-default -M isapc -device ramfb qemu-system-x86_64: -device ramfb: Parameter 'driver' expects a dynamic sysbus device type for the machine
HTH & take care,
Gerd
Re: [PATCH v4 2/2] hw/i386: Add the ramfb romfile compatatibility
Hi Gerd,
Quoted 18 lines · Gerd Hoffmann
Hi,
Quoted 4 lines
Quoted 2 lines
If those machine types need to set it to true. I think they can set it after they have this property.
nope it does not work like that. In case we really need to take care of this, this must be handled by compats.
ramfb is a sysbus device so it can only used for machine types where it is explicitly enabled:
# git grep machine_class_allow_dynamic_sysbus_dev.*TYPE_RAMFB_DEVICE hw/arm/virt.c: machine_class_allow_dynamic_sysbus_dev(mc, TYPE_RAMFB_DEVICE); hw/i386/microvm.c: machine_class_allow_dynamic_sysbus_dev(mc, TYPE_RAMFB_DEVICE); hw/i386/pc_piix.c: machine_class_allow_dynamic_sysbus_dev(m, TYPE_RAMFB_DEVICE); hw/i386/pc_q35.c: machine_class_allow_dynamic_sysbus_dev(m, TYPE_RAMFB_DEVICE); hw/loongarch/virt.c: machine_class_allow_dynamic_sysbus_dev(mc, TYPE_RAMFB_DEVICE); hw/riscv/virt.c: machine_class_allow_dynamic_sysbus_dev(mc, TYPE_RAMFB_DEVICE);
Quoted 4 lines
So these six are the only machine types we have to worry about.
The three x86 machine types (pc, q35, microvm) will actually use the rom (when booting with seabios).
makes total sense. So microvm is needed as well.
Thank you for the confirmation!
Eric
Quoted 12 lines
For arm/riscv/loongarch virt we want disable the rom.
Everything else doesn't matter much because ramfb can not be used in the first place, you'll get an error like this when trying:
# qemu-default -M isapc -device ramfb qemu-system-x86_64: -device ramfb: Parameter 'driver' expects a dynamic sysbus device type for the machineHTH & take care,
Gerd
Hi guys,
Kindly ping for this series.
Thanks,
Shaoqin
Quoted 46 lines · Shaoqin Huang
Now the ramfb will load the vgabios-ramfb.bin unconditionally, but only the x86 need the vgabios-ramfb.bin, this can cause that when use the release package on arm64 it can't find the vgabios-ramfb.bin.
Because only seabios will use the vgabios-ramfb.bin, load the rom logic is x86-specific. For other !x86 platforms, the edk2 ships an EFI driver for ramfb, so they don't need to load the romfile.
So add a new property
use_legacy_x86_romin both ramfb andvfio_pcidevice, because the vfio display also use theramfb_setup()to load the vgabios-ramfb.bin file.After have this property, the machine type can set the compatibility to not load the vgabios-ramfb.bin if the arch doesn't need it.
Then I set the
use_legacy_x86_romproperty to false by default, and only set it to true on x86 since only x86 will need it.Changelog:
---------
v3 -> v4:
- Set the new property to false by default, only set it to true on x86.
v2 -> v3:
- Fix the underscore error.
- Add a new patch to set the property in arm compatibility.
v1 -> v2:
- Change the property name.v3: https://lore.kernel.org/all/[email protected]/
v2: https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/Shaoqin Huang (2):
ramfb: Add property to control if load the romfile hw/i386: Add the ramfb romfile compatatibilityhw/display/ramfb-standalone.c | 4 +++- hw/display/ramfb-stubs.c | 2 +- hw/display/ramfb.c | 6 ++++-- hw/i386/pc_q35.c | 3 +++ hw/vfio/display.c | 4 ++-- hw/vfio/pci.c | 1 + hw/vfio/pci.h | 1 + include/hw/display/ramfb.h | 2 +- 8 files changed, 16 insertions(+), 7 deletions(-)
Signature · 1 line
Shaoqin