any reason for include/uapi/sound header files not listed in Kbuild?
i just noticed that, in include/uapi/sound/, there are three header
files:
* asoc.h
* tlv.h
* usb_stream.h
that are not referenced by the corresponding Kbuild file. is there any reason for this? or, in general, is there *any* reason for there to be header files under include/uapi/ that are not listed in their Kbuild files? thanks.
rday
Signature · 7 lines
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================Quoted 11 lines · Robert P. J. Day
i just noticed that, in
include/uapi/sound/, there are three header
files:*
asoc.h
*tlv.h
*usb_stream.hthat are not referenced by the corresponding
Kbuildfile. is there any reason for this?
There is no reason. I noticed this sometime ago but forgot after that.
Quoted 3 lines
or, in general, is there *any* reason for there to be header files under
include/uapi/that are not listed in theirKbuildfiles? thanks.
Yes, they should be included in Kbuild file. So far, all user-space stuff is self-contained, keeping the copy of such files in it, thus there was no complaint due to the missing files.
That said, feel free to send a fix patch ;)
thanks,
Takashi
Quoted 21 lines · Takashi Iwai
Quoted 11 lines · Robert P. J. Day
i just noticed that, in
include/uapi/sound/, there are three header
files:*
asoc.h
*tlv.h
*usb_stream.hthat are not referenced by the corresponding
Kbuildfile. is there any reason for this?There is no reason. I noticed this sometime ago but forgot after that.
Quoted 3 lines
or, in general, is there *any* reason for there to be header files under
include/uapi/that are not listed in theirKbuildfiles? thanks.
Quoted 5 lines
Yes, they should be included in
Kbuildfile. So far, all user-space stuff is self-contained, keeping the copy of such files in it, thus there was no complaint due to the missing files.That said, feel free to send a fix patch ;)
so the patch would be to include the missing files in Kbuild, not to
delete them? :-)
rday
Signature · 7 lines
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================Quoted 24 lines · Robert P. J. Day
Quoted 21 lines · Takashi Iwai
Quoted 11 lines · Robert P. J. Day
i just noticed that, in
include/uapi/sound/, there are three header
files:*
asoc.h
*tlv.h
*usb_stream.hthat are not referenced by the corresponding
Kbuildfile. is there any reason for this?There is no reason. I noticed this sometime ago but forgot after that.
Quoted 3 lines
or, in general, is there *any* reason for there to be header files under
include/uapi/that are not listed in theirKbuildfiles? thanks.
Quoted 8 lines
Quoted 5 lines
Yes, they should be included in
Kbuildfile. So far, all user-space stuff is self-contained, keeping the copy of such files in it, thus there was no complaint due to the missing files.That said, feel free to send a fix patch ;)
so the patch would be to include the missing files in
Kbuild, not to
delete them? :-)
Yes.
Takashi