Skip to contentSkip to conversation

any reason for include/uapi/sound header files not listed in Kbuild?

DISCUSSION Robert P. J. Day 2 participants 4 messages May 28, 2016 – May 31, 2016

lore
Share & tools
lore
#0 lore raw

i just noticed that, in include/uapi/sound/, there are three header
files:

* asoc.h
* tlv.h
* usb_stream.h

that are not referenced by the corresponding Kbuild file. is there any reason for this? or, in general, is there *any* reason for there to be header files under include/uapi/ that are not listed in their Kbuild files? thanks.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#1 lore raw
Quoted 11 lines · Robert P. J. Day

i just noticed that, in include/uapi/sound/, there are three header
files:

* asoc.h
* tlv.h
* usb_stream.h

that are not referenced by the corresponding Kbuild file. is there any reason for this?

There is no reason. I noticed this sometime ago but forgot after that.

Quoted 3 lines

or, in general, is there *any* reason for there to be header files under include/uapi/ that are not listed in their Kbuild files? thanks.

Yes, they should be included in Kbuild file. So far, all user-space stuff is self-contained, keeping the copy of such files in it, thus there was no complaint due to the missing files.

That said, feel free to send a fix patch ;)

thanks,

Takashi

#2 lore raw
Quoted 21 lines · Takashi Iwai
Quoted 11 lines · Robert P. J. Day

i just noticed that, in include/uapi/sound/, there are three header
files:

* asoc.h
* tlv.h
* usb_stream.h

that are not referenced by the corresponding Kbuild file. is there any reason for this?

There is no reason. I noticed this sometime ago but forgot after that.

Quoted 3 lines

or, in general, is there *any* reason for there to be header files under include/uapi/ that are not listed in their Kbuild files? thanks.

Quoted 5 lines

Yes, they should be included in Kbuild file. So far, all user-space stuff is self-contained, keeping the copy of such files in it, thus there was no complaint due to the missing files.

That said, feel free to send a fix patch ;)

so the patch would be to include the missing files in Kbuild, not to
delete them? :-)

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#3 lore raw
Quoted 24 lines · Robert P. J. Day
Quoted 21 lines · Takashi Iwai
Quoted 11 lines · Robert P. J. Day

i just noticed that, in include/uapi/sound/, there are three header
files:

* asoc.h
* tlv.h
* usb_stream.h

that are not referenced by the corresponding Kbuild file. is there any reason for this?

There is no reason. I noticed this sometime ago but forgot after that.

Quoted 3 lines

or, in general, is there *any* reason for there to be header files under include/uapi/ that are not listed in their Kbuild files? thanks.

Quoted 8 lines
Quoted 5 lines

Yes, they should be included in Kbuild file. So far, all user-space stuff is self-contained, keeping the copy of such files in it, thus there was no complaint due to the missing files.

That said, feel free to send a fix patch ;)

so the patch would be to include the missing files in Kbuild, not to
delete them? :-)

Yes.

Takashi