gcov: Replace strncmp with str_has_prefix
PATCH v2 2/10 gcov: Replace strncmp with str_has_prefix
strncmp(str, const, len) is error-prone because len is easy to have typo.
The example is the hard-coded len has counting error or sizeof(const) forgets - 1.
So we prefer using newly introduced str_has_prefix to substitute such strncmp.
Signed-off-by Chuhong Yuan <[email protected]>
---
Changes in v2:
- Revise the description.
kernel/gcov/fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/gcov/fs.c +1 -1
@@ -354,7 +354,7 @@ static char *get_link_target(const char *filename, const struct gcov_link *ext)*/ static const char *deskew (const char *basename) { -if (strncmp (basename,SKEW_PREFIX ,sizeof (SKEW_PREFIX ) -1 ) ==0 ) +if (str_has_prefix (basename,SKEW_PREFIX ))return basename +sizeof (SKEW_PREFIX ) -1 ;return basename; }
Signature · 1 line
2.20.1
Quoted 8 lines · Chuhong Yuan
strncmp(str, const, len)is error-prone because len is easy to have typo.
The example is the hard-coded len has counting error or sizeof(const) forgets - 1.
So we prefer using newly introducedstr_has_prefixto substitute such strncmp.Signed-off-by Chuhong Yuan <[email protected]>
Looks sane!
Quoted 21 lines
---
Changes in v2:
- Revise the description.kernel/gcov/fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/gcov/fs.c +1
-1@@ -354,7 +354,7 @@ static char *get_link_target(const char *filename, const struct gcov_link *ext)*/ static const char *deskew (const char *basename) { -if (strncmp (basename,SKEW_PREFIX ,sizeof (SKEW_PREFIX ) -1 ) ==0 ) +if (str_has_prefix (basename,SKEW_PREFIX ))return basename +sizeof (SKEW_PREFIX ) -1 ;return basename; }
Signature · 2 lines
Peter Oberparleiter Linux on Z Development - IBM Germany