Skip to contentSkip to conversation

gcov: Replace strncmp with str_has_prefix

PATCH Applied Chuhong Yuan 2 participants 2 messages Aug 2, 2019 Gcov based kernel profiling

v2 of 4 Applied Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 2/10 gcov: Replace strncmp with str_has_prefix

strncmp(str, const, len) is error-prone because len is easy to have typo.
The example is the hard-coded len has counting error or sizeof(const) forgets - 1.
So we prefer using newly introduced str_has_prefix to substitute such strncmp.

---
Changes in v2:
- Revise the description.

 kernel/gcov/fs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/gcov/fs.c +1 -1
index e5eb5ea7ea59..67296c1768b4 100644
@@ -354,7 +354,7 @@ static char *get_link_target(const char *filename, const struct gcov_link *ext)
  */
 static const char *deskew(const char *basename)
 {
-	if (strncmp(basename, SKEW_PREFIX, sizeof(SKEW_PREFIX) - 1) == 0)
+	if (str_has_prefix(basename, SKEW_PREFIX))
 		return basename + sizeof(SKEW_PREFIX) - 1;
 	return basename;
 }
Signature · 1 line
2.20.1
maintainer Acked-by on v2 2/10
#1 lore raw
Quoted 8 lines · Chuhong Yuan

strncmp(str, const, len) is error-prone because len is easy to have typo.
The example is the hard-coded len has counting error or sizeof(const) forgets - 1.
So we prefer using newly introduced str_has_prefix to substitute such strncmp.

Looks sane!

Quoted 21 lines

---
Changes in v2:
- Revise the description.

 kernel/gcov/fs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/gcov/fs.c +1 -1
index e5eb5ea7ea59..67296c1768b4 100644
@@ -354,7 +354,7 @@ static char *get_link_target(const char *filename, const struct gcov_link *ext)
  */
 static const char *deskew(const char *basename)
 {
-	if (strncmp(basename, SKEW_PREFIX, sizeof(SKEW_PREFIX) - 1) == 0)
+	if (str_has_prefix(basename, SKEW_PREFIX))
 		return basename + sizeof(SKEW_PREFIX) - 1;
 	return basename;
 }
Signature · 2 lines
Peter Oberparleiter
Linux on Z Development - IBM Germany