drm: Remove includes for drm_crtc_helper.h
Subsystems (25)
Thomas Zimmermann
maintainercover drm: Remove includes for drm_crtc_helper.h
A lot of source files include drm_crtc_helper.h for its contained include statements. This leads to excessive compile-time dependencies.
Where possible, remove the include statements for drm_crtc_helper.h and include the required source files directly. Also remove the include statements from drm_crtc_helper.h itself, which doesn't need most of them.
I built this patchset on x86-64, aarch64 and arm. Hopefully I found all include dependencies.
Thanks to Sam Ravnborg for bringing this to my attention.
Thomas Zimmermann (22):
drm/amdgpu: Fix coding style
drm: Remove unnecessary include statements for drm_crtc_helper.h drm/amdgpu: Remove unnecessary include statements for
drm_crtc_helper.h
drm/arm/komeda: Remove unnecessary include statements for
drm_crtc_helper.h
drm/aspeed: Remove unnecessary include statements for
drm_crtc_helper.h
drm/ast: Remove unnecessary include statements for drm_crtc_helper.h drm/bridge: Remove unnecessary include statements for
drm_crtc_helper.h
drm/gma500: Remove unnecessary include statements for
drm_crtc_helper.h
drm/i2c/ch7006: Remove unnecessary include statements for
drm_crtc_helper.h
drm/ingenic: Remove unnecessary include statements for
drm_crtc_helper.h
drm/kmb: Remove unnecessary include statements for drm_crtc_helper.h drm/logicvc: Remove unnecessary include statements for
drm_crtc_helper.h
drm/nouveau: Remove unnecessary include statements for
drm_crtc_helper.h
drm/radeon: Remove unnecessary include statements for
drm_crtc_helper.h
drm/rockchip: Remove unnecessary include statements for
drm_crtc_helper.h
drm/shmobile: Remove unnecessary include statements for
drm_crtc_helper.h
drm/sprd: Remove unnecessary include statements for drm_crtc_helper.h drm/sun4i: Remove unnecessary include statements for drm_crtc_helper.h drm/tidss: Remove unnecessary include statements for drm_crtc_helper.h drm/udl: Remove unnecessary include statements for drm_crtc_helper.h drm/vboxvideo: Remove unnecessary include statements for
drm_crtc_helper.h
drm/crtc-helper: Remove most include statements from drm_crtc_helper.h
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 - drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 1 - drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 1 - drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 ++ drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 1 - drivers/gpu/drm/arm/display/komeda/komeda_kms.h | 1 - drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c | 1 - drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 1 - drivers/gpu/drm/aspeed/aspeed_gfx_out.c | 1 - drivers/gpu/drm/ast/ast_drv.c | 1 - drivers/gpu/drm/ast/ast_main.c | 1 - drivers/gpu/drm/ast/ast_mode.c | 1 - drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 1 - drivers/gpu/drm/bridge/analogix/anx7625.c | 1 - .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 1 - drivers/gpu/drm/bridge/ite-it6505.c | 1 - drivers/gpu/drm/bridge/ite-it66121.c | 1 - drivers/gpu/drm/bridge/tc358768.c | 1 - drivers/gpu/drm/bridge/tc358775.c | 1 - drivers/gpu/drm/drm_crtc_helper.c | 1 - drivers/gpu/drm/drm_lease.c | 2 +- drivers/gpu/drm/drm_plane_helper.c | 1 - drivers/gpu/drm/gma500/cdv_device.c | 1 + drivers/gpu/drm/gma500/cdv_intel_crt.c | 2 ++ drivers/gpu/drm/gma500/cdv_intel_display.c | 1 + drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 + drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2 ++ drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 ++ drivers/gpu/drm/gma500/framebuffer.c | 2 ++ drivers/gpu/drm/gma500/gma_display.c | 2 ++ drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 + drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 ++ drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 + drivers/gpu/drm/gma500/psb_device.c | 1 + drivers/gpu/drm/gma500/psb_intel_display.c | 3 +++ drivers/gpu/drm/gma500/psb_intel_drv.h | 1 - drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 ++ drivers/gpu/drm/gma500/psb_intel_sdvo.c | 2 ++ drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++ drivers/gpu/drm/i2c/ch7006_priv.h | 1 - drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 - drivers/gpu/drm/kmb/kmb_crtc.c | 1 - drivers/gpu/drm/kmb/kmb_plane.c | 1 - drivers/gpu/drm/logicvc/logicvc_interface.c | 1 - drivers/gpu/drm/logicvc/logicvc_mode.c | 1 - drivers/gpu/drm/nouveau/dispnv04/crtc.c | 1 + drivers/gpu/drm/nouveau/dispnv04/dac.c | 2 +- drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +- drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c | 1 - drivers/gpu/drm/nouveau/dispnv04/tvnv04.c | 2 +- drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 1 + drivers/gpu/drm/nouveau/dispnv50/head.c | 1 - drivers/gpu/drm/nouveau/nouveau_drm.c | 1 - drivers/gpu/drm/nouveau/nouveau_vga.c | 1 - drivers/gpu/drm/radeon/atombios_crtc.c | 2 +- drivers/gpu/drm/radeon/atombios_encoders.c | 1 + drivers/gpu/drm/radeon/r300.c | 1 - drivers/gpu/drm/radeon/radeon_asic.c | 1 - drivers/gpu/drm/radeon/radeon_connectors.c | 1 + drivers/gpu/drm/radeon/radeon_display.c | 1 + drivers/gpu/drm/radeon/radeon_drv.c | 1 - drivers/gpu/drm/radeon/radeon_encoders.c | 1 - drivers/gpu/drm/radeon/radeon_irq_kms.c | 1 - drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 2 +- drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 2 +- drivers/gpu/drm/radeon/radeon_legacy_tv.c | 1 - drivers/gpu/drm/radeon/radeon_mode.h | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 - drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 2 ++ drivers/gpu/drm/shmobile/shmob_drm_drv.c | 1 - drivers/gpu/drm/shmobile/shmob_drm_plane.c | 1 - drivers/gpu/drm/sprd/sprd_dpu.c | 1 - drivers/gpu/drm/sprd/sprd_drm.c | 1 - drivers/gpu/drm/sprd/sprd_dsi.c | 1 - drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +- drivers/gpu/drm/tidss/tidss_crtc.c | 1 - drivers/gpu/drm/tidss/tidss_drv.c | 1 - drivers/gpu/drm/tidss/tidss_encoder.c | 2 +- drivers/gpu/drm/tidss/tidss_kms.c | 1 - drivers/gpu/drm/tidss/tidss_plane.c | 1 - drivers/gpu/drm/udl/udl_drv.c | 2 +- drivers/gpu/drm/udl/udl_modeset.c | 1 - drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +- drivers/gpu/drm/vboxvideo/vbox_main.c | 1 - include/drm/drm_crtc_helper.h | 14 +++++++++----- include/drm/drm_fixed.h | 1 + 94 files changed, 70 insertions(+), 70 deletions(-)
base-commit: 68d139b609a97a83e7c231189d4864aba4e1679b
prerequisite-patch-id: 0aa359f6144c4015c140c8a6750be19099c676fb
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
prerequisite-patch-id: 3f204510fcbf9530d6540bd8e6128cce598988b6
Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 1/22 drm/amdgpu: Fix coding style
Align a closing brace and remove trailing whitespaces. No functional changes.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2 -2
@@ -5871,8 +5871,8 @@ void amdgpu_device_invalidate_hdp(struct amdgpu_device *adev,int amdgpu_in_reset (struct amdgpu_device *adev) {return atomic_read (&adev->reset_domain->in_gpu_reset); - } - +} +/** * amdgpu_device_halt() - bring hardware to some kind of halt state *
Signature · 1 line
2.39.0
Alex Deucher
AppliedRe: [PATCH 01/22] drm/amdgpu: Fix coding style
Applied. Thanks!
Quoted 27 lines · Thomas Zimmermann
Align a closing brace and remove trailing whitespaces. No functional changes.
Signed-off-by Thomas Zimmermann <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2
-3@@ -5871,8 +5871,8 @@ void amdgpu_device_invalidate_hdp(struct amdgpu_device *adev,int amdgpu_in_reset (struct amdgpu_device *adev) {return atomic_read (&adev->reset_domain->in_gpu_reset); - } - +} +/** * amdgpu_device_halt() - bring hardware to some kind of halt state * -- 2.39.0
Thomas Zimmermann
maintainerPATCH 2/22 drm: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral DRM core and helper source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible. The header file, drm_fixed.h, includes <linux/kernel.h> for lower_32_bits().
--- drivers/gpu/drm/drm_crtc_helper.c | 1 - drivers/gpu/drm/drm_lease.c | 2 +- drivers/gpu/drm/drm_plane_helper.c | 1 - include/drm/drm_fixed.h | 1 + 4 files changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_crtc_helper.c +0 -1
@@ -39,7 +39,6 @@#include <drm/drm_atomic_uapi.h> #include <drm/drm_bridge.h> #include <drm/drm_crtc.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_drv.h> #include <drm/drm_edid.h> #include <drm/drm_encoder.h>
drivers/gpu/drm/drm_lease.c +1 -1
@@ -6,7 +6,7 @@#include <linux/uaccess.h> #include <drm/drm_auth.h> -#include <drm/drm_crtc_helper.h> +#include <drm/drm_crtc.h> #include <drm/drm_drv.h> #include <drm/drm_file.h> #include <drm/drm_lease.h>
drivers/gpu/drm/drm_plane_helper.c +0 -1
@@ -28,7 +28,6 @@#include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_atomic_uapi.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_device.h> #include <drm/drm_drv.h> #include <drm/drm_encoder.h>
include/drm/drm_fixed.h +1 -0
@@ -25,6 +25,7 @@ #ifndef DRM_FIXED_H #define DRM_FIXED_H +#include <linux/kernel.h> #include <linux/math64.h> typedef union dfixed {
Signature · 1 line
2.39.0
Re: [PATCH 02/22] drm: Remove unnecessary include statements for drm_crtc_helper.h
Hi Thomas.
Quoted 21 lines · Thomas Zimmermann
Several DRM core and helper source files include
drm_crtc_helper.hwithout needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.Directly include required headers and drop
drm_crtc_helper.hwhere possible. The header file,drm_fixed.h, includes <linux/kernel.h> forlower_32_bits().Signed-off-by Thomas Zimmermann <[email protected]>--- drivers/gpu/drm/drm_crtc_helper.c | 1 - drivers/gpu/drm/drm_lease.c | 2 +- drivers/gpu/drm/drm_plane_helper.c | 1 - include/drm/drm_fixed.h | 1 + 4 files changed, 2 insertions(+), 3 deletions(-)drivers/gpu/drm/drm_crtc_helper.c +0
-0
drivers/gpu/drm/drm_crtc_helper.c line 42
Quoted 4 lines
drivers/gpu/drm/drm_crtc_helper.c +0
-1@@ -39,7 +39,6 @@#include <drm/drm_atomic_uapi.h> #include <drm/drm_bridge.h> #include <drm/drm_crtc.h> -#include <drm/drm_crtc_helper.h>
drm_crtc_helper.c may not require drm/drm_crtc_helper.h, but it should include it so we get a warning in case there is a mismatch between the header file and the implementation.
I think sparse would also complain that the function is not declared or something like that.
With this fixed:
Quoted 42 lines
drivers/gpu/drm/drm_crtc_helper.c +0
-0#include <drm/drm_drv.h> #include <drm/drm_edid.h> #include <drm/drm_encoder.h> drivers/gpu/drm/drm_lease.c +1
-1@@ -6,7 +6,7 @@#include <linux/uaccess.h> #include <drm/drm_auth.h> -#include <drm/drm_crtc_helper.h> +#include <drm/drm_crtc.h> #include <drm/drm_drv.h> #include <drm/drm_file.h> #include <drm/drm_lease.h> drivers/gpu/drm/drm_plane_helper.c +0
-1@@ -28,7 +28,6 @@#include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_atomic_uapi.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_device.h> #include <drm/drm_drv.h> #include <drm/drm_encoder.h> include/drm/drm_fixed.h +1
-0@@ -25,6 +25,7 @@ #ifndef DRM_FIXED_H #define DRM_FIXED_H +#include <linux/kernel.h> #include <linux/math64.h> typedef union dfixed {Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 3/22 drm/amdgpu: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 - drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 1 - drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 1 - drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 ++ 12 files changed, 12 insertions(+), 5 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c +2 -0
@@ -25,7 +25,9 @@*/ #include <drm/display/drm_dp_helper.h> +#include <drm/drm_crtc_helper.h> #include <drm/drm_edid.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_probe_helper.h> #include <drm/amdgpu_drm.h> #include "amdgpu.h"
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -0
@@ -39,6 +39,7 @@#include <drm/drm_aperture.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_fb_helper.h> +#include <drm/drm_crtc_helper.h> #include <drm/drm_probe_helper.h> #include <drm/amdgpu_drm.h> #include <linux/vgaarb.h>
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +1 -0
@@ -42,6 +42,7 @@#include <drm/drm_fb_helper.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/drm_fourcc.h> +#include <drm/drm_modeset_helper.h> #include <drm/drm_vblank.h> /**
drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c +0 -1
@@ -24,7 +24,6 @@* Alex Deucher */ -#include <drm/drm_crtc_helper.h> #include <drm/amdgpu_drm.h> #include "amdgpu.h" #include "amdgpu_connectors.h"
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c +0 -1
@@ -45,7 +45,6 @@#include <linux/irq.h> #include <linux/pci.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_vblank.h> #include <drm/amdgpu_drm.h> #include <drm/drm_drv.h>
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h +0 -1
@@ -35,7 +35,6 @@#include <drm/drm_edid.h> #include <drm/drm_encoder.h> #include <drm/drm_fixed.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_framebuffer.h> #include <drm/drm_probe_helper.h> #include <linux/i2c.h>
drivers/gpu/drm/amd/amdgpu/atombios_crtc.c +0 -1
@@ -24,7 +24,6 @@* Alex Deucher */ -#include <drm/drm_crtc_helper.h> #include <drm/amdgpu_drm.h> #include <drm/drm_fixed.h> #include "amdgpu.h"
drivers/gpu/drm/amd/amdgpu/atombios_encoders.c +0 -1
@@ -28,7 +28,6 @@#include <acpi/video.h> -#include <drm/drm_crtc_helper.h> #include <drm/amdgpu_drm.h> #include "amdgpu.h" #include "amdgpu_connectors.h"
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c +2 -0
@@ -22,6 +22,8 @@*/ #include <drm/drm_fourcc.h> +#include <drm/drm_modeset_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_vblank.h> #include "amdgpu.h"
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c +2 -0
@@ -22,6 +22,8 @@*/ #include <drm/drm_fourcc.h> +#include <drm/drm_modeset_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_vblank.h> #include "amdgpu.h"
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c +2 -0
@@ -24,6 +24,8 @@#include <linux/pci.h> #include <drm/drm_fourcc.h> +#include <drm/drm_modeset_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_vblank.h> #include "amdgpu.h"
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +2 -0
@@ -22,6 +22,8 @@*/ #include <drm/drm_fourcc.h> +#include <drm/drm_modeset_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_vblank.h> #include "amdgpu.h"
Signature · 1 line
2.39.0
Re: [PATCH 03/22] drm/amdgpu: Remove unnecessary include statements for drm_crtc_helper.h
Quoted 42 lines · Thomas Zimmermann
Several source files include
drm_crtc_helper.hwithout needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.Directly include required headers and drop
drm_crtc_helper.hwhere possible.Signed-off-by Thomas Zimmermann <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 - drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 1 - drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 1 - drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 ++ 12 files changed, 12 insertions(+), 5 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c +2
-0@@ -25,7 +25,9 @@*/ #include <drm/display/drm_dp_helper.h> +#include <drm/drm_crtc_helper.h> #include <drm/drm_edid.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_probe_helper.h> #include <drm/amdgpu_drm.h> #include "amdgpu.h" drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c line 42
Quoted 4 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-0@@ -39,6 +39,7 @@#include <drm/drm_aperture.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_fb_helper.h> +#include <drm/drm_crtc_helper.h>
Move it one line up to keep the sorting.
With this fixed:
Quoted 129 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0
-0#include <drm/drm_probe_helper.h> #include <drm/amdgpu_drm.h> #include <linux/vgaarb.h> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +1
-0@@ -42,6 +42,7 @@#include <drm/drm_fb_helper.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/drm_fourcc.h> +#include <drm/drm_modeset_helper.h> #include <drm/drm_vblank.h> /** drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c +0
-1@@ -24,7 +24,6 @@* Alex Deucher */ -#include <drm/drm_crtc_helper.h> #include <drm/amdgpu_drm.h> #include "amdgpu.h" #include "amdgpu_connectors.h" drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c +0
-1@@ -45,7 +45,6 @@#include <linux/irq.h> #include <linux/pci.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_vblank.h> #include <drm/amdgpu_drm.h> #include <drm/drm_drv.h> drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h +0
-1@@ -35,7 +35,6 @@#include <drm/drm_edid.h> #include <drm/drm_encoder.h> #include <drm/drm_fixed.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_framebuffer.h> #include <drm/drm_probe_helper.h> #include <linux/i2c.h> drivers/gpu/drm/amd/amdgpu/atombios_crtc.c +0
-1@@ -24,7 +24,6 @@* Alex Deucher */ -#include <drm/drm_crtc_helper.h> #include <drm/amdgpu_drm.h> #include <drm/drm_fixed.h> #include "amdgpu.h" drivers/gpu/drm/amd/amdgpu/atombios_encoders.c +0
-1@@ -28,7 +28,6 @@#include <acpi/video.h> -#include <drm/drm_crtc_helper.h> #include <drm/amdgpu_drm.h> #include "amdgpu.h" #include "amdgpu_connectors.h" drivers/gpu/drm/amd/amdgpu/dce_v10_0.c +2
-0@@ -22,6 +22,8 @@*/ #include <drm/drm_fourcc.h> +#include <drm/drm_modeset_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_vblank.h> #include "amdgpu.h" drivers/gpu/drm/amd/amdgpu/dce_v11_0.c +2
-0@@ -22,6 +22,8 @@*/ #include <drm/drm_fourcc.h> +#include <drm/drm_modeset_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_vblank.h> #include "amdgpu.h" drivers/gpu/drm/amd/amdgpu/dce_v6_0.c +2
-0@@ -24,6 +24,8 @@#include <linux/pci.h> #include <drm/drm_fourcc.h> +#include <drm/drm_modeset_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_vblank.h> #include "amdgpu.h" drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +2
-0@@ -22,6 +22,8 @@*/ #include <drm/drm_fourcc.h> +#include <drm/drm_modeset_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_vblank.h> #include "amdgpu.h" Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 4/22 drm/arm/komeda: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 1 - drivers/gpu/drm/arm/display/komeda/komeda_kms.h | 1 - 2 files changed, 2 deletions(-)
drivers/gpu/drm/arm/display/komeda/komeda_crtc.c +0 -1
@@ -10,7 +10,6 @@#include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_print.h> #include <drm/drm_vblank.h>
drivers/gpu/drm/arm/display/komeda/komeda_kms.h +0 -1
@@ -11,7 +11,6 @@#include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_blend.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_device.h> #include <drm/drm_writeback.h> #include <drm/drm_print.h>
Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 5/22 drm/aspeed: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c | 1 - drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 1 - drivers/gpu/drm/aspeed/aspeed_gfx_out.c | 1 - 3 files changed, 3 deletions(-)
drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c +0 -1
@@ -5,7 +5,6 @@#include <linux/reset.h> #include <linux/regmap.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_device.h> #include <drm/drm_fb_dma_helper.h> #include <drm/drm_fourcc.h>
drivers/gpu/drm/aspeed/aspeed_gfx_drv.c +0 -1
@@ -14,7 +14,6 @@#include <linux/reset.h> #include <drm/drm_atomic_helper.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_device.h> #include <drm/drm_fbdev_generic.h> #include <drm/drm_gem_dma_helper.h>
drivers/gpu/drm/aspeed/aspeed_gfx_out.c +0 -1
@@ -3,7 +3,6 @@#include <drm/drm_atomic_helper.h> #include <drm/drm_connector.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_edid.h> #include <drm/drm_probe_helper.h>
Signature · 1 line
2.39.0
Re: [PATCH 05/22] drm/aspeed: Remove unnecessary include statements for drm_crtc_helper.h
Quoted 6 lines · Thomas Zimmermann
Several source files include
drm_crtc_helper.hwithout needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.Directly include required headers and drop
drm_crtc_helper.hwhere possible.
Nitpicking... The above is the standard text you use.
But in many cases, like this case, the patch just drop the wrong use of the header and do not include any required headers.
If you want to rephrase for future changelog diggers or leave it as is, is up to you.
Sam
Quoted 46 lines
Signed-off-by Thomas Zimmermann <[email protected]>--- drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c | 1 - drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 1 - drivers/gpu/drm/aspeed/aspeed_gfx_out.c | 1 - 3 files changed, 3 deletions(-)drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c +0
-1@@ -5,7 +5,6 @@#include <linux/reset.h> #include <linux/regmap.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_device.h> #include <drm/drm_fb_dma_helper.h> #include <drm/drm_fourcc.h> drivers/gpu/drm/aspeed/aspeed_gfx_drv.c +0
-1@@ -14,7 +14,6 @@#include <linux/reset.h> #include <drm/drm_atomic_helper.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_device.h> #include <drm/drm_fbdev_generic.h> #include <drm/drm_gem_dma_helper.h> drivers/gpu/drm/aspeed/aspeed_gfx_out.c +0
-1@@ -3,7 +3,6 @@#include <drm/drm_atomic_helper.h> #include <drm/drm_connector.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_edid.h> #include <drm/drm_probe_helper.h> Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 6/22 drm/ast: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/ast/ast_drv.c | 1 - drivers/gpu/drm/ast/ast_main.c | 1 - drivers/gpu/drm/ast/ast_mode.c | 1 - 3 files changed, 3 deletions(-)
drivers/gpu/drm/ast/ast_drv.c +0 -1
@@ -31,7 +31,6 @@#include <drm/drm_aperture.h> #include <drm/drm_atomic_helper.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_drv.h> #include <drm/drm_fbdev_generic.h> #include <drm/drm_gem_shmem_helper.h>
drivers/gpu/drm/ast/ast_main.c +0 -1
@@ -29,7 +29,6 @@#include <linux/pci.h> #include <drm/drm_atomic_helper.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_drv.h> #include <drm/drm_gem.h> #include <drm/drm_managed.h>
drivers/gpu/drm/ast/ast_mode.c +0 -1
@@ -35,7 +35,6 @@#include <drm/drm_atomic_helper.h> #include <drm/drm_atomic_state_helper.h> #include <drm/drm_crtc.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_damage_helper.h> #include <drm/drm_edid.h> #include <drm/drm_format_helper.h>
Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 7/22 drm/bridge: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 1 - drivers/gpu/drm/bridge/analogix/anx7625.c | 1 - drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 1 - drivers/gpu/drm/bridge/ite-it6505.c | 1 - drivers/gpu/drm/bridge/ite-it66121.c | 1 - drivers/gpu/drm/bridge/tc358768.c | 1 - drivers/gpu/drm/bridge/tc358775.c | 1 - 7 files changed, 7 deletions(-)
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c +0 -1
@@ -22,7 +22,6 @@#include <drm/drm_atomic_helper.h> #include <drm/drm_bridge.h> #include <drm/drm_crtc.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_edid.h> #include <drm/drm_of.h> #include <drm/drm_panel.h>
drivers/gpu/drm/bridge/analogix/anx7625.c +0 -1
@@ -26,7 +26,6 @@#include <drm/display/drm_hdcp_helper.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_bridge.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_edid.h> #include <drm/drm_mipi_dsi.h> #include <drm/drm_of.h>
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +0 -1
@@ -43,7 +43,6 @@#include <drm/drm_atomic_state_helper.h> #include <drm/drm_bridge.h> #include <drm/drm_connector.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_edid.h> #include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_print.h>
drivers/gpu/drm/bridge/ite-it6505.c +0 -1
@@ -26,7 +26,6 @@#include <drm/drm_atomic_helper.h> #include <drm/drm_bridge.h> #include <drm/drm_crtc.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_edid.h> #include <drm/drm_print.h> #include <drm/drm_probe_helper.h>
drivers/gpu/drm/bridge/ite-it66121.c +0 -1
@@ -22,7 +22,6 @@#include <drm/drm_atomic_helper.h> #include <drm/drm_bridge.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_edid.h> #include <drm/drm_modes.h> #include <drm/drm_print.h>
drivers/gpu/drm/bridge/tc358768.c +0 -1
@@ -15,7 +15,6 @@#include <linux/slab.h> #include <drm/drm_atomic_helper.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_drv.h> #include <drm/drm_mipi_dsi.h> #include <drm/drm_of.h>
drivers/gpu/drm/bridge/tc358775.c +0 -1
@@ -23,7 +23,6 @@#include <drm/display/drm_dp_helper.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_bridge.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_mipi_dsi.h> #include <drm/drm_of.h> #include <drm/drm_panel.h>
Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 8/22 drm/gma500: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/gma500/cdv_device.c | 1 + drivers/gpu/drm/gma500/cdv_intel_crt.c | 2 ++ drivers/gpu/drm/gma500/cdv_intel_display.c | 1 + drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 + drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2 ++ drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 ++ drivers/gpu/drm/gma500/framebuffer.c | 2 ++ drivers/gpu/drm/gma500/gma_display.c | 2 ++ drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 + drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 ++ drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 + drivers/gpu/drm/gma500/psb_device.c | 1 + drivers/gpu/drm/gma500/psb_intel_display.c | 3 +++ drivers/gpu/drm/gma500/psb_intel_drv.h | 1 - drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 ++ drivers/gpu/drm/gma500/psb_intel_sdvo.c | 2 ++ 16 files changed, 25 insertions(+), 1 deletion(-)
drivers/gpu/drm/gma500/cdv_device.c +1 -0
@@ -8,6 +8,7 @@#include <linux/delay.h> #include <drm/drm.h> +#include <drm/drm_crtc_helper.h> #include "cdv_device.h" #include "gma_device.h"
drivers/gpu/drm/gma500/cdv_intel_crt.c +2 -0
@@ -28,6 +28,8 @@#include <linux/i2c.h> #include <linux/pm_runtime.h> +#include <drm/drm_crtc_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_simple_kms_helper.h> #include "cdv_device.h"
drivers/gpu/drm/gma500/cdv_intel_display.c +1 -0
@@ -10,6 +10,7 @@#include <linux/i2c.h> #include <drm/drm_crtc.h> +#include <drm/drm_modeset_helper_vtables.h> #include "cdv_device.h" #include "framebuffer.h"
drivers/gpu/drm/gma500/cdv_intel_dp.c +1 -0
@@ -33,6 +33,7 @@#include <drm/drm_crtc.h> #include <drm/drm_crtc_helper.h> #include <drm/drm_edid.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_simple_kms_helper.h> #include "gma_display.h"
drivers/gpu/drm/gma500/cdv_intel_hdmi.c +2 -0
@@ -28,7 +28,9 @@#include <drm/drm.h> #include <drm/drm_crtc.h> +#include <drm/drm_crtc_helper.h> #include <drm/drm_edid.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_simple_kms_helper.h> #include "cdv_device.h"
drivers/gpu/drm/gma500/cdv_intel_lvds.c +2 -0
@@ -12,6 +12,8 @@#include <linux/i2c.h> #include <linux/pm_runtime.h> +#include <drm/drm_crtc_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_simple_kms_helper.h> #include "cdv_device.h"
drivers/gpu/drm/gma500/framebuffer.c +2 -0
@@ -19,10 +19,12 @@#include <drm/drm.h> #include <drm/drm_crtc.h> +#include <drm/drm_crtc_helper.h> #include <drm/drm_fb_helper.h> #include <drm/drm_fourcc.h> #include <drm/drm_framebuffer.h> #include <drm/drm_gem_framebuffer_helper.h> +#include <drm/drm_modeset_helper.h> #include "framebuffer.h" #include "gem.h"
drivers/gpu/drm/gma500/gma_display.c +2 -0
@@ -11,8 +11,10 @@#include <linux/highmem.h> #include <drm/drm_crtc.h> +#include <drm/drm_crtc_helper.h> #include <drm/drm_fourcc.h> #include <drm/drm_framebuffer.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_vblank.h> #include "framebuffer.h"
drivers/gpu/drm/gma500/oaktrail_crtc.c +1 -0
@@ -9,6 +9,7 @@#include <drm/drm_fourcc.h> #include <drm/drm_framebuffer.h> +#include <drm/drm_modeset_helper_vtables.h> #include "framebuffer.h" #include "gem.h"
drivers/gpu/drm/gma500/oaktrail_hdmi.c +2 -0
@@ -27,7 +27,9 @@#include <linux/delay.h> #include <drm/drm.h> +#include <drm/drm_crtc_helper.h> #include <drm/drm_edid.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_simple_kms_helper.h> #include "psb_drv.h"
drivers/gpu/drm/gma500/oaktrail_lvds.c +1 -0
@@ -14,6 +14,7 @@#include <asm/intel-mid.h> #include <drm/drm_edid.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_simple_kms_helper.h> #include "intel_bios.h"
drivers/gpu/drm/gma500/psb_device.c +1 -0
@@ -6,6 +6,7 @@**************************************************************************/ #include <drm/drm.h> +#include <drm/drm_crtc_helper.h> #include "gma_device.h" #include "intel_bios.h"
drivers/gpu/drm/gma500/psb_intel_display.c +3 -0
@@ -9,6 +9,9 @@#include <linux/delay.h> #include <linux/i2c.h> +#include <drm/drm_modeset_helper.h> +#include <drm/drm_modeset_helper_vtables.h> +#include "framebuffer.h" #include "gem.h" #include "gma_display.h"
drivers/gpu/drm/gma500/psb_intel_drv.h +0 -1
@@ -9,7 +9,6 @@#include <linux/i2c.h> #include <linux/i2c-algo-bit.h> #include <drm/drm_crtc.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_encoder.h> #include <drm/drm_probe_helper.h> #include <drm/drm_vblank.h>
drivers/gpu/drm/gma500/psb_intel_lvds.c +2 -0
@@ -11,6 +11,8 @@#include <linux/i2c.h> #include <linux/pm_runtime.h> +#include <drm/drm_crtc_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_simple_kms_helper.h> #include "intel_bios.h"
drivers/gpu/drm/gma500/psb_intel_sdvo.c +2 -0
@@ -33,7 +33,9 @@#include <linux/slab.h> #include <drm/drm_crtc.h> +#include <drm/drm_crtc_helper.h> #include <drm/drm_edid.h> +#include <drm/drm_modeset_helper_vtables.h> #include "psb_drv.h" #include "psb_intel_drv.h"
Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 9/22 drm/i2c/ch7006: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++ drivers/gpu/drm/i2c/ch7006_priv.h | 1 - 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i2c/ch7006_drv.c +2 -0
@@ -26,6 +26,8 @@#include <linux/module.h> +#include <drm/drm_crtc_helper.h> +#include "ch7006_priv.h" /* DRM encoder functions */
drivers/gpu/drm/i2c/ch7006_priv.h +0 -1
@@ -27,7 +27,6 @@#ifndef __DRM_I2C_CH7006_PRIV_H__#define __DRM_I2C_CH7006_PRIV_H__ -#include <drm/drm_crtc_helper.h> #include <drm/drm_encoder_slave.h> #include <drm/drm_probe_helper.h> #include <drm/i2c/ch7006.h>
Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 10/22 drm/ingenic: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/ingenic/ingenic-drm-drv.c +0 -1
@@ -26,7 +26,6 @@#include <drm/drm_bridge_connector.h> #include <drm/drm_color_mgmt.h> #include <drm/drm_crtc.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_damage_helper.h> #include <drm/drm_drv.h> #include <drm/drm_encoder.h>
Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 11/22 drm/kmb: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/kmb/kmb_crtc.c | 1 - drivers/gpu/drm/kmb/kmb_plane.c | 1 - 2 files changed, 2 deletions(-)
drivers/gpu/drm/kmb/kmb_crtc.c +0 -1
@@ -8,7 +8,6 @@#include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_crtc.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_print.h> #include <drm/drm_vblank.h> #include <drm/drm_modeset_helper_vtables.h>
drivers/gpu/drm/kmb/kmb_plane.c +0 -1
@@ -7,7 +7,6 @@#include <drm/drm_atomic_helper.h> #include <drm/drm_blend.h> #include <drm/drm_crtc.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_fb_dma_helper.h> #include <drm/drm_fourcc.h> #include <drm/drm_framebuffer.h>
Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 12/22 drm/logicvc: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/logicvc/logicvc_interface.c | 1 - drivers/gpu/drm/logicvc/logicvc_mode.c | 1 - 2 files changed, 2 deletions(-)
drivers/gpu/drm/logicvc/logicvc_interface.c +0 -1
@@ -9,7 +9,6 @@#include <drm/drm_atomic_helper.h> #include <drm/drm_bridge.h> #include <drm/drm_connector.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_drv.h> #include <drm/drm_encoder.h> #include <drm/drm_gem_dma_helper.h>
drivers/gpu/drm/logicvc/logicvc_mode.c +0 -1
@@ -8,7 +8,6 @@#include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_drv.h> #include <drm/drm_gem_dma_helper.h> #include <drm/drm_gem_framebuffer_helper.h>
Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 13/22 drm/nouveau: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 1 + drivers/gpu/drm/nouveau/dispnv04/dac.c | 2 +- drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +- drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c | 1 - drivers/gpu/drm/nouveau/dispnv04/tvnv04.c | 2 +- drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 1 + drivers/gpu/drm/nouveau/dispnv50/head.c | 1 - drivers/gpu/drm/nouveau/nouveau_drm.c | 1 - drivers/gpu/drm/nouveau/nouveau_vga.c | 1 - 9 files changed, 5 insertions(+), 7 deletions(-)
drivers/gpu/drm/nouveau/dispnv04/crtc.c +1 -0
@@ -24,6 +24,7 @@*/ #include <drm/drm_crtc_helper.h> #include <drm/drm_fourcc.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_plane_helper.h> #include <drm/drm_vblank.h>
drivers/gpu/drm/nouveau/dispnv04/dac.c +1 -1
@@ -24,7 +24,7 @@* DEALINGS IN THE SOFTWARE. */ -#include <drm/drm_crtc_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include "nouveau_drv.h" #include "nouveau_encoder.h"
drivers/gpu/drm/nouveau/dispnv04/dfp.c +1 -1
@@ -24,8 +24,8 @@* DEALINGS IN THE SOFTWARE. */ -#include <drm/drm_crtc_helper.h> #include <drm/drm_fourcc.h> +#include <drm/drm_modeset_helper_vtables.h> #include "nouveau_drv.h" #include "nouveau_reg.h"
drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c +0 -1
@@ -24,7 +24,6 @@* */ -#include <drm/drm_crtc_helper.h> #include "nouveau_drv.h" #include "nouveau_encoder.h" #include "nouveau_crtc.h"
drivers/gpu/drm/nouveau/dispnv04/tvnv04.c +1 -1
@@ -30,7 +30,7 @@#include "nouveau_connector.h" #include "nouveau_crtc.h" #include "hw.h" -#include <drm/drm_crtc_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/i2c/ch7006.h>
drivers/gpu/drm/nouveau/dispnv04/tvnv17.c +1 -0
@@ -25,6 +25,7 @@*/ #include <drm/drm_crtc_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_probe_helper.h> #include "nouveau_drv.h" #include "nouveau_reg.h"
drivers/gpu/drm/nouveau/dispnv50/head.c +0 -1
@@ -32,7 +32,6 @@#include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_vblank.h> #include "nouveau_connector.h"
drivers/gpu/drm/nouveau/nouveau_drm.c +0 -1
@@ -31,7 +31,6 @@#include <linux/dynamic_debug.h> #include <drm/drm_aperture.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_drv.h> #include <drm/drm_fbdev_generic.h> #include <drm/drm_gem_ttm_helper.h>
drivers/gpu/drm/nouveau/nouveau_vga.c +0 -1
@@ -2,7 +2,6 @@#include <linux/vgaarb.h> #include <linux/vga_switcheroo.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_fb_helper.h> #include "nouveau_drv.h"
Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 14/22 drm/radeon: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/radeon/atombios_crtc.c | 2 +- drivers/gpu/drm/radeon/atombios_encoders.c | 1 + drivers/gpu/drm/radeon/r300.c | 1 - drivers/gpu/drm/radeon/radeon_asic.c | 1 - drivers/gpu/drm/radeon/radeon_connectors.c | 1 + drivers/gpu/drm/radeon/radeon_display.c | 1 + drivers/gpu/drm/radeon/radeon_drv.c | 1 - drivers/gpu/drm/radeon/radeon_encoders.c | 1 - drivers/gpu/drm/radeon/radeon_irq_kms.c | 1 - drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 2 +- drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 2 +- drivers/gpu/drm/radeon/radeon_legacy_tv.c | 1 - drivers/gpu/drm/radeon/radeon_mode.h | 2 +- 13 files changed, 7 insertions(+), 10 deletions(-)
drivers/gpu/drm/radeon/atombios_crtc.c +1 -1
@@ -24,10 +24,10 @@* Alex Deucher */ -#include <drm/drm_crtc_helper.h> #include <drm/drm_fixed.h> #include <drm/drm_fourcc.h> #include <drm/drm_framebuffer.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_vblank.h> #include <drm/radeon_drm.h>
drivers/gpu/drm/radeon/atombios_encoders.c +1 -0
@@ -30,6 +30,7 @@#include <drm/drm_crtc_helper.h> #include <drm/drm_file.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/radeon_drm.h> #include <acpi/video.h>
drivers/gpu/drm/radeon/r300.c +0 -1
@@ -31,7 +31,6 @@#include <linux/slab.h> #include <drm/drm.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_device.h> #include <drm/drm_file.h> #include <drm/radeon_drm.h>
drivers/gpu/drm/radeon/radeon_asic.c +0 -1
@@ -30,7 +30,6 @@#include <linux/pci.h> #include <linux/vgaarb.h> -#include <drm/drm_crtc_helper.h> #include <drm/radeon_drm.h> #include "atom.h"
drivers/gpu/drm/radeon/radeon_connectors.c +1 -0
@@ -27,6 +27,7 @@#include <drm/display/drm_dp_mst_helper.h> #include <drm/drm_edid.h> #include <drm/drm_crtc_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_probe_helper.h> #include <drm/radeon_drm.h> #include "radeon.h"
drivers/gpu/drm/radeon/radeon_display.c +1 -0
@@ -38,6 +38,7 @@#include <drm/drm_fourcc.h> #include <drm/drm_framebuffer.h> #include <drm/drm_gem_framebuffer_helper.h> +#include <drm/drm_modeset_helper.h> #include <drm/drm_probe_helper.h> #include <drm/drm_vblank.h> #include <drm/radeon_drm.h>
drivers/gpu/drm/radeon/radeon_drv.c +0 -1
@@ -38,7 +38,6 @@#include <linux/pci.h> #include <drm/drm_aperture.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_drv.h> #include <drm/drm_file.h> #include <drm/drm_gem.h>
drivers/gpu/drm/radeon/radeon_encoders.c +0 -1
@@ -26,7 +26,6 @@#include <linux/pci.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_device.h> #include <drm/radeon_drm.h>
drivers/gpu/drm/radeon/radeon_irq_kms.c +0 -1
@@ -29,7 +29,6 @@#include <linux/pci.h> #include <linux/pm_runtime.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_device.h> #include <drm/drm_drv.h> #include <drm/drm_probe_helper.h>
drivers/gpu/drm/radeon/radeon_legacy_crtc.c +1 -1
@@ -24,10 +24,10 @@* Alex Deucher */ -#include <drm/drm_crtc_helper.h> #include <drm/drm_fixed.h> #include <drm/drm_fourcc.h> #include <drm/drm_framebuffer.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_vblank.h> #include <drm/radeon_drm.h>
drivers/gpu/drm/radeon/radeon_legacy_encoders.c +1 -1
@@ -27,9 +27,9 @@#include <linux/backlight.h> #include <linux/pci.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_device.h> #include <drm/drm_file.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_util.h> #include <drm/radeon_drm.h>
drivers/gpu/drm/radeon/radeon_legacy_tv.c +0 -1
@@ -1,6 +1,5 @@// SPDX-License-Identifier: MIT -#include <drm/drm_crtc_helper.h> #include <drm/drm_device.h> #include "radeon.h"
drivers/gpu/drm/radeon/radeon_mode.h +1 -1
@@ -35,7 +35,7 @@#include <drm/drm_edid.h> #include <drm/drm_encoder.h> #include <drm/drm_fixed.h> -#include <drm/drm_crtc_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include <linux/i2c.h> #include <linux/i2c-algo-bit.h>
Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 15/22 drm/rockchip: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +0 -1
@@ -25,7 +25,6 @@#include <drm/drm_atomic_uapi.h> #include <drm/drm_blend.h> #include <drm/drm_crtc.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_debugfs.h> #include <drm/drm_flip_work.h> #include <drm/drm_framebuffer.h>
Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 16/22 drm/shmobile: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 2 ++ drivers/gpu/drm/shmobile/shmob_drm_drv.c | 1 - drivers/gpu/drm/shmobile/shmob_drm_plane.c | 1 - 3 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/shmobile/shmob_drm_crtc.c +2 -0
@@ -16,6 +16,8 @@#include <drm/drm_fourcc.h> #include <drm/drm_framebuffer.h> #include <drm/drm_gem_dma_helper.h> +#include <drm/drm_modeset_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_probe_helper.h> #include <drm/drm_simple_kms_helper.h> #include <drm/drm_vblank.h>
drivers/gpu/drm/shmobile/shmob_drm_drv.c +0 -1
@@ -15,7 +15,6 @@#include <linux/pm.h> #include <linux/slab.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_drv.h> #include <drm/drm_gem_dma_helper.h> #include <drm/drm_module.h>
drivers/gpu/drm/shmobile/shmob_drm_plane.c +0 -1
@@ -8,7 +8,6 @@*/ #include <drm/drm_crtc.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_fb_dma_helper.h> #include <drm/drm_fourcc.h> #include <drm/drm_framebuffer.h>
Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 17/22 drm/sprd: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/sprd/sprd_dpu.c | 1 - drivers/gpu/drm/sprd/sprd_drm.c | 1 - drivers/gpu/drm/sprd/sprd_dsi.c | 1 - 3 files changed, 3 deletions(-)
drivers/gpu/drm/sprd/sprd_dpu.c +0 -1
@@ -18,7 +18,6 @@#include <drm/drm_atomic_helper.h> #include <drm/drm_blend.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_fb_dma_helper.h> #include <drm/drm_framebuffer.h> #include <drm/drm_gem_dma_helper.h>
drivers/gpu/drm/sprd/sprd_drm.c +0 -1
@@ -11,7 +11,6 @@#include <linux/of_platform.h> #include <drm/drm_atomic_helper.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_drv.h> #include <drm/drm_gem_dma_helper.h> #include <drm/drm_gem_framebuffer_helper.h>
drivers/gpu/drm/sprd/sprd_dsi.c +0 -1
@@ -13,7 +13,6 @@#include <drm/drm_atomic_helper.h> #include <drm/drm_bridge.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_of.h> #include <drm/drm_probe_helper.h>
Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 18/22 drm/sun4i: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c +1 -1
@@ -8,8 +8,8 @@#include <linux/of_device.h> #include <linux/platform_device.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_of.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_simple_kms_helper.h> #include "sun8i_dw_hdmi.h"
Signature · 1 line
2.39.0
Re: [PATCH 18/22] drm/sun4i: Remove unnecessary include statements for drm_crtc_helper.h
Quoted 17 lines · Thomas Zimmermann
Several source files include
drm_crtc_helper.hwithout needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.Directly include required headers and drop
drm_crtc_helper.hwhere possible.Signed-off-by Thomas Zimmermann <[email protected]>--- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c +0
-0
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c line 12
Quoted 6 lines
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c +1
-1@@ -8,8 +8,8 @@#include <linux/of_device.h> #include <linux/platform_device.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_of.h> +#include <drm/drm_modeset_helper_vtables.h>
Move one up to maintain sorting.
With that fixed:
Quoted 5 lines
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c +0
-0#include <drm/drm_simple_kms_helper.h> #include "sun8i_dw_hdmi.h" Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 19/22 drm/tidss: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/tidss/tidss_crtc.c | 1 - drivers/gpu/drm/tidss/tidss_drv.c | 1 - drivers/gpu/drm/tidss/tidss_encoder.c | 2 +- drivers/gpu/drm/tidss/tidss_kms.c | 1 - drivers/gpu/drm/tidss/tidss_plane.c | 1 - 5 files changed, 1 insertion(+), 5 deletions(-)
drivers/gpu/drm/tidss/tidss_crtc.c +0 -1
@@ -7,7 +7,6 @@#include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_crtc.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_gem_dma_helper.h> #include <drm/drm_vblank.h>
drivers/gpu/drm/tidss/tidss_drv.c +0 -1
@@ -12,7 +12,6 @@#include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_crtc.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_drv.h> #include <drm/drm_fbdev_generic.h> #include <drm/drm_gem_dma_helper.h>
drivers/gpu/drm/tidss/tidss_encoder.c +1 -1
@@ -7,7 +7,7 @@#include <linux/export.h> #include <drm/drm_crtc.h> -#include <drm/drm_crtc_helper.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_panel.h> #include <drm/drm_of.h>
drivers/gpu/drm/tidss/tidss_kms.c +0 -1
@@ -9,7 +9,6 @@#include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_bridge.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/drm_of.h> #include <drm/drm_panel.h>
drivers/gpu/drm/tidss/tidss_plane.c +0 -1
@@ -8,7 +8,6 @@#include <drm/drm_atomic_helper.h> #include <drm/drm_blend.h> #include <drm/drm_crtc.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_fourcc.h> #include <drm/drm_framebuffer.h> #include <drm/drm_gem_atomic_helper.h>
Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 20/22 drm/udl: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/udl/udl_drv.c | 2 +- drivers/gpu/drm/udl/udl_modeset.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/udl/udl_drv.c +1 -1
@@ -5,12 +5,12 @@#include <linux/module.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_drv.h> #include <drm/drm_fbdev_generic.h> #include <drm/drm_file.h> #include <drm/drm_gem_shmem_helper.h> #include <drm/drm_managed.h> +#include <drm/drm_modeset_helper.h> #include <drm/drm_ioctl.h> #include <drm/drm_probe_helper.h> #include <drm/drm_print.h>
drivers/gpu/drm/udl/udl_modeset.c +0 -1
@@ -12,7 +12,6 @@#include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_damage_helper.h> #include <drm/drm_drv.h> #include <drm/drm_edid.h>
Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 21/22 drm/vboxvideo: Remove unnecessary include statements for drm_crtc_helper.h
In reply to Thomas ZimmermannSeveral source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies.
Directly include required headers and drop drm_crtc_helper.h where possible.
--- drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +- drivers/gpu/drm/vboxvideo/vbox_main.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/vboxvideo/vbox_drv.c +1 -1
@@ -12,12 +12,12 @@#include <linux/vt_kern.h> #include <drm/drm_aperture.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_drv.h> #include <drm/drm_fbdev_generic.h> #include <drm/drm_file.h> #include <drm/drm_ioctl.h> #include <drm/drm_managed.h> +#include <drm/drm_modeset_helper.h> #include <drm/drm_module.h> #include "vbox_drv.h"
drivers/gpu/drm/vboxvideo/vbox_main.c +0 -1
@@ -11,7 +11,6 @@#include <linux/pci.h> #include <linux/vbox_err.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_damage_helper.h> #include "vbox_drv.h"
Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerPATCH 22/22 drm/crtc-helper: Remove most include statements from drm_crtc_helper.h
In reply to Thomas ZimmermannRemove most include statements from crm_crtc_helper.h and forward- declare the contained types in drm_crtc_helper.h. Only keep <linux/types.h> for the definition of 'bool'.
--- include/drm/drm_crtc_helper.h | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)
include/drm/drm_crtc_helper.h +9 -5
@@ -33,13 +33,17 @@#ifndef __DRM_CRTC_HELPER_H__#define __DRM_CRTC_HELPER_H__ -#include <linux/spinlock.h> #include <linux/types.h> -#include <linux/idr.h> -#include <drm/drm_crtc.h> -#include <drm/drm_modeset_helper_vtables.h> -#include <drm/drm_modeset_helper.h> +struct drm_atomic_state ; +struct drm_connector ; +struct drm_crtc ; +struct drm_device ; +struct drm_display_mode ; +struct drm_encoder ; +struct drm_framebuffer ; +struct drm_mode_set ; +struct drm_modeset_acquire_ctx ;void drm_helper_disable_unused_functions (struct drm_device *dev); int drm_crtc_helper_set_config(struct drm_mode_set *set,
Signature · 1 line
2.39.0
Quoted 10 lines · Thomas Zimmermann
A lot of source files include
drm_crtc_helper.hfor its contained include statements. This leads to excessive compile-time dependencies.Where possible, remove the include statements for
drm_crtc_helper.hand include the required source files directly. Also remove the include statements fromdrm_crtc_helper.hitself, which doesn't need most of them.I built this patchset on x86-64, aarch64 and arm. Hopefully I found all include dependencies.
I think this is the right direction and I support this. Personally I think it's enough to build test and fix any fallout afterwards.
To that end, I did build test this myself with my config, and it was fine, though that probably doesn't add much coverage.
FWIW,
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Alex Deucher
Acked-byQuoted 16 lines · Jani Nikula
Quoted 10 lines · Thomas Zimmermann
A lot of source files include
drm_crtc_helper.hfor its contained include statements. This leads to excessive compile-time dependencies.Where possible, remove the include statements for
drm_crtc_helper.hand include the required source files directly. Also remove the include statements fromdrm_crtc_helper.hitself, which doesn't need most of them.I built this patchset on x86-64, aarch64 and arm. Hopefully I found all include dependencies.
I think this is the right direction and I support this. Personally I think it's enough to build test and fix any fallout afterwards.
Quoted 6 lines
To that end, I did build test this myself with my config, and it was fine, though that probably doesn't add much coverage.
FWIW,
Acked-by Jani Nikula <[email protected]>
Agreed. I applied 1/22 since it was an unrelated cleanup, but the rest of the series is:
Quoted 4 lines
--
Jani Nikula, Intel Open Source Graphics Center
Thomas Zimmermann
maintainerHi
Am 16.01.23 um 19:37 schrieb Alex Deucher:
Quoted 21 lines
Quoted 19 lines · Jani Nikula
Quoted 10 lines · Thomas Zimmermann
A lot of source files include
drm_crtc_helper.hfor its contained include statements. This leads to excessive compile-time dependencies.Where possible, remove the include statements for
drm_crtc_helper.hand include the required source files directly. Also remove the include statements fromdrm_crtc_helper.hitself, which doesn't need most of them.I built this patchset on x86-64, aarch64 and arm. Hopefully I found all include dependencies.
I think this is the right direction and I support this. Personally I think it's enough to build test and fix any fallout afterwards.
To that end, I did build test this myself with my config, and it was fine, though that probably doesn't add much coverage.
Quoted 7 lines
Quoted 3 lines
FWIW,
Acked-by Jani Nikula <[email protected]>Agreed. I applied 1/22 since it was an unrelated cleanup, but the rest of the series is:
Acked-by Alex Deucher <[email protected]>
Thanks to both of you. I'll leave out the first patch when merging the series.
Best regards
Thomas
Quoted 5 lines
Quoted 5 lines
--
Jani Nikula, Intel Open Source Graphics Center
Signature · 13 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N?rnberg, Germany (HRB 36809, AG N?rnberg) Gesch?ftsf?hrer: Ivo Totev -------------- next part -------------- A non-text attachment was scrubbed... Name: OpenPGP_signature Type: application/pgp-signature Size: 840 bytes Desc: OpenPGP digital signature URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20230117/4dfff3ea/attachment.sig>
Hi Thomas.
Quoted 7 lines · Thomas Zimmermann
A lot of source files include
drm_crtc_helper.hfor its contained include statements. This leads to excessive compile-time dependencies.Where possible, remove the include statements for
drm_crtc_helper.hand include the required source files directly. Also remove the include statements fromdrm_crtc_helper.hitself, which doesn't need most of them.
With this patchset drm_crtc_helper usage is reduced from 85 places to 35 places. And the 35 places is only .c files.
This is a very nice reduction of bloat! I hope this has a measureable effect on building times.
I was working on something similar, but that approach only added missing includes, and did not kill all the unnessesary includes - which I think is the biggest win here.
All patches are:
For a few of them the r-b is conditional, see the specific comments posted.
I did a build check here with the archs and config I verifies with. This covers "alpha arm arm64 sparc64 i386 x86 powerpc s390 riscv sh" and everything was fine. I have a few specific configs to pull in drivers that need a bit extra to be built.
So I consider build coverage OK for applying, but it would be nice to wait a few days for the bots to verify too.
My own work on slimming drm_atomic_helper.h and drm_print.h will be rebased on top of your work before I continue it.
I need to look into removing unused includes too.
Sam
Quoted 146 lines
I built this patchset on x86-64, aarch64 and arm. Hopefully I found all include dependencies.
Thanks to Sam Ravnborg for bringing this to my attention.
Thomas Zimmermann (22):
drm/amdgpu: Fix coding style
drm: Remove unnecessary include statements fordrm_crtc_helper.hdrm/amdgpu: Remove unnecessary include statements for
drm_crtc_helper.h
drm/arm/komeda: Remove unnecessary include statements for
drm_crtc_helper.h
drm/aspeed: Remove unnecessary include statements for
drm_crtc_helper.h
drm/ast: Remove unnecessary include statements fordrm_crtc_helper.hdrm/bridge: Remove unnecessary include statements for
drm_crtc_helper.h
drm/gma500: Remove unnecessary include statements for
drm_crtc_helper.h
drm/i2c/ch7006: Remove unnecessary include statements for
drm_crtc_helper.h
drm/ingenic: Remove unnecessary include statements for
drm_crtc_helper.h
drm/kmb: Remove unnecessary include statements fordrm_crtc_helper.hdrm/logicvc: Remove unnecessary include statements for
drm_crtc_helper.h
drm/nouveau: Remove unnecessary include statements for
drm_crtc_helper.h
drm/radeon: Remove unnecessary include statements for
drm_crtc_helper.h
drm/rockchip: Remove unnecessary include statements for
drm_crtc_helper.h
drm/shmobile: Remove unnecessary include statements for
drm_crtc_helper.h
drm/sprd: Remove unnecessary include statements fordrm_crtc_helper.hdrm/sun4i: Remove unnecessary include statements fordrm_crtc_helper.hdrm/tidss: Remove unnecessary include statements fordrm_crtc_helper.hdrm/udl: Remove unnecessary include statements fordrm_crtc_helper.hdrm/vboxvideo: Remove unnecessary include statements for
drm_crtc_helper.h
drm/crtc-helper: Remove most include statements fromdrm_crtc_helper.hdrivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 - drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 1 - drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 1 - drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 ++ drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 1 - drivers/gpu/drm/arm/display/komeda/komeda_kms.h | 1 - drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c | 1 - drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 1 - drivers/gpu/drm/aspeed/aspeed_gfx_out.c | 1 - drivers/gpu/drm/ast/ast_drv.c | 1 - drivers/gpu/drm/ast/ast_main.c | 1 - drivers/gpu/drm/ast/ast_mode.c | 1 - drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 1 - drivers/gpu/drm/bridge/analogix/anx7625.c | 1 - .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 1 - drivers/gpu/drm/bridge/ite-it6505.c | 1 - drivers/gpu/drm/bridge/ite-it66121.c | 1 - drivers/gpu/drm/bridge/tc358768.c | 1 - drivers/gpu/drm/bridge/tc358775.c | 1 - drivers/gpu/drm/drm_crtc_helper.c | 1 - drivers/gpu/drm/drm_lease.c | 2 +- drivers/gpu/drm/drm_plane_helper.c | 1 - drivers/gpu/drm/gma500/cdv_device.c | 1 + drivers/gpu/drm/gma500/cdv_intel_crt.c | 2 ++ drivers/gpu/drm/gma500/cdv_intel_display.c | 1 + drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 + drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2 ++ drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 ++ drivers/gpu/drm/gma500/framebuffer.c | 2 ++ drivers/gpu/drm/gma500/gma_display.c | 2 ++ drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 + drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 ++ drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 + drivers/gpu/drm/gma500/psb_device.c | 1 + drivers/gpu/drm/gma500/psb_intel_display.c | 3 +++ drivers/gpu/drm/gma500/psb_intel_drv.h | 1 - drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 ++ drivers/gpu/drm/gma500/psb_intel_sdvo.c | 2 ++ drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++ drivers/gpu/drm/i2c/ch7006_priv.h | 1 - drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 - drivers/gpu/drm/kmb/kmb_crtc.c | 1 - drivers/gpu/drm/kmb/kmb_plane.c | 1 - drivers/gpu/drm/logicvc/logicvc_interface.c | 1 - drivers/gpu/drm/logicvc/logicvc_mode.c | 1 - drivers/gpu/drm/nouveau/dispnv04/crtc.c | 1 + drivers/gpu/drm/nouveau/dispnv04/dac.c | 2 +- drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +- drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c | 1 - drivers/gpu/drm/nouveau/dispnv04/tvnv04.c | 2 +- drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 1 + drivers/gpu/drm/nouveau/dispnv50/head.c | 1 - drivers/gpu/drm/nouveau/nouveau_drm.c | 1 - drivers/gpu/drm/nouveau/nouveau_vga.c | 1 - drivers/gpu/drm/radeon/atombios_crtc.c | 2 +- drivers/gpu/drm/radeon/atombios_encoders.c | 1 + drivers/gpu/drm/radeon/r300.c | 1 - drivers/gpu/drm/radeon/radeon_asic.c | 1 - drivers/gpu/drm/radeon/radeon_connectors.c | 1 + drivers/gpu/drm/radeon/radeon_display.c | 1 + drivers/gpu/drm/radeon/radeon_drv.c | 1 - drivers/gpu/drm/radeon/radeon_encoders.c | 1 - drivers/gpu/drm/radeon/radeon_irq_kms.c | 1 - drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 2 +- drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 2 +- drivers/gpu/drm/radeon/radeon_legacy_tv.c | 1 - drivers/gpu/drm/radeon/radeon_mode.h | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 - drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 2 ++ drivers/gpu/drm/shmobile/shmob_drm_drv.c | 1 - drivers/gpu/drm/shmobile/shmob_drm_plane.c | 1 - drivers/gpu/drm/sprd/sprd_dpu.c | 1 - drivers/gpu/drm/sprd/sprd_drm.c | 1 - drivers/gpu/drm/sprd/sprd_dsi.c | 1 - drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +- drivers/gpu/drm/tidss/tidss_crtc.c | 1 - drivers/gpu/drm/tidss/tidss_drv.c | 1 - drivers/gpu/drm/tidss/tidss_encoder.c | 2 +- drivers/gpu/drm/tidss/tidss_kms.c | 1 - drivers/gpu/drm/tidss/tidss_plane.c | 1 - drivers/gpu/drm/udl/udl_drv.c | 2 +- drivers/gpu/drm/udl/udl_modeset.c | 1 - drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +- drivers/gpu/drm/vboxvideo/vbox_main.c | 1 - include/drm/drm_crtc_helper.h | 14 +++++++++----- include/drm/drm_fixed.h | 1 + 94 files changed, 70 insertions(+), 70 deletions(-)base-commit:
68d139b609a97a83e7c231189d4864aba4e1679b
prerequisite-patch-id:0aa359f6144c4015c140c8a6750be19099c676fb
prerequisite-patch-id:c67e5d886a47b7d0266d81100837557fda34cb24
prerequisite-patch-id:3f204510fcbf9530d6540bd8e6128cce598988b6Signature · 1 line
2.39.0
Thomas Zimmermann
maintainerHi
Am 16.01.23 um 21:47 schrieb Sam Ravnborg:
Quoted 6 lines
Hi Thomas.
Quoted 3 lines · Thomas Zimmermann
A lot of source files include
drm_crtc_helper.hfor its contained include statements. This leads to excessive compile-time dependencies.
Quoted 8 lines
Quoted 4 lines
Where possible, remove the include statements for
drm_crtc_helper.hand include the required source files directly. Also remove the include statements fromdrm_crtc_helper.hitself, which doesn't need most of them.With this patchset
drm_crtc_helperusage is reduced from 85 places to 35 places. And the 35 places is only .c files.
This is a very nice reduction of bloat! I hope this has a measureable effect on building times.
I cannot say what the effect is for a single header, but if we do this for all header files, the effect is measureable.
Quoted 7 lines
I was working on something similar, but that approach only added missing includes, and did not kill all the unnessesary includes - which I think is the biggest win here.
All patches are:
Reviewed-by Sam Ravnborg <[email protected]>
Thank you.
Quoted 3 lines
For a few of them the r-b is conditional, see the specific comments posted.
I fixed all your comments, including the minor complaint about the commit messages.
I don't intent to send out a v2 here, but the fixed patches should soon show up in drm-misc-next.
Best regards
Thomas
Quoted 161 lines
I did a build check here with the archs and config I verifies with. This covers "alpha arm arm64 sparc64 i386 x86 powerpc s390 riscv sh" and everything was fine. I have a few specific configs to pull in drivers that need a bit extra to be built.
So I consider build coverage OK for applying, but it would be nice to wait a few days for the bots to verify too.My own work on slimming
drm_atomic_helper.handdrm_print.hwill be rebased on top of your work before I continue it.
I need to look into removing unused includes too.Sam
Quoted 146 lines
I built this patchset on x86-64, aarch64 and arm. Hopefully I found all include dependencies.
Thanks to Sam Ravnborg for bringing this to my attention.
Thomas Zimmermann (22):
drm/amdgpu: Fix coding style
drm: Remove unnecessary include statements fordrm_crtc_helper.hdrm/amdgpu: Remove unnecessary include statements for
drm_crtc_helper.h
drm/arm/komeda: Remove unnecessary include statements for
drm_crtc_helper.h
drm/aspeed: Remove unnecessary include statements for
drm_crtc_helper.h
drm/ast: Remove unnecessary include statements fordrm_crtc_helper.hdrm/bridge: Remove unnecessary include statements for
drm_crtc_helper.h
drm/gma500: Remove unnecessary include statements for
drm_crtc_helper.h
drm/i2c/ch7006: Remove unnecessary include statements for
drm_crtc_helper.h
drm/ingenic: Remove unnecessary include statements for
drm_crtc_helper.h
drm/kmb: Remove unnecessary include statements fordrm_crtc_helper.hdrm/logicvc: Remove unnecessary include statements for
drm_crtc_helper.h
drm/nouveau: Remove unnecessary include statements for
drm_crtc_helper.h
drm/radeon: Remove unnecessary include statements for
drm_crtc_helper.h
drm/rockchip: Remove unnecessary include statements for
drm_crtc_helper.h
drm/shmobile: Remove unnecessary include statements for
drm_crtc_helper.h
drm/sprd: Remove unnecessary include statements fordrm_crtc_helper.hdrm/sun4i: Remove unnecessary include statements fordrm_crtc_helper.hdrm/tidss: Remove unnecessary include statements fordrm_crtc_helper.hdrm/udl: Remove unnecessary include statements fordrm_crtc_helper.hdrm/vboxvideo: Remove unnecessary include statements for
drm_crtc_helper.h
drm/crtc-helper: Remove most include statements fromdrm_crtc_helper.hdrivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 - drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 1 - drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 1 - drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 ++ drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 1 - drivers/gpu/drm/arm/display/komeda/komeda_kms.h | 1 - drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c | 1 - drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 1 - drivers/gpu/drm/aspeed/aspeed_gfx_out.c | 1 - drivers/gpu/drm/ast/ast_drv.c | 1 - drivers/gpu/drm/ast/ast_main.c | 1 - drivers/gpu/drm/ast/ast_mode.c | 1 - drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 1 - drivers/gpu/drm/bridge/analogix/anx7625.c | 1 - .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 1 - drivers/gpu/drm/bridge/ite-it6505.c | 1 - drivers/gpu/drm/bridge/ite-it66121.c | 1 - drivers/gpu/drm/bridge/tc358768.c | 1 - drivers/gpu/drm/bridge/tc358775.c | 1 - drivers/gpu/drm/drm_crtc_helper.c | 1 - drivers/gpu/drm/drm_lease.c | 2 +- drivers/gpu/drm/drm_plane_helper.c | 1 - drivers/gpu/drm/gma500/cdv_device.c | 1 + drivers/gpu/drm/gma500/cdv_intel_crt.c | 2 ++ drivers/gpu/drm/gma500/cdv_intel_display.c | 1 + drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 + drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2 ++ drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 ++ drivers/gpu/drm/gma500/framebuffer.c | 2 ++ drivers/gpu/drm/gma500/gma_display.c | 2 ++ drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 + drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 ++ drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 + drivers/gpu/drm/gma500/psb_device.c | 1 + drivers/gpu/drm/gma500/psb_intel_display.c | 3 +++ drivers/gpu/drm/gma500/psb_intel_drv.h | 1 - drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 ++ drivers/gpu/drm/gma500/psb_intel_sdvo.c | 2 ++ drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++ drivers/gpu/drm/i2c/ch7006_priv.h | 1 - drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 - drivers/gpu/drm/kmb/kmb_crtc.c | 1 - drivers/gpu/drm/kmb/kmb_plane.c | 1 - drivers/gpu/drm/logicvc/logicvc_interface.c | 1 - drivers/gpu/drm/logicvc/logicvc_mode.c | 1 - drivers/gpu/drm/nouveau/dispnv04/crtc.c | 1 + drivers/gpu/drm/nouveau/dispnv04/dac.c | 2 +- drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +- drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c | 1 - drivers/gpu/drm/nouveau/dispnv04/tvnv04.c | 2 +- drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 1 + drivers/gpu/drm/nouveau/dispnv50/head.c | 1 - drivers/gpu/drm/nouveau/nouveau_drm.c | 1 - drivers/gpu/drm/nouveau/nouveau_vga.c | 1 - drivers/gpu/drm/radeon/atombios_crtc.c | 2 +- drivers/gpu/drm/radeon/atombios_encoders.c | 1 + drivers/gpu/drm/radeon/r300.c | 1 - drivers/gpu/drm/radeon/radeon_asic.c | 1 - drivers/gpu/drm/radeon/radeon_connectors.c | 1 + drivers/gpu/drm/radeon/radeon_display.c | 1 + drivers/gpu/drm/radeon/radeon_drv.c | 1 - drivers/gpu/drm/radeon/radeon_encoders.c | 1 - drivers/gpu/drm/radeon/radeon_irq_kms.c | 1 - drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 2 +- drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 2 +- drivers/gpu/drm/radeon/radeon_legacy_tv.c | 1 - drivers/gpu/drm/radeon/radeon_mode.h | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 - drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 2 ++ drivers/gpu/drm/shmobile/shmob_drm_drv.c | 1 - drivers/gpu/drm/shmobile/shmob_drm_plane.c | 1 - drivers/gpu/drm/sprd/sprd_dpu.c | 1 - drivers/gpu/drm/sprd/sprd_drm.c | 1 - drivers/gpu/drm/sprd/sprd_dsi.c | 1 - drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +- drivers/gpu/drm/tidss/tidss_crtc.c | 1 - drivers/gpu/drm/tidss/tidss_drv.c | 1 - drivers/gpu/drm/tidss/tidss_encoder.c | 2 +- drivers/gpu/drm/tidss/tidss_kms.c | 1 - drivers/gpu/drm/tidss/tidss_plane.c | 1 - drivers/gpu/drm/udl/udl_drv.c | 2 +- drivers/gpu/drm/udl/udl_modeset.c | 1 - drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +- drivers/gpu/drm/vboxvideo/vbox_main.c | 1 - include/drm/drm_crtc_helper.h | 14 +++++++++----- include/drm/drm_fixed.h | 1 + 94 files changed, 70 insertions(+), 70 deletions(-)base-commit:
68d139b609a97a83e7c231189d4864aba4e1679b
prerequisite-patch-id:0aa359f6144c4015c140c8a6750be19099c676fb
prerequisite-patch-id:c67e5d886a47b7d0266d81100837557fda34cb24
prerequisite-patch-id:3f204510fcbf9530d6540bd8e6128cce598988b6Signature · 1 line
2.39.0
Signature · 13 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N?rnberg, Germany (HRB 36809, AG N?rnberg) Gesch?ftsf?hrer: Ivo Totev -------------- next part -------------- A non-text attachment was scrubbed... Name: OpenPGP_signature Type: application/pgp-signature Size: 840 bytes Desc: OpenPGP digital signature URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20230117/e5f452ac/attachment.sig>