Skip to contentSkip to conversation

Adjustments in function call

PATCH RESEND Superseded Javier F. Arias 2 participants 4 messages Oct 27, 2019 Staging

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v3 cover Adjustments in function call

This patchset fixes a warning and simplify a boolean expression in a function call.

V2: Update the message of the second commit to include the updated
patch version and to use the Suggested-By tag.
V3: Update the first commit to include the Suggested-By tag and
the second commit to update the patch version.

Javier F. Arias (2):
staging: rtl8723bs: Fix line over 80 characters
staging: rtl8723bs: Simplify boolean expression

 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.20.1
#1 lore raw

PATCH RESEND v3 1/2 staging: rtl8723bs: Fix line over 80 characters.

Fix line over 80 characters by wrapping arguments in function call.

---
Changes in V2:
- Edit the commit message to use the Suggested-by tag.

 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +3 -1
index c514cb735afd..0c2f3b2d4326 100644
@@ -188,7 +188,9 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
 
 		bBtDisabled = hal_btcoex_IsBtDisabled(Adapter);
 
-		ODM_CmnInfoUpdate(&pHalData->odmpriv, ODM_CMNINFO_BT_ENABLED, ((bBtDisabled == true)?false:true));
+		ODM_CmnInfoUpdate(&pHalData->odmpriv,
+				  ODM_CMNINFO_BT_ENABLED,
+				  ((bBtDisabled == true)?false:true));
 
 		ODM_DMWatchdog(&pHalData->odmpriv);
 	}
Signature · 1 line
2.20.1
maintainer
#2 lore raw

Re: [RESEND PATCH v3 1/2] staging: rtl8723bs: Fix line over 80 characters.

Quoted 4 lines · Javier F. Arias

Fix line over 80 characters by wrapping arguments in function call.

Need a blank line before the "Suggested-by:" and not after it.

Quoted 12 lines

---
Changes in V2:
- Edit the commit message to use the Suggested-by tag.

 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +0 -0
index c514cb735afd..0c2f3b2d4326 100644

drivers/staging/rtl8723bs/hal/rtl8723b_dm.c void rtl8723b_HalDmWatchDog(struct adapter *Adapter) · line 193

Quoted 7 lines
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +3 -1
@@ -188,7 +188,9 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
 
 		bBtDisabled = hal_btcoex_IsBtDisabled(Adapter);
 
-		ODM_CmnInfoUpdate(&pHalData->odmpriv, ODM_CMNINFO_BT_ENABLED, ((bBtDisabled == true)?false:true));
+		ODM_CmnInfoUpdate(&pHalData->odmpriv,
+				  ODM_CMNINFO_BT_ENABLED,
+				  ((bBtDisabled == true)?false:true));

Why does this have to be 3 lines and not 2?

thanks,

greg k-h

#3 lore raw

PATCH RESEND v3 2/2 staging: rtl8723bs: Simplify boolean expression

In reply to Javier F. Arias

Simplify expression that it's inverting a boolean value. Issue found by Coccinelle.

---
Changes in V2:
- Remove the parentheses around the variable.

 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +1 -1
index 0c2f3b2d4326..6f341d52afb6 100644
@@ -190,7 +190,7 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
 
 		ODM_CmnInfoUpdate(&pHalData->odmpriv,
 				  ODM_CMNINFO_BT_ENABLED,
-				  ((bBtDisabled == true)?false:true));
+				  !bBtDisabled);
 
 		ODM_DMWatchdog(&pHalData->odmpriv);
 	}
Signature · 1 line
2.20.1