Skip to contentSkip to conversation

Adjustments in function call

PATCH RESEND In review Javier F. Arias 2 participants 6 messages Oct 30, 2019 – Nov 1, 2019 Staging

lore
Share & tools
lore
#0 lore raw

v5 cover Adjustments in function call

This patchset fixes a warning and simplify a boolean expression in a function call.

V2: Update the message of the second commit to include the updated
patch version and to use the Suggested-By tag.
V3: Update the first commit to include the Suggested-By tag and
the second commit to update the patch version.
V4: Correct the format of the first commit to use the Suggested-by
tag properly.
V5: Add the version revision that wasn't included in the previous
patchset.

Javier F. Arias (2):
staging: rtl8723bs: Fix line over 80 characters
staging: rtl8723bs: Simplify boolean expression

 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.20.1
#1 lore raw

PATCH RESEND v5 1/2 staging: rtl8723bs: Fix line over 80 characters

Fix line over 80 characters by wrapping arguments in function call.

---
Changes in V3:
- Edit the commit message to properly use the Suggested-by tag.
Changes in V2:
- Edit the commit message to use the Suggested-by tag.

 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +3 -1
index c514cb735afd..0c2f3b2d4326 100644
@@ -188,7 +188,9 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
 
 		bBtDisabled = hal_btcoex_IsBtDisabled(Adapter);
 
-		ODM_CmnInfoUpdate(&pHalData->odmpriv, ODM_CMNINFO_BT_ENABLED, ((bBtDisabled == true)?false:true));
+		ODM_CmnInfoUpdate(&pHalData->odmpriv,
+				  ODM_CMNINFO_BT_ENABLED,
+				  ((bBtDisabled == true)?false:true));
 
 		ODM_DMWatchdog(&pHalData->odmpriv);
 	}
Signature · 1 line
2.20.1
maintainer
#2 lore raw

Re: [RESEND PATCH v5 1/2] staging: rtl8723bs: Fix line over 80 characters

Quoted 10 lines · Javier F. Arias

Fix line over 80 characters by wrapping arguments in function call.

---
Changes in V3:
- Edit the commit message to properly use the Suggested-by tag.
Changes in V2:
- Edit the commit message to use the Suggested-by tag.

This is a v5 patch, but you only show what happened in v2 and v3, what about the other 2?

Also, you don't seem to have changed this patch from my last review, why not? I will not take this as-is, sorry. Please fix up and send a new version based on that review.

thanks,

greg k-h

#3 lore raw

Re: [Outreachy kernel] Re: [RESEND PATCH v5 1/2] staging: rtl8723bs: Fix line over 80 characters

Quoted 15 lines · Greg KH
Quoted 10 lines · Javier F. Arias

Fix line over 80 characters by wrapping arguments in function call.

---
Changes in V3:
- Edit the commit message to properly use the Suggested-by tag.
Changes in V2:
- Edit the commit message to use the Suggested-by tag.

This is a v5 patch, but you only show what happened in v2 and v3, what about the other 2?

Quoted 12 lines

Also, you don't seem to have changed this patch from my last review, why not? I will not take this as-is, sorry. Please fix up and send a new version based on that review.

thanks,

greg k-h

Signature · 3 lines
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191030092456.GA637833%40kroah.com.

I'm resending this email because my neomutt skipped the list.

Hello Greg,

Sorry, the V4 of this patchset was wrong as I forgot to add the versions on the first patch, so I stopped before sending the second patch and created V5.

About the V5, I think I did what you suggested, as I added a blank line before the Suggested-by tag and deleted the blank line after it.

I'm trying to implement all the suggestions I receive, it's just that I made a couple of mistakes with this patchset (despite being very short), so this is +why it got to V5. I'll correct all these issues.

#4 lore raw

Re: [Outreachy kernel] Re: [RESEND PATCH v5 1/2] staging: rtl8723bs: Fix line over 80 characters

In reply to Greg KH

Hello Greg,

I've updated the patch and decided to drop the coverletter. Now all the changes are clearly defined. I also added your suggestion about the argument wrapping that I didn't see the first time.

Thanks.

Quoted 27 lines · Greg KH
Quoted 10 lines · Javier F. Arias

Fix line over 80 characters by wrapping arguments in function call.

---
Changes in V3:
- Edit the commit message to properly use the Suggested-by tag.
Changes in V2:
- Edit the commit message to use the Suggested-by tag.

This is a v5 patch, but you only show what happened in v2 and v3, what about the other 2?

Also, you don't seem to have changed this patch from my last review, why not? I will not take this as-is, sorry. Please fix up and send a new version based on that review.

thanks,

greg k-h

Signature · 3 lines
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191030092456.GA637833%40kroah.com.
#5 lore raw

PATCH RESEND v5 2/2 staging: rtl8723bs: Simplify boolean expression

In reply to Javier F. Arias

Simplify expression that it's inverting a boolean value. Issue found by Coccinelle.

---
Changes in V2:
- Edit the commit message to use the Suggested-by tag.

 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +1 -1
index 0c2f3b2d4326..6f341d52afb6 100644
@@ -190,7 +190,7 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
 
 		ODM_CmnInfoUpdate(&pHalData->odmpriv,
 				  ODM_CMNINFO_BT_ENABLED,
-				  ((bBtDisabled == true)?false:true));
+				  !bBtDisabled);
 
 		ODM_DMWatchdog(&pHalData->odmpriv);
 	}
Signature · 1 line
2.20.1