Skip to contentSkip to conversation

staging: rtl8723bs: Fix line over 80 characters

PATCH RESEND New Javier F. Arias 1 participant 2 messages Nov 1, 2019 1 message not in the archive Staging

v4 of 5 New Latest is v5 →

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH RESEND v4 1/2 staging: rtl8723bs: Fix line over 80 characters

Fix line over 80 characters by wrapping arguments in function call.

--
Changes in V4:
- Changed the number of arguments before wrapping to make the code more readable.
Changes in V3:
- Edit the commit message to properly use the Suggested-by tag.
Changes in V2:
- Edit the commit message to use the Suggested-by tag.

 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +2 -1
index c514cb735afd..a94462a48692 100644
@@ -188,7 +188,8 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
 
 		bBtDisabled = hal_btcoex_IsBtDisabled(Adapter);
 
-		ODM_CmnInfoUpdate(&pHalData->odmpriv, ODM_CMNINFO_BT_ENABLED, ((bBtDisabled == true)?false:true));
+		ODM_CmnInfoUpdate(&pHalData->odmpriv, ODM_CMNINFO_BT_ENABLED,
+				  ((bBtDisabled == true)?false:true));
 
 		ODM_DMWatchdog(&pHalData->odmpriv);
 	}
Signature · 1 line
2.20.1
#2 lore raw

PATCH RESEND v4 2/2 staging: rtl8723bs: Simplify boolean expression

In reply to a message not in the archive

Simplify expression that it's inverting a boolean value. Issue found by Coccinelle.

---
Changes in V4:
- No changes.
Changes in V3:
- No changes.
Changes in V2:
- Remove unnecessary parentheses.

 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +1 -1
index a94462a48692..650fbedd34e8 100644
@@ -189,7 +189,7 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
 		bBtDisabled = hal_btcoex_IsBtDisabled(Adapter);
 
 		ODM_CmnInfoUpdate(&pHalData->odmpriv, ODM_CMNINFO_BT_ENABLED,
-				  ((bBtDisabled == true)?false:true));
+				  !bBtDisabled);
 
 		ODM_DMWatchdog(&pHalData->odmpriv);
 	}
Signature · 1 line
2.20.1