Skip to contentSkip to conversation

ALSA: hda/conexant - Add quirks for lenovo notebooks

PATCH Takashi Iwai 1 participant 2 messages Oct 18, 2011 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

At Tue, 18 Oct 2011 12:20:28 +0200,

Quoted 10 lines · Torsten Hilbrich

The lenovo sandy bridge notebooks (T420, T520, L520) didn't work with the external sound input and output connectors on the dockig unit (tested with P/N 45N5887).

Loading snd-hda-intel with model=thinkpad solved the problem so I added the accordings quirks to perform that decision automatically for these specific models.

Could you check whether model=auto with the latest kernel work? Basically I won't take any more the model-specific quirk but move all to the auto-parser as much as possible.

thanks,

Takashi

Quoted 23 lines
---
 sound/pci/hda/patch_conexant.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
sound/pci/hda/patch_conexant.c +3 -0
index 502fc94..90a6b98 100644
@@ -3110,8 +3110,11 @@ static const struct snd_pci_quirk cxt5066_cfg_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x21c5, "Thinkpad Edge 13", CXT5066_THINKPAD),
 	SND_PCI_QUIRK(0x17aa, 0x21c6, "Thinkpad Edge 13", CXT5066_ASUS),
  	SND_PCI_QUIRK(0x17aa, 0x215e, "Lenovo Thinkpad", CXT5066_THINKPAD),
+	SND_PCI_QUIRK(0x17aa, 0x21ce, "Lenovo T420", CXT5066_THINKPAD),
+	SND_PCI_QUIRK(0x17aa, 0x21cf, "Lenovo T520", CXT5066_THINKPAD),
 	SND_PCI_QUIRK(0x17aa, 0x21da, "Lenovo X220", CXT5066_THINKPAD),
 	SND_PCI_QUIRK(0x17aa, 0x21db, "Lenovo X220-tablet", CXT5066_THINKPAD),
+	SND_PCI_QUIRK(0x17aa, 0x21de, "Lenovo L520", CXT5066_THINKPAD),
 	SND_PCI_QUIRK(0x17aa, 0x3a0d, "Lenovo U350", CXT5066_ASUS),
 	SND_PCI_QUIRK(0x17aa, 0x38af, "Lenovo G560", CXT5066_ASUS),
 	SND_PCI_QUIRK(0x17aa, 0x3938, "Lenovo G565", CXT5066_AUTO),
Signature · 1 line
1.7.5.4

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

At Tue, 18 Oct 2011 14:05:53 +0200,

Quoted 13 lines · Torsten Hilbrich

Am 18.10.2011 12:57, schrieb Takashi Iwai:

Quoted 11 lines

At Tue, 18 Oct 2011 12:20:28 +0200,

Quoted 9 lines · Torsten Hilbrich

The lenovo sandy bridge notebooks (T420, T520, L520) didn't work with the external sound input and output connectors on the dockig unit (tested with P/N 45N5887).

Loading snd-hda-intel with model=thinkpad solved the problem so I added the accordings quirks to perform that decision automatically for these specific models.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Could you check whether model=auto with the latest kernel work? Basically I won't take any more the model-specific quirk but move all to the auto-parser as much as possible.

I just checked with upstream v3.1-rc10, model=auto didn't solve the problem on the Lenovo T520.

OK, so it's a bug of BIOS. BIOS doesn't provide the pin for docking-station.

The right fix in this case is to provide the pin config table. In sound git tree, there is a fix for Lenovo X200. A similar entry would work for you.
git://github.com/tiwai/sound.git

Check either topic/hda, for-next or master branch.

Quoted 23 lines

Here are some dmesg output with model=auto:

snd_hda_intel 0000:00:1b.0: PCI INT A -> GSI 22 (level, low) -> IRQ 22 snd_hda_intel 0000:00:1b.0: irq 45 for MSI/MSI-X snd_hda_intel 0000:00:1b.0: setting latency timer to 64
hda-intel: chipset global capabilities = 0x4401
hda-intel: Clearing TCSEL
hda-intel: HDA snoop disabled, enabling ... OK
hda-intel: codec_mask = 0xb
hda-intel: codec #0 probed OK
hda-intel: codec #1 probed OK
hda-intel: codec #3 probed OK
IBM TrackPoint firmware: 0x0e, buttons: 3/3
hda_codec: model 'auto' is selected
hda_codec: CX20590: BIOS auto-probing.
autoconfig: line_outs=1 (0x1f/0x0/0x0/0x0/0x0) type:speaker
speaker_outs=0 (0x0/0x0/0x0/0x0/0x0)
hp_outs=1 (0x19/0x0/0x0/0x0/0x0)
mono: mono_out=0x0
inputs: Mic=0x1b Internal Mic=0x23

when playing some audio:

Quoted 8 lines

hda-intel: azx_pcm_prepare: bufsize=0x10000, format=0x31
hda_codec_setup_stream: NID=0x10, stream=0x5, channel=0, format=0x31
hda_codec_setup_stream: NID=0x11, stream=0x5, channel=0, format=0x31
hda_codec_cleanup_stream: NID=0x10
hda_codec_cleanup_stream: NID=0x11

I will attach the codec#x files from /proc/asound/PCH if you need this information.

At best, please give alsa-info.sh output (run with --no-upload option).

thanks,

Takashi