Skip to content

Add initial zynqmp R5 remoteproc driver

Ben Levinsky linux-arm-kernel linux-devicetree linux-remoteproc lkml 27 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v26 Latest5 patches 13 repliesIn review
  2. v255 patches 9 repliesSuperseded
  3. v245 patches 7 repliesSuperseded
Earlier versions · 24
VersionPostedPatchesRepliesStatus
v235 patches4 repliesSuperseded
v225 patches3 repliesSuperseded
v215 patches4 repliesSuperseded
v205 patches1 replySuperseded
v195 patches3 repliesSuperseded
v185 patches14 repliesSuperseded
v175 patches2 repliesSuperseded
v165 patches4 repliesSuperseded
v155 patches2 repliesSuperseded
v145 patches13 repliesSuperseded
v135 patches3 repliesSuperseded
v125 patches1 replySuperseded
v115 patches2 repliesSuperseded
v9 posting 2/20 of 5 patches3 repliesSuperseded
v105 patches1 replySuperseded
v9 posting 1/25 patches4 repliesSuperseded
v85 patches13 repliesSuperseded
v75 patches0 repliesSuperseded
v65 patches4 repliesSuperseded
v55 patches8 repliesSuperseded
v45 patches11 repliesSuperseded
v35 patches6 repliesSuperseded
v25 patches2 repliesSuperseded
v15 patches7 repliesSuperseded

Changes in v26 from the cover letter

- add prepare and unprepare to handle Xilinx platform management's request_node and release node using each core's list of srams that is constructed in each core's zynqmp_r5_probe.
- add new field sram to zynqmp_r5_rproc to store each core's srams being used as described in device tree. This helps to reduce unneeded looping of the sram prop in device tree. As now only zynqmp_r5_probe has to parse and validate each core's sram property. The ensuing prepare, unprepare and parse_fw logic are now much simpler.
- similarly add 'size' field to struct sram_addr_data to simplify prepare, unprepare and parse_fw.

Patches in v26 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.include/linux/firmware/xlnx-zynqmp.h+23 -00 replies
2/5firmware: xilinx: Add shutdown/wakeup APIsdrivers/firmware/xilinx/zynqmp.c include/linux/firmware/xlnx-zynqmp.h+58 -00 replies
3/5firmware: xilinx: Add RPU configuration APIsdrivers/firmware/xilinx/zynqmp.c include/linux/firmware/xlnx-zynqmp.h+79 -00 replies
4/5dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindingsDocumentation/devicetree/bindings/remoteproc/xilinx,zynqmp-r5-remoteproc.yaml+223 -00 replies
5/5remoteproc: Add initial zynqmp R5 remoteproc driverdrivers/remoteproc/Kconfig drivers/remoteproc/Makefile drivers/remoteproc/zynqmp_r5_remoteproc.c+963 -012 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v26 yet.

Read the v26 thread

Cover letter [PATCH v26 0/5] Add initial zynqmp R5 remoteproc driver

R5 is included in Xilinx Zynq UltraScale MPSoC so by adding this remotproc driver, we can boot the R5 sub-system in two different configurations -
* Split
* Lockstep

The Xilinx R5 Remoteproc Driver boots the R5's via calls to the Xilinx Platform Management Unit that handles the R5 configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls.

v26:
- add prepare and unprepare to handle Xilinx platform management's request_node and release node using each core's list of srams that is constructed in each core's zynqmp_r5_probe.
- add new field sram to zynqmp_r5_rproc to store each core's srams being used as described in device tree. This helps to reduce unneeded looping of the sram prop in device tree. As now only zynqmp_r5_probe has to parse and validate each core's sram property. The ensuing prepare, unprepare and parse_fw logic are now much simpler.
- similarly add 'size' field to struct sram_addr_data to simplify prepare, unprepare and parse_fw.

Previous version:
https://patchwork.kernel.org/project/linux-remoteproc/list/?series=412083

Ben Levinsky (5):
firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU
configuration.
firmware: xilinx: Add shutdown/wakeup APIs
firmware: xilinx: Add RPU configuration APIs
dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc
bindings
remoteproc: Add initial zynqmp R5 remoteproc driver

 .../xilinx,zynqmp-r5-remoteproc.yaml          | 223 ++++
 drivers/firmware/xilinx/zynqmp.c              |  96 ++
 drivers/remoteproc/Kconfig                    |   8 +
 drivers/remoteproc/Makefile                   |   1 +
 drivers/remoteproc/zynqmp_r5_remoteproc.c     | 954 ++++++++++++++++++
 include/linux/firmware/xlnx-zynqmp.h          |  64 ++
 6 files changed, 1356 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/remoteproc/xilinx,zynqmp-r5-remoteproc.yaml
 create mode 100644 drivers/remoteproc/zynqmp_r5_remoteproc.c
Signature · 1 line
2.17.1