Adds -Wshadow on KBUILD_HOSTCFLAGS
Get series with b4
b4 am 20181023011344.GA6836@WindFlashVersions newest first · linked by author and title
- v2 Latest5 patches 7 repliesIn review
- v14 patches 28 repliesSuperseded
Changes in v2 from the cover letter
1- Makefile change is the last, so there is no extra warnings on building
intermediate commits.
2- Replaced -Wshadow=local with -Wshadow
3- Created macro to accept variable name instead of changing logic in
file2alias.c
4- Drops if/else logic change in asn1_compiler.c
5- Renames variables to meaningful names in vdso2c.h
- The previous logic in file2alias.c will be available on a separated patch
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | x86/vdso: Renames variable to fix shadow warning.arch/ | +7 | 2 replies | |
| 2/5 | kbuild: Removes unnecessary shadowed local variable.scripts/ | +1 | 0 replies | |
| 3/5 | Creates macro to avoid variable shadowingscripts/ | +17 | 5 replies | |
| 4/5 | modpost: Changes parameter name to avoid shadowing.scripts/ | +2 | 0 replies | |
| 5/5 | Adds -Wshadow on KBUILD_HOSTCFLAGSMakefile | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/5] Adds -Wshadow on KBUILD_HOSTCFLAGS
Changes in v2:
1- Makefile change is the last, so there is no extra warnings on building
intermediate commits.
2- Replaced -Wshadow=local with -Wshadow
3- Created macro to accept variable name instead of changing logic in
file2alias.c
4- Drops if/else logic change in asn1_compiler.c
5- Renames variables to meaningful names in vdso2c.h
- The previous logic in file2alias.c will be available on a separated patch
Leonardo Brás (5):
x86/vdso: Renames variable to fix shadow warning.
kbuild: Removes unnecessary shadowed local variable. Creates macro to avoid variable shadowing
modpost: Changes parameter name to avoid shadowing. Adds -Wshadow on KBUILD_HOSTCFLAGS
Makefile | 2 +- arch/x86/entry/vdso/vdso2c.h | 13 +++++++------ scripts/asn1_compiler.c | 2 +- scripts/mod/file2alias.c | 24 +++++++++++++++++------- scripts/mod/modpost.c | 4 ++-- 5 files changed, 28 insertions(+), 17 deletions(-)
Signature · 1 line
2.19.1