Skip to contentSkip to conversation

Adds -Wshadow on KBUILD_HOSTCFLAGS

PATCH In review Leonardo Brás 1 participant 1 message Oct 23, 2018 Kbuild

lore
Share & tools
lore
#0 lore raw

v2 cover Adds -Wshadow on KBUILD_HOSTCFLAGS

Changes in v2:
1- Makefile change is the last, so there is no extra warnings on building
intermediate commits.
2- Replaced -Wshadow=local with -Wshadow
3- Created macro to accept variable name instead of changing logic in
file2alias.c
4- Drops if/else logic change in asn1_compiler.c
5- Renames variables to meaningful names in vdso2c.h

- The previous logic in file2alias.c will be available on a separated patch

Leonardo Brás (5):
x86/vdso: Renames variable to fix shadow warning.
kbuild: Removes unnecessary shadowed local variable. Creates macro to avoid variable shadowing
modpost: Changes parameter name to avoid shadowing. Adds -Wshadow on KBUILD_HOSTCFLAGS

 Makefile                     |  2 +-
 arch/x86/entry/vdso/vdso2c.h | 13 +++++++------
 scripts/asn1_compiler.c      |  2 +-
 scripts/mod/file2alias.c     | 24 +++++++++++++++++-------
 scripts/mod/modpost.c        |  4 ++--
 5 files changed, 28 insertions(+), 17 deletions(-)
Signature · 1 line
2.19.1