Skip to contentSkip to conversation

Adds -Wshadow=local on KBUILD_HOSTCFLAGS

PATCH Superseded Leonardo Brás 2 participants 2 messages Oct 17, 2018 Kbuild

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Adds -Wshadow=local on KBUILD_HOSTCFLAGS

This patchset add -Wshadow=local on KBUILD_HOSTCFLAGS and fixes all code that show this warning.

The third patch was already submitted, but was not merged yet. I like to think it's part of this patchset, but if it was already merged, please ignore it.

Leonardo Brás (4):
Adds -Wshadow=local on KBUILD_HOSTCFLAGS
Renames variable to fix shadow warning.
kbuild: Removes unnecessary shadowed local variable and optimize
testing.
Changes macro usage to avoid shadowing a variable.

 Makefile                     |  2 +-
 arch/x86/entry/vdso/vdso2c.h |  4 ++--
 scripts/asn1_compiler.c      |  7 +++----
 scripts/mod/file2alias.c     | 14 ++++++++------
 4 files changed, 14 insertions(+), 13 deletions(-)
Signature · 1 line
2.19.1
#1 lore raw

Hi Leonardo,

Thanks for the patches.

Quoted 6 lines · Leonardo Brás

This patchset add -Wshadow=local on KBUILD_HOSTCFLAGS and fixes all code that show this warning.

The third patch was already submitted, but was not merged yet. I like to think it's part of this patchset, but if it was already merged, please ignore it.

You can check if it was merged in the maintainers' tree, if it is not there then it is not merged :)

imho, I would prefer if you submitted it as a v2 with an explanation of what changed since v1 (e.g. new commits) or even stating that nothing has changed and you just regrouped it.
Or better, you could also not re-submit it and just point out that this series depends on a previous commit (with a link to it).

Quoted 8 lines

Leonardo Brás (4):
Adds -Wshadow=local on KBUILD_HOSTCFLAGS
Renames variable to fix shadow warning.
kbuild: Removes unnecessary shadowed local variable and optimize
testing.
Changes macro usage to avoid shadowing a variable.

Quoted 6 lines
 Makefile                     |  2 +-
 arch/x86/entry/vdso/vdso2c.h |  4 ++--
 scripts/asn1_compiler.c      |  7 +++----
 scripts/mod/file2alias.c     | 14 ++++++++------
 4 files changed, 14 insertions(+), 13 deletions(-)

I hope this helps.

Regards,
Helen