Skip to content

Turris Omnia LED driver changes

Marek Behún linux-devicetree linux-leds soc 7 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest11 patches 3 repliesApplied
  2. v612 patches 2 repliesSuperseded
  3. v512 patches 19 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v412 patches2 repliesSuperseded
v311 patches5 repliesSuperseded
v211 patches7 repliesSuperseded
v18 patches5 repliesSuperseded

Changes in v7 from the cover letter

- patch 6: fixed documentation comment for the @lock member of struct omnia_leds
- patch 12: dropped, since Gregory applied it on mvebu/dt back in v5.

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/11turris-omnia-mcu-interface.h: Move command execution function to global headerdrivers/platform/cznic/turris-omnia-mcu-base.c drivers/platform/cznic/turris-omnia-mcu.h include/linux/turris-omnia-mcu-interface.h+136 -1310 replies
2/11leds: turris-omnia: Use command execution functions from the MCU driverdrivers/leds/Kconfig drivers/leds/leds-turris-omnia.c+55 -830 replies
3/11turris-omnia-mcu-interface.h: Add LED commands related definitions to global headerinclude/linux/turris-omnia-mcu-interface.h+12 -01 reply
4/11leds: turris-omnia: Use global header for MCU command definitionsdrivers/leds/leds-turris-omnia.c+23 -480 replies
5/11dt-bindings: leds: cznic,turris-omnia-leds: Allow interrupts propertyDocumentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml+8 -00 replies
6/11leds: turris-omnia: Document driver private structuresdrivers/leds/leds-turris-omnia.c+16 -00 replies
7/11leds: turris-omnia: Notify sysfs on MCU global LEDs brightness changedrivers/leds/Kconfig drivers/leds/leds-turris-omnia.c+63 -00 replies
8/11platform: cznic: turris-omnia-mcu: Inform about missing LED panel brightness change interrupt featuredrivers/platform/cznic/turris-omnia-mcu-base.c+1 -00 replies
9/11leds: turris-omnia: Inform about missing LED gamma correction feature in the MCU driverdrivers/leds/leds-turris-omnia.c drivers/platform/cznic/turris-omnia-mcu-base.c+1 -60 replies
10/11leds: turris-omnia: Use dev_err_probe() where appropriatedrivers/leds/leds-turris-omnia.c+16 -340 replies
11/11leds: turris-omnia: Use uppercase first letter in all commentsdrivers/leds/leds-turris-omnia.c+4 -40 replies

Reviews trailers per patch

1 of 11 patches has a Reviewed-by or Acked-by.

PatchKrzysztof Kozlowski
1/11
2/11
3/11
4/11
5/11A-b
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH leds v7 00/11] Turris Omnia LED driver changes

Hello Lee,

this is v7 of Turris Omnia LED driver changes.
v1 to v6 can be found at
https://lore.kernel.org/linux-leds/[email protected]/
https://lore.kernel.org/linux-leds/[email protected]/
https://lore.kernel.org/linux-leds/[email protected]/
https://lore.kernel.org/linux-leds/[email protected]/
https://lore.kernel.org/linux-leds/[email protected]/
https://lore.kernel.org/linux-leds/[email protected]/

Changes since v6:
- patch 6: fixed documentation comment for the @lock member of struct omnia_leds
- patch 12: dropped, since Gregory applied it on mvebu/dt back in v5.

Marek

Marek Behún (11):
turris-omnia-mcu-interface.h: Move command execution function to
global header
leds: turris-omnia: Use command execution functions from the MCU
driver
turris-omnia-mcu-interface.h: Add LED commands related definitions to
global header
leds: turris-omnia: Use global header for MCU command definitions
dt-bindings: leds: cznic,turris-omnia-leds: Allow interrupts property
leds: turris-omnia: Document driver private structures
leds: turris-omnia: Notify sysfs on MCU global LEDs brightness change
platform: cznic: turris-omnia-mcu: Inform about missing LED panel
brightness change interrupt feature
leds: turris-omnia: Inform about missing LED gamma correction feature
in the MCU driver
leds: turris-omnia: Use dev_err_probe() where appropriate
leds: turris-omnia: Use uppercase first letter in all comments

 .../leds/cznic,turris-omnia-leds.yaml         |   8 +
 drivers/leds/Kconfig                          |   2 +
 drivers/leds/leds-turris-omnia.c              | 336 +++++++++---------
 .../platform/cznic/turris-omnia-mcu-base.c    |   3 +
 drivers/platform/cznic/turris-omnia-mcu.h     | 130 -------
 include/linux/turris-omnia-mcu-interface.h    | 148 +++++++-
 6 files changed, 328 insertions(+), 299 deletions(-)
Signature · 1 line
2.45.2