Support RK3528 variant of Rockchip naneng-combphy
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest6 patches 4 repliesApplied
- v46 patches 5 repliesSuperseded
- v35 patches 10 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 5 patches | 2 replies | Superseded | |
| v1 | 5 patches | 6 replies | Superseded |
Changes in v5 from the cover letter
- Collect review tags
- Add extra handling of USB3OTG_CON1 when operating in USB3 mode
- Link to v4: https://lore.kernel.org/all/[email protected]/
Patches in v5 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | dt-bindings: soc: rockchip: Add RK3528 pipe-phy GRF sysconDocumentation/ | +1 | 0 replies | |
| 2/6 | dt-bindings: phy: rockchip: naneng-combphy: Add power-domains propertyDocumentation/ | +3 | 0 replies | |
| 3/6 | dt-bindings: phy: rockchip: naneng-combphy: Add RK3528 variantDocumentation/ | +4 | 0 replies | |
| 4/6 | phy: rockchip: naneng-combphy: Add SoC prefix to register definitionsdrivers/ | +288 | 0 replies | |
| 5/6 | phy: rockchip: naneng-combphy: Add RK3528 supportdrivers/ | +188 | 2 replies | |
| 6/6 | arm64: dts: rockchip: Add naneng-combphy for RK3528arch/ | +24 | 0 replies |
Reviews trailers per patch
5 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Conor Dooley | Krzysztof Kozlowski | Heiko Stuebner | Neil Armstrong |
|---|---|---|---|---|
| 1/6 | A-b | |||
| 2/6 | A-b | |||
| 3/6 | A-b | |||
| 4/6 | R-b | R-b | ||
| 5/6 | R-b | R-b | ||
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v5 0/6] Support RK3528 variant of Rockchip naneng-combphy
Rockchip RK3528 ships a naneng-combphy that operates in either PCIe or USB 3.0 mode. It has a similar control logic to previous generations of naneng-combphy but an apparently different register layout.
This series prepares phy-rockchip-naneng-combphy.c for variants with a different register layout and add RK3528 support.
Testing is done on both Radxa E20C and Radxa Rock 2A with downstream devicetree changes, both USB 3 and PCIe modes are verified with mainline
driver, and reach a reasonable speed.
This series depends on patch "phy: rockchip: naneng-combphy: Enable U3 OTG port for RK3568"[1], and the dts patch depends on v2 of patch "arm64: dts: rockchip: convert rk3528 power-domains to dt-binding constants"[2] to build.
[1]: https://lore.kernel.org/all/[email protected]/
[2]: https://lore.kernel.org/all/[email protected]/
Changed from v4
- Collect review tags
- Add extra handling of USB3OTG_CON1 when operating in USB3 mode
- Link to v4: https://lore.kernel.org/all/[email protected]/
Changed from v3
- Add a dt-binding patch to allow power-domains property when describing Rockchip naneng combphys
- devicetree patch
- Break down long lines
- Sort properties to keep the style consistent
- Add power-domains property to the combphy node
- Link to v3: https://lore.kernel.org/linux-rockchip/[email protected]/
Changed from v2
- phy binding patch
- Fix format issue
- drop review tags
- Link to v2: https://lore.kernel.org/all/20250509004121.36058-2-ziyao@disroot.
org/
Changed from v1
- Collect review tags
- Restyle RK3528 register definitions in the combphy driver
- Drop unused include of phy.h in SoC devicetree
- Link to v1: https://lore.kernel.org/all/20250508134332.14668-2-ziyao@disroo
t.org/
Yao Zi (6):
dt-bindings: soc: rockchip: Add RK3528 pipe-phy GRF syscon
dt-bindings: phy: rockchip: naneng-combphy: Add power-domains property
dt-bindings: phy: rockchip: naneng-combphy: Add RK3528 variant
phy: rockchip: naneng-combphy: Add SoC prefix to register definitions
phy: rockchip: naneng-combphy: Add RK3528 support
arm64: dts: rockchip: Add naneng-combphy for RK3528
.../phy/phy-rockchip-naneng-combphy.yaml | 8 +- .../devicetree/bindings/soc/rockchip/grf.yaml | 1 + arch/arm64/boot/dts/rockchip/rk3528.dtsi | 24 + .../rockchip/phy-rockchip-naneng-combphy.c | 749 +++++++++++------- 4 files changed, 508 insertions(+), 274 deletions(-)
Signature · 1 line
2.50.1